[Acme] Secdir last call review of draft-ietf-acme-authority-token-tnauthlist-07

2021-03-25 Thread Nancy Cam-Winget via Datatracker
Reviewer: Nancy Cam-Winget Review result: Has Nits I have reviewed this document as part of the security directorate's ongoing effort to review all IETF documents being processed by the IESG.  These comments were written primarily for the benefit of the security area directors.  Document editors

Re: [Acme] Secdir last call review of draft-ietf-acme-star-delegation-06

2021-03-25 Thread Thomas Fossati
Hi Russ, On 25/03/2021, 20:15, "Russ Housley" wrote: > Thomas: > > As I said in GitHub, I think the Abstract could be more clear. There > are two key points. First, the certificate contains the identifier that > is delegated. Second, that the third party has control of the private > key, and

Re: [Acme] Secdir last call review of draft-ietf-acme-star-delegation-06

2021-03-25 Thread Russ Housley
Thomas: As I said in GitHub, I think the Abstract could be more clear. There are two key points. First, the certificate contains the identifier that is delegated. Second, that the third party has control of the private key, and the certificate contains the corresponding public key. All of

Re: [Acme] Secdir last call review of draft-ietf-acme-star-delegation-06

2021-03-25 Thread Thomas Fossati
Hi Russ, On 25/03/2021, 19:28, "Russ Housley" wrote: > > You will see my comments in those issues. Thanks very much! We have prepared https://github.com/yaronf/I-D/pull/167/files Could you please review it and see if fixes your remaining concerns? Cheers, t > Russ > > > On Mar 25, 2021, at

Re: [Acme] Secdir last call review of draft-ietf-acme-star-delegation-06

2021-03-25 Thread Russ Housley
Yaron: You will see my comments in those issues. Russ > On Mar 25, 2021, at 10:28 AM, Yaron Sheffer wrote: > > Hi Russ, > > Please see the remaining open issues from your review - we have reopened the > GitHub issues: > > https://github.com/yaronf/I-D/issues/139 >

Re: [Acme] Genart last call review of draft-ietf-acme-star-delegation-06

2021-03-25 Thread Thomas Fossati
Hi Suresh, thanks for your review! On 25/03/2021, 19:10, "Suresh Krishnan via Datatracker" wrote: > > Reviewer: Suresh Krishnan > Review result: Ready with Nits > > I am the assigned Gen-ART reviewer for this draft. The General Area > Review Team (Gen-ART) reviews all IETF documents being

[Acme] Genart last call review of draft-ietf-acme-star-delegation-06

2021-03-25 Thread Suresh Krishnan via Datatracker
Reviewer: Suresh Krishnan Review result: Ready with Nits I am the assigned Gen-ART reviewer for this draft. The General Area Review Team (Gen-ART) reviews all IETF documents being processed by the IESG for the IETF Chair. Please treat these comments just like any other last call comments. For

Re: [Acme] Secdir last call review of draft-ietf-acme-star-delegation-06

2021-03-25 Thread Yaron Sheffer
Hi Russ, Please see the remaining open issues from your review - we have reopened the GitHub issues: https://github.com/yaronf/I-D/issues/139 https://github.com/yaronf/I-D/issues/145 https://github.com/yaronf/I-D/issues/146 https://github.com/yaronf/I-D/issues/147