Re: Re: security issue w/ UIXEditableValue ?

2006-10-17 Thread Martin Marinschek
Ok, this sounds reasonable. The annotations-stuff would of course be great. regards, Martin On 10/16/06, Adam Winer [EMAIL PROTECTED] wrote: Martin, You don't want the validator to be on the component with the values - once you've said that it's cross-component validation, that's just not

Re: [proposal] issue for a commit

2006-10-17 Thread Matthias Wessendorf
I pretty much like the omnibus thing for things like that. We already had that in Trinidad as well, when I did all the renaming and refactoring. -M On 10/14/06, Craig McClanahan [EMAIL PROTECTED] wrote: On 10/14/06, Martin Marinschek [EMAIL PROTECTED] wrote: +1 for applying this rule to all

RE: commandNavigationItem - recommend changing 2 properties

2006-10-17 Thread Pavitra Subramaniam
So shall I create a JIRA issue for this? Thanks - Pavitra -Original Message- From: Simon Lessard [mailto:[EMAIL PROTECTED] Sent: Monday, October 16, 2006 2:40 PM To: adffaces-dev@incubator.apache.org Subject: Re: commandNavigationItem - recommend changing 2 properties In case of train

commandNavigationItem: Propose adding a 'visited' attribute...

2006-10-17 Thread Pavitra Subramaniam
Hello, I would like to propose adding a 'visited' attribute to the commandNavigationItem component. This attribute is relevant only when used within the train component. We currently have an inaccurate way of figuring out if a stop has been visited or not. The renderer gets the row index of

Re: commandNavigationItem: Propose adding a 'visited' attribute...

2006-10-17 Thread Gabrielle Crawford
+1 Jeanne Waldman wrote: +1. This sounds good to me. I've always wanted the model to control visited. Pavitra Subramaniam wrote: Hello, I would like to propose adding a 'visited' attribute to the commandNavigationItem component. This attribute is relevant only when used within the train

making IntegerUtils part of API ?

2006-10-17 Thread Matthias Wessendorf
Hey, any one care to make IntegerUtils from trinidad-impl part of the public API? I like to use it in the api, when working on the validator/converter *overhaul* issue(s). the javadoc says: Class containing various integer utilities. It caches commonly used Integer objects and String

Re: making IntegerUtils part of API ?

2006-10-17 Thread Matthias Wessendorf
+1 On 10/17/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hey, any one care to make IntegerUtils from trinidad-impl part of the public API? I like to use it in the api, when working on the validator/converter *overhaul* issue(s). the javadoc says: Class containing various integer

Re: making IntegerUtils part of API ?

2006-10-17 Thread Jeanne Waldman
+1 Matthias Wessendorf wrote: +1 On 10/17/06, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hey, any one care to make IntegerUtils from trinidad-impl part of the public API? I like to use it in the api, when working on the validator/converter *overhaul* issue(s). the javadoc says: Class

Re: [API] add registerStyleSheet to public Skin API?

2006-10-17 Thread Matthias Wessendorf
+1 On 10/17/06, Jeanne Waldman [EMAIL PROTECTED] wrote: I didn't realize until now that registerStyleSheet wasn't in the public Skin API. It's only in SkinImpl. I'd like to add it to the Skin's APIs so that custom component developers can register skin definitions for their custom components to

Build Error - test failure

2006-10-17 Thread Piyush Hari
Hello, To fix a commandButton ,presently not rendering on a Pocket IE or IE Mobile browser, I changed the following agent capability in pocketie.xml from 'true' to 'false' capability name=-adfinternal-advancedForms value=false/ When I built with tests OFF, it worked fine - button displayed

Re: Build Error - test failure

2006-10-17 Thread Jeanne Waldman
I don't know, but I'd try doing a 'mvn clean' first. Did you do this? What were the golden file diffs? Maybe that will give a clue. Piyush Hari wrote: Hello, To fix a commandButton ,presently not rendering on a Pocket IE or IE Mobile browser, I changed the following agent capability in

Re: Build Error - test failure

2006-10-17 Thread Piyush Hari
I did mvn clean but it did not do any good. -Piyush - Original Message - From: Jeanne Waldman [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: Tuesday, October 17, 2006 7:12 PM Subject: Re: Build Error - test failure I don't know, but I'd try doing a 'mvn clean' first.

Re: Build Error - test failure

2006-10-17 Thread Matthias Wessendorf
surefire plugin is containing. changed something in the (j)unit test(s) ? try to skip the test ... (just for the case ) On 10/17/06, Piyush Hari [EMAIL PROTECTED] wrote: I did mvn clean but it did not do any good. -Piyush - Original Message - From: Jeanne Waldman [EMAIL

Re: Build Error - test failure

2006-10-17 Thread Piyush Hari
surefire plugin is containing. changed something in the (j)unit test(s) ? What do you mean by this ? try to skip the test ... (just for the case ) I did. Skipping tests works fine. But, I want to do the tests as I am submitting the patch for an issue that should include test changes

Re: Build Error - test failure

2006-10-17 Thread Matthias Wessendorf
in the -impl there is a target folder surefire reports test failer some folder like that may contain more infos On 10/17/06, Piyush Hari [EMAIL PROTECTED] wrote: I did not change any test. I guess my change causes some error in the tests already in place. Is there a way to detect that ?

Re: Build Error - test failure

2006-10-17 Thread Piyush Hari
Thanks Mathias. surefire-reports under -impl provided me the key. href was being added twice for a goButton tag when rendered as an input HTML element. Thanks, -Piyush - Original Message - From: Matthias Wessendorf [EMAIL PROTECTED] To: adffaces-dev@incubator.apache.org Sent: