Adding getInstance() to the configurator will either force us to cast in
a bunch of different places or to expose the GlobalConfiguratorImpl's
api to the rest of the world (which I don't want to do because they are
applicable ONLY to global configurator. And it won't lock us into an
API we
Scott,
OK, well, I just went ahead and implemented what I was trying
to say, to see if I'd run into the problems you're describing. I didn't...
(It's possible I've broken something in portlet land - I only tested
the changes in a servlet environment.)
On 12/21/06, Scott O'Bryan [EMAIL
Adam,
Well, you basically implemented one of the solutions I said I didn't
like earlier, but oh well. And there are a number of places you need to
cast. So the concerns are still valid.
The one question I do have is why does getInstance take in an
ExternalContext? I'm assuming it's
BTW- There are some API inconsistencies that need to be documented. The
beginRequest and endRequest methods on the Global configurator object
are designed to be run at the beginning and end of each request phase
(In servlet there is one and in Portlet there are two) where as the
Configurator
On 12/21/06, Scott O'Bryan [EMAIL PROTECTED] wrote:
Adam,
Well, you basically implemented one of the solutions I said I didn't
like earlier, but oh well. And there are a number of places you need to
cast. So the concerns are still valid.
Well, I don't get that claim, as I didn't add a
