Re: Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-30 Thread Adam Winer
Also? I thought that's exactly what we were talking about. Were we talking about anything else? -- Adam On 11/29/06, Qiang Fan [EMAIL PROTECTED] wrote: Adam: Your comment also applies to the following GoLinkRenderer code, right? @Override protected void renderId( FacesContext

Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-29 Thread Scott O'Bryan
Right. Well it's the other cases I'm worried about. I would rather not have the decision in the Trinidad code whether to encode the URL or not. We should always be encoding unless we're certain they are bookmarks. Otherwise, presumably, the app server or portal will handle it accordingly.

Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-29 Thread Adam Winer
Guys, this is ALWAYS a # URL. It's the name attr of a link, and can't possibly be anything more. There are zero portal implications. -- Adam On 11/29/06, Scott O'Bryan [EMAIL PROTECTED] wrote: Right. Well it's the other cases I'm worried about. I would rather not have the decision in the

Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-29 Thread Scott O'Bryan
Thanks Adam. That's what I was looking for. :) Scott Adam Winer wrote: Guys, this is ALWAYS a # URL. It's the name attr of a link, and can't possibly be anything more. There are zero portal implications. -- Adam On 11/29/06, Scott O'Bryan [EMAIL PROTECTED] wrote: Right. Well it's

Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-29 Thread Qiang Fan
Adam: Your comment also applies to the following GoLinkRenderer code, right? @Override protected void renderId( FacesContext context, UIComponent component) throws IOException { if (shouldRenderId(context, component)) { String clientId = getClientId(context, component);

GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-28 Thread Qiang Fan
In GoLinkRenderer class, there is the following method: @Override protected void renderId( FacesContext context, UIComponent component) throws IOException { if (shouldRenderId(context, component)) { String clientId = getClientId(context, component); // For links, these

Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-28 Thread Adam Winer
The value of the attribute on name on GoLink will end up mapping up to href on some other link. So it really is a URI. E.g., you need to use % encoding, not encoding. And id must equal name. -- Adam On 11/28/06, Qiang Fan [EMAIL PROTECTED] wrote: In GoLinkRenderer class, there is the

Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-28 Thread Qiang Fan
Adam: I asked the question because I am working on a patch for encoding URLs in trinidad. I need to know whether to encode the URL as Action URL or Resource URL. For the following scenarios I guess they should all be encoded as Action URL. But I am not sure. Just want to confirm with you. In

Re: Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-28 Thread Adam Winer
Neither; they do not need to be encoded at all, as they are only references within a page. -- Adam On 11/28/06, Qiang Fan [EMAIL PROTECTED] wrote: Adam: I asked the question because I am working on a patch for encoding URLs in trinidad. I need to know whether to encode the URL as Action URL