Re: using trinidad as non-default render-kit

2007-02-28 Thread Adam Winer
Changing how we get the RenderKit would break a lot of code, so I'd be a big -1 on that. There's other parts of the ExtendedRenderKitService contract, and, yes, they'll be hard to enforce in general. Facelets could actually fix this quite elegantly by getting the renderKitId correct in createView

Re: using trinidad as non-default render-kit

2007-02-28 Thread Stefan Podkowinski
This is definitely harder than I expected. What about coupling the RenderingContext with the used RenderingKit? And droping the RenderingContext ThreadLocal based access in favour of FacesContext.getCurrentInstance().getRenderKit().getRenderingContext(). The RenderKitBase could probably extended f

Re: using trinidad as non-default render-kit

2007-02-24 Thread Adam Winer
Stefan, Take a look at the code in ViewHandlerImpl - w/regard to ExtendedRenderKitService and its encodeBegin() method. You don't need to have any direct reference to CoreRenderingContext. (Also, by only mucking with encodeBegin(), this'll fail if the first Trinidad component is rendersChildren

Re: using trinidad as non-default render-kit

2007-02-22 Thread Matthias Wessendorf
I was working a bit on the myfaces 1.2 stack, and I saw the same stack trace like you. I noticed during that, that there wasn't the TrinidadViewHandler in place (in myfaces there is an issue regarding that) not sure, if that info helps :) -M On 2/22/07, Stefan Podkowinski <[EMAIL PROTECTED]> wr

Re: using trinidad as non-default render-kit

2007-02-22 Thread Stefan Podkowinski
Adam, I think the CoreRenderer should take care of initializing the RenderingContext. Facelets will be kind enough to set the rendering kit in the FacesContext, as specified by the renderKitId attribute. Since encodeBegin() will be called in the CoreRenderer impl., we should know which RenderingC

Re: using trinidad as non-default render-kit

2007-02-21 Thread Adam Winer
How are you thinking of tackling this one? I didn't have any great ideas. -- Adam On 2/21/07, Stefan Podkowinski <[EMAIL PROTECTED]> wrote: Created the issue in jira. https://issues.apache.org/jira/browse/ADFFACES-387 I'll hopefully be able to contribute a patch in the coming week, if I have t

Re: using trinidad as non-default render-kit

2007-02-21 Thread Stefan Podkowinski
Created the issue in jira. https://issues.apache.org/jira/browse/ADFFACES-387 I'll hopefully be able to contribute a patch in the coming week, if I have the time for it. On 2/20/07, Adam Winer <[EMAIL PROTECTED]> wrote: Yep, re-reading it, that's exactly what you said. Sorry for the misundersta

Re: using trinidad as non-default render-kit

2007-02-20 Thread Adam Winer
Yep, re-reading it, that's exactly what you said. Sorry for the misunderstanding. So this is a tougher nut to crack. I can imagine some hacks to try to instantiate the rendering context on the fly, but nothing really obvious and bulletproof comes to mind. I think we need a JIRA issue... -- Ad

Re: using trinidad as non-default render-kit

2007-02-20 Thread Stefan Podkowinski
Hi Adam I already have trinidad working with facelets. The problem is it only runs with trinidad as the *default rendering kit*. Defining trinidad as the rendering kit per page does *not* work. Please see my first mail for details. On 2/19/07, Adam Winer <[EMAIL PROTECTED]> wrote: Oh, I see. Y

Re: using trinidad as non-default render-kit

2007-02-19 Thread Adam Winer
Oh, I see. You're using Facelets. You need to configure things a bit differently than without Facelets. Check out: http://wiki.apache.org/myfaces/Facelets_with_Trinidad -- Adam On 2/16/07, Stefan Podkowinski <[EMAIL PROTECTED]> wrote: I just tried the other way around by setting trinidad

Re: using trinidad as non-default render-kit

2007-02-16 Thread Stefan Podkowinski
I just tried the other way around by setting trinidad as default render kit in faces-config.xml and . Afterwards the page renders fine but I'm getting an error on submit: javax.faces.application.ViewExpiredException: viewId:/jsfexamples/examples-simple-1.jsf - View /jsfexamples/examples-simple-1.

Re: using trinidad as non-default render-kit

2007-02-16 Thread Stefan Podkowinski
Hi Adam I just updated to the 1.2 branch but the error is still there: java.lang.IllegalStateException: No RenderingContext at org.apache.myfaces.trinidad.render.CoreRenderer.encodeBegin(CoreRenderer.java:156) at org.apache.myfaces.trinidad.component.UIXComponentBase.encodeBegi

Re: using trinidad as non-default render-kit

2007-02-15 Thread Adam Winer
Stefan, We have a JSF 1.2 branch of Trinidad which is well tested, and contains (nearly) the latest code. http://svn.apache.org/repos/asf/incubator/adffaces/branches/faces-1_2-070201/ The only bad news is that you currently have to build it yourself - we don't have an automated build going for

using trinidad as non-default render-kit

2007-02-15 Thread Stefan Podkowinski
Hello Currently it does not seem to be possible to use trinidad with jsf1.2 ri and facelets and not having trinidad declared as default rendering kit. Removing org.apache.myfaces.trinidad.core from faces-config.xml and adding the render kit declaration to the view root will break the view h