Re: [akka-user] Akka 2.4.5 broken actor creators

Found the problem, an actor creator constructor need to be preferably public, even if the code compiles in Java, under some complex circumstances the class loader cannot see the constructor, in the reproducer posted on the issue https://github.com/akka/akka/issues/20537 I made it private to

Re: [akka-user] Akka 2.4.5 broken actor creators

Yeah, agreed, I deleted that comment once realized the complexity of the problem. On Tuesday, May 17, 2016 at 10:15:30 AM UTC+1, Patrik Nordwall wrote: > > > > On Tue, May 17, 2016 at 10:32 AM, Guido Medina > wrote: > >> Is it safe to say it will be fixed in the next

Re: [akka-user] Akka 2.4.5 broken actor creators

On Tue, May 17, 2016 at 10:32 AM, Guido Medina wrote: > Is it safe to say it will be fixed in the next release? i.e.: 2.4.6? > We must first understand the issue, before promising anything. We can continue the discussion in issue https://github.com/akka/akka/issues/20537 and

Re: [akka-user] Akka 2.4.5 broken actor creators

Thanks Patrik and Konrad for the quick responses. Yes, you are right, there are many ways, from the Java perspective an static class and creation at a method or constructor might be very common. Thanks again for the quick responses. On Tuesday, May 17, 2016 at 9:31:31 AM UTC+1, Patrik Nordwall

Re: [akka-user] Akka 2.4.5 broken actor creators

Is it safe to say it will be fixed in the next release? i.e.: 2.4.6? On Tuesday, May 17, 2016 at 9:28:58 AM UTC+1, Konrad Malawski wrote: > > The change is this: https://github.com/akka/akka/pull/20488 > > On Tue, May 17, 2016 at 9:50 AM, Guido Medina > wrote: > >> I didn't

Re: [akka-user] Akka 2.4.5 broken actor creators

Thanks of noticing this, Guido. The change was introduced in https://github.com/akka/akka/pull/20488 due to a fix of a bug that we have not dared to touch for 1 year just because there is a risk of such regression. There are incredibly many ways you can write such a Creator and we obviously didn't

Re: [akka-user] Akka 2.4.5 broken actor creators

The change is this: https://github.com/akka/akka/pull/20488 On Tue, May 17, 2016 at 9:50 AM, Guido Medina wrote: > I didn't pasted the code because I wasn't sure it was a known issue: > > // Inside an actor supervisor: > > static final class PriceProcessorCreator implements

Re: [akka-user] Akka 2.4.5 broken actor creators

I didn't pasted the code because I wasn't sure it was a known issue: // Inside an actor supervisor: static final class PriceProcessorCreator implements Creator { final StrategySupervisor supervisor; protected PriceProcessorCreator(StrategySupervisor supervisor) {

Re: [akka-user] Akka 2.4.5 broken actor creators

When talking about "that code does not work", please paste the code under discussion. On Tue, May 17, 2016 at 9:39 AM, Guido Medina wrote: > My creators are not working with Akka 2.4.5, they have been working up to > now, > My actor creators are either static classes or

[akka-user] Akka 2.4.5 broken actor creators

My creators are not working with Akka 2.4.5, they have been working up to now, My actor creators are either static classes or standard classes but the methods that use the creator are not static: java.lang.IllegalArgumentException: cannot use non-static local Creator to create actors; make it