[akka-user] No shutDown on Materializer

2017-10-23 Thread Richard Rodseth
I just heard from someone who attended a talk at Reactive Summit that you can leak resources if you are restarting a stream within a host actor, and not shutting down the materializer. I've written most of the stream creation logic and messages using Materializer, not ActorMaterializer, and I see

Re: [akka-user] No shutDown on Materializer

2017-10-23 Thread Konrad “ktoso” Malawski
Hi Richard, Saying that “using Materializer” will cause leaks is somewhat of a weird phrasing, since that sounds just like “using ActorSystem can cause leaks” — well sure, just like “using objects can cause leaks” :-) Let’s step back and analyse where your colleague’s statement came from, and perh

Re: [akka-user] No shutDown on Materializer

2017-10-23 Thread Richard Rodseth
Hi Konrad. I don't believe I used that phrase, but thanks for elaborating. I will digest what you wrote and discuss it. Any thoughts on having a lifecycle method on Materializer vs ActorMaterializer? On Mon, Oct 23, 2017 at 7:39 PM, Konrad “ktoso” Malawski < konrad.malaw...@lightbend.com> wrote:

Re: [akka-user] No shutDown on Materializer

2017-10-23 Thread Konrad “ktoso” Malawski
Adding the shutdown method to the interface you mean? I guess it could be considered, please open a ticket. Technically it would be breaking to do so, but materializers are somewhat special “internal” one might say. -- Cheers, Konrad 'ktoso ' Malawski Akka @ Light

Re: [akka-user] No shutDown on Materializer

2017-10-23 Thread Richard Rodseth
Here you go https://github.com/akka/akka/issues/23837 On Mon, Oct 23, 2017 at 10:22 PM, Konrad “ktoso” Malawski < konrad.malaw...@lightbend.com> wrote: > Adding the shutdown method to the interface you mean? > I guess it could be considered, please open a ticket. > Technically it would be brea

Re: [akka-user] No shutDown on Materializer

2017-10-23 Thread Konrad “ktoso” Malawski
Thanks Richard, sorry if I misread the phrasing you used, read it before coffee time… :) Hope the explanation helps though. -- Cheers, Konrad 'ktoso ' Malawski Akka @ Lightbend On October 24, 2017 at 14:34:07, Richard Rodseth (rrods...@gma