Re: [akka-user] Re: akka-persistence: LocalSnapshotStore ignores timestamps in SnapshotSelectionCriteria

2015-08-03 Thread Stephen McDonald
On Mon, Aug 3, 2015 at 9:39 PM, Patrik Nordwall wrote: > Why do you need to specify the timestamp when you know the sequence number? > While debugging this I also discovered the sequence number was always the same - I don't have enough understanding to know whether this was a bug or a mistake wi

Re: [akka-user] Re: akka-persistence: LocalSnapshotStore ignores timestamps in SnapshotSelectionCriteria

2015-08-03 Thread Patrik Nordwall
On Mon, Aug 3, 2015 at 1:55 PM, Konrad Malawski < konrad.malaw...@typesafe.com> wrote: > Hi there, > sorry I missed this thread previously. > > This change has some background story to it, but perhaps we missed > something when Criteria is used for the delete... > I'll open a bug and have a look a

Re: [akka-user] Re: akka-persistence: LocalSnapshotStore ignores timestamps in SnapshotSelectionCriteria

2015-08-03 Thread Patrik Nordwall
On Mon, Aug 3, 2015 at 1:59 PM, Konrad Malawski < konrad.malaw...@typesafe.com> wrote: > By looking at the patch it seems it's a bug indeed - would you submit the > patch as a PR Stephen? > I opened up an issue, so you could open a PR referencing the issue nr: > https://github.com/akka/akka/issues

Re: [akka-user] Re: akka-persistence: LocalSnapshotStore ignores timestamps in SnapshotSelectionCriteria

2015-08-03 Thread Konrad Malawski
By looking at the patch it seems it's a bug indeed - would you submit the patch as a PR Stephen? I opened up an issue, so you could open a PR referencing the issue nr:  https://github.com/akka/akka/issues/18112 Thanks a lot for finding this and the patch! --  Cheers, Konrad 'ktoso’ Malawski Akka

Re: [akka-user] Re: akka-persistence: LocalSnapshotStore ignores timestamps in SnapshotSelectionCriteria

2015-08-03 Thread Konrad Malawski
Hi there, sorry I missed this thread previously. This change has some background story to it, but perhaps we missed something when Criteria is used for the delete... I'll open a bug and have a look at it. The reason was to abandon the deleteSnapshot(seqNr, timestamp) API, as the timestamp is act

Re: [akka-user] Re: akka-persistence: LocalSnapshotStore ignores timestamps in SnapshotSelectionCriteria

2015-08-03 Thread Patrik Nordwall
Why do you need to specify the timestamp when you know the sequence number? Anyway, has this been reported as an github issue? /Patrik On Mon, Jul 20, 2015 at 5:07 AM, Stephen McDonald wrote: > BTW for anyone who hits this issue and needs an immediate solution, here's > how I fixed it within m

[akka-user] Re: akka-persistence: LocalSnapshotStore ignores timestamps in SnapshotSelectionCriteria

2015-07-19 Thread Stephen McDonald
BTW for anyone who hits this issue and needs an immediate solution, here's how I fixed it within my own project. Couldn't quite subclass as I mentioned earlier, due to LocalSnapshotStore being private, so I made a copy and tweaked as required to support timestamp handling in snapshot criterias: