[clang-tools-extra] r332723 - Silence more truncation warnings; NFC.

2018-05-18 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri May 18 07:53:32 2018 New Revision: 332723 URL: http://llvm.org/viewvc/llvm-project?rev=332723&view=rev Log: Silence more truncation warnings; NFC. Modified: clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp Modified: clang-tools-extra/trunk/unittests/cl

r333653 - Add a new driver mode to dump compiler feature and extension options.

2018-05-31 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu May 31 06:57:09 2018 New Revision: 333653 URL: http://llvm.org/viewvc/llvm-project?rev=333653&view=rev Log: Add a new driver mode to dump compiler feature and extension options. Add the ability to dump compiler option-related information to a JSON file via the -com

Re: r333802 - Add Features.def to module map

2018-06-01 Thread Aaron Ballman via cfe-commits
On Fri, Jun 1, 2018 at 6:52 PM, Eric Fiselier via cfe-commits wrote: > Author: ericwf > Date: Fri Jun 1 15:51:59 2018 > New Revision: 333802 > > URL: http://llvm.org/viewvc/llvm-project?rev=333802&view=rev > Log: > Add Features.def to module map Thank you! I didn't know I had missed that. ~Aaro

[clang-tools-extra] r334013 - Silence a "truncation from double to float" diagnostic in MSVC; NFC.

2018-06-05 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Jun 5 05:14:47 2018 New Revision: 334013 URL: http://llvm.org/viewvc/llvm-project?rev=334013&view=rev Log: Silence a "truncation from double to float" diagnostic in MSVC; NFC. Modified: clang-tools-extra/trunk/unittests/clangd/QualityTests.cpp Modified: clang-

Re: [PATCH] D45679: [clang-tidy] Add ExprMutationAnalyzer, that analyzes whether an expression is mutated within a statement.

2018-06-06 Thread Aaron Ballman via cfe-commits
On Wed, Jun 6, 2018 at 4:40 AM Jonas Toth via Phabricator wrote: > > JonasToth added a comment. > > @shuaiwang I can commit it in 2 hours for you if you want, after my lecture. That's sooner than my "I can commit next week." :-D ~Aaron > > > Repository: > rCTE Clang Tools Extra > > https://re

Re: r334160 - Change return value of trivial visibility check.

2018-06-06 Thread Aaron Ballman via cfe-commits
On Wed, Jun 6, 2018 at 11:24 PM Richard Trieu via cfe-commits wrote: > > Author: rtrieu > Date: Wed Jun 6 20:20:30 2018 > New Revision: 334160 > > URL: http://llvm.org/viewvc/llvm-project?rev=334160&view=rev > Log: > Change return value of trivial visibility check. > > Previous, if no Decl's were

r324890 - Allow the NS, CF, and ObjC attributes to be used with -fdouble-square-bracket-attributes. The syntactic locations for such attributes on ObjC constructs have been specifically chosen to foll

2018-02-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Feb 12 05:38:25 2018 New Revision: 324890 URL: http://llvm.org/viewvc/llvm-project?rev=324890&view=rev Log: Allow the NS, CF, and ObjC attributes to be used with -fdouble-square-bracket-attributes. The syntactic locations for such attributes on ObjC constructs have

Re: [PATCH] D43120: [clang-tidy] New checker for exceptions that are created but not thrown

2018-02-15 Thread Aaron Ballman via cfe-commits
On Thu, Feb 15, 2018 at 4:11 AM, Phabricator via Phabricator wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL325222: [clang-tidy] New checker for exceptions that are > created but not thrown (authored by xazax, committed by ). There's nothi

r325261 - Amend r325256. This change was not properly merged locally before the commit happened.

2018-02-15 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Feb 15 08:28:10 2018 New Revision: 325261 URL: http://llvm.org/viewvc/llvm-project?rev=325261&view=rev Log: Amend r325256. This change was not properly merged locally before the commit happened. Modified: cfe/trunk/lib/Sema/SemaDeclAttr.cpp Modified: cfe/trunk

r325292 - Silence some -Wunused-variable warnings; NFC.

2018-02-15 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Feb 15 12:56:19 2018 New Revision: 325292 URL: http://llvm.org/viewvc/llvm-project?rev=325292&view=rev Log: Silence some -Wunused-variable warnings; NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/E

r325293 - Silence a -Wparentheses warning; NFC.

2018-02-15 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Feb 15 13:03:39 2018 New Revision: 325293 URL: http://llvm.org/viewvc/llvm-project?rev=325293&view=rev Log: Silence a -Wparentheses warning; NFC. Modified: cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Core/CallEvent.cpp

r325520 - Add several more attributes to be parsed in C with [[]] when -fdouble-square-bracket-attributes is specified.

2018-02-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Feb 19 09:32:07 2018 New Revision: 325520 URL: http://llvm.org/viewvc/llvm-project?rev=325520&view=rev Log: Add several more attributes to be parsed in C with [[]] when -fdouble-square-bracket-attributes is specified. Also flags a few attributes that should not be

Re: r325678 - [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

2018-02-21 Thread Aaron Ballman via cfe-commits
On Wed, Feb 21, 2018 at 8:51 AM, Eric Liu via cfe-commits wrote: > Author: ioeric > Date: Wed Feb 21 05:51:27 2018 > New Revision: 325678 > > URL: http://llvm.org/viewvc/llvm-project?rev=325678&view=rev > Log: > [ASTMatchers] isTemplateInstantiation: also match explicit instantiation > declaratio

Re: r325678 - [ASTMatchers] isTemplateInstantiation: also match explicit instantiation declaration.

2018-02-21 Thread Aaron Ballman via cfe-commits
On Wed, Feb 21, 2018 at 8:56 AM, Eric Liu wrote: > Oops, I only saw this after landing the patch. I'll send another one to > update the doc. Sorry about that! No worries! I didn't see the patch until after the commit anyway. Thanks for taking care of it! ~Aaron > > On Wed, Feb 21, 2018 at 2:54

r326036 - Add a C++11 and C2x spelling for the availability attribute in the clang vendor namespace.

2018-02-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat Feb 24 09:16:42 2018 New Revision: 326036 URL: http://llvm.org/viewvc/llvm-project?rev=326036&view=rev Log: Add a C++11 and C2x spelling for the availability attribute in the clang vendor namespace. This attribute has custom parsing rules that previously prevented

r326038 - Add a C++11 and C2x spelling for the objc_bridge_related attribute in the clang vendor namespace.

2018-02-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat Feb 24 09:37:37 2018 New Revision: 326038 URL: http://llvm.org/viewvc/llvm-project?rev=326038&view=rev Log: Add a C++11 and C2x spelling for the objc_bridge_related attribute in the clang vendor namespace. This attribute has custom parsing rules that previously pre

r326052 - Add a C++11 and C2x spelling for the type safety attribute (argument_with_type_tag, pointer_with_type_tag, and type_tag_for_datatype) in the clang vendor namespace.

2018-02-25 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Feb 25 06:01:04 2018 New Revision: 326052 URL: http://llvm.org/viewvc/llvm-project?rev=326052&view=rev Log: Add a C++11 and C2x spelling for the type safety attribute (argument_with_type_tag, pointer_with_type_tag, and type_tag_for_datatype) in the clang vendor nam

r326053 - Add a C2x spelling for the external_source_symbol and internal_linkage attributes in the clang vendor namespace.

2018-02-25 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Feb 25 06:43:45 2018 New Revision: 326053 URL: http://llvm.org/viewvc/llvm-project?rev=326053&view=rev Log: Add a C2x spelling for the external_source_symbol and internal_linkage attributes in the clang vendor namespace. Both of these attributes have existing meani

r326054 - Document why the consumed attributes (consumable, callable_when, et al) are not exposed with a C2x spelling. NFC.

2018-02-25 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Feb 25 06:54:25 2018 New Revision: 326054 URL: http://llvm.org/viewvc/llvm-project?rev=326054&view=rev Log: Document why the consumed attributes (consumable, callable_when, et al) are not exposed with a C2x spelling. NFC. Modified: cfe/trunk/include/clang/Basic

r326055 - Switch the default behavior of the Clang<> spelling to opt-in to the C2x attribute spellings. NFC to the attribute spellings themselves.

2018-02-25 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Feb 25 07:34:17 2018 New Revision: 326055 URL: http://llvm.org/viewvc/llvm-project?rev=326055&view=rev Log: Switch the default behavior of the Clang<> spelling to opt-in to the C2x attribute spellings. NFC to the attribute spellings themselves. The Clang<> spelling

r326057 - Fix a failing assertion with the pointer_with_type_tag attribute when the function the attribute appertains to is variadic.

2018-02-25 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Feb 25 12:28:10 2018 New Revision: 326057 URL: http://llvm.org/viewvc/llvm-project?rev=326057&view=rev Log: Fix a failing assertion with the pointer_with_type_tag attribute when the function the attribute appertains to is variadic. Patch by Joel Denny. Modified:

r326058 - When diagnosing the arguments to alloc_size, report the failing argument using a 1-based index instead of a 0-based index for consistency.

2018-02-25 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Feb 25 12:40:06 2018 New Revision: 326058 URL: http://llvm.org/viewvc/llvm-project?rev=326058&view=rev Log: When diagnosing the arguments to alloc_size, report the failing argument using a 1-based index instead of a 0-based index for consistency. Patch by Joel Denn

r326266 - Improve the way attribute argument printing happens for omitted optional arguments when pretty printing.

2018-02-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Feb 27 15:49:28 2018 New Revision: 326266 URL: http://llvm.org/viewvc/llvm-project?rev=326266&view=rev Log: Improve the way attribute argument printing happens for omitted optional arguments when pretty printing. Patch by Joel Denny. Added: cfe/trunk/test/Sema

Re: r336658 - Fixing builtin __atomic_fetch_min declaration

2018-07-10 Thread Aaron Ballman via cfe-commits
On Tue, Jul 10, 2018 at 8:04 AM, Omer Paparo Bivas via cfe-commits wrote: > Author: opaparo > Date: Tue Jul 10 05:04:04 2018 > New Revision: 336658 > > URL: http://llvm.org/viewvc/llvm-project?rev=336658&view=rev > Log: > Fixing builtin __atomic_fetch_min declaration Can a test case also be commi

r337125 - Run thread safety tests with both lock and capability attributes; NFC to the analysis behavior.

2018-07-15 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Jul 15 05:08:52 2018 New Revision: 337125 URL: http://llvm.org/viewvc/llvm-project?rev=337125&view=rev Log: Run thread safety tests with both lock and capability attributes; NFC to the analysis behavior. Patch thanks to Aaron Puchert. Modified: cfe/trunk/test/

Re: r337470 - [Sema] Add a new warning, -Wmemset-transposed-args

2018-07-23 Thread Aaron Ballman via cfe-commits
On Sat, Jul 21, 2018 at 4:40 PM, Arthur O'Dwyer via cfe-commits wrote: > In this case Clang is complaining about > > memset(complicated-expr, 0, 0); > > which means that transposing the last two arguments would not "fix" > anything. Clang ought to not complain in this case. +1 ~Aaron > It d

r338024 - Allow thread safety annotation lock upgrading and downgrading.

2018-07-26 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jul 26 06:03:16 2018 New Revision: 338024 URL: http://llvm.org/viewvc/llvm-project?rev=338024&view=rev Log: Allow thread safety annotation lock upgrading and downgrading. Patch thanks to Aaron Puchert! Modified: cfe/trunk/lib/Analysis/ThreadSafety.cpp cfe/t

[clang-tools-extra] r334604 - Add a new class to analyze whether an expression is mutated within a statement.

2018-06-13 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Jun 13 07:41:42 2018 New Revision: 334604 URL: http://llvm.org/viewvc/llvm-project?rev=334604&view=rev Log: Add a new class to analyze whether an expression is mutated within a statement. ExprMutationAnalyzer is a generally useful helper that can be used in differen

[clang-tools-extra] r334606 - Reverting r334604 due to failing tests.

2018-06-13 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Jun 13 08:02:34 2018 New Revision: 334606 URL: http://llvm.org/viewvc/llvm-project?rev=334606&view=rev Log: Reverting r334604 due to failing tests. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/31500 Removed: clang-tools-ex

r335048 - Implement semantic checking for __builtin_signbit.

2018-06-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Jun 19 07:36:04 2018 New Revision: 335048 URL: http://llvm.org/viewvc/llvm-project?rev=335048&view=rev Log: Implement semantic checking for __builtin_signbit. r242675 changed the signature for the signbit builtin but did not introduce proper semantic checking to en

r335049 - Reverting due to line ending changes; will reapply after addressing that.

2018-06-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Jun 19 07:53:20 2018 New Revision: 335049 URL: http://llvm.org/viewvc/llvm-project?rev=335049&view=rev Log: Reverting due to line ending changes; will reapply after addressing that. Modified: cfe/trunk/lib/Sema/SemaChecking.cpp cfe/trunk/test/Sema/builtins.c

r335050 - Implement semantic checking for __builtin_signbit.

2018-06-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Jun 19 07:59:11 2018 New Revision: 335050 URL: http://llvm.org/viewvc/llvm-project?rev=335050&view=rev Log: Implement semantic checking for __builtin_signbit. r242675 changed the signature for the signbit builtin but did not introduce proper semantic checking to en

r335841 - Fix the indentation in this documentation to remove a Sphinx warning; NFC.

2018-06-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jun 28 05:00:16 2018 New Revision: 335841 URL: http://llvm.org/viewvc/llvm-project?rev=335841&view=rev Log: Fix the indentation in this documentation to remove a Sphinx warning; NFC. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/includ

r335842 - Correct the code highlighting marker to be Objective-C rather than C++ which fixes a Sphinx build warning; NFC.

2018-06-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jun 28 05:02:38 2018 New Revision: 335842 URL: http://llvm.org/viewvc/llvm-project?rev=335842&view=rev Log: Correct the code highlighting marker to be Objective-C rather than C++ which fixes a Sphinx build warning; NFC. Modified: cfe/trunk/docs/ClangFormatStyle

r335843 - The :option: syntax was generating Sphinx build warnings; switched to double backticks to silence the warning; NFC.

2018-06-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jun 28 05:05:40 2018 New Revision: 335843 URL: http://llvm.org/viewvc/llvm-project?rev=335843&view=rev Log: The :option: syntax was generating Sphinx build warnings; switched to double backticks to silence the warning; NFC. Modified: cfe/trunk/docs/ReleaseNotes

r335896 - Set the line ending of clang.natvis to CRLF.

2018-06-28 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Jun 28 11:03:00 2018 New Revision: 335896 URL: http://llvm.org/viewvc/llvm-project?rev=335896&view=rev Log: Set the line ending of clang.natvis to CRLF. This corresponds to r335889, which does the same thing for llvm.natvis. Modified: cfe/trunk/utils/ClangVisua

Re: r336225 - Fix allocation of Nullability attribute.

2018-07-03 Thread Aaron Ballman via cfe-commits
On Tue, Jul 3, 2018 at 4:30 PM, Erich Keane via cfe-commits wrote: > Author: erichkeane > Date: Tue Jul 3 13:30:34 2018 > New Revision: 336225 > > URL: http://llvm.org/viewvc/llvm-project?rev=336225&view=rev > Log: > Fix allocation of Nullability attribute. > > Existing code always allocates for

[clang-tools-extra] r336301 - Add the cert-msc51-cpp and cert-msc32-c checks.

2018-07-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Jul 4 18:16:31 2018 New Revision: 336301 URL: http://llvm.org/viewvc/llvm-project?rev=336301&view=rev Log: Add the cert-msc51-cpp and cert-msc32-c checks. These checks flag use of random number generators with poor seeds that would possibly lead to degraded random

[clang-tools-extra] r336302 - Adding some documentation changes that were missed in r336301.

2018-07-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Jul 4 18:35:49 2018 New Revision: 336302 URL: http://llvm.org/viewvc/llvm-project?rev=336302&view=rev Log: Adding some documentation changes that were missed in r336301. Added: clang-tools-extra/trunk/docs/clang-tidy/checks/cert-msc51-cpp.rst Modified: clan

Re: r336225 - Fix allocation of Nullability attribute.

2018-07-05 Thread Aaron Ballman via cfe-commits
On Thu, Jul 5, 2018 at 8:54 AM, Keane, Erich wrote: > Unfortunately I'm not sure of a good way to validate this. The only way I > was able to even discover this was with manual instrumentation of D48788. > There is a future opportunity to better instrument the source to find these > things in

r329762 - Introduce a new builtin, __builtin_dump_struct, that is useful for dumping structure contents at runtime in circumstances where debuggers may not be easily available (such as in kernel work)

2018-04-10 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Apr 10 14:58:13 2018 New Revision: 329762 URL: http://llvm.org/viewvc/llvm-project?rev=329762&view=rev Log: Introduce a new builtin, __builtin_dump_struct, that is useful for dumping structure contents at runtime in circumstances where debuggers may not be easily a

r329904 - Allow [[maybe_unused]] on static data members; these are considered variables and the attribute should appertain to them.

2018-04-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Apr 12 05:21:41 2018 New Revision: 329904 URL: http://llvm.org/viewvc/llvm-project?rev=329904&view=rev Log: Allow [[maybe_unused]] on static data members; these are considered variables and the attribute should appertain to them. Patch by S. B. Tam. Modified:

r329924 - Correctly diagnose when a conversion function is declared with a type qualifier in the declaration specifiers rather than in the conversion type id. Fixes PR30595.

2018-04-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Apr 12 09:41:55 2018 New Revision: 329924 URL: http://llvm.org/viewvc/llvm-project?rev=329924&view=rev Log: Correctly diagnose when a conversion function is declared with a type qualifier in the declaration specifiers rather than in the conversion type id. Fixes PR

r329930 - Fix the try_acquire_capability attribute to behave like the other try-lock functions. Fixes PR32954.

2018-04-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Apr 12 10:53:21 2018 New Revision: 329930 URL: http://llvm.org/viewvc/llvm-project?rev=329930&view=rev Log: Fix the try_acquire_capability attribute to behave like the other try-lock functions. Fixes PR32954. Modified: cfe/trunk/lib/Analysis/ThreadSafety.cpp

r330159 - Defer adding keywords to the identifier table until after the language options have been loaded from the AST file.

2018-04-16 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Apr 16 14:07:08 2018 New Revision: 330159 URL: http://llvm.org/viewvc/llvm-project?rev=330159&view=rev Log: Defer adding keywords to the identifier table until after the language options have been loaded from the AST file. This fixes issues with "class" being repor

r330185 - Add checks for format specifiers used by __builtin_dump_struct and added a new specifier for null-terminated constant strings.

2018-04-17 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Apr 17 04:57:47 2018 New Revision: 330185 URL: http://llvm.org/viewvc/llvm-project?rev=330185&view=rev Log: Add checks for format specifiers used by __builtin_dump_struct and added a new specifier for null-terminated constant strings. Patch by Paul Semel. Modified

r330188 - Add modifiers for unsigned char and signed char field printing for __builtin_dump_struct.

2018-04-17 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Apr 17 07:00:06 2018 New Revision: 330188 URL: http://llvm.org/viewvc/llvm-project?rev=330188&view=rev Log: Add modifiers for unsigned char and signed char field printing for __builtin_dump_struct. Patch by Paul Semel. Modified: cfe/trunk/lib/CodeGen/CGBuiltin

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-21 Thread Aaron Ballman via cfe-commits
On Tue, Feb 14, 2017 at 6:05 AM, Marcwell Helpdesk wrote: > The intention of the patch is to extend the functionality of annotations > while utilizing existing infrastructure in the AST and IR as much as > possible. Annotations are indeed a general purpose solution, sufficient for > many use cases

Re: [PATCH] Improved plugin/tool support by expanding an existing attribute

2017-02-28 Thread Aaron Ballman via cfe-commits
On Fri, Feb 24, 2017 at 8:24 AM, Marcwell Helpdesk wrote: > > As interesting the subject of pluggable attributes may be could we please > drop that discussion and focus on the intention of and what the patch > actually does? Two revisions of the patch have been supplied and both should > reason

r297592 - Allow the nonnull attribute to be inherited as a parameter in the redefinition of a function. Fixes PR30828.

2017-03-12 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Mar 12 17:30:07 2017 New Revision: 297592 URL: http://llvm.org/viewvc/llvm-project?rev=297592&view=rev Log: Allow the nonnull attribute to be inherited as a parameter in the redefinition of a function. Fixes PR30828. Patch by Matt Bettinson. Modified: cfe/trun

[clang-tools-extra] r297671 - Add the 'AllowSoleDefaultDtor' and 'AllowMissingMoveFunctions' options to the cppcoreguidelines-special-member-functions check.

2017-03-13 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Mar 13 16:39:00 2017 New Revision: 297671 URL: http://llvm.org/viewvc/llvm-project?rev=297671&view=rev Log: Add the 'AllowSoleDefaultDtor' and 'AllowMissingMoveFunctions' options to the cppcoreguidelines-special-member-functions check. Patch by Florian Gross. Adde

r297882 - Add AST matchers for ObjCProtocolDecl, ObjCCategoryDecl, ObjCMethodDecl, ObjCIvarDecl, and ObjCPropertyDecl.

2017-03-15 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Mar 15 15:14:25 2017 New Revision: 297882 URL: http://llvm.org/viewvc/llvm-project?rev=297882&view=rev Log: Add AST matchers for ObjCProtocolDecl, ObjCCategoryDecl, ObjCMethodDecl, ObjCIvarDecl, and ObjCPropertyDecl. Patch by Dave Lee. Modified: cfe/trunk/docs

r298215 - Cleaning up the IdentifierResolver::iterator class a bit; NFC.

2017-03-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Mar 19 10:15:28 2017 New Revision: 298215 URL: http://llvm.org/viewvc/llvm-project?rev=298215&view=rev Log: Cleaning up the IdentifierResolver::iterator class a bit; NFC. The comment about there being three different forms that Ptr represents was stale. Also, the o

[clang-tools-extra] r298229 - Rename the clang-tidy safety module to be hicpp, for the High-Integrity C++ coding standard from PRQA.

2017-03-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sun Mar 19 12:23:23 2017 New Revision: 298229 URL: http://llvm.org/viewvc/llvm-project?rev=298229&view=rev Log: Rename the clang-tidy safety module to be hicpp, for the High-Integrity C++ coding standard from PRQA. This commit renames all of the safety functionality to

[clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

2017-03-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Mar 21 14:01:17 2017 New Revision: 298421 URL: http://llvm.org/viewvc/llvm-project?rev=298421&view=rev Log: Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros. Patch by Breno Rodrigues Guim

[clang-tools-extra] r298470 - Reverting r298421 due to using a header that's unavailable to all systems and some other post-commit review feedback.

2017-03-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Mar 21 20:08:54 2017 New Revision: 298470 URL: http://llvm.org/viewvc/llvm-project?rev=298470&view=rev Log: Reverting r298421 due to using a header that's unavailable to all systems and some other post-commit review feedback. Modified: clang-tools-extra/trunk/

Re: [clang-tools-extra] r298421 - Prevent cppcoreguidelines-pro-bounds-array-to-pointer-decay from diagnosing array to pointer decay stemming from system macros.

2017-03-21 Thread Aaron Ballman via cfe-commits
On Tue, Mar 21, 2017 at 9:15 PM, Richard Smith wrote: > On 21 March 2017 at 12:01, Aaron Ballman via cfe-commits > wrote: >> >> Author: aaronballman >> Date: Tue Mar 21 14:01:17 2017 >> New Revision: 298421 >> >> URL: http://llvm.org/viewvc/llvm-proj

Re: [PATCH] D59254: [RFC] Implementation of Clang randstruct

2019-07-24 Thread Aaron Ballman via cfe-commits
On Tue, Jul 23, 2019 at 9:17 PM Connor Kuehl via Phabricator wrote: > > connorkuehl added a comment. > > In D59254#1429401 , @jfb wrote: > > > I find it easier to understand the code by looking at the tests. When you > > add tests, please make sure you tes

r366941 - Fix exporting SARIF files from scan-build on Windows.

2019-07-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Jul 24 13:03:27 2019 New Revision: 366941 URL: http://llvm.org/viewvc/llvm-project?rev=366941&view=rev Log: Fix exporting SARIF files from scan-build on Windows. In Perl, -z is defined as checking if a "file has zero size" and makes no mention what it does when giv

Phabricator stability

2019-07-28 Thread Aaron Ballman via cfe-commits
Just an FYI, but it seems like Phabricator may be having some issues this weekend. When trying to perform reviews, a few folks have noticed they get errors about insufficient space to save various internal tables. Additionally, it seems that emails from submitted reviews are not always being genera

Re: r367193 - Buildbot fix for r367190

2019-07-29 Thread Aaron Ballman via cfe-commits
On Mon, Jul 29, 2019 at 3:03 PM Galina Kistanova via cfe-commits wrote: > > Hello Gabor , > > It looks like this commit broke tests on couple builders: > > http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/18867/steps/test-check-all/logs/stdio > http://lab.llvm.org:80

r367312 - Add typedef declaration information to the JSON AST dump.

2019-07-30 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue Jul 30 06:42:19 2019 New Revision: 367312 URL: http://llvm.org/viewvc/llvm-project?rev=367312&view=rev Log: Add typedef declaration information to the JSON AST dump. When dumping a desugared QualType and the type is a type alias, also print out the id for the type

Re: AST for For loop

2019-08-06 Thread Aaron Ballman via cfe-commits
On Tue, Aug 6, 2019 at 11:15 AM Monalisa Rout via cfe-commits wrote: > > Hello, > While dumping the AST for For loop, Why do I get <<>> ?? > > Source code: > void func() > { > for (int i = 0; i < 5; i++) > break; > } > > AST > > FunctionDecl 0x4a4ac10 > line:2:6 > func 'void ()' > `-CompoundSt

r357579 - Fixing a typo; NFC.

2019-04-03 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Apr 3 06:37:56 2019 New Revision: 357579 URL: http://llvm.org/viewvc/llvm-project?rev=357579&view=rev Log: Fixing a typo; NFC. Modified: cfe/trunk/docs/LibASTMatchersReference.html cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/docs/

r357585 - Add a new attribute documentation category for declarations.

2019-04-03 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Apr 3 07:26:32 2019 New Revision: 357585 URL: http://llvm.org/viewvc/llvm-project?rev=357585&view=rev Log: Add a new attribute documentation category for declarations. This moves documentation for some attributes into new categories that are hopefully a bit more c

r357589 - Whitespace and formatting changes; NFC.

2019-04-03 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Apr 3 07:40:00 2019 New Revision: 357589 URL: http://llvm.org/viewvc/llvm-project?rev=357589&view=rev Log: Whitespace and formatting changes; NFC. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL: htt

r361172 - Dump macro expansion information as needed when outputting the AST to JSON.

2019-05-20 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 20 09:46:44 2019 New Revision: 361172 URL: http://llvm.org/viewvc/llvm-project?rev=361172&view=rev Log: Dump macro expansion information as needed when outputting the AST to JSON. Added: cfe/trunk/test/AST/ast-dump-macro-json.c Modified: cfe/trunk/includ

r361265 - Add support for dumping AST comment nodes to JSON.

2019-05-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 21 07:38:29 2019 New Revision: 361265 URL: http://llvm.org/viewvc/llvm-project?rev=361265&view=rev Log: Add support for dumping AST comment nodes to JSON. Added: cfe/trunk/test/AST/ast-dump-comment-json.cpp Modified: cfe/trunk/include/clang/AST/JSONNodeD

r361274 - Do not use the incorrect attribute spelling list index when translating a no_sanitize_foo attribute into a no_sanitize("foo") attribute.

2019-05-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 21 10:24:49 2019 New Revision: 361274 URL: http://llvm.org/viewvc/llvm-project?rev=361274&view=rev Log: Do not use the incorrect attribute spelling list index when translating a no_sanitize_foo attribute into a no_sanitize("foo") attribute. This fixes a crash w

r361325 - Rename identifiers to spell out analyze; NFC.

2019-05-21 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 21 15:43:48 2019 New Revision: 361325 URL: http://llvm.org/viewvc/llvm-project?rev=361325&view=rev Log: Rename identifiers to spell out analyze; NFC. Modified: cfe/trunk/test/SemaCXX/attr-no-sanitize-address.cpp cfe/trunk/test/SemaCXX/attr-no-sanitize-me

r361378 - Clang-formatting the header in advance of other planned changes; NFC.

2019-05-22 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed May 22 06:01:28 2019 New Revision: 361378 URL: http://llvm.org/viewvc/llvm-project?rev=361378&view=rev Log: Clang-formatting the header in advance of other planned changes; NFC. Modified: cfe/trunk/utils/TableGen/TableGenBackends.h Modified: cfe/trunk/utils/Tab

r361652 - Add support for dumping Objective C AST declaration nodes to JSON.

2019-05-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri May 24 10:39:55 2019 New Revision: 361652 URL: http://llvm.org/viewvc/llvm-project?rev=361652&view=rev Log: Add support for dumping Objective C AST declaration nodes to JSON. Added: cfe/trunk/test/AST/ast-dump-decl-json.m Modified: cfe/trunk/include/clang/AS

r361660 - Add JSON dumping tests for ObjC statements; add support for dumping @catch catch-all statements.

2019-05-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri May 24 11:58:29 2019 New Revision: 361660 URL: http://llvm.org/viewvc/llvm-project?rev=361660&view=rev Log: Add JSON dumping tests for ObjC statements; add support for dumping @catch catch-all statements. Added: cfe/trunk/test/AST/ast-dump-stmt-json.m Modified:

r361662 - Adding an explicit triple to this test to appease build bots.

2019-05-24 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri May 24 12:19:00 2019 New Revision: 361662 URL: http://llvm.org/viewvc/llvm-project?rev=361662&view=rev Log: Adding an explicit triple to this test to appease build bots. Modified: cfe/trunk/test/AST/ast-dump-stmt-json.m Modified: cfe/trunk/test/AST/ast-dump-stm

r361766 - When dumping the AST to JSON, dump the argument name to a sizeof pack expression.

2019-05-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 27 07:17:32 2019 New Revision: 361766 URL: http://llvm.org/viewvc/llvm-project?rev=361766&view=rev Log: When dumping the AST to JSON, dump the argument name to a sizeof pack expression. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h cfe/trunk/li

r361767 - When dumping the AST to JSON, dump the declared name of a MemberExpr operand.

2019-05-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 27 07:25:04 2019 New Revision: 361767 URL: http://llvm.org/viewvc/llvm-project?rev=361767&view=rev Log: When dumping the AST to JSON, dump the declared name of a MemberExpr operand. Modified: cfe/trunk/lib/AST/JSONNodeDumper.cpp cfe/trunk/test/AST/ast-du

r361768 - When dumping the AST to JSON, dump whether a function is variadic or not.

2019-05-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 27 07:29:10 2019 New Revision: 361768 URL: http://llvm.org/viewvc/llvm-project?rev=361768&view=rev Log: When dumping the AST to JSON, dump whether a function is variadic or not. Modified: cfe/trunk/lib/AST/JSONNodeDumper.cpp cfe/trunk/test/AST/ast-dump-e

r361769 - When dumping the AST to JSON, dump the type information from a typeid expression with a type operand.

2019-05-27 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 27 07:34:31 2019 New Revision: 361769 URL: http://llvm.org/viewvc/llvm-project?rev=361769&view=rev Log: When dumping the AST to JSON, dump the type information from a typeid expression with a type operand. Modified: cfe/trunk/include/clang/AST/JSONNodeDumpe

Re: [PATCH] D54258: [Clang] Fix pretty printing of CUDA address spaces

2019-06-04 Thread Aaron Ballman via cfe-commits
On Tue, Jun 4, 2019 at 5:37 AM Richard Membarth via Phabricator wrote: > > richardmembarth added a comment. > > Merging in two weeks is fine for me. > > My assumption was that accepted patches are merged into upstream in a timely > manner. > Maybe this is not how it works? Your assumption is cor

Re: AST in JSONFormat

2019-06-08 Thread Aaron Ballman via cfe-commits
On Sat, Jun 8, 2019 at 5:46 AM Monalisa Rout via cfe-commits wrote: > > Hello, > > I am using LibTooling to dump the clangAST in JSON format which is available > in clang 9. > I need the JSON Schema for that. Is it available ?? > > If not wil you be interested in one ?? The JSON format for AST d

r360147 - Allow field offset lookups in types with incomplete arrays within libclang.

2019-05-07 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 7 07:00:49 2019 New Revision: 360147 URL: http://llvm.org/viewvc/llvm-project?rev=360147&view=rev Log: Allow field offset lookups in types with incomplete arrays within libclang. Patch thanks to Jorn Vernee Added: cfe/trunk/test/Index/print-type-size.c Mod

r360155 - Add an explicit triple to this test to hopefully appease the build bots.

2019-05-07 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 7 07:40:37 2019 New Revision: 360155 URL: http://llvm.org/viewvc/llvm-project?rev=360155&view=rev Log: Add an explicit triple to this test to hopefully appease the build bots. Modified: cfe/trunk/test/Index/print-type-size.c Modified: cfe/trunk/test/Index/

r360250 - Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode.

2019-05-08 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed May 8 06:24:36 2019 New Revision: 360250 URL: http://llvm.org/viewvc/llvm-project?rev=360250&view=rev Log: Allow 'static' storage specifier on an out-of-line class member template declaration in MSVCCompat mode. Patch by Soumi Manna. Modified: cfe/trunk/lib/S

r360254 - Allow test to pass after 2030.

2019-05-08 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed May 8 06:42:44 2019 New Revision: 360254 URL: http://llvm.org/viewvc/llvm-project?rev=360254&view=rev Log: Allow test to pass after 2030. Patch by Bernhard M. Wiedemann. Modified: cfe/trunk/test/Modules/fmodules-validate-once-per-build-session.c Modified: cfe

[clang-tools-extra] r360345 - Add the modernize-use-trailing-return check to rewrite function signatures to use trailing return types.

2019-05-09 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu May 9 07:48:17 2019 New Revision: 360345 URL: http://llvm.org/viewvc/llvm-project?rev=360345&view=rev Log: Add the modernize-use-trailing-return check to rewrite function signatures to use trailing return types. Patch by Bernhard Manfred Gruber. Added: clang-

[clang-tools-extra] r360346 - Fixing a link in the release notes to appease the Sphinx bot.

2019-05-09 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu May 9 08:00:38 2019 New Revision: 360346 URL: http://llvm.org/viewvc/llvm-project?rev=360346&view=rev Log: Fixing a link in the release notes to appease the Sphinx bot. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/d

[clang-tools-extra] r360348 - Revert r360345 and r360346, as they are not passing the testbots.

2019-05-09 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu May 9 08:06:41 2019 New Revision: 360348 URL: http://llvm.org/viewvc/llvm-project?rev=360348&view=rev Log: Revert r360345 and r360346, as they are not passing the testbots. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/48063/st

[clang-tools-extra] r360438 - Recommit r360345 with fixes (was reverted in r360348).

2019-05-10 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri May 10 09:24:28 2019 New Revision: 360438 URL: http://llvm.org/viewvc/llvm-project?rev=360438&view=rev Log: Recommit r360345 with fixes (was reverted in r360348). Add the modernize-use-trailing-return check to rewrite function signatures to use trailing return type

[clang-tools-extra] r360451 - Removing an unused member variable; NFC.

2019-05-10 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Fri May 10 11:29:10 2019 New Revision: 360451 URL: http://llvm.org/viewvc/llvm-project?rev=360451&view=rev Log: Removing an unused member variable; NFC. Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseTrailingReturnTypeCheck.cpp Modified: clang-tools-ext

r360622 - Introduce the ability to dump the AST to JSON.

2019-05-13 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 13 14:39:55 2019 New Revision: 360622 URL: http://llvm.org/viewvc/llvm-project?rev=360622&view=rev Log: Introduce the ability to dump the AST to JSON. This adds the -ast-dump=json cc1 flag (in addition to -ast-dump=default, which is the default if no dump forma

r360628 - Removing an unused member variable; NFC.

2019-05-13 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon May 13 15:29:16 2019 New Revision: 360628 URL: http://llvm.org/viewvc/llvm-project?rev=360628&view=rev Log: Removing an unused member variable; NFC. Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h Modified: cfe/trunk/include/clang/AST/JSONNodeDumper.h UR

r360667 - Add a new language mode for C2x; enable [[attribute]] support by default in C2x.

2019-05-14 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Tue May 14 05:09:55 2019 New Revision: 360667 URL: http://llvm.org/viewvc/llvm-project?rev=360667&view=rev Log: Add a new language mode for C2x; enable [[attribute]] support by default in C2x. Modified: cfe/trunk/include/clang/Basic/LangOptions.def cfe/trunk/inc

r370970 - Generate parent context id from Decl* instead of DeclContext*.

2019-09-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Sep 4 13:30:00 2019 New Revision: 370970 URL: http://llvm.org/viewvc/llvm-project?rev=370970&view=rev Log: Generate parent context id from Decl* instead of DeclContext*. Because of multiple inheritance, a DeclContext pointer does not produce the same pointer repres

r370982 - Diagnose _Atomic as a C11 extension.

2019-09-04 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Wed Sep 4 14:01:57 2019 New Revision: 370982 URL: http://llvm.org/viewvc/llvm-project?rev=370982&view=rev Log: Diagnose _Atomic as a C11 extension. Modified: cfe/trunk/lib/Parse/ParseDecl.cpp cfe/trunk/test/Parser/atomic.c cfe/trunk/test/SemaCXX/atomic-type

r371320 - Fixes an assertion while instantiating a template with an incomplete typo-corrected type.

2019-09-07 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Sat Sep 7 13:14:09 2019 New Revision: 371320 URL: http://llvm.org/viewvc/llvm-project?rev=371320&view=rev Log: Fixes an assertion while instantiating a template with an incomplete typo-corrected type. Fixes PR35682. When a template in instantiated with an incomplete t

r372323 - Remove an unsafe member variable that wasn't needed; NFC.

2019-09-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Sep 19 06:51:50 2019 New Revision: 372323 URL: http://llvm.org/viewvc/llvm-project?rev=372323&view=rev Log: Remove an unsafe member variable that wasn't needed; NFC. People use the AST dumping interface while debugging, so it's not safe to assume that a declaration

r372325 - Reverting r372323 because it broke color tests on Linux.

2019-09-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Sep 19 06:59:53 2019 New Revision: 372325 URL: http://llvm.org/viewvc/llvm-project?rev=372325&view=rev Log: Reverting r372323 because it broke color tests on Linux. http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/17919 Modified: cfe/trunk/incl

r372334 - Revert r372325 - Reverting r372323 because it broke color tests on Linux.

2019-09-19 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Thu Sep 19 08:10:51 2019 New Revision: 372334 URL: http://llvm.org/viewvc/llvm-project?rev=372334&view=rev Log: Revert r372325 - Reverting r372323 because it broke color tests on Linux. This corrects the testing issues. Modified: cfe/trunk/include/clang/AST/TextNod

r373213 - Correct function declarations; NFC.

2019-09-30 Thread Aaron Ballman via cfe-commits
Author: aaronballman Date: Mon Sep 30 07:43:52 2019 New Revision: 373213 URL: http://llvm.org/viewvc/llvm-project?rev=373213&view=rev Log: Correct function declarations; NFC. This header is included by C code so the functions need to have a prototype. Also, fix the function definitions so that t

Re: r348858 - Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"

2018-12-11 Thread Aaron Ballman via cfe-commits
On Tue, Dec 11, 2018 at 10:50 AM Stefan Pintilie via cfe-commits wrote: > > Author: stefanp > Date: Tue Dec 11 07:47:57 2018 > New Revision: 348858 > > URL: http://llvm.org/viewvc/llvm-project?rev=348858&view=rev > Log: > Revert "[PowerPC] Make no-PIC default to match GCC - CLANG" > > This reverts

<    1   2   3   4   5   6   7   8   9   10   >