[Spice-devel] [PATCH] support automake = 1.12

2012-08-27 Thread Alon Levy
Requires a single line (sans comments) change to configure.ac in spice-common too, to define the new AM_PROG_AR. --- Pushing without ack per the trivial rule. configure.ac | 3 +++ spice-common | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac

Re: [Spice-devel] [spice-protocol PATCH 0/2] seamless migration support

2012-08-26 Thread Alon Levy
On Wed, Aug 15, 2012 at 10:55:36AM +0300, Yonit Halperin wrote: This patch series, together with the patches following it for spice-common, spice, and spice-gtk, introduce seamless migration support. ACK Series (protocol, common, server). Some spelling errors that can be corrected in a

Re: [Spice-devel] New xrandr multi-mon / arbitrary resolution support issues

2012-08-26 Thread Alon Levy
On Sun, Aug 26, 2012 at 03:48:44PM +0200, Hans de Goede wrote: Hi, As part of integrating the spice-vdagent xrandr patches (done, as there were many other patches pending, so fixes can just be applied on top), I've been testing the new xrandr multi-mon / arbitrary resolution support.

[PATCH] intel_display.c: make acpi_video last in backlight_interfaces

2012-08-26 Thread Alon Levy
ACPI is meant as a fallback, so it should be last. This allows my Lenovo T510 to reach the minimal backlight (switched off), by using intel_backlight instead of acpi. Signed-off-by: Alon Levy al...@redhat.com --- src/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] intel_display.c: make acpi_video last in backlight_interfaces

2012-08-26 Thread Alon Levy
On Sun, Aug 26, 2012 at 03:45:15PM +0100, Chris Wilson wrote: On Sun, 26 Aug 2012 16:31:41 +0200, Alon Levy al...@redhat.com wrote: OK. I'm not sure what would be better for gnome / your-favorite desktop manager. One option is to write an xorg.conf file with this patch. Another

Re: [Spice-devel] Passed trough video card screen access

2012-08-24 Thread Alon Levy
in our management will like them :) 24.08.2012, 00:21, Alon Levy al...@redhat.com: On Thu, Aug 23, 2012 at 11:26:21PM +1000, Boris Morozov wrote:  In the setup you describe windows guest should show two cards,  qxl and the hardware. Does it?  Yes it does, there are two video cards

Re: [Spice-devel] Passed trough video card screen access

2012-08-23 Thread Alon Levy
- Original Message - Hi Борис, Борис Морозов píše v Po 20. 08. 2012 v 15:57 +1000: I wish to migrate from tower cases into nettops to make contribution to ecology by using KVM based virtualization. I made some expiriments that show me that i'am in right way but only one thing

Re: [Spice-devel] Passed trough video card screen access

2012-08-23 Thread Alon Levy
- Original Message - I wish to migrate from tower cases into nettops to make contribution to ecology by using KVM based virtualization. I made some expiriments that show me that i'am in right way but only one thing is obstacle from success. Some days ago on my server i

[Spice-devel] [PATCH xf86-video-qxl] src/qxl_driver: use the new dixScreenSpecificPrivatesSize

2012-08-23 Thread Alon Levy
xserver introduces a new screen specific privates infrastructure, moving the PRIVATE_PIXBUF over there, breaking qxl that was using the wrong dixPrivatesSize to access it - there is a new array of screen specific/not flags, and PRIVATE_PIXBUF is screen specific. xorg-xserver commit:

[Qemu-devel] [PATCH v12 2/2] configure: print spice-protocol and spice-server versions

2012-08-22 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 84fa2c6..02c06aa 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice=yes libs_softmmu=$libs_softmmu $spice_libs

[Qemu-devel] [PATCH v12 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-22 Thread Alon Levy
-server read a new guest set monitors config and notify the client. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- v11-v12: fix build with older spice server (Gerd). configure | 7 hw/qxl.c | 97

Re: [Spice-devel] crash when using spice-client to connect a VM

2012-08-21 Thread Alon Levy
On Tue, Aug 21, 2012 at 12:23:58AM +0200, Dominique Rodrigues wrote: Hi, I have some persistent crashes with last versions of spice/qemu-kvm. See for instance this message in qemu console : QEMU 1.1.1 monitor - type 'help' for more information (qemu) spice_server_add_interface:

Re: [Qemu-devel] [PATCH v9 5/5] (temp) FORTIFY_SOURCES hack

2012-08-21 Thread Alon Levy
On Mon, Aug 20, 2012 at 1:26 PM, Alon Levy al...@redhat.com wrote: --- .gitmodules| 3 +++ compiler.h | 7 +++ spice-protocol | 1 + 3 files changed, 11 insertions(+) create mode 16 spice-protocol I accidentally sent this patch, you can see the (temp) in the title

[Qemu-devel] [PATCH v10 1/4] qxl/update_area_io: guest_bug on invalid parameters

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- v9-v10 Use CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC instead of -D directly, define is created in config-host.h so hw/qxl.[ch] is unchanged except for s/QXL_HAS_IO_MONITORS_CONFIG_ASYNC/CONFIG_QXL_IO_MONITORS_CONFIG_ASYNC (Blue Swirl) No other patches

[Qemu-devel] [PATCH v10 2/4] qxl: disallow unknown revisions

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size

[Qemu-devel] [PATCH v10 4/4] configure: print spice-protocol and spice-server versions

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 84fa2c6..02c06aa 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice=yes libs_softmmu=$libs_softmmu $spice_libs

[Qemu-devel] [PATCH v10 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Alon Levy
-server read a new guest set monitors config and notify the client. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- configure | 7 + hw/qxl.c | 91 -- hw

[Qemu-devel] [PATCH v11 2/4] qxl: disallow unknown revisions

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size

[Qemu-devel] [PATCH v11 1/4] qxl/update_area_io: guest_bug on invalid parameters

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- v10-v11 fixed coding style: space before square bracket. fixed an old instance too. (Gerd) hw/qxl.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..6c48eb9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c

[Qemu-devel] [PATCH v11 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-21 Thread Alon Levy
-server read a new guest set monitors config and notify the client. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- configure | 7 hw/qxl.c | 93 +++--- hw

[Qemu-devel] [PATCH v11 4/4] configure: print spice-protocol and spice-server versions

2012-08-21 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 84fa2c6..02c06aa 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice=yes libs_softmmu=$libs_softmmu $spice_libs

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
Hi, +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). So you are telling me to undo a change that Gerd asked for - could you please at least debate about the merits of both

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
Hi, +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). So you are telling me to undo a change that Gerd asked for - could you please at least debate about the

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
On 08/20/12 10:00, Alon Levy wrote: Hi, +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0 Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC). So you are telling me to undo a change that Gerd asked for - could you please

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
On Sat, Aug 18, 2012 at 07:07:46PM +, Blue Swirl wrote: On Sat, Aug 18, 2012 at 4:16 PM, Alon Levy al...@redhat.com wrote: On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote: On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy al...@redhat.com wrote: Revision bumped to 4 for new IO

[Qemu-devel] [PATCH v8 1/4] qxl/update_area_io: guest_bug on invalid parameters

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- Changes for patchset v7-v8: QXL_IO_MONITORS_CONFIG_ASYNC is defined even when spice-protocol 0.12 (Gerd Hoffman) QXL_HAS_.. is either defined or not, same as other feature definitions (Blue Swirl) Only the third patch qxl: add

[Qemu-devel] [PATCH v8 2/4] qxl: disallow unknown revisions

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size

[Qemu-devel] [PATCH v8 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
-server read a new guest set monitors config and notify the client. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- configure | 3 +++ hw/qxl.c | 66 +++--- hw

[Qemu-devel] [PATCH v8 4/4] configure: print spice-protocol and spice-server versions

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index ff6443e..aae051b 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice=yes libs_softmmu=$libs_softmmu $spice_libs

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
- Original Message - Hi, Maybe revisit upstream spice packaging? spice internal usage of spice-protocol is handled via submodules now. Are there external users, other than qemu? Does it make sense to keep the spice-server / spice-protocol split in the first place? Or

[Qemu-devel] [PATCH v9 1/5] qxl/update_area_io: guest_bug on invalid parameters

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- v8-v9: * split guest_monitors_config to a subsection (Gerd Hoffman) - no change to other patches. hw/qxl.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..6c48eb9 100644 --- a/hw/qxl.c +++ b/hw

[Qemu-devel] [PATCH v9 5/5] (temp) FORTIFY_SOURCES hack

2012-08-20 Thread Alon Levy
--- .gitmodules| 3 +++ compiler.h | 7 +++ spice-protocol | 1 + 3 files changed, 11 insertions(+) create mode 16 spice-protocol diff --git a/.gitmodules b/.gitmodules index eca876f..ba6844b 100644 --- a/.gitmodules +++ b/.gitmodules @@ -19,3 +19,6 @@ [submodule roms/sgabios]

[Qemu-devel] [PATCH v9 3/5] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-20 Thread Alon Levy
-server read a new guest set monitors config and notify the client. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- configure | 3 ++ hw/qxl.c | 91 -- hw

[Qemu-devel] [PATCH v9 2/5] qxl: disallow unknown revisions

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size

[Qemu-devel] [PATCH v9 4/5] configure: print spice-protocol and spice-server versions

2012-08-20 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index ff6443e..aae051b 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice=yes libs_softmmu=$libs_softmmu $spice_libs

Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-18 Thread Alon Levy
On Sat, Aug 18, 2012 at 02:31:32PM +, Blue Swirl wrote: On Fri, Aug 17, 2012 at 3:39 PM, Alon Levy al...@redhat.com wrote: Revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol = 0.12.0. On migration

[Qemu-devel] [PATCH v5 1.2 queue 0/4] QXL_IO_MONITORS_CONFIG_ASYNC + misc

2012-08-17 Thread Alon Levy
Hi Gerd, Rebased on the lastest, redid ifdefs to use a single line, QXL_HAS_IO_MONITORS_CONFIG_ASYNC is 0 by default, 1 if spice-protocol is new enough. Also available at git://people.freedesktop.org/~alon/qemu qxl/pull Alon Levy (4): qxl/update_area_io: guest_bug on invalid

[Qemu-devel] [PATCH v5 1.2 queue 1/4] qxl/update_area_io: guest_bug on invalid parameters

2012-08-17 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..6c48eb9 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1385,6 +1385,18 @@ async_common: QXLCookie *cookie = NULL; QXLRect update

[Qemu-devel] [PATCH v5 1.2 queue 4/4] configure: print spice-protocol and spice-server versions

2012-08-17 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index dbf3af6..af4f68d 100755 --- a/configure +++ b/configure @@ -2657,6 +2657,8 @@ EOF spice=yes libs_softmmu=$libs_softmmu $spice_libs

[Qemu-devel] [PATCH v5 1.2 queue 2/4] qxl: disallow unknown revisions

2012-08-17 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index 6c48eb9..c978f5e 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1797,10 +1797,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size

[Qemu-devel] [PATCH v5 1.2 queue 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-17 Thread Alon Levy
Revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol = 0.12.0. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- configure | 3 +++ hw/qxl.c

[Qemu-devel] [PATCH v6 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-17 Thread Alon Levy
Revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol = 0.12.0. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- Left in one defined, fixed here

[Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-17 Thread Alon Levy
Revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol = 0.12.0. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- Fixed another defined I missed

Re: [Spice-devel] status of my spice-html5 patches

2012-08-16 Thread Alon Levy
On Thu, Aug 16, 2012 at 07:08:14AM -0500, Aric Stewart wrote: Hi all, Just checking on the spice-html5 patches I sent a while ago. I see they have not gotten pushed and am wondering what i should do to help that process. I can push them for you, or anyone else with commit access (like

Re: [Spice-devel] status of my spice-html5 patches

2012-08-16 Thread Alon Levy
on the list. That will be great. About the two patches - I'm getting a complaint from patch git am about a corrupt patch, line 486 and 20 (the first in the bigger patch). Could you please resend the two patches using git format-patch ? -aric On 8/16/12 10:28 AM, Alon Levy wrote: On Thu

Re: [Spice-devel] [PATCH] Implement spice_server_set_exit_on_disconnect to enable an option whereby the spice server shuts down on client disconnect.

2012-08-15 Thread Alon Levy
On Tue, Aug 14, 2012 at 03:43:14PM -0500, Jeremy White wrote: ACK. --- configure.ac |6 +++--- server/reds.c| 14 ++ server/spice-server.syms |4 server/spice.h |1 + 4 files changed, 22 insertions(+), 3 deletions(-) diff

Re: [Spice-devel] [PATCH] Implement spice_server_set_exit_on_disconnect to enable an option whereby the spice server shuts down on client disconnect.

2012-08-15 Thread Alon Levy
On Tue, Aug 14, 2012 at 07:14:06PM -0500, Jeremy White wrote: Hmm. I'm not sure this is complete; in writing the patch for the qxl driver, I realized I wanted to key off of SPICE_SERVER_VERSION, which I want to bump to 0x000b02. But then if I do that, how should I map out spice-server.syms?

Re: [Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-15 Thread Alon Levy
On Wed, Aug 15, 2012 at 10:23:23AM +0200, Gerd Hoffmann wrote: On 08/09/12 16:21, Alon Levy wrote: Revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol = 0.12.0. Patch doesn't apply cleanly to master

Re: [Spice-devel] Help on terminate on disconnect feature needed

2012-08-14 Thread Alon Levy
On Mon, Aug 13, 2012 at 10:38:28AM -0500, Jeremy White wrote: On 08/12/2012 05:10 PM, Alon Levy wrote: On Fri, Aug 10, 2012 at 03:57:05PM -0500, Jeremy White wrote: I've got a need for an Xspice feature whereby the whole X server dies on client disconnect. Basically, we want the Xspice

[PATCH modesetting] drmmode_display: add DRM_MODE_CONNECTOR_VIRTUAL to output_names

2012-08-14 Thread Alon Levy
Added by a7331e5cb, since v3.2-rc1 Signed-off-by: Alon Levy al...@redhat.com --- src/drmmode_display.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 5e38265..e455de9 100644 --- a/src/drmmode_display.c +++ b/src

Re: [Spice-devel] Help on terminate on disconnect feature needed

2012-08-12 Thread Alon Levy
On Fri, Aug 10, 2012 at 03:57:05PM -0500, Jeremy White wrote: I've got a need for an Xspice feature whereby the whole X server dies on client disconnect. Basically, we want the Xspice session to live exactly once, and then die. You are talking about the spice client? As I puzzle through

Re: [Qemu-devel] vga-pci and MMIO BAR

2012-08-10 Thread Alon Levy
On Mon, Aug 06, 2012 at 02:03:59PM +0200, Gerd Hoffmann wrote: On 07/25/12 05:57, Benjamin Herrenschmidt wrote: Hi folks ! Would there be any objection to adding a second MMIO BAR to qemu-vga which mirrors the bochs magic VBE ports ? No. Once done, I'd like to look into doing a

Re: [Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-09 Thread Alon Levy
On Mon, Aug 06, 2012 at 09:31:19AM +0200, Gerd Hoffmann wrote: diff --git a/configure b/configure index cef0a71..5fcd315 100755 --- a/configure +++ b/configure @@ -2630,7 +2630,7 @@ EOF spice_cflags=$($pkg_config --cflags spice-protocol spice-server 2/dev/null)

Re: [Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-09 Thread Alon Levy
On Thu, Aug 09, 2012 at 03:50:12PM +0200, Gerd Hoffmann wrote: On 08/09/12 15:41, Alon Levy wrote: On Mon, Aug 06, 2012 at 09:31:19AM +0200, Gerd Hoffmann wrote: diff --git a/configure b/configure index cef0a71..5fcd315 100755 --- a/configure +++ b/configure @@ -2630,7 +2630,7 @@ EOF

[Qemu-devel] [PATCH v4 1/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-08-09 Thread Alon Levy
Revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1. New io enabled iff spice-server = 0.11.1 spice-protocol = 0.12.0. On migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- configure | 3 +++ hw/qxl.c

[Qemu-devel] [PATCH v4 2/2] configure: print spice-protocol and spice-server versions

2012-08-09 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- configure | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 913077f..2c8399a 100755 --- a/configure +++ b/configure @@ -2638,6 +2638,8 @@ EOF spice=yes libs_softmmu=$libs_softmmu $spice_libs

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-07 Thread Alon Levy
On Fri, Aug 03, 2012 at 08:41:36AM -0500, Anthony Liguori wrote: Alon Levy al...@redhat.com writes: On Wed, Aug 01, 2012 at 02:22:37PM -0500, Anthony Liguori wrote: Andreas Färber afaer...@suse.de writes: Am 30.07.2012 18:19, schrieb Alon Levy: On Mon, Jul 30, 2012 at 09:54:27PM

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-08-03 Thread Alon Levy
On Wed, Aug 01, 2012 at 02:22:37PM -0500, Anthony Liguori wrote: Andreas Färber afaer...@suse.de writes: Am 30.07.2012 18:19, schrieb Alon Levy: On Mon, Jul 30, 2012 at 09:54:27PM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-07-30 at 14:25 +0300, Avi Kivity wrote: [...] why

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-31 Thread Alon Levy
On Tue, Jul 31, 2012 at 08:24:23AM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-07-30 at 18:24 +0200, Alon Levy wrote: On Mon, Jul 30, 2012 at 10:08:07PM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-07-30 at 14:58 +0300, Avi Kivity wrote: Let's balkanize some more

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-31 Thread Alon Levy
On Mon, Jul 30, 2012 at 09:29:01AM -0500, Anthony Liguori wrote: Avi Kivity a...@redhat.com writes: Virtio makes sense for qxl, but for now we have the original pci model which I don't see a reason why it can't work for ppc. I'm sure it can work for PPC given enough effort. But I

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-30 Thread Alon Levy
On Mon, Jul 30, 2012 at 09:54:27PM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-07-30 at 14:25 +0300, Avi Kivity wrote: Right. Cirrus on ppc was used on PReP and Amiga for example though not many people really care about those platforms anymore. I'm not too worried at this point

Re: [Qemu-devel] Cirrus bugs vs endian: how two bugs cancel each other out

2012-07-30 Thread Alon Levy
On Mon, Jul 30, 2012 at 10:08:07PM +1000, Benjamin Herrenschmidt wrote: On Mon, 2012-07-30 at 14:58 +0300, Avi Kivity wrote: Let's balkanize some more then? No, qxl is our paravirt vga, we should improve it instead of spawning new ones (which will be horrible in the eyes of the next

[Spice-devel] [PATCH] server/red_worker: handle_dev_update_area: fail if invalid area

2012-07-29 Thread Alon Levy
--- server/red_worker.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/server/red_worker.c b/server/red_worker.c index 9009462..eb21208 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4589,6 +4589,12 @@ static void red_update_area(RedWorker *worker, const SpiceRect

[Qemu-devel] [PATCH] qxl/update_area_io: guest_bug on invalid parameters

2012-07-29 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 12 1 file changed, 12 insertions(+) diff --git a/hw/qxl.c b/hw/qxl.c index 92e985b..5278541 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1405,6 +1405,18 @@ async_common: QXLCookie *cookie = NULL; QXLRect update

Re: [Spice-devel] Multiple Clients with single spice VM (windows xp or 7)

2012-07-28 Thread Alon Levy
On Fri, Jul 27, 2012 at 08:14:00PM +0530, Avdhoot Dendge - BetterLabs wrote: How i can use Multiple Clients with single spice vm with windows. http://spice-space.org/page/Features/MultipleClients I read this but not able to understand. It doesn't work properly. It will crash the server

[Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-28 Thread Alon Levy
bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1 on migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- configure |2 +- hw/qxl.c | 47

Re: [Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-28 Thread Alon Levy
On Sat, Jul 28, 2012 at 09:01:11AM +, Blue Swirl wrote: +// - this is not a guest io, but a reply, so async_io isn't set. Please use checkpatch.pl to avoid C99 comments. Doh, I must have missed it (I do), will fix, thanks. Alon

[Qemu-devel] [PATCH v3] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-28 Thread Alon Levy
bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1 on migration reissue spice_qxl_monitors_config_async. RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- configure | 2 +- hw/qxl.c | 49

Re: [Spice-devel] [PATCH] red_worker: Fix reference counting for the current frame (drawable) of a stream

2012-07-25 Thread Alon Levy
On Wed, Jul 25, 2012 at 04:50:15PM +0300, Yonit Halperin wrote: After marshalling MSG_STREAM_CREATE, there is no need to ref and unref stream-current before and after completing the sending of the message (correspondingly). The referencing is unnecessary because all the data that is required

Re: [Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-25 Thread Alon Levy
the recalling) and new client. Regards, Yonit. On 07/23/2012 07:33 PM, Alon Levy wrote: bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for spice-server= 0.11.1 RHBZ: 770842 Signed-off-by: Alon Levyal...@redhat.com --- v2: fixed

[Spice-devel] [PATCH] bump version to 0.11.1 for new spice_qxl_monitors_config_async

2012-07-23 Thread Alon Levy
--- configure.ac |2 +- server/spice.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 75a062c..afad73b 100644 --- a/configure.ac +++ b/configure.ac @@ -12,7 +12,7 @@ AC_PREREQ([2.57]) m4_define([SPICE_MAJOR], 0)

[Spice-devel] [PATCH v2] bump version to 0.11.1 for new spice_qxl_monitors_config_async

2012-07-23 Thread Alon Levy
bump current and age since only additions where done. new server library is libspice-server.so.1.2.0 . --- configure.ac |6 +++--- server/spice.h |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 75a062c..bed0464 100644 ---

[Qemu-devel] [PATCH 2/2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-23 Thread Alon Levy
bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1 RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- configure|2 +- hw/qxl.c | 29 - hw/qxl.h |4 trace-events

[Qemu-devel] [PATCH 1/2] qxl: disallow unknown revisions

2012-07-23 Thread Alon Levy
Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index c2dd3b4..3a883ce 100644 --- a/hw/qxl.c +++ b/hw/qxl.c @@ -1785,10 +1785,13 @@ static int qxl_init_common(PCIQXLDevice *qxl) io_size

[Qemu-devel] [PATCH v2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

2012-07-23 Thread Alon Levy
bumps spice-protocol to 0.12.0 for new IO. revision bumped to 4 for new IO support, enabled for spice-server = 0.11.1 RHBZ: 770842 Signed-off-by: Alon Levy al...@redhat.com --- v2: fixed interface_async_complete_io to not complain about unexpected async io. configure|2 +- hw/qxl.c

[Spice-devel] [PATCH v2 1/3] server: don't abort on guest images with missing palettes

2012-07-22 Thread Alon Levy
--- server/red_parse_qxl.c |9 + server/red_worker.c|4 2 files changed, 13 insertions(+) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index e6c2705..daae897 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -328,6 +328,10 @@ static

[Spice-devel] [PATCH v2 2/3] server/red_parse_qxl: disallow zero area bitmaps

2012-07-22 Thread Alon Levy
prevents division by zero later (SIGFPE, Arithmetic exception) in spice-common code, at spice-common/common/canvas_base.c:646 for both client and server (server only upon rendering). --- server/red_parse_qxl.c |4 1 file changed, 4 insertions(+) diff --git a/server/red_parse_qxl.c

[Spice-devel] [PATCH v2 3/3] server/red_worker: release bad drawables

2012-07-22 Thread Alon Levy
--- server/red_worker.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 1fe9ada..aca998b 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4844,11 +4844,10 @@ static int red_process_commands(RedWorker

Re: [Spice-devel] [PATCH v2 0/3] some guest abort removal

2012-07-22 Thread Alon Levy
On Sun, Jul 22, 2012 at 11:39:20AM +0300, Alon Levy wrote: Sorry for the noise, please ignore. There is more work to be done for other type os messages, this only fixes some QXL_CMD_DRAWABLE. But don't let that stop you from acking :) Alon Levy (3): server: don't abort on guest images

[Spice-devel] [PATCH v3 1/2] server/red_parse_qxl: disallow zero area bitmaps

2012-07-22 Thread Alon Levy
prevents division by zero later (SIGFPE, Arithmetic exception) in spice-common code, at spice-common/common/canvas_base.c:646 for both client and server (server only upon rendering). --- server/red_parse_qxl.c |4 1 file changed, 4 insertions(+) diff --git a/server/red_parse_qxl.c

[Spice-devel] [PATCH v3 2/2] server/red_worker: release bad drawables

2012-07-22 Thread Alon Levy
--- server/red_worker.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 5634db5..e239740 100644 --- a/server/red_worker.c +++ b/server/red_worker.c @@ -4843,11 +4843,10 @@ static int red_process_commands(RedWorker

Re: [Spice-devel] [PATCH v3 2/2] server/red_worker: release bad drawables

2012-07-22 Thread Alon Levy
On Sun, Jul 22, 2012 at 01:36:42PM +0300, Yonit Halperin wrote: On 07/22/2012 01:04 PM, Alon Levy wrote: --- server/red_worker.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/server/red_worker.c b/server/red_worker.c index 5634db5..e239740 100644

[Spice-devel] [PATCH] server/red_parse_qxl: red_get_image: fix leaks on bad image

2012-07-22 Thread Alon Levy
--- server/red_parse_qxl.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/server/red_parse_qxl.c b/server/red_parse_qxl.c index deab38f..221c005 100644 --- a/server/red_parse_qxl.c +++ b/server/red_parse_qxl.c @@ -336,7 +336,8 @@ static SpiceImage

[Qemu-devel] [PATCH] configure: fix libcacard check

2012-07-22 Thread Alon Levy
SRC_PATH is undefined during configure run time, it is only defined in makefiles generated by it. Replace with source_path which is defined. Signed-off-by: Alon Levy al...@redhat.com --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH] configure: fix libcacard check

2012-07-22 Thread Alon Levy
On Sun, Jul 22, 2012 at 12:30:27PM +0100, Peter Maydell wrote: On 22 July 2012 12:00, Alon Levy al...@redhat.com wrote: SRC_PATH is undefined during configure run time, it is only defined in makefiles generated by it. Replace with source_path which is defined. There's a (slightly different

[Spice-devel] [PATCH] server/red_parse_qxl: disallow zero area bitmaps

2012-07-20 Thread Alon Levy
prevents division by zero later (SIGFPE, Arithmetic exception) in spice-common code, at spice-common/common/canvas_base.c:646 for both client and server (server only upon rendering). --- server/red_parse_qxl.c |4 1 file changed, 4 insertions(+) diff --git a/server/red_parse_qxl.c

Re: [Spice-devel] [PATCH] server/red_parse_qxl: disallow zero area bitmaps

2012-07-20 Thread Alon Levy
On Fri, Jul 20, 2012 at 07:41:01PM +0300, Alon Levy wrote: prevents division by zero later (SIGFPE, Arithmetic exception) in spice-common code, at spice-common/common/canvas_base.c:646 for both client and server (server only upon rendering). --- server/red_parse_qxl.c |4 1 file

Re: [Spice-devel] [spice-gtk 2/2] Block ctrl+alt+del if the corresponding property is set

2012-07-19 Thread Alon Levy
On Thu, Jul 19, 2012 at 09:40:51AM +0200, Christophe Fergeau wrote: --- gtk/spice-widget.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/gtk/spice-widget.c b/gtk/spice-widget.c index 02bb089..e5c48ed 100644 --- a/gtk/spice-widget.c +++

Re: [Spice-devel] [spice-gtk 1/2] Add SpiceSession::disable-ctrlaltdel

2012-07-19 Thread Alon Levy
On Thu, Jul 19, 2012 at 09:40:50AM +0200, Christophe Fergeau wrote: ACK both with changing nested if to a conjunction (I mistakenly said or, meant and, in the reply to patch 2 I just sent). --- gtk/spice-session-priv.h |5 + gtk/spice-session.c | 30

Re: [Spice-devel] No package 'qcairo' found

2012-07-19 Thread Alon Levy
On Thu, Jul 19, 2012 at 11:20:49AM +0200, Stijn wrote: Hi, I'm trying to install spice according to the user manual, on an ubuntu The user manual is ancient, there is a comment to that affect at the top of the documentation page where I assume you found it, Important: This documentation is

Re: [Spice-devel] [PATCH xf86-qxl 00/27] add arbitrary resolution and multiple monitors

2012-07-17 Thread Alon Levy
but not being as drastic as the recent auto-reindent xorg code base. In general, it would be nice to follow http://www.x.org/wiki/CodingStyle, but if some devs disagree with this change, we can easily skip it. Alon Levy (18): whitespace fix uxa: fix bad argument type from removed index API

Re: [Spice-devel] [PATCH spice-gtk 18/25] spicy: learn to deal with monitors

2012-07-16 Thread Alon Levy
On Fri, Jul 13, 2012 at 12:29:15AM +0200, Marc-André Lureau wrote: --- gtk/spicy.c | 98 ++- 1 file changed, 84 insertions(+), 14 deletions(-) diff --git a/gtk/spicy.c b/gtk/spicy.c index 5ffe3b7..ac2088e 100644 --- a/gtk/spicy.c

Re: [Spice-devel] [PATCH spice-gtk 23/25] Handle MonitorsConfig::max_allowed

2012-07-16 Thread Alon Levy
On Fri, Jul 13, 2012 at 12:29:20AM +0200, Marc-André Lureau wrote: I'm not sure how, but it needs to be damn clear that this value can change during the client lifetime. Documentation change suggested below. --- gtk/channel-display.c | 27 +-- spice-common

Re: [Spice-devel] [PATCH spice-gtk 00/25] support multiple monitors on a single display

2012-07-16 Thread Alon Levy
On Fri, Jul 13, 2012 at 12:28:57AM +0200, Marc-André Lureau wrote: Hi, Ack series. I understand you prefer to keep the patches like this instead of merging (for instance the last one could be merged earlier). I don't mind either way. This is the patch series to support multiple monitors on

Re: [Spice-devel] [PATCH spice-protocol] support multiple monitors on a single display channel

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 09:27:59AM +0200, Christophe Fergeau wrote: On Sat, Jul 14, 2012 at 05:08:24PM +0300, Alon Levy wrote: On Fri, Jul 13, 2012 at 11:39:06AM +0200, Christophe Fergeau wrote: On Thu, Jul 12, 2012 at 07:49:45PM +0300, Alon Levy wrote: Adds on device: RAM

Re: [Spice-devel] [PATCH spice-protocol] support multiple monitors on a single display channel

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 09:27:59AM +0200, Christophe Fergeau wrote: On Sat, Jul 14, 2012 at 05:08:24PM +0300, Alon Levy wrote: On Fri, Jul 13, 2012 at 11:39:06AM +0200, Christophe Fergeau wrote: On Thu, Jul 12, 2012 at 07:49:45PM +0300, Alon Levy wrote: Adds on device: RAM

[Spice-devel] [PATCH v2] server: factor out bitmap_fmt_is_rgb

2012-07-16 Thread Alon Levy
--- server/red_common.h| 10 ++ server/red_parse_qxl.c |6 +- server/red_worker.c| 15 +++ 3 files changed, 18 insertions(+), 13 deletions(-) diff --git a/server/red_common.h b/server/red_common.h index cb7bf71..7b14f9a 100644 --- a/server/red_common.h +++

Re: [Spice-devel] [PATCH v2] server: factor out bitmap_fmt_is_rgb

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 01:22:37PM +0200, Marc-André Lureau wrote: On Mon, Jul 16, 2012 at 10:40 AM, Alon Levy al...@redhat.com wrote: --- server/red_common.h| 10 ++ server/red_parse_qxl.c |6 +- server/red_worker.c| 15 +++ 3 files changed, 18

Re: [Spice-devel] [Spice-commits] spice/enums.h

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 02:26:20PM +0200, Marc-André Lureau wrote: On Fri, Jun 22, 2012 at 4:21 PM, Alon Levy a...@kemper.freedesktop.org wrote: SPICE_MSGC_SMARTCARD_DATA = 101, +SPICE_MSGC_SMARTCARD_HEADER = 101, +SPICE_MSGC_SMARTCARD_ERROR = 101

Re: [Spice-devel] [Spice-commits] spice/enums.h

2012-07-16 Thread Alon Levy
On Mon, Jul 16, 2012 at 02:47:35PM +0200, Marc-André Lureau wrote: On Mon, Jul 16, 2012 at 2:45 PM, Alon Levy al...@redhat.com wrote: On Mon, Jul 16, 2012 at 02:26:20PM +0200, Marc-André Lureau wrote: On Fri, Jun 22, 2012 at 4:21 PM, Alon Levy a...@kemper.freedesktop.org wrote

<    4   5   6   7   8   9   10   11   12   13   >