Re: WARNING in shmem_release_dquot

On Mon, Feb 19, 2024 at 08:26:20PM -0800, Hugh Dickins wrote: > On Mon, 29 Jan 2024, Ubisectech Sirius wrote: > > > Hello. > > We are Ubisectech Sirius Team, the vulnerability lab of China ValiantSec. > > Recently, our team has discovered a issue in Linux kernel > > 6.8.0-rc1-gecb1b8288dc7.

Re: [xfsprogs PATCH] xfs_io/encrypt: support specifying crypto data unit size

On Wed, Nov 15, 2023 at 07:58:46PM -0800, Eric Biggers wrote: > On Thu, Oct 12, 2023 at 11:26:39PM -0700, Eric Biggers wrote: > > From: Eric Biggers > > > > Add an '-s' option to the 'set_encpolicy' command of xfs_io to allow > > exercising the log2_data_unit_size field that is being added to

Re: [f2fs-dev] [PATCH 12/12] xfs use fs_holder_ops for the log and RT devices

On Wed, Aug 02, 2023 at 05:41:31PM +0200, Christoph Hellwig wrote: > Use the generic fs_holder_ops to shut down the file system when the > log or RT device goes away instead of duplicating the logic. > > Signed-off-by: Christoph Hellwig Reviewed-by: Carlos Maiolino Carlos >

Re: [f2fs-dev] [PATCH 12/12] xfs use fs_holder_ops for the log and RT devices

- > 1 file changed, 3 insertions(+), 14 deletions(-) Looks good: Reviewed-by: Carlos Maiolino Carlos > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index d5042419ed9997..338eba71ff8667 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > CC-ing Javier... > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > Hi. > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > >Good day list, > > >

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

On Wed, Sep 01, 2021 at 02:40:57PM +0200, Daniel Kiper wrote: > CC-ing Javier... > > On Mon, Aug 30, 2021 at 01:48:50PM +0200, Carlos Maiolino wrote: > > Hi. > > On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: > > >Good day list, > > >

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

Hi. On Mon, Aug 30, 2021 at 11:18:31AM +0200, Erwan Velu wrote: >Good day list, >Le jeu. 26 août 2021 à 15:26, Carlos Maiolino <[1]cmaiol...@redhat.com> >a écrit : > > [..] > Thanks for spotting this! > >I'm adding the maintainers in CC. C

Re: [PATCH] fs/xfs: Avoid unreadble filesystem if V4 superblock

On Thu, Aug 26, 2021 at 09:54:59AM +0200, Erwan Velu wrote: >I should have cc Carlos Maiolino who authored this patch. >This is now done. > >Le mer. 25 août 2021 à 15:32, Erwan Velu <[1]erwanalia...@gmail.com> a >écrit : > > Commit 8b1e5d1936fff

Re: [OS-BUILD PATCH] [fs] dax: mark tech preview

From: Carlos Maiolino on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1319#note_659995858 Acked-by: Carlos Maiolino (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

Re: [OS-BUILD PATCH] xfs: drop experimental warnings for bigtime and inobtcount

From: Carlos Maiolino on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/1317#note_656130910 Acked-by: Carlos Maiolino (via approve button) ___ kernel mailing list -- kernel@lists.fedoraproject.org To unsubscribe send an email

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

On Thu, Apr 22, 2021 at 05:15:31PM +0200, Javier Martinez Canillas wrote: > Hello Vladimir, > > On 4/22/21 4:56 PM, Vladimir 'phcoder' Serbinenko wrote: > > Filesystems are not mounted in GRUB. This patch will result in GRUB > > outputting a warning on every access to any XFS that has this flag

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

Hi Daniel > > --- a/grub-core/fs/xfs.c > > +++ b/grub-core/fs/xfs.c > > @@ -79,6 +79,7 @@ GRUB_MOD_LICENSE ("GPLv3+"); > > #define XFS_SB_FEAT_INCOMPAT_FTYPE (1 << 0)/* filetype in > > dirent */ > > #define XFS_SB_FEAT_INCOMPAT_SPINODES (1 << 1)/* sparse inode > >

Re: [PATCH] xfs: Print a warning if the filesystem needs to be repaired

lesystem needs repair. Please run a XFS repair > tool")); > +} > + I'm not a grub developer, but from the XFS point of view, this looks fine. Feel free to add my reviewed tag if it makes sense to you: Reviewed-by: Carlos Maiolino -- Carlos ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

[PATCH V2 2/2] fs: Use 64bit type for filesystem timestamp

. These changes enables grub to support dates beyond y2038. Reviewed-by: Javier Martinez Canillas Signed-off-by: Carlos Maiolino --- Changelog: V2: - Update subject adding 'fs:' prefix - Update patch description with more details about the 32 -> 64 bit type convers

[PATCH V2 0/2] Enable bigtime feature for xfs driver

they worked as expected, but again, I am new to grub code, so I might have missed some other corner cases. Carlos Maiolino (2): fs/xfs: Add bigtime support for xfs driver fs: Use 64bit type for filesystem timestamp grub-core/fs/affs.c | 2 +- grub-core/fs/ext2.c | 2 +- grub-core/fs

[PATCH V2 1/2] fs/xfs: Add bigtime support for xfs driver

with files with timestamps up to INT32_MAX (y2038), any file with timestamps bigger than this will overflow the counter, causing grub to show wrong timestamps (not really much difference on current situation). Reviewed-by: Javier Martinez Canillas Signed-off-by: Carlos Maiolino --- Changelog

Re: [PATCH 0/2] Enable bigtime feature for xfs driver

On Tue, Mar 23, 2021 at 07:09:01PM +0100, Daniel Kiper wrote: > Hey Carlos, > > On Tue, Mar 23, 2021 at 02:29:57PM +0100, Carlos Maiolino wrote: > > Hello. > > First, my apologies if I messed up with code styling here somehow, it's the > > first time I send a patch t

[PATCH 0/2] Enable bigtime feature for xfs driver

timestamp handling. I tested these patches on both x86_64 and x86_32 and in my testing they worked as expected, but again, I am new to grub code, so I might have missed some corner cases. Carlos Maiolino (2): Add bigtime support for xfs driver Use 64bit type for filesystem timestamp grub-core/fs

[PATCH 2/2] Use 64bit type for filesystem timestamp

y2038. Signed-off-by: Carlos Maiolino --- grub-core/fs/affs.c | 2 +- grub-core/fs/ext2.c | 2 +- grub-core/fs/fat.c | 4 ++-- grub-core/fs/hfs.c | 2 +- grub-core/fs/hfsplus.c | 2 +- grub-core/fs/iso9660.c | 6 +++--- grub-core/fs/nilfs2

[PATCH 1/2] Add bigtime support for xfs driver

with files with timestamps up to INT32_MAX (y2038), any file with timestamps bigger than this will overflow the counter, causing grub to show wrong timestamps (not really much difference on current situation). Signed-off-by: Carlos Maiolino --- grub-core/fs/xfs.c | 69

Re: [OS-BUILD PATCH] [redhat] New configs in fs/xfs

From: Carlos Maiolino on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/738#note_531140352 >[1]Don Zickus [2]commented: > >[3]@cmaiolino can you ack these change then? Oh, sure. How can I ack this MR without using the web interface? Is it possible? hmmm

Re: [OS-BUILD PATCH] [redhat] New configs in fs/xfs

From: Carlos Maiolino on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/738#note_530700566 Ok, so, looks like gitlab interface tricked me... I haven't seen the chunk adding the config option above, only the chunk removing it. So, for that case, yes, V4 support should stay

Re: [OS-BUILD PATCH] [redhat] New configs in fs/xfs

From: Carlos Maiolino on gitlab.com https://gitlab.com/cki-project/kernel-ark/-/merge_requests/738#note_530696464 So, this MR has been created months ago, that explains why I didn't even know about this until now. I think I didn't even have a gitlab account that time. Since Brian and I

Re: [PATCH] fs: xfs: xfs_log: Change return type from int to void

c:4886:7-12: Unneeded variable: "error". Return > "0" on line 4926 > > Signed-off-by: Hariprasad Kelam Looks ok. You can add: Reviewed-by: Carlos Maiolino > --- > fs/xfs/xfs_log.c | 8 ++-- > fs/xfs/xfs_log.h | 2 +- > fs/

Re: [PATCH V2] xfs: libxfs: move xfs_perag_put late

speaker too, but I believe it should be "is read and written after..." But, for the code itself, you can add: Reviewed-by: Carlos Maiolino Cheers > > Signed-off-by: Pan Bian > --- > V2: correct the commit log > --- > fs/xfs/libxfs/xfs_alloc.c | 2 +- >

Re: [PATCH V2] xfs: libxfs: move xfs_perag_put late

speaker too, but I believe it should be "is read and written after..." But, for the code itself, you can add: Reviewed-by: Carlos Maiolino Cheers > > Signed-off-by: Pan Bian > --- > V2: correct the commit log > --- > fs/xfs/libxfs/xfs_alloc.c | 2 +- >

Re: [PATCH] xfs: libxfs: move xfs_perag_put late

On Sat, Nov 24, 2018 at 05:44:20PM +0800, Pan Bian wrote: > The function xfs_alloc_get_freelist calls xfs_perag_put to drop the > reference. In this case, pag may be released. However, > pag->pagf_btreeblks is read and write after the put operation. This may > result in a use-after-free bug. This

Re: [PATCH] xfs: libxfs: move xfs_perag_put late

On Sat, Nov 24, 2018 at 05:44:20PM +0800, Pan Bian wrote: > The function xfs_alloc_get_freelist calls xfs_perag_put to drop the > reference. In this case, pag may be released. However, > pag->pagf_btreeblks is read and write after the put operation. This may > result in a use-after-free bug. This

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Mon, Jul 30, 2018 at 11:49 AM, Stefan Wahren wrote: > Am 30.07.2018 um 11:43 schrieb Carlos Maiolino: >> On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren >> wrote: >>> i think easiest the way would be to get a recent Raspbian Lite ( >>> https://www.r

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Mon, Jul 30, 2018 at 11:34 AM, Stefan Wahren wrote: > Hi Carlos, > > Am 30.07.2018 um 11:25 schrieb Carlos Maiolino: >> >> On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren >> wrote: >>> >>> Hi Carlos, >>> >>> >>> Am 30.

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Mon, Jul 30, 2018 at 11:13 AM, Stefan Wahren wrote: > Hi Carlos, > > > Am 30.07.2018 um 11:08 schrieb Carlos Maiolino: >> >> On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote: >>> >>> On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wr

Re: [PATCH] staging/vc04_services: Use __user annotation for user-space pointers

On Mon, Jul 30, 2018 at 10:58 AM, Greg KH wrote: > On Tue, Jul 24, 2018 at 10:32:17AM +0200, Carlos Maiolino wrote: >> Fix several sparse warnings regarding different address space >> assignments, like example below, by properly annotating pointers >> expected to carry

[PATCH] staging/vc04_services: Use __user annotation for user-space pointers

Fix several sparse warnings regarding different address space assignments, like example below, by properly annotating pointers expected to carry user space addresses. warning: incorrect type in argument 1 (different address spaces) Signed-off-by: Carlos Maiolino --- I'm not subscribed

Re: [PATCH v2 0/4] vfs: track per-sb writeback errors and report them via fsinfo()

xfstest for it, since the syscall is still quite new. Once that > goes in and we get fsinfo support in xfs_io, it should be rather > trivial to roll a testcase for this. > Whole patch sounds fine, you can add: Reviewed-by: Carlos Maiolino Cheers > Al, if this looks ok, could y

Re: [PATCH v2 0/4] vfs: track per-sb writeback errors and report them via fsinfo()

xfstest for it, since the syscall is still quite new. Once that > goes in and we get fsinfo support in xfs_io, it should be rather > trivial to roll a testcase for this. > Whole patch sounds fine, you can add: Reviewed-by: Carlos Maiolino Cheers > Al, if this looks ok, could y

Re: [PATCH] vfs: remove iterate_supers_type

On Thu, May 17, 2018 at 11:47:37AM -0400, Jeff Layton wrote: > From: Jeff Layton <jlay...@redhat.com> > > Nothing calls this. > > Signed-off-by: Jeff Layton <jlay...@redhat.com> looks like there are no reviews here yet, and it looks good to me, so, feel free t

Re: [PATCH] vfs: remove iterate_supers_type

On Thu, May 17, 2018 at 11:47:37AM -0400, Jeff Layton wrote: > From: Jeff Layton > > Nothing calls this. > > Signed-off-by: Jeff Layton looks like there are no reviews here yet, and it looks good to me, so, feel free to add. Reviewed-by: Carlos Maiolino > --- > fs

Re: [PATCH 1/1] extend BLKRRPART to update the readable size of optical media

On Fri, Feb 23, 2018 at 11:14:41AM +0100, Carlos Maiolino wrote: > On Thu, Feb 22, 2018 at 01:00:16PM -0600, Steve Kenton wrote: > > The readable size of new, factory blank, optical media can change via user > > space ioctl(SG_IO) commands to format overwritable media

Re: [PATCH v7 21/22] xfs: minimal conversion to errseq_t writeback error reporting

On Fri, Jun 16, 2017 at 03:34:26PM -0400, Jeff Layton wrote: > Just check and advance the data errseq_t in struct file before > before returning from fsync on normal files. Internal filemap_* > callers are left as-is. > Looks good. Reviewed-by: Carlos Maiolino <cmaiol...@redhat

Re: [PATCH v7 21/22] xfs: minimal conversion to errseq_t writeback error reporting

On Fri, Jun 16, 2017 at 03:34:26PM -0400, Jeff Layton wrote: > Just check and advance the data errseq_t in struct file before > before returning from fsync on normal files. Internal filemap_* > callers are left as-is. > Looks good. Reviewed-by: Carlos Maiolino <cmaiol...@redhat

Re: [PATCH v7 05/22] jbd2: don't clear and reset errors after waiting on writeback

insertions(+), 15 deletions(-) > I'm not too experienced with jbd2 internals, but this patch is clear enough: Reviewed-by: Carlos Maiolino <cmaiol...@redhat.com> -- Carlos

Re: [PATCH v7 05/22] jbd2: don't clear and reset errors after waiting on writeback

insertions(+), 15 deletions(-) > I'm not too experienced with jbd2 internals, but this patch is clear enough: Reviewed-by: Carlos Maiolino <cmaiol...@redhat.com> -- Carlos -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord..

Re: [PATCH v7 04/22] buffer: set errors in mapping at the time that the error occurs

--- > fs/buffer.c | 20 +--- > fs/gfs2/lops.c | 2 +- > include/linux/buffer_head.h | 1 + > 3 files changed, 15 insertions(+), 8 deletions(-) > Reviewed-by: Carlos Maiolino <cmaiol...@redhat.com> > diff --git a/fs/buffer.c b/fs/buffer.

Re: [PATCH v7 04/22] buffer: set errors in mapping at the time that the error occurs

--- > fs/buffer.c | 20 +--- > fs/gfs2/lops.c | 2 +- > include/linux/buffer_head.h | 1 + > 3 files changed, 15 insertions(+), 8 deletions(-) > Reviewed-by: Carlos Maiolino <cmaiol...@redhat.com> > diff --git a/fs/buffer.c b/fs/buffer.

Re: [PATCH v7 01/22] fs: remove call_fsync helper function

t; 3 files changed, 2 insertions(+), 8 deletions(-) > > 2.13.0 If it's worth to have one more reviewer, you can add: Reviewed-by: Carlos Maiolino <cmaiol...@redhat.com> > -- Carlos -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of

Re: [PATCH v7 01/22] fs: remove call_fsync helper function

t; 3 files changed, 2 insertions(+), 8 deletions(-) > > 2.13.0 If it's worth to have one more reviewer, you can add: Reviewed-by: Carlos Maiolino <cmaiol...@redhat.com> > -- Carlos

Re: [PATCH RFC] vfs: add mount umount logs

On Thu, May 18, 2017 at 06:08:04PM +0800, Anand Jain wrote: > By looking at the logs we should be able to know when was the FS > mounted and unmounted and the options used, so to help forensic > investigations. > > Signed-off-by: Anand Jain > --- > You may want to know

Re: [PATCH] staging: rtl8188eu: Fix coding style errors

Yes, thanks for the heads up. I'll try to avoid such mistakes in the next patches On Mon, Oct 17, 2016 at 6:29 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Mon, Oct 17, 2016 at 06:17:21PM +0200, Carlos Maiolino wrote: >> >> --- >> >> drivers/staging/r

Re: [PATCH] staging: rtl8188eu: Fix coding style errors

>> --- >> drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 28 >> +-- >> 1 file changed, 14 insertions(+), 14 deletions(-) > > Any reason you didn't use scripts/get_maintainer.pl to cc: the relevant > maintainers and developers of this code? > > thanks, > > greg k-h Not

[PATCH] staging: rtl8188eu: Fix coding style errors

Fix coding style errors reported by checkpatch.pl, specifically: ERROR: space prohibited before that ',' (ctx:WxW) This patch get rid of all "ERROR" messages from checkpatch.pl for this file Signed-off-by: Carlos Maiolino <cmaiolin...@gmail.com> --- drivers/stagin

Re: [PATCH 0/3] staging: ks7010: Coding style fixes

at 10:16:00PM +0200, Carlos Maiolino wrote: >> A small patchset fixing some coding style errors identified by checkpatch.pl >> >> Greg. I splitted the single patch into 3 different patches now, hope I set it >> right now :) >> >> Also added a blank line before the s

[PATCH 3/3] staging: ks7010: add missing blank lines

Use blank lines to separate variable declarations from statements, fixing the following checkpatch.pl issue: WARNING: Missing a blank line after declarations Signed-off-by: Carlos Maiolino <cmaiolin...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 6 ++ 1 file changed, 6 inse

[PATCH 2/3] staging: ks7010: Fix coding style spacing issues

parenthesis ')' ERROR: exactly one space required after that #ifdef ERROR: space prohibited after that '&' (ctx:WxW) Signed-off-by: Carlos Maiolino <cmaiolin...@gmail.com> --- drivers/staging/ks7010/ks_hostif.c | 202 ++--- 1 file changed, 101 insertio

[PATCH 1/3] staging: ks7010: Fix conditional statements coding style

Fix coding style issues in if statements braces, specifically: WARNING: braces {} are not necessary for single statement blocks WARNING: braces {} are not necessary for any arm of this statement CHECK: braces {} should be used on all arms of this statement Signed-off-by: Carlos Maiolino

[PATCH 0/3] staging: ks7010: Coding style fixes

A small patchset fixing some coding style errors identified by checkpatch.pl Greg. I splitted the single patch into 3 different patches now, hope I set it right now :) Also added a blank line before the signed-off. Cheers Carlos Maiolino (3): staging: ks7010: Fix conditional statements

[PATCH] staging: ks7010: Fix coding style errors

after that #ifdef WARNING: Missing a blank line after declarations ERROR: space prohibited after that '&' (ctx:WxW) WARNING: braces {} are not necessary for single statement blocks CHECK: No space is necessary after a cast Signed-off-by: Carlos Maiolino <cmaiolin...@gmail.com> --- drive

Re: [PATCH v4 0/6] Add alignment check for DAX mount

ches looks good to me, the conflicts with Dan's patches, also should not cause any semantics change of this patchset, you can add: Reviewed-by: Carlos Maiolino <cmaiol...@redhat.com> Cheers > --- > block/ioctl.c | 30 > fs/block_dev.c | 96 > +++

Re: [PATCH v4 0/6] Add alignment check for DAX mount

ches looks good to me, the conflicts with Dan's patches, also should not cause any semantics change of this patchset, you can add: Reviewed-by: Carlos Maiolino Cheers > --- > block/ioctl.c | 30 > fs/block_dev.c | 96 > +

Re: [patch] direct-io: propagate -ENOSPC errors

This looks good to me. Reviewed-by: Carlos Maiolino <cmaiol...@redhat.com> On Mon, Mar 14, 2016 at 05:10:00PM -0400, Jeff Moyer wrote: > dio_bio_complete turns all errors into -EIO. This is historical, > since you used to only get 1 bit precision for errors (BIO_UPTODATE). >

Re: [patch] direct-io: propagate -ENOSPC errors

This looks good to me. Reviewed-by: Carlos Maiolino On Mon, Mar 14, 2016 at 05:10:00PM -0400, Jeff Moyer wrote: > dio_bio_complete turns all errors into -EIO. This is historical, > since you used to only get 1 bit precision for errors (BIO_UPTODATE). > Now that we get actual error

Re: [Darktable-users] Darktable-users Digest, Vol 64, Issue 3

h fetches only the requested branch (and merges it). > > Carlos Maiolino <cmaiolin...@gmail.com> writes: > > > Tags can also be pulled with git pull. > > > > "git fetch" will pull all changes from a repository, but not apply > > them to your local branch, w

Re: [Darktable-users] Darktable-users Digest, Vol 64, Issue 3

Tags can also be pulled with git pull. "git fetch" will pull all changes from a repository, but not apply them to your local branch, while, "git pull" will pull only the changes from the remote branch that is being tracked by you local branch and, apply the changes locally. On Wed, Mar 2, 2016,

Re: [Darktable-users] Exported photo without applying all changes in the stack history

On Sun, Feb 14, 2016, 14:15 Patrick Shanahan <p...@wahoo.no-ip.org> wrote: > * Carlos Maiolino <cmaiolin...@gmail.com> [02-14-16 07:49]: > > Ok, I finally figured out what is happening: > > > > For my understanding, I can't compare the pictures from darkta

Re: [Darktable-users] Exported photo without applying all changes in the stack history

for the help until now On Sun, Feb 14, 2016 at 12:57 PM, Carlos Maiolino <cmaiolin...@gmail.com> wrote: > BTW Patrick, how are you comparing both images? > > I've been using Image Viewer to open jpeg files, not sure if this make > much difference. But I got a bit annoyed with

Re: [Darktable-users] Exported photo without applying all changes in the stack history

different images from the one showed inside darktable darkroom and the one exported, showed with Image viewer On Sun, Feb 14, 2016 at 12:25 PM, Carlos Maiolino <cmaiolin...@gmail.com> wrote: > On Sun, Feb 14, 2016 at 5:14 AM, Patrick Shanahan <p...@wahoo.no-ip.org> > wrote: &g

Re: [Darktable-users] Exported photo without applying all changes in the stack history

On Sun, Feb 14, 2016 at 5:14 AM, Patrick Shanahan <p...@wahoo.no-ip.org> wrote: > * Carlos Maiolino <cmaiolin...@gmail.com> [02-13-16 19:54]: >> Definitely something is wrong. I think darktable is not applying >> denoise modules on top of some other module. I don't

[Darktable-users] Exported photo without applying all changes in the stack history

the changes darktable made in the photography. I published the photo here: https://500px.com/photo/140190983/colorful-duck-by-carlos-maiolino (I apologize if I'm not supposed to send links to the list). And, if somebody is interested, I can provide the RAW file together with the .xmp file. FWIW

Re: [Darktable-users] Exported photo without applying all changes in the stack history

.no-ip.org> wrote: > * Carlos Maiolino <cmaiolin...@gmail.com> [02-13-16 18:14]: >> Hi folks, I recently started to use darktable 2.0.0, and I just >> exported a photography I've been working on, and the resulting JPEG >> was very different from what I was seeing in

Re: [Darktable-users] Exported photo without applying all changes in the stack history

> > I am using darktable-2.1+git1455303561.2c8c073-1.1.x86_64 from git > packaged by darix for openSUSE Tumbleweed. > > The exported image on my display looks to me identical to your 500px > image. And I see where both noise reduction instances changed your image. > The output I generated is at:

Re: [Darktable-users] Exported photo without applying all changes in the stack history

> Anyway, thanks, I'll take a look on my configs and also test the same > version you're using. meh, I just cloned the darktable git tree and tested on it, same thing for me, RAW image and exported jpeg are different, mainly related to denoise. I'm not sure if it's my monitor, but I'll check my

Re: [Darktable-users] Exported photo without applying all changes in the stack history

of this new one, and I got the same problem. Denoise module applied to the image, image exported didn't have the denoise applied On Sun, Feb 14, 2016 at 1:24 AM, Patrick Shanahan <p...@wahoo.no-ip.org> wrote: > * Carlos Maiolino <cmaiolin...@gmail.com> [02-13-16 19:14]: >&

Re: [Darktable-users] Exported photo without applying all changes in the stack history

out what.. Anyway, time to get some sleep. On Sun, Feb 14, 2016 at 1:52 AM, Carlos Maiolino <cmaiolin...@gmail.com> wrote: > Definitely something is wrong. I think darktable is not applying > denoise modules on top of some other module. I don't have time to > figure out no

Re: [Cluster-devel] [PATCH] Add myself (Bob Peterson) as a maintainer of GFS2

This looks good to me, you can consider it Reviewed-by: Carlos Maiolino cmaiol...@redhat.com Cheers On Mon, Feb 16, 2015 at 09:20:56AM -0500, Bob Peterson wrote: Hi, This patch adds Bob Peterson as a maintainer of the GFS2 file system. It also changes the development repository

Re: [RHEL6 PATCH 2/2] ext4: don't leave i_crtime.tv_sec uninitialized

How sweet, someone who doesn't know how to configure git to not spam public mailing lists... Sorry, new box, forgot to disable it on git :) -- Carlos -- To unsubscribe from this list: send the line unsubscribe stable in the body of a message to majord...@vger.kernel.org More majordomo info at

[RHEL6 PATCH 2/2] ext4: don't leave i_crtime.tv_sec uninitialized

Nossum vegard.nos...@oracle.com Signed-off-by: Theodore Ts'o ty...@mit.edu Cc: stable@vger.kernel.org Signed-off-by: Carlos Maiolino cmaiol...@redhat.com --- fs/ext4/ext4.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index ad3e3a1..b4f0d73

[RHEL6 PATCH 2/2] ext4: don't leave i_crtime.tv_sec uninitialized

Nossum vegard.nos...@oracle.com Signed-off-by: Theodore Ts'o ty...@mit.edu Cc: stable@vger.kernel.org Signed-off-by: Carlos Maiolino cmaiol...@redhat.com --- fs/ext4/ext4.h |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h index ad3e3a1..b4f0d73

Re: [LSF/MM TOPIC] SMR: Disrupting recording technology meriting a new class of storage device

Hi Jim, On Fri, Feb 07, 2014 at 05:32:44PM +, Jim Malina wrote: -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Friday, February 07, 2014 5:46 AM To: Carlos Maiolino; Albert Chen Cc: lsf...@lists.linux-foundation.org; James Borden; Jim Malina; Curtis

Re: [LSF/MM TOPIC] SMR: Disrupting recording technology meriting a new class of storage device

Hi, On Sat, Feb 01, 2014 at 02:24:33AM +, Albert Chen wrote: [LSF/MM TOPIC] SMR: Disrupting recording technology meriting a new class of storage device Shingle Magnetic Recording is a disruptive technology that delivers the next areal density gain for the HDD industry by partially

Re: [Bug-tar] --sparse is broken on filesystems where small files may have zero blocks

On Tue, Oct 29, 2013 at 04:01:16PM -0600, Andreas Dilger wrote: On Oct 29, 2013, at 11:37 AM, Jan Kara j...@suse.cz wrote: On Tue 29-10-13 16:27:02, Pavel Raiskup wrote: Well, I now recalled somehow relevant Red Hat bug, sorry I have not mentioned it before:

Re: [PATCH] reiserfs: Fix warning and inode leak when deleting inode with xattrs

Looks good to me Reviewed-by: Carlos Maiolino cmaiol...@redhat.com On Fri, Mar 29, 2013 at 05:09:44PM +0100, Jan Kara wrote: After commit 21d8a15a (lookup_one_len: don't accept . and ..) reiserfs started failing to delete xattrs from inode. This was due to a buggy test

Re: [PATCH] ext4: add check for inodes_count overflow in new resize ioctl

Looks good. Reviewed-by: Carlos Maiolino cmaiol...@redhat.com On Sun, Apr 21, 2013 at 10:57:05PM -0400, Theodore Ts'o wrote: Addresses-Red-Hat-Bugzilla: #913245 Reported-by: Eric Sandeen sand...@redhat.com Signed-off-by: Theodore Ts'o ty...@mit.edu Cc: stable@vger.kernel.org --- fs/ext4

Re: [PATCH 1/4] ext4: Fix possible use-after-free with AIO

Looks Good, Reviewed-by: Carlos Maiolino cmaiol...@redhat.com On Wed, Jan 23, 2013 at 01:56:17PM +0100, Jan Kara wrote: Running AIO is pinning inode in memory using file reference. Once AIO is completed using aio_complete(), file reference is put and inode can be freed from memory. So we have

Re: jbd2: don't wake kjournald unnecessarily

On Mon, Jan 21, 2013 at 11:47:33AM +0100, Jan Kara wrote: > On Sun 20-01-13 01:06:40, Sedat Dilek wrote: > > On Sun, Jan 20, 2013 at 12:44 AM, Sedat Dilek wrote: > > > Hi, > > > > > > I and some others hit a similiar problem in Linux-Next > > > (next-20130118), please see [1] and [2]. > > > > > >

Re: jbd2: don't wake kjournald unnecessarily

On Mon, Jan 21, 2013 at 11:47:33AM +0100, Jan Kara wrote: On Sun 20-01-13 01:06:40, Sedat Dilek wrote: On Sun, Jan 20, 2013 at 12:44 AM, Sedat Dilek sedat.di...@gmail.com wrote: Hi, I and some others hit a similiar problem in Linux-Next (next-20130118), please see [1] and [2].

Re: [PATCH 2/2] quota: autoload the quota_v2 module for QFMT_VFS_V1 quota format

Looks good, Reviewed-by: Carlos Maiolino cmaiol...@redhat.com On Mon, Jan 21, 2013 at 01:46:21AM -0500, Theodore Ts'o wrote: Otherwise, ext4 file systems with the quota feature enable will get a very confusing No such process error message if the quota code is built as a mdoule

Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization

Hi, On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: > Hi, > set_anon_super is called by many filesystems. Some call directly and > some call through the wrapper. Many of them in the wrapper's call to > this function are passing the second argument to this function which > is not

Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization

Hi, On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: Hi, set_anon_super is called by many filesystems. Some call directly and some call through the wrapper. Many of them in the wrapper's call to this function are passing the second argument to this function which is not used

Re: [RESEND PATCH] fs/super.c set_anon_super calling optimization

Hi, On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote: Hi, set_anon_super is called by many filesystems. Some call directly and some call through the wrapper. Many of them in the wrapper's call to this function are passing the second argument to this function which is not used

Re: [PATCH] fs: xattr: rewrite simple_xattr_set()

orig/fs/xattr.c2012-10-23 16:02:41.155857391 -0400 > +++ github/fs/xattr.c 2012-10-25 11:17:15.118197552 -0400 > @@ -842,55 +842,46 @@ > return ret; > } > Looks good to me Reviewed-by: Carlos Maiolino -- --Carlos -- To unsubscribe from this list: send the lin

Re: [PATCH] fs: xattr: rewrite simple_xattr_set()

=== --- github.orig/fs/xattr.c2012-10-23 16:02:41.155857391 -0400 +++ github/fs/xattr.c 2012-10-25 11:17:15.118197552 -0400 @@ -842,55 +842,46 @@ return ret; } Looks good to me Reviewed-by: Carlos Maiolino cmaiol...@redhat.com -- --Carlos -- To unsubscribe from this list: send the line

Re: [PATCH] use mkstemp instead of mktemp

Hi, FILE *mnttmp, *mntmtab; struct mntent *mountent; char *mtabfile, *mtabdir, *mtabtmpfile; + mode_t mode; + FILE *spf; + int fd = -1 ; mtabfile = strdup(MOUNTED); mtabdir = dirname(mtabfile); @@ -1652,12 +1655,17 @@ del_mtab(char *mountpoint)

Bug#661580: mkfs.xfs fails to detect correct sector size

On Tue, Feb 28, 2012 at 04:11:51AM -0500, Christoph Hellwig wrote: Carlos, didn't you plan to look into this issue? Goswin, how do you determin that mkfs is still doing unaligned I/O when forcing the large sevtor size? Once we set the sector size XFS can't do I/O smaller than it. On Tue,

Re: [PATCH v2] mount.cifs: handle errors from rename() in del_mtab

Looks good, On Mon, Jan 16, 2012 at 01:23:13PM -0500, Jeff Layton wrote: The new del_mtab code ignored errors from rename(). Make it handle that error as well like it does other errors. Signed-off-by: Jeff Layton jlay...@samba.org Reviewed-by: Carlos Maiolino cmaiol...@redhat.com

[PATCH] mount.cifs: Properly update mtab during remount V5

will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino cmaiol...@redhat.com --- mount.cifs.c | 100 +- 1 files

[PATCH] mount.cifs: Properly update mtab during remount V4

will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino cmaiol...@redhat.com --- mount.cifs.c | 98 ++ 1

Re: [PATCH] mount.cifs: Properly update mtab during remount V2

Hi Jeff On Tue, Jan 03, 2012 at 07:22:29AM -0500, Jeff Layton wrote: + + mtabfile = strdup(MOUNTED); This looks like a buffer overrun. Here, you're strduping MOUNTED... + mtabdir = dirname(mtabfile); Then altering that string to get the dirname... + if (!mtabdir) { +

[PATCH] mount.cifs: Properly update mtab during remount V3

will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino cmaiol...@redhat.com --- mount.cifs.c | 107 ++ 1

Re: [PATCH] mount.cifs: Properly update mtab during remount

. The del_mtab() function will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino cmaiol...@redhat.com --- mount.cifs.c | 81

[PATCH] mount.cifs: Properly update mtab during remount V2

will delete from the mtab, the old entry from the filesystem which is being remounted, and then, calls add_mtab() to add an updated entry to the mtab file. Signed-off-by: Carlos Maiolino cmaiol...@redhat.com --- mount.cifs.c | 102 ++ 1

[no subject]

subscribe -- To unsubscribe from this list: send the line unsubscribe linux-cifs in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

  1   2   >