[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-26 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/79533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

2024-01-29 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/79912 The `total` parameter for the constructor for Progress was changed to a std::optional in https://github.com/llvm/llvm-project/pull/77547. When initializing the `m_total` member variable for progress, it is

[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

2024-01-29 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79912 >From af9a5581702b5c9ca8009fc32c7ae10a1654d391 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 29 Jan 2024 15:29:46 -0800 Subject: [PATCH] [lldb][progress] Correctly check total for deterministi

[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79912 >From af9a5581702b5c9ca8009fc32c7ae10a1654d391 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 29 Jan 2024 15:29:46 -0800 Subject: [PATCH 1/2] [lldb][progress] Correctly check total for determin

[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
@@ -39,7 +39,7 @@ class ProgressEventData : public EventData { GetAsStructuredData(const Event *event_ptr); uint64_t GetID() const { return m_id; } - bool IsFinite() const { return m_total != UINT64_MAX; } + bool IsFinite() const { return m_total != 1; }

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,125 @@ +//===-- ProgressReportTest.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][progress] Correctly check total for deterministic progress (PR #79912)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/79912 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79533 >From 10343b6cdad410e09546dd5a98e29d272300ed2e Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 25 Jan 2024 16:40:42 -0800 Subject: [PATCH 1/4] [lldb][progress][NFC] Add unit test for progress re

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-30 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79533 >From 10343b6cdad410e09546dd5a98e29d272300ed2e Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 25 Jan 2024 16:40:42 -0800 Subject: [PATCH 1/4] [lldb][progress][NFC] Add unit test for progress re

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-31 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/79533 >From 10343b6cdad410e09546dd5a98e29d272300ed2e Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 25 Jan 2024 16:40:42 -0800 Subject: [PATCH 1/4] [lldb][progress][NFC] Add unit test for progress re

[Lldb-commits] [lldb] [lldb][progress][NFC] Add unit test for progress reports (PR #79533)

2024-01-31 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/79533 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 209fe1f - Revert "[lldb][progress][NFC] Add unit test for progress reports (#79533)"

2024-01-31 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2024-01-31T11:58:11-08:00 New Revision: 209fe1f3d70d1c4a20bb2687e0d0a94b1bbfa0c6 URL: https://github.com/llvm/llvm-project/commit/209fe1f3d70d1c4a20bb2687e0d0a94b1bbfa0c6 DIFF: https://github.com/llvm/llvm-project/commit/209fe1f3d70d1c4a20bb2687e0d0a94b1bbfa0c6.d

[Lldb-commits] [lldb] a5a8cbb - Reland "[lldb][progress][NFC] Add unit test for progress reports (#79533)"

2024-01-31 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2024-01-31T15:19:39-08:00 New Revision: a5a8cbb110384825b99228891576f799082f200e URL: https://github.com/llvm/llvm-project/commit/a5a8cbb110384825b99228891576f799082f200e DIFF: https://github.com/llvm/llvm-project/commit/a5a8cbb110384825b99228891576f799082f200e.d

[Lldb-commits] [lldb] 40ebe52 - Revert "Reland "[lldb][progress][NFC] Add unit test for progress reports (#79533)""

2024-01-31 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2024-01-31T15:31:52-08:00 New Revision: 40ebe522ea5fd56cb383e29c77373b1482d49c0f URL: https://github.com/llvm/llvm-project/commit/40ebe522ea5fd56cb383e29c77373b1482d49c0f DIFF: https://github.com/llvm/llvm-project/commit/40ebe522ea5fd56cb383e29c77373b1482d49c0f.d

[Lldb-commits] [lldb] b797834 - [lldb/Fuzzer] Add fuzzer for expression evaluator

2022-07-22 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-07-22T17:32:00-04:00 New Revision: b797834748f1954950880bf50fb78abedd4494e6 URL: https://github.com/llvm/llvm-project/commit/b797834748f1954950880bf50fb78abedd4494e6 DIFF: https://github.com/llvm/llvm-project/commit/b797834748f1954950880bf50fb78abedd4494e6.d

[Lldb-commits] [lldb] bcf6ffb - Reland "[lldb/Fuzzer] Add fuzzer for expression evaluator"

2022-08-04 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-08-04T11:47:06-04:00 New Revision: bcf6ffb87ec67ba41daeaab905b2c57a50568aa0 URL: https://github.com/llvm/llvm-project/commit/bcf6ffb87ec67ba41daeaab905b2c57a50568aa0 DIFF: https://github.com/llvm/llvm-project/commit/bcf6ffb87ec67ba41daeaab905b2c57a50568aa0.d

[Lldb-commits] [lldb] 9525015 - [lldb][tests] Test queue-specific breakpoints

2022-08-17 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-08-17T12:46:04-04:00 New Revision: 9525015c1bed5563813a440c5e5c871bd3c7eb24 URL: https://github.com/llvm/llvm-project/commit/9525015c1bed5563813a440c5e5c871bd3c7eb24 DIFF: https://github.com/llvm/llvm-project/commit/9525015c1bed5563813a440c5e5c871bd3c7eb24.d

[Lldb-commits] [lldb] 43d7320 - [lldb][docs] Add documentation for LLDB fuzzers

2022-08-26 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-08-26T18:35:21-05:00 New Revision: 43d7320e7111784c613634e73f50c631a1b0b303 URL: https://github.com/llvm/llvm-project/commit/43d7320e7111784c613634e73f50c631a1b0b303 DIFF: https://github.com/llvm/llvm-project/commit/43d7320e7111784c613634e73f50c631a1b0b303.d

[Lldb-commits] [lldb] 53f1cc8 - [lldb][docs] Fix formatting in fuzzing doc

2022-08-26 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-08-26T22:15:38-05:00 New Revision: 53f1cc85e3de11ff91eb985332257d63dcf47ddc URL: https://github.com/llvm/llvm-project/commit/53f1cc85e3de11ff91eb985332257d63dcf47ddc DIFF: https://github.com/llvm/llvm-project/commit/53f1cc85e3de11ff91eb985332257d63dcf47ddc.d

[Lldb-commits] [lldb] 0f02dd3 - [lldb/Commands] Prevent crash due to reading memory from page zero.

2022-06-08 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-06-08T18:10:41-04:00 New Revision: 0f02dd34f22650d8af0070e7ad21632525e33da8 URL: https://github.com/llvm/llvm-project/commit/0f02dd34f22650d8af0070e7ad21632525e33da8 DIFF: https://github.com/llvm/llvm-project/commit/0f02dd34f22650d8af0070e7ad21632525e33da8.d

[Lldb-commits] [lldb] f3250da - [lldb/Fuzzer] Create ninja target for target fuzzer

2022-06-15 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-06-15T14:55:43-04:00 New Revision: f3250da1b94fed260ea5da8264ba366c42aaf34c URL: https://github.com/llvm/llvm-project/commit/f3250da1b94fed260ea5da8264ba366c42aaf34c DIFF: https://github.com/llvm/llvm-project/commit/f3250da1b94fed260ea5da8264ba366c42aaf34c.d

[Lldb-commits] [lldb] 3ba71f1 - Reland "[lldb/Fuzzer] Create ninja target for target fuzzer"

2022-06-15 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-06-15T17:37:38-04:00 New Revision: 3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7 URL: https://github.com/llvm/llvm-project/commit/3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7 DIFF: https://github.com/llvm/llvm-project/commit/3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7.d

[Lldb-commits] [lldb] 46be5fa - [lldb/Fuzzer] Add command interpreter fuzzer for LLDB

2022-06-22 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-06-22T17:42:55-04:00 New Revision: 46be5faaf03466c3751f8a2882bef5a217e15926 URL: https://github.com/llvm/llvm-project/commit/46be5faaf03466c3751f8a2882bef5a217e15926 DIFF: https://github.com/llvm/llvm-project/commit/46be5faaf03466c3751f8a2882bef5a217e15926.d

[Lldb-commits] [lldb] 40aace5 - [lldb/Fuzzer] Have fuzzers write artifacts to specific directory

2022-06-23 Thread Chelsea Cassanova via lldb-commits
Author: Chelsea Cassanova Date: 2022-06-23T16:55:23-04:00 New Revision: 40aace59cc58ca438060cf4dfd97ba01ff4f0ebc URL: https://github.com/llvm/llvm-project/commit/40aace59cc58ca438060cf4dfd97ba01ff4f0ebc DIFF: https://github.com/llvm/llvm-project/commit/40aace59cc58ca438060cf4dfd97ba01ff4f0ebc.d

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

2024-06-20 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From aa575bbc2b91837851631cf7a14e03398e2efa48 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

2024-06-20 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From 2cfcef620125ed7d0ba84acfa20de3064437282c Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

2024-06-20 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,93 @@ +//===-- TestBreakpointSetCallback.cpp +//===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identi

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

2024-06-21 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From 86dcffcc7a1820756fe8104d8239f25185a27733 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

2024-06-21 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From 44ea5e0d0a319fa12463129ff072bcaef6112544 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

2024-06-21 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/96001 >From a59949cc908d5216950f2530fe1455da8ad39b5f Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 13 Jun 2024 16:02:07 -0700 Subject: [PATCH] add unit test for breakpoint::setcallback --- lldb/in

[Lldb-commits] [lldb] [lldb][API] Add Find(Ranges)InMemory() to Process SB API (PR #95007)

2024-06-24 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Hey Miro, looks like this change broke the LLDB MacOS buildbot: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6353/ https://github.com/llvm/llvm-project/pull/95007 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [lldb] Add a unit test for SBBreakpoint::SetCallback (PR #96001)

2024-06-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/96001 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Revert commits that add `TestFind(Ranges)InMemory.py` (PR #96560)

2024-06-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/96560 Reverting to unblock macOS buildbots which are currently failing on these tests. https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6377/ >From 22127178761968b01be207a1c83c7048dc3ec47d Mon

[Lldb-commits] [lldb] Revert commits that add `TestFind(Ranges)InMemory.py` (PR #96560)

2024-06-24 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/96560 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Parse and display register field enums (PR #95768)

2024-06-28 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Hey David! It looks like this commit broke the `TestXMLRegisterFlags.py` test on macOS sanitized buildbots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake-sanitized/425/console https://github.com/llvm/llvm-project/pull/95768 __

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed (PR #93913)

2024-07-01 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Hey! Looks like this commit broke some tests on the LLDB macOS buildbots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/6805/console ``` Assertion failed: (!isUnbracedLanguageLinkage(DC) || SC == SC_None), function VarDecl, file Decl.cpp, line 2128. P

[Lldb-commits] [lldb] [lldb][breakpoint] Grey out disabled breakpoints (PR #91404)

2024-07-11 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: Just making sure, a setting for changing the prefix/suffix would be in `CoreProperties.td` right? https://github.com/llvm/llvm-project/pull/91404 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [lldb] [lldb] Fully namespace SBType callback function parameters (PR #102375)

2024-08-07 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/102375 This commit fully namespaces callback function pointer parameters that are SB types in `SBDefines` and `lldb-types`. >From 6525ca91f6ef49b06613ec6e947f54d3faf73efe Mon Sep 17 00:00:00 2001 From: Chelsea C

[Lldb-commits] [lldb] [lldb] Fully namespace SBType callback function parameters (PR #102375)

2024-08-07 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/102375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fully namespace SBType callback function parameters (PR #102375)

2024-08-07 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > LGTM! Are these the only callbacks that need to be fully qualified ? Yes they are, if new callback function pointers are added in the future that use SB types in their parameter list or as their return type then ideally those should also be fully namespaced. https://git

[Lldb-commits] [lldb] [lldb] Fully namespace SBType callback function parameters (PR #102375)

2024-08-07 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/102375 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][unittest] Add call_once flag to initialize debugger (PR #80786)

2024-02-05 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/80786 I tried adding a new unit test to the core test suite (https://github.com/llvm/llvm-project/pull/79533) but it broke the test suite on AArch64 Linux due to hitting an assertion for calling `Debugger::Initi

[Lldb-commits] [lldb] [lldb][unittest] Use shared once_flag in DiagnosticEventTest (PR #80788)

2024-02-05 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/80788 Incorporates the changes from https://github.com/llvm/llvm-project/pull/80786 to use a once_flag from `TestUtilities` instead of a local flag in order to prevent hitting an assertion that the debugger was

[Lldb-commits] [lldb] [lldb][unittest] Add call_once flag to initialize debugger (PR #80786)

2024-02-05 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I did, I'm adding them as separate patches. DiagnosticEventTest.cpp could probably go here since it's a simple change but ProgressEventTest doesn't exist upstream yet since I had to revert so I think that at least should be it's own PR> https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] [lldb][unittest] Add call_once flag to initialize debugger (PR #80786)

2024-02-06 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/80786 >From 0d56057bc9904b2079324b21b3625def7e15b6c2 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 5 Feb 2024 18:41:14 -0800 Subject: [PATCH] [lldb][unittest] Add call_once flag to initialize debugg

[Lldb-commits] [lldb] [lldb][unittest] Add call_once flag to initialize debugger (PR #80786)

2024-02-06 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/80786 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb][progress][NFC] Add unit test for progress reports" (PR #80791)

2024-02-06 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/80791 >From 16e468b938ade09c57fd1eb7ea3db7b673836cb0 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 5 Feb 2024 19:00:52 -0800 Subject: [PATCH] Reland "[lldb][progress][NFC] Add unit test for progress

[Lldb-commits] [lldb] [lldb][unittest] Use shared once_flag in DiagnosticEventTest (PR #80788)

2024-02-06 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/80788 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reland "[lldb][progress][NFC] Add unit test for progress reports" (PR #80791)

2024-02-06 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/80791 >From 4760c7ca48790f5f87de8e6ba2a5a3eea002 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 5 Feb 2024 19:00:52 -0800 Subject: [PATCH] Reland "[lldb][progress][NFC] Add unit test for progress

[Lldb-commits] [lldb] Reland "[lldb][progress][NFC] Add unit test for progress reports" (PR #80791)

2024-02-06 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/80791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-07 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/81026 As part of the effort to improve progress reporting in LLDB (https://discourse.llvm.org/t/rfc-improve-lldb-progress-reporting/75717) we want a way to keep track of progress reports to see if they're ongoin

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-07 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/81026 >From a80637fe2471c3f1adc2b353cef41887bcd55a3c Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 6 Feb 2024 10:48:39 -0800 Subject: [PATCH] [lldb][progress][NFC] Add groundwork to keep track of p

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-07 Thread Chelsea Cassanova via lldb-commits
@@ -117,6 +127,7 @@ class Progress { /// to ensure that we don't send progress updates after progress has /// completed. bool m_complete = false; + bool m_type; chelcassanova wrote: Holdover from when I used a bool for this value before switching an enu

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-07 Thread Chelsea Cassanova via lldb-commits
@@ -9,26 +9,34 @@ #include "lldb/Core/Progress.h" #include "lldb/Core/Debugger.h" -#include "lldb/Utility/StreamString.h" #include using namespace lldb; using namespace lldb_private; std::atomic Progress::g_id(0); +std::atomic Progress::g_refcount(1); +std::unordere

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-07 Thread Chelsea Cassanova via lldb-commits
@@ -99,6 +105,10 @@ class Progress { private: void ReportProgress(); static std::atomic g_id; + static std::atomic g_refcount; + /// Map that tracks each progress object and if we've seen its start and stop + /// events + static std::unordered_map g_map; ---

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-07 Thread Chelsea Cassanova via lldb-commits
@@ -99,6 +105,10 @@ class Progress { private: void ReportProgress(); static std::atomic g_id; + static std::atomic g_refcount; + /// Map that tracks each progress object and if we've seen its start and stop + /// events + static std::unordered_map g_map; ---

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-07 Thread Chelsea Cassanova via lldb-commits
@@ -9,26 +9,34 @@ #include "lldb/Core/Progress.h" #include "lldb/Core/Debugger.h" -#include "lldb/Utility/StreamString.h" #include using namespace lldb; using namespace lldb_private; std::atomic Progress::g_id(0); +std::atomic Progress::g_refcount(1); +std::unordere

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-08 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I'll start with this by changing this so that bookkeeping is done with the new bit instead of being done in the constructor for `Progress`. https://github.com/llvm/llvm-project/pull/81026 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-08 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: The discussions happening here are talking about 2 major things, how to do the bookkeeping of the map that keeps track of progress reports and where to do that bookkeeping. I think it makes sense to split up this work into smaller patches as such: 1. Since it's best to do

[Lldb-commits] [lldb] [lldb][debugger][NFC] Add broadcast bit for category-based progress events. (PR #81169)

2024-02-08 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/81169 This commit adds a new broadcast bit to the debugger. When in use, it will be listened to for progress events that will be delivered and kept track of by category as opposed to the current behaviour of com

[Lldb-commits] [lldb] [lldb][debugger][NFC] Add broadcast bit for category-based progress events. (PR #81169)

2024-02-08 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/81169 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-08 Thread Chelsea Cassanova via lldb-commits
@@ -12,6 +12,7 @@ #include "lldb/Utility/ConstString.h" #include "lldb/lldb-types.h" #include +#include chelcassanova wrote: I shouldn't need a sorted map so I'll go with StringMap for the updated patch with the class that will handle the progress report ma

[Lldb-commits] [lldb] [lldb][progress][NFC] Add groundwork to keep track of progress reports (PR #81026)

2024-02-08 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/81026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-09 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/81319 Per discussions from https://github.com/llvm/llvm-project/pull/81026, it was decided that having a class that manages a map of progress reports would be beneficial in order to categorize them. This class i

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-09 Thread Chelsea Cassanova via lldb-commits
@@ -119,6 +120,32 @@ class Progress { bool m_complete = false; }; +/// A class used to group progress reports by category. This is done by using a +/// map that maintains a refcount of each category of progress reports that have +/// come in. Keeping track of progress repor

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-09 Thread Chelsea Cassanova via lldb-commits
@@ -66,3 +66,47 @@ void Progress::ReportProgress() { m_debugger_id); } } + +void ProgressManager::Initialize() { + lldbassert(!InstanceImpl() && "A progress report manager already exists."); + InstanceImpl().emplace(); +} + +void ProgressManager

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-09 Thread Chelsea Cassanova via lldb-commits
@@ -66,3 +66,47 @@ void Progress::ReportProgress() { m_debugger_id); } } + +void ProgressManager::Initialize() { + lldbassert(!InstanceImpl() && "A progress report manager already exists."); + InstanceImpl().emplace(); +} + +void ProgressManager

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-09 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/81319 >From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 8 Feb 2024 15:31:33 -0800 Subject: [PATCH] [lldb][progress] Add progress manager class Per discuss

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-12 Thread Chelsea Cassanova via lldb-commits
@@ -66,3 +66,47 @@ void Progress::ReportProgress() { m_debugger_id); } } + +void ProgressManager::Initialize() { + lldbassert(!InstanceImpl() && "A progress report manager already exists."); + InstanceImpl().emplace(); +} + +void ProgressManager

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-13 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/81319 >From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 8 Feb 2024 15:31:33 -0800 Subject: [PATCH 1/2] [lldb][progress] Add progress manager class Per dis

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-14 Thread Chelsea Cassanova via lldb-commits
@@ -119,6 +120,32 @@ class Progress { bool m_complete = false; }; +/// A class used to group progress reports by category. This is done by using a +/// map that maintains a refcount of each category of progress reports that have +/// come in. Keeping track of progress repor

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-14 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/81319 >From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 8 Feb 2024 15:31:33 -0800 Subject: [PATCH 1/2] [lldb][progress] Add progress manager class Per dis

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-14 Thread Chelsea Cassanova via lldb-commits
@@ -66,3 +67,41 @@ void Progress::ReportProgress() { m_debugger_id); } } + +ProgressManager &ProgressManager::InstanceImpl() { + static std::once_flag g_once_flag; + static ProgressManager *g_progress_manager = nullptr; + std::call_once(g_once_

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-14 Thread Chelsea Cassanova via lldb-commits
@@ -66,3 +67,41 @@ void Progress::ReportProgress() { m_debugger_id); } } + +ProgressManager &ProgressManager::InstanceImpl() { + static std::once_flag g_once_flag; + static ProgressManager *g_progress_manager = nullptr; + std::call_once(g_once_

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/81319 >From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 8 Feb 2024 15:31:33 -0800 Subject: [PATCH 1/3] [lldb][progress] Add progress manager class Per dis

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
@@ -119,6 +120,32 @@ class Progress { bool m_complete = false; }; +/// A class used to group progress reports by category. This is done by using a +/// map that maintains a refcount of each category of progress reports that have +/// come in. Keeping track of progress repor

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
@@ -66,3 +67,41 @@ void Progress::ReportProgress() { m_debugger_id); } } + +ProgressManager &ProgressManager::InstanceImpl() { + static std::once_flag g_once_flag; + static ProgressManager *g_progress_manager = nullptr; + std::call_once(g_once_

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/81319 >From f5ef07849c61ee9387f92376d5e1bd13bedc43e5 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Thu, 8 Feb 2024 15:31:33 -0800 Subject: [PATCH 1/4] [lldb][progress] Add progress manager class Per dis

[Lldb-commits] [lldb] [lldb][progress] Add progress manager class (PR #81319)

2024-02-15 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/81319 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-26 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/83069 This commit adds the functionality to broadcast events using the `Debugger::eBroadcastProgressCategory` bit (https://github.com/llvm/llvm-project/pull/81169) by keeping track of these reports with the `Pro

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-26 Thread Chelsea Cassanova via lldb-commits
@@ -97,12 +98,32 @@ class Progress { /// Used to indicate a non-deterministic progress report static constexpr uint64_t kNonDeterministicTotal = UINT64_MAX; + /// Use a struct to send data from a Progress object to + /// ProgressManager::ReportProgress. In addition to th

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-26 Thread Chelsea Cassanova via lldb-commits
@@ -1433,11 +1434,30 @@ void Debugger::SetDestroyCallback( static void PrivateReportProgress(Debugger &debugger, uint64_t progress_id, std::string title, std::string details, uint64_t completed, uint64_t total,

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-26 Thread Chelsea Cassanova via lldb-commits
@@ -593,6 +593,7 @@ class Debugger : public std::enable_shared_from_this, friend class CommandInterpreter; friend class REPL; friend class Progress; + friend class ProgressManager; chelcassanova wrote: `Debugger::ReportProgress` is protected, so to my

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-26 Thread Chelsea Cassanova via lldb-commits
@@ -1433,11 +1434,30 @@ void Debugger::SetDestroyCallback( static void PrivateReportProgress(Debugger &debugger, uint64_t progress_id, std::string title, std::string details, uint64_t completed, uint64_t total,

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-26 Thread Chelsea Cassanova via lldb-commits
@@ -1433,11 +1434,30 @@ void Debugger::SetDestroyCallback( static void PrivateReportProgress(Debugger &debugger, uint64_t progress_id, std::string title, std::string details, uint64_t completed, uint64_t total,

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-26 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova edited https://github.com/llvm/llvm-project/pull/83069 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-26 Thread Chelsea Cassanova via lldb-commits
@@ -1433,11 +1434,30 @@ void Debugger::SetDestroyCallback( static void PrivateReportProgress(Debugger &debugger, uint64_t progress_id, std::string title, std::string details, uint64_t completed, uint64_t total,

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-27 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/83069 >From d2854ecb51d5996cd5cabf4e1c1ac9dc6e01240b Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 20 Feb 2024 13:56:53 -0800 Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-27 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/83069 >From 2cef4a29f0105847fa11b7f6a6ee063184fb838a Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 20 Feb 2024 13:56:53 -0800 Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-27 Thread Chelsea Cassanova via lldb-commits
@@ -29,8 +30,12 @@ Progress::Progress(std::string title, std::string details, if (debugger) m_debugger_id = debugger->GetID(); + + m_progress_data = {m_title, m_details, m_id, + m_completed, m_total, m_debugger_id}; chelcassano

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/83069 >From 63dded34a47dd161fa918e45aaeecf966ba08476 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 20 Feb 2024 13:56:53 -0800 Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-28 Thread Chelsea Cassanova via lldb-commits
@@ -82,20 +94,37 @@ ProgressManager &ProgressManager::Instance() { return *g_progress_manager; } -void ProgressManager::Increment(std::string title) { +void ProgressManager::Increment(Progress::ProgressData progress_data) { chelcassanova wrote: Yeah, the ti

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/83069 >From 03268312834c61a16c4bc28efc442fcd027ec0a9 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 20 Feb 2024 13:56:53 -0800 Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/83069 >From 40caaa80180d4845393fc4b80ee2dc09b7c87a7e Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 20 Feb 2024 13:56:53 -0800 Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-28 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/83069 >From f38204941062691bf3e3f6e57d8171a5c0258f77 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 20 Feb 2024 13:56:53 -0800 Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-29 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/83069 >From 59e3b1da1335261badeace24d6136d924cda6949 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 20 Feb 2024 13:56:53 -0800 Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-02-29 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/83069 >From 5fcab5d9b7af70861bbc46f096032dce7de41517 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Tue, 20 Feb 2024 13:56:53 -0800 Subject: [PATCH] [lldb][progress] Hook up new broadcast bit and progress

[Lldb-commits] [lldb] [lldb][progress][NFC] Fix Doxygen information (PR #83502)

2024-02-29 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova created https://github.com/llvm/llvm-project/pull/83502 The `details` field in the constructor for `Progress` is missing Doxygen documentation, this commit adds this. >From 7b26213416e45853514e98d5043255ccd42153a9 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanov

[Lldb-commits] [lldb] [lldb][progress][NFC] Fix Doxygen information (PR #83502)

2024-02-29 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/83502 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][progress] Hook up new broadcast bit and progress manager (PR #83069)

2024-03-01 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova closed https://github.com/llvm/llvm-project/pull/83069 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2   3   >