https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -97,12 +119,17 @@ class Progress {
/// The title of the progress activity.
std::string m_title;
std::mutex m_mutex;
+ /// Set to eNonAggregateProgressReport if the progress event is aggregate;
chelcassanova wrote:
Mistake by me
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
- /// @param [in] total The total units of work to be done if specified, if
- /// set to UINT64_MAX then an indeterminate progress indicator should be
+ /// @param
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
chelcassanova wrote:
The report type has been added as a key in the dictionary that gets returned
from `SBDebugger::GetProgressDataFromEvent` (specifically it's the key
`is_aggregate`) and that key is added in `DebuggerEvents.cpp`. To my
understanding since we can get the report type from
chelcassanova wrote:
@clayborg Just pinging on this PR (when you have the chance) :)
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -398,13 +398,16 @@ ValueObject::GetChildAtIndexPath(llvm::ArrayRef
idxs,
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (size_t idx : idxs) {
root = root->GetChildAtIndex(idx);
if (!root) {
@@ -414,13 +417,17 @@ lldb::ValueObjectSP ValueObject::GetChildAtIndexPath(
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (std::pair idx : idxs) {
root = root->GetChildAtIndex(idx.first, idx.second);
@@ -398,13 +398,16 @@ ValueObject::GetChildAtIndexPath(llvm::ArrayRef
idxs,
if (idxs.size() == 0)
return GetSP();
ValueObjectSP root(GetSP());
+
+ size_t current_index = 0;
for (size_t idx : idxs) {
root = root->GetChildAtIndex(idx);
if (!root) {
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 028d5b9f706fdf06ee0d9a33228d96660d68f5f0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
+ /// @param [in] report_type Enum value indicating how the progress is being
+ /// reported. Progress reports considered "aggregate" are reports done for
+ ///
@@ -63,13 +68,30 @@ class Progress {
///
/// @param [in] title The title of this progress activity.
///
+ /// @param [in] report_type Enum value indicating how the progress is being
+ /// reported. Progress reports considered "aggregate" are reports done for
+ ///
@@ -97,6 +119,10 @@ class Progress {
/// The title of the progress activity.
std::string m_title;
std::mutex m_mutex;
+ /// Set to true if the progress event is aggregate; meaning it will happen
+ /// multiple times during a debug session as individual progress events
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 417d99ff038517fed596ebf6605e203110e88e6f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
@@ -1451,7 +1451,8 @@ static lldb::SectionType GetSectionType(uint32_t flags,
static ConstString g_sect_name_dwarf_debug_line_str("__debug_line_str");
static ConstString g_sect_name_dwarf_debug_loc("__debug_loc");
static ConstString
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 83ca6c8e94ded4378b4c0cd067aaeca1d92719d0 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 004e0e6a8a09b34bdc694ca7eb5ef02483693e5f Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH] [lldb][progress] Add discrete boolean flag to progress
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/6] [lldb][progress] Add discrete boolean flag to
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/73605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/73605
>From 8c29a2034a57174ec68f8c1f1a2c5c66a7988762 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 27 Nov 2023 15:42:13 -0800
Subject: [PATCH 1/2] [lldb][progress] Always report progress upon
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/73605
This commit allows a final progress report upon the destruction of the
`Progress` object to happen at all times as opposed to when the progress was
not completed.
>From
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/71081
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/71081
The instructions for running single tests in the LLDB test suite used an older
directory structure from before the LLVM project became a monorepo. This commit
updates the references to these directories.
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/5] [lldb][progress] Add discrete boolean flag to
chelcassanova wrote:
"Aggregate" can work. These are moreso status updates than than they are
progress reports and I need to work on the documentation in the code that
explains what I'm trying to accomplish.
https://github.com/llvm/llvm-project/pull/69516
@@ -16,9 +16,10 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
lldb_private::Debugger *debugger)
-:
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/4] [lldb][progress] Add discrete boolean flag to
@@ -16,7 +16,7 @@ using namespace lldb_private;
std::atomic Progress::g_id(0);
-Progress::Progress(std::string title, uint64_t total,
+Progress::Progress(std::string title, bool is_discrete, uint64_t total,
chelcassanova wrote:
Yes it was, left it out by
@@ -37,5 +37,8 @@ def
test_dwarf_symbol_loading_progress_report_structured_data(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
progress_data = lldb.SBDebugger.GetProgressDataFromEvent(event)
-message =
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/3] [lldb][progress] Add discrete boolean flag to
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/69516
>From 073ba299ab15c487bff28212563b5a103bdc5f60 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 18 Oct 2023 13:07:51 -0700
Subject: [PATCH 1/2] [lldb][progress] Add discrete boolean flag to
@@ -25,8 +25,8 @@ def test_dwarf_symbol_loading_progress_report(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
ret_args = lldb.SBDebugger.GetProgressFromEvent(event)
self.assertGreater(len(ret_args), 0)
-message
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/69516
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1426,7 +1427,8 @@ void Debugger::ReportProgress(uint64_t progress_id,
std::string title,
if (debugger_sp)
PrivateReportProgress(*debugger_sp, progress_id, std::move(title),
std::move(details), completed, total,
-
@@ -2219,7 +2219,7 @@ void ObjectFileMachO::ParseSymtab(Symtab ) {
const FileSpec = m_file ? m_file : module_sp->GetFileSpec();
const char *file_name = file.GetFilename().AsCString("");
LLDB_SCOPED_TIMERF("ObjectFileMachO::ParseSymtab () module = %s", file_name);
-
@@ -25,8 +25,8 @@ def test_dwarf_symbol_loading_progress_report(self):
event = lldbutil.fetch_next_event(self, self.listener,
self.broadcaster)
ret_args = lldb.SBDebugger.GetProgressFromEvent(event)
self.assertGreater(len(ret_args), 0)
-message
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/69516
This commit adds a boolean flag `is_discrete` is to progress reports in LLDB.
The flag is set to false by default and indicates if a progress event is
discrete, i.e. an operation that has no clear start
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/66144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/66144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/5] [lldb][Commands] Show symbol change bit in SB API
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/4] [lldb][Commands] Show symbol change bit in SB API
@@ -57,6 +57,29 @@ def test_add_dsym_with_dSYM_bundle(self):
self.exe_name = "a.out"
self.do_add_dsym_with_dSYM_bundle(self.exe_name)
+@no_debug_info_test
+def test_report_symbol_load(self):
+"""Test that when adding a symbol file, the
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/3] [lldb][Commands] Show symbol change bit in SB API
chelcassanova wrote:
> Does this API work for eBroadcastBitSymbolsLoaded:
>
> ```
> static lldb::SBModule lldb::SBTarget::GetModuleAtIndexFromEvent(const
> uint32_t idx, const lldb::SBEvent );
> ```
>
> ?
>
> > Note, Jonas already added the Target::eBroadcastBitSymbolsChanged, but it
> >
@@ -83,7 +83,7 @@ class Debugger : public
std::enable_shared_from_this,
eBroadcastBitProgress = (1 << 0),
eBroadcastBitWarning = (1 << 1),
eBroadcastBitError = (1 << 2),
-eBroadcastSymbolChange = (1 << 3),
+eBroadcastBitSymbolChange = (1 << 3),
@@ -66,6 +66,7 @@
#include "llvm/ADT/ScopeExit.h"
#include "llvm/ADT/SetVector.h"
+#include <_types/_uint32_t.h>
chelcassanova wrote:
This was included by mistake
https://github.com/llvm/llvm-project/pull/66144
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH 1/2] [lldb][Commands] Show symbol change bit in SB API
@@ -83,7 +83,7 @@ class Debugger : public
std::enable_shared_from_this,
eBroadcastBitProgress = (1 << 0),
eBroadcastBitWarning = (1 << 1),
eBroadcastBitError = (1 << 2),
-eBroadcastSymbolChange = (1 << 3),
+eBroadcastBitSymbolChange = (1 << 3),
@@ -83,7 +83,7 @@ class Debugger : public
std::enable_shared_from_this,
eBroadcastBitProgress = (1 << 0),
eBroadcastBitWarning = (1 << 1),
eBroadcastBitError = (1 << 2),
-eBroadcastSymbolChange = (1 << 3),
+eBroadcastBitSymbolChange = (1 << 3),
https://github.com/chelcassanova resolved
https://github.com/llvm/llvm-project/pull/66144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -13,6 +13,7 @@
#include "lldb/API/SBDefines.h"
#include "lldb/API/SBPlatform.h"
+#include "lldb/API/SBStructuredData.h"
chelcassanova wrote:
Correct, I left this in here by mistake.
https://github.com/llvm/llvm-project/pull/66144
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/66144:
>From 8754d93a72bdff94f95f991d9bf1112e5f9fe692 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Tue, 12 Sep 2023 13:49:50 -0700
Subject: [PATCH] [lldb][Commands] Show symbol change bit in SB API
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/66144:
This exposes the `eBroadcastBitSymbolChange` bit to the SB API to show when a
symbol change event has been broadcast as this wasn't being done before. Also
refactors `eBroadcastSymbolChange` to
https://github.com/chelcassanova review_requested
https://github.com/llvm/llvm-project/pull/66144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2022-08-26T22:15:38-05:00
New Revision: 53f1cc85e3de11ff91eb985332257d63dcf47ddc
URL:
https://github.com/llvm/llvm-project/commit/53f1cc85e3de11ff91eb985332257d63dcf47ddc
DIFF:
Author: Chelsea Cassanova
Date: 2022-08-26T18:35:21-05:00
New Revision: 43d7320e7111784c613634e73f50c631a1b0b303
URL:
https://github.com/llvm/llvm-project/commit/43d7320e7111784c613634e73f50c631a1b0b303
DIFF:
Author: Chelsea Cassanova
Date: 2022-08-17T12:46:04-04:00
New Revision: 9525015c1bed5563813a440c5e5c871bd3c7eb24
URL:
https://github.com/llvm/llvm-project/commit/9525015c1bed5563813a440c5e5c871bd3c7eb24
DIFF:
Author: Chelsea Cassanova
Date: 2022-08-04T11:47:06-04:00
New Revision: bcf6ffb87ec67ba41daeaab905b2c57a50568aa0
URL:
https://github.com/llvm/llvm-project/commit/bcf6ffb87ec67ba41daeaab905b2c57a50568aa0
DIFF:
Author: Chelsea Cassanova
Date: 2022-07-22T17:32:00-04:00
New Revision: b797834748f1954950880bf50fb78abedd4494e6
URL:
https://github.com/llvm/llvm-project/commit/b797834748f1954950880bf50fb78abedd4494e6
DIFF:
Author: Chelsea Cassanova
Date: 2022-06-23T16:55:23-04:00
New Revision: 40aace59cc58ca438060cf4dfd97ba01ff4f0ebc
URL:
https://github.com/llvm/llvm-project/commit/40aace59cc58ca438060cf4dfd97ba01ff4f0ebc
DIFF:
Author: Chelsea Cassanova
Date: 2022-06-22T17:42:55-04:00
New Revision: 46be5faaf03466c3751f8a2882bef5a217e15926
URL:
https://github.com/llvm/llvm-project/commit/46be5faaf03466c3751f8a2882bef5a217e15926
DIFF:
Author: Chelsea Cassanova
Date: 2022-06-15T17:37:38-04:00
New Revision: 3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7
URL:
https://github.com/llvm/llvm-project/commit/3ba71f1be1fb986e634debd8d17a69d2bb4c4eb7
DIFF:
Author: Chelsea Cassanova
Date: 2022-06-15T14:55:43-04:00
New Revision: f3250da1b94fed260ea5da8264ba366c42aaf34c
URL:
https://github.com/llvm/llvm-project/commit/f3250da1b94fed260ea5da8264ba366c42aaf34c
DIFF:
Author: Chelsea Cassanova
Date: 2022-06-08T18:10:41-04:00
New Revision: 0f02dd34f22650d8af0070e7ad21632525e33da8
URL:
https://github.com/llvm/llvm-project/commit/0f02dd34f22650d8af0070e7ad21632525e33da8
DIFF:
201 - 266 of 266 matches
Mail list logo
