DavidSpickett wrote:
This was failing on our bots that build all backends, I've fixed that:
https://github.com/llvm/llvm-project/commit/8bf952d77fbe63f979e4293e95a5ca379e26eede
It will help you in future if you set an email address for your commits in this
Github project. Buildbot will then
DavidSpickett wrote:
I saw your email in the merge box so I've gone ahead and landed it (I think the
workflow that checks for a private email may only be re-run when the changes in
the PR are updated).
https://github.com/llvm/llvm-project/pull/99256
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/99256
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
I know there is UB in there (https://github.com/llvm/llvm-project/issues/94741)
so this is not unsurprising. Though so far none of that has been the cause of
failures natively.
Let's see what Leandro finds.
https://github.com/llvm/llvm-project/pull/70306
DavidSpickett wrote:
@luporl please help reproduce the bot failure
https://lab.llvm.org/buildbot/#/builders/39/builds/528.
You can also try it under qemu -
https://linaro.atlassian.net/wiki/spaces/TCWGPUB/pages/29360783374/How+to+Reproduce+32+bit+Arm+Builds+Without+Hardware.
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -20,16 +20,15 @@ using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- StringMap features;
-
- if (!sys::getHostCPUFeatures(features))
+ const StringMap features =
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/9] [llvm][TargetParser] Return optional from
@@ -492,6 +495,13 @@ Modified Compiler Flags
now include dianostics about C++26 features that are not present in older
versions.
+- Removed the "arm interrupt calling convention" warning that was included in
+ ``-Wextra`` without its own flag. This warning suggested
DavidSpickett wrote:
Everything LGTM but I'd like someone who works on Arm's downstream compiler to
approve. @ostannard perhaps?
(thanks for your patience @chrisnc)
https://github.com/llvm/llvm-project/pull/91870
___
cfe-commits mailing list
@@ -1329,6 +1329,11 @@ void SemaARM::handleInterruptAttr(Decl *D, const
ParsedAttr ) {
return;
}
+ const TargetInfo = getASTContext().getTargetInfo();
+ if (TI.hasFeature("vfp")) {
+Diag(D->getLocation(), diag::warn_arm_interrupt_vfp_clobber);
+ }
@@ -13,6 +13,7 @@
#ifndef LLVM_TARGETPARSER_HOST_H
#define LLVM_TARGETPARSER_HOST_H
+#include
DavidSpickett wrote:
Done.
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
@@ -15,21 +15,22 @@
#include "llvm/Support/raw_ostream.h"
#include "llvm/TargetParser/Host.h"
+#include
+
DavidSpickett wrote:
Done.
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/5] [llvm][TargetParser] Return optional from
DavidSpickett wrote:
> Why not return a map every time?
Done.
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/4] [llvm][TargetParser] Return optional from
DavidSpickett wrote:
Fair point, iirc all the callers go on to iterate the map so no one is handling
failure in a special way. I'll update this.
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DavidSpickett wrote:
Re. the test failure, I've been disabling these and collecting them in
https://github.com/llvm/llvm-project/issues/97712. Let me know if you see any
others.
https://github.com/llvm/llvm-project/pull/97829
___
cfe-commits mailing
@@ -22,13 +22,13 @@ using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- if (std::optional> features =
+ if (const std::optional> features =
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/3] [llvm][TargetParser] Return optional from
@@ -22,13 +22,13 @@ using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- if (std::optional> features =
+ if (const std::optional> features =
@@ -15,22 +15,23 @@
#include "llvm/Support/raw_ostream.h"
#include "llvm/TargetParser/Host.h"
+#include
+
using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- StringMap
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/2] [llvm][TargetParser] Return optional from
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1710,15 +1710,17 @@ VendorSignatures getVendorSignature(unsigned *MaxLeaf) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
-bool sys::getHostCPUFeatures(StringMap ) {
+std::optional> sys::getHostCPUFeatures() {
unsigned EAX =
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/97824
Previously this took a reference to a map and returned a bool to say whether it
succeeded. This is an optional but with more steps.
The only reason to keep it that way was if someone was appending to an
DavidSpickett wrote:
Looks ok to me, X86 and ARM already do this.
> One point we noticed is that it could end up turning "aes+sha2" into "crypto"
> and "crypto" back into "sha2+aes+sha3+sm4", as it uses the old meaning of
> "crypto"
Then this needs to be fixed before this PR can go in, we
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Also remove the comment that links to
https://github.com/llvm/llvm-project/issues/94994 and add `Fixes #94994` to the
commit message.
https://github.com/llvm/llvm-project/pull/97071
@@ -343,7 +350,9 @@ bool isX18ReservedByDefault(const Triple );
// themselves, they are sequential (0, 1, 2, 3, ...).
uint64_t getCpuSupportsMask(ArrayRef FeatureStrs);
-void PrintSupportedExtensions(StringMap DescMap);
+void PrintSupportedExtensions();
+
+void
DavidSpickett wrote:
I very much doubt it is, your change is still in the next build
(https://lab.llvm.org/buildbot/#/builders/134/builds/681) and that's green.
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
@@ -448,6 +448,11 @@ Modified Compiler Flags
evaluating to ``true`` and an empty body such as ``while(1);``)
are considered infinite, even when the ``-ffinite-loop`` flag is set.
+- Removed "arm interrupt calling convention" warning that was included in
+ ``-Wextra``
@@ -336,9 +336,12 @@ def warn_anyx86_excessive_regsave : Warning<
" with attribute 'no_caller_saved_registers'"
" or be compiled with '-mgeneral-regs-only'">,
InGroup>;
-def warn_arm_interrupt_calling_convention : Warning<
- "call to function without interrupt
DavidSpickett wrote:
Linaro will look into this.
Reproducing the build is quite easy if you do want to look yourselves in the
meantime:
```
$ ./libcxx/utils/ci/run-buildbot
armv7m-picolibc-no-exceptions
```
You'll need a recent `qemu-system-arm` installed to run the tests, I have 8.1.3
@@ -204,6 +238,10 @@ int cc1_main(ArrayRef Argv, const char
*Argv0, void *MainAddr) {
if (Clang->getFrontendOpts().PrintSupportedExtensions)
return PrintSupportedExtensions(Clang->getTargetOpts().Triple);
+ // --print-enabled-extensions takes priority over the actual
@@ -19,3 +19,19 @@
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
//
@@ -161,6 +162,39 @@ static int PrintSupportedExtensions(std::string TargetStr)
{
return 0;
}
+static int PrintEnabledExtensions(const TargetOptions& TargetOpts) {
DavidSpickett wrote:
Cool, happy to "when in Rome" here and leave it as is.
@@ -13,3 +13,57 @@
// RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6a -### -c %s
2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s
// RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6-a -### -c %s
2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s
//
@@ -19,3 +19,19 @@
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
//
DavidSpickett wrote:
Also please list the impact, if any, on `--print-supported-extensions` in the
commit message. I think it got a column with the FEAT_ names added, which is a
nice improvement.
https://github.com/llvm/llvm-project/pull/95805
___
@@ -204,6 +238,10 @@ int cc1_main(ArrayRef Argv, const char
*Argv0, void *MainAddr) {
if (Clang->getFrontendOpts().PrintSupportedExtensions)
return PrintSupportedExtensions(Clang->getTargetOpts().Triple);
+ // --print-enabled-extensions takes priority over the actual
@@ -134,17 +136,39 @@ std::optional
AArch64::parseCpu(StringRef Name) {
return {};
}
-void AArch64::PrintSupportedExtensions(StringMap DescMap) {
+void AArch64::PrintSupportedExtensions() {
outs() << "All available -march extensions for AArch64\n\n"
<< ""
@@ -13,3 +13,57 @@
// RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6a -### -c %s
2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s
// RUN: %clang --target=aarch64_be -mbig-endian -march=armv8.6-a -### -c %s
2>&1 | FileCheck -check-prefix=GENERICV86A-BE %s
//
@@ -161,6 +162,39 @@ static int PrintSupportedExtensions(std::string TargetStr)
{
return 0;
}
+static int PrintEnabledExtensions(const TargetOptions& TargetOpts) {
DavidSpickett wrote:
Is int here just following the local code style or would bool do?
@@ -19,3 +19,19 @@
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
// RUN: %clang --target=arm64 -mlittle-endian -march=armv8.1-a -### -c %s 2>&1
| FileCheck -check-prefix=ARM64-GENERICV81A %s
//
https://github.com/DavidSpickett commented:
Cool idea, should be very useful.
The TableGen has changed so much since I last looked so I didn't look over that
myself.
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/95805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5703,6 +5703,11 @@ def print_supported_extensions : Flag<["-", "--"],
"print-supported-extensions">
Visibility<[ClangOption, CC1Option, CLOption]>,
HelpText<"Print supported -march extensions (RISC-V, AArch64 and ARM only)">,
MarshallingInfoFlag>;
+def
DavidSpickett wrote:
> I'd like to also address https://github.com/llvm/llvm-project/issues/47815,
> but I wasn't able to find the right path to answer "is this M-profile" from
> TargetInfo.
Any ARM folks know if there are existing M profile only warnings to learn from?
@@ -544,6 +548,14 @@ Improvements to Clang's diagnostics
- Clang no longer emits a "declared here" note for a builtin function that has
no declaration in source.
Fixes #GH93369.
+- On ARM, Clang no longer suggests adding ``__attribute__((interrupt))`` to
@@ -384,6 +384,10 @@ Modified Compiler Flags
evaluating to ``true`` and an empty body such as ``while(1);``)
are considered infinite, even when the ``-ffinite-loop`` flag is set.
+- Removed "arm interrupt calling convention" warning that was included in
@@ -336,9 +336,10 @@ def warn_anyx86_excessive_regsave : Warning<
" with attribute 'no_caller_saved_registers'"
" or be compiled with '-mgeneral-regs-only'">,
InGroup>;
-def warn_arm_interrupt_calling_convention : Warning<
- "call to function without interrupt
https://github.com/DavidSpickett commented:
I can't fully approve this, I leave that to other members of
@llvm/pr-subscribers-arm .
2 overall comments:
* Calling a function marked interrupt from a function marked interrupt is still
UB isn't it? Should there be another warning to cover that
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91870
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Spickett
Date: 2024-06-10T16:14:53+01:00
New Revision: c32428151678f05fa3a9b5996e07f1e67094626c
URL:
https://github.com/llvm/llvm-project/commit/c32428151678f05fa3a9b5996e07f1e67094626c
DIFF:
DavidSpickett wrote:
You can debug it by cross-compiling a debug build, then running the unit tests
binary and connecting to qemu's built in gdbserver. The Arm toolchain might
have a copy of gdb in it already, but if not, gdb multiarch and lldb would also
work (which are both installable from
DavidSpickett wrote:
Looks like this fixed things:
https://lab.llvm.org/buildbot/#/builders/245/builds/25578
Thanks for working with me on this.
https://github.com/llvm/llvm-project/pull/94603
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DavidSpickett wrote:
Actually, as someone pointed out, I've been conflating clang-repl with the
constant expression interpreter. So the issue covers the latter and this must
be something else.
https://github.com/llvm/llvm-project/pull/89811
___
DavidSpickett wrote:
> I will get you instructions on how to do that (will be tomorrow at this
> point).
https://github.com/llvm/llvm-project/issues/94741#issuecomment-2154656315
There is some underlying issue
(https://github.com/llvm/llvm-project/issues/94741), so if you want to try and
Author: David Spickett
Date: 2024-06-07T10:38:25Z
New Revision: 54c5dbe7c3812461decbccb6ed122e41777e02bd
URL:
https://github.com/llvm/llvm-project/commit/54c5dbe7c3812461decbccb6ed122e41777e02bd
DIFF:
https://github.com/llvm/llvm-project/commit/54c5dbe7c3812461decbccb6ed122e41777e02bd.diff
DavidSpickett wrote:
Ok, this new version passes `check-llvm` and `check-clang` (ignoring the
pre-existing failure), using the exact config from
[clang-armv8-quick](https://lab.llvm.org/buildbot/#/builders/245).
https://github.com/llvm/llvm-project/pull/94603
DavidSpickett wrote:
Sure I'll test it now.
BTW if you see `Clang-Unit::ClangReplInterpreterTests/InterpreterTest/Value`
failing on one of our bots, that's not due to your change.
https://github.com/llvm/llvm-project/pull/94603
___
cfe-commits
DavidSpickett wrote:
> My feeling is the latter but how can we get a debug build and debug?
I'm going to try a UBSAN build on the chance it pinpoints the issue right away,
but failing that it'll be cross compiling to Arm 32 bit and using qemu-user to
run the unit test binary. I will get you
DavidSpickett wrote:
It is a 32 bit container running on an arm64 host. As far as the compiler and
tests know, it's a 32 bit system.
> But in either case the width of the int type should be the same, right?
Yes.
So I am wondering if someone of the assumptions about types being larger than
DavidSpickett wrote:
I have bisected a 32 bit Arm failure down to this change:
https://lab.llvm.org/buildbot/#/builders/245/builds/25526
Is it possible that something in this code is truncating a value when
interpreting types intended for a 64 bit system, on a 32 bit system? I don't
see this
DavidSpickett wrote:
I tested locally and this fixes all the test failures.
https://github.com/llvm/llvm-project/pull/94603
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
> Thanks. Reproduced. But it surprised me that I can't run the commands you
> mentioned, but I need to run:
> ./bin/lldb-dotest -p TestTemplateWithSameArg.py -G gmodules
Running the tests as modules is perhaps opt in, we have the ability to run them
with different debug
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/94271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
https://github.com/llvm/llvm-project/pull/94325 will get us past the compiler
error.
Some things I noticed testing that:
* There is an lld installed on the machine but it's in a path with spaces so
lit can't run it. Generally we'd build lld along with lldb and use that in
DavidSpickett wrote:
Maybe you can run individual tests with lit but generally I use `lldb-dotest`
instead:
```
./bin/lldb-dotest.py -p TestTemplateWithSameArg.py
```
(you only need the filename)
https://github.com/llvm/llvm-project/pull/92083
___
DavidSpickett wrote:
I think the issue is
https://developercommunity.visualstudio.com/t/c-shared-state-futuresstate-default-constructs-the/60897
which appears to have been fixed in 19.32 (https://godbolt.org/z/P594qGrc9).
But @slydiman reports 14.29.30133 which is earlier than that. Perhaps
DavidSpickett wrote:
> MSVC 14.29.30133 is VS 2019. We are using VS 2022 with the latest Windows SDK
> to build lldb w/o problems.
I also couldn't reproduce it locally with `19.34.31937`, but I may still be
able to reproduce by making my own version of this PR so I can use the CI's
version.
DavidSpickett wrote:
> I'll do that, but I think LLDB should follow the example of MLIR here
https://github.com/llvm/llvm-project/pull/94220
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DavidSpickett wrote:
> First Windows CI results: LLDB unit tests do not even build.
Linaro's Windows bot uses clang-cl, but I do remember something like this there
too. I will do a local build with msvc and see what I can do.
https://github.com/llvm/llvm-project/pull/94208
DavidSpickett wrote:
And I would bet that a majority of the unresolved are due to:
```
ModuleNotFoundError: No module named 'pexpect'
```
You can either install it with `pip` or pass
`-DLLDB_TEST_USER_ARGS=--skip-category=pexpect` to CMake.
https://github.com/llvm/llvm-project/pull/94208
DavidSpickett wrote:
> lldb-shell :: SymbolFile/DWARF/x86/module-ownership.mm
This is due to https://github.com/llvm/llvm-project/pull/92083, it's been
reverted now.
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
DavidSpickett wrote:
This also broke an lldb test:
https://lab.llvm.org/buildbot/#/builders/96/builds/58449
`lldb-test: ../llvm-project/clang/lib/AST/DeclBase.cpp:132: void
clang::Decl::setOwningModuleID(unsigned int): Assertion `!((*IDAddress) >> 48)
&& "We should only set the module ID
DavidSpickett wrote:
If this is split out from the other larger PR, should there be `clang/` changes
in here?
I've copied your commit message into the PR description, because with the way
llvm is setup, we use the PR's description as the commit message for a squashed
version of the changes.
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/91858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett approved this pull request.
LLDB changes look good to me.
https://github.com/llvm/llvm-project/pull/91857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DavidSpickett wrote:
LLVM uses a GitHub setting where the PR is squashed, and the commit message is
taken from the PR description rather than the commits themselves. So all you
have to do here is copy the commit message you updated into the PR's
description.
Author: David Spickett
Date: 2024-05-03T09:56:23Z
New Revision: fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b
URL:
https://github.com/llvm/llvm-project/commit/fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b
DIFF:
https://github.com/llvm/llvm-project/commit/fb1c2dbc0a6ba641e0b39e0692ec6a4eec4b.diff
DavidSpickett wrote:
@wzssyqa thanks for working with us on this. Bare metal is always a wild card
but I think in the end we'll all have cleaner builds because of these changes.
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/90734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/90734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/90734
That were implemented by https://github.com/llvm/llvm-project/pull/89638.
>From 2d4d5e1885cc8e722b9ebaab81caf2d39c9994da Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 1 May 2024 15:39:31 +0100
DavidSpickett wrote:
libcxx is sorted, and I will write up the release note given that I suggested
it and have been fixing some builds myself.
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DavidSpickett wrote:
Also this change should be release noted with a tip that build scripts may want
to change to asking clang for the triple instead.
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
@@ -217,7 +217,7 @@ function test-armv7m-picolibc() {
"${@}"
${NINJA} -vC "${BUILD_DIR}/compiler-rt" install
-mv "${BUILD_DIR}/install/lib/armv7m-none-unknown-eabi"/*
"${BUILD_DIR}/install/lib"
+mv "${BUILD_DIR}/install/lib/armv7m-unknown-none-eabi"/*
DavidSpickett wrote:
I'm checking the picolib libcxx build right now so please hold off on landing
this.
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
1 - 100 of 385 matches
Mail list logo
