https://github.com/erichkeane commented:
Did a look through, and have no comments. While we could clean up the
`TemplateDeductionResult` enum, I'm hopeful we're getting 'near the end' on it,
and I can't think of a nicer way to break it down, none of the cases are really
well associated with e
https://github.com/erichkeane approved this pull request.
Fine other than the release note not being clear enough
https://github.com/llvm/llvm-project/pull/93266
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm
@@ -784,6 +784,7 @@ Miscellaneous Bug Fixes
- Fixed an infinite recursion in ASTImporter, on return type declared inside
body of C++11 lambda without trailing return (#GH68775).
- Fixed declaration name source location of instantiated function definitions
(GH71161).
+- Missi
https://github.com/erichkeane approved this pull request.
I don't quite get the justification for this, but also don't see any downside
for it, so I think this is acceptable.
https://github.com/llvm/llvm-project/pull/92854
___
llvm-branch-commits mail
https://github.com/erichkeane approved this pull request.
Seems reasonable, lgtm.
https://github.com/llvm/llvm-project/pull/92855
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
https://github.com/erichkeane approved this pull request.
This seems useful enough with little enough impact to add to the release
branch. If we've got another one coming, I see no reason not to.
https://github.com/llvm/llvm-project/pull/91890
___
ll
https://github.com/erichkeane approved this pull request.
I think this makes sense, 2 nits, else LGTM.
https://github.com/llvm/llvm-project/pull/90961
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bi
@@ -2744,31 +2744,155 @@ bool hasDeclaredDeductionGuides(DeclarationName Name,
DeclContext *DC) {
return false;
}
+unsigned getTemplateDepth(NamedDecl *TemplateParam) {
+ if (auto *TTP = dyn_cast(TemplateParam))
+return TTP->getDepth();
+ if (auto *TTP = dyn_cast(Temp
@@ -2744,31 +2744,155 @@ bool hasDeclaredDeductionGuides(DeclarationName Name,
DeclContext *DC) {
return false;
}
+unsigned getTemplateDepth(NamedDecl *TemplateParam) {
erichkeane wrote:
are we in an anonymous namespace? Else this should be 'static'.
htt
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/90961
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/89030
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -2876,6 +2876,15 @@ def flax_vector_conversions : Flag<["-"],
"flax-vector-conversions">, Group, Group,
HelpText<"Force linking the clang builtins runtime library">;
+
+/// ClangIR-specific options - BEGIN
+def fclangir_enable : Flag<["-"], "fclangir-enable">, Visibility<[C
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/86080
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
I see this is irrelevant now, but noticed I had a pair of pending comments and
wanted the other one.
https://github.com/llvm/llvm-project/pull/86080
___
llvm-branch-commits mailing list
llvm-branch-
@@ -0,0 +1,11 @@
+//===- CIRDialect.cpp - MLIR CIR ops implementation
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
erichkeane wrote:
we should probably still create this file with the comment header and include
guards at this point.
https://github.com/llvm/llvm-project/pull/86080
___
llvm-branch-commits mailing list
llvm-branch-c
@@ -590,7 +596,7 @@ class FrontendOptions {
EmitSymbolGraph(false), EmitExtensionSymbolGraphs(false),
EmitSymbolGraphSymbolLabelsForTesting(false),
EmitPrettySymbolGraphs(false), GenReducedBMI(false),
-TimeTraceGranularity(500) {}
+UseCla
@@ -2876,6 +2876,15 @@ def flax_vector_conversions : Flag<["-"],
"flax-vector-conversions">, Group, Group,
HelpText<"Force linking the clang builtins runtime library">;
+
+/// ClangIR-specific options - BEGIN
+def fclangir_enable : Flag<["-"], "fclangir-enable">, Visibility<[C
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/88453
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
Just got back from WG21, so sorry for the delay. While we don't USUALLY do
backports like this that fix something that was present in the last release, I
think this ends up being reasonably low risk, we haven't seen any bugs
regarding this SINCE, and worst-case it breaks `-W
erichkeane wrote:
As far as I can tell, this isn't fixing a regression in Clang17, and thus isn't
really a candidate for inclusion into the 18.x branches.
https://github.com/llvm/llvm-project/pull/84912
___
llvm-branch-commits mailing list
llvm-branch
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/80120
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
Does this fix a regression against 17? I didn't think it did?
https://github.com/llvm/llvm-project/pull/80120
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llv
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/79997
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
> @erichkeane What do you think about merging this PR to the release branch?
We absolutely should! Please do.
https://github.com/llvm/llvm-project/pull/79997
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
ht
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/79400
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
erichkeane wrote:
Author seems to have disappeared, so approving.
https://github.com/llvm/llvm-project/pull/79400
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commit
erichkeane wrote:
I'd like us to give the author a chance to fix the original so that this
feature can get into 18, but this being here will be helpful in case he is
unable to.
https://github.com/llvm/llvm-project/pull/79400
___
llvm-branch-commits m
https://github.com/erichkeane commented:
The clang changes are ok, but this needs some level of documentation/release
notes, which I don't see in the clang release. As this is a part of a larger
feature, do we intend to push that later?
Also, the clang-format suggestion makes sense.
https://
Author: Erich Keane
Date: 2023-03-10T06:04:27-08:00
New Revision: a9e129ed8806cc313fcda5017f25206cf73c42ea
URL:
https://github.com/llvm/llvm-project/commit/a9e129ed8806cc313fcda5017f25206cf73c42ea
DIFF:
https://github.com/llvm/llvm-project/commit/a9e129ed8806cc313fcda5017f25206cf73c42ea.diff
L
Author: Erich Keane
Date: 2021-01-20T11:35:52-08:00
New Revision: 8776e3f289c19ee2e85c593792806e6503408d59
URL:
https://github.com/llvm/llvm-project/commit/8776e3f289c19ee2e85c593792806e6503408d59
DIFF:
https://github.com/llvm/llvm-project/commit/8776e3f289c19ee2e85c593792806e6503408d59.diff
L
Author: Erich Keane
Date: 2021-01-14T11:24:06-08:00
New Revision: 9e53c94d8dd737fcedb543d6ac687ea9696db8a6
URL:
https://github.com/llvm/llvm-project/commit/9e53c94d8dd737fcedb543d6ac687ea9696db8a6
DIFF:
https://github.com/llvm/llvm-project/commit/9e53c94d8dd737fcedb543d6ac687ea9696db8a6.diff
L
Author: Erich Keane
Date: 2021-01-07T09:14:36-08:00
New Revision: 43043adcfbc60945646b791d7162e5a1307a5318
URL:
https://github.com/llvm/llvm-project/commit/43043adcfbc60945646b791d7162e5a1307a5318
DIFF:
https://github.com/llvm/llvm-project/commit/43043adcfbc60945646b791d7162e5a1307a5318.diff
L
Author: Erich Keane
Date: 2021-01-06T07:17:12-08:00
New Revision: 3fa6cedb6be809092f8a8b27e63bd4f6dc526a08
URL:
https://github.com/llvm/llvm-project/commit/3fa6cedb6be809092f8a8b27e63bd4f6dc526a08
DIFF:
https://github.com/llvm/llvm-project/commit/3fa6cedb6be809092f8a8b27e63bd4f6dc526a08.diff
L
Author: Erich Keane
Date: 2020-12-07T11:29:57-08:00
New Revision: 1c98f984105e552daa83ed8e92c61fba0e401410
URL:
https://github.com/llvm/llvm-project/commit/1c98f984105e552daa83ed8e92c61fba0e401410
DIFF:
https://github.com/llvm/llvm-project/commit/1c98f984105e552daa83ed8e92c61fba0e401410.diff
L
35 matches
Mail list logo
