[clang-tools-extra] r345952 - [clangd] Fix clang -Wimplicit-fallthrough

2018-11-01 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Nov 1 21:23:50 2018 New Revision: 345952 URL: http://llvm.org/viewvc/llvm-project?rev=345952&view=rev Log: [clangd] Fix clang -Wimplicit-fallthrough Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp

[clang-tools-extra] r345953 - [clangd] Really fix clang -Wimplicit-fallthrough

2018-11-01 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Nov 1 22:59:29 2018 New Revision: 345953 URL: http://llvm.org/viewvc/llvm-project?rev=345953&view=rev Log: [clangd] Really fix clang -Wimplicit-fallthrough The intention was to fall through to Function case in LLVM_ENABLE_ASSERTIONS=Off builds. Use #ifndef NDEBUG to f

r345992 - [analyzer] Fix diagnostics/explicit-suppression.cpp

2018-11-02 Thread Fangrui Song via cfe-commits
Author: maskray Date: Fri Nov 2 09:23:37 2018 New Revision: 345992 URL: http://llvm.org/viewvc/llvm-project?rev=345992&view=rev Log: [analyzer] Fix diagnostics/explicit-suppression.cpp *OI++ = *II++ is on line 670, not 668 Modified: cfe/trunk/test/Analysis/diagnostics/explicit-suppression.c

r347293 - [libclang] Unify getCursorDecl and getCursorParentDecl

2018-11-20 Thread Fangrui Song via cfe-commits
Author: maskray Date: Tue Nov 20 00:00:00 2018 New Revision: 347293 URL: http://llvm.org/viewvc/llvm-project?rev=347293&view=rev Log: [libclang] Unify getCursorDecl and getCursorParentDecl They do the same thing, thus the latter (which has only 2 call sites) can be deleted. Modified: cfe/tr

[clang-tools-extra] r353415 - [ELF] Format lines inadvertently indented by rCTE353380

2019-02-07 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Feb 7 07:38:14 2019 New Revision: 353415 URL: http://llvm.org/viewvc/llvm-project?rev=353415&view=rev Log: [ELF] Format lines inadvertently indented by rCTE353380 Modified: clang-tools-extra/trunk/clangd/SourceCode.h Modified: clang-tools-extra/trunk/clangd/SourceC

r353635 - Use llvm::is_contained. NFC

2019-02-09 Thread Fangrui Song via cfe-commits
Author: maskray Date: Sat Feb 9 21:54:57 2019 New Revision: 353635 URL: http://llvm.org/viewvc/llvm-project?rev=353635&view=rev Log: Use llvm::is_contained. NFC Modified: cfe/trunk/lib/ARCMigrate/ARCMT.cpp cfe/trunk/lib/AST/RecordLayoutBuilder.cpp cfe/trunk/lib/Basic/TargetInfo.cpp

r353697 - Format isInSystemMacro after D55782

2019-02-11 Thread Fangrui Song via cfe-commits
Author: maskray Date: Mon Feb 11 05:30:04 2019 New Revision: 353697 URL: http://llvm.org/viewvc/llvm-project?rev=353697&view=rev Log: Format isInSystemMacro after D55782 Modified: cfe/trunk/include/clang/Basic/SourceManager.h Modified: cfe/trunk/include/clang/Basic/SourceManager.h URL: http

r355176 - Fix file headers. NFC

2019-02-28 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Feb 28 22:49:51 2019 New Revision: 355176 URL: http://llvm.org/viewvc/llvm-project?rev=355176&view=rev Log: Fix file headers. NFC Modified: cfe/trunk/lib/ARCMigrate/TransEmptyStatementsAndDealloc.cpp cfe/trunk/lib/ARCMigrate/TransformActions.cpp cfe/trunk/lib

[clang-tools-extra] r355188 - Fix file headers. NFC

2019-03-01 Thread Fangrui Song via cfe-commits
Author: maskray Date: Fri Mar 1 01:52:53 2019 New Revision: 355188 URL: http://llvm.org/viewvc/llvm-project?rev=355188&view=rev Log: Fix file headers. NFC Modified: clang-tools-extra/trunk/change-namespace/tool/ClangChangeNamespace.cpp clang-tools-extra/trunk/clang-doc/Generators.cpp

r338732 - [analyzer] Make RegionVector use const reference

2018-08-02 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Aug 2 09:29:36 2018 New Revision: 338732 URL: http://llvm.org/viewvc/llvm-project?rev=338732&view=rev Log: [analyzer] Make RegionVector use const reference Modified: cfe/trunk/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Co

Re: r338732 - [analyzer] Make RegionVector use const reference

2018-08-07 Thread Fangrui Song via cfe-commits
d during post-commit review of change r", etc...) Thanks for the tip! Will try to do this next time. On Thu, Aug 2, 2018 at 9:29 AM Fangrui Song via cfe-commits < cfe-commits@lists.llvm.org> wrote: Author: maskray Date: Thu AugĀ  2 09:29:36 2018 New Revision: 338732 U

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread Fangrui Song via cfe-commits
It might be useful to know what other editors do here to know whether this should be a client transformation or baked into the server. Vim syntastic/ale, Emacs flycheck do not seem to do such transformation. What's the editor you are using? On 2018-08-07, Alex L wrote: On Tue, 7 Aug 2018 at 10

Re: [PATCH] D50154: [clangd] capitalize diagnostic messages

2018-08-07 Thread Fangrui Song via cfe-commits
On 2018-08-07, David Blaikie wrote: On Tue, Aug 7, 2018 at 4:02 PM Alex L wrote: On Tue, 7 Aug 2018 at 11:38, David Blaikie wrote: On Tue, Aug 7, 2018 at 11:22 AM Alex L wrote: On Tue, 7 Aug 2018 at 10:52, David Blaikie via cfe-commits < cfe-commits@lists.l

r343660 - [Frontend] Delete -print-decl-contexts

2018-10-02 Thread Fangrui Song via cfe-commits
Author: maskray Date: Tue Oct 2 20:50:44 2018 New Revision: 343660 URL: http://llvm.org/viewvc/llvm-project?rev=343660&view=rev Log: [Frontend] Delete -print-decl-contexts Summary: Its job is covered by -ast-dump. The option is rarely used and lacks many AST nodes which will lead to llvm_unreac

r343721 - [test] Fix -Wunused-variable in rC343665

2018-10-03 Thread Fangrui Song via cfe-commits
Author: maskray Date: Wed Oct 3 13:53:53 2018 New Revision: 343721 URL: http://llvm.org/viewvc/llvm-project?rev=343721&view=rev Log: [test] Fix -Wunused-variable in rC343665 Modified: cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp Modified: cfe/trunk/unittests/ASTMatchers/Dynamic/Pa

r343722 - [ASTMatchers] Fix DynamicASTMatchersTests again

2018-10-03 Thread Fangrui Song via cfe-commits
Author: maskray Date: Wed Oct 3 14:00:44 2018 New Revision: 343722 URL: http://llvm.org/viewvc/llvm-project?rev=343722&view=rev Log: [ASTMatchers] Fix DynamicASTMatchersTests again Modified: cfe/trunk/unittests/ASTMatchers/Dynamic/ParserTest.cpp Modified: cfe/trunk/unittests/ASTMatchers/Dyn

r343738 - Revert "[ASTMatchers] Fix DynamicASTMatchersTests again"

2018-10-03 Thread Fangrui Song via cfe-commits
Author: maskray Date: Wed Oct 3 15:56:26 2018 New Revision: 343738 URL: http://llvm.org/viewvc/llvm-project?rev=343738&view=rev Log: Revert "[ASTMatchers] Fix DynamicASTMatchersTests again" This reverts commit 8a6631a983ec9c1d22cc77c5f55a524a651740f0. The last fix seems good in Debug mode. Mod

[clang-tools-extra] r343912 - [clangd] Remove unused headers from CodeComplete.cpp

2018-10-06 Thread Fangrui Song via cfe-commits
Author: maskray Date: Sat Oct 6 00:00:50 2018 New Revision: 343912 URL: http://llvm.org/viewvc/llvm-project?rev=343912&view=rev Log: [clangd] Remove unused headers from CodeComplete.cpp queue is not used after index-provided completions' merge with those from Sema USRGeneration.h is not used aft

[clang-tools-extra] r343946 - [clangd] Migrate to LLVM STLExtras range API

2018-10-07 Thread Fangrui Song via cfe-commits
Author: maskray Date: Sun Oct 7 10:21:08 2018 New Revision: 343946 URL: http://llvm.org/viewvc/llvm-project?rev=343946&view=rev Log: [clangd] Migrate to LLVM STLExtras range API Modified: clang-tools-extra/trunk/clangd/FileDistance.cpp clang-tools-extra/trunk/clangd/XRefs.cpp Modified:

r344010 - [Index] Use locations to uniquify function-scope BindingDecl USR

2018-10-08 Thread Fangrui Song via cfe-commits
Author: maskray Date: Mon Oct 8 18:02:56 2018 New Revision: 344010 URL: http://llvm.org/viewvc/llvm-project?rev=344010&view=rev Log: [Index] Use locations to uniquify function-scope BindingDecl USR Summary: This makes BindingDecl's of the same name have different USRs, so that references can be

r344098 - [Driver][cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..."

2018-10-09 Thread Fangrui Song via cfe-commits
Author: maskray Date: Tue Oct 9 17:15:33 2018 New Revision: 344098 URL: http://llvm.org/viewvc/llvm-project?rev=344098&view=rev Log: [Driver][cc1][cc1as] Call OptTable::PrintHelp with explicit " [options] file..." Summary: This is to accommodate a change in llvm/lib/Option/OptTable.cpp D51009 R

[clang-tools-extra] r344256 - [clang-move] Remove clang:: qualifier

2018-10-11 Thread Fangrui Song via cfe-commits
Author: maskray Date: Thu Oct 11 09:09:26 2018 New Revision: 344256 URL: http://llvm.org/viewvc/llvm-project?rev=344256&view=rev Log: [clang-move] Remove clang:: qualifier Summary: The use sites are enclosed by `namespace clang`, so clang:: is not necessary. Many unqualified names have already be

r344859 - Use llvm::{all, any, none}_of instead std::{all, any, none}_of. NFC

2018-10-20 Thread Fangrui Song via cfe-commits
Author: maskray Date: Sat Oct 20 10:53:42 2018 New Revision: 344859 URL: http://llvm.org/viewvc/llvm-project?rev=344859&view=rev Log: Use llvm::{all,any,none}_of instead std::{all,any,none}_of. NFC Modified: cfe/trunk/lib/AST/VTableBuilder.cpp cfe/trunk/lib/ASTMatchers/ASTMatchersInternal

[clang] [clang][CodeGen] Emit atomic IR in place of optimized libcalls. (PR #73176)

2024-02-12 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/73176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fb48fd1 - [Driver, test] Fix hlsl-lang-targets.hlsl after #78655

2024-02-12 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-02-12T10:05:22-08:00 New Revision: fb48fd18c240574841378defacadff34238089bb URL: https://github.com/llvm/llvm-project/commit/fb48fd18c240574841378defacadff34238089bb DIFF: https://github.com/llvm/llvm-project/commit/fb48fd18c240574841378defacadff34238089bb.diff

[clang] [Driver] Remove "-android" from compiler-rt library names for legacy LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=off (PR #81044)

2024-02-12 Thread Fangrui Song via cfe-commits
MaskRay wrote: Thanks for the response, so it seems that we need to keep this for a while. https://github.com/llvm/llvm-project/pull/81044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [flang] [flang][Driver] Add -masm option to flang (PR #81490)

2024-02-12 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,13 @@ +// RUN: %flang -target x86_64-unknown-linux -masm=intel -S %s -### 2>&1 | FileCheck --check-prefix=CHECK-INTEL %s MaskRay wrote: `--target=` for new tests https://github.com/llvm/llvm-project/pull/81490

[clang] 9df7189 - [test] Replace aarch64-*-{eabi, gnueabi} with aarch64

2024-02-12 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-02-12T15:00:45-08:00 New Revision: 9df71899bd5dbbaf0640c74cc82a6330dc7760cf URL: https://github.com/llvm/llvm-project/commit/9df71899bd5dbbaf0640c74cc82a6330dc7760cf DIFF: https://github.com/llvm/llvm-project/commit/9df71899bd5dbbaf0640c74cc82a6330dc7760cf.diff

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

2024-02-12 Thread Fangrui Song via cfe-commits
MaskRay wrote: I share a similar concern about not addressing the issue in a target-specific manner. However, I know a lot of confused users by the behavior, and this patch will significantly improve the status quo. I concur with asb's analysis. https://github.com/llvm/llvm-project/pull/80760

[clang] [RISCV] Add canonical ISA string as Module metadata in IR. (PR #80760)

2024-02-12 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/80760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove "-android" from compiler-rt library names for legacy LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=off (PR #81044)

2024-02-13 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/81044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MC/DC] Refactor: Let MCDCConditionID int16_t with zero-origin (PR #81257)

2024-02-14 Thread Fangrui Song via cfe-commits
MaskRay wrote: Yes, zero-based numbering is more conventional in LLVM. https://github.com/llvm/llvm-project/pull/81257 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add fixed point precision macros (PR #81207)

2024-02-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/81207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add fixed point precision macros (PR #81207)

2024-02-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/81207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add fixed point precision macros (PR #81207)

2024-02-14 Thread Fangrui Song via cfe-commits
@@ -768,6 +768,59 @@ void InitializeOpenCLFeatureTestMacros(const TargetInfo &TI, Builder.defineMacro("__opencl_c_int64"); } +std::string ConstructFixedPointLiteral(llvm::APFixedPoint Val, + llvm::StringRef Suffix) { + if (Val.isSigned

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-14 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Why not just enforce -fsanitize=signed-integer-overflow with -fwrapv? I > suspect it's just overlook, and not intentional behavior. +1 We should consider this direction https://github.com/llvm/llvm-project/pull/80089 ___ cfe-commit

[clang] [RISCV] Disable generation of asynchronous unwind tables for RISCV baremetal (PR #81727)

2024-02-14 Thread Fangrui Song via cfe-commits
MaskRay wrote: I wonder whether GCC considers using `-fno-asynchronous-unwind-tables` for all RISC-V configurations. https://github.com/llvm/llvm-project/pull/81727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-14 Thread Fangrui Song via cfe-commits
MaskRay wrote: This is a UI discussion about how command line options should behave. Some folks prefer simpler rules while some prefer smart rules (guessing what the user intends). A [-fwrapv](https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fwrapv) user may either: * rely on t

[clang] [Clang] Add 'CLANG_ALLOW_IMPLICIT_RPATH' to enable toolchain use of -rpath (PR #82004)

2024-02-16 Thread Fangrui Song via cfe-commits
MaskRay wrote: > The Fedora distributors were the only group that were against doing this by > default, so the suggestion is that Fedora uses > -DCLANG_ALLOW_IMPLICIT_RPATH=OFF when building. I think other distributors and I are against this as well. What this PR does can be achieved by addin

[clang] c92dfef - [-Wunsafe-buffer-usage] Remove unused function after 7c3ad9e72bc034ad655a7e16aa73b9864c58768b. NFC

2024-02-16 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-02-16T14:10:43-08:00 New Revision: c92dfefd4686034667e6a7f0b012b4df421843e5 URL: https://github.com/llvm/llvm-project/commit/c92dfefd4686034667e6a7f0b012b4df421843e5 DIFF: https://github.com/llvm/llvm-project/commit/c92dfefd4686034667e6a7f0b012b4df421843e5.diff

[clang] [Driver] Remove dead -freroll-loops flag (PR #82254)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/82254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Disable generation of asynchronous unwind tables for RISCV baremetal (PR #81727)

2024-02-19 Thread Fangrui Song via cfe-commits
@@ -421,3 +421,11 @@ // MIPSN32R6EL: "-target-cpu" "mips64r6" // MIPSN32R6EL: "-target-abi" "n32" // MIPSN32R6EL: "-mfloat-abi" "hard" + +// RUN: %clang --target=riscv32-unknown-elf --gcc-toolchain="" -### %s 2>&1 | FileCheck %s -check-prefix=NOUWTABLE MaskRay

[clang] [RISCV] Disable generation of asynchronous unwind tables for RISCV baremetal (PR #81727)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/81727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Disable generation of asynchronous unwind tables for RISCV baremetal (PR #81727)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/81727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Unify InstalledDir and Dir (PR #80527)

2024-02-19 Thread Fangrui Song via cfe-commits
MaskRay wrote: > From my point of view, I think this sounds fine - it looks like you've looked > through this and thought deeper about it than I have at least. I'm not deep > enough into this to comfortably press approved on this for now though, so > hopefully someone else can chime in as well

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/81037 >From f246fe8c72f4f3fcb88bdbaaff5c6f23f35d58bf Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 7 Feb 2024 12:56:05 -0800 Subject: [PATCH] [Driver] Improve error when a compiler-rt library is not found BS

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/81037 >From f332e700637f9dfec5712100b8608737f75dd255 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 7 Feb 2024 12:56:05 -0800 Subject: [PATCH] [Driver] Improve error when a compiler-rt library is not found BS

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/81037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/81037 >From 610b14d9998793f2f04a4334bcae2408d4b55b78 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 7 Feb 2024 12:56:05 -0800 Subject: [PATCH] [Driver] Improve error when a compiler-rt library is not found BS

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay ready_for_review https://github.com/llvm/llvm-project/pull/81037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/81037 >From 101f71337a84d705b15738ddf12ff8df6f06c3bd Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 7 Feb 2024 12:56:05 -0800 Subject: [PATCH] [Driver] Improve error when a compiler-rt library is not found BS

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/81037 >From 1efa872cbf29fa3ad69a9c56aa7e270d44adbc32 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Wed, 7 Feb 2024 12:56:05 -0800 Subject: [PATCH] [Driver] Improve error when a compiler-rt library is not found BS

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-19 Thread Fangrui Song via cfe-commits
MaskRay wrote: I added an AIX workaround because AIX hasn't migrated to the new layout and two AIX tests would fail without the workaround. @daltenty https://github.com/llvm/llvm-project/pull/81037 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-20 Thread Fangrui Song via cfe-commits
MaskRay wrote: > GCC folks have not answered. Adding -wrap keeps the behavior for -overflow > the same between GCC and Clang. Can we please move this forward and land it > as is? We can trivially change this in the future if we need to. I believe we can move forward by reusing `-fsanitize=sign

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-20 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. . https://github.com/llvm/llvm-project/pull/80089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Improve error when a compiler-rt library is not found (PR #81037)

2024-02-20 Thread Fangrui Song via cfe-commits
@@ -44,9 +43,8 @@ // CHECK-V6M-DEFAULTCXX: "-resource-dir" "[[RESOURCE_DIR:[^"]+]]" // CHECK-V6M-DEFAULTCXX: ld{{(.exe)?}}" "{{.*}}.o" "-Bstatic" "-EL" // CHECK-V6M-DEFAULTCXX-SAME: "-L{{[^"]*}}{{[/\\]+}}Inputs{{[/\\]+}}baremetal_arm{{[/\\]+}}lib" -// CHECK-V6M-DEFAULTCXX-SAME

[clang] [clang][driver] Allow unaligned access on ARMv7 and higher by default (PR #82400)

2024-02-20 Thread Fangrui Song via cfe-commits
@@ -22,6 +22,14 @@ // RUN: %clang -target armv7-windows -### %s 2> %t // RUN: FileCheck --check-prefix=CHECK-UNALIGNED-ARM < %t %s +/// Ensure that by default before ARMv7 we default to +strict-align +// RUN: %clang -target armv6 -### %s 2> %t MaskRay wrote:

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-02-20 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > I believe we can move forward by reusing > > `-fsanitize=signed-integer-overflow`, which adds least complexity to Clang > > and is very reasonable. > > I see a few problems with changing `-fsanitize=signed-integer-overflow`: > > 1. Clang no longer matches GCC's SIO function

[clang] [Clang] Don't use crtbegin/crtend when building for musl. (PR #85089)

2024-03-13 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. Thanks for working on musl but I don't think this is correct. A musl-cross-make build does use crtbegin/crtend, though technically the files can be empty. https://github.com/llvm/llvm-project/pull/85089 _

[clang] [Clang] Don't use crtbegin/crtend when building for musl. (PR #85089)

2024-03-13 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/85089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Don't use crtbegin/crtend when building for musl. (PR #85089)

2024-03-13 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/85089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Driver] Default -msmall-data-limit= to 0 and clean up code (PR #83093)

2024-03-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: > There is some discussion in last (2024/2/29) LLVM sync up meeting: We all > agree that might not useful in linux target and those platforms disable GP > relaxation, like Android and fuchsia; Thanks for having the discussion. The motivation behind my revising this patch was t

[clang] [Driver,CrossWindows] Remove -isystem-after (PR #84121)

2024-03-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: @compnerd https://github.com/llvm/llvm-project/pull/84121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Driver] Default riscv*- triples to -fdebug-default-version=4" (PR #84119)

2024-03-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: Ping:) https://github.com/llvm/llvm-project/pull/84119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 605abe0 - [clang] Initialize AllTocData after #67999

2024-03-13 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-03-13T15:06:55-07:00 New Revision: 605abe0689dfd28aadc9413306f33a4494cf3fb8 URL: https://github.com/llvm/llvm-project/commit/605abe0689dfd28aadc9413306f33a4494cf3fb8 DIFF: https://github.com/llvm/llvm-project/commit/605abe0689dfd28aadc9413306f33a4494cf3fb8.diff

[clang] [llvm] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2024-03-13 Thread Fangrui Song via cfe-commits
@@ -404,6 +404,15 @@ class CodeGenOptions : public CodeGenOptionsBase { /// List of pass builder callbacks. std::vector> PassBuilderCallbacks; + /// List of global variables explicitly specified by the user as toc-data. + std::vector TocDataVarsUserSpecified; + + /// Li

[clang] [Driver,CrossWindows] Remove -isystem-after (PR #84121)

2024-03-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Facebook was using it at one point (can't say if they are currently), I know > that Sony had some interested users as well. > > Yes, the order matters - that was the reason that the flag was implemented in > the first place. Cc @smeenai @pogo59 on whether this option is used.

[clang] [Driver,CrossWindows] Remove -isystem-after (PR #84121)

2024-03-13 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > Facebook was using it at one point (can't say if they are currently), I > > know that Sony had some interested users as well. > > Yes, the order matters - that was the reason that the flag was implemented > > in the first place. > > Cc @smeenai @pogo59 on whether this option

[clang] [UEFI] X86_64 UEFI Clang Driver (PR #76838)

2024-03-13 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,92 @@ +//===--- UEFI.h - UEFI ToolChain Implementations --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0

[clang] [UEFI] X86_64 UEFI Clang Driver (PR #76838)

2024-03-13 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,92 @@ +//===--- UEFI.h - UEFI ToolChain Implementations --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0

[clang] [UEFI] X86_64 UEFI Clang Driver (PR #76838)

2024-03-13 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,92 @@ +//===--- UEFI.h - UEFI ToolChain Implementations --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0

[clang] [UEFI] X86_64 UEFI Clang Driver (PR #76838)

2024-03-13 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,92 @@ +//===--- UEFI.h - UEFI ToolChain Implementations --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0

[clang] [UEFI] X86_64 UEFI Clang Driver (PR #76838)

2024-03-13 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,115 @@ +//===--- UEFI.h - UEFI ToolChain Implementations --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.

[clang] Revert "[Driver] Default riscv*- triples to -fdebug-default-version=4" (PR #84119)

2024-03-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/84119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,45 @@ +# This file is licensed under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception + +package(default_visibility = ["//visibility:public"]) --

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,45 @@ +# This file is licensed under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception + +package(default_visibility = ["//visibility:public"]) + +license

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Ping! llvm-project email notifications are extremely high-volume and nobody can notice every change even if they are subscribed to the relevant labels... If you don't have write/triage role (https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-r

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/81556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. bazel-specific changes often have a title `[bazel] Add clangd support`. Please consider following suit. It would be nice to have a fuller support, but I understand having this cc_library first can make your downstream changes easier, so LG

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -18,7 +18,6 @@ #ifndef LLVM_CLANG_TOOLS_EXTRA_CLANGD_TRANSPORT_H #define LLVM_CLANG_TOOLS_EXTRA_CLANGD_TRANSPORT_H -#include "Feature.h" MaskRay wrote: This change should be removed. https://github.com/llvm/llvm-project/pull/81556

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,46 @@ +# This file is licensed under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception + +package(features = ["layering_check"], MaskRay

[clang-tools-extra] [llvm] [bazel] Add clangd as a library support (PR #81556)

2024-03-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/81556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Don't alias -mstrict-align to -mno-unaligned-access (PR #85350)

2024-03-14 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/85350 GCC ports only supports one of the options, with -mstrict-align preferred by newer ports. And they reject adding such aliases (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111555). We should not support aliases,

[clang] [llvm] [Hexagon] ELF attributes for Hexagon (PR #85359)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -79,7 +80,8 @@ static cl::opt ErrorNoncontigiousRegister( "merror-noncontigious-register", cl::desc("Error for register names that aren't contigious"), cl::init(false)); - +static cl::opt AddBuildAttributes("hexagon-add-build-attributes", +

[clang] [llvm] [Hexagon] ELF attributes for Hexagon (PR #85359)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,20 @@ +/// Enabled by default for assembly +// RUN: %clang -target hexagon-unknown-elf -### %s 2>&1 \ +// RUN:| FileCheck %s -check-prefix CHECK-ENABLED + +/// Can be forced on or off for assembly. +// RUN: %clang -target hexagon-unknown-elf -### %s 2>&1 -mno-defau

[clang] [llvm] [Hexagon] ELF attributes for Hexagon (PR #85359)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -652,6 +660,57 @@ bool HexagonAsmParser::MatchAndEmitInstruction(SMLoc IDLoc, unsigned &Opcode, return finishBundle(IDLoc, Out); return false; } +/// parseDirectiveAttribute +/// ::= .attribute int, int +/// ::= .attribute Tag_name, int +bool HexagonAsmParser::parse

[clang] [llvm] [Hexagon] ELF attributes for Hexagon (PR #85359)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -395,7 +396,8 @@ template class ELFObjectFile : public ELFObjectFileBase { for (const Elf_Shdr &Sec : *SectionsOrErr) { if (Sec.sh_type == ELF::SHT_ARM_ATTRIBUTES || - Sec.sh_type == ELF::SHT_RISCV_ATTRIBUTES) { + Sec.sh_type == ELF::SHT_RISCV_

[clang] [Driver] Don't alias -mstrict-align to -mno-unaligned-access (PR #85350)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -321,9 +321,11 @@ void aarch64::getAArch64TargetFeatures(const Driver &D, } } - if (Arg *A = Args.getLastArg(options::OPT_mno_unaligned_access, - options::OPT_munaligned_access)) { -if (A->getOption().matches(options::OPT_mno_unalign

[clang] [llvm] [Hexagon] ELF attributes for Hexagon (PR #85359)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -251,7 +251,10 @@ StringRef llvm::object::getELFSectionTypeName(uint32_t Machine, unsigned Type) { } break; case ELF::EM_HEXAGON: -switch (Type) { STRINGIFY_ENUM_CASE(ELF, SHT_HEX_ORDERED); } +switch (Type) { + STRINGIFY_ENUM_CASE(ELF, SHT_HEX_ORDERED

[clang] [llvm] [Hexagon] ELF attributes for Hexagon (PR #85359)

2024-03-14 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,24 @@ +/// attribute parsing error cases. + +// RUN: not llvm-mc -triple=hexagon -filetype=asm %s 2>&1 \ +// RUN: | FileCheck %s + + .attribute Tag_unknown_name, 0 +// CHECK: error: attribute name not recognized: Tag_unknown_name MaskRay wrote: Newe

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

2024-03-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/83136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

2024-03-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/83136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86] Add Support for X86 TLSDESC Relocations (PR #83136)

2024-03-15 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,247 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 +; RUN: llc < %s -mtriple=i686 --relocation-model=pic -enable-tlsdesc | FileCheck %s --check-prefix=X86 +; RUN: llc < %s -mtriple=x86_64-pc-linux-gnux32 --reloc

[clang] [Driver] Don't alias -mstrict-align to -mno-unaligned-access (PR #85350)

2024-03-15 Thread Fangrui Song via cfe-commits
@@ -321,9 +321,11 @@ void aarch64::getAArch64TargetFeatures(const Driver &D, } } - if (Arg *A = Args.getLastArg(options::OPT_mno_unaligned_access, - options::OPT_munaligned_access)) { -if (A->getOption().matches(options::OPT_mno_unalign

[clang] [Driver] Don't alias -mstrict-align to -mno-unaligned-access (PR #85350)

2024-03-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/85350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Don't alias -mstrict-align to -mno-unaligned-access (PR #85350)

2024-03-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/85350 >From 94997d2d43a4db288e81e7b4c61d4562645cc5d8 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 14 Mar 2024 19:04:53 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF

[clang] [Driver] Don't alias -mstrict-align to -mno-unaligned-access (PR #85350)

2024-03-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/85350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Don't alias -mstrict-align to -mno-unaligned-access (PR #85350)

2024-03-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/85350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Don't alias -mstrict-align to -mno-unaligned-access (PR #85350)

2024-03-15 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/85350 >From 94997d2d43a4db288e81e7b4c61d4562645cc5d8 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Thu, 14 Mar 2024 19:04:53 -0700 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF

[clang] b8db3e7 - [RISCV,test] Change two -munaligned-access to GCC-supported -mno-strict-align

2024-03-15 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-03-15T10:46:12-07:00 New Revision: b8db3e7c7dddaa14c314a05b92c9fa3df38734e4 URL: https://github.com/llvm/llvm-project/commit/b8db3e7c7dddaa14c314a05b92c9fa3df38734e4 DIFF: https://github.com/llvm/llvm-project/commit/b8db3e7c7dddaa14c314a05b92c9fa3df38734e4.diff

<    7   8   9   10   11   12   13   >