https://github.com/jh7370 approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/97382
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/jh7370 approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/97521
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,140 @@
+# RUN: yaml2obj %s -o %t
+# RUN: llvm-objcopy --remove-section=.foo --strip-symbol=unused %t %t.out
+# RUN: llvm-readelf -Sr %t.out | FileCheck %s
+
+# CHECK: [Nr] Name TypeAddress Off
Size ES Flg Lk Inf Al
+# CHECK-N
https://github.com/jh7370 commented:
Is it worth a test to show a user attempting to strip a symbol referenced by a
crel section? Similarly, a crel section that is associated with a section that
gets stripped? Perhaps not needed, but just a thought.
https://github.com/llvm/llvm-project/pull/97
https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/97521
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -0,0 +1,63 @@
+//===- MCELFExtras.h - Extra functions for ELF --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1117,9 +1155,11 @@ void ELFObjectFile::getRelocationTypeName(
template
Expected
ELFObjectFile::getRelocationAddend(DataRefImpl Rel) const {
- if (getRelSection(Rel)->sh_type != ELF::SHT_RELA)
-return createError("Section is not SHT_RELA");
- return (int64_t)getRela(R
https://github.com/jh7370 commented:
I've skimmed briefly and the changes look reasonable - will look more in depth
on a separate occasion when I have more time.
Not for this PR, but I wonder if there would be some benefit in a
`--decode-crel` and/or `--encode-crel` option that would convert a
@@ -1022,6 +1033,47 @@ ELFObjectFile::section_rel_begin(DataRefImpl Sec)
const {
uintptr_t SHT = reinterpret_cast((*SectionsOrErr).begin());
RelData.d.a = (Sec.p - SHT) / EF.getHeader().e_shentsize;
RelData.d.b = 0;
+ if (reinterpret_cast(Sec.p)->sh_type == ELF::SHT_CRE
@@ -12,8 +12,10 @@
# CHECK: Name TypeAddress Off
Size ES Flg Lk Inf Al
# COMPRESSED:.debug_fooPROGBITS 40
{{.*}} 00 C 0 0 8
# COMPRESSED-NEXT: .notdebug_foo PROGBITS
https://github.com/jh7370 commented:
Looks basically fine to me.
https://github.com/llvm/llvm-project/pull/84885
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/84885
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -214,33 +214,34 @@ static Error dumpSectionToFile(StringRef SecName,
StringRef Filename,
SecName.str().c_str());
}
-static bool isCompressable(const SectionBase &Sec) {
- return !(Sec.Flags & ELF::SHF_COMPRESSED) &&
- StringRef(Sec.Name)
https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/83751
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -344,21 +344,26 @@ Changes to the LLVM tools
* Fixed big-endian support in llvm-symbolizer's DWARF location parser.
* llvm-readelf now supports ``--extra-sym-info`` (``-X``) to display extra
information (section name) when showing symbols.
-
-* ``llvm-nm`` now supports the
https://github.com/jh7370 approved this pull request.
LGTM (I haven't attempted to review the list of changes to make sure you
haven't missed any).
https://github.com/llvm/llvm-project/pull/83751
___
llvm-branch-commits mailing list
llvm-branch-commit
https://github.com/jh7370 approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/82470
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
jh7370 wrote:
Functionally, I'm confident this is safe, but I don't know whether it's too
late in the cycle to be picking additional non-bug fix commits. @tstellar?
Also, as noted in the original PR, the corresponding doc change needs picking
too.
https://github.com/llvm/llvm-project/pull/823
https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/82187
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -143,3 +143,10 @@ ELF_RELOC(R_ARM_THM_BF16, 0x88)
ELF_RELOC(R_ARM_THM_BF12, 0x89)
ELF_RELOC(R_ARM_THM_BF18, 0x8a)
ELF_RELOC(R_ARM_IRELATIVE, 0xa0)
+ELF_RELOC(R_ARM_GOTFUNCDESC,0xa1)
+ELF_RELOC(R_ARM_GOTOFFFUN
https://github.com/jh7370 commented:
BinaryFormat/llvm-readobj aspects looks fine to me, but the assembler side of
things goes a bit over my head, so you'll need someone else to review that area.
https://github.com/llvm/llvm-project/pull/82187
___
llv
https://github.com/jh7370 edited https://github.com/llvm/llvm-project/pull/74880
___
llvm-branch-commits mailing list
llvm-branch-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits
@@ -1,16 +1,16 @@
; RUN: llvm-cvtres /h > %t
-; RUN: FileCheck -input-file=%t %s -check-prefix=HELP_TEST
+; RUN: FileCheck -input-file=%t %s --strict-whitespace -check-prefix=HELP_TEST
-; HELP_TEST: OVERVIEW: Resource Converter
-; HELP_TEST-DAG: USAGE: llvm-cvtres [options
https://github.com/jh7370 commented:
> > Is the main functionality of this test actually tested in the current
> > patch? It doesn't seem to be to me.
> I don't fully understand your comment, I am working on getting some of the
> test to be whitespace strict to specifically test the functionali
https://github.com/jh7370 commented:
Is the main functionality of this test actually tested in the current patch? It
doesn't seem to be to me.
https://github.com/llvm/llvm-project/pull/74880
___
llvm-branch-commits mailing list
llvm-branch-commits@lis
Author: James Henderson
Date: 2021-09-21T09:48:35+01:00
New Revision: 5b95eb0b442e8eaa6b90ff765a3ad4c271c2d9eb
URL:
https://github.com/llvm/llvm-project/commit/5b95eb0b442e8eaa6b90ff765a3ad4c271c2d9eb
DIFF:
https://github.com/llvm/llvm-project/commit/5b95eb0b442e8eaa6b90ff765a3ad4c271c2d9eb.dif
Author: James Henderson
Date: 2021-01-25T09:58:56Z
New Revision: b37a349ff2442e73ceafeee982afb430359e08b1
URL:
https://github.com/llvm/llvm-project/commit/b37a349ff2442e73ceafeee982afb430359e08b1
DIFF:
https://github.com/llvm/llvm-project/commit/b37a349ff2442e73ceafeee982afb430359e08b1.diff
LO
Author: James Henderson
Date: 2021-01-20T11:50:00Z
New Revision: f07403eb1a5f781b1bcc2b0c18ef7f632e1a0fdc
URL:
https://github.com/llvm/llvm-project/commit/f07403eb1a5f781b1bcc2b0c18ef7f632e1a0fdc
DIFF:
https://github.com/llvm/llvm-project/commit/f07403eb1a5f781b1bcc2b0c18ef7f632e1a0fdc.diff
LO
28 matches
Mail list logo