Downloaded files in source() are required to be unique. A common
violation of this is from community named files (i.e. LICENSE) that
aren't part of an upstream tarball.
Warn if a source file is downloaded, doesn't have an overriding name,
and has a commonly used name, ignoring extension and
Signed-off-by: James P. Harvey
---
.../tests/pkgbuild/test_nonuniquesources.py | 36 +++
1 file changed, 36 insertions(+)
diff --git a/Namcap/tests/pkgbuild/test_nonuniquesources.py
b/Namcap/tests/pkgbuild/test_nonuniquesources.py
index 1c6d75c..b647051 100644
---
Spent too much time figuring out why I was getting an error of "object
has no attribute 'rule'". Perhaps it's correct spelling and grammer for
"set up" to be two words here, being used as a verb, but I wasn't
expecting that. Maybe this will help someone someday.
Signed off by: James P. Harvey
Signed-off-by: James P. Harvey
---
.../tests/pkgbuild/test_nonuniquesources.py | 36 +++
1 file changed, 36 insertions(+)
diff --git a/Namcap/tests/pkgbuild/test_nonuniquesources.py
b/Namcap/tests/pkgbuild/test_nonuniquesources.py
index 1c6d75c..b8f3542 100644
---
Signed-off-by: James P. Harvey
---
.../tests/pkgbuild/test_nonuniquesources.py | 58 +++
1 file changed, 58 insertions(+)
create mode 100644 Namcap/tests/pkgbuild/test_nonuniquesources.py
diff --git a/Namcap/tests/pkgbuild/test_nonuniquesources.py
Filenames in source() are required to be unique. A common violation of
this is from commonly named files (i.e. LICENSE) that aren't part of an
upstream tarball.
Warn if a source file doesn't have an overriding name, and has a
commonly used name, ignoring extension and case.
Signed-off-by: James
This was originally here, because it used PkgInfoRule, but was changed to use
PkgbuildRule and was left here.
Signed-off-by: James P. Harvey
---
Namcap/rules/__init__.py | 1 +
Namcap/rules/nonuniquesources.py | 34
Namcap/rules/pkginfo.py | 11
Done by:
$ find . -not \( -name .git -prune \) -type f -print0 | xargs -0 sed -i -E
"s/[[:space:]]*$//"
And manually reviewed.
Signed-off-by: James P. Harvey
---
COPYING | 10 +--
Namcap/__init__.py| 6 +-
Namcap/depends.py