Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

I think we are talking at cross purposes. Seems to me you are saying “If we can assert that the answers to questions I ask must always copacetic, then we can express that in software, and that will make things so much easier". I’m saying "my experience of the data debuggers have to deal with i

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 9, 2017, at 7:38 PM, Zachary Turner wrote: > > Sure, but reading a core file involves handling user input. Obviously that > has to be sanitized and you can't crash on user input. I don't think there's > ever been any disagreement about that. On the other hand, if you just type an > e

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

willing to give it a try. You are right that this code is tricky, but it would be worth the effort to fix it right, if for no other reason than to get some other eyes on it. I'm happy to answer any questions as you go along. This code has ping-ponged back and forth between Greg and me, so w

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

d narrow case. IMO the > > "right" fix is #1, but it seems a more radical change. #2 seems tempting in > > terms of code changes, but I find it less compelling overall since > > rollbacks are generally fragile if the code is not designed with that in > >

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 11, 2017, at 4:05 PM, Leonard Mosescu via lldb-commits > wrote: > > > Process already has "Error Process::WillResume()" for this very reason. Just > have the Windows mini dump core file plug-in override it. The code in > Process::Resume already checks this: > Status Process::Private

Re: [Lldb-commits] [lldb-dev] PTYPE replacement in LLDB

The original plan was to add a "type eval" to go alongside "type lookup". "type eval" would take an expression, evaluate it, and then print the resulting type. gdb's type takes either a type name or an expression, but there's no way to disambiguate if you have a type that has the same name as

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

> On Sep 12, 2017, at 11:19 AM, Zachary Turner via lldb-commits > wrote: > > > > On Tue, Sep 12, 2017 at 11:07 AM Greg Clayton wrote: > >> On Sep 12, 2017, at 10:10 AM, Zachary Turner wrote: >> >> >> >> On Tue, Sep 12, 2017 at 10:03 AM Greg Clayton wrote: >>> On Sep 12, 2017, at 9:53 A

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Huh, yeah I don't see any of these bugs as making your point. These are all fixes so I don't see how they argue that we're willfully ignoring anything. To the extent that they deal with asserts they fixes for lldb not remembering that it has to tread carefully to avoid triggering other asserts

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Can you elaborate on this comment. I must be being dense but it didn't parse for me. Jim > On Sep 12, 2017, at 1:21 PM, Zachary Turner wrote: > > Incidentally, if you add --stat to the command line there, you'll see that > only 1 of those CLs has any test coverage at all. I pressed Enter a

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Got that part, didn't get the last PP. Jim > On Sep 12, 2017, at 1:36 PM, Zachary Turner wrote: > > > > On Tue, Sep 12, 2017 at 1:30 PM Jim Ingham wrote: > Can you elaborate on this comment. I must be being dense but it didn't parse > for me. > > Jim > > git log --stat shows you the file

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

Yeah, seems like there's too much heat right now of this to be a useful avenue. Jim > On Sep 12, 2017, at 1:35 PM, Zachary Turner wrote: > > 4ad5334bfcff803f3765e444785b8f9d3a73c683: Don't pass a null StringRef. > simple. > f7b079263a751fdf3adea8e549803aaf92d465f8: Maybe fix it instead, as th

Re: [Lldb-commits] [PATCH] D37651: Fix for bug 34532 - A few rough corners related to post-mortem debugging (core/minidump)

I agree with Jason here, but I guess that's no surprise. Jim > On Sep 12, 2017, at 2:57 PM, Jason Molenda via lldb-commits > wrote: > > Or another way, I don't object to asserts because we hit them so often today. > I object to asserts in a shipping debugger fundamentally - it's not an err

[Lldb-commits] [lldb] r313216 - Forgot to svn add the test cases for breakpoint auto-continue flag.

Author: jingham Date: Wed Sep 13 16:43:26 2017 New Revision: 313216 URL: http://llvm.org/viewvc/llvm-project?rev=313216&view=rev Log: Forgot to svn add the test cases for breakpoint auto-continue flag. Adding that now. Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/breakpoi

[Lldb-commits] [lldb] r313221 - Commands are -d to break modify, not -C.

Author: jingham Date: Wed Sep 13 17:27:36 2017 New Revision: 313221 URL: http://llvm.org/viewvc/llvm-project?rev=313221&view=rev Log: Commands are -d to break modify, not -C. The auto-continue test was using the new (better) name for providing commands (-C) but I haven't checked in that change ye

[Lldb-commits] [lldb] r313293 - Add new files to the cmake lists.

Author: jingham Date: Thu Sep 14 13:31:02 2017 New Revision: 313293 URL: http://llvm.org/viewvc/llvm-project?rev=313293&view=rev Log: Add new files to the cmake lists. Modified: lldb/trunk/source/API/CMakeLists.txt lldb/trunk/source/Breakpoint/CMakeLists.txt Modified: lldb/trunk/source/A

[Lldb-commits] [lldb] r313296 - Remove BreakpointName.h from all targets so it doesn't

Author: jingham Date: Thu Sep 14 13:52:35 2017 New Revision: 313296 URL: http://llvm.org/viewvc/llvm-project?rev=313296&view=rev Log: Remove BreakpointName.h from all targets so it doesn't get included in headermaps or put in a CopyFiles phase. Modified: lldb/trunk/lldb.xcodeproj/project.pbx

[Lldb-commits] [lldb] r313305 - Mention breakpoint names in the tutorial.

Author: jingham Date: Thu Sep 14 15:20:31 2017 New Revision: 313305 URL: http://llvm.org/viewvc/llvm-project?rev=313305&view=rev Log: Mention breakpoint names in the tutorial. Modified: lldb/trunk/www/tutorial.html Modified: lldb/trunk/www/tutorial.html URL: http://llvm.org/viewvc/llvm-proj

[Lldb-commits] [lldb] r313327 - Wire up the breakpoint name help string.

Author: jingham Date: Thu Sep 14 17:52:35 2017 New Revision: 313327 URL: http://llvm.org/viewvc/llvm-project?rev=313327&view=rev Log: Wire up the breakpoint name help string. Modified: lldb/trunk/include/lldb/API/SBBreakpointName.h lldb/trunk/packages/Python/lldbsuite/test/functionalitie

[Lldb-commits] [lldb] r313371 - Remove a couple of warnings pointed out by Ted Woodward.

Author: jingham Date: Fri Sep 15 10:54:37 2017 New Revision: 313371 URL: http://llvm.org/viewvc/llvm-project?rev=313371&view=rev Log: Remove a couple of warnings pointed out by Ted Woodward. Modified: lldb/trunk/source/API/SBBreakpointName.cpp Modified: lldb/trunk/source/API/SBBreakpointName

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

Python based commands will need to be able to call WasInterrupted if they are going to do their jobs. So it would make sense to add an SBCommandInterpreter::WasInterrupted API and make sure that works. And you can already send the interrupt with DispatchInputInterrupt. So it should be pretty

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

I'd really prefer to do this as/along with an SB API test since we also need commands made through the SB API to be interruptible, and we should test that that also works. So this kills two birds with one stone. In general, when developing any high-level features in lldb one of the questions y

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

I disagree. The things we care about are (a) that this works in C++ implemented commands and (b) that it works in Python commands. This doesn't seem to test either of those things. Also, I find writing tests for new functionality to be a great way to inform you about what you need to add to t

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

We agreed to forwards compatibility because people write big scripts that use the SB API, implement GUI's on top of them (more than just Xcode) etc. So we try not to jerk those folks around. That adds a little more responsibility on our part to think carefully about what we add, but the notion

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

> On Sep 19, 2017, at 11:30 AM, Zachary Turner wrote: > > > > On Tue, Sep 19, 2017 at 11:27 AM Jim Ingham wrote: > We agreed to forwards compatibility because people write big scripts that use > the SB API, implement GUI's on top of them (more than just Xcode) etc. So we > try not to jerk

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

IIRC Enrico put in something where we would tell Python to interrupt at points where Python checks for interruptibility, but that is pretty herky-jerky. It would be much better to have the commands control this. Jim > On Sep 19, 2017, at 11:34 AM, Jim Ingham wrote: > > >> On Sep 19, 2017, a

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

Xcode does, I don't know about other UI's. Jim > On Sep 19, 2017, at 11:35 AM, Leonard Mosescu wrote: > > I agree Jim. I'd like like to build thing incrementally - checking in the > current change as is does not preclude adding the SB APIs while it does > provide the foundation. > > I think

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

I must be missing something. DisaptchInputInterrupt knows how to interrupt a running process, and because of Enrico's Python interruption stuff it will interrupt script execution at some point but it wasn't very reliable last time I tried it. But the whole point of this patch is that in gen

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

That seems fine to me. Jim > On Sep 19, 2017, at 11:39 AM, Leonard Mosescu wrote: > > So, how about I look into exposing WasInterrupted() through SB APIs in a > follow up change? > > On Tue, Sep 19, 2017 at 11:36 AM, Jim Ingham wrote: > Xcode does, I don't know about other UI's. > > Jim >

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

> On Sep 19, 2017, at 11:25 AM, Leonard Mosescu wrote: > > These are all great suggestions, thanks everyone! > > > We should have a test. The test would need to use pexpect or something > > similar. If anyone has any pointer on how to make a test for this, please > > chime in. I was thinking

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

Here's a short description of the coding rules and the general idea of how to add API's: http://lldb.llvm.org/SB-api-coding-rules.html If you come across something you wished would have been in this document while you are implementing this, please add it. It's sometimes hard to see some cruci

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

One of the fundamental goals of lldb is that it be an extensible debugger. The extension mechanism for command line lldb all runs through the SB API through either Python or C++ (though most folks choose to use Python). We know first hand that many people take advantage this mechanism to add c

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

Directly WRT testing. I’m not against ALSO adding gtests when you add some functionality. But when your change is actually adding behaviors to lldb, one of the things you need to ask yourself is if this is functionality that extension developers for lldb will benefit from. If it is, then addi

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

I write lots of tests. I don’t really think that the SB API’s are really a barrier to writing tests. The lldbinline tests are trivial to write and can even be made just as a transcription of an lldb command line session, so the barrier to entry is trivial. That is surely the easiest way to wr

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

> On Sep 20, 2017, at 11:25 AM, Zachary Turner wrote: > > > > On Wed, Sep 20, 2017 at 11:14 AM Jim Ingham > wrote: > > The amount of test coverage lldb has at present has much more to do with the > very aggressive schedules lldb has been driven by since its incepti

Re: [Lldb-commits] [PATCH] D37923: Implement interactive command interruption

> On Sep 20, 2017, at 4:16 PM, Leonard Mosescu wrote: > > I don't quite understand the comment about signals adding indeterminacy. No > signal delivery is required to test this part. The lldb driver has a sigint > handler that calls SBDebugger::DispatchInputInterrupt. But since you aren't >

[Lldb-commits] [lldb] r314371 - Revert patch r313904, as it breaks "command source" and in

Author: jingham Date: Wed Sep 27 18:39:07 2017 New Revision: 314371 URL: http://llvm.org/viewvc/llvm-project?rev=314371&view=rev Log: Revert patch r313904, as it breaks "command source" and in particular causes lldb to die on startup if you have a ~/.lldbinit file. I filed: https://bugs.llvm.or

[Lldb-commits] [lldb] r314958 - Another silly little thing you can do with Python commands.

Author: jingham Date: Wed Oct 4 17:49:49 2017 New Revision: 314958 URL: http://llvm.org/viewvc/llvm-project?rev=314958&view=rev Log: Another silly little thing you can do with Python commands. Sometimes you want to step along and print a local each time as you go. You can do that with stop hooks

[Lldb-commits] [lldb] r314959 - Work around a bug in the C++ expression parser.

Author: jingham Date: Wed Oct 4 18:00:29 2017 New Revision: 314959 URL: http://llvm.org/viewvc/llvm-project?rev=314959&view=rev Log: Work around a bug in the C++ expression parser. When the expression parser does name resolution for local variables in C++ closures it doesn't give the local name

[Lldb-commits] [lldb] r315549 - The save_crashlog command was still looking at lldb.target and

Author: jingham Date: Wed Oct 11 19:21:41 2017 New Revision: 315549 URL: http://llvm.org/viewvc/llvm-project?rev=315549&view=rev Log: The save_crashlog command was still looking at lldb.target and lldb.process. That hasn't worked for a long time. Convert it to the form that takes an SBExecutionC

Re: [Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

This thread behavior over fork is the same on Mach, BTW. Apple extended posix_spawnp to take a “Stop at first instruction” attribute, basically just running PT_TRACEME for us. That has ended up being very handy because we get all the nice cleanup behavior that pthread_spawn does, but still get

Re: [Lldb-commits] [PATCH] D38938: Logging: provide a way to safely disable logging in a forked process

See my other message. In a ptrace based system the inferior has to call PT_TRACEME to signal it should be stopped at the first instruction. So you do need to run that code. As I said, Apple added an extension to posix_spawnp to do this for us. Jim > On Oct 16, 2017, at 2:17 PM, Zachary Tu

[Lldb-commits] [lldb] r360730 - Make SBDebugger.RunCommandInterpreter callable from Python.

Author: jingham Date: Tue May 14 17:08:55 2019 New Revision: 360730 URL: http://llvm.org/viewvc/llvm-project?rev=360730&view=rev Log: Make SBDebugger.RunCommandInterpreter callable from Python. Authored by: Lukas Boger Differential Revision: https://reviews.llvm.org/D61602 Added: lldb/trun

[Lldb-commits] [lldb] r361420 - Add DWARFTypeUnit to the Xcode project.

Author: jingham Date: Wed May 22 12:05:59 2019 New Revision: 361420 URL: http://llvm.org/viewvc/llvm-project?rev=361420&view=rev Log: Add DWARFTypeUnit to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL: http://l

[Lldb-commits] [lldb] r361447 - Ack, added DWARFTypeUnit to the wrong target...

Author: jingham Date: Wed May 22 17:12:45 2019 New Revision: 361447 URL: http://llvm.org/viewvc/llvm-project?rev=361447&view=rev Log: Ack, added DWARFTypeUnit to the wrong target... LLDB -> liblldbcore.a Modified: lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h lldb/trunk/lldb.x

Re: [Lldb-commits] [lldb] r361447 - Ack, added DWARFTypeUnit to the wrong target...

I was also eliminating unused const versions of functions in that tree. It wasn't used, so I don't think it matters, but I shouldn't have done it at the same time... Jim > On May 22, 2019, at 5:24 PM, Frédéric Riss wrote: > > > >> On May 22, 2019, at 5:1

[Lldb-commits] [lldb] r361455 - Remove unused const version of CommandInterpreter::GetCommandHistory.

Author: jingham Date: Wed May 22 18:40:33 2019 New Revision: 361455 URL: http://llvm.org/viewvc/llvm-project?rev=361455&view=rev Log: Remove unused const version of CommandInterpreter::GetCommandHistory. Modified: lldb/trunk/include/lldb/Interpreter/CommandInterpreter.h Modified: lldb/trunk/

Re: [Lldb-commits] [lldb] r361447 - Ack, added DWARFTypeUnit to the wrong target...

That should have been a separate commit, I was rushing to get the build unbroken. But this is a good change, we shouldn't silently fail to load the history file, that's pretty confusing. Dumping to the edit line output file is not great but we're not running commands at this point so there's n

Re: [Lldb-commits] [PATCH] D62505: Fix multiple module loaded with the same UUID

> On May 28, 2019, at 7:59 AM, Pavel Labath via Phabricator > wrote: > > labath added a comment. > > In D62505#1519166 , @aadsm wrote: > >> Interesting, I did miss that comment when I checked that class. This is >> something @clayborg was concerned w

Re: [Lldb-commits] [PATCH] D62702: [ABI] Fix SystemV ABI to handle nested aggregate type returned in register

There was a plan - which Adrian may remember more about - to have some API from clang where you could pass in a function signature and have it return dwarf expressions for the locations of all the input parameters, and of the return value directly on exit. That would be the handiest form, dwarf

Re: [Lldb-commits] [PATCH] D62948: lit/Register: Avoid stdio in register write tests

> On Jun 7, 2019, at 2:47 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath planned changes to this revision. > labath added a comment. > > It looks like this problem is more widespread than we originally thought (a > bunch of other tests are affected too). I'll need to t

Re: [Lldb-commits] [PATCH] D63240: [Core] Generalize ValueObject::IsRuntimeSupportValue

> On Jun 27, 2019, at 3:28 PM, Alex Langford via Phabricator > wrote: > > xiaobai added a comment. > > In D63240#1561531 , @jingham wrote: > >> In D63240#1561488 , @xiaobai wrote: >> >>> @jingham: Okay, so I t

[Lldb-commits] [lldb] r364666 - Make sure the thread list is updated before you set the stop reason

Author: jingham Date: Fri Jun 28 10:57:19 2019 New Revision: 364666 URL: http://llvm.org/viewvc/llvm-project?rev=364666&view=rev Log: Make sure the thread list is updated before you set the stop reason on a thread. When talking to some older gdb-remote stubs, We were getting a stop reason from th

[Lldb-commits] [lldb] r364686 - Get the expression parser to handle missing weak symbols.

Author: jingham Date: Fri Jun 28 14:40:05 2019 New Revision: 364686 URL: http://llvm.org/viewvc/llvm-project?rev=364686&view=rev Log: Get the expression parser to handle missing weak symbols. MachO only for this patch. Differential Revision: https://reviews.llvm.org/D63914 Added: lldb/trun

[Lldb-commits] [lldb] r364980 - Fix for r364686 - actually set symbol_is_missing_weak...

Author: jingham Date: Tue Jul 2 16:38:07 2019 New Revision: 364980 URL: http://llvm.org/viewvc/llvm-project?rev=364980&view=rev Log: Fix for r364686 - actually set symbol_is_missing_weak... This was set in a std::function, but I was shadowing a variable that I thought I was capturing. Even with

Re: [Lldb-commits] [lldb] r365390 - [Windows] Convert GetLastError to std::error_code

Why is the thread ID getting checked against -1L? Did Windows not define LLDB_INVALID_HOST_THREAD? Jim > On Jul 8, 2019, at 3:06 PM, Pavel Labath via lldb-commits > wrote: > > Are you sure this will actually produce something meaningful? I know > llvm usually uses llvm::mapWindowsError for th

[Lldb-commits] [lldb] r366506 - The switch to table-genning command options broke

Author: jingham Date: Thu Jul 18 15:18:50 2019 New Revision: 366506 URL: http://llvm.org/viewvc/llvm-project?rev=366506&view=rev Log: The switch to table-genning command options broke the xcode project. This gets it a little closer to working, but I still have to figure out how to generate the ll

[Lldb-commits] [lldb] r366507 - Add an expectedFailure test for type finding.

Author: jingham Date: Thu Jul 18 15:21:16 2019 New Revision: 366507 URL: http://llvm.org/viewvc/llvm-project?rev=366507&view=rev Log: Add an expectedFailure test for type finding. When two .c files define a type of the same name, lldb just picks one and uses it regardless of context. That is not

[Lldb-commits] [lldb] r366508 - Remember to sort the Xcode project!!!

Author: jingham Date: Thu Jul 18 15:25:56 2019 New Revision: 366508 URL: http://llvm.org/viewvc/llvm-project?rev=366508&view=rev Log: Remember to sort the Xcode project!!! Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj ___ lldb-commits mailing

[Lldb-commits] [lldb] r367057 - Remove a project that was completed.

Author: jingham Date: Thu Jul 25 14:29:29 2019 New Revision: 367057 URL: http://llvm.org/viewvc/llvm-project?rev=367057&view=rev Log: Remove a project that was completed. Modified: lldb/trunk/docs/status/projects.rst Modified: lldb/trunk/docs/status/projects.rst URL: http://llvm.org/viewvc/

[Lldb-commits] [lldb] r367059 - Mention adding predicates to settings in the projects page.

Author: jingham Date: Thu Jul 25 14:37:57 2019 New Revision: 367059 URL: http://llvm.org/viewvc/llvm-project?rev=367059&view=rev Log: Mention adding predicates to settings in the projects page. Modified: lldb/trunk/docs/status/projects.rst Modified: lldb/trunk/docs/status/projects.rst URL:

[Lldb-commits] [lldb] r367132 - Document that LLDB_LOG macros use the format_providers.

Author: jingham Date: Fri Jul 26 10:25:20 2019 New Revision: 367132 URL: http://llvm.org/viewvc/llvm-project?rev=367132&view=rev Log: Document that LLDB_LOG macros use the format_providers. Differential Revision: https://reviews.llvm.org/D65293 Modified: lldb/trunk/include/lldb/Utility/Log.h

Re: [Lldb-commits] [lldb] r367385 - [CompletionRequest] Remove unimplemented members.

This wasn't a "weird thing". When you have a match with potentially many hits, it would be very handy to say "give me the first 10", then "give me the next 10" so you only do the work to fetch as much as your paginator would show. That would allow us to avoid unnecessary work when somebody g

Re: [Lldb-commits] [lldb] r367441 - Don't crash when pass by value struct has no definition.

> On Jul 31, 2019, at 12:50 PM, via lldb-commits > wrote: > > > >> -Original Message- >> From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf >> Of Greg Clayton via lldb-commits >> Sent: Wednesday, July 31, 2019 2:29 PM >> To: Raphael Isemann >> Cc: lldb-commits

[Lldb-commits] [lldb] r368340 - Fix a comment which was incorrect.

Author: jingham Date: Thu Aug 8 13:47:40 2019 New Revision: 368340 URL: http://llvm.org/viewvc/llvm-project?rev=368340&view=rev Log: Fix a comment which was incorrect. Modified: lldb/trunk/source/Plugins/OperatingSystem/Python/OperatingSystemPython.cpp Modified: lldb/trunk/source/Plugins/O

Re: [Lldb-commits] [PATCH] D39307: Fix global data symbol resolution

> On Oct 26, 2017, at 9:34 AM, Zachary Turner > wrote: > > Note that $ is a valid character in a MSVC-mangled symbol name. So, I don't > think it will work for that reason alone. FWIW, I also don't like the {,,} > syntax very much, but if you read on there's a sim

[Lldb-commits] [lldb] r316954 - Remove a stray space.

Author: jingham Date: Mon Oct 30 13:44:45 2017 New Revision: 316954 URL: http://llvm.org/viewvc/llvm-project?rev=316954&view=rev Log: Remove a stray space. Modified: lldb/trunk/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntime.cpp Modified: lldb/trunk/source/Plugins/Lan

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

> On Oct 30, 2017, at 5:35 PM, Zachary Turner wrote: > > > On Mon, Oct 30, 2017 at 5:32 PM Jim Ingham via Phabricator > mailto:revi...@reviews.llvm.org>> wrote: > jingham added a comment. > > In https://reviews.llvm.org/D39436#911304 > , @hintonda wro

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

> On Oct 31, 2017, at 9:05 AM, Zachary Turner wrote: > > This is a case where I think a new API *would* be warranted. But it would > not be an API specifically for the -m option. It would instead be an API > that introduces an `SBBreakpointOptions` class, and then add a method called > `Br

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

Not directly, though you can get the ID from the breakpoint you've made, and then do: debugger.HandleCommand("breakpoint modify -m 0 %d"%(ID)) Jim > On Oct 31, 2017, at 8:32 AM, Don Hinton wrote: > > Btw, is there a way to pass the '-m' option via the SB API? I'd like to > exclude matches

[Lldb-commits] [lldb] r317043 - Modernize the example cmdtemplate.py.

Author: jingham Date: Tue Oct 31 15:38:24 2017 New Revision: 317043 URL: http://llvm.org/viewvc/llvm-project?rev=317043&view=rev Log: Modernize the example cmdtemplate.py. This version relies on a newer and more convenient way to use a class to implement a command. It has been in place since ear

Re: [Lldb-commits] [PATCH] D39436: Add regex support to file (-f) and module (-s) breakpoint options.

> On Nov 1, 2017, at 9:54 AM, Greg Clayton via Phabricator > wrote: > > clayborg added a comment. > > In https://reviews.llvm.org/D39436#912828, @zturner wrote: > >> In https://reviews.llvm.org/D39436#912810, @clayborg wrote: >> >>> I was unhappy when we went over two pointers for a FileSpe

Re: [Lldb-commits] [PATCH] D39896: Remove last Host usage from ArchSpec

I'm not sure we have enough instances to decide on better organization, but ArchSpec really doesn't feel like a Utility for lldb. That would be like moving the llvm triple handling to ADT, that seems a little weird. Similarly having the register stuff in Utility seems odd as well. I would nev

[Lldb-commits] [lldb] r318495 - "source list -a" was calling DisplaySourceLinesWithNumbers incorrectly.

Author: jingham Date: Thu Nov 16 17:19:59 2017 New Revision: 318495 URL: http://llvm.org/viewvc/llvm-project?rev=318495&view=rev Log: "source list -a" was calling DisplaySourceLinesWithNumbers incorrectly. The parameters were just passed in the wrong order. Modified: lldb/trunk/source/Comm

[Lldb-commits] [lldb] r318496 - Recognize another magic token sent in the LaunchInfo's EventData.

Author: jingham Date: Thu Nov 16 17:22:34 2017 New Revision: 318496 URL: http://llvm.org/viewvc/llvm-project?rev=318496&view=rev Log: Recognize another magic token sent in the LaunchInfo's EventData. Modified: lldb/trunk/tools/debugserver/source/MacOSX/MachProcess.mm Modified: lldb/trunk/t

Re: [Lldb-commits] [PATCH] D40537: Simplify UUID::IsValid()

How would the ObjectFile API's that take or return UUID's work in this case? Jim > On Nov 28, 2017, at 11:44 AM, Zachary Turner via lldb-commits > wrote: > > Also worth pointing out that when you write things this way, this UUID > class can be part of a larger structure that matches the reco

[Lldb-commits] [lldb] r319226 - Add elf-core/RegisterUtilities.{cpp, h} to the project file.

Author: jingham Date: Tue Nov 28 13:11:15 2017 New Revision: 319226 URL: http://llvm.org/viewvc/llvm-project?rev=319226&view=rev Log: Add elf-core/RegisterUtilities.{cpp,h} to the project file. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pb

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

I'm a little confused by your response. My stated objection to command output dependent tests is and has always been that they make the test dependent on the details of command output. Over time doing so makes it hard to modify command output. This is sort of related to interactivity, in th

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

I'm mostly basing this concern on the bad effect this had on gdb all of whose testing was expect based command scraping. gdb is a tool that's much closer to lldb than any of the compiler tools so that experience seems relevant. It's been a decade or so since I worked on gdb, but back when I wa

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

> On Nov 29, 2017, at 3:46 PM, Zachary Turner wrote: > > FWIW, it can certainly use the SB API where it makes sense, but I think > requiring that it only use the SB API would be very limiting and a big > mistake. > > The entire point of a tool such as this is that it allows you to dig deep

[Lldb-commits] [lldb] r319389 - Fix the gtest target for the move of ArchSpecTest.cpp from Core to Utility.

Author: jingham Date: Wed Nov 29 16:23:42 2017 New Revision: 319389 URL: http://llvm.org/viewvc/llvm-project?rev=319389&view=rev Log: Fix the gtest target for the move of ArchSpecTest.cpp from Core to Utility. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xc

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

I thought we weren't talking about why you want this lldb-test, but rather why tests that poke deep into the lldb_private API's are or are not appropriate for your test dingus. The thing I worry about is if you start using this for very special purpose "reach deep into the lldb_private API's"

Re: [Lldb-commits] [PATCH] D40616: ObjectFileELF: Add support for compressed sections

And of course, one such discipline would be "only use SB API's"... Jim > On Nov 29, 2017, at 5:00 PM, Jim Ingham wrote: > > I thought we weren't talking about why you want this lldb-test, but rather > why tests that poke deep into the lldb_private API's are or are not > appropriate for your

[Lldb-commits] [lldb] r319454 - Remove a long out-of-date comment.

Author: jingham Date: Thu Nov 30 10:35:35 2017 New Revision: 319454 URL: http://llvm.org/viewvc/llvm-project?rev=319454&view=rev Log: Remove a long out-of-date comment. Modified: lldb/trunk/source/Target/Process.cpp Modified: lldb/trunk/source/Target/Process.cpp URL: http://llvm.org/viewvc/

Re: [Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

We had a similar problem with the tests on macOS. lldb has a facility that will do automatic lookup of UUID -> dSYM (macOS's separate debug info format) and if you are internal to Apple this will find all the system library debug info. That will cause a handful of tests to fail, mostly because

Re: [Lldb-commits] [lldb] r319443 - Add a test case for open bug 35480

This test actually almost succeeds on macOS. The problem is that your breakpoint in the Foo constructor produces two line table entries so we hit the foo breakpoint twice. If you change the test file to: Index: packages/Python/lldbsuite/test/functionalities/breakpoint/global_constructor/foo.c

Re: [Lldb-commits] [lldb] r319443 - Add a test case for open bug 35480

The other way to do this would be to pass num_expected_locations = -1 when you make the foo breakpoint, and then grab the breakpoint's number of locations and assume you are going to hit the breakpoint that many times. But changing the code so that the line you are breaking on is unambiguously o

[Lldb-commits] [lldb] r319472 - Fix this test so that the breakpoints you set are

Author: jingham Date: Thu Nov 30 12:43:00 2017 New Revision: 319472 URL: http://llvm.org/viewvc/llvm-project?rev=319472&view=rev Log: Fix this test so that the breakpoints you set are unambiguously on one bit of code. On macOS these lines mapped to two distinct locations, and that was artificiall

[Lldb-commits] [lldb] r319516 - ClangASTContext::ParseClassTemplateDecl doesn't always succeed.

Author: jingham Date: Thu Nov 30 19:41:30 2017 New Revision: 319516 URL: http://llvm.org/viewvc/llvm-project?rev=319516&view=rev Log: ClangASTContext::ParseClassTemplateDecl doesn't always succeed. When it does, it returns a NULL ClassTemplateDecl. Don't use it if it is NULL... Modified:

Re: [Lldb-commits] [lldb] r319516 - ClangASTContext::ParseClassTemplateDecl doesn't always succeed.

his failure anyway, so that effort is really orthogonal to this patch. Jim > On Nov 30, 2017, at 9:45 PM, Davide Italiano wrote: > > On Thu, Nov 30, 2017 at 7:41 PM, Jim Ingham via lldb-commits > wrote: >> Author: jingham >> Date: Thu Nov 30 19:41:30 2017 >> New

Re: [Lldb-commits] [lldb] r319472 - Fix this test so that the breakpoints you set are

h wrote: > > cool. thanks. > > On 30 November 2017 at 20:43, Jim Ingham via lldb-commits > wrote: >> Author: jingham >> Date: Thu Nov 30 12:43:00 2017 >> New Revision: 319472 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=319472&view=rev >

Re: [Lldb-commits] [PATCH] D40475: DWZ 12/12: DWZ test mode

This certainly should be cleared up and centralized. I'm not quite as sure it should be in Platform however. For instance, macOS has the DebugSymbols framework that allows users to specify a local lookup tool to find symbol files given a UUID. That runs only on MacOS and requires MacOS specif

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

Yes, we don't use llvm code in debugserver. It doesn't actually use any lldb classes either, it's its own standalone thing. Jim > On Dec 1, 2017, at 4:01 PM, Zachary Turner via lldb-commits > wrote: > > I don't recall, is there a hard restriction on debugserver not being allowed > to use l

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

If somebody finds themselves ambitious to work on debugserver, they should divert that energy to porting lldb-server to macOS IMHO. Jim > On Dec 1, 2017, at 4:04 PM, Jim Ingham wrote: > > Yes, we don't use llvm code in debugserver. It doesn't actually use any lldb > classes either, it's its

[Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

Author: jingham Date: Fri Dec 1 16:11:18 2017 New Revision: 319598 URL: http://llvm.org/viewvc/llvm-project?rev=319598&view=rev Log: Don't use llvm::EnablePrettyStackTrace on macOS. LLDB.framework gets loaded into Xcode and other frameworks, and this is inserting a signal handler into the proce

Re: [Lldb-commits] [lldb] r319596 - Fix warnings in JSON.cpp, NFC

Yeah, I was not being realistic in saying that. debugserver has a bunch of junk in it specific to our various embedded platforms that isn't actually buildable outside of Apple, but which we need (it's all #ifdef around in the debugserver sources). We aren't going to be able to do away with thi

Re: [Lldb-commits] [lldb] r319598 - Don't use llvm::EnablePrettyStackTrace on macOS.

resent all I have is a bunch of non-reproducible crash reports, I don't know why it isn't working. Jim > > On Sat, Dec 2, 2017 at 12:24 PM Davide Italiano wrote: > Maybe we should remove this feature altogether? > > On Fri, Dec 1, 2017 at 4:11 PM, Jim Ingham vi

[Lldb-commits] [lldb] r319730 - Clean up stop hook output in case a hook restarts.

Author: jingham Date: Mon Dec 4 18:34:05 2017 New Revision: 319730 URL: http://llvm.org/viewvc/llvm-project?rev=319730&view=rev Log: Clean up stop hook output in case a hook restarts. I was warning about the fact that this will abort further stop hooks, but didn't check that there WAS a further

[Lldb-commits] [lldb] r319731 - Add target.process.stop-on-exec setting, and obey it.

Author: jingham Date: Mon Dec 4 18:50:45 2017 New Revision: 319731 URL: http://llvm.org/viewvc/llvm-project?rev=319731&view=rev Log: Add target.process.stop-on-exec setting, and obey it. Also add a test. There should also be control for this in ProcessLaunchInfo and a "target launch" flag, but

[Lldb-commits] [lldb] r320077 - These tests don't depend on debug info format.

Author: jingham Date: Thu Dec 7 11:44:09 2017 New Revision: 320077 URL: http://llvm.org/viewvc/llvm-project?rev=320077&view=rev Log: These tests don't depend on debug info format. Mark them as such. Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/exec/TestExec.py Modifi

Re: [Lldb-commits] [lldb] r321271 - Work around test failures on red-hat linux

This is a trivial thing, but you can use: lldbutil.run_break_set_by_source_regexp rather than having to capture the line number matching the regex and setting a line breakpoint from that. You are setting them in different source files, so you'll have to pass: extra_options = "-f 'One/One.c

<    1   2   3   4   5   6   7   8   9   10   >