[Lldb-commits] [lldb] a8d62fc - Skip all the tests for Windows.

Author: Jim Ingham Date: 2021-03-19T12:05:16-07:00 New Revision: a8d62fc8ff1c836e16cfb1a510ee8063ac2652ff URL: https://github.com/llvm/llvm-project/commit/a8d62fc8ff1c836e16cfb1a510ee8063ac2652ff DIFF: https://github.com/llvm/llvm-project/commit/a8d62fc8ff1c836e16cfb1a510ee8063ac2652ff.diff

[Lldb-commits] [lldb] 9406d43 - Make the stop-on-sharedlibrary-events setting work.

Author: Jim Ingham Date: 2021-03-19T12:02:16-07:00 New Revision: 9406d43138811ac4dfd0ab31434f65a649bc882e URL: https://github.com/llvm/llvm-project/commit/9406d43138811ac4dfd0ab31434f65a649bc882e DIFF: https://github.com/llvm/llvm-project/commit/9406d43138811ac4dfd0ab31434f65a649bc882e.diff

[Lldb-commits] [lldb] 71c4da8 - Don't assume that stepping out of a function will land on the next line.

Author: Jim Ingham Date: 2021-03-18T17:44:17-07:00 New Revision: 71c4da83b67a485f0cfacbce8b46eaa497df900e URL: https://github.com/llvm/llvm-project/commit/71c4da83b67a485f0cfacbce8b46eaa497df900e DIFF: https://github.com/llvm/llvm-project/commit/71c4da83b67a485f0cfacbce8b46eaa497df900e.diff

[Lldb-commits] [lldb] 483ec13 - Use internal_dict everywhere we refer to the python session dict in docs.

Author: Jim Ingham Date: 2021-02-09T17:48:47-08:00 New Revision: 483ec136da7193de781a5284f1c37929cc27c05c URL: https://github.com/llvm/llvm-project/commit/483ec136da7193de781a5284f1c37929cc27c05c DIFF: https://github.com/llvm/llvm-project/commit/483ec136da7193de781a5284f1c37929cc27c05c.diff

[Lldb-commits] [lldb] ffd7be6 - Remove trailing spaces after \ in comments.

Author: Jim Ingham Date: 2021-02-09T16:06:47-08:00 New Revision: ffd7be65d0efbe8448b8fa051ad213be51e8c367 URL: https://github.com/llvm/llvm-project/commit/ffd7be65d0efbe8448b8fa051ad213be51e8c367 DIFF: https://github.com/llvm/llvm-project/commit/ffd7be65d0efbe8448b8fa051ad213be51e8c367.diff

[Lldb-commits] [lldb] 365b186 - Add documentation for the extra_args parameter to breakpoint commands.

Author: Jim Ingham Date: 2021-02-09T15:33:36-08:00 New Revision: 365b186c242b0c3516d7dbb174f3a258c1c8361c URL: https://github.com/llvm/llvm-project/commit/365b186c242b0c3516d7dbb174f3a258c1c8361c DIFF: https://github.com/llvm/llvm-project/commit/365b186c242b0c3516d7dbb174f3a258c1c8361c.diff

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

> On Jan 24, 2021, at 8:30 PM, David Blaikie wrote: > > I guess lldb doesn't have a machine readable form, like gdb's machine > interface that might make for a more robust thing to test against most of the > time (& then leaving a limited number of tests that test the user-textual >

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

lldb creates a single line table out of the debug_line input and the inlined_subroutine info from the debug_info. For instance, if you have a nested set of inlines that all have the same start address, they cannot be represented in the debug_line which requires monotonically increasing

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

If you are just loading an object file and the looking at the line table or something like that, would a UnitTest be more suitable? Jim > On Jan 22, 2021, at 5:37 AM, Pavel Labath wrote: > > On 19/01/2021 23:23, David Blaikie wrote: >> On Tue, Jan 19, 2021 at 1:12 AM Pavel Labath wrote: >>

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

Excellent, thanks for persisting on this! I think your second idea sounds less error prone than having to figure out whether the cache is trustworthy at a particular point. Maybe even better than triggering off a stop event is to clear the caches before we do whatever might make the threads

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

The ThreadPlanStack always has one base thread plan. You can't get rid of that one, the system relies on its always being there. Despite it's name, DiscardThreadPlans doesn't actually discard all the thread plans, just all but the base thread plan... So I think that's neither here nor

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

> On Jan 21, 2021, at 2:33 PM, Jim Ingham wrote: > > > >> On Jan 21, 2021, at 12:51 PM, walter erquinigo via Phabricator >> wrote: >> >> wallace added a comment. >> >> Sorry for returning late to this diff, but I have some additional >> information. This is what's happening: >> >> -

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

> On Jan 21, 2021, at 12:51 PM, walter erquinigo via Phabricator > wrote: > > wallace added a comment. > > Sorry for returning late to this diff, but I have some additional > information. This is what's happening: > > - Before the exec, the base thread plan holds a reference to the thread

[Lldb-commits] [lldb] 98feb08 - Use CXX_SOURCES and point to the right source file.

Author: Jim Ingham Date: 2021-01-20T18:38:07-08:00 New Revision: 98feb08e449f179c3c5ccc6878c31cf16c160b06 URL: https://github.com/llvm/llvm-project/commit/98feb08e449f179c3c5ccc6878c31cf16c160b06 DIFF: https://github.com/llvm/llvm-project/commit/98feb08e449f179c3c5ccc6878c31cf16c160b06.diff

[Lldb-commits] [lldb] bff3891 - Fix a bug with setting breakpoints on C++11 inline initialization statements.

Author: Jim Ingham Date: 2021-01-20T17:58:34-08:00 New Revision: bff389120fa2368d123612449c938958cfd7f45e URL: https://github.com/llvm/llvm-project/commit/bff389120fa2368d123612449c938958cfd7f45e DIFF: https://github.com/llvm/llvm-project/commit/bff389120fa2368d123612449c938958cfd7f45e.diff

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

> On Jan 19, 2021, at 3:34 PM, David Blaikie wrote: > > On Tue, Jan 19, 2021 at 2:55 PM Jim Ingham wrote: >> >> >> >>> On Jan 19, 2021, at 11:40 AM, David Blaikie wrote: >>> >>> On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: > On Jan 17, 2021, at 10:47 AM,

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

> On Jan 19, 2021, at 11:40 AM, David Blaikie wrote: > > On Tue, Jan 19, 2021 at 10:17 AM Jim Ingham wrote: >> >> >> >>> On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: >>> >>> On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: If you set a breakpoint on source lines with

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

> On Jan 17, 2021, at 10:47 AM, David Blaikie wrote: > > On Fri, Jan 15, 2021 at 6:22 PM Jim Ingham wrote: >> >> If you set a breakpoint on source lines with no line table entries, lldb >> slides the actual match forward to the nearest line table entry to the given >> line number. That's

Re: [Lldb-commits] [PATCH] D94846: Allow breakpoints to be set on C++11 inline initializers

If you set a breakpoint on source lines with no line table entries, lldb slides the actual match forward to the nearest line table entry to the given line number. That's necessary for instance because if you lay out your function definitions over multiple lines they won't all get line table

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

testing easier, but we haven't back ported them to old tests. >> If you want other models than the sample_test, look for ones made more >> recently. >> >> There's some description of the API tests here: >> >> https://lldb.llvm.org/resources/t

Re: [Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

Thanks for looking into this further! The thing to figure out is who still has a reference to either the Thread * or to the ThreadPlanStack over the destruction of the thread. That shouldn't be allowed to happen. Jim > On Jan 11, 2021, at 10:01 PM, walter erquinigo via Phabricator > wrote:

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

, David Blaikie wrote: > > > > On Thu, Jan 7, 2021 at 3:37 PM Jim Ingham via lldb-commits > > wrote: > >> > >> > >> > >>> On Jan 7, 2021, at 2:29 PM, David Blaikie via Phabricator via > >>> lldb-commits wrot

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

> On Jan 7, 2021, at 3:57 PM, David Blaikie wrote: > > On Thu, Jan 7, 2021 at 3:37 PM Jim Ingham via lldb-commits > wrote: >> >> >> >>> On Jan 7, 2021, at 2:29 PM, David Blaikie via Phabricator via lldb-commits >>> wrote: >>>

Re: [Lldb-commits] [PATCH] D94063: lldb: Add support for DW_AT_ranges on DW_TAG_subprograms

> On Jan 7, 2021, at 2:29 PM, David Blaikie via Phabricator via lldb-commits > wrote: > > dblaikie added a comment. > > In D94063#2485271 , @labath wrote: > >> In D94063#2483546 , @dblaikie wrote: >> >>> If

Re: [Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

> On Dec 3, 2020, at 5:43 PM, Robinson, Paul wrote: > > > >> -Original Message- >> From: Jim Ingham mailto:jing...@apple.com>> >> Sent: Thursday, December 3, 2020 5:51 PM >> To: David Blaikie >> > >; David >> Blaikie >>

Re: [Lldb-commits] [PATCH] D91734: [FastISel] Flush local value map on every instruction

Note, lldb has a bunch of special handling for line 0 code. For instance, when we are pushing a breakpoint past the prologue we will keep pushing it forward over line number 0 lines. Those are compiler generated and in general people don't want to stop there. Similarly, if you are stepping

[Lldb-commits] [lldb] 5a4b2e1 - The AssertRecognizer used the module from a frames SC without checking it was non-null.

Author: Jim Ingham Date: 2020-11-13T11:41:32-08:00 New Revision: 5a4b2e1541f399c146a4ef5cf8f6aaf8b258a77b URL: https://github.com/llvm/llvm-project/commit/5a4b2e1541f399c146a4ef5cf8f6aaf8b258a77b DIFF: https://github.com/llvm/llvm-project/commit/5a4b2e1541f399c146a4ef5cf8f6aaf8b258a77b.diff

[Lldb-commits] [lldb] 32a85b2 - This is a preliminary version of the test for https://reviews.llvm.org/D88483.

Author: Jim Ingham Date: 2020-10-29T16:39:35-07:00 New Revision: 32a85b268a010035e81646541ac1c9675da6cb2e URL: https://github.com/llvm/llvm-project/commit/32a85b268a010035e81646541ac1c9675da6cb2e DIFF: https://github.com/llvm/llvm-project/commit/32a85b268a010035e81646541ac1c9675da6cb2e.diff

[Lldb-commits] [lldb] fa5a132 - Provide a reasonable value for PATH_MAX if the lldb headers don't provide it.

Author: Jim Ingham Date: 2020-10-29T15:02:51-07:00 New Revision: fa5a13276764a2657b3571fa3c57b07ee5d2d661 URL: https://github.com/llvm/llvm-project/commit/fa5a13276764a2657b3571fa3c57b07ee5d2d661 DIFF: https://github.com/llvm/llvm-project/commit/fa5a13276764a2657b3571fa3c57b07ee5d2d661.diff

[Lldb-commits] [lldb] c8c07b7 - Use !hasLocalLinkage instead of listing the symbol types

Author: Jim Ingham Date: 2020-10-29T14:44:06-07:00 New Revision: c8c07b76b2cf2ada8e7ec132f7f57b97d76743cf URL: https://github.com/llvm/llvm-project/commit/c8c07b76b2cf2ada8e7ec132f7f57b97d76743cf DIFF: https://github.com/llvm/llvm-project/commit/c8c07b76b2cf2ada8e7ec132f7f57b97d76743cf.diff

[Lldb-commits] [lldb] a37672e - Mark the execution of stop-hooks as non-interactive.

Author: Jim Ingham Date: 2020-10-29T14:41:53-07:00 New Revision: a37672e2db7377681d996834a0c3073c9838a549 URL: https://github.com/llvm/llvm-project/commit/a37672e2db7377681d996834a0c3073c9838a549 DIFF: https://github.com/llvm/llvm-project/commit/a37672e2db7377681d996834a0c3073c9838a549.diff

[Lldb-commits] [lldb] 6754caa - Add an SB API to get the SBTarget from an SBBreakpoint

Author: Jim Ingham Date: 2020-10-15T14:28:44-07:00 New Revision: 6754caa9bf21a759c4080a797f23e2b7a77a71e1 URL: https://github.com/llvm/llvm-project/commit/6754caa9bf21a759c4080a797f23e2b7a77a71e1 DIFF: https://github.com/llvm/llvm-project/commit/6754caa9bf21a759c4080a797f23e2b7a77a71e1.diff

[Lldb-commits] [lldb] a68ffb1 - Change the default handling of SIGCONT to nosuppress/nostop/notify

Author: Jim Ingham Date: 2020-10-08T15:24:19-07:00 New Revision: a68ffb19d392c6d52f6e42925217a77b4cd71cee URL: https://github.com/llvm/llvm-project/commit/a68ffb19d392c6d52f6e42925217a77b4cd71cee DIFF: https://github.com/llvm/llvm-project/commit/a68ffb19d392c6d52f6e42925217a77b4cd71cee.diff

[Lldb-commits] [lldb] 81b11c9 - Fix a macOS build break caused by 3dfb94986170.

Author: Jim Ingham Date: 2020-10-07T15:01:27-07:00 New Revision: 81b11c91070f3a969b64b2c2e6011b02450fa75f URL: https://github.com/llvm/llvm-project/commit/81b11c91070f3a969b64b2c2e6011b02450fa75f DIFF: https://github.com/llvm/llvm-project/commit/81b11c91070f3a969b64b2c2e6011b02450fa75f.diff

Re: [Lldb-commits] [PATCH] D88840: [dotest] Simplify logic to find the Python path

> On Oct 6, 2020, at 8:40 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > In D88840#2314587 , @rupprecht wrote: > >> In D88840#2313331 , @kastiglione >> wrote: >>

[Lldb-commits] [lldb] be66987 - Fix raciness in the StopHook check for "has the target run".

Author: Jim Ingham Date: 2020-10-05T15:44:28-07:00 New Revision: be66987e2047636d9ed9d2a4d88b762d59ae88f2 URL: https://github.com/llvm/llvm-project/commit/be66987e2047636d9ed9d2a4d88b762d59ae88f2 DIFF: https://github.com/llvm/llvm-project/commit/be66987e2047636d9ed9d2a4d88b762d59ae88f2.diff

Re: [Lldb-commits] [PATCH] D88516: [lldb] Add a "design" section to the documentation.

Architecture is more specific to the structural aspect of a thing, whereas Design is more general. For instance, the rules for the SB API don’t really seem like a description of an Architecture, but more some general principles for doing the thing. Jim > On Oct 1, 2020, at 4:25 PM, Adrian

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

Thanks for the info… We’re running in sync mode, so for Continue to return before the process is all the way stopped, Process::ResumeSynchronous() must be bobbling the case where a stop event that resumes the process comes in. The only way I can see that happening is if Process::PrivateResume

[Lldb-commits] [lldb] afaeb6a - Fix crash in SBStructuredData::GetDescription() when there's no StructuredDataPlugin.

Author: Jim Ingham Date: 2020-09-30T11:48:54-07:00 New Revision: afaeb6af79a4278249ef9114755e5685d0b35984 URL: https://github.com/llvm/llvm-project/commit/afaeb6af79a4278249ef9114755e5685d0b35984 DIFF: https://github.com/llvm/llvm-project/commit/afaeb6af79a4278249ef9114755e5685d0b35984.diff

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

I also used to get e-mails when a test failed and I was on the changes list. But I haven’t gotten any failure e-mails. Does that only happen for some of the bots (or has that stopped working) or should I look to my filters? Jim > On Sep 30, 2020, at 10:40 AM, Jim Ingham via lldb-comm

Re: [Lldb-commits] [PATCH] D88266: Check that the "StructuredData Plugin weak pointer" is good before trying to turn it into a shared pointer

We should probably outlaw the shared pointer from weak pointer constructor in lldb. It looks like the only safe way to use it is in a try/catch block (or by preflighting the weak pointer with lock which renders it pretty much pointless.) Jim > On Sep 30, 2020, at 6:02 AM, Pavel Labath via

Re: [Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/9484/steps/test/logs/stdio > http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/9504/steps/test/logs/stdio > http://lab.llvm.org:8011/builders/lldb-aarch64-ubuntu/builds/9505/steps/test/logs/stdio > > On 29/09/2020 21:01,

[Lldb-commits] [lldb] 1b1d981 - Revert "Revert "Add the ability to write target stop-hooks using the ScriptInterpreter.""

Author: Jim Ingham Date: 2020-09-29T12:01:14-07:00 New Revision: 1b1d9815987a753f2f3524cfad050b85972dae5b URL: https://github.com/llvm/llvm-project/commit/1b1d9815987a753f2f3524cfad050b85972dae5b DIFF: https://github.com/llvm/llvm-project/commit/1b1d9815987a753f2f3524cfad050b85972dae5b.diff

[Lldb-commits] [lldb] b65966c - Add the ability to write target stop-hooks using the ScriptInterpreter.

Author: Jim Ingham Date: 2020-09-25T15:44:55-07:00 New Revision: b65966cff65bfb66de59621347ffd97238d3f645 URL: https://github.com/llvm/llvm-project/commit/b65966cff65bfb66de59621347ffd97238d3f645 DIFF: https://github.com/llvm/llvm-project/commit/b65966cff65bfb66de59621347ffd97238d3f645.diff

[Lldb-commits] [lldb] 3726ac4 - Add `breakpoint delete --disabled`: deletes all disabled breakpoints.

Author: Jim Ingham Date: 2020-09-23T11:35:11-07:00 New Revision: 3726ac41e9e00d2f6f87779b68f91ea264223c8a URL: https://github.com/llvm/llvm-project/commit/3726ac41e9e00d2f6f87779b68f91ea264223c8a DIFF: https://github.com/llvm/llvm-project/commit/3726ac41e9e00d2f6f87779b68f91ea264223c8a.diff

[Lldb-commits] [lldb] 94b0d83 - Fix reporting the lack of global variables in "target var".

Author: Jim Ingham Date: 2020-09-21T17:29:40-07:00 New Revision: 94b0d836a105116220052313df5a58473f706cdf URL: https://github.com/llvm/llvm-project/commit/94b0d836a105116220052313df5a58473f706cdf DIFF: https://github.com/llvm/llvm-project/commit/94b0d836a105116220052313df5a58473f706cdf.diff

[Lldb-commits] [lldb] f723d19 - Add '<' meta command to read in code from external file

Author: Patrick Beard Date: 2020-09-16T11:36:54-07:00 New Revision: f723d193e2c92ea6903e3debfee32b13354808bc URL: https://github.com/llvm/llvm-project/commit/f723d193e2c92ea6903e3debfee32b13354808bc DIFF: https://github.com/llvm/llvm-project/commit/f723d193e2c92ea6903e3debfee32b13354808bc.diff

[Lldb-commits] [lldb] b6db0a5 - Add python enumerators for SBTypeEnumMemberList, and some tests for this API.

Author: Jim Ingham Date: 2020-08-14T09:57:46-07:00 New Revision: b6db0a544df1f28e7fa53b74e19839e55e63c8c9 URL: https://github.com/llvm/llvm-project/commit/b6db0a544df1f28e7fa53b74e19839e55e63c8c9 DIFF: https://github.com/llvm/llvm-project/commit/b6db0a544df1f28e7fa53b74e19839e55e63c8c9.diff

[Lldb-commits] [lldb] d3dfd8c - Add a setting to force stepping to always run all threads.

Author: Jim Ingham Date: 2020-08-07T14:47:31-07:00 New Revision: d3dfd8cec44072302818c34193d898903dbaef8f URL: https://github.com/llvm/llvm-project/commit/d3dfd8cec44072302818c34193d898903dbaef8f DIFF: https://github.com/llvm/llvm-project/commit/d3dfd8cec44072302818c34193d898903dbaef8f.diff

[Lldb-commits] [lldb] 1c1ffa6 - GetPath() returns a std::string temporary. You can't reference just the c_str.

Author: Jim Ingham Date: 2020-08-05T19:12:15-07:00 New Revision: 1c1ffa6a300a60c81be41a3e08a4e9da7499adc1 URL: https://github.com/llvm/llvm-project/commit/1c1ffa6a300a60c81be41a3e08a4e9da7499adc1 DIFF: https://github.com/llvm/llvm-project/commit/1c1ffa6a300a60c81be41a3e08a4e9da7499adc1.diff

[Lldb-commits] [lldb] 08063f8 - "|" used when "||" was meant in SBTarget::FindFunctions

Author: Jim Ingham Date: 2020-08-05T19:02:00-07:00 New Revision: 08063f85a7eadb1e54d0a03e0307bf15319513e8 URL: https://github.com/llvm/llvm-project/commit/08063f85a7eadb1e54d0a03e0307bf15319513e8 DIFF: https://github.com/llvm/llvm-project/commit/08063f85a7eadb1e54d0a03e0307bf15319513e8.diff

[Lldb-commits] [lldb] 8d6aa68 - Remove the "bool" return from OptionValue::Clear and its subclasses.

Author: Jim Ingham Date: 2020-07-21T11:32:55-07:00 New Revision: 8d6aa688eeffea4b9151d1a208ed619ca50c823a URL: https://github.com/llvm/llvm-project/commit/8d6aa688eeffea4b9151d1a208ed619ca50c823a DIFF: https://github.com/llvm/llvm-project/commit/8d6aa688eeffea4b9151d1a208ed619ca50c823a.diff

[Lldb-commits] [lldb] bc0a9a1 - Add an option (-y) to "break set" and "source list" that uses the same

Author: Jim Ingham Date: 2020-07-20T17:40:36-07:00 New Revision: bc0a9a17a4a658153f4b524da3274d33a98d1c5b URL: https://github.com/llvm/llvm-project/commit/bc0a9a17a4a658153f4b524da3274d33a98d1c5b DIFF: https://github.com/llvm/llvm-project/commit/bc0a9a17a4a658153f4b524da3274d33a98d1c5b.diff

[Lldb-commits] [Differential] D83975: Add an option to "break set" and "source list" that takes a line spec in the form file:line:column

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jingham marked 2 inline comments as done. Closed by commit rGbc0a9a17a4a6: Add an

[Lldb-commits] [lldb] e337350 - This is a refinement on 96601ec28b7efe5abf3479a1aa91bcedb235bbbd. The intent of that change was to do the same work for the computation of the locations of the children

Author: Jim Ingham Date: 2020-07-10T11:11:59-07:00 New Revision: e337350be9d6efd72027c331f95ef33df61fdc43 URL: https://github.com/llvm/llvm-project/commit/e337350be9d6efd72027c331f95ef33df61fdc43 DIFF: https://github.com/llvm/llvm-project/commit/e337350be9d6efd72027c331f95ef33df61fdc43.diff

Re: [Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

I’m not sure > On Jun 25, 2020, at 5:08 AM, Pavel Labath wrote: > > On 24/06/2020 18:55, Jim Ingham wrote: >> >>> On Jun 22, 2020, at 5:52 AM, Pavel Labath via Phabricator via lldb-commits >>> wrote: >>> >>> labath added a comment. >>> >>> This seems like it could be useful in some

Re: [Lldb-commits] [PATCH] D82155: [WIP][lldb/interpreter] Add ability to save lldb session to a file

> On Jun 22, 2020, at 5:52 AM, Pavel Labath via Phabricator via lldb-commits > wrote: > > labath added a comment. > > This seems like it could be useful in some circumstances, though for the use > cases I am imagining (bug reporting) it would be easier to just copy-paste > the terminal

[Lldb-commits] [lldb] a976a7f - Disable this test for Windows.

Author: Jim Ingham Date: 2020-06-04T10:51:01-07:00 New Revision: a976a7fcae44ed5ca9e4f13735a4f91378169282 URL: https://github.com/llvm/llvm-project/commit/a976a7fcae44ed5ca9e4f13735a4f91378169282 DIFF: https://github.com/llvm/llvm-project/commit/a976a7fcae44ed5ca9e4f13735a4f91378169282.diff

[Lldb-commits] [lldb] f4d4273 - Add a test for preserving state on the non-expr thread across expression evaluation.

Author: Jim Ingham Date: 2020-06-03T14:30:35-07:00 New Revision: f4d427326539f007b05378eaf66018c10b651ad0 URL: https://github.com/llvm/llvm-project/commit/f4d427326539f007b05378eaf66018c10b651ad0 DIFF: https://github.com/llvm/llvm-project/commit/f4d427326539f007b05378eaf66018c10b651ad0.diff

[Lldb-commits] [lldb] 723a1ca - Fix the crashlog.py script's use of the load_address property.

Author: Jim Ingham Date: 2020-05-28T09:55:40-07:00 New Revision: 723a1caa377b898ff3dc0897156f544feab99ac8 URL: https://github.com/llvm/llvm-project/commit/723a1caa377b898ff3dc0897156f544feab99ac8 DIFF: https://github.com/llvm/llvm-project/commit/723a1caa377b898ff3dc0897156f544feab99ac8.diff

Re: [Lldb-commits] [lldb] 053b063 - [lldb] Increase timeout in TestExitDuringExpression

I set the timeouts low just to keep the test from taking too long. Beyond that there’s no harm in bumping them up till they pass consistently. I messed with the timeouts and reran the test a bunch of times till it was stable for me, but I have a pretty fast mac, so apparently that wasn’t a

Re: [Lldb-commits] [lldb] 8a6333e - [lldb/REPL] Fix unhandled switch case

Sorry I missed that. That seems fine. In the dedicated REPL, you’re probably dead at this point, but you can do “expr —repl --” in which case we’ll pick whatever thread on to run your expression, adding the results to the REPL context, so it could happen there and you might not be all the way

[Lldb-commits] [lldb] 54c2c2a - Maybe I need ENABLE_THREADS in the Makefile.

Author: Jim Ingham Date: 2020-05-21T18:38:49-07:00 New Revision: 54c2c2add7ad42ce1910a276cd1cd2912af4cddd URL: https://github.com/llvm/llvm-project/commit/54c2c2add7ad42ce1910a276cd1cd2912af4cddd DIFF: https://github.com/llvm/llvm-project/commit/54c2c2add7ad42ce1910a276cd1cd2912af4cddd.diff

[Lldb-commits] [lldb] 1583766 - This very simple .c file is failing on the Debian bot wit the error

Author: Jim Ingham Date: 2020-05-21T18:26:01-07:00 New Revision: 1583766ed23b707898e872728783f054ede47ca8 URL: https://github.com/llvm/llvm-project/commit/1583766ed23b707898e872728783f054ede47ca8 DIFF: https://github.com/llvm/llvm-project/commit/1583766ed23b707898e872728783f054ede47ca8.diff

[Lldb-commits] [lldb] dbbed97 - Handle the case where a thread exits while we are running a function on it.

Author: Jim Ingham Date: 2020-05-21T17:55:53-07:00 New Revision: dbbed971e3a282f44242297b75a527256eb862dc URL: https://github.com/llvm/llvm-project/commit/dbbed971e3a282f44242297b75a527256eb862dc DIFF: https://github.com/llvm/llvm-project/commit/dbbed971e3a282f44242297b75a527256eb862dc.diff

Re: [Lldb-commits] [lldb] 1cbd1b8 - Revert "[lldb] Don't dissasemble large functions by default"

I’m pretty sure all you need to do is add a —force to the disassemble command in TestFoundationDisassembly.py. Jim > On May 14, 2020, at 2:16 PM, via lldb-commits > wrote: > > > Author: shafik > Date: 2020-05-14T14:15:51-07:00 > New Revision: 1cbd1b8f692df7742efb9114510688045d901f96 > >

Re: [Lldb-commits] [PATCH] D78807: Fix gendered documentation

A lot of our comments and documentation was written a while ago when the “good” practice was to be careful to use “he” and “she” in equal measure when referring to our users. The consensus has shifted to using “they” instead, so there are probably a bunch of other places using he and she.

Re: [Lldb-commits] [PATCH] D78421: Fix out of sync source code/executable when debugging

Yes, to do it right you should do that. I think it would still be worthwhile to first check whether the current frame’s source file is the one being asked for, since that is a very common way to get to source files and that would make going from source file -> module very cheap. But

[Lldb-commits] [lldb] aa4b37b - Convert the ThreadPlanCommands test to use a scripted plan

Author: Jim Ingham Date: 2020-04-10T18:15:03-07:00 New Revision: aa4b37b2acda8f0879ed5507e1a732c37e6ec5aa URL: https://github.com/llvm/llvm-project/commit/aa4b37b2acda8f0879ed5507e1a732c37e6ec5aa DIFF: https://github.com/llvm/llvm-project/commit/aa4b37b2acda8f0879ed5507e1a732c37e6ec5aa.diff

[Lldb-commits] [lldb] f7de4b5 - Thread Plans pushed by a scripted plan should be private plans.

Author: Jim Ingham Date: 2020-04-10T18:15:03-07:00 New Revision: f7de4b5d6bce8c33ac3e18a41abcf5268a29f461 URL: https://github.com/llvm/llvm-project/commit/f7de4b5d6bce8c33ac3e18a41abcf5268a29f461 DIFF: https://github.com/llvm/llvm-project/commit/f7de4b5d6bce8c33ac3e18a41abcf5268a29f461.diff

Re: [Lldb-commits] [lldb] 3775be2 - Target: correct the return value for `GetImageAddrFromToken`

This should be easy to test. If you have a running process, and haven’t called “process load” then: (lldb) process unload 12345 Should return the error: failed to unload image: invalid image token But instead on x86_64 it returns the error: failed to unload image: expression failed:

Re: [Lldb-commits] [PATCH] D77444: [commands] Support autorepeat in SBCommands

Then only time that I can find where I customized the string based on the incoming full command was for “source list” because I needed to know whether the listing was going forward or backward, so I needed to write that into the “keep doing what you were doing” command. That could have also

Re: [Lldb-commits] [lldb] b6cd964 - Fix typo in xfail decorator for lldb thread plan list tests

Yes. Now that I think about it a little more, I’m a bit surprised that on most platforms we do have to step in & back out again to step over this function. That’s what we always used to do, but the work Greg & Co. did a little while back added the assumption that call’s return to the PC

[Lldb-commits] [lldb] 3270748 - The thread plan list test is failing at least on Ubuntu Linux.

Author: Jim Ingham Date: 2020-04-03T20:06:11-07:00 New Revision: 327074812707d41f492a0e23940430422a9cd237 URL: https://github.com/llvm/llvm-project/commit/327074812707d41f492a0e23940430422a9cd237 DIFF: https://github.com/llvm/llvm-project/commit/327074812707d41f492a0e23940430422a9cd237.diff

[Lldb-commits] [lldb] 48ba745 - This test is failing on the Ubuntu bot but the bot log doesn't

Author: Jim Ingham Date: 2020-04-03T18:04:02-07:00 New Revision: 48ba745eacf883080152fe16b5b1305657d001ca URL: https://github.com/llvm/llvm-project/commit/48ba745eacf883080152fe16b5b1305657d001ca DIFF: https://github.com/llvm/llvm-project/commit/48ba745eacf883080152fe16b5b1305657d001ca.diff

[Lldb-commits] [lldb] 2d658c5 - Disable two new tests on Windows. They are failing but the logs are not helpful.

Author: Jim Ingham Date: 2020-04-03T17:14:56-07:00 New Revision: 2d658c56d57c4b355635b2bab38ba97a598c7393 URL: https://github.com/llvm/llvm-project/commit/2d658c56d57c4b355635b2bab38ba97a598c7393 DIFF: https://github.com/llvm/llvm-project/commit/2d658c56d57c4b355635b2bab38ba97a598c7393.diff

[Lldb-commits] [lldb] e4598dc - Make ThreadPlans use TID and Process, rather than Thread *.

Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: e4598dc04a1f582e18b6721ae8ad15cad3ddd48b URL: https://github.com/llvm/llvm-project/commit/e4598dc04a1f582e18b6721ae8ad15cad3ddd48b DIFF: https://github.com/llvm/llvm-project/commit/e4598dc04a1f582e18b6721ae8ad15cad3ddd48b.diff

[Lldb-commits] [lldb] 1893065 - Allow the ThreadPlanStackMap to hold the thread plans for threads

Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: 1893065d7bf5c41fbd0dbbee0a39933d3a99806b URL: https://github.com/llvm/llvm-project/commit/1893065d7bf5c41fbd0dbbee0a39933d3a99806b DIFF: https://github.com/llvm/llvm-project/commit/1893065d7bf5c41fbd0dbbee0a39933d3a99806b.diff

[Lldb-commits] [lldb] 61e8e68 - Move thread plan stacks into the Process, indexed by TID.

Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: 61e8e6882de7c89933d3cc4c4d44719679e4b4f0 URL: https://github.com/llvm/llvm-project/commit/61e8e6882de7c89933d3cc4c4d44719679e4b4f0 DIFF: https://github.com/llvm/llvm-project/commit/61e8e6882de7c89933d3cc4c4d44719679e4b4f0.diff

[Lldb-commits] [lldb] 2c1c57a - Make ThreadPlanTracers use TID & Process rather than Thread *.

Author: Jim Ingham Date: 2020-04-03T14:56:28-07:00 New Revision: 2c1c57a1df8187870df114af666bacbd413699f7 URL: https://github.com/llvm/llvm-project/commit/2c1c57a1df8187870df114af666bacbd413699f7 DIFF: https://github.com/llvm/llvm-project/commit/2c1c57a1df8187870df114af666bacbd413699f7.diff

[Lldb-commits] [lldb] 67d67eb - Internal expressions shouldn't increment the result variable numbering.

Author: Jim Ingham Date: 2020-03-23T13:30:37-07:00 New Revision: 67d67ebe8f2535c5de75c62820f7713f87d07307 URL: https://github.com/llvm/llvm-project/commit/67d67ebe8f2535c5de75c62820f7713f87d07307 DIFF: https://github.com/llvm/llvm-project/commit/67d67ebe8f2535c5de75c62820f7713f87d07307.diff

Re: [Lldb-commits] [lldb] 6385c2a - [AppleObjCRuntimeV2] Force lazily allocated class names to be resolved.

Yes, I’m working on a fix. Can you use regular expressions or globs in FileCheck matching? It means if you ever add a test that makes an expression above this test in the file, you have to go renumber everything. That's kind of annoying even if the numbering was still working, and you

Re: [Lldb-commits] [lldb] e98ef0a - [lldb] Fix several LLDB_LOGs with wrong indices in ClangASTSource.cpp

We should really have a low-frequency bot that just runs the whole testsuite with all the logs turned on and make sure that doesn't crash... Jim > On Mar 4, 2020, at 10:56 AM, Raphael “Teemperor” Isemann via lldb-commits > wrote: > > Yeah this whole thing is a disaster and it’s puzzling

[Lldb-commits] [lldb] 3cd13c4 - Fix a race between lldb's packet timeout and the profile thread's usleep.

Author: Jim Ingham Date: 2020-02-25T11:17:08-08:00 New Revision: 3cd13c4624b5900c884b691b72d0ca053433f6fe URL: https://github.com/llvm/llvm-project/commit/3cd13c4624b5900c884b691b72d0ca053433f6fe DIFF: https://github.com/llvm/llvm-project/commit/3cd13c4624b5900c884b691b72d0ca053433f6fe.diff

Re: [Lldb-commits] [PATCH] D75004: Fix a race between lldb's packet timeout and killing the profile thread

I don’t understand your suggestion. The point of this change was to get the profile loop to exit without waiting the full sleep time. That time is generally pretty long (1 second or thereabouts) and so if you have the main debugserver thread wait on the profile thread’s timeout before

Re: [Lldb-commits] [PATCH] D74478: [lldb] Let TypeSystemClang::GetDisplayTypeName remove anonymous and inline namespaces.

Yes, I don't think you have to solve this problem to make the suggested change. I think a lot of folks would appreciate the effort it would take to make names in backtraces more readable. Sometimes, particularly when you use function objects and iterators in combination, the names are

[Lldb-commits] [lldb] 4570f2c - Add a test for debugserver handling threads suspended from within a program.

Author: Jim Ingham Date: 2020-02-13T15:48:38-08:00 New Revision: 4570f2c7cf35388d8b3ab9cc5cdcad4971e31cf2 URL: https://github.com/llvm/llvm-project/commit/4570f2c7cf35388d8b3ab9cc5cdcad4971e31cf2 DIFF: https://github.com/llvm/llvm-project/commit/4570f2c7cf35388d8b3ab9cc5cdcad4971e31cf2.diff

[Lldb-commits] [lldb] d62a343 - Add a test for adding and removing Listeners from a BroadcasterManager.

Author: Jim Ingham Date: 2020-02-07T17:54:25-08:00 New Revision: d62a343db23b7e8c3b5f2a0284bcacc10141a49e URL: https://github.com/llvm/llvm-project/commit/d62a343db23b7e8c3b5f2a0284bcacc10141a49e DIFF: https://github.com/llvm/llvm-project/commit/d62a343db23b7e8c3b5f2a0284bcacc10141a49e.diff

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

The question isn't so much whether it makes a difference to the user than whether when somebody reports getting this error in a project that we can't get our hands on so all we have is the screen output (a very not uncommon circumstance for debuggers) the different error messages would be

Re: [Lldb-commits] [lldb] c25938d - Refactor CommandObjectTargetSymbolsAdd::AddModuleSymbols

Seems like your change is more informative. Could we just fix the tests? Jim > On Feb 4, 2020, at 11:18 AM, Adrian McCarthy via lldb-commits > wrote: > > I see why the behavior is different, but I'm not sure whether the new > behavior is wrong. > > The old code nested a bunch of

Re: [Lldb-commits] [lldb] r355466 - Replace debug-only assert with a plain old assert.

That shouldn't be ASAN specific, that should happen on and LLDB_CONFIGURATION_DEBUG build. If it only happens on ASAN builds, something else must be going wrong. BTW, those asserts only make sense if you can't re-enter the command interpreter while a command is active. In the case of a

[Lldb-commits] [lldb] 29c7e6c - Clang added a new feature to the ObjC compiler that will translate method

Author: Jim Ingham Date: 2020-01-23T12:41:14-08:00 New Revision: 29c7e6c8c97f6b1186f012d614e9a1100e8c06cb URL: https://github.com/llvm/llvm-project/commit/29c7e6c8c97f6b1186f012d614e9a1100e8c06cb DIFF: https://github.com/llvm/llvm-project/commit/29c7e6c8c97f6b1186f012d614e9a1100e8c06cb.diff

[Lldb-commits] [lldb] 89c8866 - Convert AssertTrue( A == B) to AssertEqual(A, B) in TestObjCStepping.py.

Author: Jim Ingham Date: 2020-01-22T13:20:15-08:00 New Revision: 89c8866c0417a415ab546aa870569308f15b0ec8 URL: https://github.com/llvm/llvm-project/commit/89c8866c0417a415ab546aa870569308f15b0ec8 DIFF: https://github.com/llvm/llvm-project/commit/89c8866c0417a415ab546aa870569308f15b0ec8.diff

Re: [Lldb-commits] [PATCH] D72953: Fix the handling of unnamed bit-fields when parsing DWARF

> On Jan 17, 2020, at 2:24 PM, Raphael Isemann via Phabricator > wrote: > > teemperor added a comment. > > (Just some quick comments, will review this properly during normal working > hours) > > Without this fix debugging Clang with LLDB is essentially impossible, so I'm > in favour of

Re: [Lldb-commits] LLDB Intel hardware breakpoints patch

Somebody will have to champion this patch for it to get into lldb. It has no test case, so it’s not acceptable as is. It should also be cleaned up so that it shares more code with the watchpoint implementation in the same file (for instance duplicating all the comments and logic to set a

[Lldb-commits] [lldb] cd9e5c3 - Fix the macos build after D71575.

Author: Jim Ingham Date: 2020-01-15T18:13:44-08:00 New Revision: cd9e5c32302cd3b34b796683eedb072c6a1cfdc1 URL: https://github.com/llvm/llvm-project/commit/cd9e5c32302cd3b34b796683eedb072c6a1cfdc1 DIFF: https://github.com/llvm/llvm-project/commit/cd9e5c32302cd3b34b796683eedb072c6a1cfdc1.diff

Re: [Lldb-commits] [PATCH] D72391: [lldb] Add a display name to ClangASTContext instances

I think we should keep the pointer. You can easily cast the pointer & call functions on it in the expression parser. So if you have the log streaming as you are debugging and you see a log message that seems interesting, you can interrupt lldb and access the relevant context without having to

Re: [Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

Okay, I pushed a change to the test to only run on darwin. When you have a patch for the other systems, we can take that out again. Jim > On Dec 20, 2019, at 2:08 PM, Mark Mossberg via Phabricator > wrote: > > mossberg added a comment. > > Took a quick look, and I think the good news is

[Lldb-commits] [lldb] 05b2c6a - Temporarily restrict the test for D71372 to darwin till we fix it on other systems.

Author: Jim Ingham Date: 2019-12-20T14:31:41-08:00 New Revision: 05b2c6a52cc79916beb4cad820a4b5e0ddfd2c4e URL: https://github.com/llvm/llvm-project/commit/05b2c6a52cc79916beb4cad820a4b5e0ddfd2c4e DIFF: https://github.com/llvm/llvm-project/commit/05b2c6a52cc79916beb4cad820a4b5e0ddfd2c4e.diff

Re: [Lldb-commits] [PATCH] D71372: [lldb] Add additional validation on return address in 'thread step-out'

Yes, and Fedora Linux too. Jan added a partial fix but that doesn't get the test passing IIUC. I think Mark only had a Darwin machine to test this on. I'm going to limit the test to darwin for now to give Mark a chance to analyze the failures. Jim > On Dec 20, 2019, at 1:25 PM, Stella

<    1   2   3   4   5   6   7   8   9   10   >