[Lldb-commits] [lldb] r282043 - Adds tests for breakpoint names, and a FindBreakpointsByName.

Author: jingham Date: Tue Sep 20 20:21:19 2016 New Revision: 282043 URL: http://llvm.org/viewvc/llvm-project?rev=282043=rev Log: Adds tests for breakpoint names, and a FindBreakpointsByName. Also if you set a breakpoint with an invalid name, we'll refuse to set the breakpoint rather than

[Lldb-commits] [lldb] r282036 - Add some more tests for breakpoint serialization.

Author: jingham Date: Tue Sep 20 17:54:49 2016 New Revision: 282036 URL: http://llvm.org/viewvc/llvm-project?rev=282036=rev Log: Add some more tests for breakpoint serialization. Serialize breakpoint names & the hardware_requested attributes. Also added a few missing affordances to SBBreakpoint

[Lldb-commits] [lldb] r281690 - First tests for serializing breakpoints.

Author: jingham Date: Thu Sep 15 20:41:27 2016 New Revision: 281690 URL: http://llvm.org/viewvc/llvm-project?rev=281690=rev Log: First tests for serializing breakpoints. Plus a few bug fixes I found along the way. Added:

[Lldb-commits] [lldb] r281569 - Make the keys enumerations for options and resolvers enum classes.

Author: jingham Date: Wed Sep 14 20:47:22 2016 New Revision: 281569 URL: http://llvm.org/viewvc/llvm-project?rev=281569=rev Log: Make the keys enumerations for options and resolvers enum classes. This keeps them from conflicting with other symbols names, so it's worth their being less convenient

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

Also, w.r.t: > Aside from write imperative control flow constructs, which I see as a > positive rather than a negative. I wrote a bunch of tests to test that stepping behavior for swift and C was reasonable. When stepping through source code, there is not one correct way to write the line

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

> On Sep 14, 2016, at 3:56 PM, Chris Bieneman wrote: > > @jingham and @zturner, we can also take advantage of FileCheck's use of > regular expressions to write robust matchers. In general LLVM has managed to > change text output formats many times in radical ways, and LIT's

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

If the internal thing is three things in a list, you get back thing one, thing two and thing three in declarative ways rather than "I got three space separated things, maybe they had spaces in them, maybe there were quotes, etc, and don't ever change this now or you'll have to go fix all the

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

jingham added a comment. Writing tests this way means we're going back to testing the command line commands. That was what gdb did for the most part, and you ended up terrified of making changes that might effect command output, not because the change was hard but because knew you would have

[Lldb-commits] [lldb] r281520 - Add SB API's for writing breakpoints to & creating the from a file.

Author: jingham Date: Wed Sep 14 14:07:35 2016 New Revision: 281520 URL: http://llvm.org/viewvc/llvm-project?rev=281520=rev Log: Add SB API's for writing breakpoints to & creating the from a file. Moved the guts of the code from CommandObjectBreakpoint to Target (should have done it that way in

[Lldb-commits] [lldb] r281519 - Fix some const-ness issues with BreakpointID & BreakpointIDList.

Author: jingham Date: Wed Sep 14 14:05:27 2016 New Revision: 281519 URL: http://llvm.org/viewvc/llvm-project?rev=281519=rev Log: Fix some const-ness issues with BreakpointID & BreakpointIDList. Modified: lldb/trunk/include/lldb/Breakpoint/BreakpointID.h

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. See inlined comments. Otherwise this is great. Comment at: include/lldb/Core/SourceManager.h:34-35 @@ -33,3 +33,4 @@ public: -File(const FileSpec _spec,

Re: [Lldb-commits] [PATCH] D24495: A little bit more pointer safety in the Breakpoint code

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks fine. The only bad effect of making a CommandBaton, then going out of your way to put it in a plain old BatonSP before passing it to us rather than a CommandBatonSP is that the

[Lldb-commits] [lldb] r281288 - Add a few const's (thanks Zachary) and return shared or unique pointers

Author: jingham Date: Mon Sep 12 20:58:08 2016 New Revision: 281288 URL: http://llvm.org/viewvc/llvm-project?rev=281288=rev Log: Add a few const's (thanks Zachary) and return shared or unique pointers in places where they help prevent leaks. Modified:

Re: [Lldb-commits] [lldb] r281273 - This is the main part of a change to add breakpoint save and restore to lldb.

BTW, I was going over these, and this does not seem to me like a case where you want to do an early return. The logic is: Add some stuff to data See if I found the UserSource key, if so add some more stuff Then return data It would not be clearer to do: Add some stuff to data See if I found

Re: [Lldb-commits] [lldb] r281273 - This is the main part of a change to add breakpoint save and restore to lldb.

I see the whole content, but I'll reply to this one so the reply doesn't get truncated on your end... > On Sep 12, 2016, at 6:03 PM, Zachary Turner wrote: > > > Immediately, very little. A small amount of performance, since comparing > StringRefs is faster than comparing

Re: [Lldb-commits] [lldb] r281273 - This is the main part of a change to add breakpoint save and restore to lldb.

> On Sep 12, 2016, at 4:57 PM, Zachary Turner <ztur...@google.com> wrote: > > > > On Mon, Sep 12, 2016 at 4:19 PM Jim Ingham via lldb-commits > <lldb-commits@lists.llvm.org> wrote: > Author: jingham > Date: Mon Sep 12 18:10:56 2016 > New Revision: 28127

Re: [Lldb-commits] [PATCH] D23883: Remove MIUtilParse (no longer used)

> On Sep 10, 2016, at 11:26 PM, Zachary Turner via lldb-commits > wrote: > > I don't think requiring user install of six would work, lldb should just work > out of the box. Renaming it to lldb_six might work. > > Also yes using llvm regex everywhere would be

[Lldb-commits] [lldb] r280892 - Remove lldb coding conventions as they are no longer relevant.

Author: jingham Date: Wed Sep 7 19:42:02 2016 New Revision: 280892 URL: http://llvm.org/viewvc/llvm-project?rev=280892=rev Log: Remove lldb coding conventions as they are no longer relevant. Removed: lldb/trunk/www/lldb-coding-conventions.html Modified: lldb/trunk/www/sidebar.incl

Re: [Lldb-commits] [PATCH] D24025: Remove mention of autoconf from the build instructions

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks for cleaning this up! https://reviews.llvm.org/D24025 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D23952: Remove unused frame_zero_id local variable

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Thanks for finding that. https://reviews.llvm.org/D23952 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r279800 - Make all the Function implementations different so the compiler won't share them.

Author: jingham Date: Thu Aug 25 20:27:50 2016 New Revision: 279800 URL: http://llvm.org/viewvc/llvm-project?rev=279800=rev Log: Make all the Function implementations different so the compiler won't share them. Clang on ARM64 was making the three Function methods with identical bodies have one

[Lldb-commits] [lldb] r279540 - Implementation "step out" plans shouldn't gather the return value.

Author: jingham Date: Tue Aug 23 12:55:21 2016 New Revision: 279540 URL: http://llvm.org/viewvc/llvm-project?rev=279540=rev Log: Implementation "step out" plans shouldn't gather the return value. When, for instance, "step-in" steps into a function that it doesn't want to stop in (e.g. has no

[Lldb-commits] [lldb] r279533 - Change the PathMappingList::FindFile to use FileSpec API's

Author: jingham Date: Tue Aug 23 12:13:33 2016 New Revision: 279533 URL: http://llvm.org/viewvc/llvm-project?rev=279533=rev Log: Change the PathMappingList::FindFile to use FileSpec API's Also, when appending path components, collapse multiple "/" into one at the join. Modified:

[Lldb-commits] [lldb] r279345 - Remove a test that depends on knowing all compiler's register allocation schemes.

Author: jingham Date: Fri Aug 19 17:58:26 2016 New Revision: 279345 URL: http://llvm.org/viewvc/llvm-project?rev=279345=rev Log: Remove a test that depends on knowing all compiler's register allocation schemes. This test was using a condition that would compare a variable against the register

Re: [Lldb-commits] [PATCH] D23406: Fix a race in Broadcaster/Listener interaction

jingham accepted this revision. jingham added a comment. Yes, sorry. I seem to have trouble with remembering the Action dropdown... Thanks for figuring this out - and apologies for any hair loss we inadvertently caused you! I doubt it is important to use SmallVector rather than std::vector

Re: [Lldb-commits] [lldb] r278440 - Decoupled Options from CommandInterpreter.

I have no opposition to unit tests in general, but if somebody finds some free time on their hands, it would be really great to make the option definition & argument parsing available to the SB API's so that people could define real lldb Python commands that did completion, help etc as an equal

[Lldb-commits] [lldb] r278305 - dlopen & dlclose can't throw C++ or ObjC exceptions, so don't do the extra work of

Author: jingham Date: Wed Aug 10 19:15:28 2016 New Revision: 278305 URL: http://llvm.org/viewvc/llvm-project?rev=278305=rev Log: dlopen & dlclose can't throw C++ or ObjC exceptions, so don't do the extra work of setting & deleting the breakpoints to watch for this. Modified:

[Lldb-commits] [lldb] r278188 - Add a newline to the end of the file to remove the clang warnings.

Author: jingham Date: Tue Aug 9 19:45:58 2016 New Revision: 278188 URL: http://llvm.org/viewvc/llvm-project?rev=278188=rev Log: Add a newline to the end of the file to remove the clang warnings. Modified: lldb/trunk/include/lldb/Host/PosixApi.h Modified:

[Lldb-commits] [lldb] r277890 - Mention the scripted thread plans in the python reference.

Author: jingham Date: Fri Aug 5 18:35:26 2016 New Revision: 277890 URL: http://llvm.org/viewvc/llvm-project?rev=277890=rev Log: Mention the scripted thread plans in the python reference. Modified: lldb/trunk/www/python-reference.html Modified: lldb/trunk/www/python-reference.html URL:

[Lldb-commits] [lldb] r277884 - Mention is_stale in the scripted step doc.

Author: jingham Date: Fri Aug 5 17:47:43 2016 New Revision: 277884 URL: http://llvm.org/viewvc/llvm-project?rev=277884=rev Log: Mention is_stale in the scripted step doc. Modified: lldb/trunk/examples/python/scripted_step.py Modified: lldb/trunk/examples/python/scripted_step.py URL:

[Lldb-commits] [lldb] r277879 - Add a few more needed bits to the scripted thread plans.

Author: jingham Date: Fri Aug 5 17:06:12 2016 New Revision: 277879 URL: http://llvm.org/viewvc/llvm-project?rev=277879=rev Log: Add a few more needed bits to the scripted thread plans. Modified: lldb/trunk/include/lldb/API/SBThread.h lldb/trunk/include/lldb/API/SBThreadPlan.h

[Lldb-commits] [lldb] r277662 - Errors compiling breakpoint conditions will cause the breakpoint not to be hit

Author: jingham Date: Wed Aug 3 17:46:11 2016 New Revision: 277662 URL: http://llvm.org/viewvc/llvm-project?rev=277662=rev Log: Errors compiling breakpoint conditions will cause the breakpoint not to be hit This was a shadowed variable error from the big Expression Parser plugin-ification. I

Re: [Lldb-commits] [lldb] r277443 - Support for OCaml native debugging

r277660 should do it. Jim > On Aug 3, 2016, at 3:04 PM, Jim Ingham wrote: > > Just finishing off a test build. Give me a minute and I'll check it in. > > Jim > >> On Aug 3, 2016, at 2:22 PM, Tamas Berghammer via lldb-commits >> wrote: >> >>

[Lldb-commits] [lldb] r277660 - Add the new OCaml support files to the Xcode project file.

Author: jingham Date: Wed Aug 3 17:12:00 2016 New Revision: 277660 URL: http://llvm.org/viewvc/llvm-project?rev=277660=rev Log: Add the new OCaml support files to the Xcode project file. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

Re: [Lldb-commits] [lldb] r277443 - Support for OCaml native debugging

Just finishing off a test build. Give me a minute and I'll check it in. Jim > On Aug 3, 2016, at 2:22 PM, Tamas Berghammer via lldb-commits > wrote: > > It is failing because the new files have to be added to the xcode project. > Currently I don't have a Mac

Re: [Lldb-commits] [PATCH] D22950: Centralize all calls to select() into a single class so we always call select properly

jingham added a subscriber: jingham. jingham added a comment. In https://reviews.llvm.org/D22950#500582, @emaste wrote: > Testing now on FreeBSD. Do you have a sense of how many fds lldb might use in > practice? For FreeBSD we can increase it from the default if necessary via > > NOTES >

[Lldb-commits] [lldb] r277185 - Some code that is sanity checking stepping out back out from one inlined

Author: jingham Date: Fri Jul 29 13:09:12 2016 New Revision: 277185 URL: http://llvm.org/viewvc/llvm-project?rev=277185=rev Log: Some code that is sanity checking stepping out back out from one inlined frame to another was triggering an early stop when stepping back out to a real frame. Check

Re: [Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

> On Jul 27, 2016, at 10:08 AM, Pavel Labath wrote: > > On 27 July 2016 at 17:41, Jim Ingham wrote: >> If you go to halt a thread whose private state is running, and by the time >> you get to halting it the private state has gone from running to stopped

Re: [Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

> the case, we should check whether RunThreadPlan is active instead of > relying on the private state. > > pl > > On 26 July 2016 at 20:47, Jim Ingham via lldb-commits > <lldb-commits@lists.llvm.org> wrote: >> Author: jingham >> Date: Tue Jul 26 14:47:45 2016 >>

[Lldb-commits] [lldb] r276796 - The ARM single-step handling needs to look for breakpoint on the next instruction.

Author: jingham Date: Tue Jul 26 14:50:25 2016 New Revision: 276796 URL: http://llvm.org/viewvc/llvm-project?rev=276796=rev Log: The ARM single-step handling needs to look for breakpoint on the next instruction. Modified: lldb/trunk/source/Plugins/Process/Utility/StopInfoMachException.cpp

[Lldb-commits] [lldb] r276795 - Check both private & public states to decide if you need to halt before killing.

Author: jingham Date: Tue Jul 26 14:47:45 2016 New Revision: 276795 URL: http://llvm.org/viewvc/llvm-project?rev=276795=rev Log: Check both private & public states to decide if you need to halt before killing. We were just checking the public state, but that meant if you were hung in a long

[Lldb-commits] [lldb] r276132 - If x/i is followed by x/g, the format should be reset to 'x'.

Author: jingham Date: Wed Jul 20 10:41:12 2016 New Revision: 276132 URL: http://llvm.org/viewvc/llvm-project?rev=276132=rev Log: If x/i is followed by x/g, the format should be reset to 'x'. Otherwise, you have to say "x/gx" to what you obviously intended to happen to happen. Modified:

[Lldb-commits] [lldb] r275519 - Remember to add the testcase I wrote for r274822.

Author: jingham Date: Thu Jul 14 20:41:54 2016 New Revision: 275519 URL: http://llvm.org/viewvc/llvm-project?rev=275519=rev Log: Remember to add the testcase I wrote for r274822. Added: lldb/trunk/packages/Python/lldbsuite/test/expression_command/unwind_expression/

Re: [Lldb-commits] [PATCH] D22294: Add functionality for rewriting symbols

jingham added a comment. We always resolve duplicate symbols to the "closest" one to the current frame. So if there are two versions of putchar and one is in the library containing the current frame, we should find that one. If we aren't getting that right, that's a bug. So the correct

Re: [Lldb-commits] [PATCH] D22294: Add functionality for rewriting symbols

We always resolve duplicate symbols to the "closest" one to the current frame. So if there are two versions of putchar and one is in the library containing the current frame, we should find that one. If we aren't getting that right, that's a bug. So the correct symbol should get called in

Re: [Lldb-commits] [PATCH] D22294: Add functionality for rewriting symbols

jingham added a subscriber: jingham. jingham added a comment. This approach seems fragile to me. I'm supposed to remember that some build system set some rewriter file that I then have to supply manually to get the view of symbols to match reality? We really try to avoid having to write notes

Re: [Lldb-commits] [PATCH] D22230: Make ThreadPlanStepInstruction's constructor public.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Sure, yes. http://reviews.llvm.org/D22230 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

jingham added a comment. Yes, that's sad. It needs to be done that way because the plan that organizes stepping "through" and provides a safety backstop if the step through runs away needs to push the sub-plans after it has been pushed. We could move all the stuff in the

Re: [Lldb-commits] [PATCH] D22231: Implement trampoline step-through for Windows-x86.

jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. jingham added a comment. This revision now requires changes to proceed. Can't you just call "thread->QueueThreadPlanForStepSingleInstruction"? For the most part, it doesn't make

[Lldb-commits] [lldb] r274822 - Add an API to unwind from a hand-called expression.

Author: jingham Date: Thu Jul 7 21:12:05 2016 New Revision: 274822 URL: http://llvm.org/viewvc/llvm-project?rev=274822=rev Log: Add an API to unwind from a hand-called expression. This is just an SB API way of doing "thread return -x". Modified: lldb/trunk/include/lldb/API/SBThread.h

[Lldb-commits] [lldb] r274787 - Check whether Sema::CreateBuiltinUnaryOp returns an empty result.

Author: jingham Date: Thu Jul 7 14:06:37 2016 New Revision: 274787 URL: http://llvm.org/viewvc/llvm-project?rev=274787=rev Log: Check whether Sema::CreateBuiltinUnaryOp returns an empty result. If it does, calling AddInitializerToDecl will crash, so we should abort the result synthesis in this

[Lldb-commits] [lldb] r274783 - Add an "experimental" setting to disable injecting local variables into expressions.

Author: jingham Date: Thu Jul 7 13:25:48 2016 New Revision: 274783 URL: http://llvm.org/viewvc/llvm-project?rev=274783=rev Log: Add an "experimental" setting to disable injecting local variables into expressions. This feature was added to solve a lookup problem in expressions when local

Re: [Lldb-commits] [PATCH] D22060: [expression evaluation] Prevent invalid function declarations ending up in clang AST

jingham added a comment. Shouldn't it be the job of the subsequent filtering loop to sort this out? The debugger should be able to call functions from a given frame, even if that function is not actually visible from the current frame. So I don't think you want to reject such functions from

[Lldb-commits] [lldb] r274593 - Allows "experimental" settings that will either route to their containing

Author: jingham Date: Tue Jul 5 20:27:33 2016 New Revision: 274593 URL: http://llvm.org/viewvc/llvm-project?rev=274593=rev Log: Allows "experimental" settings that will either route to their containing settings or raise no error if not found. From time to time it is useful to add some setting

[Lldb-commits] [lldb] r274032 - Process::StopForDetachOrDestroy should actually return an error if it can't stop the

Author: jingham Date: Tue Jun 28 11:35:58 2016 New Revision: 274032 URL: http://llvm.org/viewvc/llvm-project?rev=274032=rev Log: Process::StopForDetachOrDestroy should actually return an error if it can't stop the process. Modified: lldb/trunk/source/Target/Process.cpp Modified:

[Lldb-commits] [lldb] r273979 - fixits are apparently called fix-its.

Author: jingham Date: Mon Jun 27 20:33:03 2016 New Revision: 273979 URL: http://llvm.org/viewvc/llvm-project?rev=273979=rev Log: fixits are apparently called fix-its. Modified: lldb/trunk/include/lldb/Expression/UserExpression.h lldb/trunk/scripts/interface/SBExpressionOptions.i

Re: [Lldb-commits] [PATCH] D21296: [lldb] Fixed race condition on private state thread exit, take 2

jingham accepted this revision. jingham added a comment. This looks okay to me. http://reviews.llvm.org/D21296 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D21221: Fix for PrintStackTraces

jingham added a subscriber: jingham. jingham added a comment. I agree with Pavel. Remember that most stops in the course of stepping will require an unwind (to tell step-in vrs. lateral step vrs. step out). This can happen many times in the course of a "user level" step. So for stepping,

[Lldb-commits] [lldb] r272407 - SBThread also had some places where it got the ExecutionContext w/o

Author: jingham Date: Fri Jun 10 12:22:26 2016 New Revision: 272407 URL: http://llvm.org/viewvc/llvm-project?rev=272407=rev Log: SBThread also had some places where it got the ExecutionContext w/o taking the API lock. Modified: lldb/trunk/source/API/SBThread.cpp Modified:

[Lldb-commits] [lldb] r272354 - Make all the SBFrame API's take the target lock.

Author: jingham Date: Thu Jun 9 19:37:44 2016 New Revision: 272354 URL: http://llvm.org/viewvc/llvm-project?rev=272354=rev Log: Make all the SBFrame API's take the target lock. For some reason, the conversion to taking the target lock when acquiring the ExecutionContext was only done for some

[Lldb-commits] [lldb] r272189 - Add a test for the failure described by pr28055. Mark it as xfail.

Author: jingham Date: Wed Jun 8 14:06:00 2016 New Revision: 272189 URL: http://llvm.org/viewvc/llvm-project?rev=272189=rev Log: Add a test for the failure described by pr28055. Mark it as xfail. Added:

[Lldb-commits] [lldb] r272087 - Revive the error message from "process load" and SBProcess::LoadImage.

Author: jingham Date: Tue Jun 7 20:29:21 2016 New Revision: 272087 URL: http://llvm.org/viewvc/llvm-project?rev=272087=rev Log: Revive the error message from "process load" and SBProcess::LoadImage. IsPointedCString has problems with ValueObjects of type eTypeHostAddress. We should figure out

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks fine to me. http://reviews.llvm.org/D20835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

jingham added a subscriber: jingham. jingham added a comment. All the other controls for printing the stop info have "stop-*". It would be clearer to keep doing this, I think. Jim http://reviews.llvm.org/D20835 ___ lldb-commits mailing list

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. I wouldn't call the setting "use-column-info". It would be better to call it "stop-print-column-info" or something that makes it clear this is just for printing. If we get

Re: [Lldb-commits] [PATCH] D20835: Mark the current column when displaying the context of the current breakpoint on the terminal.

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. This looks fine. Can you add a setting in the "stop-line" vein that will turn on and off the column listing. Seems odd to control all the other stuff, but not this.

[Lldb-commits] [lldb] r270593 - Lock out Process::RunThreadPlan so only one can be in flight at a time.

Author: jingham Date: Tue May 24 13:29:36 2016 New Revision: 270593 URL: http://llvm.org/viewvc/llvm-project?rev=270593=rev Log: Lock out Process::RunThreadPlan so only one can be in flight at a time. What with all sorts of folks (TSAN, ASAN, queue detection, etc...) trying to gather info by

[Lldb-commits] [lldb] r270148 - Remove a should have been deleted extra assignment to a variable.

Author: jingham Date: Thu May 19 17:22:57 2016 New Revision: 270148 URL: http://llvm.org/viewvc/llvm-project?rev=270148=rev Log: Remove a should have been deleted extra assignment to a variable. Also fix up the formatting a bit, it looks like something was inserting actual tabs. Replace with 4

[Lldb-commits] [lldb] r270014 - Fix error propagation from the Z0 packet in gdb-remote breakpoint setting.

Author: jingham Date: Wed May 18 21:13:44 2016 New Revision: 270014 URL: http://llvm.org/viewvc/llvm-project?rev=270014=rev Log: Fix error propagation from the Z0 packet in gdb-remote breakpoint setting. The error was not getting propagated to the caller, so the higher layers thought the

Re: [Lldb-commits] [PATCH] D19124: [LLDB] Added support for PHI nodes to IR interpreter

Note that while adding a "expr --allow-jit" flag to control this was great, there already was an SBExpressionOptions option and the appropriate flags available for this, so it was testable. I was just checking because there really shouldn't be anything we can do from a command that we can't do

Re: [Lldb-commits] [PATCH] D20135: Keep original source path and mapped path in LineEntry

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Looks good to me. http://reviews.llvm.org/D20135 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] r268827 - Remove some lldbassert's from the packet checking code.

Author: jingham Date: Fri May 6 19:52:18 2016 New Revision: 268827 URL: http://llvm.org/viewvc/llvm-project?rev=268827=rev Log: Remove some lldbassert's from the packet checking code. Greg says he doesn't need these asserts anymore and since they cause occasional test suite crashes, out they

[Lldb-commits] [lldb] r268823 - Fix the way the ShouldStopHere checker handles the general case of "stepping through line 0 code".

Author: jingham Date: Fri May 6 18:44:10 2016 New Revision: 268823 URL: http://llvm.org/viewvc/llvm-project?rev=268823=rev Log: Fix the way the ShouldStopHere checker handles the general case of "stepping through line 0 code". That's good 'cause it means all the different kinds of source line

Re: [Lldb-commits] [PATCH] D19983: Fix TestEvents.py on OS X

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. I agree, doing something to get the test working is primary. Then we can go back and figure out why the less ordered shutdown doesn't work. http://reviews.llvm.org/D19983

[Lldb-commits] [lldb] r268467 - You have to call setHasLoadedFieldsFromExternalStorage AFTER calling

Author: jingham Date: Tue May 3 19:06:23 2016 New Revision: 268467 URL: http://llvm.org/viewvc/llvm-project?rev=268467=rev Log: You have to call setHasLoadedFieldsFromExternalStorage AFTER calling the field_begin that starts the copy or it won't do anything. This causes failures, but only in

[Lldb-commits] [lldb] r268338 - Another little example use of scripted thread plans.

Author: jingham Date: Mon May 2 19:14:52 2016 New Revision: 268338 URL: http://llvm.org/viewvc/llvm-project?rev=268338=rev Log: Another little example use of scripted thread plans. Modified: lldb/trunk/examples/python/scripted_step.py Modified: lldb/trunk/examples/python/scripted_step.py

Re: [Lldb-commits] [lldb] r268110 - Watch out for compilers that generate bad bitfield info. If the bit size of a bitfield member doesn't lie within the bit bounds of the type itself, just leave it ou

Of course we filed a bug about this, and I'm pretty sure Adrian is done or close to done with the fix. Searching for a useful interpretation to your question all I can come up with is: "Why are you bothering to work around this rather than fixing clang." That is actually worth answering,

[Lldb-commits] [lldb] r267842 - Fix an inefficiency in the handling of $__lldb_local_vars in expressions.

Author: jingham Date: Wed Apr 27 21:17:02 2016 New Revision: 267842 URL: http://llvm.org/viewvc/llvm-project?rev=267842=rev Log: Fix an inefficiency in the handling of $__lldb_local_vars in expressions. The code in ClangExpressionDeclMap::FindExternalVisibleDecls figures out what the token

[Lldb-commits] [lldb] r267834 - Add the ability to limit "source regexp" breakpoints to a particular function

Author: jingham Date: Wed Apr 27 20:40:57 2016 New Revision: 267834 URL: http://llvm.org/viewvc/llvm-project?rev=267834=rev Log: Add the ability to limit "source regexp" breakpoints to a particular function within a source file. This isn't done, I need to make the name match smarter (right now

[Lldb-commits] [lldb] r267594 - UtilityFunction::MakeFunctionCaller uses the Error to report failure,

Author: jingham Date: Tue Apr 26 14:46:39 2016 New Revision: 267594 URL: http://llvm.org/viewvc/llvm-project?rev=267594=rev Log: UtilityFunction::MakeFunctionCaller uses the Error to report failure, but when there's was no process it was just returning an null pointer and not setting the error.

Re: [Lldb-commits] [lldb] r267478 - Fix StackFrame::GetVariables(...) function that was broken by 261858 when lambda functions were added to Block::AppendBlockVariables(). The Stackframe::GetVariables

Debug mode doesn't mean no optimization, but -O0 SHOULD... OTOH, long experience has shown that it is very hard to convince compilers to be as dumb at -O0 as you would like them to be. That's why in all our test cases, we initialize variables, and generally do something dumb like printf the

[Lldb-commits] [lldb] r267500 - When building the list of variables we're going to write "using $_lldb_local_vars"

Author: jingham Date: Mon Apr 25 19:29:59 2016 New Revision: 267500 URL: http://llvm.org/viewvc/llvm-project?rev=267500=rev Log: When building the list of variables we're going to write "using $_lldb_local_vars" statements for, be sure not to include variables that have no locations. We

[Lldb-commits] [lldb] r266944 - Expressions can run without a process.

Author: jingham Date: Wed Apr 20 20:46:11 2016 New Revision: 266944 URL: http://llvm.org/viewvc/llvm-project?rev=266944=rev Log: Expressions can run without a process. Code was added in ClangExpressionParser::ClangExpressionParser that was calling through the process w/o checking that it was

Re: [Lldb-commits] [PATCH] D19215: normalize test file extension for test filenames

That I don't know. But we really shouldn't be generating the .pyc files, they just litter the test directories and I don't think they are much help. Jim > On Apr 18, 2016, at 11:29 AM, Zachary Turner wrote: > > That's normal, but why would that cause an issue for the test

Re: [Lldb-commits] [PATCH] D19215: normalize test file extension for test filenames

IIRC, python will generate byte-compiled ".pyc" versions of the ".py" files automatically (and helpfully leave them in the CWD...) We turned that off for the testsuite through some Python magic I don't think I ever knew, but if I did I've certainly forgotten it... Anyway, sounds like that got

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

jingham added a subscriber: jingham. jingham added a comment. Done in r266407. It built for me after this. Jim http://reviews.llvm.org/D18848 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D18848: Add PDBASTParser and parse type information from PDB

Done in r266407. It built for me after this. Jim > On Apr 14, 2016, at 6:34 PM, Zachary Turner via lldb-commits > wrote: > > zturner added a comment. > > A new file was added, Greg or someone else at Apple may need to add it to > the Xcode workspace > > >

[Lldb-commits] [lldb] r266407 - Add the PDBParser.{cpp, h} files to the Xcode project.

Author: jingham Date: Thu Apr 14 20:42:30 2016 New Revision: 266407 URL: http://llvm.org/viewvc/llvm-project?rev=266407=rev Log: Add the PDBParser.{cpp,h} files to the Xcode project. Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

jingham added a subscriber: jingham. jingham added a comment. At the Command & SB API level, we restrict access to the process from multiple threads with the run lock. But internally it is currently more of a gentleman's agreement not to do this. I don't think it would ever be useful to try

Re: [Lldb-commits] [PATCH] D19122: LLDB: Fixed race condition on timeout when stopping private state thread

At the Command & SB API level, we restrict access to the process from multiple threads with the run lock. But internally it is currently more of a gentleman's agreement not to do this. I don't think it would ever be useful to try to make calling functions in the target (which is the job of

Re: [Lldb-commits] [PATCH] D19092: Fix Android build after r266267

jingham added a subscriber: jingham. jingham added a comment. Why is this necessary? stdout is a local variable defined in this scope. Why would the android g++ have problems with this? Anyway, if you have to avoid using stdout as a name, maybe name it std_out as that better reflects its

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

jingham added a subscriber: jingham. jingham requested changes to this revision. jingham added a reviewer: jingham. This revision now requires changes to proceed. Comment at: source/API/SBThread.cpp:926 @@ -925,3 +925,3 @@ Thread *thread = exe_ctx.GetThreadPtr(); -

[Lldb-commits] [lldb] r266093 - Breakpoint conditions were making result variables, which they should not do.

Author: jingham Date: Tue Apr 12 12:17:35 2016 New Revision: 266093 URL: http://llvm.org/viewvc/llvm-project?rev=266093=rev Log: Breakpoint conditions were making result variables, which they should not do. The result variables aren't useful, and if you have a breakpoint on a common function

[Lldb-commits] [lldb] r266092 - 'int' is reported as an exception on OS X not as a signal. I don't think

Author: jingham Date: Tue Apr 12 12:04:12 2016 New Revision: 266092 URL: http://llvm.org/viewvc/llvm-project?rev=266092=rev Log: 'int' is reported as an exception on OS X not as a signal. I don't think this test ever succeeded on OS X. Modified:

Re: [Lldb-commits] [lldb] r265461 - XFail TestImport.py on Windows because Python 3 import rules don't work that way.

Will this be necessary for everybody who uses "command script import" with Python 3? If so, it would be really nice to do this work in "command script import" if possible. Otherwise everybody will have to put this goo at the top of every .py file they write for formatters & breakpoint

[Lldb-commits] [lldb] r265495 - If the fixed expression doesn't parse, don't tell the user about it.

Author: jingham Date: Tue Apr 5 19:25:04 2016 New Revision: 265495 URL: http://llvm.org/viewvc/llvm-project?rev=265495=rev Log: If the fixed expression doesn't parse, don't tell the user about it. Modified: lldb/trunk/source/Expression/UserExpression.cpp Modified:

[Lldb-commits] [lldb] r265496 - The FixItList typedef should have been inside "class ClangDiagnostic".

Author: jingham Date: Tue Apr 5 19:25:44 2016 New Revision: 265496 URL: http://llvm.org/viewvc/llvm-project?rev=265496=rev Log: The FixItList typedef should have been inside "class ClangDiagnostic". Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangDiagnostic.h Modified:

[Lldb-commits] [lldb] r265494 - Don't write "using $_lldb_local_vars" statements for variables with

Author: jingham Date: Tue Apr 5 19:24:17 2016 New Revision: 265494 URL: http://llvm.org/viewvc/llvm-project?rev=265494=rev Log: Don't write "using $_lldb_local_vars" statements for variables with no name. These were showing up with a recent clang, I haven't tracked down why yet, but adding them

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

jingham accepted this revision. jingham added a reviewer: jingham. jingham added a comment. Yes, that sounds right. http://reviews.llvm.org/D18692 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

Re: [Lldb-commits] [PATCH] D18692: Fix a cornercase in breakpoint reporting

jingham added a subscriber: jingham. jingham added a comment. The only worry I have about this is - thread A is stopped at a breakpoint, and then we stop on thread B instead, then we report a breakpoint, great! - The user steps thread B, which we do by suspending thread B and stepping A. - Then

<    4   5   6   7   8   9   10   11   12   >