Author: jdevlieghere
Date: Wed Aug 14 20:59:30 2019
New Revision: 368954
URL: http://llvm.org/viewvc/llvm-project?rev=368954&view=rev
Log:
[NFC] Update doc comment to fix warning.
This fixes the warning: parameter 'EnableNullFPSuppression' not found in
the function declaration [-Wdocumentation]
Author: jdevlieghere
Date: Thu Jul 18 08:17:42 2019
New Revision: 366447
URL: http://llvm.org/viewvc/llvm-project?rev=366447&view=rev
Log:
[CMake] Don't set Python_ADDITIONAL_VERSIONS
Until recently, Python_ADDITIONAL_VERSIONS was used to limit LLVM's
Python support to 2.7. Now that both LLVM and
Author: Philippe Blain
Date: 2020-06-30T09:33:20-07:00
New Revision: a1f4e48c4aca8c7339be2018926baf860a562f13
URL:
https://github.com/llvm/llvm-project/commit/a1f4e48c4aca8c7339be2018926baf860a562f13
DIFF:
https://github.com/llvm/llvm-project/commit/a1f4e48c4aca8c7339be2018926baf860a562f13.diff
Author: Jonas Devlieghere
Date: 2020-05-26T11:32:02-07:00
New Revision: a94e08d2e840a0e7ce032f59e9344bc49b5a54a1
URL:
https://github.com/llvm/llvm-project/commit/a94e08d2e840a0e7ce032f59e9344bc49b5a54a1
DIFF:
https://github.com/llvm/llvm-project/commit/a94e08d2e840a0e7ce032f59e9344bc49b5a54a1.d
Author: Jonas Devlieghere
Date: 2020-06-04T23:45:36-07:00
New Revision: 70ad03d93818532ef19f149f8ff89bcd8af80163
URL:
https://github.com/llvm/llvm-project/commit/70ad03d93818532ef19f149f8ff89bcd8af80163
DIFF:
https://github.com/llvm/llvm-project/commit/70ad03d93818532ef19f149f8ff89bcd8af80163.d
Hey Richard,
It appears this broke the lldb bots:
http://lab.llvm.org:8011/builders/lldb-x86_64-debian
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/20549/
It's hitting an assertion in
llvm-project/clang/include/clang/AST/DeclCXX.h:887:
Assertion `(data().DefaultedCopyAssignmentIsDel
Author: Jonas Devlieghere
Date: 2020-06-04T23:45:36-07:00
New Revision: df53f09056b0f6a91029cae5f1cdc941c21b
URL:
https://github.com/llvm/llvm-project/commit/df53f09056b0f6a91029cae5f1cdc941c21b
DIFF:
https://github.com/llvm/llvm-project/commit/df53f09056b0f6a91029cae5f1cdc941c21b.d
Author: Jonas Devlieghere
Date: 2020-03-05T21:45:20-08:00
New Revision: 45e2c6d956141618683d31a683d762aaf0e7168d
URL:
https://github.com/llvm/llvm-project/commit/45e2c6d956141618683d31a683d762aaf0e7168d
DIFF:
https://github.com/llvm/llvm-project/commit/45e2c6d956141618683d31a683d762aaf0e7168d.d
Author: Jonas Devlieghere
Date: 2020-03-23T12:09:24-07:00
New Revision: 56abcfad70ee679ad95ab41d934491ebcaebdf7d
URL:
https://github.com/llvm/llvm-project/commit/56abcfad70ee679ad95ab41d934491ebcaebdf7d
DIFF:
https://github.com/llvm/llvm-project/commit/56abcfad70ee679ad95ab41d934491ebcaebdf7d.d
Author: Jonas Devlieghere
Date: 2020-01-28T15:19:27-08:00
New Revision: 00d834e08719c994f12b216c7eb17bbc0c976714
URL:
https://github.com/llvm/llvm-project/commit/00d834e08719c994f12b216c7eb17bbc0c976714
DIFF:
https://github.com/llvm/llvm-project/commit/00d834e08719c994f12b216c7eb17bbc0c976714.d
Author: Jonas Devlieghere
Date: 2020-01-28T15:28:22-08:00
New Revision: 43a1c80508d17fa42c78b690d426105eaa84c539
URL:
https://github.com/llvm/llvm-project/commit/43a1c80508d17fa42c78b690d426105eaa84c539
DIFF:
https://github.com/llvm/llvm-project/commit/43a1c80508d17fa42c78b690d426105eaa84c539.d
Author: Jonas Devlieghere
Date: 2020-01-29T21:27:46-08:00
New Revision: 509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e
URL:
https://github.com/llvm/llvm-project/commit/509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e
DIFF:
https://github.com/llvm/llvm-project/commit/509e21a1b9debc7fcbfb3eaf56a5dcf57de55e0e.d
Author: jdevlieghere
Date: Sun Mar 18 04:38:41 2018
New Revision: 327790
URL: http://llvm.org/viewvc/llvm-project?rev=327790&view=rev
Log:
[dsymutil] Rename llvm-dsymutil -> dsymutil
Now that almost all functionality of Apple's dsymutil has been
upstreamed, the open source variant can be used as
Author: jdevlieghere
Date: Thu Mar 22 06:53:30 2018
New Revision: 328196
URL: http://llvm.org/viewvc/llvm-project?rev=328196&view=rev
Log:
[CodeGen] Emit DWARF "constructor" calling convention
Now that LLVM has support for emitting calling conventions in DWARF (see
r328191) have clang emit them.
Author: jdevlieghere
Date: Tue Dec 19 09:16:45 2017
New Revision: 321090
URL: http://llvm.org/viewvc/llvm-project?rev=321090&view=rev
Log:
[clang] -foptimization-record-file= should imply -fsave-optimization-record
The Clang option -foptimization-record-file= controls which file an
optimization r
Author: jdevlieghere
Date: Wed May 16 03:23:25 2018
New Revision: 332448
URL: http://llvm.org/viewvc/llvm-project?rev=332448&view=rev
Log:
[diagtool] Add diagtool to install target.
Although not very well known, diagtool is an incredibly convenient
utility for dealing with diagnostics.
Particular
Author: jdevlieghere
Date: Thu May 31 10:36:31 2018
New Revision: 333673
URL: http://llvm.org/viewvc/llvm-project?rev=333673&view=rev
Log:
PrintEscapedString -> printEscapedString
Update PrintEscapedString after renaming it in ADT.
Modified:
clang-tools-extra/trunk/clangd/Protocol.cpp
Modif
Author: jdevlieghere
Date: Mon Feb 26 03:30:13 2018
New Revision: 326081
URL: http://llvm.org/viewvc/llvm-project?rev=326081&view=rev
Log:
[Support] Replace HashString with djbHash.
This removes the HashString function from StringExtraces and replaces
its uses with calls to djbHash from DJB.h
Th
Author: jdevlieghere
Date: Mon Feb 26 04:05:18 2018
New Revision: 326082
URL: http://llvm.org/viewvc/llvm-project?rev=326082&view=rev
Log:
Revert "[Support] Replace HashString with djbHash."
It looks like some of our tests depend on the ordering of hashed values.
I'm reverting my changes while I
Author: jdevlieghere
Date: Mon Feb 26 07:16:42 2018
New Revision: 326091
URL: http://llvm.org/viewvc/llvm-project?rev=326091&view=rev
Log:
Re-land: "[Support] Replace HashString with djbHash."
This patch removes the HashString function from StringExtraces and
replaces its uses with calls to djbHa
Author: jdevlieghere
Date: Mon Jul 23 10:50:15 2018
New Revision: 337717
URL: http://llvm.org/viewvc/llvm-project?rev=337717&view=rev
Log:
[DebugInfo] Error out when enabling -fdebug-types-section on non-ELF target.
Currently, support for debug_types is only present for ELF and trying to
pass -fd
Author: jdevlieghere
Date: Wed Jun 27 10:31:59 2018
New Revision: 335757
URL: http://llvm.org/viewvc/llvm-project?rev=335757&view=rev
Log:
[DebugInfo] Emit ObjC methods as part of interface
As brought up during the discussion of the DWARF5 accelerator tables,
there is currently no way to associat
Author: jdevlieghere
Date: Thu Jun 28 03:56:40 2018
New Revision: 335834
URL: http://llvm.org/viewvc/llvm-project?rev=335834&view=rev
Log:
[DebugInfo] Follow-up commit to improve consistency. NFC
Follow-up commit for r335757 to address some inconsistencies.
Modified:
cfe/trunk/lib/CodeGen/CG
Author: jdevlieghere
Date: Mon Mar 13 13:08:11 2017
New Revision: 297649
URL: http://llvm.org/viewvc/llvm-project?rev=297649&view=rev
Log:
[Linker] Provide callback for internalization
Differential Revision: https://reviews.llvm.org/D30738
Modified:
cfe/trunk/include/clang/CodeGen/CodeGenAct
Author: jdevlieghere
Date: Mon Jul 29 16:02:11 2019
New Revision: 367271
URL: http://llvm.org/viewvc/llvm-project?rev=367271&view=rev
Log:
[DependencyCollector] Make maybeAddDependency virtual (NFC)
Make DependencyCollector::maybeAddDependency, just like its other
methods, which I made virtual a
I think this is causing a stage2 failure:
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/124/consoleFull#-95886206949ba4694-19c4-4d7e-bec5-911270d8a58c
On Fri, Aug 9, 2019 at 10:41 AM Gabor Horvath via cfe-commits
wrote:
>
> Author: xazax
> Date: Fri Aug 9 10:42:41 2019
> New Revision:
The bot is a little special in that it has modules enabled. Maybe that
explains it? Let me know if that doesn't work and I can try
reproducing locally.
On Fri, Aug 9, 2019 at 12:02 PM Gábor Horváth wrote:
>
> I reverted but I cannot reproduce this locally on a linux box. Is there any
> way to ge
Hi Leonard,
It appears that your patch is still triggering an assertion on GreenDragon:
http://green.lab.llvm.org/green/job/clang-stage1-configure-RA/56255/consoleFull#312501878d489585b-5106-414a-ac11-3ff90657619c
Can you please have a look?
Thanks,
Jonas
On Mon, May 6, 2019 at 8:17 PM Leonard
Hi Leonard,
The test that is asserting is part of the debuginfo test. (
https://github.com/llvm-project/debuginfo-tests)
The reason that it's only failing on the non-incremental bot is because the
incremental one isn't running those, I believe.
RA stands for Release/Asserts.
Hope that helps!
Ch
Author: jdevlieghere
Date: Tue May 7 14:08:15 2019
New Revision: 360192
URL: http://llvm.org/viewvc/llvm-project?rev=360192&view=rev
Log:
Revert "[OpenMP][Clang] Support for target math functions"
This commit appears to be breaking stage-2 builds on GreenDragon. The
OpenMP wrappers for cmath and
Hi Leonard,
My personal rule of thumb is that if I can fix it in something like 30
minutes or less, I'll leave the bot red and commit a fix. Otherwise I'll
revert my change. The problem with leaving the bot red is that if something
else breaks, that person doesn't get a signal, and issue start to
Author: jdevlieghere
Date: Thu Sep 12 22:16:59 2019
New Revision: 371813
URL: http://llvm.org/viewvc/llvm-project?rev=371813&view=rev
Log:
Revert "For PR17164: split -fno-lax-vector-conversion into three different"
This breaks the LLDB build. I tried reaching out to Richard, but haven't
gotten a
Author: jdevlieghere
Date: Mon Sep 23 16:49:36 2019
New Revision: 372672
URL: http://llvm.org/viewvc/llvm-project?rev=372672&view=rev
Log:
Revert "Support for DWARF-5 C++ language tags."
This reverts commit bf9c8ffb54943c6d77398adbedddf05ef9724007.
Modified:
cfe/trunk/include/clang/AST/DeclC
Author: jdevlieghere
Date: Wed Feb 15 11:06:06 2017
New Revision: 295199
URL: http://llvm.org/viewvc/llvm-project?rev=295199&view=rev
Log:
[clang-tidy] Add check 'modernize-return-braced-init-list'
Summary:
Replaces explicit calls to the constructor in a return with a braced
initializer list. Thi
Author: jdevlieghere
Date: Wed Feb 15 11:19:44 2017
New Revision: 295205
URL: http://llvm.org/viewvc/llvm-project?rev=295205&view=rev
Log:
Fixed indentation issue in release notes
Modified:
clang-tools-extra/trunk/docs/ReleaseNotes.rst
Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst
Author: jdevlieghere
Date: Wed Feb 15 11:37:58 2017
New Revision: 295207
URL: http://llvm.org/viewvc/llvm-project?rev=295207&view=rev
Log:
[clang-tidy] Fix test modernize-return-braced-init-list
Modified:
clang-tools-extra/trunk/test/clang-tidy/modernize-return-braced-init-list.cpp
Modified
Author: jdevlieghere
Date: Mon Jul 3 09:46:46 2017
New Revision: 307040
URL: http://llvm.org/viewvc/llvm-project?rev=307040&view=rev
Log:
[clang-tidy] Resolve cppcoreguidelines-pro-type-member-init false positive
Summary: https://bugs.llvm.org/show_bug.cgi?id=33557
Reviewers: Eugene.Zelenko, al
Author: jdevlieghere
Date: Tue Sep 5 11:04:34 2017
New Revision: 312545
URL: http://llvm.org/viewvc/llvm-project?rev=312545&view=rev
Log:
[NFC] Loop modernization in diagtool
Precommit for https://reviews.llvm.org/D37390
Modified:
cfe/trunk/tools/diagtool/DiagnosticNames.cpp
cfe/trunk/t
Author: jdevlieghere
Date: Tue Sep 5 11:04:40 2017
New Revision: 312546
URL: http://llvm.org/viewvc/llvm-project?rev=312546&view=rev
Log:
[diagtool] Change default tree behavior to print only flags
This patch changes the default behavior of `diagtool tree` to only
display warning flags and not t
Author: jdevlieghere
Date: Tue Apr 4 14:42:29 2017
New Revision: 299461
URL: http://llvm.org/viewvc/llvm-project?rev=299461&view=rev
Log:
[clangd] Link against clangSema
Fixes linking issue introduced by rL299421 when building LLVM with
shared libraries.
Modified:
clang-tools-extra/trunk/cl
JDevlieghere updated this revision to Diff 67390.
JDevlieghere marked 5 inline comments as done.
JDevlieghere added a comment.
Fixes issues raised by Alexander and Aaron
Repository:
rL LLVM
https://reviews.llvm.org/D22725
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/Mo
JDevlieghere updated this revision to Diff 67391.
JDevlieghere added a comment.
Removed anonymous namespaces in test file. I was playing around with it but
forgot to remove it before making my last diff.
Repository:
rL LLVM
https://reviews.llvm.org/D22725
Files:
clang-tidy/modernize/CMake
JDevlieghere abandoned this revision.
JDevlieghere added a comment.
I'm abandoning this revision because I think this check is getting overly
complex. There's still the problem of supporting arguments that can have side
effects, and then there's also the unaddressed issue of code possibly using
Author: jdevlieghere
Date: Wed Nov 30 12:06:42 2016
New Revision: 288258
URL: http://llvm.org/viewvc/llvm-project?rev=288258&view=rev
Log:
[clang-tidy] Make format style customizable
Summary: I came across an outstanding FIXME to make the format style
customizable. Inspired by the include fixer,
JDevlieghere updated this revision to Diff 71835.
JDevlieghere added a comment.
Herald added subscribers: mgorny, beanz.
Still working on comment #2 from Alex but wanted to update my diff since it's
been a while and I haven't gotten around to looking into it further. So no need
to review yet.
Author: Jonas Devlieghere
Date: 2020-08-19T09:35:08-07:00
New Revision: fc53bd610ff95d2824617095bcf4976035b4cb9a
URL:
https://github.com/llvm/llvm-project/commit/fc53bd610ff95d2824617095bcf4976035b4cb9a
DIFF:
https://github.com/llvm/llvm-project/commit/fc53bd610ff95d2824617095bcf4976035b4cb9a.d
Author: Jonas Devlieghere
Date: 2020-08-19T09:40:46-07:00
New Revision: 6b742cc48d91f35bfa98844d5add3655f33f8326
URL:
https://github.com/llvm/llvm-project/commit/6b742cc48d91f35bfa98844d5add3655f33f8326
DIFF:
https://github.com/llvm/llvm-project/commit/6b742cc48d91f35bfa98844d5add3655f33f8326.d
Author: Jonas Devlieghere
Date: 2020-10-11T20:16:46-07:00
New Revision: ba2dff0159fcd1d2349bc610331914618ca9bc30
URL:
https://github.com/llvm/llvm-project/commit/ba2dff0159fcd1d2349bc610331914618ca9bc30
DIFF:
https://github.com/llvm/llvm-project/commit/ba2dff0159fcd1d2349bc610331914618ca9bc30.d
I've reverted this in ba2dff0159fcd1d2349bc610331914618ca9bc30 because it
also caused a build failure when building a stage 2 clang:
http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/24177/console
FAILED: tools/clang/lib/AST/CMakeFiles/obj.clangAST.dir/ASTContext.cpp.o
/Users/buildslave/je
Author: Jonas Devlieghere
Date: 2020-10-20T13:46:44-07:00
New Revision: 27a909a24f99d4de40c4ce6553b9cd420b11c056
URL:
https://github.com/llvm/llvm-project/commit/27a909a24f99d4de40c4ce6553b9cd420b11c056
DIFF:
https://github.com/llvm/llvm-project/commit/27a909a24f99d4de40c4ce6553b9cd420b11c056.d
Author: Jonas Devlieghere
Date: 2021-04-20T20:42:50-07:00
New Revision: 05eeed9691aeb3e0316712195b998e9078cdceb0
URL:
https://github.com/llvm/llvm-project/commit/05eeed9691aeb3e0316712195b998e9078cdceb0
DIFF:
https://github.com/llvm/llvm-project/commit/05eeed9691aeb3e0316712195b998e9078cdceb0.d
Author: Jonas Devlieghere
Date: 2021-04-21T14:22:13-07:00
New Revision: 6331680ad2ad000fdaf7e72f3c1880c7908ffa25
URL:
https://github.com/llvm/llvm-project/commit/6331680ad2ad000fdaf7e72f3c1880c7908ffa25
DIFF:
https://github.com/llvm/llvm-project/commit/6331680ad2ad000fdaf7e72f3c1880c7908ffa25.d
Author: Jonas Devlieghere
Date: 2022-03-14T09:24:17-07:00
New Revision: f51d7e4bae9e861e711ad9711599456fc2f1bbca
URL:
https://github.com/llvm/llvm-project/commit/f51d7e4bae9e861e711ad9711599456fc2f1bbca
DIFF:
https://github.com/llvm/llvm-project/commit/f51d7e4bae9e861e711ad9711599456fc2f1bbca.d
Author: Jonas Devlieghere
Date: 2022-03-14T09:43:13-07:00
New Revision: df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9
URL:
https://github.com/llvm/llvm-project/commit/df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9
DIFF:
https://github.com/llvm/llvm-project/commit/df6fcef2b8330afd08a3c76e6a01cb5ada6b1aa9.d
Author: Jonas Devlieghere
Date: 2022-07-11T13:59:41-07:00
New Revision: c7fd7512a5c5b133665bfecbe2e9748c0607286e
URL:
https://github.com/llvm/llvm-project/commit/c7fd7512a5c5b133665bfecbe2e9748c0607286e
DIFF:
https://github.com/llvm/llvm-project/commit/c7fd7512a5c5b133665bfecbe2e9748c0607286e.d
Author: Jonas Devlieghere
Date: 2022-07-12T15:22:29-07:00
New Revision: a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437
URL:
https://github.com/llvm/llvm-project/commit/a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437
DIFF:
https://github.com/llvm/llvm-project/commit/a262f4dbd78fc68609d230f3e9c5ca2b1d1d9437.d
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/70512
>From 1c6a604df93b833c3bb9c7d34f4f27415592dbe5 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Thu, 5 Oct 2023 12:39:02 -0700
Subject: [PATCH] [LLVM][DWARF] Add support for monolithic types in
.d
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/77216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,13 +108,9 @@ else()
linux/HostInfoLinux.cpp
linux/LibcGlue.cpp
linux/Support.cpp
+ android/HostInfoAndroid.cpp
+ android/LibcGlue.cpp
)
-if (CMAKE_SYSTEM_NAME MATCHES "Android")
JDevlieghere wrote:
While Android m
https://github.com/JDevlieghere requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/77216
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/73067
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere approved this pull request.
I like how this centralizes everything in a single place and the def file
format seems like a natural fit for the platforms.
https://github.com/llvm/llvm-project/pull/69262
___
cfe-commits m
Author: jdevlieghere
Date: Tue Jan 29 22:26:26 2019
New Revision: 352605
URL: http://llvm.org/viewvc/llvm-project?rev=352605&view=rev
Log:
[ModuleDependencyCollector] Use llvm::sys::fs::real_path (NFC)
Use the real_path implementation from llvm::sys::fs::real_path instead
of having a custom imple
Author: jdevlieghere
Date: Sat Nov 10 16:56:15 2018
New Revision: 346601
URL: http://llvm.org/viewvc/llvm-project?rev=346601&view=rev
Log:
Pass the function type instead of the return type to FunctionDecl::Create
Fix places where the return type of a FunctionDecl was being used in
place of the fu
Author: jdevlieghere
Date: Mon Nov 12 08:59:50 2018
New Revision: 346675
URL: http://llvm.org/viewvc/llvm-project?rev=346675&view=rev
Log:
Revert "Make clang-based tools find libc++ on MacOS"
This breaks the LLDB bots.
Removed:
cfe/trunk/test/Tooling/Inputs/mock-libcxx/include/c++/v1/mock_ve
JDevlieghere created this revision.
JDevlieghere added a reviewer: alexfh.
JDevlieghere added a subscriber: cfe-commits.
JDevlieghere added a project: clang-tools-extra.
This check emits a warning when memcpy is used and suggest replacing it with a
call to std::copy.
Using std::copy opens up th
JDevlieghere added a comment.
In https://reviews.llvm.org/D22725#493940, @aaron.ballman wrote:
> > Using std::copy opens up the possibility of type-aware optimizations which
> > are not possible with memcpy.
>
>
> To my knowledge, those type-aware optimizations are for transforming copies
> inv
JDevlieghere updated this revision to Diff 65246.
JDevlieghere added a comment.
- Added new check to release notes
- Renamed to modernize-use-copy
- Addressed comments from Prazek
Repository:
rL LLVM
https://reviews.llvm.org/D22725
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/mo
JDevlieghere added a comment.
In https://reviews.llvm.org/D22725#493947, @Prazek wrote:
> Thanks for the contribution. Is it your first check?
Yes, it is! :-)
> Some main issues:
>
> 1. I think it would be much better to move this check to modernize module. I
> think the name 'modernize-us
JDevlieghere removed rL LLVM as the repository for this revision.
JDevlieghere updated this revision to Diff 65273.
JDevlieghere added a comment.
- Extended check to replace memmove with std::move and memset with std::fill
- Renamed check to modernize-use-algorithm (I'd be equally fine with moving
JDevlieghere added a comment.
In https://reviews.llvm.org/D22725#494074, @Prazek wrote:
> Maybe the right way would be to have check called
> 'modernize-use-sequence-algorithm' or just 'modernize-use-algorithm' that
> would basically do all those stuff. It would be good to not introduce 5 new
JDevlieghere added a comment.
In https://reviews.llvm.org/D22725#494167, @Prazek wrote:
> hmm It seems that I mislead you, I suck at C api - memmove source and
> destination can overlap, but std::move can't. So I guess you have to remove
> the memmove support. Sorry.
No problem, I wasn't awar
Hi,
I hope I'm not breaking any mailing list etiquette by replying to this
mail, but if I am then please accept my apologies.
On Fri, Jun 3, 2016 at 8:36 PM, Steven Wu via llvm-dev
wrote:
> Hi everyone
>
> I am still in the process of upstreaming some improvements to the embed
> bitcode option.
JDevlieghere added a comment.
Thanks for the reviews everyone!
I'm currently still stuck on an issue I discovered when processing LLVM. I
asked for help on the mailing list [0] but maybe someone here can help.
Basically the issue is that sometimes pointers are passed to memcpy for which
the ty
JDevlieghere retitled this revision from "[clang-tidy] Add check
'misc-replace-memcpy'" to "[clang-tidy] Add check 'modernize-use-algorithm'".
JDevlieghere updated the summary for this revision.
JDevlieghere set the repository for this revision to rL LLVM.
JDevlieghere updated this revision to Dif
JDevlieghere updated this revision to Diff 66350.
JDevlieghere added a comment.
Addressed comments from Piotr Padlewski
Repository:
rL LLVM
https://reviews.llvm.org/D22725
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseAl
JDevlieghere updated this revision to Diff 66688.
JDevlieghere marked 21 inline comments as done.
JDevlieghere added a comment.
Addresses comments from Aaron Ballman
@aaron.ballman Thanks for the thorough review! Can you check whether the tests
I added address your concerns? Could you also elabo
JDevlieghere updated this revision to Diff 66835.
JDevlieghere marked 9 inline comments as done.
JDevlieghere added a comment.
- Added function pointer test case
- Used placeholders for diagnostics
I extended the matchers to include `::memcpy` and `::memset` as well because
the check otherwise d
Author: jdevlieghere
Date: Tue Feb 12 13:45:14 2019
New Revision: 353882
URL: http://llvm.org/viewvc/llvm-project?rev=353882&view=rev
Log:
Make ModuleDependencyCollector's method virtual (NFC)
For reproducers in LLDB we want to hook up into the existing clang
infrastructure. To make that happen w
Author: jdevlieghere
Date: Wed Oct 10 06:27:25 2018
New Revision: 344140
URL: http://llvm.org/viewvc/llvm-project?rev=344140&view=rev
Log:
Lift VFS from clang to llvm (NFC)
This patch moves the virtual file system form clang to llvm so it can be
used by more projects.
Concretely the patch:
- Mo
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
JDevlieghere wrote:
"tools" has a pretty specific meaning for LL
https://github.com/JDevlieghere approved this pull request.
Thanks, this LGTM!
https://github.com/llvm/llvm-project/pull/87585
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -673,6 +673,9 @@ option(LLVM_USE_OPROFILE
option(LLVM_EXTERNALIZE_DEBUGINFO
"Generate dSYM files and strip executables and libraries (Darwin Only)" OFF)
+option(LLVM_ENABLE_EXPORTED_SYMBOLS
JDevlieghere wrote:
@delcypher I was referring to the tools in `
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/84279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,65 @@
+# Tests for basic Debuginfod functionality
+
+Because the Debuginfod protocol is a simple HTTP path-based system, one can
+mimic a Debuginfod server by setting up a directory structure to reflect the
+protocol properly. That's how all these tests operate. We over
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/79181
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere commented:
I'm wondering if shell test are really the best way to test this. For more
complex scenarios like are being tested here, we generally prefer [1] API tests
because they're more expressive and allow you to build more complicated test
binaries with our M
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/78392
Upstream XROS support in the clang frontend and driver.
>From 1e65420f87eed1f7f4380496f96eef2560a15cb0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 16 Jan 2024 20:36:47 -0800
Subject: [PATCH]
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/78392
>From 6f6d93b6cc413d54dbdec05f30ede00ffdb4 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 10 Jan 2024 17:35:47 -0800
Subject: [PATCH 1/2] [lldb] Upstream xros support in lldb
Upstream suppo
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/78392
>From d7c431e0fbc0ad006b9d37a4e3a43c61ce1f50b7 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 16 Jan 2024 20:36:47 -0800
Subject: [PATCH] [clang] Upstream XROS support in Clang
Upstream XROS su
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/78392
>From 52ff81ffbce596fd89b296e7f4199be13f9402ff Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 16 Jan 2024 20:36:47 -0800
Subject: [PATCH 1/2] [clang] Upstream XROS support in Clang
Upstream XRO
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/77932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere approved this pull request.
Before this patch, the DWARFLinker was the one responsible for creating the
streamer, which meant that both the classic and parallel implementation needed
to conform to the same interface. After this patch, the concrete
implementation
@@ -30,6 +30,20 @@ using namespace llvm;
using namespace dwarf_linker;
using namespace dwarf_linker::classic;
+Expected> DwarfStreamer::createStreamer(
+const Triple &TheTriple, DWARFLinkerBase::OutputFileType FileType,
+raw_pwrite_stream &OutFile, DWARFLinkerBase::Tra
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/78392
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere requested changes to this pull request.
We should be using `-platform-version` for newer versions of the linker. How
are we ending up in this code path?
https://github.com/llvm/llvm-project/pull/88810
___
cfe-commits m
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/88810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JDevlieghere wrote:
Right, my point is that (I think) that doesn't make sense. AFAIK
`addMinVersionArgs` is called exclusively from the code snippet I pasted, which
should check the linker version. The version of `ld` in which this changed is
much newer than the 520 referenced there.
I'd sta
https://github.com/JDevlieghere approved this pull request.
🥳
https://github.com/llvm/llvm-project/pull/95164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/95164
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 136 matches
Mail list logo
