@@ -804,23 +751,21 @@ class NoOwnershipChangeVisitor final : public
NoStateChangeFuncVisitor {
return false;
}
+ bool hasResourceStateChanged(ProgramStateRef CallEnterState,
+ ProgramStateRef CallExitEndState) final {
+return
https://github.com/Szelethus created
https://github.com/llvm/llvm-project/pull/100719
Response to the catch in this comment:
https://github.com/llvm/llvm-project/pull/94357/files/07f6daf2cf0f5d5bd4fc9950f2585a3f52b4ad2f#r1692084074
From d176b03b211144dadaa1efb4b7da959110d7725c Mon Sep 17
Szelethus wrote:
> If these changes are unrelated to each other, wouldn't it be better to
> separate them into 2 commits?
I see the principle, but I think its reasonable to push this one go,
considering that these changes are really minor and inconsquential, especially
since they affect the
https://github.com/Szelethus approved this pull request.
https://github.com/llvm/llvm-project/pull/100570
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus wrote:
I decided to merge this. We are still miles ahead with these docs, and I don't
wanna accidentally forget the PR.
https://github.com/llvm/llvm-project/pull/97407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Szelethus closed
https://github.com/llvm/llvm-project/pull/97407
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,182 @@
+//===--- TaggedUnionMemberCountCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
@@ -0,0 +1,125 @@
+//===--- TaggedUnionMemberCountCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/97407
From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Tue, 2 Jul 2024 12:58:19 +0200
Subject: [PATCH 1/6] [analyzer][NFC] Add some docs for
@@ -363,6 +397,18 @@ class LazyCompoundVal : public NonLoc {
/// It might return null.
const void *getStore() const;
+ /// This function itself is immaterial. It is only an implementation detail.
+ /// LazyCompoundVal represents only the rvalue, the data (known or
Szelethus wrote:
I'd also love to see some docs for `Loc` and `NonLoc`, because I recall some
angry looks from years ago when I touched those on their own, but I can barely
recall them :( As well as some docs for the various `ProgramState::getSVal`
methods...
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/97407
From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Tue, 2 Jul 2024 12:58:19 +0200
Subject: [PATCH 1/5] [analyzer][NFC] Add some docs for
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/97407
From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Tue, 2 Jul 2024 12:58:19 +0200
Subject: [PATCH 1/4] [analyzer][NFC] Add some docs for
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/97407
From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Tue, 2 Jul 2024 12:58:19 +0200
Subject: [PATCH 1/3] [analyzer][NFC] Add some docs for
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/97407
From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Tue, 2 Jul 2024 12:58:19 +0200
Subject: [PATCH 1/2] [analyzer][NFC] Add some docs for
Szelethus wrote:
I merget the PR as is, but I'll keep the warning message in mind, I'm open to
changing it as we are getting closer to moving out-of-alpha.
https://github.com/llvm/llvm-project/pull/95408
___
cfe-commits mailing list
https://github.com/Szelethus closed
https://github.com/llvm/llvm-project/pull/95408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Szelethus created
https://github.com/llvm/llvm-project/pull/97407
Yes, I basically copy-pasted some posts from discord and Artem's book, but
these make for a rather decent docs.
From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001
From:
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/95408
From 90cedd519da8b76c686db9c3f824b6d044e16eb6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Thu, 25 Apr 2024 17:31:24 +0200
Subject: [PATCH 1/7] [analyzer] Check the correct first and
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/95408
From 90cedd519da8b76c686db9c3f824b6d044e16eb6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Thu, 25 Apr 2024 17:31:24 +0200
Subject: [PATCH 1/6] [analyzer] Check the correct first and
https://github.com/Szelethus closed
https://github.com/llvm/llvm-project/pull/94957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/95408
From d717b412749f10b45a9387044e97da6981f3cad4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Thu, 25 Apr 2024 17:31:24 +0200
Subject: [PATCH 1/5] [analyzer] Check the correct first and
@@ -393,6 +401,162 @@ ProgramStateRef
CStringChecker::checkNonNull(CheckerContext ,
return stateNonNull;
}
+static std::optional getIndex(ProgramStateRef State,
+ const ElementRegion *ER, CharKind CK) {
+ SValBuilder =
Szelethus wrote:
> > > I did not find a similar test for `MallocChecker` but there could be one
> > > with similar test functions.
> >
> >
> > I'm not sure what tests you are referring to. I did fix your other
> > observations.
>
> I meant another test file where the
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/95408
From d717b412749f10b45a9387044e97da6981f3cad4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Thu, 25 Apr 2024 17:31:24 +0200
Subject: [PATCH 1/4] [analyzer] Check the correct first and
Szelethus wrote:
> The intention of the patch makes sense to me. However, I believe that the bug
> is inside the Store. It should not say it's `Undefined` if actually an
> existing binding overlaps (actually completely covers) the requested region.
> So, that said, the checker does the right
@@ -393,6 +401,173 @@ ProgramStateRef
CStringChecker::checkNonNull(CheckerContext ,
return stateNonNull;
}
+static std::optional getIndex(ProgramStateRef State,
+ const ElementRegion *ER, CharKind CK) {
+ SValBuilder =
@@ -393,6 +401,173 @@ ProgramStateRef
CStringChecker::checkNonNull(CheckerContext ,
return stateNonNull;
}
+static std::optional getIndex(ProgramStateRef State,
+ const ElementRegion *ER, CharKind CK) {
+ SValBuilder =
@@ -393,6 +401,173 @@ ProgramStateRef
CStringChecker::checkNonNull(CheckerContext ,
return stateNonNull;
}
+static std::optional getIndex(ProgramStateRef State,
+ const ElementRegion *ER, CharKind CK) {
+ SValBuilder =
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/95408
From d717b412749f10b45a9387044e97da6981f3cad4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Thu, 25 Apr 2024 17:31:24 +0200
Subject: [PATCH 1/3] [analyzer] Check the correct first and
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/95408
From d717b412749f10b45a9387044e97da6981f3cad4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Thu, 25 Apr 2024 17:31:24 +0200
Subject: [PATCH 1/2] [analyzer] Check the correct first and
@@ -26,16 +50,12 @@ void top(char *dst) {
void *mempcpy(void *restrict s1, const void *restrict s2, size_t n);
-void mempcpy14() {
+void mempcpy13() {
Szelethus wrote:
I gave sensible names to all of these test functions.
@@ -393,6 +401,173 @@ ProgramStateRef
CStringChecker::checkNonNull(CheckerContext ,
return stateNonNull;
}
+static std::optional getIndex(ProgramStateRef State,
+ const ElementRegion *ER, CharKind CK) {
+ SValBuilder =
@@ -696,6 +730,69 @@ struct StreamOperationEvaluator {
} // end anonymous namespace
+//===--===//
+// Definition of NoStreamStateChangeVisitor.
Szelethus wrote:
> I did not find a similar test for `MallocChecker` but there could be one with
> similar test functions.
I'm not sure what tests you are referring to. I did fix your other observations.
https://github.com/llvm/llvm-project/pull/94957
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/94957
From faf00d0e1286e053ba9fb457513bd8309eb541ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Fri, 7 Jun 2024 12:07:35 +0200
Subject: [PATCH 1/5] [analyzer] Add an ownership change
@@ -696,6 +730,69 @@ struct StreamOperationEvaluator {
} // end anonymous namespace
+//===--===//
+// Definition of NoStreamStateChangeVisitor.
@@ -696,6 +730,69 @@ struct StreamOperationEvaluator {
} // end anonymous namespace
+//===--===//
+// Definition of NoStreamStateChangeVisitor.
https://github.com/Szelethus edited
https://github.com/llvm/llvm-project/pull/94957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Szelethus created
https://github.com/llvm/llvm-project/pull/95408
I intend to fix this checker up so that we can move it out of alpha. I made a
bunch of analyses, and found many similar false positives:
```c++
int t[] = {1,2,3};
memcpy(dst, t, sizeof(t) / sizeof(t[0])); //
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/94957
From faf00d0e1286e053ba9fb457513bd8309eb541ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Fri, 7 Jun 2024 12:07:35 +0200
Subject: [PATCH 1/4] [analyzer] Add an ownership change
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/94957
From faf00d0e1286e053ba9fb457513bd8309eb541ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Fri, 7 Jun 2024 12:07:35 +0200
Subject: [PATCH 1/3] [analyzer] Add an ownership change
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/94957
From faf00d0e1286e053ba9fb457513bd8309eb541ed Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Fri, 7 Jun 2024 12:07:35 +0200
Subject: [PATCH 1/2] [analyzer] Add an ownership change
https://github.com/Szelethus created
https://github.com/llvm/llvm-project/pull/94957
This is very similar to https://reviews.llvm.org/D105553, in fact, I barely
made any changes from MallocChecker's ownership visitor to this one.
The new visitor emits a diagnostic note for function where a
@@ -0,0 +1,116 @@
+//===--*- C++
-*--//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/Szelethus closed
https://github.com/llvm/llvm-project/pull/94357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Szelethus updated
https://github.com/llvm/llvm-project/pull/94357
From b6beb7098bb8e5148fe0467dc976506ff6691f15 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Krist=C3=B3f=20Umann?=
Date: Tue, 4 Jun 2024 16:15:42 +0200
Subject: [PATCH 1/2] [analyzer] Factor out
https://github.com/Szelethus edited
https://github.com/llvm/llvm-project/pull/94357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Szelethus wrote:
Yes, it is, sorry about that :)
https://github.com/llvm/llvm-project/pull/94357
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Szelethus created
https://github.com/llvm/llvm-project/pull/94357
In preparation for adding essentially the same visitor to StreamChecker, this
patch factors this visitor out to a common header.
I'll be the first to admit that the interface of these classes are not
https://github.com/Szelethus approved this pull request.
Seems like a very straightforward followup to the existing patches.
https://github.com/llvm/llvm-project/pull/88267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Szelethus approved this pull request.
Lets hope it works fine this time around :)
https://github.com/llvm/llvm-project/pull/85791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Szelethus approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/84963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Szelethus edited
https://github.com/llvm/llvm-project/pull/84469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -41,12 +41,8 @@ class CallDescription {
/// - We also accept calls where the number of arguments or parameters is
///greater than the specified value.
/// For the exact heuristics, see CheckerContext::isCLibraryFunction().
-/// Note that functions whose
@@ -87,9 +87,11 @@ bool CheckerContext::isCLibraryFunction(const FunctionDecl
*FD,
if (!II)
return false;
- // Look through 'extern "C"' and anything similar invented in the future.
- // If this function is not in TU directly, it is not a C library function.
- if
https://github.com/Szelethus commented:
Makes perfect sense to me. Can you add a testcase for `std::malloc` or
something similar?
https://github.com/llvm/llvm-project/pull/84469
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/Szelethus edited
https://github.com/llvm/llvm-project/pull/66481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kristóf Umann
Date: 2022-10-26T17:22:12+02:00
New Revision: a504ddc8bf9d5c406ea88b84b8495d7aae200d4c
URL:
https://github.com/llvm/llvm-project/commit/a504ddc8bf9d5c406ea88b84b8495d7aae200d4c
DIFF:
https://github.com/llvm/llvm-project/commit/a504ddc8bf9d5c406ea88b84b8495d7aae200d4c.diff
Author: Kristóf Umann
Date: 2022-04-08T10:16:58+02:00
New Revision: fd8e5762f86f0a602ec08eea5c4c86927faba6dc
URL:
https://github.com/llvm/llvm-project/commit/fd8e5762f86f0a602ec08eea5c4c86927faba6dc
DIFF:
https://github.com/llvm/llvm-project/commit/fd8e5762f86f0a602ec08eea5c4c86927faba6dc.diff
Author: Kristóf Umann
Date: 2022-03-03T11:27:56+01:00
New Revision: d832078904c6e1d26648236b9f724f699dafb201
URL:
https://github.com/llvm/llvm-project/commit/d832078904c6e1d26648236b9f724f699dafb201
DIFF:
https://github.com/llvm/llvm-project/commit/d832078904c6e1d26648236b9f724f699dafb201.diff
Author: Kristóf Umann
Date: 2022-03-01T17:13:04+01:00
New Revision: 32ac21d04909da0d50d3b24100d5d9ab30b29a95
URL:
https://github.com/llvm/llvm-project/commit/32ac21d04909da0d50d3b24100d5d9ab30b29a95
DIFF:
https://github.com/llvm/llvm-project/commit/32ac21d04909da0d50d3b24100d5d9ab30b29a95.diff
Author: Kristóf Umann
Date: 2022-02-25T17:51:37+01:00
New Revision: 5048a58a6792ee7432b749a48c937cc9b6a9dc93
URL:
https://github.com/llvm/llvm-project/commit/5048a58a6792ee7432b749a48c937cc9b6a9dc93
DIFF:
https://github.com/llvm/llvm-project/commit/5048a58a6792ee7432b749a48c937cc9b6a9dc93.diff
Author: Kristóf Umann
Date: 2022-01-24T16:37:11+01:00
New Revision: 3ad35ba4dea5240dd58476f0c85f0fe096d6c7ce
URL:
https://github.com/llvm/llvm-project/commit/3ad35ba4dea5240dd58476f0c85f0fe096d6c7ce
DIFF:
https://github.com/llvm/llvm-project/commit/3ad35ba4dea5240dd58476f0c85f0fe096d6c7ce.diff
Author: Kristóf Umann
Date: 2021-11-09T15:26:00+01:00
New Revision: 8cc2de667ec2526b055e971f46f4b3731107546c
URL:
https://github.com/llvm/llvm-project/commit/8cc2de667ec2526b055e971f46f4b3731107546c
DIFF:
https://github.com/llvm/llvm-project/commit/8cc2de667ec2526b055e971f46f4b3731107546c.diff
Author: Kristóf Umann
Date: 2021-09-14T16:11:11+02:00
New Revision: fb4d590a622f4031900516360c07ee6ace01c5e6
URL:
https://github.com/llvm/llvm-project/commit/fb4d590a622f4031900516360c07ee6ace01c5e6
DIFF:
https://github.com/llvm/llvm-project/commit/fb4d590a622f4031900516360c07ee6ace01c5e6.diff
Author: Kristóf Umann
Date: 2021-09-13T15:01:20+02:00
New Revision: 9d359f6c738632c6973e9f5328b10bf39b3df55a
URL:
https://github.com/llvm/llvm-project/commit/9d359f6c738632c6973e9f5328b10bf39b3df55a
DIFF:
https://github.com/llvm/llvm-project/commit/9d359f6c738632c6973e9f5328b10bf39b3df55a.diff
Author: Kristóf Umann
Date: 2021-09-13T13:50:01+02:00
New Revision: 0213d7ec0c501414d12020737fdc47e47e4392d9
URL:
https://github.com/llvm/llvm-project/commit/0213d7ec0c501414d12020737fdc47e47e4392d9
DIFF:
https://github.com/llvm/llvm-project/commit/0213d7ec0c501414d12020737fdc47e47e4392d9.diff
Author: Kristóf Umann
Date: 2021-09-03T13:50:18+02:00
New Revision: a375bfb5b729e0f3ca8d5e001f423fa89e74de87
URL:
https://github.com/llvm/llvm-project/commit/a375bfb5b729e0f3ca8d5e001f423fa89e74de87
DIFF:
https://github.com/llvm/llvm-project/commit/a375bfb5b729e0f3ca8d5e001f423fa89e74de87.diff
Author: Kristóf Umann
Date: 2021-09-02T17:19:49+02:00
New Revision: 3891b45a06f9192b7185d03269717cd60dfdea13
URL:
https://github.com/llvm/llvm-project/commit/3891b45a06f9192b7185d03269717cd60dfdea13
DIFF:
https://github.com/llvm/llvm-project/commit/3891b45a06f9192b7185d03269717cd60dfdea13.diff
Author: Kristóf Umann
Date: 2021-09-02T16:56:32+02:00
New Revision: 7d0e62bfb773c68d2bc8831fddcc8536f4613190
URL:
https://github.com/llvm/llvm-project/commit/7d0e62bfb773c68d2bc8831fddcc8536f4613190
DIFF:
https://github.com/llvm/llvm-project/commit/7d0e62bfb773c68d2bc8831fddcc8536f4613190.diff
Author: Kristóf Umann
Date: 2021-08-16T16:19:00+02:00
New Revision: 2d3668c997faac1f64cd3b8eb336af989069d135
URL:
https://github.com/llvm/llvm-project/commit/2d3668c997faac1f64cd3b8eb336af989069d135
DIFF:
https://github.com/llvm/llvm-project/commit/2d3668c997faac1f64cd3b8eb336af989069d135.diff
Author: Kristóf Umann
Date: 2021-08-16T15:03:22+02:00
New Revision: c019142a89b477cd247434c1d8f571662d26e19d
URL:
https://github.com/llvm/llvm-project/commit/c019142a89b477cd247434c1d8f571662d26e19d
DIFF:
https://github.com/llvm/llvm-project/commit/c019142a89b477cd247434c1d8f571662d26e19d.diff
Author: Kristóf Umann
Date: 2021-08-13T16:14:54+02:00
New Revision: 027c5a6adcb3a41c29533680a650fae7262f2b31
URL:
https://github.com/llvm/llvm-project/commit/027c5a6adcb3a41c29533680a650fae7262f2b31
DIFF:
https://github.com/llvm/llvm-project/commit/027c5a6adcb3a41c29533680a650fae7262f2b31.diff
Author: Kirstóf Umann
Date: 2021-06-17T10:27:34+02:00
New Revision: 9cca5c1391d637b5500ada646cf136ddb38254a3
URL:
https://github.com/llvm/llvm-project/commit/9cca5c1391d637b5500ada646cf136ddb38254a3
DIFF:
https://github.com/llvm/llvm-project/commit/9cca5c1391d637b5500ada646cf136ddb38254a3.diff
Author: Kristóf Umann
Date: 2020-09-15T17:43:02+02:00
New Revision: dd1d5488e47d0a89217dfd22a726c3d3ad2b4984
URL:
https://github.com/llvm/llvm-project/commit/dd1d5488e47d0a89217dfd22a726c3d3ad2b4984
DIFF:
https://github.com/llvm/llvm-project/commit/dd1d5488e47d0a89217dfd22a726c3d3ad2b4984.diff
Author: Kristóf Umann
Date: 2020-09-15T16:55:44+02:00
New Revision: 7c6f5b7fbf5a9eee7f3ef9192c354d1536a8f1c6
URL:
https://github.com/llvm/llvm-project/commit/7c6f5b7fbf5a9eee7f3ef9192c354d1536a8f1c6
DIFF:
https://github.com/llvm/llvm-project/commit/7c6f5b7fbf5a9eee7f3ef9192c354d1536a8f1c6.diff
Yup, unless you this breaks something, I'd really prefer to keep it.
On Sat, 12 Sep 2020, 03:24 David Blaikie, wrote:
> LLVM_DUMP_METHOD is meant to be used for annotating functions that might
> be useful to execute from a debugger to dump data structures, etc - so it's
> expected that they'd
Author: Kristóf Umann
Date: 2020-09-11T15:58:48+02:00
New Revision: b9bca883c970d36f408db80df21838c713c326db
URL:
https://github.com/llvm/llvm-project/commit/b9bca883c970d36f408db80df21838c713c326db
DIFF:
https://github.com/llvm/llvm-project/commit/b9bca883c970d36f408db80df21838c713c326db.diff
Author: Kirstóf Umann
Date: 2020-09-11T13:48:26+02:00
New Revision: 7527898fef47da929e70c81100a0248c2f445762
URL:
https://github.com/llvm/llvm-project/commit/7527898fef47da929e70c81100a0248c2f445762
DIFF:
https://github.com/llvm/llvm-project/commit/7527898fef47da929e70c81100a0248c2f445762.diff
Author: Kirstóf Umann
Date: 2020-09-11T13:33:02+02:00
New Revision: 26d9a94681056f88bd3e892f8113093268fa0907
URL:
https://github.com/llvm/llvm-project/commit/26d9a94681056f88bd3e892f8113093268fa0907
DIFF:
https://github.com/llvm/llvm-project/commit/26d9a94681056f88bd3e892f8113093268fa0907.diff
Author: Kirstóf Umann
Date: 2020-09-11T13:29:14+02:00
New Revision: 1c08da38676d15600b5c707cf7522eb4273a5347
URL:
https://github.com/llvm/llvm-project/commit/1c08da38676d15600b5c707cf7522eb4273a5347
DIFF:
https://github.com/llvm/llvm-project/commit/1c08da38676d15600b5c707cf7522eb4273a5347.diff
Apologies for the inconvenience, though I wonder why I haven't gotten
builtbot mails :/
On Tue, 16 Jun 2020 at 09:54, Haojian Wu wrote:
> On Mon, 15 Jun 2020 at 18:29, David Blaikie wrote:
>
>> I don't think the comment's adding value here - it should be fairly
>> clear from the context that
Yup, I'm working on it already, thanks.
On Thu, 21 May 2020 at 01:36, Nico Weber wrote:
> This breaks tests: http://45.33.8.238/linux/18215/step_7.txt
>
> On Wed, May 20, 2020 at 7:05 PM Kirstóf Umann via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>>
>> Author: Kirstóf Umann
>> Date:
Author: Kristóf Umann
Date: 2020-02-25T15:43:33+01:00
New Revision: e5513336aee4a9b10cb98f234145aeb4763fdd69
URL:
https://github.com/llvm/llvm-project/commit/e5513336aee4a9b10cb98f234145aeb4763fdd69
DIFF:
https://github.com/llvm/llvm-project/commit/e5513336aee4a9b10cb98f234145aeb4763fdd69.diff
Author: Kristóf Umann
Date: 2020-02-25T11:17:32+01:00
New Revision: 9fd7ce7f4449619bc85ab4d2643e656836a2d5e2
URL:
https://github.com/llvm/llvm-project/commit/9fd7ce7f4449619bc85ab4d2643e656836a2d5e2
DIFF:
https://github.com/llvm/llvm-project/commit/9fd7ce7f4449619bc85ab4d2643e656836a2d5e2.diff
Apologies for not picking this up, I just recently changed my commit email.
I can see that it was fixed in the meanwhile.
On Sat, 24 Aug 2019 at 01:45, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello Kristof,
>
> This commit broke test to few builders:
>
>
>
Totally possible, thanks for letting me know! There should be plenty of
room for caching, because I do calculate control dependencies in an excess
for the same CFG, and the retrieval of a basic block from an ExplodedNode
is anything but efficient, though I honestly didnt expect a performance hit
Thank you so much! Sorry for the inconvencience, I'll be that much more
careful next time :)
On Mon, 8 Jul 2019, 21:42 Richard Smith, wrote:
> I'll commit the change below once my testing finishes :)
>
> On Mon, 8 Jul 2019 at 12:40, Kristóf Umann via cfe-commits <
> cfe-commits
Noted, thanks! Gabor, could you please fix this?
On Mon, 8 Jul 2019, 21:37 Richard Smith, wrote:
> This is in any case the wrong fix. The code *is* wrong, for the reason
> this compiler is reporting.
>
> The correct fix is to declare the explicit specializations in the header
> file:
>
>
Hi!
Unfortunately, I'm out of town for the week -- I'll see whether I can ask
someone in the office to help out with this.
On Mon, 8 Jul 2019, 21:29 JF Bastien, wrote:
> Kristof,
>
> It looks like your fix didn’t address all the bots:
>
>
91 matches
Mail list logo
