[PATCH] D113694: [Clang] Conform to C++17 definition of literal types

2022-02-26 Thread Léo Lam via Phabricator via cfe-commits
leoetlino added a comment. ping (as per the contributing guidelines) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113694/new/ https://reviews.llvm.org/D113694 ___ cfe-commits mailing list

[PATCH] D113859: [Sema] Fix consteval function calls with value-dependent args

2021-11-14 Thread Léo Lam via Phabricator via cfe-commits
leoetlino added a comment. While this patch doesn't introduce new regressions and does fix compilation of the code snippet mentioned earlier, I'm not sure this is the correct approach, considering there are a bunch of other similar template-related consteval bugs that this patch does *not*

[PATCH] D113859: [Sema] Fix consteval function calls with value-dependent args

2021-11-14 Thread Léo Lam via Phabricator via cfe-commits
leoetlino created this revision. leoetlino added a reviewer: rsmith. Herald added a subscriber: kristof.beyls. leoetlino requested review of this revision. Herald added a project: clang. If any arguments of a consteval function call are value-dependent, the call cannot be evaluated until

[PATCH] D113694: [Clang] Conform to C++17 definition of literal types

2021-11-11 Thread Léo Lam via Phabricator via cfe-commits
leoetlino updated this revision to Diff 386642. leoetlino added a comment. fix formatting issues (sorry for the spam!) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113694/new/ https://reviews.llvm.org/D113694 Files:

[PATCH] D113694: [Clang] Conform to C++17 definition of literal types

2021-11-11 Thread Léo Lam via Phabricator via cfe-commits
leoetlino updated this revision to Diff 386622. leoetlino added a comment. Fix Clang.CodeGenCXX::mangle-class-nttp.cpp test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113694/new/ https://reviews.llvm.org/D113694 Files:

[PATCH] D113694: [Clang] Conform to C++17 definition of literal types

2021-11-11 Thread Léo Lam via Phabricator via cfe-commits
leoetlino created this revision. leoetlino requested review of this revision. Herald added a project: clang. C++17 changed the definition of literal types so that unions that have at least one non-static data member of non-volatile literal type are also considered literal types. This patch