On Mon, 21 Oct 2024, Jiri Kosina wrote:
> On Tue, 1 Oct 2024, Lee Jones wrote:
>
> > Enjoy!
> >
> > The following changes since commit 9852d85ec9d492ebef56dc5f229416c925758edc:
> >
> > Linux 6.12-rc1 (2024-09-29 15:06:19 -0700)
> >
> > are av
ht: convert zii,rave-sp-backlight.txt to yaml
commit: 0eda30af58809224d80dc3bf3f368fc677fe8c08
--
Lee Jones [李琼斯]
txt to yaml format
commit: f4b00ab2c29960961f9641be8f3e8ba4960fd849
--
Lee Jones [李琼斯]
es),
> MFD_CELL_NAME("88pm886-regulator"),
> + MFD_CELL_NAME("88pm886-rtc"),
> };
>
> static int pm886_power_off_handler(struct sys_off_data *sys_off_data)
> --
> 2.47.0
>
--
Lee Jones [李琼斯]
gt; MAINTAINERS | 1 +
> drivers/rtc/Kconfig | 10
> drivers/rtc/Makefile| 1 +
> drivers/rtc/rtc-88pm886.c | 97 +++++++++
> include/linux/mfd/88pm886.h | 9
Acked-by: Lee Jones
> 5 files changed, 118 inser
On Thu, 10 Oct 2024, Karel Balej wrote:
> Lee Jones, 2024-10-10T09:35:19+01:00:
> > On Thu, 10 Oct 2024, Lee Jones wrote:
> >
> > > On Wed, 09 Oct 2024, Karel Balej wrote:
> > >
> > > > Lee Jones, 2024-10-09T11:06:43+01:00:
> > > >
an Muralidharan
> ---
> drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 8 +++-
> include/linux/mfd/atmel-hlcdc.h | 1 +
Acked-by: Lee Jones
> 2 files changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
On Wed, 09 Oct 2024, Lee Jones wrote:
> On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote:
> > RTC lives on the base register page of the chip. Add definitions of the
> > registers needed for a basic set/read time functionality.
> >
> >
>
> Applied, thanks!
On Thu, 10 Oct 2024, Lee Jones wrote:
> On Wed, 09 Oct 2024, Karel Balej wrote:
>
> > Lee Jones, 2024-10-09T11:06:43+01:00:
> > > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote:
> > > > RTC lives on the base register page of the chip. Add definitions of t
On Wed, 09 Oct 2024, Karel Balej wrote:
> Lee Jones, 2024-10-09T11:06:43+01:00:
> > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote:
> > > RTC lives on the base register page of the chip. Add definitions of the
> > > registers needed for a basic
;)
>
> With those not being called, it means that the backlight_notifier
> list is always empty.
>
> [...]
Applied, thanks!
[1/1] backlight: Remove notifier
commit: 5461f3fd74a89757f95f351eb0bc26aafc2a2e91
--
Lee Jones [李琼斯]
s, the list itself and the enum used in the
> > notifications.
> >
> > Signed-off-by: Dr. David Alan Gilbert
>
> Reviewed-by: Simona Vetter
>
> I think Lee Jones or Daniel Thompson will pick this up.
I will pick this up with Daniel's review.
--
Lee Jones [李琼斯]
commit: 0a936c2c45884b9a3800379f3cab4d0a685d63f5
--
Lee Jones [李琼斯]
On Mon, 07 Oct 2024, Werner Sembach wrote:
>
> Am 07.10.24 um 14:58 schrieb Lee Jones:
> > On Fri, 04 Oct 2024, Werner Sembach wrote:
> >
> > > Am 03.10.24 um 09:59 schrieb Lee Jones:
> > > > On Wed, 02 Oct 2024, Werner Sembach wrote:
> > > >
On Fri, 04 Oct 2024, Werner Sembach wrote:
>
> Am 03.10.24 um 09:59 schrieb Lee Jones:
> > On Wed, 02 Oct 2024, Werner Sembach wrote:
> >
> > > Hi,
> > >
> > > Am 02.10.24 um 14:52 schrieb Lee Jones:
> > > > On Fri, 27 Sep 2024, Wer
On Wed, 02 Oct 2024, Werner Sembach wrote:
> Hi,
>
> Am 02.10.24 um 14:52 schrieb Lee Jones:
> > On Fri, 27 Sep 2024, Werner Sembach wrote:
> >
> > > Hi,
> > > first revision integrating Armins feedback.
> > >
> > > Stuff I did not ye
nnotate and --compose next time please.
--
Lee Jones [李琼斯]
/fbdev/omap/lcd_ams_delta.c | 8 ++---
include/linux/fb.h | 13 +
include/linux/lcd.h | 29 +-
include/video/platform_lcd.h | 3 --
21 files changed, 181 insertions(+), 158 deletions(-)
--
Lee Jones [李琼斯]
ght: lcd: Do not include in lcd header
commit: 0d580d99749e759b62dc8e28f511310e9235da7a
--
Lee Jones [李琼斯]
d08906be37b8
--
Lee Jones [李琼斯]
commit: 3db60398b4c10425dd32c076280af7f334431064
--
Lee Jones [李琼斯]
On Thu, 12 Sep 2024, Mark Brown wrote:
> On Thu, Sep 12, 2024 at 03:51:00PM +0100, Lee Jones wrote:
> > On Wed, 04 Sep 2024, Mark Brown wrote:
>
> > > [03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
> > > commit: 761cab667898d86c04867
se engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.
>
> Thanks,
> Mark
>
--
Lee Jones [李琼斯]
u can do what you like with them since
> > none are major enough to stop me also sharing a:
> > Reviewed-by: Daniel Thompson
>
> Thanks for reviewing. I'll send out an update. Why tree do these patches go
> into? Backlight?
Yes, that's expected.
--
Lee Jones [李琼斯]
roller we wouldn't
> be able to implement that without having some other DT property to
> indicate which output ports are connected to the DP endpoint.
>
> Reviewed-by: Rob Herring (Arm)
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Acked-by: Lee Jones
> Cc: B
On Wed, 28 Aug 2024 15:10:55 +, Detlev Casanova wrote:
> Document rk3576 compatible for QoS registers.
>
>
Applied, thanks!
[04/11] dt-bindings: mfd: syscon: Add rk3576 QoS register compatible
commit: 2f9709b8541dc742235743d19b8a6e2baa2e81d4
--
Lee Jones [李琼斯]
On Thu, 22 Aug 2024, Kees Cook wrote:
> On Thu, Jul 25, 2024 at 11:22:40AM +0100, Lee Jones wrote:
> > On Tue, 16 Jul 2024, Gustavo A. R. Silva wrote:
> >
> > >
> > >
> > > On 16/07/24 15:24, Kees Cook wrote:
> > > > With the new __c
to the array.
>
> [...]
Applied, thanks!
[1/1] leds: gpio: Set num_leds after allocation
commit: 045391a02bd971d431c83ad03f7cc51b6e2fe331
--
Lee Jones [李琼斯]
On Mon, 19 Aug 2024, Stephen Boyd wrote:
> This binding is about USB type-c control. Move the binding to the usb
> directory as it's a better home than chrome.
>
> Cc: Rob Herring
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Cc: Lee Jones
> Cc: Benson Leu
roller we wouldn't
> be able to implement that without having some other DT property to
> indicate which output ports are connected to the DP endpoint.
>
> Cc: Rob Herring
> Cc: Krzysztof Kozlowski
> Cc: Conor Dooley
> Cc: Lee Jones
> Cc: Benson Leung
> Cc: Guenter
gning your mails like this. It means that some of
us have to physically click a pop-up box as we are parsing our inboxes.
I'm deleting all mails in this thread.
--
Lee Jones [李琼斯]
down.
>
> Also, add the audio power supply property which is dedicated for
> the audio codec sub-device.
>
> [...]
Applied, thanks!
[03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
commit: 3821149eb101fe2d45a4697659e60930828400d8
--
Lee Jones [李琼斯]
down.
>
> Also, add the audio power supply property which is dedicated for
> the audio codec sub-device.
>
> [...]
Applied, thanks!
[03/16] dt-bindings: mfd: mediatek: Add codec property for MT6357 PMIC
commit: 3821149eb101fe2d45a4697659e60930828400d8
--
Lee Jones [李琼斯]
| 12 -
> drivers/clk/qcom/common.c | 4 +--
> drivers/clk/sunxi/clk-simple-gates.c| 4 +--
> drivers/clk/sunxi/clk-sun8i-bus-gates.c | 4 +--
> drivers/clocksource/samsung_pwm_timer.c | 4 +--
> drivers/gpio/gpio-brcmstb.c
A. R. Silva
>
> Thanks
> --
Using the signature tag in the middle of an email turns the remainder of
the body into a signature block, which is odd to say the least. By all
means sign-off in the middle of a mail, but please refrain from
converting the rest of the mail.
> Gustavo
&
575651c593a9
--
Lee Jones [李琼斯]
16/17] backlight: rave-sp-backlight: Use backlight power constants
commit: 22f8a85ef0c563ba7e53d9ece39c1f2dc99f53ed
[17/17] backlight: sky81452-backlight: Use backlight power constants
commit: 1df5aa3754cac2045998ca505edb84d994786c67
--
Lee Jones [李琼斯]
On Fri, 28 Jun 2024, Lee Jones wrote:
> On Fri, 31 May 2024 19:34:55 +0200, Karel Balej wrote:
> > the following implements basic support for Marvell's 88PM886 PMIC which
> > is found for instance as a component of the samsung,coreprimevelte
> > smartphone which inspired
144396e9570efea02d467df0a68fd28db6f
[4/5] input: add onkey driver for Marvell 88PM886 PMIC
commit: 914089db309ccc590314b6c21df5a1f812e9ab0b
[5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC
commit: f53d3efa366b1754f0389944401bb53397d22468
--
Lee Jones [李琼斯]
> In particular, the allocation for the array of pointers was converted
> into a single-pointer allocation.
>
> [...]
Applied, thanks!
[1/1] mfd: omap-usb-tll: use struct_size to allocate tll
commit: 1938e6882b89d1d01926ed3e0bbdd8346263c317
--
Lee Jones [李琼斯]
y SY7802 flash LED controller
commit: d0838d7c837820733c4e6b9c6d16323d307ebd96
--
Lee Jones [李琼斯]
> The scoped version of the macro accounts for such early breaks, fixing
> the early exits without the need for explicit calls to of_node_put().
>
> [...]
Applied, thanks!
[1/1] backlight: lm3509_bl: Fix early returns in for_each_child_of_node()
commit: b337cc3ce47549528fc3ee0b8c7ebd
w clear
> what is what.
>
>
> [...]
Applied, thanks!
[1/2] mfd: omap-usb-tll: annotate struct usbtll_omap with __counted_by
commit: 621a62fdd279b06c23bc6c3073b8fe52b5dc356c
--
Lee Jones [李琼斯]
-tll.c
> @@ -230,8 +230,7 @@ static int usbtll_omap_probe(struct platform_device *pdev)
> break;
> }
>
> - tll = devm_kzalloc(dev, sizeof(*tll) + sizeof(tll->ch_clk[nch]),
> -GFP_KERNEL);
> + tll = devm_kzalloc(dev, struct
On Sat, 22 Jun 2024, André Apitzsch wrote:
> Hello Lee,
>
> Am Freitag, dem 21.06.2024 um 11:26 +0100 schrieb Lee Jones:
> > On Sun, 16 Jun 2024, André Apitzsch via B4 Relay wrote:
> >
> > > From: André Apitzsch
> > >
> > > The SY7802 is a
+++
> 3 files changed, 554 insertions(+)
Generally very nice.
Just a couple of teensy nits to fix then add my and resubmit please.
Acked-by: Lee Jones
> diff --git a/drivers/leds/flash/Kconfig b/drivers/leds/flash/Kconfig
> index 809b6d98bb3e..f39f0bfe6eef 100644
> --- a/drivers
er, more experienced maintainer's reviews would also be a good
> > use
> > of your time.
>
> I am trying to influence adjustments in desirable directions for a while.
Never stop trying to improve.
These are only my opinions of course. Take the advice or leave it.
There's no need to reply to this.
--
Lee Jones [李琼斯]
iew points, rather than repeating the same
few over and over? Reading other, more experienced maintainer's reviews
would also be a good use of your time.
--
Lee Jones [李琼斯]
On Fri, 21 Jun 2024, Nuno Sá wrote:
> On Fri, 2024-06-21 at 12:39 +0530, Vinod Koul wrote:
> > On 20-06-24, 18:05, Lee Jones wrote:
> > > On Thu, 20 Jun 2024, Vinod Koul wrote:
> > >
> > > > On 20-06-24, 12:45, Markus Elfring wrote:
> > > &g
o initialization or named designators. But it's also a nice
> cleanup on its own.
>
> [...]
Applied, thanks!
[1/1] backlight: Drop explicit initialization of struct
i2c_device_id::driver_data to 0
commit: bfd3587760498227510acc1b18c4299c7922ffe3
--
Lee Jones [李琼斯]
> The one where all emails from Markus go to dev/null
Play nice please.
Documentation/process/code-of-conduct.rst
--
Lee Jones [李琼斯]
natural as you can.
Ex 1: Please place curly brackets around this section to aid with
Ex 2: To save N lines of clean-up, please use scoped_guard()
Ex 3: Moving out this chunk to another function would help with
Etc.
--
Lee Jones [李琼斯]
MEM;
> > mutex_init(&powernv_led_common->lock);
> > powernv_led_common->max_led_type = cpu_to_be64(OPAL_SLOT_LED_TYPE_MAX);
> > platform_set_drvdata(pdev, powernv_led_common);
> > - rc = powernv_led_classdev(pdev, led_node, powernv_led_common);
> > -out:
> > - of_node_put(led_node);
> > - return rc;
> > + return powernv_led_classdev(pdev, led_node, powernv_led_common);
> > }
> > /* Platform driver remove */
>
> Hello,
> Did you have a chance to look at the patch after the requested change?
Was that for me? Please refrain from pinging.
My TODO list is long and I'm doing my best to get through it.
--
Lee Jones [李琼斯]
in the kernel code.
>
> [...]
Applied, thanks!
[1/1] leds: powernv: replace of_node_put to __free
commit: 7c85503b6d597b84ea58fe3dd95cd9eaeb1f3206
--
Lee Jones [李琼斯]
/video/backlight/rt4831-backlight.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
>
> [...]
Applied, thanks!
[1/1] backlight: add missing MODULE_DESCRIPTION() macros
commit: 7857f5c38d04a38e7a20060a6d370caf0424aa4e
--
Lee Jones [李琼斯]
tion
commit: 90b7f2ead953aab5677ae8235d78841cee8fd13e
--
Lee Jones [李琼斯]
> drivers/regulator/Makefile| 1 +
> 3 files changed, 399 insertions(+)
> create mode 100644 drivers/regulator/88pm886-regulator.c
I'm fine with this set - just waiting for Mark to review.
--
Lee Jones [李琼斯]
now I leave it to Lee and Johan to decide
> the destiny of the drivers.
Let's not rush into it. Take your time.
--
Lee Jones [李琼斯]
> 11 files changed, 2865 deletions(-)
> delete mode 100644 drivers/iio/light/lm3533-als.c
> delete mode 100644 drivers/leds/leds-lm3533.c
> delete mode 100644 drivers/mfd/lm3533-core.c
> delete mode 100644 drivers/video/backlight/lm3533_bl.c
> delete mode 100644 include/linux/mfd/lm3533.h
>
> --
> 2.43.0.rc1.1336.g36b5255a03ac
>
--
Lee Jones [李琼斯]
d_common->lock);
> powernv_led_common->max_led_type = cpu_to_be64(OPAL_SLOT_LED_TYPE_MAX);
>
> platform_set_drvdata(pdev, powernv_led_common);
>
> - rc = powernv_led_classdev(pdev, led_node, powernv_led_common);
> -out:
> - of_node_put(led_node);
> - return rc;
> + return powernv_led_classdev(pdev, led_node, powernv_led_common);
> }
>
> /* Platform driver remove */
> --
> 2.34.1
>
--
Lee Jones [李琼斯]
river
commit: b72755f5b577357cac661cbf9048cad704eb4ad8
--
Lee Jones [李琼斯]
gt; drivers/mfd/Makefile| 1 +
> include/linux/mfd/88pm886.h | 69 +
> 4 files changed, 230 insertions(+)
> create mode 100644 drivers/mfd/88pm886.c
> create mode 100644 include/linux/mfd/88pm886.h
I don't see any more issues.
Are you planning on seeing to Mark's review comments?
--
Lee Jones [李琼斯]
17, 1, "active-low", "active-high"),
> + fld("ii", 16, 1, "normal", "inverted"),
> + fld("pll", 15, 1, "disable", "enable"),
> + fld("gap", 13, 2, "0"),
> + fld("dac", 12, 1, "enable", "disable"),
> + fld("mc", 11, 1, "cpu", "8051"),
> + fld("bl", 10, 8, "1"),
> + fld("usb", 9, 1, "master", "slave"),
> + fld("vr", 4, 1, "0x1e0", "0x3e0"),
> + { .name = NULL },
> +};
I've been avoiding this set for a while now!
I appreciate the amount of work that you've put into this, but this is a
bit of a disaster. It's a hell of lot of over-complex infrastructure
just to pull out some values from DT.
Forgive me if I have this wrong, but it looks like you're defining
various structs then populating static versions with hard-coded offsets
into DT arrays! Then you have a bunch of hoop-jumpy functions to
firstly parse the offset-structs, then conduct look-ups to pull the
final value which in turn gets shifted into an encoded variable ready
for to write out to the registers. Bonkers.
What does 'timing' even mean in this context? Clocks?
What other devices require this kind of handling? Why is this device so
different from all other supported devices to date? Instead of
attempting to shoehorn this into a 20 year old driver, why not reshape
it to bring it into alignment with how we do things today?
E.g. handle all clocking from the clock driver, all display settings
(including timing?) from the display driver, etc.
--
Lee Jones [李琼斯]
earer
> bindings.
>
>
> [...]
Applied, thanks!
[1/1] dt-bindings: leds: add FUNCTION defines for per-band WLANs
commit: 89d9d3eedc8804e06a770e3cf1279f9131b785f1
--
Lee Jones [李琼斯]
___
openwrt-devel mailing list
openwrt-devel@lists.openwrt.o
/lcd.h | 6 +++---
scripts/const_structs.checkpatch | 1 +
20 files changed, 23 insertions(+), 22 deletions(-)
--
Lee Jones [李琼斯]
On Sat, 04 May 2024, André Apitzsch wrote:
> Am Freitag, dem 03.05.2024 um 08:19 +0100 schrieb Lee Jones:
> > On Thu, 11 Apr 2024, Lee Jones wrote:
> >
> > > On Mon, 01 Apr 2024, André Apitzsch via B4 Relay wrote:
> > >
> > > > From: André Apitzsch
On Fri, 03 May 2024, Lee Jones wrote:
> On Fri, 03 May 2024, Lee Jones wrote:
>
> > On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote:
> > > Changes in v2:
> > > - Collect tags, including wrongly places Thomas' tag (which requires me
> > >
On Fri, 03 May 2024, Lee Jones wrote:
> On Wed, 24 Apr 2024 08:33:26 +0200, Krzysztof Kozlowski wrote:
> > Changes in v2:
> > - Collect tags, including wrongly places Thomas' tag (which requires me
> > to manually edit 15 other patches to drop it).
> >
ec6108d768f54d31e7cb48b06c0e3814
--
Lee Jones [李琼斯]
On Thu, 02 May 2024, André Apitzsch wrote:
> Am Donnerstag, dem 02.05.2024 um 10:10 +0100 schrieb Lee Jones:
> > On Wed, 01 May 2024, André Apitzsch wrote:
> >
> > > > > + ret = -EBUSY;
> > > > > + goto unlock;
> >
On Thu, 11 Apr 2024, Lee Jones wrote:
> On Mon, 01 Apr 2024, André Apitzsch via B4 Relay wrote:
>
> > From: André Apitzsch
> >
> > Add support for SY7802 flash LED controller. It can support up to 1.8A
> > flash current.
>
> This is a very small c
On Fri, 03 May 2024, FLAVIO SULIGOI wrote:
> Hi Lee,
>
> ...
>
> > Subject: EXTERNAL: Re: (subset) [PATCH v1 1/1] backlight: mp3309c: fix
> > leds flickering in pwm mode
> >
> > [Use caution with links & attachments]
> >
> >
> >
&
-backlight: Remove unnecessary call to of_node_get
commit: 4da294108e38bf9cd5c62c2caa47611e5dbb7fb1
--
Lee Jones [李琼斯]
On Thu, 02 May 2024, Lee Jones wrote:
> On Wed, 17 Apr 2024 17:31:05 +0200, Flavio Suligoi wrote:
> > The mp3309 has two configuration registers, named according to their
> > address (0x00 and 0x01).
> > In the second register (0x01), the bit DIMS (Dimming Mode Select) must
kering on the LEDs powered by the mp3309c.
>
> [...]
Applied, thanks!
[1/1] backlight: mp3309c: fix leds flickering in pwm mode
commit: ce60cddc2abf61902dfca71d630624db95315124
--
Lee Jones [李琼斯]
On Fri, 12 Apr 2024 16:22:53 +0200, Luca Weiss wrote:
> Add the PBS (Programmable Boot Sequencer) to the list of devices.
>
>
Applied, thanks!
[1/1] dt-bindings: mfd: qcom,spmi-pmic: Add pbs to SPMI device types
commit: a1f3b5edaf18b1c71a537032c4a6537bde2ad5e9
--
Lee Jones [李琼斯]
edid && len == EDID_LENGTH) {
> + struct fb_monspecs *specs;
> + u8 *edid;
> +
> + edid = kmemdup(p_edid, EDID_LENGTH, GFP_KERNEL);
> + if (edid) {
> + specs = kzalloc(sizeof(*specs), GFP_KERNEL);
> + if (specs) {
> + fb_edid_to_monspecs(edid, specs);
> + def_mode = specs->modedb;
> + }
> + }
> + kfree(edid);
> + }
> +
> + of_property_read_u32(child, "bpp", &bpp);
> +
> + /* If flags property is obtained, fbsub is returned. */
> + flags = read_display_flags(child);
> + if (flags) {
> + fbsub = devm_kzalloc(dev, sizeof(*fbsub), GFP_KERNEL);
> + if (fbsub) {
> + fbsub->def_mode = def_mode;
> + fbsub->def_bpp = bpp;
> + fbsub->flags = flags;
> + }
> + }
> + return fbsub;
> +}
> +
> +/* Build platform_data from OF property */
> +static struct sm501_platdata_fb *pdata_from_dt(struct device *dev, struct
> device_node *np)
> +{
> + enum sm501_fb_routing fb_route = SM501_FB_OWN;
> + struct sm501_platdata_fb *pdata = NULL;
> + struct sm501_platdata_fbsub *fb_crt;
> + struct sm501_platdata_fbsub *fb_pnl;
> + unsigned int flags = 0;
> +
> + if (of_property_read_bool(np, "route-crt-panel"))
> + fb_route = SM501_FB_CRT_PANEL;
> + if (of_property_read_bool(np, "swap-fb-endian"))
> + flags = SM501_FBPD_SWAP_FB_ENDIAN;
> + fb_crt = dt_fbsub(dev, np, "crt");
> + fb_pnl = dt_fbsub(dev, np, "panel");
> + if (fb_crt || fb_pnl) {
> + pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
> + if (pdata) {
> + pdata->fb_route = fb_route;
> + pdata->flags = flags;
> + pdata->fb_crt = fb_crt;
> + pdata->fb_pnl = fb_pnl;
> + }
> + }
> + return pdata;
> +}
> +#endif
> +
> static int sm501fb_probe(struct platform_device *pdev)
> {
> struct sm501fb_info *info;
> @@ -1974,6 +2074,12 @@ static int sm501fb_probe(struct platform_device *pdev)
> if (info->edid_data)
> found = 1;
> }
> + /* Get platform data compatible configuration */
> + if (!found) {
> + info->pdata = pdata_from_dt(dev, np);
> + if (info->pdata)
> + found = 1;
> + }
> }
> #endif
> if (!found) {
> --
> 2.39.2
>
--
Lee Jones [李琼斯]
On Thu, 02 May 2024, Lee Jones wrote:
> On Thu, 02 May 2024, Shresth Prasad wrote:
>
> > On Thu, May 2, 2024 at 3:06 PM Lee Jones wrote:
> > >
> > > On Thu, 02 May 2024, Shresth Prasad wrote:
> > >
> > > > `dev->of_node` already has a refere
On Thu, 02 May 2024, Shresth Prasad wrote:
> On Thu, May 2, 2024 at 3:06 PM Lee Jones wrote:
> >
> > On Thu, 02 May 2024, Shresth Prasad wrote:
> >
> > > `dev->of_node` already has a reference to the device_node and calling
> > > of_node_get on it
https://lore.kernel.org/all/?q=%22%5BPATCH+v3%5D%5Bnext%5D+backlight%3A+sky81452-backlight%3A+Remove+unnecessary+call+to+of_node_get%22
--
Lee Jones [李琼斯]
On Mon, 29 Apr 2024, Justin Stitt wrote:
> I am going to quote Lee Jones who has been doing some snprintf ->
> scnprintf refactorings:
>
> "There is a general misunderstanding amongst engineers that
> {v}snprintf() returns the length of the data *actually* encoded into
On Mon, 29 Apr 2024, Joe Perches wrote:
> On Mon, 2024-04-29 at 12:49 -0700, Kees Cook wrote:
> > On Mon, Apr 29, 2024 at 06:39:28PM +, Justin Stitt wrote:
> > > I am going to quote Lee Jones who has been doing some snprintf ->
> > > scnprintf refactorings:
&g
On Wed, 01 May 2024, André Apitzsch wrote:
> Hi Lee Jones,
>
> thanks for the feedback. I will address your comments in the next
> version. I have a few comments/questions though, see below.
>
> Best regards,
> André
>
> Am Donnerstag, dem 11.04.2024 um 13:48 +010
deo/fbdev/omap/lcd_ams_delta.c | 2 +-
> include/linux/lcd.h | 6 +++---
> scripts/const_structs.checkpatch | 1 +
> 20 files changed, 23 insertions(+), 22 deletions(-)
> ---
> base-commit: a59668a9397e7245b26e9be85d23f242ff757ae8
> change-id: 20240414-video-backlight-lcd-ops-276d8439ffb8
>
> Best regards,
> --
> Krzysztof Kozlowski
>
--
Lee Jones [李琼斯]
20240414-video-backlight-lcd-ops-v1-0-9b37fcbf5...@kernel.org
>
> Cc: Lee Jones
> Cc: Daniel Thompson
> Cc: Jingoo Han
> Cc: linux-fb...@vger.kernel.org
> Cc: linux-ker...@vger.kernel.org
> ---
> scripts/const_structs.checkpatch | 1 +
> 1 file changed, 1 insertion(+)
imers.c:
ksft_perror("Can't create timer");
stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c:
ksft_perror("Can't call gettimeofday()");
stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c:
ksft_perror("Can't set timer");
stable/linux-6.6.y:tools/testing/selftests/timers/posix_timers.c:
ksft_perror("Can't call gettimeofday()");
We should probably have this added to linux-6.6.y.
--
Lee Jones [李琼斯]
gt; EVERYTHING. You must provide tag under each individual patch.
And for that to not happen now, you have to resubmit the set. :)
--
Lee Jones [李琼斯]
On Thu, 11 Apr 2024, Karel Balej wrote:
> Lee Jones, 2024-04-11T12:37:26+01:00:
> [...]
> > > diff --git a/drivers/mfd/88pm886.c b/drivers/mfd/88pm886.c
> > > new file mode 100644
> > > index ..e06d418a5da9
> > > --- /dev/null
> > &g
s"
> + chip = devm_kzalloc(dev, struct_size(chip, leds, count), GFP_KERNEL);
> + if (!chip)
> + return -ENOMEM;
> +
> + chip->num_leds = count;
> +
> + chip->dev = dev;
> + i2c_set_clientdata(client, chip);
> +
> + chip-&g
b99886057a85
--
Lee Jones [李琼斯]
LP8788_BL_REGISTER_ONLY.
>
>
Applied, thanks!
[1/1] backlight: lp8788: Drop support for platform data
commit: 150476e60a80ebb93d49aae7b636934eb04b83d2
--
Lee Jones [李琼斯]
0.o 88pm80x.o
> obj-$(CONFIG_MFD_88PM805)+= 88pm805.o 88pm80x.o
> +obj-$(CONFIG_MFD_88PM886_PMIC) += 88pm886.o
> obj-$(CONFIG_MFD_ACT8945A) += act8945a.o
> obj-$(CONFIG_MFD_SM501) += sm501.o
> obj-$(CONFIG_ARCH_BCM2835) += bcm2835-pm.o
> diff --git a/include/linux/mfd/88pm886.h b/include/linux/mfd/88pm886.h
> new file mode 100644
> index ..5ce30a3b85aa
> --- /dev/null
> +++ b/include/linux/mfd/88pm886.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __MFD_88PM886_H
> +#define __MFD_88PM886_H
> +
> +#include
> +#include
> +
> +#define PM886_A1_CHIP_ID 0xa1
> +
> +#define PM886_REG_ID 0x00
> +
> +#define PM886_REG_STATUS10x01
> +#define PM886_ONKEY_STS1 BIT(0)
> +
> +#define PM886_REG_MISC_CONFIG1 0x14
> +#define PM886_SW_PDOWN BIT(5)
> +
> +#define PM886_REG_MISC_CONFIG2 0x15
> +#define PM886_INT_INVBIT(0)
> +#define PM886_INT_CLEAR BIT(1)
> +#define PM886_INT_RC 0x00
> +#define PM886_INT_WC BIT(1)
> +#define PM886_INT_MASK_MODE BIT(2)
> +
> +struct pm886_chip {
> + struct i2c_client *client;
> + unsigned int chip_id;
> + struct regmap *regmap;
> +};
> +#endif /* __MFD_88PM886_H */
> --
> 2.44.0
>
--
Lee Jones [李琼斯]
LP8788_BL_REGISTER_ONLY.
>
>
Applied, thanks!
[1/1] backlight: lp8788: Drop support for platform data
commit: 150476e60a80ebb93d49aae7b636934eb04b83d2
--
Lee Jones [李琼斯]
On Mon, 08 Apr 2024, Justin Stitt wrote:
> I am going to quote Lee Jones who has been doing some snprintf ->
> scnprintf refactorings:
>
> "There is a general misunderstanding amongst engineers that
> {v}snprintf() returns the length of the data *actually* encoded into
On Thu, 28 Mar 2024, Lee Jones wrote:
> On Thu, 28 Mar 2024 12:59:06 +0100, Greg Kroah-Hartman wrote:
> > Since commit 43a7206b0963 ("driver core: class: make class_register() take
> > a const *"), the driver core allows for struct class to be in read-only
> > memo
ke lcd_class constant
commit: d51564f749fe4e4efd570b0591f2d23696c90cc7
--
Lee Jones [李琼斯]
drivers/video/backlight/lcd.c | 23 +--
> 2 files changed, 29 insertions(+), 23 deletions(-)
No longer apply.
Please rebase on top of v6.9-rc1 or for-backlight-next.
--
Lee Jones [李琼斯]
| 1 -
11 files changed, 26 insertions(+), 84 deletions(-)
--
Lee Jones [李琼斯]
+++
include/linux/backlight.h| 16
include/linux/fb.h | 9 +
include/linux/pwm_backlight.h| 1 -
16 files changed, 71 insertions(+), 97 deletions(-)
--
Lee Jones [李琼斯]
that this didn't fail to compile ...
>
> Best regards
> Uwe
>
> drivers/video/backlight/lp8788_bl.c | 151 ++--
> include/linux/mfd/lp8788.h | 36 ---
> 2 files changed, 8 insertions(+), 179 deletions(-)
Does not apply.
Please rebase onto v6.9-rc1 or for-backlight-next.
--
Lee Jones [李琼斯]
1 - 100 of 3892 matches
Mail list logo
