[PATCH] driver: rng: Do not check ARM_SMCCC_TRNG_VERSION

2024-07-09 Thread Leo Yan
his commit removes the invocation to avoid the failure - which is a wrong calling in U-boot. The later code invokes ARM_SMCCC_TRNG_VERSION for retrieving the TRNG version, except it can read back the version number, it also can be used to detect whether the TRNG is supported or not. Signed-off-b

Re: [PATCH v1 0/4] perf parse-regs: Cleanup config and building

2024-02-14 Thread Leo Yan
On Wed, Feb 14, 2024 at 02:42:55PM -0800, Ian Rogers wrote: [...] > Thanks Leo, this is great cleanup! Series: > Reviewed-by: Ian Rogers Thanks a lot for reviewing, Ian! Leo

[PATCH v1 4/4] perf build: Cleanup perf register configuration

2024-02-14 Thread Leo Yan
EGS_SUPPORT' from the Makefile. Signed-off-by: Leo Yan --- tools/perf/Makefile.config | 21 - 1 file changed, 21 deletions(-) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index 8b740c668ab7..7de7111c0226 100644 --- a/tools/perf/Makefile.config +++ b/

[PATCH v1 3/4] perf parse-regs: Introduce a weak function arch__sample_reg_masks()

2024-02-14 Thread Leo Yan
needed anymore, so remove it. Signed-off-by: Leo Yan --- tools/perf/arch/arm/util/perf_regs.c | 7 ++- tools/perf/arch/arm64/util/machine.c | 2 ++ tools/perf/arch/arm64/util/perf_regs.c | 7 ++- tools/perf/arch/csky/util/perf_regs.c | 7 ++- tools/perf/arch/loong

[PATCH v1 2/4] perf parse-regs: Always build perf register functions

2024-02-14 Thread Leo Yan
native parsing and cross parsing, the tool should always build the perf regs functions. Thus, this patch removes HAVE_PERF_REGS_SUPPORT from the perf regs files. Signed-off-by: Leo Yan --- .../util/perf-regs-arch/perf_regs_aarch64.c | 4 --- .../perf/util/perf-regs-arch/perf_regs_arm.c | 4

[PATCH v1 1/4] perf build: Remove unused CONFIG_PERF_REGS

2024-02-14 Thread Leo Yan
CONFIG_PERF_REGS is not used, remove it. Signed-off-by: Leo Yan --- tools/perf/Makefile.config | 4 1 file changed, 4 deletions(-) diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config index aa55850fbc21..8b740c668ab7 100644 --- a/tools/perf/Makefile.config +++ b/tools/perf

[PATCH v1 0/4] perf parse-regs: Cleanup config and building

2024-02-14 Thread Leo Yan
macro 'HAVE_PERF_REGS_SUPPORT' in the source file. The forth patch is to clean up the Makefile for removing relevant configuration and macro definition, as they are not useful anymore. I tested this patch set on Arm64 and x86 for building and did a cross register parsing ('perf recor

Re: [PATCH v3 0/4] virtio: Refactor vhost input stub

2023-12-29 Thread Leo Yan
Hi Michael, On Mon, Dec 25, 2023 at 11:06:35AM -0500, Michael S. Tsirkin wrote: > On Mon, Nov 20, 2023 at 12:37:17PM +0800, Leo Yan wrote: > > This series is to refactor vhost stub vhost-user-input. > > > > Since vhost input stub requires set_config() callback for co

[PATCH v3 1/4] hw/virtio: Support set_config() callback in vhost-user-base

2023-11-19 Thread Leo Yan
The Virtio input device invokes set_config() callback for retrieving the event configuration info, but the callback is not supported in vhost-user-base. This patch adds support set_config() callback in vhost-user-base. Signed-off-by: Leo Yan Reviewed-by: Marc-André Lureau --- hw/virtio/vhost

[PATCH v3 2/4] docs/system: Add vhost-user-input documentation

2023-11-19 Thread Leo Yan
This adds basic documentation for vhost-user-input. Signed-off-by: Leo Yan --- MAINTAINERS | 1 + docs/system/device-emulation.rst | 1 + docs/system/devices/vhost-user-input.rst | 45 docs/system/devices/vhost-user.rst | 4

[PATCH v3 0/4] virtio: Refactor vhost input stub

2023-11-19 Thread Leo Yan
changing folder for vhost-user-input.c. (Manos) Leo Yan (4): hw/virtio: Support set_config() callback in vhost-user-base docs/system: Add vhost-user-input documentation hw/virtio: Move vhost-user-input into virtio folder hw/virtio: derive vhost-user-input from vhost-use

[PATCH v3 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-19 Thread Leo Yan
vhost-user-input is in the input folder. On the other hand, the folder 'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc). This patch moves vhost-user-input into the virtio folder for better code organization. No functionality change. Signed-off-by: Leo Yan --- M

[PATCH v3 4/4] hw/virtio: derive vhost-user-input from vhost-user-base

2023-11-19 Thread Leo Yan
or, remove the duplicate property from vhost-user-input-pci. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-input-pci.c | 3 - hw/virtio/vhost-user-input.c | 114 +-- include/hw/virtio/virtio-input.h | 6 +- 3 files changed, 21 insertions(+), 102 deletions(-) di

Re: [PATCH v4 2/2] xen/arm: Enlarge identity map space to 10TB

2023-11-16 Thread Leo Yan
On Thu, Nov 16, 2023 at 02:21:18PM +, Julien Grall wrote: [...] > I have done the changes and directly committed the series. So no need to > respin. Thanks a lot, Julien! Leo

Re: [PATCH v2 2/4] docs/system: Add vhost-user-input documentation

2023-11-14 Thread Leo Yan
Hi Marc-André, + Mathieu for vhost RNG stuff. On Tue, Nov 14, 2023 at 01:54:50PM +0400, Marc-André Lureau wrote: > Hi > > On Mon, Nov 13, 2023 at 11:04 PM Leo Yan wrote: [...] > > @@ -2233,6 +2233,7 @@ L: virtio...@redhat.com > > virtio-input > > M: Gerd Hoffman

Re: [PATCH v1 0/4] virtio: Refactor vhost input stub

2023-11-13 Thread Leo Yan
Hi Michael, On Mon, Nov 13, 2023 at 01:29:49AM -0500, Michael S. Tsirkin wrote: [...] > > The series is based on "[PATCH v8 0/7] virtio: cleanup > > vhost-user-generic and reduce c&p" which introduces vhost-user-base. > > Based-on: <20231107180752.3458672-1-alex.ben...@linaro.org> > > > That p

[PATCH v2 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-13 Thread Leo Yan
vhost-user-input is in the input folder. On the other hand, the folder 'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc). This patch moves vhost-user-input into the virtio folder for better code organization. No functionality change. Signed-off-by: Leo Yan --- M

[PATCH v2 4/4] hw/virtio: derive vhost-user-input from vhost-user-base

2023-11-13 Thread Leo Yan
or, remove the duplicate property from vhost-user-input-pci. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-input-pci.c | 3 - hw/virtio/vhost-user-input.c | 114 +-- include/hw/virtio/virtio-input.h | 6 +- 3 files changed, 21 insertions(+), 102 deletions(-) di

[PATCH v2 2/4] docs/system: Add vhost-user-input documentation

2023-11-13 Thread Leo Yan
This adds basic documentation for vhost-user-input. Signed-off-by: Leo Yan --- MAINTAINERS | 1 + docs/system/devices/vhost-user-input.rst | 44 docs/system/devices/vhost-user.rst | 2 +- 3 files changed, 46 insertions(+), 1 deletion

[PATCH v2 1/4] hw/virtio: Support set_config() callback in vhost-user-base

2023-11-13 Thread Leo Yan
The Virtio input device invokes set_config() callback for retrieving the event configuration info, but the callback is not supported in vhost-user-base. This patch adds support set_config() callback in vhost-user-base. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-base.c | 17

[PATCH v2 0/4] virtio: Refactor vhost input stub

2023-11-13 Thread Leo Yan
base. Based-on: <20231107180752.3458672-1-alex.ben...@linaro.org> Changes from v1: - Fixed typo in vhost-user-input.rst. - Updated MAINTAINERS for new added input document and changing folder for vhost-user-input.c. Leo Yan (4): hw/virtio: Support set_config() callback in vhost-user-base do

Re: [PATCH v1 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-13 Thread Leo Yan
Hi Manos, On Mon, Nov 13, 2023 at 09:24:09AM +0200, Manos Pitsidianakis wrote: > Hello Leo, > > On Mon, 13 Nov 2023 03:16, Leo Yan wrote: > > vhost-user-input is in the input folder. On the other hand, the folder > > 'hw/virtio' maintains other virtio

Re: [PATCH v1 2/4] docs/system: Add vhost-user-input documentation

2023-11-12 Thread Leo Yan
On Mon, Nov 13, 2023 at 09:16:40AM +0800, Leo Yan wrote: > This adds basic documentation for vhost-user-input. > > Signed-off-by: Leo Yan > --- > docs/system/devices/vhost-user-input.rst | 44 > docs/system/devices/vhost-user.rst | 2 +- >

[PATCH v1 3/4] hw/virtio: Move vhost-user-input into virtio folder

2023-11-12 Thread Leo Yan
vhost-user-input is in the input folder. On the other hand, the folder 'hw/virtio' maintains other virtio stubs (e.g. I2C, RNG, GPIO, etc). This patch moves vhost-user-input into the virtio folder for better code organization. No functionality change. Signed-off-by: Leo Yan ---

[PATCH v1 0/4] virtio: Refactor vhost input stub

2023-11-12 Thread Leo Yan
base. Based-on: <20231107180752.3458672-1-alex.ben...@linaro.org> Leo Yan (4): hw/virtio: Support set_config() callback in vhost-user-base docs/system: Add vhost-user-input documentation hw/virtio: Move vhost-user-input into virtio folder hw/virtio: derive vhost-user-input from vhost-use

[PATCH v1 4/4] hw/virtio: derive vhost-user-input from vhost-user-base

2023-11-12 Thread Leo Yan
or, remove the duplicate property from vhost-user-input-pci. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-input-pci.c | 3 - hw/virtio/vhost-user-input.c | 114 +-- include/hw/virtio/virtio-input.h | 6 +- 3 files changed, 21 insertions(+), 102 deletions(-) di

[PATCH v1 2/4] docs/system: Add vhost-user-input documentation

2023-11-12 Thread Leo Yan
This adds basic documentation for vhost-user-input. Signed-off-by: Leo Yan --- docs/system/devices/vhost-user-input.rst | 44 docs/system/devices/vhost-user.rst | 2 +- 2 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 docs/system/devices/vhost

[PATCH v1 1/4] hw/virtio: Support set_config() callback in vhost-user-base

2023-11-12 Thread Leo Yan
The Virtio input device invokes set_config() callback for retrieving the event configuration info, but the callback is not supported in vhost-user-base. This patch adds support set_config() callback in vhost-user-base. Signed-off-by: Leo Yan --- hw/virtio/vhost-user-base.c | 17

Re: [PATCH v4] xen/arm: Skip memory nodes if not enabled

2023-11-06 Thread Leo Yan
Hi Julien, On Mon, Nov 06, 2023 at 09:52:45AM +, Julien Grall wrote: [...] > > Gentle ping. > > > > I don't see this patch is landed in Xen master or staging branch, should > > anything I need to follow up? > > The tree has been frozen for the past few weeks for any patches that are not >

Re: [PATCH v4 2/2] xen/arm: Enlarge identity map space to 10TB

2023-11-06 Thread Leo Yan
Hi Julien, On Mon, Nov 06, 2023 at 09:39:24AM +, Julien Grall wrote: [...] > > I would like to check if here is anything specific I should follow up > > on. Based on the discussion in this thread, I've come to the following > > conclusions: > > > > - Remove the fixes tags; > > - Add a descr

Re: [PATCH v4 2/2] xen/arm: Enlarge identity map space to 10TB

2023-11-05 Thread Leo Yan
Hi all, On Wed, Oct 18, 2023 at 07:11:11PM +0100, Julien Grall wrote: [...] > > Anyway, both Bertrand and you seems to be against the Fixes tag here. So > > I can compromise with the "This commit fixes...". However, can Bertrand > > or you update process/send-patches.pandoc so it is clear for a

Re: [PATCH v4] xen/arm: Skip memory nodes if not enabled

2023-11-05 Thread Leo Yan
Hi maintainers, On Fri, Oct 13, 2023 at 08:04:42PM +0800, Leo Yan wrote: > Currently, Xen doesn't check the status property of memory/reserved > memory nodes, which may lead to the following issues: > > - If a memory node has a status "disabled" it implies that it

Re: [PATCH] virtio: rng: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX

2023-10-25 Thread Leo Yan
On Thu, Oct 26, 2023 at 01:06:21PM +0800, Leo Yan wrote: > On Wed, Oct 25, 2023 at 11:18:41AM -0600, Mathieu Poirier wrote: > > Since the driver doesn't support interrupts, we must return early when > > index is set to VIRTIO_CONFIG_IRQ_IDX. Basically the same thin

Re: [PATCH] virtio: rng: Check notifier helpers for VIRTIO_CONFIG_IRQ_IDX

2023-10-25 Thread Leo Yan
otifier helpers for > VIRTIO_CONFIG_IRQ_IDX". > > Fixes: 544f0278afca ("virtio: introduce macro VIRTIO_CONFIG_IRQ_IDX") > Signed-off-by: Mathieu Poirier Tested this patch and the vhost-user-i2c device works with it: Tested-by: Leo Yan

Re: [PATCH v4 2/2] xen/arm: Enlarge identity map space to 10TB

2023-10-19 Thread Leo Yan
Hi Julien, On Wed, Oct 18, 2023 at 07:11:11PM +0100, Julien Grall wrote: > On 18/10/2023 11:59, Julien Grall wrote: > > On 17/10/2023 20:58, Stefano Stabellini wrote: [...] > > I don't really see the problem for someone to mistakenly backport this > > patch. In fact, this could potentially save

Re: [PATCH v4 2/2] xen/arm: Enlarge identity map space to 10TB

2023-10-16 Thread Leo Yan
could help to remove it when pick up this patch set. And thanks for review, Michal and Bertrand. Leo > > Reported-by: Alexey Klimov > > Signed-off-by: Leo Yan > > Reviewed-by: Bertrand Marquis > > Cheers > Bertrand

[PATCH v4 2/2] xen/arm: Enlarge identity map space to 10TB

2023-10-13 Thread Leo Yan
module loading within the range of [0x0 .. 0x09ff__]. Fixes: 1c78d76b67 ("xen/arm64: mm: Introduce helpers to prepare/enable/disable") Reported-by: Alexey Klimov Signed-off-by: Leo Yan --- xen/arch/arm/arm64/mm.c | 6 -- xen/arch/arm/include/asm/mmu/la

[PATCH v4 0/2] xen/arm: Enlarge identity map space

2023-10-13 Thread Leo Yan
rtrand); - Added Alexey Klimov tested tag for patch 01 (Alexey). - Corrected the printing log with dynamically calculation ID map size. Leo Yan (2): xen/arm: Add macro XEN_VM_MAPPING xen/arm: Enlarge identity map space to 10TB xen/arch/arm/arm64/mm.c | 6 -- xen/arch/arm

[PATCH v4 1/2] xen/arm: Add macro XEN_VM_MAPPING

2023-10-13 Thread Leo Yan
cked-by: Julien Grall Signed-off-by: Leo Yan --- xen/arch/arm/include/asm/mmu/layout.h | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/xen/arch/arm/include/asm/mmu/layout.h b/xen/arch/arm/include/asm/mmu/layout.h index da6be276ac..2cb2382fbf 100644 --- a/xen/arch/

[PATCH v4] xen/arm: Skip memory nodes if not enabled

2023-10-13 Thread Leo Yan
hecking device node's status in the device_tree_get_meminfo() function, except it checks for memory nodes and reserved memory nodes, it also supports status for static memory and static heap. Suggested-by: Michal Orzel Signed-off-by: Leo Yan Reviewed-by: Michal Orzel --- Changes from v3: - Refined the c

Re: [PATCH v3] xen/arm: Skip memory nodes if not enabled

2023-10-13 Thread Leo Yan
Hi Michal, On Fri, Oct 13, 2023 at 01:00:12PM +0200, Michal Orzel wrote: > Hi Leo, > > On 13/10/2023 12:29, Leo Yan wrote: > > > > > > Currently, the Xen hypervisor doesn't handle the status, the issue can > > be described from two perspectives: the me

Re: [PATCH v2] xen/arm: Skip memory nodes if not enabled

2023-10-13 Thread Leo Yan
Hi Michal, On Fri, Sep 29, 2023 at 10:11:19AM +0200, Michal Orzel wrote: [...] > > +static bool __init device_tree_node_is_available(const void *fdt, int node) > > +{ > > +const char *status = fdt_getprop(fdt, node, "status", NULL); > Please see Julien's comment for v1. To save some jumps,in

[PATCH v3] xen/arm: Skip memory nodes if not enabled

2023-10-13 Thread Leo Yan
nce this patch adds checking device node's status in the device_tree_get_meminfo() function, except it checks for memory nodes and reserved memory nodes, it also supports status for static memory and static heap. Suggested-by: Michal Orzel Signed-off-by: Leo Yan --- Changes from v2: - Added che

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-28 Thread Leo Yan
Hi Michal, Julien, On Wed, Sep 27, 2023 at 02:49:23PM +0200, Michal Orzel wrote: [...] > Either way is fine. The advantage of placing the check in boot_fdt_info() is > that we can have a single check instead of duplicated and we do the check > before > the "first" use which happens to be the ba

[PATCH v2] xen/arm: Skip memory nodes if not enabled

2023-09-28 Thread Leo Yan
nce this patch adds checking device node's status in the device_tree_get_meminfo() function, except it checks for memory nodes and reserved memory nodes, it also supports status for static memory and static heap. Suggested-by: Michal Orzel Signed-off-by: Leo Yan --- Changes from v1: - Renamed f

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-26 Thread Leo Yan
Hi Luca, On Tue, Sep 26, 2023 at 10:10:57AM +, Luca Fancellu wrote: [...] > >> I might be wrong, but reading the specifications seems that “status” is > >> not a property > >> of the child nodes of /reserved-memory, so I’m not sure Xen should do > >> something about it. > > > > Please take

Re: [PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-26 Thread Leo Yan
lot for good summary! In theory, a good practice should use two separate patches to fix two issues respectively. Given we can use simple change to fix these two issues in one patch, I will amend the patch's commit log with your summary for better recording these issues. > > Signed-off

Re: RFC: arm64: Handling reserved memory nodes

2023-09-26 Thread Leo Yan
Hi Julien, On Wed, Sep 20, 2023 at 11:36:24AM +0100, Julien Grall wrote: [...] > > Host dt: > > memory@4000 { > > reg = <0x00 0x4000 0x01 0x00>; > > device_type = "memory"; > > }; > > > > reserved-memory { > > #size-cells = <0x02>; > > #address-cells = <0x02>; > >

[PATCH] xen/arm: Skip memory nodes if not enabled

2023-09-25 Thread Leo Yan
nerate the memory nodes from the memory lists sent to the kernel and the kernel cannot use the disabled memory nodes any longer. Signed-off-by: Leo Yan --- xen/arch/arm/bootfdt.c | 16 1 file changed, 16 insertions(+) diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c

Re: RFC: arm64: Handling reserved memory nodes

2023-09-20 Thread Leo Yan
On Wed, Sep 20, 2023 at 11:36:24AM +0100, Julien Grall wrote: [...] > Can you confirm the version of Xen you are using? For this question, I use a very new Xen repo with staging branch which I git pulled at last week. Thanks, Leo

Re: RFC: arm64: Handling reserved memory nodes

2023-09-20 Thread Leo Yan
On Wed, Sep 20, 2023 at 11:36:24AM +0100, Julien Grall wrote: [...] > > > Could you confirm the Xen does write reserved memory nodes? Or Xen > > > converts the reserved memory nodes to normal memory nodes as I > > > describe above :) > > > > Xen passes the /reserved-memory node unchanged from h

Re: RFC: arm64: Handling reserved memory nodes

2023-09-20 Thread Leo Yan
Hi Julien, On Mon, Sep 18, 2023 at 08:26:21PM +0100, Julien Grall wrote: [...] > ... from my understanding reserved-memory are just normal memory that are > set aside for a specific purpose. So Xen has to create a 'memory' node *and* > a 'reserved-memory' region. To be clear, Xen passes the 're

Re: RFC: arm64: Handling reserved memory nodes

2023-09-16 Thread Leo Yan
Hi Julien, On Thu, Sep 14, 2023 at 10:37:05AM +0100, Julien Grall wrote: [...] > > This error is caused by kernel using an invalid memory frame number > > 0x1a02dc, we can convert it to the address: > > > >0x1a02dc << PAGE_SHIFT = 0x1_a02d_c000 > > This error is coming from get_page_from_g

RFC: arm64: Handling reserved memory nodes

2023-09-14 Thread Leo Yan
Hi all, I'd like to discuss for how to handle the reserved memory nodes in DT binding on Xen / Arm64. Note, now I am using DTB when boot Xen but not UEFI/ACPI (ACPI is disabled in this case). ## Failure I ported Xen on a platform, after the kernel booting, the Xen hypervisor reports error: (

[PATCH v3 2/2] xen/arm: Enlarge identity map space to 127TB

2023-09-13 Thread Leo Yan
(refer to pfn_pdx_hole_setup() for Xen removing the biggest gap from memory regions). Thus, 2TB of memory support remains sufficient for most use cases. Fixes: 1c78d76b67 ("xen/arm64: mm: Introduce helpers to prepare/enable/disable") Reported-by: Alexey Klimov Signed-off-by: Leo Yan ---

[PATCH v3 1/2] xen/arm: Add macro XEN_VM_MAPPING

2023-09-13 Thread Leo Yan
Xen maps the virtual memory space starting from L0 slot 4, so it's open coded for macros with the offset '4'. For more readable, add a new macro XEN_VM_MAPPING which defines the start slot for Xen virtual memory mapping, and all virtual memory regions are defined based on it. Sig

[PATCH v3 0/2] xen/arm: Enlarge identity map space

2023-09-13 Thread Leo Yan
ding style (Julien Grall). - Added platform's detail in the patch 02 commit log (Julien Grall). Changes from v1: - Rebased on staging branch (Bertrand); - Added Alexey Klimov tested tag for patch 01 (Alexey). - Corrected the printing log with dynamically calculation ID map size. Leo Yan (2): xen

Re: [PATCH RESEND v2 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-09-11 Thread Leo Yan
Hi Henry, On Tue, Sep 12, 2023 at 03:01:30AM +, Henry Wang wrote: [...] > At Arm we also test Xen on AVA in our CI, but our setup is based on Yocto > meta-adlink-ampere layer [1]. Thanks for sharing the info. Yes, we (Linaro) also work with Yocto based on EWAOL [1] or TRS [2]. > >> Also,

Re: [PATCH RESEND v2 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-09-11 Thread Leo Yan
Hi Julien, On Mon, Sep 11, 2023 at 04:13:27PM +0100, Julien Grall wrote: > Hi Leo, > > I know you said you will respin the series. I'd like to leave some comments > to avoid having another round afterwards. Thanks! > On 09/09/2023 09:34, Leo Yan wrote: > > On some pla

Re: [PATCH RESEND v2 0/2] xen/arm: Enlarge identity map space

2023-09-09 Thread Leo Yan
On Sat, Sep 09, 2023 at 04:34:08PM +0800, Leo Yan wrote: > The latest Xen fails to boot on ADLink AVA platform. Alexey Klimov root > caused the issue is related with the commit 1c78d76b67 ("xen/arm64: mm: > Introduce helpers to prepare/enable/disable"). > > This is becau

[PATCH RESEND v2 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-09-09 Thread Leo Yan
fined macros, it enlarges identity map space to 127TiB, which can support the memory space [0x0 .. 0x7eff__] so has flexibility for various platforms. Fixes: 1c78d76b67 ("xen/arm64: mm: Introduce helpers to prepare/enable/disable") Reported-by: Alexey Klimov Signed-off-by: Leo Yan

[PATCH RESEND v2 1/2] xen/arm: Add macro XEN_VM_MAPPING

2023-09-09 Thread Leo Yan
Xen maps the virtual memory space starting from L0 slot 4, so it's open coded for macros with the offset '4'. For more readable, add a new macro XEN_VM_MAPPING which defines the start slot for Xen virtual memory mapping, and all virtual memory regions are defined based on it. Sig

[PATCH RESEND v2 0/2] xen/arm: Enlarge identity map space

2023-09-09 Thread Leo Yan
series is to enlarge identity map space to 127 TiB and tested on Telechips Dolphin5 platform. Changes from v1: - Rebased on staging branch (Bertrand); - Added Alexey Klimov tested tag for patch 01 (Alexey). - Corrected the printing log with dynamically calculation ID map size. Leo Yan (2): xe

[PATCH v2 1/2] xen/arm: Add macro XEN_VM_MAPPING

2023-09-09 Thread Leo Yan
Xen maps the virtual memory space starting from L0 slot 4, so it's open coded for macros with the offset '4'. For more readable, add a new macro XEN_VM_MAPPING which defines the start slot for Xen virtual memory mapping, and all virtual memory regions are defined based on it. Sig

[PATCH v2 0/2] xen/arm: Enlarge identity map space

2023-09-09 Thread Leo Yan
series is to enlarge identity map space to 127 TiB and tested on Telechips Dolphin5 platform. Changes from v1: - Rebased on staging branch (Bertrand); - Added Alexey Klimov tested tag for patch 01 (Alexey). - Corrected the printing log with dynamically calculation ID map size. Leo Yan (2): xe

[PATCH v2 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-09-09 Thread Leo Yan
fined macros, it enlarges identity map space to 127TiB, which can support the memory space [0x0 .. 0x7eff__] so has flexibility for various platforms. Fixes: 1c78d76b67 ("xen/arm64: mm: Introduce helpers to prepare/enable/disable") Reported-by: Alexey Klimov Signed-off-by: Leo Yan

Re: [PATCH v1 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-09-04 Thread Leo Yan
Hi Bertrand, On Mon, Sep 04, 2023 at 01:55:12PM +, Bertrand Marquis wrote: > Hi Leo, > > > On 31 Aug 2023, at 13:01, Leo Yan wrote: > > > > On some platforms, the memory regions could be: > > > > (XEN) MODULE[0]: 0807f6df -

[PATCH v1 2/2] xen/arm: Enlarge identity map space to 127TiB

2023-08-31 Thread Leo Yan
: 1c78d76b67 ("xen/arm64: mm: Introduce helpers to prepare/enable/disable") Reported-by: Alexey Klimov Signed-off-by: Leo Yan --- xen/arch/arm/include/asm/config.h | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/xen/arch/arm/include/asm/config.h b/xen/arch/a

[PATCH v1 0/2] xen/arm: Enlarge identity map space

2023-08-31 Thread Leo Yan
r into the high memory address and caused booting failure. Leo Yan (2): xen/arm: Add macro XEN_VM_MAPPING xen/arm: Enlarge identity map space to 127TiB xen/arch/arm/include/asm/config.h | 18 -- 1 file changed, 8 insertions(+), 10 deletions(-) -- 2.39.2

[PATCH v1 1/2] xen/arm: Add macro XEN_VM_MAPPING

2023-08-31 Thread Leo Yan
Xen maps the virtual memory space starting from L0 slot 4, so it's open coded for macros with the offset '4'. For more readable, add a new macro XEN_VM_MAPPING which defines the start slot for Xen virtual memory mapping, and all virtual memory regions are defined based on it. Sig

Re: [PATCH v1] tools/hotplug: systemd: Make dependency on Xen device nodes

2023-08-25 Thread Leo Yan
On Fri, Aug 25, 2023 at 09:37:58AM +0200, Erik Schilling wrote: [...] > > > > diff --git a/tools/hotplug/Linux/systemd/xenstored.service.in > > > > b/tools/hotplug/Linux/systemd/xenstored.service.in > > > > index 261077dc92..6e48cdb0e7 100644 > > > > --- a/tools/hotplug/Linux/systemd/xenstored.s

Re: [PATCH v1] tools/hotplug: systemd: Make dependency on Xen device nodes

2023-08-24 Thread Leo Yan
On Fri, Aug 25, 2023 at 07:02:33AM +0200, Erik Schilling wrote: > On Fri Aug 25, 2023 at 5:36 AM CEST, Leo Yan wrote: > > When system booting up, the kernel module xen_gntdev.ko is loaded and > > the device node '/dev/xen/gntdev' is created; later the xenstored > &

[PATCH v1] tools/hotplug: systemd: Make dependency on Xen device nodes

2023-08-24 Thread Leo Yan
etween udev and systemd for the device node. There have an extra change in the udev rules for tagging 'systemd' for Xen device nodes, which notifies device node creating to systemd; besides udev change, this patch adds dependency in systemd service for waiting the device node. Signed-o

[PATCH] docs: Correct name for xen-command-line.pandoc

2023-07-24 Thread Leo Yan
en-command-line.pandoc. Fixes: d661611d08 ("docs/markdown: Switch to using pandoc, and fix underscore escaping") Signed-off-by: Leo Yan --- docs/features/sched_credit2.pandoc | 2 +- docs/misc/arm/big.LITTLE.txt | 2 +- xen/common/Kconfig | 2 +- 3 files changed, 3 insertio

Re: [PATCH v1 2/2] xen_arm: Initialize RAM and add hi/low memory regions

2023-07-03 Thread Leo Yan
Hi Vikram, On Thu, Jun 29, 2023 at 10:43:10AM -0700, Oleksandr Tyshchenko wrote: [...] > void arch_handle_ioreq(XenIOState *state, ioreq_t *req) > { > hw_error("Invalid ioreq type 0x%x\n", req->type); > @@ -135,6 +170,14 @@ static void xen_arm_init(MachineState *machine) > > xam->s

Re: [PATCH 01/17] perf: get rid of unused import

2023-06-13 Thread Leo Yan
sts before making it available > via perf-tools-next, when I should not make any further changes. Understand now. Here is my review tag: Reviewed-by: Leo Yan

Re: [PATCH 01/17] perf: get rid of unused import

2023-06-13 Thread Leo Yan
On Tue, Jun 13, 2023 at 04:54:08PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Jun 13, 2023 at 10:11:29PM +0530, Athira Rajeev escreveu: > > From: Sourabh Jain > > > > Script doesn't use sys library, so remove it. > > Please Cc the persons working on that file, I added Leo to the CC list >

Re: [PATCH v1 0/2] arm64: Fix building failure for Xen target

2023-05-17 Thread Leo Yan
On Thu, May 04, 2023 at 03:54:57PM +0800, Leo Yan wrote: > This patch series is for building Xen target with Clang. > > The first patch is to fix building failure for Xen target, the second > patch is to add info for a linkage known issue when use Clang as > compiler. Gentle pin

[PATCH v1 2/2] doc: Add info for building Xen target with Clang

2023-05-04 Thread Leo Yan
When build Xen target with Clang, the linker reports failure. This patch adds the related info in the documentation as a known issue and gives details for how to dismiss the building failure with Clang. Signed-off-by: Leo Yan --- doc/build/clang.rst | 36 1

[PATCH v1 1/2] arm64: Remove duplicated symbols

2023-05-04 Thread Leo Yan
rom boot0-linux-kernel-header.h. Signed-off-by: Leo Yan --- arch/arm/include/asm/boot0-linux-kernel-header.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/include/asm/boot0-linux-kernel-header.h b/arch/arm/include/asm/boot0-linux-kernel-header.h index c6cd76f32a..c930fea5fd 10064

[PATCH v1 0/2] arm64: Fix building failure for Xen target

2023-05-04 Thread Leo Yan
This patch series is for building Xen target with Clang. The first patch is to fix building failure for Xen target, the second patch is to add info for a linkage known issue when use Clang as compiler. Leo Yan (2): arm64: Remove duplicated symbols doc: Add info for building Xen target with

Re: [PATCH] verifiers: Don't return error for deferred image

2023-01-05 Thread Leo Yan
Hi Boyang, On Fri, Dec 30, 2022 at 08:56:59PM +0800, Zhang Boyang wrote: [...] > > > I'd like to ask what kind of image you are trying to boot/execute? If it > > > is > > > an EFI application, I think you can "chainloader" it and forget U-boot (if > > > U-boot have no verification in it self).

Re: [PATCH] verifiers: Don't return error for deferred image

2022-12-26 Thread Leo Yan
Hi Boyang, On Thu, Dec 22, 2022 at 10:37:01PM +0800, Zhang Boyang wrote: [...] > > > On 2022/12/22 19:14, Leo Yan wrote: > > > > When boot from menu and the flag GRUB_VERIFY_FLAGS_DEFER_AUTH is set, > > > > grub returns error: > > > > > > >

Re: [PATCH] verifiers: Don't return error for deferred image

2022-12-22 Thread Leo Yan
Hi Boyang, On Thu, Dec 22, 2022 at 07:25:13PM +0800, Zhang Boyang wrote: > Hi, > > On 2022/12/22 19:14, Leo Yan wrote: > > When boot from menu and the flag GRUB_VERIFY_FLAGS_DEFER_AUTH is set, > > grub returns error: > > > > Booting a command list > >

[PATCH] verifiers: Don't return error for deferred image

2022-12-22 Thread Leo Yan
the file handle and pass down to later firmware (e.g. U-Boot, etc) for authentication. For this purpose, rather than returning error, this patch prints log and returns file handler. Signed-off-by: Leo Yan --- grub-core/kern/verifiers.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions

Re: [PATCH v1 3/3] perf arm64: Support virtual CPU ID for kvm-stat

2022-11-08 Thread Leo Yan
On Mon, Nov 07, 2022 at 03:39:07PM +, Marc Zyngier wrote: [...] > > > Please educate me: how useful is it to filter on a vcpu number across > > > all VMs? What sense does it even make? > > > > Now "perf kvm" tool is not sophisticated since it doesn't capture VMID > > and virtual CPU ID toget

Re: [PATCH v1 3/3] perf arm64: Support virtual CPU ID for kvm-stat

2022-11-07 Thread Leo Yan
On Sat, Nov 05, 2022 at 01:28:40PM +, Marc Zyngier wrote: [...] > > Before: > > > > # perf kvm stat report --vcpu 27 > > > > Analyze events for all VMs, VCPU 27: > > > >VM-EXITSamples Samples% Time%Min TimeMax > > Time Avg time > > > > Total

[PATCH v1 3/3] perf arm64: Support virtual CPU ID for kvm-stat

2022-11-05 Thread Leo Yan
Total events handled time:3068.28us. Signed-off-by: Leo Yan --- tools/perf/arch/arm64/util/kvm-stat.c | 54 --- 1 file changed, 49 insertions(+), 5 deletions(-) diff --git a/tools/perf/arch/arm64/util/kvm-stat.c b/tools/perf/arch/arm64/util/kvm-stat.c index 73d18e0ed6f6..

[PATCH v1 2/3] KVM: arm64: Add trace events with field 'vcpu_id'

2022-11-05 Thread Leo Yan
vents kvm_entry_v2 and kvm_exit_v2 with a new field 'vcpu_id'. To support both the old and new events, we use the tracepoint callback to check if any event is enabled or not, if it's enabled then the callback will invoke the corresponding trace event. Signed-off-by: Leo Yan --- ar

[PATCH v1 1/3] KVM: arm64: Dynamically register callback for tracepoints

2022-11-05 Thread Leo Yan
This commit doesn't change any functionality but only refactoring. It registers callbacks for tracepoints dynamically, with this way, the existed trace events (in this case kvm_entry and kvm_exit) are kept. This is a preparation to add new trace events in later patch. Signed-off-by: Le

[PATCH v1 0/3] KVM: arm64: Support tracing virtual CPU ID

2022-11-05 Thread Leo Yan
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/kernel/sched/core.c?id=a056a5bed7fa67706574b00cf1122c38596b2be1 Leo Yan (3): KVM: arm64: Dynamically register callback for tracepoints KVM: arm64: Add trace events with field 'vcpu_id' perf arm64: Support virt

Re: Issue: Networking performance in Xen VM on Arm64

2022-10-28 Thread Leo Yan
On Fri, Oct 28, 2022 at 05:54:05PM +0800, Leo Yan wrote: [...] > If map to the code, I think the function xennet_start_xmit() in Xen > frontend driver is critical for the sending interval in domU. I can > see several things cost time when sending a packet: > > - Xen frontend

Re: Issue: Networking performance in Xen VM on Arm64

2022-10-28 Thread Leo Yan
Hi Stefano, On Tue, Oct 25, 2022 at 04:58:16PM -0700, Stefano Stabellini wrote: > On Mon, 24 Oct 2022, Leo Yan wrote: > > > If you are really running with the NULL scheduler, then I would > > > investigate why the vCPU has is_running == 0 because it should not > > >

Re: Issue: Networking performance in Xen VM on Arm64

2022-10-24 Thread Leo Yan
On Fri, Oct 21, 2022 at 02:14:04PM -0700, Stefano Stabellini wrote: [...] > > > # domU side > > > xen/arch/arm/vgic-v2.c:vgic_v2_to_sgi > > > xen/arch/arm/vgic.c:vgic_to_sgi > > > xen/arch/arm/vgic.c:vgic_inject_irq > > > xen/arch/arm/vgic.c:vcpu_kick > > > xen/arch/arm/gic-v2.c:gicv2_send_SGI >

Re: Issue: Networking performance in Xen VM on Arm64

2022-10-21 Thread Leo Yan
Hi Stefano and all, On Mon, Oct 17, 2022 at 04:50:05PM -0700, Stefano Stabellini wrote: [...] > > We can see DomU sends notification with timestamp (raw counter) is > > 4989078592 and Dom0 receives the interrupt with timestamp 4989092169. > > Since Dom0 and DomU use the same time counter and the

Re: Issue: Networking performance in Xen VM on Arm64

2022-10-18 Thread Leo Yan
On Mon, Oct 17, 2022 at 04:50:05PM -0700, Stefano Stabellini wrote: [...] > > Which means it takes 543us to let Dom0 to receive the notification. > > You could see DomU runs in CPU3 and Dom0 runs on CPU13, there should > > not have contention for CPU resources. Seems to me, it's likely Xen > > h

Re: Issue: Networking performance in Xen VM on Arm64

2022-10-17 Thread Leo Yan
Hi Stefano, Sorry for late response. Please see below comments. On Tue, Oct 11, 2022 at 02:47:00PM -0700, Stefano Stabellini wrote: > On Tue, 11 Oct 2022, Leo Yan wrote: > > > > The second question is how to mitigate the long latency when send data > > > > from DomU.

Re: Issue: Networking performance in Xen VM on Arm64

2022-10-11 Thread Leo Yan
Hi Stefano, On Mon, Oct 10, 2022 at 04:50:46PM -0700, Stefano Stabellini wrote: > +Xen/Linux maintainers Thanks for reviewing. [...] > > Throughput result: > > > > Profile netperf (Mbits/sec)ddsperf (Mbits/sec) > > Xen-Dom0939.41 > 620 > > Xen-DomU

Issue: Networking performance in Xen VM on Arm64

2022-10-10 Thread Leo Yan
Hi there, I tested the networking performance on my Arm64 platform in Xen virtual machine, below I will try to give out summary for testing result and share some analysis, at the end I want to check a bit from the community and get suggestion before I can proceed. First of all, if you want to kno

Re: [PATCH] xen: Add macro for version number string

2022-09-07 Thread Leo Yan
On Wed, Sep 07, 2022 at 02:34:25PM +0200, Jan Beulich wrote: > On 07.09.2022 14:20, Bertrand Marquis wrote: > > Hi Leo, > > > > Thanks a lot for the quick handling here. > > > >> On 7 Sep 2022, at 13:04, Leo Yan wrote: > >> > >> O

  1   2   3   4   5   6   7   8   9   10   >