ldionne wrote:
Amazing to see this paying off!
https://github.com/llvm/llvm-project/pull/111581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@petrhosek Where is the cache generating that build?
The fix for this is:
```
# On embedded platforms that don't support shared library targets, CMake
implicitly changes shared
# library targets to be static library targets. This results in duplicate
definitions of the static
#
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/80007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
I had to fix how we were excluding targets from `EXCLUDE_FROM_ALL`, which
didn't work as intended and was breaking the MinGW CI. I'll merge this if the
CI passes.
https://github.com/llvm/llvm-project/pull/80007
___
cfe-commits mailing
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/80007
>From 447159a21d73d6b4b5c6f6c4710231f01e0af4fc Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 12 Oct 2022 18:06:32 -0400
Subject: [PATCH] [runtimes] Always define cxx_shared, cxx_static & other
targets
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/111007
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/111007
This variable isn't used anymore in libc++'s build and hasn't been for a few
years, so this is likely a remnant of the past.
>From 7b29252b9150e0b4d2939afe1c6b33a6e9d52a0b Mon Sep 17 00:00:00 2001
From: Louis D
ldionne wrote:
@petrhosek @vitalybuka Gentle ping.
If the CI is green, I will land this next week unless someone objects to it. I
don't want to purposefully break anyone's build, but I also don't want to hold
off on this change forever if there's nothing actionable.
Last time in https://revie
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/80007
>From 33a4c2504236f47ef244d808bebc9a01b916b7c3 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 12 Oct 2022 18:06:32 -0400
Subject: [PATCH] [runtimes] Always define cxx_shared, cxx_static & other
targets
ldionne wrote:
I'm not a codeowner for Clang, but in this case I think the change is simple
enough that this is good to go.
https://github.com/llvm/llvm-project/pull/110955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/110955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
I think support for wasm mandates a short RFC, like most projects to support
new platforms that require non-trivial changes. There's not a huge amount of
changes in this patch, but it's also unclear to me that this is sufficient
ldionne wrote:
> > This can be merged by whoever sees the CI green first.
>
> There are 6 failing build so far but all due to the "runner received a
> shutdown signal", not actually a build/test failure? Should I do another
> rebase to trigger a rerun? Or we can just land it now?
Merged since
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/110777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
This can be merged by whoever sees the CI green first.
https://github.com/llvm/llvm-project/pull/110777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
I rebased onto `main` to trigger the CI again.
https://github.com/llvm/llvm-project/pull/110777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/110777
>From cb81337ae2828f330424b3c45a4161bc1e88ae18 Mon Sep 17 00:00:00 2001
From: Haowei Wu
Date: Tue, 1 Oct 2024 18:16:44 -0700
Subject: [PATCH] [libunwind] Fix libunwind library path for runtime test
This patch f
https://github.com/ldionne approved this pull request.
LGTM assuming the CI is green.
https://github.com/llvm/llvm-project/pull/110777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/98712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,25 @@
+
ldionne wrote:
Ack. Just be aware that so long as there's no CI job, the platform is not
officially supported so it may happen that we'll make changes that will make
your life harder. We won't do it on purpose, of course, but it could happen
ldionne wrote:
Thanks for the analysis. Per-target runtime dir strikes again! That setting
keeps on creating issues (by no fault of its own) because it's not the default.
Can we do something like this instead, then?
```
config.substitutions.append(('%{lib}',
'@LIBUNWIND_TESTING_INSTALL_PREFIX
@@ -38,9 +38,13 @@ check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG)
# required during compilation (which has the -nostdlib++ or -nodefaultlibs).
libc is
# required for the link to go through. We remove sanitizers from the
# configuration checks to avoid spurious link
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/109984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109984
>From 8b98482170459226ddfe7ba77f6b88f20d27d319 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 25 Sep 2024 09:55:53 -0400
Subject: [PATCH] [runtimes] Run backdeployment CI on Github hosted runners
This r
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/110171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -14,16 +14,30 @@
#include <__type_traits/decay.h>
#include <__type_traits/is_same.h>
#include <__type_traits/remove_cvref.h>
+#include <__type_traits/type_identity.h>
#include <__type_traits/void_t.h>
#include <__utility/declval.h>
+#include <__utility/empty.h>
#if !def
@@ -1,2125 +1,2235 @@
-// Main C++ standard library interfaces
-module std_algorithm [system] {
- header "algorithm"
- export *
-}
-module std_any [system] {
- header "any"
- export *
-}
-module std_array [system] {
- header "array"
- export *
-}
-module std_atomic [system]
@@ -14,16 +14,30 @@
#include <__type_traits/decay.h>
#include <__type_traits/is_same.h>
#include <__type_traits/remove_cvref.h>
+#include <__type_traits/type_identity.h>
#include <__type_traits/void_t.h>
#include <__utility/declval.h>
+#include <__utility/empty.h>
#if !def
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/110171
>From f6c1590f9513ecab8fe0ea6db8b5367513ce95a1 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 26 Sep 2024 17:09:32 -0400
Subject: [PATCH] [libc++abi][libunwind] Run c++abi and unwind tests against a
fak
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/110171
>From f6c1590f9513ecab8fe0ea6db8b5367513ce95a1 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 26 Sep 2024 17:09:32 -0400
Subject: [PATCH 1/2] [libc++abi][libunwind] Run c++abi and unwind tests
against a
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/110178
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/110175
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/110178
This patch introduces the LIBUNWIND_LIBRARY_VERSION setting to control the
dylib version of libunwind. This allows expressing the dylib version in CMake
instead of adding custom compiler flags.
As a drive-by,
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/110175
None
>From 77b8da53c769106ac75e818c4ea8a37b6e927a4f Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Thu, 26 Sep 2024 17:48:24 -0400
Subject: [PATCH] [libunwind][CMake] Remove LIBUNWIND_BUILD_32_BITS which has
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/110171
This is what we started doing in libc++ and it straightens up a lot of things
that only happened to work before, notably the presence of relative rpaths in
dylibs when running from the build tree.
This unlocks
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109984
>From 6567a45fca93b81da2ccb0d596aa0be84666eab1 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 25 Sep 2024 09:55:53 -0400
Subject: [PATCH 1/4] [runtimes] Run backdeployment CI on Github hosted runners
Th
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/109984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109984
>From 6567a45fca93b81da2ccb0d596aa0be84666eab1 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 25 Sep 2024 09:55:53 -0400
Subject: [PATCH 1/3] [runtimes] Run backdeployment CI on Github hosted runners
Th
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109984
>From 6567a45fca93b81da2ccb0d596aa0be84666eab1 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 25 Sep 2024 09:55:53 -0400
Subject: [PATCH 1/2] [runtimes] Run backdeployment CI on Github hosted runners
Th
https://github.com/ldionne ready_for_review
https://github.com/llvm/llvm-project/pull/109984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/109984
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109984
>From 6567a45fca93b81da2ccb0d596aa0be84666eab1 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 25 Sep 2024 09:55:53 -0400
Subject: [PATCH] [runtimes] Run backdeployment CI on Github hosted runners
This r
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109984
>From b03b189897358070290549af67bfd3705ec3c203 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 25 Sep 2024 09:55:53 -0400
Subject: [PATCH 1/4] [runtimes] Run backdeployment CI on Github hosted runners
Th
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109984
>From b03b189897358070290549af67bfd3705ec3c203 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 25 Sep 2024 09:55:53 -0400
Subject: [PATCH 1/3] [runtimes] Run backdeployment CI on Github hosted runners
Th
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/109984
>From b03b189897358070290549af67bfd3705ec3c203 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 25 Sep 2024 09:55:53 -0400
Subject: [PATCH 1/2] [runtimes] Run backdeployment CI on Github hosted runners
Th
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/109984
This removes the need for macOS nodes in Buildkite. It also moves to the proper
way of testing backdeployment, which is to actually run on the target OS
itself, instead of using packaged dylibs from previous OS
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/107905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
I don't think this is very controversial so I'll land now that the CI has run.
https://github.com/llvm/llvm-project/pull/107905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
@@ -38,9 +38,13 @@ check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG)
# required during compilation (which has the -nostdlib++ or -nodefaultlibs).
libc is
# required for the link to go through. We remove sanitizers from the
# configuration checks to avoid spurious link
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/107905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne created
https://github.com/llvm/llvm-project/pull/107905
That missing space was causing the whole sentence to be rendered incorrectly in
the resulting HTML.
>From df520b4cb99001b81ab00fa530718a2307dafb6f Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Mon, 9 Sep 2
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
ldionne wrote:
Do you really need this setting here? Can't you instead set
`CMAKE_CXX_COMPILER_TARGET`?
https://github.com/llvm/llvm-project/pull/98712
__
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
+set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR OFF CACHE BOOL "")
+set(LLVM_ENABLE_RUNTIMES libcxx;libcxxabi;libunwind;compiler-rt CACHE STRING
"")
+set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOO
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
+set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR OFF CACHE BOOL "")
+set(LLVM_ENABLE_RUNTIMES libcxx;libcxxabi;libunwind;compiler-rt CACHE STRING
"")
+set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOO
@@ -0,0 +1,25 @@
+
+set(LLVM_DEFAULT_TARGET_TRIPLE hexagon-unknown-linux-musl CACHE STRING "")
+set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR OFF CACHE BOOL "")
+set(LLVM_ENABLE_RUNTIMES libcxx;libcxxabi;libunwind;compiler-rt CACHE STRING
"")
+set(LIBCXX_INCLUDE_BENCHMARKS OFF CACHE BOO
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/98712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne requested changes to this pull request.
Sorry for the delay. I have some questions and comments but this looks
reasonable.
https://github.com/llvm/llvm-project/pull/98712
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
https://github.com/ldionne approved this pull request.
LGTM. I don't own the driver, but this is how we want libc++ to be used (as
generically as possible).
https://github.com/llvm/llvm-project/pull/101259
___
cfe-commits mailing list
cfe-commits@list
ldionne wrote:
> > Gentle ping @petrhosek
>
> I'd like to go ahead and merge this PR but I still need someone to approve
> this change.
Sorry, somehow I thought this was waiting on a reply from you.
https://github.com/llvm/llvm-project/pull/101259
_
@@ -257,7 +257,7 @@ General purpose options
A semicolon list of arguments to pass when running the libc++ benchmarks
using the
``check-cxx-benchmarks`` rule. By default we run the benchmarks for a very
short amount of time,
- since the primary use of ``check-cxx-benchma
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github:
List[PaperInfo]) -> List[Tuple]:
results.append(gh.for_printing())
continue
elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with differen
https://github.com/ldionne requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/105990
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -284,7 +284,7 @@ def sync_csv(rows: List[Tuple], from_github:
List[PaperInfo]) -> List[Tuple]:
results.append(gh.for_printing())
continue
elif paper.status != gh.status:
-print(f"We found a CSV row and a Github issue with differen
ldionne wrote:
Gentle ping
https://github.com/llvm/llvm-project/pull/101688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,431 @@
+// RUN: %clang_cc1 -std=c++20 -Wno-unused %s -verify=expected,cxx20
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify=expected,sincecxx23
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++26 -Wno-unused %s -verify=expected,sincecxx2
ldionne wrote:
The libc++ part: https://github.com/llvm/llvm-project/pull/105847
https://github.com/llvm/llvm-project/pull/100393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/91895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,431 @@
+// RUN: %clang_cc1 -std=c++20 -Wno-unused %s -verify=expected,cxx20
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify=expected,sincecxx23
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++26 -Wno-unused %s -verify=expected,sincecxx2
https://github.com/ldionne commented:
I did a very cursory review and this seems good to me, the tests seem to cover
what the paper was intending to provide.
https://github.com/llvm/llvm-project/pull/91895
___
cfe-commits mailing list
cfe-commits@list
ldionne wrote:
@hokein @vvereschaka Yeah, I get the same conclusion as you. I think that's a
false positive, this is just moving the content of an engaged `std::optional`.
https://github.com/llvm/llvm-project/pull/104906
___
cfe-commits mailing list
c
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/105616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Thanks for the writeup, this is useful. This leaves me wondering if
`arm64-apple-darwin22.4.0` might be the right target triple then, but the
effective triple would be e.g. `arm64-apple-macos12.0.0`?
https://github.com/llvm/llvm-project/pull/104037
__
ldionne wrote:
Ping @petrhosek @vitalybuka. I would like to merge this patch this week. CI
seems to be happy, but your CI may be doing something different since IIRC this
patch upset your bots the last time I tried landing it. Can you take it for a
round to see if that's still the case?
https
@@ -0,0 +1,32 @@
+# This testing configuration handles running the test suite against LLVM's
libc++
+# using a static library.
+#
+# This configuration uses a 'just-built' Clang runtime builtins library to
link with
+# the tests instead of the target system library.
+#
+# Provid
https://github.com/ldionne updated
https://github.com/llvm/llvm-project/pull/80007
>From ad17e287c4ceed5d6148d52cbb0ed31fd0d04e99 Mon Sep 17 00:00:00 2001
From: Louis Dionne
Date: Wed, 12 Oct 2022 18:06:32 -0400
Subject: [PATCH] [runtimes] Always define cxx_shared, cxx_static & other
targets
ldionne wrote:
@mstorsjo I think you put the finger on something I don't really understand at
the moment. What is the relationship between `armv7` and `thumbv7` as a target
triple? Is there any documentation on what an "effective triple" is in
comparison to a "non-effective triple"?
Separatel
@@ -0,0 +1,35 @@
+// Test the output of -print-target-triple on Darwin.
+
ldionne wrote:
```suggestion
// Test the output of -print-target-triple on Darwin.
// See https://github.com/llvm/llvm-project/issues/61762
```
https://github.com/llvm/llvm-project/pull/1
@@ -0,0 +1,35 @@
+// Test the output of -print-target-triple on Darwin.
+
+//
+// All platforms
+//
+
+// RUN: %clang -print-target-triple \
+// RUN: --target=x86_64-apple-macos -mmacos-version-min=15 \
+// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \
+// RUN: | File
https://github.com/ldionne approved this pull request.
This seems really nice! Again, I don't own the driver but IMO this seems fine
to me.
https://github.com/llvm/llvm-project/pull/104037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/104037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/104037
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,39 @@
+#===
ldionne wrote:
For now, can't you include `libcxx/cmake/Modules/HandleLibC.cmake` instead?
https://github.com/llvm/llvm-project/pull/101688
___
ldionne wrote:
> @ldionne I'm starting to think that we should have a generic module in
> https://github.com/llvm/llvm-project/tree/main/cmake/Modules that would be
> controlled by `LLVM_USE_LIBC` and define `libc-headers`, `libc-static` and
> `libc-shared`. That way we could avoid duplicating
@@ -0,0 +1,34 @@
+// RUN: %clang_cc1 %s -verify
+
+#if !__has_cpp_attribute(clang::diagnose_specializations)
+# error
+#endif
+
+struct [[clang::diagnose_specializations]] S {}; // expected-warning
{{'diagnose_specializations' attribute only applies to class templates}}
+
+templ
@@ -1511,6 +1511,46 @@ Attributes (N2335)
C2
``#embed`` (N3017)
C23 C89, C++
===
@@ -3058,6 +3058,133 @@ void Sema::NoteAllFoundTemplates(TemplateName Name) {
}
}
+static QualType commonTypeImpl(Sema &S, TemplateName BaseTemplate,
+ SourceLocation TemplateLoc,
+ ArrayRef Ts) {
+ auto lookUpComm
ldionne wrote:
@rorth Please check if this is still broken after
https://github.com/llvm/llvm-project/commit/7ab643383fe49d5bb22e45610cb52476bf7a922e
https://github.com/llvm/llvm-project/pull/96171
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
Author: Louis Dionne
Date: 2024-07-31T10:50:34-04:00
New Revision: 7ab643383fe49d5bb22e45610cb52476bf7a922e
URL:
https://github.com/llvm/llvm-project/commit/7ab643383fe49d5bb22e45610cb52476bf7a922e
DIFF:
https://github.com/llvm/llvm-project/commit/7ab643383fe49d5bb22e45610cb52476bf7a922e.diff
https://github.com/ldionne closed
https://github.com/llvm/llvm-project/pull/96171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/96171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6,7 +6,7 @@
//
//===--===//
-// REQUIRES: target={{powerpc.*-ibm-aix.*}}
+// REQUIRES: target={{.+}}-aix{{.*}}
ldionne wrote:
`libcxx/test/vendor` is a bit mis-named, I guess. It's more
https://github.com/ldionne approved this pull request.
https://github.com/llvm/llvm-project/pull/101196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ldionne approved this pull request.
libc++ changes LGTM.
https://github.com/llvm/llvm-project/pull/100425
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
It seems like the bot looks for the command anywhere in any comment :)
https://github.com/llvm/llvm-project/pull/97534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@ian-twilightcoder You can create an issue if you want, but you can also say
/cherry-pick directly from the PR as long as you add the release
milestone to it.
That being said, the cherry-pick failed so you will need to create a PR
manually.
https://github.com/llvm/llvm-projec
ldionne wrote:
@AaronBallman Just FYI you can also add the Milestone to the PR directly and
use the /cherry-pick command right here. This is a bit simpler.
https://github.com/llvm/llvm-project/pull/97534
___
cfe-commits mailing list
cfe-commits@lists.
ldionne wrote:
@ian-twilightcoder Cherry-picking is easy. Once this is merged, follow the
guidelines here to get it cherry-picked:
https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches
Basically you only need to add a comment to this PR like `/cherry-pick
COMMIT-SHA` and
https://github.com/ldionne milestoned
https://github.com/llvm/llvm-project/pull/99727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
@AaronBallman Should this be added to the 19.x milestone and cherry-picked?
https://github.com/llvm/llvm-project/pull/99727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
1 - 100 of 798 matches
Mail list logo
