[llvm-branch-commits] [runtimes] Allow building against an installed LLVM tree (PR #86209)

2024-06-25 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM but I think @petrhosek should also have a look. https://github.com/llvm/llvm-project/pull/86209 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [clang] [libcxx] [clang] Finish implementation of P0522 (PR #96023)

2024-06-25 Thread Louis Dionne via llvm-branch-commits
@@ -18,5 +18,9 @@ #include #include -// expected-error@+1 {{template template argument has different template parameters than its corresponding template template parameter}} -static_assert(!std::__is_specialization_v, std::array>); +#if defined(__clang__) &&

[llvm-branch-commits] [libcxx] Add release note for #95264 (PR #96116)

2024-06-24 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: > We don't have a great way to add release notes after the final release. I > added this to the release announcement do you think that is enough? Yes I think that is fine. https://github.com/llvm/llvm-project/pull/96116 ___

[llvm-branch-commits] [libcxx] Add release note for #95264 (PR #96116)

2024-06-24 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/96116 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] Add release note for #95264 (PR #96116)

2024-06-24 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: Gentle ping @tstellar, do we want to merge this? The CI issues are unrelated. https://github.com/llvm/llvm-project/pull/96116 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] Add release note for #95264 (PR #96116)

2024-06-20 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/96116 >From 4044e7c930381e5e070c7131c5b14a3dfd373259 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 19 Jun 2024 16:50:07 -0400 Subject: [PATCH 1/2] [libc++] Add release note for #95264 ---

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

2024-06-20 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,93 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

2024-06-20 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,93 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

2024-06-20 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,93 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

2024-06-20 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne requested changes to this pull request. I am not certain how to best make a decision about the bit-stealing mechanism yet, but I do have a few comments. https://github.com/llvm/llvm-project/pull/94670 ___

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

2024-06-20 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/94670 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] Add release note for #95264 (PR #96116)

2024-06-19 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/96116 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] Add release note for #95264 (PR #96116)

2024-06-19 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/96116 None >From 4044e7c930381e5e070c7131c5b14a3dfd373259 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 19 Jun 2024 16:50:07 -0400 Subject: [PATCH] [libc++] Add release note for #95264 ---

[llvm-branch-commits] [clang] [libcxx] [clang] Finish implementation of P0522 (PR #96023)

2024-06-19 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. libcxx/ nit LGTM. https://github.com/llvm/llvm-project/pull/96023 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][TZDB] Finishes zoned_time constructors. (PR #95010)

2024-06-18 Thread Louis Dionne via llvm-branch-commits
@@ -76,12 +81,71 @@ class zoned_time { _LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name) requires(requires { __traits::locate_zone(string_view{}); } && - // constructible_from - // would create a dependency on itself. Instead depend

[llvm-branch-commits] [libcxx] [libc++][TZDB] Finishes zoned_time constructors. (PR #95010)

2024-06-18 Thread Louis Dionne via llvm-branch-commits
@@ -76,12 +81,71 @@ class zoned_time { _LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name) requires(requires { __traits::locate_zone(string_view{}); } && - // constructible_from - // would create a dependency on itself. Instead depend

[llvm-branch-commits] [libcxx] [libc++][TZDB] Finishes zoned_time constructors. (PR #95010)

2024-06-18 Thread Louis Dionne via llvm-branch-commits
@@ -76,12 +81,71 @@ class zoned_time { _LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name) requires(requires { __traits::locate_zone(string_view{}); } && - // constructible_from - // would create a dependency on itself. Instead depend

[llvm-branch-commits] [libcxx] [libc++][TZDB] Finishes zoned_time constructors. (PR #95010)

2024-06-18 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,105 @@ +//===--===/ +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][TZDB] Finishes zoned_time constructors. (PR #95010)

2024-06-18 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,105 @@ +//===--===/ +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][TZDB] Finishes zoned_time constructors. (PR #95010)

2024-06-18 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/95010 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Finishes zoned_time constructors. (PR #95010)

2024-06-18 Thread Louis Dionne via llvm-branch-commits
@@ -76,12 +81,71 @@ class zoned_time { _LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name) requires(requires { __traits::locate_zone(string_view{}); } && - // constructible_from - // would create a dependency on itself. Instead depend

[llvm-branch-commits] [libcxx] [libc++][TZDB] Finishes zoned_time constructors. (PR #95010)

2024-06-18 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne requested changes to this pull request. This generally LGTM but the constraints seem wrong, so I'd like to see again once that is figured out. https://github.com/llvm/llvm-project/pull/95010 ___ llvm-branch-commits mailing

[llvm-branch-commits] [libcxx] [libc++][TZDB] Finishes zoned_time constructors. (PR #95010)

2024-06-18 Thread Louis Dionne via llvm-branch-commits
@@ -76,12 +81,71 @@ class zoned_time { _LIBCPP_HIDE_FROM_ABI explicit zoned_time(string_view __name) requires(requires { __traits::locate_zone(string_view{}); } && - // constructible_from - // would create a dependency on itself. Instead depend

[llvm-branch-commits] [libcxx] [libc++] Implement std::move_only_function (P0288R9) (PR #94670)

2024-06-11 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,233 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] Fixes leap seconds. (PR #90070)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/90070 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Fixes leap seconds. (PR #90070)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/90070 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Fixes leap seconds. (PR #90070)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
@@ -626,29 +626,49 @@ static void __parse_leap_seconds(vector& __leap_seconds, istream&& // seconds since 1 January 1970. constexpr auto __offset = sys_days{1970y / January / 1} - sys_days{1900y / January / 1}; - while (true) { -switch (__input.peek()) { -case

[llvm-branch-commits] [libcxx] [libc++][chrono] Fixes leap seconds. (PR #90070)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
@@ -626,29 +626,49 @@ static void __parse_leap_seconds(vector& __leap_seconds, istream&& // seconds since 1 January 1970. constexpr auto __offset = sys_days{1970y / January / 1} - sys_days{1900y / January / 1}; - while (true) { -switch (__input.peek()) { -case

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements zoned_traits. (PR #91059)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,32 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements zoned_traits. (PR #91059)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/91059 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements zoned_traits. (PR #91059)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM w/ minor comment. https://github.com/llvm/llvm-project/pull/91059 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_local. (PR #91003)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,66 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_local. (PR #91003)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/91003 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_local. (PR #91003)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/91003 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90901)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/90901 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90901)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/90901 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90901)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,37 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
@@ -339,6 +339,9 @@ if (LIBCXX_ENABLE_LOCALIZATION AND LIBCXX_ENABLE_FILESYSTEM AND LIBCXX_ENABLE_TI include/tzdb/types_private.h include/tzdb/tzdb_list_private.h include/tzdb/tzdb_private.h +# TODO TZDB The exception could be moved in chrono once the TZDB

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/90394 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,33 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
@@ -70,6 +72,30 @@ class _LIBCPP_AVAILABILITY_TZDB time_zone { return __get_info(chrono::time_point_cast(__time)); } + // Since the interface promisses throwing, don't add nodiscard. ldionne wrote: I don't think this comment is necessary -- we assume

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM w/ comments applied (in particular the missing tests). https://github.com/llvm/llvm-project/pull/90394 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone::to_sys. (PR #90394)

2024-06-04 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,20 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [clang] [libcxx] [clang] Preserve Qualifiers and type sugar in TemplateNames (PR #93433)

2024-05-27 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. `libcxx/` changes LGTM. https://github.com/llvm/llvm-project/pull/93433 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libc] [libcxx] [libcxxabi] [libunwind] [llvm] [pstl] Revise IDE folder structure (PR #89755)

2024-05-21 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM. After checking, I think this only impacts `add_lit_testsuites` since we don't use many other things from `AddLLVM.cmake` in the runtimes. https://github.com/llvm/llvm-project/pull/89755 ___

[llvm-branch-commits] [libcxx] release/18.x: [libcxx] [modules] Add _LIBCPP_USING_IF_EXISTS on aligned_alloc (#89827) (PR #89894)

2024-04-25 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: > Can we ignore the libcxx test failure? Yes. It turns out to be extremely difficult to keep the release branch CI working *and* the `main` branch CI working at the same time. I mean it mostly works, except for annoyances like this.

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -106,1110 +105,748 @@ namespace __escaped_output_table { /// table lacks a property, thus having more bits available for the size. /// /// The data has 2 values: -/// - bits [0, 10] The size of the range, allowing 2048 elements. -/// - bits [11, 31] The lower bound code

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -106,1110 +105,748 @@ namespace __escaped_output_table { /// table lacks a property, thus having more bits available for the size. /// /// The data has 2 values: -/// - bits [0, 10] The size of the range, allowing 2048 elements. -/// - bits [11, 31] The lower bound code

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88533 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -305,23 +316,28 @@ def generate_data_tables() -> str: data = compactPropertyRanges(sorted(properties, key=lambda x: x.lower)) -# The last entry is large. In Unicode 14 it contains the entries -# 3134B..0 912564 elements -# This are 446 entries of 1325

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -305,23 +316,28 @@ def generate_data_tables() -> str: data = compactPropertyRanges(sorted(properties, key=lambda x: x.lower)) -# The last entry is large. In Unicode 14 it contains the entries -# 3134B..0 912564 elements -# This are 446 entries of 1325

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,100 @@ +//===--===// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM with a few comments! https://github.com/llvm/llvm-project/pull/88533 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -305,23 +316,28 @@ def generate_data_tables() -> str: data = compactPropertyRanges(sorted(properties, key=lambda x: x.lower)) -# The last entry is large. In Unicode 14 it contains the entries -# 3134B..0 912564 elements -# This are 446 entries of 1325

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping performance. (PR #88533)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88533 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -328,8 +313,13 @@ def generate_data_tables() -> str: # # When this region becomes substantially smaller we need to investigate # this design. +# +# Due to P2713R1 Escaping improvements in std::format the range +# E0100..E01EF ; Grapheme_Extend #

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][format] Improves escaping. (PR #88283)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/88283 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/89537 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
@@ -903,6 +904,180 @@ time_zone::__get_info(sys_seconds __time) const { std::__throw_runtime_error("tzdb: corrupt db"); } +enum class __position { + __beginning, + __middle, + __end, +}; + +// Determines the position of "__time" inside "__info". +// +// The code picks an

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/89537 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Implements time_zone get_info(local_time). (PR #89537)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/89537 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Makes saturation functions privately available. (PR #89503)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/89503 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Fixes reverse time lookups. (PR #89502)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/89502 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Fixes reverse time lookups. (PR #89502)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/89502 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libc] [libcxx] [libcxxabi] [libunwind] [llvm] [pstl] Revise IDE folder structure (PR #89755)

2024-04-23 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/89755 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Fix -Wgnu-include-next in stddef.h (#88214) (PR #88419)

2024-04-17 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: I don't think a release note is necessary here because we introduced the "bug" and fixed it in the same point-release. So from the user's perspective there was no issue introduced. https://github.com/llvm/llvm-project/pull/88419 ___

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,114 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,50 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,50 @@ +// -*- C++ -*- ldionne wrote: Maybe update the commit message since this patch actually introduces `local_info`, not only the formatter for it. https://github.com/llvm/llvm-project/pull/86256 ___

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM with small comments. https://github.com/llvm/llvm-project/pull/86256 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/86256 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/85896 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/86127 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/86127 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -322,15 +322,13 @@ _LIBCPP_HIDE_FROM_ABI void __format_chrono_using_chrono_specs( __formatter::__format_year(__sstr, __t.tm_year + 1900); break; - case _CharT('F'): { -int __year = __t.tm_year + 1900; -if (__year < 1000) { -

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/86127 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/85797 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/85797 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -170,10 +171,45 @@ _LIBCPP_HIDE_FROM_ABI void __format_century(basic_stringstream<_CharT>& __sstr, __sstr << std::format(_LIBCPP_STATICALLY_WIDEN(_CharT, "{:02}"), __century); } +// Implements the %z format specifier according to [tab:time.format.spec], where +//

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -170,10 +171,45 @@ _LIBCPP_HIDE_FROM_ABI void __format_century(basic_stringstream<_CharT>& __sstr, __sstr << std::format(_LIBCPP_STATICALLY_WIDEN(_CharT, "{:02}"), __century); } +// Implements the %z format specifier according to [tab:time.format.spec], where +//

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. LGTM with minor comments. Thanks! https://github.com/llvm/llvm-project/pull/85797 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

2024-04-16 Thread Louis Dionne via llvm-branch-commits
@@ -170,10 +171,45 @@ _LIBCPP_HIDE_FROM_ABI void __format_century(basic_stringstream<_CharT>& __sstr, __sstr << std::format(_LIBCPP_STATICALLY_WIDEN(_CharT, "{:02}"), __century); } +// Implements the %z format specifier according to [tab:time.format.spec], where +//

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Fix -Wgnu-include-next in stddef.h (#88214) (PR #88419)

2024-04-11 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/88419 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Simplify the implementation of (#86843) (PR #87374)

2024-04-11 Thread Louis Dionne via llvm-branch-commits
ldionne wrote: > As mentioned on #86843, this breaks using `-pedantic` in code that includes > libc++ headers. Since this got cherry-picked, we also must cherry-pick #88214. I just started that process here: https://github.com/llvm/llvm-project/pull/88214#issuecomment-2050203419

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,1374 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,53 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/85619 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
https://github.com/ldionne commented: We can dive into the implementation during the next round of review! https://github.com/llvm/llvm-project/pull/85619 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [runtimes] Allow building against an installed LLVM tree (PR #86209)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -218,6 +218,22 @@ foreach(entry ${runtimes}) endforeach() if(LLVM_INCLUDE_TESTS) + # Add lit if needed before adding any runtimes since their CMake tests + # configuration might depend on lit being present. + if (NOT HAVE_LLVM_LIT) +# If built by manually invoking

[llvm-branch-commits] [runtimes] Allow building against an installed LLVM tree (PR #86209)

2024-03-26 Thread Louis Dionne via llvm-branch-commits
@@ -218,6 +218,22 @@ foreach(entry ${runtimes}) endforeach() if(LLVM_INCLUDE_TESTS) + # Add lit if needed before adding any runtimes since their CMake tests + # configuration might depend on lit being present. + if (NOT HAVE_LLVM_LIT) +# If built by manually invoking

  1   2   3   >