[llvm-branch-commits] [libcxx] release/18.x: [libc++] Fix -Wgnu-include-next in stddef.h (#88214) (PR #88419)

ldionne wrote: I don't think a release note is necessary here because we introduced the "bug" and fixed it in the same point-release. So from the user's perspective there was no issue introduced. https://github.com/llvm/llvm-project/pull/88419 ___

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

@@ -0,0 +1,114 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

@@ -0,0 +1,50 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

@@ -0,0 +1,50 @@ +// -*- C++ -*- ldionne wrote: Maybe update the commit message since this patch actually introduces `local_info`, not only the formatter for it. https://github.com/llvm/llvm-project/pull/86256 ___

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

https://github.com/ldionne approved this pull request. LGTM with small comments. https://github.com/llvm/llvm-project/pull/86256 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds local_info formatter. (PR #86256)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/86256 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Adds sys_info formatter. (PR #85896)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/85896 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/86127 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/86127 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

@@ -322,15 +322,13 @@ _LIBCPP_HIDE_FROM_ABI void __format_chrono_using_chrono_specs( __formatter::__format_year(__sstr, __t.tm_year + 1900); break; - case _CharT('F'): { -int __year = __t.tm_year + 1900; -if (__year < 1000) { -

[llvm-branch-commits] [libcxx] [libc++][chrono] Improves date formatting. (PR #86127)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/86127 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/85797 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/85797 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

@@ -170,10 +171,45 @@ _LIBCPP_HIDE_FROM_ABI void __format_century(basic_stringstream<_CharT>& __sstr, __sstr << std::format(_LIBCPP_STATICALLY_WIDEN(_CharT, "{:02}"), __century); } +// Implements the %z format specifier according to [tab:time.format.spec], where +//

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

@@ -170,10 +171,45 @@ _LIBCPP_HIDE_FROM_ABI void __format_century(basic_stringstream<_CharT>& __sstr, __sstr << std::format(_LIBCPP_STATICALLY_WIDEN(_CharT, "{:02}"), __century); } +// Implements the %z format specifier according to [tab:time.format.spec], where +//

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

https://github.com/ldionne approved this pull request. LGTM with minor comments. Thanks! https://github.com/llvm/llvm-project/pull/85797 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][TZDB] Improves time zone format specifiers. (PR #85797)

@@ -170,10 +171,45 @@ _LIBCPP_HIDE_FROM_ABI void __format_century(basic_stringstream<_CharT>& __sstr, __sstr << std::format(_LIBCPP_STATICALLY_WIDEN(_CharT, "{:02}"), __century); } +// Implements the %z format specifier according to [tab:time.format.spec], where +//

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Fix -Wgnu-include-next in stddef.h (#88214) (PR #88419)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/88419 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Simplify the implementation of (#86843) (PR #87374)

ldionne wrote: > As mentioned on #86843, this breaks using `-pedantic` in code that includes > libc++ headers. Since this got cherry-picked, we also must cherry-pick #88214. I just started that process here: https://github.com/llvm/llvm-project/pull/88214#issuecomment-2050203419

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

@@ -0,0 +1,1374 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

@@ -0,0 +1,53 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/85619 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

@@ -0,0 +1,127 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] Adds the sys_info class. (PR #85619)

https://github.com/ldionne commented: We can dive into the implementation during the next round of review! https://github.com/llvm/llvm-project/pull/85619 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [runtimes] Allow building against an installed LLVM tree (PR #86209)

@@ -218,6 +218,22 @@ foreach(entry ${runtimes}) endforeach() if(LLVM_INCLUDE_TESTS) + # Add lit if needed before adding any runtimes since their CMake tests + # configuration might depend on lit being present. + if (NOT HAVE_LLVM_LIT) +# If built by manually invoking

[llvm-branch-commits] [runtimes] Allow building against an installed LLVM tree (PR #86209)

@@ -218,6 +218,22 @@ foreach(entry ${runtimes}) endforeach() if(LLVM_INCLUDE_TESTS) + # Add lit if needed before adding any runtimes since their CMake tests + # configuration might depend on lit being present. + if (NOT HAVE_LLVM_LIT) +# If built by manually invoking

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

ldionne wrote: No worries! I just created https://github.com/llvm/llvm-project/pull/85305, hopefully that should do the trick. https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++] Use clang-tidy version that matches the compiler we use in the CI (PR #85305)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/85305 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Use clang-tidy version that matches the compiler we use in the CI (PR #85305)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/85305 This works around ODR violations in the clang-tidy plugin we use to perform the modules tests. Fixes #85242 >From 810c55db5c92f5786a4c2b1b1336dd8b62f28f86 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date:

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

ldionne wrote: Is the fix only to switch to 18.1 in the cmake? I can do that if that's it, I just don't fully understand the situation w/ clang tidy ODR violations since you were the one to make these changes https://github.com/llvm/llvm-project/pull/85247

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

ldionne wrote: @mordante So should I close this PR? https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

https://github.com/ldionne closed https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/85247 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Cherry-pick the disabling of modules tests onto release/18.x (PR #85247)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/85247 LIT was never really meant to generate tests during discovery, and we probably shouldn't be doing this. This hack is even worse than the initial attempt because it buries the "UNSUPPORTED" at the bottom of the

[llvm-branch-commits] [libcxx] [libcxxabi] [libunwind] release/18.x: [runtimes] Prefer -fvisibility-global-new-delete=force-hidden (#84917) (PR #85126)

ldionne wrote: @tstellar Yes. I think I'll disable these tests which keep failing in the LLVM 18 release branch so we can remove some of the noise here. https://github.com/llvm/llvm-project/pull/85126 ___ llvm-branch-commits mailing list

[llvm-branch-commits] [libcxx] [libcxxabi] [libunwind] release/18.x: [runtimes] Prefer -fvisibility-global-new-delete=force-hidden (#84917) (PR #85126)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/85126 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Enable availability based on the compiler instead of __has_extension (#84065) (PR #84374)

ldionne wrote: No, it's not legitimate. Our CI is rather unstable at the moment but this looks as good as it'll get. https://github.com/llvm/llvm-project/pull/84374 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] release/18.x: [libc++] Enable availability based on the compiler instead of __has_extension (#84065) (PR #84374)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/84374 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

@@ -43,6 +44,40 @@ struct tzdb { vector links; vector leap_seconds; + + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI const time_zone* __locate_zone(string_view __name) const { +if (const time_zone* __result = __find_in_zone(__name); __result) + return __result; + +

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

@@ -655,6 +655,57 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.leap_seconds); } +#ifdef _WIN32 +[[nodiscard]] static const time_zone* __current_zone_windows(const tzdb& tzdb) { + // TODO TZDB Implement this on Windows.

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

@@ -43,6 +44,40 @@ struct tzdb { vector links; vector leap_seconds; + + [[nodiscard]] _LIBCPP_HIDE_FROM_ABI const time_zone* __locate_zone(string_view __name) const { +if (const time_zone* __result = __find_in_zone(__name); __result) + return __result; + +

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/82157 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][chrono] Completes the tzdb class. (PR #82157)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/82157 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libc++][modules] Fixes naming inconsistency. (#83036) (PR #83156)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/83156 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++] Implements filebuf unbuffered. (PR #76629)

@@ -276,6 +276,30 @@ private: state_type __st_; state_type __st_last_; ios_base::openmode __om_; + // Used to track the currently used mode and track whether the output should + // be unbuffered. + // [filebuf.virtuals]/12 + // If setbuf(0, 0) is called on a stream

[llvm-branch-commits] [libcxx] [libc++] Implements filebuf unbuffered. (PR #76629)

@@ -294,7 +318,10 @@ private: return nullptr; __om_ = __mode; + __try_set_unbuffered_mode(); ldionne wrote: Strange indentation. https://github.com/llvm/llvm-project/pull/76629 ___

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -0,0 +1,48 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -0,0 +1,53 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -0,0 +1,112 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -612,6 +643,16 @@ void __init_tzdb(tzdb& __tzdb, __tz::__rules_storage_type& __rules) { std::ranges::sort(__tzdb.zones); std::ranges::sort(__tzdb.links); std::ranges::sort(__rules, {}, [](const auto& p) { return p.first; }); + + // There are two files with the leap

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -0,0 +1,102 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -0,0 +1,51 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -35,5 +35,8 @@ int main(int, const char**) { assert(std::ranges::is_sorted(db.links)); assert(std::ranges::adjacent_find(db.links) == db.links.end()); // is unique? + assert(!db.leap_seconds.empty()); ldionne wrote: We seem to be missing a test that

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -0,0 +1,56 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -0,0 +1,53 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

https://github.com/ldionne requested changes to this pull request. https://github.com/llvm/llvm-project/pull/82113 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -0,0 +1,53 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

@@ -0,0 +1,112 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[llvm-branch-commits] [libcxx] [libc++][chrono] Loads leap-seconds.list in tzdb. (PR #82113)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/82113 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] release/18.x: [libc++][modules] Re-add build dir CMakeLists.txt. (#81370) (PR #81651)

ldionne wrote: Approved after talking with Mark. This is important for early adopters of modules. https://github.com/llvm/llvm-project/pull/81651 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] release/18.x: [libc++][print] Moves is_terminal to the dylib. (#80464) (PR #81410)

ldionne wrote: Approved. https://github.com/llvm/llvm-project/pull/81410 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] PR for llvm/llvm-project#80168 (PR #80702)

ldionne wrote: > @ldionne What do you think about merging this PR to the release branch? Approved! https://github.com/llvm/llvm-project/pull/80702 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libcxx] Add a release note for Clang-cl specific features (PR #80010)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/80010 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [clang] PR for llvm/llvm-project#79762 (PR #79763)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/79763 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [llvm] [][ci] Fix the base branch we use to determine changes (#79503) (PR #79506)

https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/79506 >From fce5c171b463d766cb25208634553a39b94498a6 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jan 2024 16:38:53 -0500 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9F=8D=92][ci]=20Fix=20the=20base=20bra?=

[llvm-branch-commits] [llvm] [][ci] Fix the base branch we use to determine changes (#79503) (PR #79506)

https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/79506 >From fce5c171b463d766cb25208634553a39b94498a6 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 25 Jan 2024 16:38:53 -0500 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9F=8D=92][ci]=20Fix=20the=20base=20bra?=

[llvm-branch-commits] [llvm] [][ci] Fix the base branch we use to determine changes (#79503) (PR #79506)

https://github.com/ldionne created https://github.com/llvm/llvm-project/pull/79506 We should diff against the base branch, not always against `main`. This allows the BuildKite pre-commit CI to work properly when we target other branches, such as `release/18.x`. (cherry picked from commit

[llvm-branch-commits] [libcxx] [][libc++] Fix missing and incorrect push/pop macros (#79204) (PR #79497)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/79497 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [][libc++] Fix missing and incorrect push/pop macros (#79204) (PR #79497)

https://github.com/ldionne milestoned https://github.com/llvm/llvm-project/pull/79497 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [] Unconditionally lower std::string's alignment requirement from 16 to 8 (#68925) (PR #79480)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/79480 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] Cherry-pick Unconditionally lower std::string's alignment requirement from 16 to 8 (#68925) (PR #79480)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/79480 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] Cherry-pick Unconditionally lower std::string's alignment requirement from 16 to 8 (#68925) (PR #79480)

ldionne wrote: Oh, that's great! Then it looks like this PR is fine as-is. https://github.com/llvm/llvm-project/pull/79480 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] Cherry-pick Unconditionally lower std::string's alignment requirement from 16 to 8 (#68925) (PR #79480)

ldionne wrote: This is the official way to do it: https://llvm.org/docs/GitHub.html#backporting-fixes-to-the-release-branches @tstellar I do wonder if it wouldn't be simpler to allow people to open PRs against the release branch instead? https://github.com/llvm/llvm-project/pull/79480

[llvm-branch-commits] [libcxx] Cherry-pick Unconditionally lower std::string's alignment requirement from 16 to 8 (#68925) (PR #79480)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/79480 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] Cherry-pick Unconditionally lower std::string's alignment requirement from 16 to 8 (#68925) (PR #79480)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/79480 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -131,13 +138,65 @@ def parseScript(test, preamble): script += preamble script += scriptInTest +has_std_module = False +has_std_compat_module = False +for module in modules: +if module == "std": +has_std_module = True +elif

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -132,13 +154,62 @@ def parseScript(test, preamble): script += scriptInTest # Add compile flags specified with ADDITIONAL_COMPILE_FLAGS. +# Modules need to be build with the same compilation flags as the +# test. So add these flags before adding the modules.

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -132,13 +154,62 @@ def parseScript(test, preamble): script += scriptInTest # Add compile flags specified with ADDITIONAL_COMPILE_FLAGS. +# Modules need to be build with the same compilation flags as the +# test. So add these flags before adding the modules.

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -132,13 +154,62 @@ def parseScript(test, preamble): script += scriptInTest # Add compile flags specified with ADDITIONAL_COMPILE_FLAGS. +# Modules need to be build with the same compilation flags as the +# test. So add these flags before adding the modules.

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -132,13 +154,62 @@ def parseScript(test, preamble): script += scriptInTest # Add compile flags specified with ADDITIONAL_COMPILE_FLAGS. +# Modules need to be build with the same compilation flags as the +# test. So add these flags before adding the modules.

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -52,6 +52,21 @@ def _executeScriptInternal(test, litConfig, commands): return (out, err, exitCode, timeoutInfo, parsedCommands) +def _validateModuleDependencies(modules): +for m in modules: +if m not in ("std", "std.compat"): +raise

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -0,0 +1,22 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -132,13 +154,62 @@ def parseScript(test, preamble): script += scriptInTest # Add compile flags specified with ADDITIONAL_COMPILE_FLAGS. +# Modules need to be build with the same compilation flags as the +# test. So add these flags before adding the modules.

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

https://github.com/ldionne approved this pull request. LGTM with some comments, thanks! https://github.com/llvm/llvm-project/pull/76246 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -0,0 +1,24 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -0,0 +1,24 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -132,13 +154,62 @@ def parseScript(test, preamble): script += scriptInTest # Add compile flags specified with ADDITIONAL_COMPILE_FLAGS. +# Modules need to be build with the same compilation flags as the +# test. So add these flags before adding the modules.

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -132,13 +154,62 @@ def parseScript(test, preamble): script += scriptInTest # Add compile flags specified with ADDITIONAL_COMPILE_FLAGS. +# Modules need to be build with the same compilation flags as the ldionne wrote: ```suggestion #

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/76246 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -131,13 +138,65 @@ def parseScript(test, preamble): script += preamble script += scriptInTest +has_std_module = False +has_std_compat_module = False +for module in modules: +if module == "std": +has_std_module = True +elif

[llvm-branch-commits] [libcxx] [libc++][modules] Improves std.compat module. (PR #76330)

https://github.com/ldionne approved this pull request. I guess I don't actually need to see this again if the CI passes once this is rebased on top of the parent changes. https://github.com/llvm/llvm-project/pull/76330 ___ llvm-branch-commits mailing

[llvm-branch-commits] [libcxx] [libc++][modules] Improves std.compat module. (PR #76330)

https://github.com/ldionne commented: This generally looks OK to me, but I'd like to see it once the parent patches have landed. https://github.com/llvm/llvm-project/pull/76330 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org

[llvm-branch-commits] [libcxx] [libc++][modules] Fixes clang-tidy exports. (PR #76288)

https://github.com/ldionne approved this pull request. https://github.com/llvm/llvm-project/pull/76288 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][modules] Fixes clang-tidy exports. (PR #76288)

https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/76288 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -223,6 +283,12 @@ class CxxStandardLibraryTest(lit.formats.FileBasedTest): allows adding special compilation flags without having to use a .sh.cpp test, which would be more powerful but perhaps overkill. +// MODULE: std std.compat + +

[llvm-branch-commits] [libcxx] [libc++][modules] Adds module testing. (PR #76246)

@@ -317,6 +317,18 @@ def _getAndroidDeviceApi(cfg): AddSubstitution("%{clang-tidy}", lambda cfg: _getSuitableClangTidy(cfg)) ], ), +# Whether module support for the platform is available. +Feature( +name="has-no-module-support",

<    1   2   3   4   >