Re: [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35

2022-08-09 Thread Mathieu Desnoyers
- On Aug 9, 2022, at 8:21 AM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - Gavin Shan wrote: >> Hi Florian, >> >> On 8/9/22 5:16 PM, Florian Weimer wrote: >> >>> __builtin_thread_pointer doesn't work on all architectures/GCC >&

Re: [PATCH 1/2] KVM: selftests: Make rseq compatible with glibc-2.35

2022-08-09 Thread Mathieu Desnoyers
gt; integrity, but it's not called at all. > > I think kvm/selftest is always relying on glibc if I'm correct. All those are handled in the rseq selftests and in librseq. Why duplicate all that logic again? Thanks, Mathieu > > Thanks, > Gavin > -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm

Re: [lttng-dev] [PATCH v2] Improve tracef/tracelog to use the stack for small strings

2022-08-01 Thread Mathieu Desnoyers via lttng-dev
eak ABI. Thoughts ? Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [lttng-dev] [PATCH v2 2/2] lttng_ust_init_thread: call urcu_register_thread

2022-08-01 Thread Mathieu Desnoyers via lttng-dev
- On Aug 1, 2022, at 10:37 AM, Norbert Lange nolang...@gmail.com wrote: > From: Norbert Lange > > Eagerly register the thread, and avoid taking mutex during the > first tracepoint. Merged, thanks! Mathieu > > Signed-off-by: Norbert Lange > Acked-by: Mathieu Desno

Re: [lttng-dev] [PATCH v2] Improve tracef/tracelog to use the stack for small strings

2022-08-01 Thread Mathieu Desnoyers via lttng-dev
racepoint_cb_lttng_ust_tracef___event, > + msg, len, LTTNG_UST_CALLER_IP()); > } > diff --git a/src/lib/lttng-ust/tracelog-internal.h > b/src/lib/lttng-ust/tracelog-internal.h > new file mode 100644 > index ..34537023 > --- /dev/null > +++ b/src/lib/lttng-

Re: [lttng-dev] [PATCH v2 1/2] lttng_ust_init_thread: initialise cached context values

2022-08-01 Thread Mathieu Desnoyers via lttng-dev
Using void lttng_ust_perf_counter_init_thread(int flags __attribute__((unused))) instead. > { > + (void)flags; > } Will fixup locally and merge. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@

Re: [lttng-dev] [PATCH] Improve tracef/tracelog to use the stack for small strings

2022-07-22 Thread Mathieu Desnoyers via lttng-dev
; - > - va_start(ap, fmt); > - lttng_ust___vtracef(fmt, ap); > - va_end(ap); > + LTTNG_UST_TRACELOG_VARARG(fmt, > + lttng_ust_tracepoint_cb_lttng_ust_tracef___event, > + msg, len, LTTNG_UST_CALLER_IP()); > } > diff --git a/src/lib/lttn

Re: [lttng-dev] [PATCH 1/2] lttng_ust_init_thread: initialise cached context values

2022-07-20 Thread Mathieu Desnoyers via lttng-dev
- On Jul 20, 2022, at 4:00 PM, Norbert Lange nolang...@gmail.com wrote: > Am Di., 19. Juli 2022 um 21:39 Uhr schrieb Mathieu Desnoyers > : >> >> - On Jul 18, 2022, at 5:59 PM, Norbert Lange via lttng-dev >> lttng-dev@lists.lttng.org wrote: >> >> > Mo

Re: [lttng-dev] [PATCH 2/2] lttng_ust_init_thread: call urcu_register_thread

2022-07-19 Thread Mathieu Desnoyers via lttng-dev
- On Jul 18, 2022, at 5:59 PM, Norbert Lange via lttng-dev lttng-dev@lists.lttng.org wrote: > Eagerly register the thread, and avoid taking mutex during the > first tracepoint. Acked-by: Mathieu Desnoyers Please resubmit with the next round with my acked-by tag. Mathieu > >

Re: [lttng-dev] [PATCH 1/2] lttng_ust_init_thread: initialise cached context values

2022-07-19 Thread Mathieu Desnoyers via lttng-dev
alloc_tls(); > + lttng_ust_alloc_tls(false); > /* >* If available, add '-ust' to the end of this thread's >* process name > @@ -2183,7 +2183,7 @@ void lttng_ust_ctor(void) >* to be the dynamic linker mutex) and ust_lock, taken within > * the ust lock. >

Re: [lttng-dev] LTTng on RHEL 7.9 with real time kernel patch

2022-07-18 Thread Mathieu Desnoyers via lttng-dev
ording to the applicable laws only if it is > digitally signed by the sender > _______ > lttng-dev mailing list > lttng-dev@lists.lttng.org > https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev -- Mathieu Desnoyers EfficiOS Inc. htt

Re: [lttng-dev] reading context fields causes syscalls

2022-07-18 Thread Mathieu Desnoyers via lttng-dev
- On Jul 14, 2022, at 9:10 AM, Norbert Lange nolang...@gmail.com wrote: > Hello Mathieu, > > Am Do., 20. Mai 2021 um 16:16 Uhr schrieb Mathieu Desnoyers > : >> >> - On May 20, 2021, at 9:42 AM, Norbert Lange nolang...@gmail.com wrote: >> >> > Am

[lttng-dev] Tracing Summit 2022: Announcement and Call for Proposals, October 11th - 13th, 2022, London, United Kingdom

2022-07-13 Thread Mathieu Desnoyers via lttng-dev
ttps://docs.google.com/forms/d/e/1FAIpQLSdq4whieesZeoHJq1h2CDbWeO5FuQnPk6G257hfSLgnWRenvg/viewform [3]: http://eepurl.com/goakfv -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi

[linuxtools-dev] Tracing Summit 2022: Announcement and Call for Proposals, October 11th - 13th, 2022, London, United Kingdom

2022-07-13 Thread Mathieu Desnoyers
ttps://docs.google.com/forms/d/e/1FAIpQLSdq4whieesZeoHJq1h2CDbWeO5FuQnPk6G257hfSLgnWRenvg/viewform [3]: http://eepurl.com/goakfv -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ linuxtools-dev mailing list linuxtools-dev@eclipse.org To unsubscribe

Re: [lttng-dev] ***UNCHECKED*** Re: Re: urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-23 Thread Mathieu Desnoyers via lttng-dev
e is still observed as empty by [d], thus calling [e] again. This time, the value is -1, so it calls sys_futex FUTEX_WAIT. Unfortunately, we still have the call to sys_futex FUTEX_WAKE that will eventually be executed, thus awakening the futex while the futex state i

Re: [lttng-dev] ***UNCHECKED*** Re: Re: urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-22 Thread Mathieu Desnoyers via lttng-dev
- On Jun 22, 2022, at 4:28 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Jun 22, 2022, at 9:19 AM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: > >> - On Jun 22, 2022, at 3:45 AM, Minlan Wang wangmin...@szsandston

Re: [lttng-dev] ***UNCHECKED*** Re: Re: urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-22 Thread Mathieu Desnoyers via lttng-dev
- On Jun 22, 2022, at 9:19 AM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Jun 22, 2022, at 3:45 AM, Minlan Wang wangmin...@szsandstone.com > wrote: > > [...] > > Hi Minlan, > >> -- >> 1.8.3.1 >> >> >> And th

Re: [lttng-dev] ***UNCHECKED*** Re: Re: urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-22 Thread Mathieu Desnoyers via lttng-dev
ry trace, because then it's easy to load it in trace compass, cut away time ranges that don't matter, and lots of other useful stuff. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.

Re: [lttng-dev] ***UNCHECKED*** Re: urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-21 Thread Mathieu Desnoyers via lttng-dev
- On Jun 20, 2022, at 11:52 PM, Minlan Wang wangmin...@szsandstone.com wrote: > Hi, Mathieu, > On Fri, Jun 17, 2022 at 09:37:23AM -0400, Mathieu Desnoyers wrote: >> Can you try the following patch on top of v0.12.1 + your debug patch ? >> >> diff --git a/src/workq

Re: [lttng-dev] urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-17 Thread Mathieu Desnoyers via lttng-dev
ait(int32_t *futex) fprintf(stderr, "%lu: wq %p: %s wait return %d\n", pthread_self(), caa_container_of(futex, struct urcu_workqueue, futex), __func__, ret); - + /* +* Prior queued wakeups can cause futex wait to return even +* though the fut

Re: [lttng-dev] urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-15 Thread Mathieu Desnoyers via lttng-dev
.1) > Author: Mathieu Desnoyers > Date: Wed Apr 22 08:51:41 2020 -0400 > >Version 0.12.1 > >Signed-off-by: Mathieu Desnoyers > > The OS we are using is CentOS Linux release 7.9.2009 (Core), not CentOS 8.2 > as mentioned before. And the kernel version is: 3.10.0-116

Re: [lttng-dev] urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-15 Thread Mathieu Desnoyers via lttng-dev
.1) > Author: Mathieu Desnoyers > Date: Wed Apr 22 08:51:41 2020 -0400 > >Version 0.12.1 > >Signed-off-by: Mathieu Desnoyers > > The OS we are using is CentOS Linux release 7.9.2009 (Core), not CentOS 8.2 > as mentioned before. And the kernel version is: 3.10.

Re: [lttng-dev] urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-14 Thread Mathieu Desnoyers via lttng-dev
b64/libpthread.so.0 > #3 0x7415d96d in clone () from /usr/lib64/libc.so.6 > Hardware watchpoint 4: -location workqueue->futex > ... > > After this, things went into wild, workqueue->futex got into bigger negative > value, and workqueue thread

Re: [lttng-dev] urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-14 Thread Mathieu Desnoyers via lttng-dev
is, things went into wild, workqueue->futex got into bigger negative > value, and workqueue thread eat up the cpu it is using. > This ends only when workqueue->futex down flew into 0. > > Do you have any idea why this is happening, and how to fix it? > > B.R > Minlan Wang -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [lttng-dev] urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-14 Thread Mathieu Desnoyers via lttng-dev
- On Jun 14, 2022, at 9:39 AM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On Jun 13, 2022, at 11:55 PM, Minlan Wang wangmin...@szsandstone.com > wrote: > >> Hi, Mathieu, > > Hi Minlan, > > Thanks for the detailed bug report. Can I ask mor

Re: [lttng-dev] urcu workqueue thread uses 99% of cpu while workqueue is empty

2022-06-14 Thread Mathieu Desnoyers via lttng-dev
kqueue.c:250 > #2 0x772e6ea5 in start_thread () from /usr/lib64/libpthread.so.0 > #3 0x7415d96d in clone () from /usr/lib64/libc.so.6 > Hardware watchpoint 4: -location workqueue->futex > ... > > After this, things went into wild, workqueue->futex got into bigger ne

[PATCH v6 4/5] grub-mkconfig kfreebsd: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a kfreebsd environment could test it before it is merged. ] Signed-o

Re: [PATCH v5 3/5] grub-mkconfig hurd: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
- On Jun 11, 2022, at 7:55 PM, samuel thibault samuel.thiba...@ens-lyon.org wrote: > Hello, > > Mathieu Desnoyers, le jeu. 09 juin 2022 14:50:22 -0400, a ecrit: >> The current implementation of the 10_hurd script implements its menu >> items sorting in bash with

Re: [PATCH v5 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
- On Jun 10, 2022, at 4:00 PM, Jason Andryuk jandr...@gmail.com wrote: > On Thu, Jun 9, 2022 at 2:50 PM Mathieu Desnoyers > wrote: >> >> The current implementation of the 20_linux_xen script implements its >> menu items sorting in bash with a quadratic algorithm,

[PATCH v6 3/5] grub-mkconfig hurd: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
ho can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. Signed-off-by: Mathieu Desnoyers Tested-by: Samuel Thibault Cc: Samuel Thibault --- Changes since v4: - Combine sed -e '...' -e '...'

[PATCH v6 1/5] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
each menu entry item. Therefore, the algorithm proposed has O(n*log(n)) complexity with GNU coreutils' sort compared to the prior O(n^2) complexity. Moreover, the constant time required for each list entry is much less because sorting is done within a single execution of sort(1) rather than requiring

[PATCH v6 4/5] grub-mkconfig kfreebsd: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a kfreebsd environment could test it before it is merged. ] Sign

[PATCH v6 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. Signed-off-by: Mathieu Desnoyers Tested-by: Jason Andryuk Cc: xen-de...@lists.xenproject.org --- Changes since v4: - Combine sed -e '...' -

[PATCH v6 0/5] grub-mkconfig: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
This series of patches fixes a O(n^2) algorithm in the menu items generation scripts. Since v5, add Tested-by tags, and update patch 1 to apply bash best practices. Testing is still needed on kfreebsd. Mathieu Mathieu Desnoyers (5): grub-mkconfig linux: Fix quadratic algorithm for sorting

[PATCH v6 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions

2022-06-13 Thread Mathieu Desnoyers
There are no users left of version_find_latest(), version_test_gt(), and version_test_numeric(). Remove those unused helper functions. Using those helper functions is what caused the quadratic sorting performance issues in the first place, so removing them is a net win. Signed-off-by: Mathieu

[PATCH v6 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. Signed-off-by: Mathieu Desnoyers Tested-by: Jason Andryuk Cc: xen-devel@lists.xenproject.org --- Changes since v4: - Combine sed -e '...' -

Re: [PATCH v5 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items

2022-06-13 Thread Mathieu Desnoyers
- On Jun 10, 2022, at 4:00 PM, Jason Andryuk jandr...@gmail.com wrote: > On Thu, Jun 9, 2022 at 2:50 PM Mathieu Desnoyers > wrote: >> >> The current implementation of the 20_linux_xen script implements its >> menu items sorting in bash with a quadratic algorithm,

[PATCH v5 4/5] grub-mkconfig kfreebsd: Fix quadratic algorithm for sorting menu items

2022-06-09 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a kfreebsd environment could test it before it is merged. ] Sign

[PATCH v5 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items

2022-06-09 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a Xen environment could test it before it is merged. ] Sign

[PATCH v5 4/5] grub-mkconfig kfreebsd: Fix quadratic algorithm for sorting menu items

2022-06-09 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a kfreebsd environment could test it before it is merged. ] Signed-o

[PATCH v5 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions

2022-06-09 Thread Mathieu Desnoyers
There are no users left of version_find_latest(), version_test_gt(), and version_test_numeric(). Remove those unused helper functions. Using those helper functions is what caused the quadratic sorting performance issues in the first place, so removing them is a net win. Signed-off-by: Mathieu

[PATCH v5 1/5] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-06-09 Thread Mathieu Desnoyers
each menu entry item. Therefore, the algorithm proposed has O(n*log(n)) complexity with GNU coreutils' sort compared to the prior O(n^2) complexity. Moreover, the constant time required for each list entry is much less because sorting is done within a single execution of sort(1) rather than requiring

[PATCH v5 3/5] grub-mkconfig hurd: Fix quadratic algorithm for sorting menu items

2022-06-09 Thread Mathieu Desnoyers
ho can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a Hurd environment could test it before it is merged. ] Signed-off-by: Mathieu Des

[PATCH v5 0/5] grub-mkconfig: Fix quadratic algorithm for sorting menu items

2022-06-09 Thread Mathieu Desnoyers
This series of patches fixes a O(n^2) algorithm in the menu items generation scripts. Testing is still needed on linux_xen, hurd, and kfreebsd. Mathieu Mathieu Desnoyers (5): grub-mkconfig linux: Fix quadratic algorithm for sorting menu items grub-mkconfig linux_xen: Fix quadratic algorithm

[PATCH v5 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items

2022-06-09 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a Xen environment could test it before it is merged. ] Signed-

Re: [lttng-dev] [PATCH] Use lu% instead ld% to print count

2022-06-09 Thread Mathieu Desnoyers via lttng-dev
obal %lu\n", count); > /* >* Don't shrink table if the number of nodes is below a >* certain threshold. > -- > 2.27.0 > ___ > lttng-dev mailing list > lttng-dev@lists.lttng.org > htt

[lttng-dev] [RELEASE] LTTng-UST 2.13.3 and 2.12.5 (Linux user-space tracer)

2022-06-03 Thread Mathieu Desnoyers via lttng-dev
() leaves byte order uninitialized Thanks, Mathieu Project website: https://lttng.org Documentation: https://lttng.org/docs Download link: https://lttng.org/download -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng

[lttng-dev] [RELEASE] LTTng-modules 2.13.4 and 2.12.9 (Linux kernel tracer)

2022-06-03 Thread Mathieu Desnoyers via lttng-dev
cs Download link: https://lttng.org/download -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions

2022-05-30 Thread Mathieu Desnoyers
- On May 27, 2022, at 10:56 AM, Robbie Harwood rharw...@redhat.com wrote: > Michael Chang via Grub-devel writes: > >> On Thu, May 26, 2022 at 05:07:11PM -0400, Robbie Harwood wrote: >>> Mathieu Desnoyers writes: >>> >>>> There are no users left

Re: [RFC PATCH v3 1/5] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-26 Thread Mathieu Desnoyers
- On May 26, 2022, at 11:13 AM, Daniel Kiper dki...@net-space.pl wrote: > On Fri, May 20, 2022 at 10:37:37AM -0400, Mathieu Desnoyers wrote: >> The current implementation of the 10_linux script implements its menu >> items sorting in bash with a quadratic algorithm, calli

[RFC PATCH v3 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items

2022-05-21 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a Xen environment could test it before it is merged. ] Signed-

Re: [RFC PATCH v3 0/5] grub-mkconfig: Fix quadratic algorithm for sorting menu items

2022-05-20 Thread Mathieu Desnoyers
Sorry, the subject prefix for this patch series should have been [RFC PATCH v4 n/5]. - On May 20, 2022, at 10:37 AM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > This series of patches fixes a O(n^2) algorithm in the menu items > generation scripts. > > Test

[RFC PATCH v3 4/5] grub-mkconfig kfreebsd: Fix quadratic algorithm for sorting menu items

2022-05-20 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a kfreebsd environment could test it before it is merged. ] Signed-o

[RFC PATCH v3 5/5] Cleanup: grub-mkconfig_lib: remove unused version comparison functions

2022-05-20 Thread Mathieu Desnoyers
There are no users left of version_find_latest(), version_test_gt(), and version_test_numeric(). Remove those unused helper functions. Using those helper functions is what caused the quadratic sorting performance issues in the first place, so removing them is a net win. Signed-off-by: Mathieu

[RFC PATCH v3 2/5] grub-mkconfig linux_xen: Fix quadratic algorithm for sorting menu items

2022-05-20 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a Xen environment could test it before it is merged. ] Sign

[RFC PATCH v3 4/5] grub-mkconfig kfreebsd: Fix quadratic algorithm for sorting menu items

2022-05-20 Thread Mathieu Desnoyers
lopers who can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a kfreebsd environment could test it before it is merged. ] Sign

[RFC PATCH v3 0/5] grub-mkconfig: Fix quadratic algorithm for sorting menu items

2022-05-20 Thread Mathieu Desnoyers
This series of patches fixes a O(n^2) algorithm in the menu items generation scripts. Testing is still needed on linux_xen, hurd, and kfreebsd. Mathieu Mathieu Desnoyers (5): grub-mkconfig linux: Fix quadratic algorithm for sorting menu items grub-mkconfig linux_xen: Fix quadratic algorithm

[RFC PATCH v3 3/5] grub-mkconfig hurd: Fix quadratic algorithm for sorting menu items

2022-05-20 Thread Mathieu Desnoyers
ho can easily end up with 50-100 kernels in their boot partition. This fix is ported from the 10_linux script, which has a similar quadratic code pattern. [ Note: this is untested. I would be grateful if anyone with a Hurd environment could test it before it is merged. ] Signed-off-by: Mathieu D

[RFC PATCH v3 1/5] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-20 Thread Mathieu Desnoyers
each menu entry item. Therefore, the algorithm proposed has O(n*log(n)) complexity with GNU coreutils' sort compared to the prior O(n^2) complexity. Moreover, the constant time required for each list entry is much less because sorting is done within a single execution of sort(1) rather than requirin

Re: [PATCH v3] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-20 Thread Mathieu Desnoyers
- On May 20, 2022, at 7:01 AM, Daniel Kiper dki...@net-space.pl wrote: > On Thu, May 19, 2022 at 04:52:54PM -0400, Mathieu Desnoyers wrote: >> - On May 19, 2022, at 2:36 PM, Daniel Kiper dki...@net-space.pl wrote: >> [...] >> > >> > Could you do the sa

Re: [PATCH v3] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-19 Thread Mathieu Desnoyers
sted by those who have those environments ? > > Did you consider Oskari's comment sent in the other email? I just did, sorry for the delay, I missed his email because it was only sent to the list. Thanks, Mathieu > > Daniel -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ Grub-devel mailing list Grub-devel@gnu.org https://lists.gnu.org/mailman/listinfo/grub-devel

Re: [PATCH v3] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-19 Thread Mathieu Desnoyers
- On May 5, 2022, at 7:02 PM, Oskari Pirhonen xxc3ncore...@gmail.com wrote: > On Thu, May 05, 2022 at 10:24:56AM -0400, Mathieu Desnoyers wrote: [...] > > Instead of creating a separate function, would it be better to let > `version_sort()` accept an argument/set

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-19 Thread Mathieu Desnoyers
- On May 3, 2022, at 1:15 PM, Mihai Moldovan io...@ionic.de wrote: > Just a nit, feel free to ignore it... > > > * On 5/3/22 4:42 PM, Mathieu Desnoyers wrote: >> How does the following paragraph sound ? >> >> >> Here is the improved algorit

Re: [lttng-dev] [PATCH] sched/tracing: fix __trace_sched_switch_state (5.18-rc7+)

2022-05-19 Thread Mathieu Desnoyers via lttng-dev
ctf_integer(long, prev_state, > __trace_sched_switch_state(preempt, prev_state, > prev)) > + ctf_integer(long, prev_state, > __trace_sched_switch_state(preempt, prev, next, > prev_state)) > #endif > ctf_array_t

[PATCH v3] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-05 Thread Mathieu Desnoyers
sub-shells. I notice that the same quadratic sorting is done for other supported OSes, so I suspect similar gains can be obtained there, but I limit the scope of this patch to Linux because this is the platform on which I can test. Signed-off-by: Mathieu Desnoyers --- Changes since v1: - Esc

Re: [PATCH v2] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-05 Thread Mathieu Desnoyers
- On May 5, 2022, at 9:53 AM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On May 4, 2022, at 11:24 AM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: > >> - On May 4, 2022, at 10:43 AM, Robbie Harwood rharw...@redhat.com wrote: >>

Re: [PATCH v2] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-05 Thread Mathieu Desnoyers
- On May 4, 2022, at 11:24 AM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > - On May 4, 2022, at 10:43 AM, Robbie Harwood rharw...@redhat.com wrote: > >> Mathieu Desnoyers writes: >> >>> +version_reverse_sort () >>> +{ >>

Re: [PATCH v2] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-04 Thread Mathieu Desnoyers
- On May 4, 2022, at 10:43 AM, Robbie Harwood rharw...@redhat.com wrote: > Mathieu Desnoyers writes: > >> +version_reverse_sort () >> +{ >> + case $version_reverse_sort_sort_has_v in > > Does this need to be its own variable, or could it just reuse > vers

[PATCH v2] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Mathieu Desnoyers
e that the same quadratic sorting is done for other supported OSes, so I suspect similar gains can be obtained there, but I limit the scope of this patch to Linux because this is the platform on which I can test. Signed-off-by: Mathieu Desnoyers --- Changes since v1: - Escape the dot from .ol

Re: [PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-03 Thread Mathieu Desnoyers
- On May 3, 2022, at 4:47 AM, Paul Menzel pmen...@molgen.mpg.de wrote: > Dear Mathieu, > > > Am 02.05.22 um 16:14 schrieb Mathieu Desnoyers: >> The current implementation of the 10_linux script implements its menu >> items sorting in bash with a quadratic algorit

[PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-05-02 Thread Mathieu Desnoyers
obtained there, but I limit the scope of this patch to Linux because this is the platform on which I can test. Signed-off-by: Mathieu Desnoyers --- util/grub-mkconfig_lib.in | 18 ++ util/grub.d/10_linux.in | 12 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/

[RFC PATCH] grub-mkconfig linux: Fix quadratic algorithm for sorting menu items

2022-04-29 Thread Mathieu Desnoyers
I limit the scope of this patch to Linux because this is the platform on which I can test. Signed-off-by: Mathieu Desnoyers --- util/grub-mkconfig_lib.in | 18 ++ util/grub.d/10_linux.in | 12 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/util/grub-m

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-25 Thread Mathieu Desnoyers via lttng-dev
- On Apr 25, 2022, at 10:04 AM, Steven Rostedt rost...@goodmis.org wrote: > On Fri, 8 Apr 2022 14:06:53 -0400 (EDT) > Mathieu Desnoyers wrote: >> >> Indeed, the fact that the TP_fast_assign snippets are embedded in the >> trace_event_raw_event_* symbols is an is

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-25 Thread Mathieu Desnoyers via lttng-dev
- On Apr 8, 2022, at 2:06 PM, Mathieu Desnoyers via lttng-dev lttng-dev@lists.lttng.org wrote: > - On Apr 8, 2022, at 12:24 PM, Paolo Bonzini pbonz...@redhat.com wrote: > >> On 4/8/22 17:36, Mathieu Desnoyers wrote: >>> LTTng is an out of tree kernel module, w

Re: [lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-08 Thread Mathieu Desnoyers via lttng-dev
- On Apr 8, 2022, at 12:24 PM, Paolo Bonzini pbonz...@redhat.com wrote: > On 4/8/22 17:36, Mathieu Desnoyers wrote: >> LTTng is an out of tree kernel module, which currently relies on the export. >> Indeed, arch/x86/kvm/x86.c exports a set of tracepoints to kernel m

[lttng-dev] Unexport of kvm_x86_ops vs tracer modules

2022-04-08 Thread Mathieu Desnoyers via lttng-dev
s. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[lttng-dev] [RELEASE] LTTng-UST 2.13.2 and 2.12.4 (Linux user-space tracer)

2022-03-25 Thread Mathieu Desnoyers via lttng-dev
ite: https://lttng.org Documentation: https://lttng.org/docs Download link: https://lttng.org/download -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[lttng-dev] [RELEASE] LTTng-modules 2.13.3 and 2.12.8 (Linux kernel tracer)

2022-03-25 Thread Mathieu Desnoyers via lttng-dev
Feedback is welcome! Thanks, Mathieu Project website: https://lttng.org Documentation: https://lttng.org/docs Download link: https://lttng.org/download -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list

Re: [lttng-dev] getting lttng-modules to work on archlinux?

2022-03-18 Thread Mathieu Desnoyers via lttng-dev
rminal=/dev/pts/6 res=success' > [16247.424446] Spectre V2 : System may be vulnerable to spectre v2 > [16247.424453] lttng_statedump: loading module not compiled with retpoline > compiler. > [16247.424612] lttng_statedump: Unknown symbol wrapper_kallsyms_lookup_name > (err -2) > [16247.424651] lttng_statedump: Unknown symbol wrapper_irq_to_desc (err -2) > ``` > > Thanks > -- > Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer > KDAB (Deutschland) GmbH, a KDAB Group company > Tel: +49-30-521325470 > KDAB - The Qt, C++ and OpenGL Experts > ___ > lttng-dev mailing list > lttng-dev@lists.lttng.org > https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

Re: [lttng-dev] call trace while using lttng in petalinux 2019.2 (kernel 4.19)

2022-03-16 Thread Mathieu Desnoyers via lttng-dev
- On Mar 16, 2022, at 10:54 AM, lttng-dev lttng-dev@lists.lttng.org wrote: > On 2022-03-16 09:25, Mathieu Desnoyers via lttng-dev wrote: >> An alternative to query the lttng-modules version, if you really cannot >> install modinfo, would >> be: >> >> strin

Re: [lttng-dev] call trace while using lttng in petalinux 2019.2 (kernel 4.19)

2022-03-16 Thread Mathieu Desnoyers via lttng-dev
/modules/$(uname -r)/extra/lttng-tracer.ko | grep "^version=" Thank you, Mathieu > Thank You > with regards > G Madhan Mohan > On Tue, Mar 15, 2022 at 9:19 PM Mathieu Desnoyers < [ > mailto:mathieu.desnoy...@efficios.com | mathieu.desnoy...@efficios.com ] > >

Re: [lttng-dev] Add support for the LOONGARCH architecture

2022-03-15 Thread Mathieu Desnoyers via lttng-dev
Hi, I'm just checking if you have received my message ? I want to understand what is going on here before merging your contribution into liburcu. Thanks, Mathieu - On Jan 25, 2022, at 4:36 PM, Mathieu Desnoyers mathieu.desnoy...@efficios.com wrote: > Hi, > > I notice that the

Re: [lttng-dev] call trace while using lttng in petalinux 2019.2 (kernel 4.19)

2022-03-15 Thread Mathieu Desnoyers via lttng-dev
9.222363] lttng_ring_buffer_client_overwrite: Unknown symbol > lttng_transport_register (err -16) What is the installed lttng-modules version ? You can query it with modinfo /lib/modules/$(uname -r)/extra/lttng-tracer.ko Thanks, Mathieu > Thank You > with regards > G Madhan Mohan > D

Re: [lttng-dev] 回复: 回复:回复: 回复: 回复: 回复: shm leak in traced application?

2022-03-10 Thread Mathieu Desnoyers via lttng-dev
;> 发件人:zhenyu.ren via lttng-dev >> 发送时间:2022年3月10日(星期四) 11:24 >> 收件人:Mathieu Desnoyers >> 抄 送:lttng-dev >> 主 题:[lttng-dev] 回复:回复: 回复: 回复: 回复: shm leak in traced application? >>> When this happpens, is the process holding a single (or very few)

Re: [lttng-dev] 回复: 回复: 回复: 回复: shm leak in traced application?

2022-03-09 Thread Mathieu Desnoyers via lttng-dev
Hi Zhenyu, Can you try this fix please ? https://review.lttng.org/c/lttng-ust/+/7530 And let me know how it goes. Thanks, Mathieu - On Mar 9, 2022, at 11:37 AM, Mathieu Desnoyers wrote: > When this happpens, is the process holding a single (or very few) shm file > refe

Re: [lttng-dev] 回复: 回复: 回复: 回复: shm leak in traced application?

2022-03-09 Thread Mathieu Desnoyers via lttng-dev
leak case. >> ------ >> 发件人:Mathieu Desnoyers >> 发送时间:2022年3月8日(星期二) 23:26 >> 收件人:zhenyu.ren >> 抄 送:Jonathan Rajotte ; lttng-dev >> >> 主 题:Re: [lttng-dev] 回复: 回复: 回复: shm leak in traced application? >> - On Mar

Re: [lttng-dev] 回复: 回复: 回复: shm leak in traced application?

2022-03-08 Thread Mathieu Desnoyers via lttng-dev
ssiond but not always release share memory. >>> Sometimes I >>> need to kill the traced application to free share memoryBut it is not a >> > good idea to kill these applications. >> > My questions are: >>> 1. Is there any way to release share memory with

[lttng-dev] [RELEASE] LTTng-modules 2.13.2 (Linux kernel tracer)

2022-03-07 Thread Mathieu Desnoyers via lttng-dev
truct request (v5.17) * fix: block: remove GENHD_FL_SUPPRESS_PARTITION_INFO (v5.17) * Copyright ownership transfer Project website: https://lttng.org Documentation: https://lttng.org/docs Download link: https://lttng.org/download -- Mathieu Desnoyers EfficiOS Inc. http://www

Re: [lttng-dev] [PATCH] QSBR: Use xor operation to replace add operation when changing rcu_gp.ctr value

2022-02-16 Thread Mathieu Desnoyers via lttng-dev
RED(urcu_qsbr_gp.ctr, urcu_qsbr_gp.ctr ^ URCU_QSBR_GP_CTR); > > /* >* Must commit urcu_qsbr_gp.ctr update to memory before waiting for > -- > 2.27.0 > ___ > lttng-dev mailing list > lttng-dev@lists.lttng.org > https://li

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-14 Thread Mathieu Desnoyers
- On Feb 9, 2022, at 2:02 PM, Waiman Long long...@redhat.com wrote: > On 2/9/22 13:29, Mathieu Desnoyers wrote: >> - On Feb 9, 2022, at 1:19 PM, Waiman Long long...@redhat.com wrote: >> >>> On 2/9/22 04:09, Peter Zijlstra wrote: >>>> On Tue, Feb 08, 20

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-14 Thread Mathieu Desnoyers
module locks, so the tracer can dump this information on trace start and module load. Use-case (b) is very similar to what is done for the kernel tracepoints. Based on this, implementing the init code that iterates on those sections and populates a hash table for use-case (a) should be easy enough. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-14 Thread Mathieu Desnoyers
- On Feb 9, 2022, at 2:22 PM, Namhyung Kim namhy...@kernel.org wrote: > Hello, > > On Wed, Feb 9, 2022 at 11:02 AM Waiman Long wrote: >> >> On 2/9/22 13:29, Mathieu Desnoyers wrote: >> > - On Feb 9, 2022, at 1:19 PM, Waiman Long long...@redhat.com wro

Re: [Intel-gfx] [RFC 00/12] locking: Separate lock tracepoints from lockdep/lock_stat (v1)

2022-02-14 Thread Mathieu Desnoyers
- On Feb 9, 2022, at 2:45 PM, Namhyung Kim namhy...@kernel.org wrote: > On Wed, Feb 9, 2022 at 11:28 AM Mathieu Desnoyers > wrote: >> >> - On Feb 9, 2022, at 2:22 PM, Namhyung Kim namhy...@kernel.org wrote: >> > I'm also concerning dynamic allocated locks in a

Re: [lttng-dev] Add support for the LOONGARCH architecture

2022-01-25 Thread Mathieu Desnoyers via lttng-dev
gt; > - On Jan 24, 2022, at 3:02 AM, 张文龙 zhangwenl...@loongson.cn wrote: > >> I'm glad the new architecture can be accepted,At present, our machines are in >> short supply.I need to go through a very complicated process to provide >> machines, Can qemu emulator work? >&

Re: [lttng-dev] Add support for the LOONGARCH architecture

2022-01-24 Thread Mathieu Desnoyers via lttng-dev
ent, our machines are in > short supply.I need to go through a very complicated process to provide > machines, Can qemu emulator work? > > > -原始邮件- > 发件人: "Mathieu Desnoyers" > 发送时间: 2022-01-20 23:59:52 (星期四) > 收件人: "张文龙" >

Re: [lttng-dev] Add support for the LOONGARCH architecture

2022-01-20 Thread Mathieu Desnoyers via lttng-dev
; lttng-dev mailing list > lttng-dev@lists.lttng.org > https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[lttng-dev] [PATCH lttng-tools] Copyright ownership transfer

2022-01-20 Thread Mathieu Desnoyers via lttng-dev
Apply copyright ownership transfer from Jonathan Rajotte-Julien and Olivier Cotte to EfficiOS Inc. Link: https://lists.lttng.org/pipermail/lttng-dev/2022-January/030111.html Link: https://lists.lttng.org/pipermail/lttng-dev/2022-January/030113.html Signed-off-by: Mathieu Desnoyers Cc: Olivier

Re: [lttng-dev] Transfer of LTTng copyright ownership: Olivier Cotte

2022-01-20 Thread Mathieu Desnoyers via lttng-dev
> Wish you all best of luck with this work, > Best, > Olivier > From: Mathieu Desnoyers > Sent: January 20, 2022 11:20 AM > To: Olivier Moussavou Cotte > Cc: Jeremie Galarneau ; Jonathan Rajotte-Julien > ; lttng-dev > Subject: Transfer of LTTng copyright owne

[lttng-dev] Transfer of LTTng copyright ownership: Jonathan Rajotte-Julien

2022-01-20 Thread Mathieu Desnoyers via lttng-dev
Rajotte Thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

[lttng-dev] Transfer of LTTng copyright ownership: Olivier Cotte

2022-01-20 Thread Mathieu Desnoyers via lttng-dev
in the lttng-tools project: Copyright (C) 2014 Olivier Cotte Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com ___ lttng-dev mailing list lttng-dev@lists.lttng.org https://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev

<    1   2   3   4   5   6   7   8   9   10   >