philnik777 wrote:
@ZequanWu I can't successfully build your reproducer with clang trunk. Would it
be possible to provide the full test case or a fully reduced one?
https://github.com/llvm/llvm-project/pull/93113
___
cfe-commits mailing list
philnik777 wrote:
@ZequanWu Could you give me a reproducer? Ther CI failure looks pretty
unrelated to me, since it complains about LeakSanitizer. The next build was
also green.
https://github.com/llvm/llvm-project/pull/93113
___
cfe-commits mailing
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/93113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/93113
>From 3998e9a8e130677f5932b744c0f4487861a54710 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Thu, 23 May 2024 01:48:06 +0200
Subject: [PATCH] [Clang] Fix __is_trivially_equality_comparable returning
@@ -1126,9 +1126,6 @@ class QualType {
/// Return true if this is a trivially relocatable type.
bool isTriviallyRelocatableType(const ASTContext ) const;
- /// Return true if this is a trivially equality comparable type.
- bool isTriviallyEqualityComparableType(const
@@ -392,6 +392,10 @@ Non-comprehensive list of changes in this release
- ``#pragma GCC diagnostic warning "-Wfoo"`` can now downgrade ``-Werror=foo``
errors and certain default-to-error ``-W`` diagnostics to warnings.
+- Clang now emits distinct type-based alias analysis
https://github.com/philnik777 commented:
First of all I want to say that this is a really cool project, especially the
type sanitizer part. Thanks for working on this!
> Just updated the tysan branches again. Unfortunately we aren't yet at a point
> where LLVM is `tysan` clean, there is a
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/76612
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1126,9 +1126,6 @@ class QualType {
/// Return true if this is a trivially relocatable type.
bool isTriviallyRelocatableType(const ASTContext ) const;
- /// Return true if this is a trivially equality comparable type.
- bool isTriviallyEqualityComparableType(const
@@ -1126,9 +1126,6 @@ class QualType {
/// Return true if this is a trivially relocatable type.
bool isTriviallyRelocatableType(const ASTContext ) const;
- /// Return true if this is a trivially equality comparable type.
- bool isTriviallyEqualityComparableType(const
@@ -1126,9 +1126,6 @@ class QualType {
/// Return true if this is a trivially relocatable type.
bool isTriviallyRelocatableType(const ASTContext ) const;
- /// Return true if this is a trivially equality comparable type.
- bool isTriviallyEqualityComparableType(const
@@ -3636,6 +3648,22 @@ def Fmin : FPMathTemplate, LibBuiltin<"math.h"> {
let OnlyBuiltinPrefixedAliasIsConstexpr = 1;
}
+def FmaximumNum : FPMathTemplate, LibBuiltin<"math.h"> {
philnik777 wrote:
In that case this should probably be a `GNULibBuiltin`. Or
@@ -3636,6 +3648,22 @@ def Fmin : FPMathTemplate, LibBuiltin<"math.h"> {
let OnlyBuiltinPrefixedAliasIsConstexpr = 1;
}
+def FmaximumNum : FPMathTemplate, LibBuiltin<"math.h"> {
philnik777 wrote:
Why is this a libbuiltin? IIUC this is only supposed to be
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/95470
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/95470
>From ee78c1e22b81ef3beb4e28e4ea778ab3a80b1f2d Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Thu, 13 Jun 2024 22:24:17 +0200
Subject: [PATCH] [Clang] Avoid opening namespace std
---
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/95470
Never opening `namespace std` avoids even the possibility of introducing new
symbols as well as making the code a bit shorter by removing unnecessary boiler
plate.
>From
philnik777 wrote:
gentle ping
https://github.com/llvm/llvm-project/pull/93113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
This is really sweet. However, I feel like this is a property that needs to
propagate through types. We can't guarantee that a `std::vector>` doesn't escape the pointer. Similarly, I think we'd
like
```c++
struct my_pair {
int i;
std::string str;
};
```
to have this
philnik777 wrote:
FYI in the libc++ CI we've been running the LLDB tests for a few months now and
I haven't seen a single unrelated failure.
https://github.com/llvm/llvm-project/pull/94208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/93113
>From d1507bf2be71940c795925cdc8159cbc90b17f0d Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Thu, 23 May 2024 01:48:06 +0200
Subject: [PATCH] [Clang] Fix __is_trivially_equality_comparable returning
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/93113
>From cabff5972424393e9d76bce4f8015ceed331a5f9 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Thu, 23 May 2024 01:48:06 +0200
Subject: [PATCH] [Clang] Fix __is_trivially_equality_comparable returning
https://github.com/philnik777 ready_for_review
https://github.com/llvm/llvm-project/pull/93113
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/93113
>From 31e334643e7b4fa4a87c8d15efab4036306d Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Thu, 23 May 2024 01:48:06 +0200
Subject: [PATCH] [Clang] Fix __is_trivially_equality_comparable returning
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/93113
This changes `__is_trivially_equality_comparable` to do overload resolution
instead, which fixes a couple of false-positives (and a false-negative as a
drive-by).
Fixes #89293
>From
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/86652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3452,9 +3452,10 @@ def Fmod : FPMathTemplate, LibBuiltin<"math.h"> {
def Frexp : FPMathTemplate, LibBuiltin<"math.h"> {
let Spellings = ["frexp"];
- let Attributes = [NoThrow];
+ let Attributes = [NoThrow, Constexpr];
philnik777 wrote:
This also
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/86652
>From 90f88bdac3dc40635c58f3f67e29354e6a32896e Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 26 Mar 2024 12:23:24 +0100
Subject: [PATCH] [Clang] Fix __is_array returning true for zero-sized arrays
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/86652
>From 90f88bdac3dc40635c58f3f67e29354e6a32896e Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 26 Mar 2024 12:23:24 +0100
Subject: [PATCH] [Clang] Fix __is_array returning true for zero-sized arrays
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/86652
>From 90f88bdac3dc40635c58f3f67e29354e6a32896e Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 26 Mar 2024 12:23:24 +0100
Subject: [PATCH] [Clang] Fix __is_array returning true for zero-sized arrays
philnik777 wrote:
I don't understand why the order of emitted instructions changes based on how
exactly Clang is compiled, but other than that this should be ready. Hopefully
someone spots what the problem could be.
https://github.com/llvm/llvm-project/pull/91306
https://github.com/philnik777 ready_for_review
https://github.com/llvm/llvm-project/pull/91306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/91306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
I'm not sure a crash is ever expected, but it's a known issue.
https://github.com/llvm/llvm-project/pull/73376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
@AaronBallman Any thoughts on how we should proceed here?
https://github.com/llvm/llvm-project/pull/86652
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/91306
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
Note that this is also a problem with an implicit assignment operator:
https://godbolt.org/z/jrh5novMo. I'm not 100% sure it's not a bug, but it
definitely looks to me like one. It's definitely a mismatch between C++03 and
C++11, which I wouldn't expect given that `= delete`
@@ -14638,6 +14649,8 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr
*E) {
return true;
}
+ case Builtin::BIfmin:
+ case Builtin::BIfminf:
philnik777 wrote:
How would that help?
https://github.com/llvm/llvm-project/pull/88978
@@ -14638,6 +14649,8 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr
*E) {
return true;
}
+ case Builtin::BIfmin:
+ case Builtin::BIfminf:
philnik777 wrote:
These have to be made `constexpr`, at least in C++23. C++ stdlibs can't
override
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?= ,
Pol Marcet =?utf-8?q?Sardà?=
Message-ID:
In-Reply-To:
philnik777 wrote:
I just wanted to say thanks for working on this. I'd love to enable the
vectorization branches in libc++ during constant
philnik777 wrote:
@AaronBallman thanks for picking this up! I agree with @cor3ntin and @ldionne
that we should provide the macros unconditionally. This brings us one step
closer to finally making libc++ fully conforming in C++17. With the PSTL
finally making steady progress, we're probably
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/88528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/88528
>From 0c9372749f4b2d52deddea82be4e77524a66a348 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 12 Apr 2024 17:36:53 +0200
Subject: [PATCH] [Clang] Fix __is_trivially_equaltiy_comparable
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/88654
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/88654
Reverts llvm/llvm-project#87361
On 32 bit platforms there is only a single bit available in the `DeclCtx`,
resulting in an assertion failure.
>From b243ca1d3616d1dd61b81e3a112707e27cd4c865 Mon Sep 17
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/87361
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/87361
>From b8a626116b0719c1acf75e9e7300df8e2bf82f99 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 2 Apr 2024 18:00:05 +0200
Subject: [PATCH 1/3] [Clang] Reduce the size of Decl and classes derived from
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/88631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/87361
>From b8a626116b0719c1acf75e9e7300df8e2bf82f99 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 2 Apr 2024 18:00:05 +0200
Subject: [PATCH 1/3] [Clang] Reduce the size of Decl and classes derived from
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/88528
Currently `__is_trivially_equality_comparable` is documented to return true if
comparing the value representation is equivalent to calling the comparison
operator, which is not quite what the trait actually
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/87361
>From b8a626116b0719c1acf75e9e7300df8e2bf82f99 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 2 Apr 2024 18:00:05 +0200
Subject: [PATCH 1/3] [Clang] Reduce the size of Decl and classes derived from
https://github.com/philnik777 approved this pull request.
LGTM from my side. I'll leave the conformance test details to the folks who
know what they're doing.
https://github.com/llvm/llvm-project/pull/88161
___
cfe-commits mailing list
philnik777 wrote:
> > Note that
> > ```c++
> > auto div(_Complex float lhs, _Complex float rhs) {
> > return lhs / rhs;
> > }
> >
> > int main() {
> > return __real div(1.f, 2.f);
> > }
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > will
philnik777 wrote:
Note that
```c++
auto div(_Complex float lhs, _Complex float rhs) {
return lhs / rhs;
}
int main() {
return __real div(1.f, 2.f);
}
```
will fail to link on windows due to `__divsc3` not being available. Similar
programs probably also fail due to other compiler-rt
@@ -268,17 +268,34 @@ class alignas(8) Decl {
/// }
/// void A::f(); // SemanticDC == namespace 'A'
///// LexicalDC == global namespace
- llvm::PointerUnion DeclCtx;
+ llvm::PointerIntPair<
philnik777 wrote:
IDK. I'm personally not
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/87361
>From b8a626116b0719c1acf75e9e7300df8e2bf82f99 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 2 Apr 2024 18:00:05 +0200
Subject: [PATCH 1/2] [Clang] Reduce the size of Decl and classes derived from
philnik777 wrote:
I think clang should reject incomplete types when the standard says so. It
doesn't seem particularly useful to accept some special cases but reject
incomplete types in general. All the traits should probably be audited once. It
looks like Clang has other problematic cases:
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/87361
Class | Old size (in bytes) | New size (in bytes)
--|-|
Decl | 40
philnik777 wrote:
I'd personally be fine with deprecating it. As I said above, we use it in
libc++ for padding inside `string` like
```c++
struct short_string {
;
char padding[sizeof(value_type) - 1];
;
};
```
That could be refactored relatively easily as
```c++
template
struct padding_t
philnik777 wrote:
> Re: there being observable differences between a header in C vs C++ mode,
> that's already a thing.
>
> The definition for `isinf` in math.h is specified to be a macro in C, but
> specified to be a function in C++. We're already doing `#ifdef __cplusplus`
> for that (see
philnik777 wrote:
I mean that `stddef.h` would be modified to provide it as a function instead of
a macro. In C++ it would simply never be a macro.
https://github.com/llvm/llvm-project/pull/86748
___
cfe-commits mailing list
philnik777 wrote:
> I can see WG21 solving this either by removing `unreachable` from `cstddef`
> or by requiring `utility` to guard against the macro via implementation magic
> (personally, I think `utility` should guard against it because of users
> including `stddef.h` directly) and it
philnik777 wrote:
> `unreachable` is morally similar to `offsetof` in that it's a macro interface
> where the implementation can give better results by expanding to a builtin
> than a library is likely to be able to give via a naive implementation, but
> the interfaces _can_ be provided by a
philnik777 wrote:
Another option would be to to not acknowledge zero-sized arrays in the type
traits at all, just like vector types: https://godbolt.org/z/aP685vz8q. That
may be the most consistent stance on this. Basically "It's non-standard and
doesn't fit neatly in any of the standard
philnik777 wrote:
> I wonder if we should be considering making zero-length arrays into a
> non-conforming extension behind a flag? e.g., `-fzero-sized-arrays` and then
> it does report true for `__is_array`, `__is_bounded_array`, and handles
> template specializations, etc as though it were
philnik777 wrote:
> This doesn't leave us with good options, does it? :-(
Not really. Zero-sized arrays should probably have been supported by C++ all
along, but it's too late to change it now.
> I think we need to consider the following things:
>
> * Should `Ty[0]` and `Ty[]` be handled
https://github.com/philnik777 approved this pull request.
LGTM with the libunwind changes removed.
https://github.com/llvm/llvm-project/pull/86658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
philnik777 wrote:
Yes, it would be the only buildkite one (AFAIK). I don't think that would make
much of a difference though.
https://github.com/llvm/llvm-project/pull/86658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -39,6 +39,9 @@
# if defined(__HAIKU__)
# define _LIBUNWIND_TARGET_HAIKU 1
# endif
+#if defined(__FreeBSD__)
philnik777 wrote:
Are these changes related?
https://github.com/llvm/llvm-project/pull/86658
___
philnik777 wrote:
The C++26 job is part of the first jobs that get run. Did you just miss it, or
do you mean something else?
https://github.com/llvm/llvm-project/pull/86658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
philnik777 wrote:
> > According to the spec it's ill-formed, so I'm not sure it falls under any
> > sensible category.
>
> It's an extension we support so it's up to us to decide what sensible is.
Sure. If we end up putting it in the array category we should probably
coordinate with GCC.
>
philnik777 wrote:
> My primary question is: then what is it?
>
> We return true for `__is_aggregrate` (https://godbolt.org/z/67zjeo7Mj), and
> an aggregate is an array or class type
> (https://eel.is/c++draft/dcl.init.aggr#1). This isn't a class type... but it
> is an aggregate... so it must
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/86652
Fixes #54705
>From 90f88bdac3dc40635c58f3f67e29354e6a32896e Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 26 Mar 2024 12:23:24 +0100
Subject: [PATCH] [Clang] Fix __is_array returning true for
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/73376
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/73376
>From 4d0e485f11fc352ff138268698f776d08c2136b1 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sat, 25 Nov 2023 04:00:57 +0100
Subject: [PATCH] [clang] Accept lambdas in C++03 as an extensions
This is a
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/73376
>From 3caa29d68939fec7fcd11bc699c01a74ab1f7d2a Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sat, 25 Nov 2023 04:00:57 +0100
Subject: [PATCH] [clang] Accept lambdas in C++03 as an extensions
This is a
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/73376
>From 9bd0146b3f058499b82bdb88fe5bd045c3c07caf Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sat, 25 Nov 2023 04:00:57 +0100
Subject: [PATCH] [clang] Accept lambdas in C++03 as an extensions
This is a
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/85427
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/85427
>From bfc6023d76077217fd4c82a91de6e0c08283ddbc Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 15 Mar 2024 17:28:11 +0100
Subject: [PATCH] Reapply "[clang] Fix crash when declaring invalid lambda
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/85427
This re-applies #74110 with the crashing code disabled in C++03. I'll
try to fix the new crash in it's own patch.
>From 9deb45f9b175ce41698feb685d74720c2397b63e Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/83721
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/84591
>From 634b8e8285b23201d7ad852ae35044d9b89c3c63 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sat, 9 Mar 2024 02:14:36 +0100
Subject: [PATCH] [Clang] Document some of the implementation-defined keywords
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/84591
None
>From 479b0dec7feb17beaccbdc029799f2333d979ce4 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sat, 9 Mar 2024 02:14:36 +0100
Subject: [PATCH] [Clang] Document some of the implementation-defined
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/73376
>From db504f5031b11ff7e28a346db829463fd6883d98 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sat, 25 Nov 2023 04:00:57 +0100
Subject: [PATCH] [clang] Accept lambdas in C++03 as an extensions
This is a
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/73376
>From 73135ec6395a6d3a29725e58b30ecb42249695fe Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sat, 25 Nov 2023 04:00:57 +0100
Subject: [PATCH] [clang] Accept lambdas in C++03 as an extensions
This is a
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/73376
>From 305599596dd5914747687af23a105d2968546ca1 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Sat, 25 Nov 2023 04:00:57 +0100
Subject: [PATCH] [clang] Accept lambdas in C++03 as an extensions
This is a
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/74110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/74110
>From 563f86bddc0ec59b63c6aeffee2342f027c09119 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 1 Dec 2023 18:16:36 +0100
Subject: [PATCH 1/2] [clang] Fix crash when declaring invalid lambda member
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/74110
>From 563f86bddc0ec59b63c6aeffee2342f027c09119 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 1 Dec 2023 18:16:36 +0100
Subject: [PATCH 1/2] [clang] Fix crash when declaring invalid lambda member
philnik777 wrote:
Not right now. I think the first thing to do is moving all the builtins to
tablegen before we can make better use of it, which is going to take a while.
https://github.com/llvm/llvm-project/pull/68324
___
cfe-commits mailing list
philnik777 wrote:
@AaronBallman Thanks for the review. Sorry for responding so late - I've missed
your review.
The tests aren't actually unrelated to the path. This is the file where I
discovered the crash, so I just used it to demonstrate that it's fixed. I'm not
sure how to split things,
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/83723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/83723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/83723
- [Clang][Driver] Merge the different strategies of how libc++ is included
- [Clang][Driver] Add special-casing for including libc++ in C++03
>From 756f80f22744bb0f2bfb81e6c4010054f1279337 Mon Sep 17
https://github.com/philnik777 created
https://github.com/llvm/llvm-project/pull/83721
None
>From 756f80f22744bb0f2bfb81e6c4010054f1279337 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 1 Mar 2024 20:49:30 +0100
Subject: [PATCH] [Clang][Driver] Merge the different strategies of how
philnik777 wrote:
Hm, yeah. I don't think it's worth complicating the parser for a tiny bit of
syntax sugar. I like your idea with a `:` quite a bit. `_ExtVector(bool:4)`
would also be an option. I don't have a strong preference either way. I'd like
to keep it separate from the name though to
philnik777 wrote:
> @philnik777 - thank you for the patch at #68324
You're welcome!
FWIW I'd find a syntax like `_ExtVector` better. The underscore and
upper case to make it clear that it's non-standard and the angle bracket syntax
since it's kind-of a template. This unfortunately doesn't
https://github.com/philnik777 closed
https://github.com/llvm/llvm-project/pull/83065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
philnik777 wrote:
The CI failure is unrelated.
https://github.com/llvm/llvm-project/pull/83065
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/83065
>From 84443dfd39a4a1c567a0e301a3d9892955b9a2fe Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 27 Feb 2024 14:40:42 +0100
Subject: [PATCH] [Clang] Fix __has_cpp_attribute and C++11 attributes with
@@ -1,7 +1,7 @@
-// RUN: %clang_cc1 -std=gnu++17 -fsyntax-only -fms-compatibility -verify %s
-
-void f() {
- // GNU-style attributes are prohibited in this position.
+// RUN: %clang_cc1 -std=gnu++17 -fsyntax-only -fms-compatibility -verify %s
philnik777 wrote:
1 - 100 of 239 matches
Mail list logo