Re: How to stop QEMU punching holes in backing store

On Sat, Jun 29, 2024 at 12:19 AM Nir Soffer wrote: > > On Wed, Jun 19, 2024 at 2:18 PM Nir Soffer wrote: > > On 19 Jun 2024, at 8:54, Justin wrote: > > > >I've run strace and I see calls to fallocate with these flags: > >FALLOC_FL_KEEP_SIZE|FALLOC_

Re: [PATCH v2] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

On Mon, Jul 1, 2024 at 6:13 PM Alberto Garcia wrote: > > This tool converts a disk image to qcow2, writing the result directly > to stdout. This can be used for example to send the generated file > over the network. > > This is equivalent to using qemu-img to convert a file to qcow2 and > then wri

Re: [PATCH v2] scripts/qcow2-to-stdout.py: Add script to write qcow2 images to stdout

On Mon, Jul 1, 2024 at 6:13 PM Alberto Garcia wrote: > > This tool converts a disk image to qcow2, writing the result directly > to stdout. This can be used for example to send the generated file > over the network. > > This is equivalent to using qemu-img to convert a file to qcow2 and > then wri

Re: Strange behavior of qemu-img map: zero/data status depends on fallocated image page cache content

On Sun, Jun 30, 2024 at 5:31 PM Nir Soffer wrote: > > I found a strange behavior in qemu-img map - zero/data status depends on page > cache content. It looks like a kernel issue since qemu-img map is using > SEEK_HOLE/DATA (block/file-posix.c line 3111). > > Tested with lat

Re: backup-discard-source iotest fails on xfs, pass on ext4

On Sat, Jun 29, 2024 at 12:17 AM Nir Soffer wrote: > > While testing > https://lists.nongnu.org/archive/html/qemu-block/2024-06/msg00644.html > I noticed that > this tests is failing also with master > (28b8a57ad63670aa0ce90334523dc552b13b4336). > > The test succeeds with

Re: [PATCH 3/4] iotests: Change imports for Python 3.13

> On 2 Jul 2024, at 17:44, John Snow wrote: > > > > On Tue, Jul 2, 2024 at 7:52 AM Nir Soffer <mailto:nsof...@redhat.com>> wrote: >> On Thu, Jun 27, 2024 at 2:23 AM John Snow > <mailto:js...@redhat.com>> wrote: >> > >> > Python 3.13

Re: [PATCH 3/4] iotests: Change imports for Python 3.13

> On 2 Jul 2024, at 17:44, John Snow wrote: > > > > On Tue, Jul 2, 2024 at 7:52 AM Nir Soffer <mailto:nsof...@redhat.com>> wrote: >> On Thu, Jun 27, 2024 at 2:23 AM John Snow > <mailto:js...@redhat.com>> wrote: >> > >> > Python 3.13

Re: [PATCH 3/4] iotests: Change imports for Python 3.13

On Thu, Jun 27, 2024 at 2:23 AM John Snow wrote: > > Python 3.13 isn't out yet, but it's in beta and Fedora is ramping up to > make it the default system interpreter for Fedora 41. > > They moved our cheese for where ContextManager lives; add a conditional > to locate it while we support both pre-

Re: [PATCH 3/4] iotests: Change imports for Python 3.13

On Thu, Jun 27, 2024 at 2:23 AM John Snow wrote: > > Python 3.13 isn't out yet, but it's in beta and Fedora is ramping up to > make it the default system interpreter for Fedora 41. > > They moved our cheese for where ContextManager lives; add a conditional > to locate it while we support both pre-

Strange behavior of qemu-img map: zero/data status depends on fallocated image page cache content

I found a strange behavior in qemu-img map - zero/data status depends on page cache content. It looks like a kernel issue since qemu-img map is using SEEK_HOLE/DATA (block/file-posix.c line 3111). Tested with latest qemu on kernel 6.9.6-100.fc39.x86_64. I see similar behavior in xfs and ex4 files

Re: How to stop QEMU punching holes in backing store

On Wed, Jun 19, 2024 at 2:18 PM Nir Soffer wrote: > On 19 Jun 2024, at 8:54, Justin wrote: > >I've run strace and I see calls to fallocate with these flags: >FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE > >I've tried passing these options: discard=off,detect-z

backup-discard-source iotest fails on xfs, pass on ext4

While testing https://lists.nongnu.org/archive/html/qemu-block/2024-06/msg00644.html I noticed that this tests is failing also with master (28b8a57ad63670aa0ce90334523dc552b13b4336). The test succeeds with ext4, and fail with xfs. Nir --- Success on ext4: $ TEST_DIR=/data/tetests/qemu-iotests

[PATCH v3 0/2] Consider discard option when writing zeros

was here: https://lists.nongnu.org/archive/html/qemu-block/2024-06/msg00231.html Nir Soffer (2): qemu-iotest/245: Add missing discard=unmap Consider discard option when writing zeros block/io.c| 9 +- tests/qemu-iotests/245| 2

[PATCH v3 1/2] qemu-iotest/245: Add missing discard=unmap

The test works since we punch holes by default even when opening the image without discard=on or discard=unmap. Fix the test to enable discard. --- tests/qemu-iotests/245 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245 index a934c

[PATCH v3 1/2] qemu-iotest/245: Add missing discard=unmap

The test works since we punch holes by default even when opening the image without discard=on or discard=unmap. Fix the test to enable discard. --- tests/qemu-iotests/245 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/245 b/tests/qemu-iotests/245 index a934c

[PATCH v3 2/2] Consider discard option when writing zeros

u.org/archive/html/qemu-discuss/2024-06/msg3.html Signed-off-by: Nir Soffer --- block/io.c| 9 +- tests/qemu-iotests/tests/write-zeroes-unmap | 127 ++ .../qemu-iotests/tests/write-zeroes-unmap.out | 81 +++ 3 files changed

[PATCH v3 2/2] Consider discard option when writing zeros

u.org/archive/html/qemu-discuss/2024-06/msg3.html Signed-off-by: Nir Soffer --- block/io.c| 9 +- tests/qemu-iotests/tests/write-zeroes-unmap | 127 ++ .../qemu-iotests/tests/write-zeroes-unmap.out | 81 +++ 3 files changed

[PATCH v3 0/2] Consider discard option when writing zeros

was here: https://lists.nongnu.org/archive/html/qemu-block/2024-06/msg00231.html Nir Soffer (2): qemu-iotest/245: Add missing discard=unmap Consider discard option when writing zeros block/io.c| 9 +- tests/qemu-iotests/245| 2

Re: [PATCH v2] Consider discard option when writing zeros

On Thu, Jun 27, 2024 at 2:42 PM Kevin Wolf wrote: > Am 26.06.2024 um 18:27 hat Nir Soffer geschrieben: > > On Wed, Jun 26, 2024 at 12:17 PM Daniel P. Berrangé > > > wrote: > > > > > On Mon, Jun 24, 2024 at 06:08:26PM +0200, Kevin Wolf wrote: > > > &g

Re: [PATCH v2] Consider discard option when writing zeros

On Thu, Jun 27, 2024 at 2:42 PM Kevin Wolf wrote: > Am 26.06.2024 um 18:27 hat Nir Soffer geschrieben: > > On Wed, Jun 26, 2024 at 12:17 PM Daniel P. Berrangé > > > wrote: > > > > > On Mon, Jun 24, 2024 at 06:08:26PM +0200, Kevin Wolf wrote: > > > &g

Re: [PATCH v2] Consider discard option when writing zeros

On Wed, Jun 26, 2024 at 12:17 PM Daniel P. Berrangé wrote: > On Mon, Jun 24, 2024 at 06:08:26PM +0200, Kevin Wolf wrote: > > Am 24.06.2024 um 17:23 hat Stefan Hajnoczi geschrieben: > > > On Wed, Jun 19, 2024 at 08:43:25PM +0300, Nir Soffer wrote: > > > > Te

Re: [PATCH v2] Consider discard option when writing zeros

On Wed, Jun 26, 2024 at 12:17 PM Daniel P. Berrangé wrote: > On Mon, Jun 24, 2024 at 06:08:26PM +0200, Kevin Wolf wrote: > > Am 24.06.2024 um 17:23 hat Stefan Hajnoczi geschrieben: > > > On Wed, Jun 19, 2024 at 08:43:25PM +0300, Nir Soffer wrote: > > > > Te

Re: [PATCH v2] Consider discard option when writing zeros

On Wed, Jun 26, 2024 at 11:42 AM Kevin Wolf wrote: > Am 24.06.2024 um 23:12 hat Nir Soffer geschrieben: > > On Mon, Jun 24, 2024 at 7:08 PM Kevin Wolf wrote: > > > > > Am 24.06.2024 um 17:23 hat Stefan Hajnoczi geschrieben: > > > > On Wed, Jun 19, 2024 a

Re: [PATCH v2] Consider discard option when writing zeros

On Wed, Jun 26, 2024 at 11:42 AM Kevin Wolf wrote: > Am 24.06.2024 um 23:12 hat Nir Soffer geschrieben: > > On Mon, Jun 24, 2024 at 7:08 PM Kevin Wolf wrote: > > > > > Am 24.06.2024 um 17:23 hat Stefan Hajnoczi geschrieben: > > > > On Wed, Jun 19, 2024 a

Re: [PATCH v2] Consider discard option when writing zeros

On Mon, Jun 24, 2024 at 7:08 PM Kevin Wolf wrote: > Am 24.06.2024 um 17:23 hat Stefan Hajnoczi geschrieben: > > On Wed, Jun 19, 2024 at 08:43:25PM +0300, Nir Soffer wrote: > > > Tested using: > > > > Hi Nir, > > This looks like a good candidate for the qemu-

Re: [PATCH v2] Consider discard option when writing zeros

On Mon, Jun 24, 2024 at 7:08 PM Kevin Wolf wrote: > Am 24.06.2024 um 17:23 hat Stefan Hajnoczi geschrieben: > > On Wed, Jun 19, 2024 at 08:43:25PM +0300, Nir Soffer wrote: > > > Tested using: > > > > Hi Nir, > > This looks like a good candidate for the qemu-

Re: qemu-img convert: Compression can not be disabled when converting from .qcow2 to .raw

On Fri, Jun 21, 2024 at 5:48 PM Sven Ott wrote: > Hi, I want to mount a VM image to a loop device and give it some excess > space. > > To do so, I download a .qcow2 file, add some 0 bytes with truncate, and > then convert the image from QCOW2 to RAW format with qemu-img convert, > like so: > > ``

Re: [PATCH v2] Consider discard option when writing zeros

On Wed, Jun 19, 2024 at 8:40 PM Nir Soffer wrote: > - Need to run all block tests > Stale note, make check pass

Re: [PATCH v2] Consider discard option when writing zeros

On Wed, Jun 19, 2024 at 8:40 PM Nir Soffer wrote: > - Need to run all block tests > Stale note, make check pass

Re: [PATCH v2] Consider discard option when writing zeros

est.raw discard=unmap - write zeroes unmap 0 /tmp/test.raw Differences: $ diff -u before.out after.out --- before.out 2024-06-19 20:24:09.234083713 +0300 +++ after.out 2024-06-19 20:24:20.526165573 +0300 @@ -3,13 +3,13 @@ 1.0M /tmp/test.raw defaults - write zeroes unmap -0 /tmp/test.raw +

Re: [PATCH v2] Consider discard option when writing zeros

est.raw discard=unmap - write zeroes unmap 0 /tmp/test.raw Differences: $ diff -u before.out after.out --- before.out 2024-06-19 20:24:09.234083713 +0300 +++ after.out 2024-06-19 20:24:20.526165573 +0300 @@ -3,13 +3,13 @@ 1.0M /tmp/test.raw defaults - write zeroes unmap -0 /tmp/test.raw +

[PATCH v2] Consider discard option when writing zeros

his change we punched holes by default. I'm not sure this is a good change in behavior. - Need to run all block tests - Not sure that we have tests covering unmapping, we may need new tests - We may need new tests to cover this change Signed-off-by: Nir Soffer --- Changes since v1: - Replac

[PATCH v2] Consider discard option when writing zeros

his change we punched holes by default. I'm not sure this is a good change in behavior. - Need to run all block tests - Not sure that we have tests covering unmapping, we may need new tests - We may need new tests to cover this change Signed-off-by: Nir Soffer --- Changes since v1: - Replac

Re: How to stop QEMU punching holes in backing store

> On 19 Jun 2024, at 8:54, Justin wrote: > >>I've run strace and I see calls to fallocate with these flags: >>FALLOC_FL_KEEP_SIZE|FALLOC_FL_PUNCH_HOLE >> >>I've tried passing these options: discard=off,detect-zeroes=off but >>this does not help. This is the full set of relevant

Re: [PATCH] block/file-posix: Consider discard flag when opening

> On 19 Jun 2024, at 11:16, Kevin Wolf wrote: > > Am 18.06.2024 um 23:24 hat Nir Soffer geschrieben: >> Set has_discard only when BDRV_O_UNMAP is not set. With this users that >> want to keep their images fully allocated can disable hole punching >> when writin

Re: [PATCH] block/file-posix: Consider discard flag when opening

> On 19 Jun 2024, at 11:16, Kevin Wolf wrote: > > Am 18.06.2024 um 23:24 hat Nir Soffer geschrieben: >> Set has_discard only when BDRV_O_UNMAP is not set. With this users that >> want to keep their images fully allocated can disable hole punching >> when writin

Re: How to stop QEMU punching holes in backing store

On Wed, Jun 5, 2024 at 5:27 PM Justin wrote: > Hi. I'm using QEMU emulator version 5.2.0 on Linux. I am using > thick-provisioned RAW files as the VM backing store. I've found that > QEMU is punching holes in my RAW files (it's replacing some zero > blocks with holes), which means that the number

[PATCH] block/file-posix: Consider discard flag when opening

un by default. We needs tests for keeping images non-sparse. Signed-off-by: Nir Soffer --- block/file-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index be25e35ff6..acac2abadc 100644 --- a/block/file-posix.c +++ b/block

[PATCH] block/file-posix: Consider discard flag when opening

un by default. We needs tests for keeping images non-sparse. Signed-off-by: Nir Soffer --- block/file-posix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index be25e35ff6..acac2abadc 100644 --- a/block/file-posix.c +++ b/block

Re: How to configure the default connection for virsh

On Thu, Apr 18, 2024 at 5:20 PM Daniel P. Berrangé wrote: > On Thu, Apr 18, 2024 at 05:07:24PM +0300, Nir Soffer wrote: > > We are using minikube vms, which require adding the user to to libvirt > > group[1]. > > We use `virsh -c qemu:///system` for debugging these vms

How to configure the default connection for virsh

We are using minikube vms, which require adding the user to to libvirt group[1]. We use `virsh -c qemu:///system` for debugging these vms or related libvirt networks. Using virsh without specifying the '-c' argument is a common mistake that leads to trouble, for example creating the libvirt defaul

[ovirt-users] Re: virt-v2v paused by system after one hour or a bit more

On Thu, Mar 21, 2024 at 7:03 PM Cyril VINH-TUNG wrote: > Hello > > Here's the technique we use : > - create manually the vm on ovirt with same disks (same size that original > but you can choose target type, thin provision or preallocated) > - on any node, force activating the disks to make them

[ovirt-users] Re: virt-v2v paused by system after one hour or a bit more

On Thu, Mar 21, 2024 at 12:44 PM Claus Serbe via Users wrote: > Hi, > > I am migrating some vmware VM's from an NFS Storage via rhv-upload in > virt-v2v, what is working good. > > But now I try to move some bigger VM's with several disks and sadly after > a while (I would guess around an hour) th

[ovirt-users] Re: Create Vm without Storage Domain

On Wed, Mar 20, 2024 at 12:06 PM Shafi Mohammed wrote: > Hi Guys , > > Thanks for the Info . > > I am trying to migrate my data from local to Storage domain . But it > requires twice the effort in terms of space and time to copy the data to > the local file system and then upload the disk to it .

Re: Export checkpoint/bitmap from image on qcow2

the issue when long backup (e.g full backup, or incremental backup with a lot of data) blocks usage of the vm during the backup. You can start/stop/migrate a vm while it is being backed up and the backup can run on another host in the cluster (if using shared storage). Nir > On 12/18/23 18

Re: Export checkpoint/bitmap from image on qcow2

On Thu, Nov 30, 2023 at 4:14 PM João Jandre Paraquetti wrote: > > Hi, all > > I recently started looking into how to create incremental backups using > Libvirt+Qemu. I have already found that, since Libvirt 7.6.0, we can use > the virDomainBackupBegin API to create incremental backups of live VMs

[ovirt-devel] Re: Yuriy about NVMe over fabrics for oVirt

On Thu, Nov 2, 2023 at 4:40 PM Yuriy wrote: > Hi Nir! > > This is Yuriy. > We agreed to continue the subject via email. > So the options are: 1. Using Managed Block Storage (cinderlib) with a driver that supports NVMe/TCP. Lastest oVirt has the needed changes to configure this. Benny and I tes

Re: Is it normal to get bigger qcow2 image after blockcopy?

On Fri, Nov 3, 2023 at 3:25 AM Fangge Jin wrote: > > > On Thu, Nov 2, 2023 at 5:13 PM Fangge Jin wrote: > >> Recently, I found that the disk size of qcow2 image get bigger(from 6.16G >> to 8G in my test) after blockcopy.🔄 ❓🔄 ❓ >> > Sorry, it should be "from 6.16G to 6.64G in my test"here > >>

Re: [PATCH 1/1] block: improve alignment detection and fix 271 test

e test to reflect real world usage? _reset_img 2083k I guess it works with: _reset_img 2084k Commits > commit a6b257a08e3d72219f03e461a52152672fec0612 > Author: Nir Soffer > Date: Tue Aug 13 21:21:03 2019 +0300 > file-posix: Handle undetectable alignme

Re: [PATCH 1/1] block: improve alignment detection and fix 271 test

e test to reflect real world usage? _reset_img 2083k I guess it works with: _reset_img 2084k Commits > commit a6b257a08e3d72219f03e461a52152672fec0612 > Author: Nir Soffer > Date: Tue Aug 13 21:21:03 2019 +0300 > file-posix: Handle undetectable alignme

[ovirt-users] Re: How to obtain vm snapshots status

On Tue, Sep 26, 2023 at 9:07 PM anton.alymov--- via Users wrote: > Hi! I use ovirt rest api to start vm, backup vm and then remove vm. > I start vm, wait for vmstatus up, then start backup, wait for starting, > finalize, wait for succeeded, wait for disk unlock. Looks like backup is > finished h

Re: [Libguestfs] [libnbd PATCH] golang: Bump minimum Go version to 1.17

On Tue, Aug 15, 2023 at 9:53 PM Eric Blake wrote: > On Mon, Aug 14, 2023 at 01:43:37PM -0500, Eric Blake wrote: > > > > +++ b/golang/configure/test.go > > > > @@ -25,8 +25,19 @@ > > > > import ( > > > > "fmt" > > > > "runtime" > > > > + "unsafe" > > > > ) > > > > > > > > +

Re: [Libguestfs] [libnbd PATCH] golang: Bump minimum Go version to 1.17

upport, but is relatively old these days. All other > systems appear unaffected by this bump in requirements, at least if > they can be configured to use developer backports. > > Suggested-by: Nir Soffer > Signed-off-by: Eric Blake > --- > > This replaces > https://l

Re: [Libguestfs] [libnbd PATCH v4 05/25] golang: Change logic of copy_uint32_array

of > int. But we can equally just panic if the count is oversized: our > state machine guarantees that the server's response fits within 64M > bytes (count will be smaller than that, since it is multiple bytes per > extent entry). Good to check this, but not related to changing

[ovirt-users] Re: python sdk4 ovirt 4.5.5.0 master

On Mon, Jul 17, 2023 at 6:29 PM Jorge Visentini wrote: > > Hi. > > I am testing oVirt 4.5.5-0.master.20230712143502.git07e865d650.el8. > > I missed the python scripts to download and upload discs and images... Will > it still be possible to use them or should I consider using Ansible? See https

Re: [Libguestfs] Libnbd asynchronous API with epoll

On Fri, Jul 7, 2023 at 11:59 AM Tage Johansson wrote: > On 7/6/2023 7:06 PM, Nir Soffer wrote: > > - After calling for example aio_notify_read(3), can I know that the next > reading from the file descriptor would block? > > No, you have to call again aio_get_direction() and po

Re: [Libguestfs] Libnbd asynchronous API with epoll

On Wed, Jul 5, 2023 at 3:38 PM Tage Johansson wrote: > As part of the Rust bindings for Libnbd, I try to integrate the > asynchronous (aio_*) functions with Tokio > , the most used asynchronous runtime > in Rust. However, in its eventloop, Tokio uses epoll(7)

[PATCH] libvhost-user: Fix update of signalled_used

d-off-by: Nir Soffer --- subprojects/libvhost-user/libvhost-user.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/subprojects/libvhost-user/libvhost-user.c b/subprojects/libvhost-user/libvhost-user.c index 8fb61e2df2..5f26d2d378 100644 --- a/sub

[Libguestfs] [PATCH libnbd v2] README: Document additional packages

When building from git we need autoconf, automake and libtool. Signed-off-by: Nir Soffer --- Changes sinve v1: - Remove `,` between package namses (Laszlo) README.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index c7166613..7eed0e31 100644 --- a

Re: [Libguestfs] [PATCH libnbd] README: Document additional packages

On Mon, Apr 17, 2023 at 7:38 PM Laszlo Ersek wrote: > > On 4/17/23 18:36, Nir Soffer wrote: > > When building from git we need autoconf, automake and libtool. > > > > Signed-off-by: Nir Soffer > > --- > > README.md | 7 +++ > > 1 file changed, 7 in

[Libguestfs] [PATCH libnbd] README: Document additional packages

When building from git we need autoconf, automake and libtool. Signed-off-by: Nir Soffer --- README.md | 7 +++ 1 file changed, 7 insertions(+) diff --git a/README.md b/README.md index c7166613..42a187c0 100644 --- a/README.md +++ b/README.md @@ -32,10 +32,17 @@ ## License very liberal

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

On Sun, Mar 5, 2023 at 10:42 AM Wouter Verhelst wrote: > > On Fri, Mar 03, 2023 at 04:17:40PM -0600, Eric Blake wrote: > > On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > s-o-b line missed. > > > > I'm not sure if the NBD project has a strict policy on incl

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

On Sun, Mar 5, 2023 at 10:42 AM Wouter Verhelst wrote: > > On Fri, Mar 03, 2023 at 04:17:40PM -0600, Eric Blake wrote: > > On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > s-o-b line missed. > > > > I'm not sure if the NBD project has a strict policy on incl

Re: [Libguestfs] [PATCH v2 1/6] spec: Recommend cap on NBD_REPLY_TYPE_BLOCK_STATUS length

On Sun, Mar 5, 2023 at 10:42 AM Wouter Verhelst wrote: > > On Fri, Mar 03, 2023 at 04:17:40PM -0600, Eric Blake wrote: > > On Fri, Dec 16, 2022 at 10:32:01PM +0300, Vladimir Sementsov-Ogievskiy > > wrote: > > > s-o-b line missed. > > > > I'm not sure if the NBD project has a strict policy on incl

Re: [Libguestfs] [PATCH] docs: Prefer 'cookie' over 'handle'

On Sat, Mar 4, 2023 at 12:15 AM Eric Blake wrote: > > In libnbd, we quickly learned that distinguishing between 'handle' > (verb for acting on an object) and 'handle' (noun describing which > object to act on) could get confusing; we solved it by renaming the > latter to 'cookie'. Copy that appro

Re: [Libguestfs] [PATCH] docs: Prefer 'cookie' over 'handle'

On Sat, Mar 4, 2023 at 12:15 AM Eric Blake wrote: > > In libnbd, we quickly learned that distinguishing between 'handle' > (verb for acting on an object) and 'handle' (noun describing which > object to act on) could get confusing; we solved it by renaming the > latter to 'cookie'. Copy that appro

Re: [Libguestfs] Checksums and other verification

On Thu, Mar 2, 2023 at 10:46 AM Richard W.M. Jones wrote: > > On Mon, Feb 27, 2023 at 07:09:33PM +0200, Nir Soffer wrote: > > On Mon, Feb 27, 2023 at 6:41 PM Richard W.M. Jones > > wrote: > > > I think it would be more useful if (or in addition) it could compute >

Re: [Libguestfs] Checksums and other verification

On Tue, Feb 28, 2023 at 4:13 PM Laszlo Ersek wrote: > > On 2/28/23 12:39, Richard W.M. Jones wrote: > > On Tue, Feb 28, 2023 at 12:24:04PM +0100, Laszlo Ersek wrote: > >> On 2/27/23 17:44, Richard W.M. Jones wrote: > >>> On Mon, Feb 27, 2023 at 08:42:23AM -0600, Eric Blake wrote: > Or intenti

Re: [Libguestfs] Checksums and other verification

On Mon, Feb 27, 2023 at 6:41 PM Richard W.M. Jones wrote: > > On Mon, Feb 27, 2023 at 04:24:33PM +0200, Nir Soffer wrote: > > On Mon, Feb 27, 2023 at 3:56 PM Richard W.M. Jones > > wrote: > > > > > > > > > https://github.com/kubevirt/containerized-

Re: [Libguestfs] Checksums and other verification

On Mon, Feb 27, 2023 at 3:56 PM Richard W.M. Jones wrote: > > > https://github.com/kubevirt/containerized-data-importer/issues/1520 > > Hi Eric, > > We had a question from the Kubevirt team related to the above issue. > The question is roughly if it's possible to calculate the checksum of > an ima

Re: [Libguestfs] [PATCH 1/2] python: Avoid crash if callback parameters cannot be built

On Mon, Feb 20, 2023 at 10:45 AM Laszlo Ersek wrote: > > On 2/17/23 17:52, Eric Blake wrote: > > On Thu, Feb 16, 2023 at 03:09:02PM +0100, Laszlo Ersek wrote: > > >> - Py_BuildValue with the "O" format specifier transfers the new list's > >> *sole* reference (= ownership) to the just-built higher-

[ovirt-users] Re: ImageIO Performance

On Thu, Feb 9, 2023 at 7:03 PM Nir Soffer wrote: > > On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users > wrote: > > > > Hi All, > > > > We backup our VM's with a custom script based on the > > https://github.com/oVirt/python-ovirt-engine-sdk4

[ovirt-users] Re: ImageIO Performance

On Thu, Feb 9, 2023 at 7:03 PM Nir Soffer wrote: > > On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users > wrote: > The easiest way would be to enable debug logs - it will be even slower, > but we will see these logs showing all extents: Using the --debug option Run ba

[ovirt-users] Re: ImageIO Performance

On Mon, Feb 6, 2023 at 10:00 AM Jean-Louis Dupond via Users wrote: > > Hi All, > > We backup our VM's with a custom script based on the > https://github.com/oVirt/python-ovirt-engine-sdk4/blob/main/examples/backup_vm.py > example. > This works fine, but we start to see scaling issues. > > On VM's

Re: [Libguestfs] [libnbd PATCH v2 3/3] nbdsh: Improve --help and initial banner contents.

On Tue, Jan 31, 2023 at 12:34 AM Richard W.M. Jones wrote: > > On Fri, Nov 04, 2022 at 04:18:31PM -0500, Eric Blake wrote: > > Document all options in --help output. If -n is not in use, then > > enhance the banner to print the current state of h, and further tailor > > the advice given on useful

Re: [Libguestfs] [PATCH v2v v2] -o rhv-upload: Improve error message for invalid or missing -os parameter

ges the storage domain name or detaches the domain from the data center in the window after the precheck completes and before the transfer starts. > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > Reported-by: Junqin Zhou > Thanks: Nir Soffer > --- > output/rhv-upload

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain does not exist

On Fri, Jan 27, 2023 at 1:18 PM Nir Soffer wrote: > > On Thu, Jan 26, 2023 at 2:31 PM Richard W.M. Jones wrote: > > > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > > Reported-by: Junqin Zhou > > --- > > output/rhv-upload-precheck.py | 7 +

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain does not exist

On Thu, Jan 26, 2023 at 2:31 PM Richard W.M. Jones wrote: > > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > Reported-by: Junqin Zhou > --- > output/rhv-upload-precheck.py | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/output/rhv-upload-precheck.py b/

Re: [Libguestfs] [PATCH v2v] -o rhv-upload: Give a nicer error if the storage domain

On Thu, Jan 26, 2023 at 2:31 PM Richard W.M. Jones wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1986386 > > My RHV instance is dead at the moment so I didn't do much more than > check this compiles and passes the one test we have. Also I want to > spend as little time as possible on RHV

Re: [PATCH v2 2/5] Support format or cache specific out file

On Tue, Dec 13, 2022 at 8:09 PM Hanna Reitz wrote: > > On 13.12.22 16:56, Nir Soffer wrote: > > On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > >> On 28.11.22 15:15, Nir Soffer wrote: > >>> Extend the test finder to find tests with format (*.o

Re: [PATCH v2 2/5] Support format or cache specific out file

On Tue, Dec 13, 2022 at 8:09 PM Hanna Reitz wrote: > > On 13.12.22 16:56, Nir Soffer wrote: > > On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > >> On 28.11.22 15:15, Nir Soffer wrote: > >>> Extend the test finder to find tests with format (*.o

Re: [PATCH v2 2/5] Support format or cache specific out file

On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > > On 28.11.22 15:15, Nir Soffer wrote: > > Extend the test finder to find tests with format (*.out.qcow2) or cache > > specific (*.out.nocache) out file. This worked before only for the > > numbered tests. > >

Re: [PATCH v2 2/5] Support format or cache specific out file

On Mon, Dec 12, 2022 at 12:38 PM Hanna Reitz wrote: > > On 28.11.22 15:15, Nir Soffer wrote: > > Extend the test finder to find tests with format (*.out.qcow2) or cache > > specific (*.out.nocache) out file. This worked before only for the > > numbered tests. > >

[ovirt-users] Re: How does ovirt handle disks across multiple iscsi LUNs

On Sun, Nov 27, 2022 at 9:11 PM wrote: > A possibly obvious question I can't find the answer to anywhere—how does > ovirt allocate VM disk images when a storage domain has multiple LUNs? Are > these allocated one per LUN, so if e.g. a LUN runs out of space the disks > on that LUN (only) will be u

[PATCH v2 5/5] qemu-img: Speed up checksum

5s ±0.183s | 1.808s ±0.016s | x1.36 | | nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 | [1] raw image full of zeroes [2] raw fedora 35 image with additional random data, 50% full [3] image [2] exported by qemu-nbd via unix socket Signed-off-by: Nir Soffer --- qemu-i

[PATCH v2 1/5] qemu-img.c: Move IO_BUF_SIZE to the top of the file

This macro is used by various commands (compare, convert, rebase) but it is defined somewhere in the middle of the file. I'm going to use it in the new checksum command so lets clean up a bit before that. --- qemu-img.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qemu-img

[PATCH v2 4/5] iotests: Test qemu-img checksum

help debugging in case of failures, the output includes a json map of the test image. Signed-off-by: Nir Soffer --- tests/qemu-iotests/tests/qemu-img-checksum| 63 +++ .../tests/qemu-img-checksum.out.qcow2 | 11 .../tests/qemu-img-checksum.out.raw | 10 +

[PATCH v2 3/5] qemu-img: Add checksum command

blkhash/ [3] Computing checksum for 8T empty image: qemu-img checksum: 3.7s, sha256sum (estimate): 17,749s Signed-off-by: Nir Soffer --- docs/tools/qemu-img.rst | 24 ++ meson.build | 10 ++- meson_options.txt | 2 + qemu-img-cmds.hx| 8 ++ qemu-img.c

[PATCH v2 2/5] Support format or cache specific out file

Extend the test finder to find tests with format (*.out.qcow2) or cache specific (*.out.nocache) out file. This worked before only for the numbered tests. --- tests/qemu-iotests/findtests.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/findtests

[PATCH v2 0/5] Add qemu-img checksum command using blkhash

tml - https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00171.html - https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00173.html Nir Soffer (5): qemu-img.c: Move IO_BUF_SIZE to the top of the file Support format or cache specific out file qemu-img: Add checksum command iote

[PATCH v2 0/5] Add qemu-img checksum command using blkhash

tml - https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00171.html - https://lists.nongnu.org/archive/html/qemu-block/2022-11/msg00173.html Nir Soffer (5): qemu-img.c: Move IO_BUF_SIZE to the top of the file Support format or cache specific out file qemu-img: Add checksum command iote

[PATCH v2 5/5] qemu-img: Speed up checksum

5s ±0.183s | 1.808s ±0.016s | x1.36 | | nbd | 6g | direct| 3.540s ±0.020s | 1.749s ±0.018s | x2.02 | [1] raw image full of zeroes [2] raw fedora 35 image with additional random data, 50% full [3] image [2] exported by qemu-nbd via unix socket Signed-off-by: Nir Soffer --- qemu-i

[PATCH v2 4/5] iotests: Test qemu-img checksum

help debugging in case of failures, the output includes a json map of the test image. Signed-off-by: Nir Soffer --- tests/qemu-iotests/tests/qemu-img-checksum| 63 +++ .../tests/qemu-img-checksum.out.qcow2 | 11 .../tests/qemu-img-checksum.out.raw | 10 +

[PATCH v2 2/5] Support format or cache specific out file

Extend the test finder to find tests with format (*.out.qcow2) or cache specific (*.out.nocache) out file. This worked before only for the numbered tests. --- tests/qemu-iotests/findtests.py | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tests/qemu-iotests/findtests

[PATCH v2 3/5] qemu-img: Add checksum command

blkhash/ [3] Computing checksum for 8T empty image: qemu-img checksum: 3.7s, sha256sum (estimate): 17,749s Signed-off-by: Nir Soffer --- docs/tools/qemu-img.rst | 24 ++ meson.build | 10 ++- meson_options.txt | 2 + qemu-img-cmds.hx| 8 ++ qemu-img.c

[PATCH v2 1/5] qemu-img.c: Move IO_BUF_SIZE to the top of the file

This macro is used by various commands (compare, convert, rebase) but it is defined somewhere in the middle of the file. I'm going to use it in the new checksum command so lets clean up a bit before that. --- qemu-img.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/qemu-img

Re: [PATCH 2/3] iotests: Test qemu-img checksum

On Mon, Nov 7, 2022 at 1:41 PM Hanna Reitz wrote: > On 30.10.22 18:38, Nir Soffer wrote: > > On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote: > > > > On 01.09.22 16:32, Nir Soffer wrote: > > > Add simple tests creating an image with all kinds

Re: [PATCH 2/3] iotests: Test qemu-img checksum

On Mon, Nov 7, 2022 at 1:41 PM Hanna Reitz wrote: > On 30.10.22 18:38, Nir Soffer wrote: > > On Wed, Oct 26, 2022 at 4:31 PM Hanna Reitz wrote: > > > > On 01.09.22 16:32, Nir Soffer wrote: > > > Add simple tests creating an image with all kinds

Re: [PATCH 1/3] qemu-img: Add checksum command

On Mon, Nov 7, 2022 at 12:20 PM Hanna Reitz wrote: > On 30.10.22 18:37, Nir Soffer wrote: > > On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote: > > > > On 01.09.22 16:32, Nir Soffer wrote: > [...] > > > --- > > > docs/tools/qemu-i

Re: [PATCH 1/3] qemu-img: Add checksum command

On Mon, Nov 7, 2022 at 12:20 PM Hanna Reitz wrote: > On 30.10.22 18:37, Nir Soffer wrote: > > On Wed, Oct 26, 2022 at 4:00 PM Hanna Reitz wrote: > > > > On 01.09.22 16:32, Nir Soffer wrote: > [...] > > > --- > > > docs/tools/qemu-i

  1   2   3   4   5   6   7   8   9   10   >