Author: Owen Pan
Date: 2023-10-09T01:09:45-07:00
New Revision: 42c564df2f479efb38e6f02340e370815b439eb1
URL:
https://github.com/llvm/llvm-project/commit/42c564df2f479efb38e6f02340e370815b439eb1
DIFF:
https://github.com/llvm/llvm-project/commit/42c564df2f479efb38e6f02340e370815b439eb1.diff
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?=
Message-ID:
In-Reply-To:
owenca wrote:
See https://github.com/llvm/llvm-project/issues/56636.
https://github.com/llvm/llvm-project/pull/68535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
=?utf-8?q?Bj=C3=B6rn_Sch=C3=A4pers?=
Message-ID:
In-Reply-To:
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68535
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Owen Pan
Date: 2023-10-05T19:24:08-07:00
New Revision: 84cbd9f4ffba17a74516d1afa442568dc54eabb1
URL:
https://github.com/llvm/llvm-project/commit/84cbd9f4ffba17a74516d1afa442568dc54eabb1
DIFF:
https://github.com/llvm/llvm-project/commit/84cbd9f4ffba17a74516d1afa442568dc54eabb1.diff
Author: Owen Pan
Date: 2023-10-05T01:18:49-07:00
New Revision: 8902f12e61aa2d3053ad4d536e36569fc8bc9512
URL:
https://github.com/llvm/llvm-project/commit/8902f12e61aa2d3053ad4d536e36569fc8bc9512
DIFF:
https://github.com/llvm/llvm-project/commit/8902f12e61aa2d3053ad4d536e36569fc8bc9512.diff
owenca wrote:
Reverted in d08fcc817eba.
https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2023-10-03T18:19:23-07:00
New Revision: d08fcc817eba7f0186620688eee73f6d25fa90e8
URL:
https://github.com/llvm/llvm-project/commit/d08fcc817eba7f0186620688eee73f6d25fa90e8
DIFF:
https://github.com/llvm/llvm-project/commit/d08fcc817eba7f0186620688eee73f6d25fa90e8.diff
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
We should also update [this
line](https://github.com/llvm/llvm-project/pull/68154/files#diff-13a957866eda585a177e1d10139b157956e9d82c40d2275b500c2b1bcb2ad8c0R452)
to:
```
assert(Shift > 0 || Changes[i].NewlinesBefore > 0 ||
```
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67955
>From 15d37075331311020020c5741e2432cd3fc0be74 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 1 Oct 2023 23:01:30 -0700
Subject: [PATCH 1/2] [clang-format] Annotate ctors/dtors as CtorDtorDeclName
instead
owenca wrote:
> https://buildkite.com/llvm-project/clang-ci/builds/4275#018af20e-3d3c-4344-b92d-88ac8b09b484
> Tests do not pass?
I saw that but don't know why. Did you have the same failures? I'll push
another commit shortly to trigger buildkite again.
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3447,9 +3447,13 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const {
Tok = Tok->Next) {
if (Tok->Previous->EndsCppAttributeGroup)
AfterLastAttribute = Tok;
-if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line,
@@ -16339,7 +16345,7 @@ TEST_F(FormatTest, ConfigurableSpaceBeforeParens) {
verifyFormat("int f();", SpaceFuncDef);
verifyFormat("void f (int a, T b) {}", SpaceFuncDef);
- verifyFormat("A::A () : a(1) {}", SpaceFuncDef);
+ verifyFormat("A::A() : a(1) {}", SpaceFuncDef);
@@ -3447,9 +3447,13 @@ void
TokenAnnotator::calculateFormattingInformation(AnnotatedLine ) const {
Tok = Tok->Next) {
if (Tok->Previous->EndsCppAttributeGroup)
AfterLastAttribute = Tok;
-if (isFunctionDeclarationName(Style.isCpp(), *Tok, Line,
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/68029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18525,12 +18525,17 @@ TEST_F(FormatTest, AlignConsecutiveAssignments) {
" a_longer_name_for_wrap}};",
Alignment);
- Alignment.ColumnLimit = 60;
+ Alignment = getLLVMStyleWithColumns(60);
+
@@ -18525,12 +18525,17 @@ TEST_F(FormatTest, AlignConsecutiveAssignments) {
" a_longer_name_for_wrap}};",
Alignment);
- Alignment.ColumnLimit = 60;
+ Alignment = getLLVMStyleWithColumns(60);
+
owenca wrote:
Can you add an issue to show the incorrect format before this patch?
https://github.com/llvm/llvm-project/pull/68029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67955
>From 15d37075331311020020c5741e2432cd3fc0be74 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 1 Oct 2023 23:01:30 -0700
Subject: [PATCH] [clang-format] Annotate ctors/dtors as CtorDtorDeclName
instead
After
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67780
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
@tru np! That was my intention anyways.
https://github.com/llvm/llvm-project/pull/67911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67955
After annotating constructors/destructors as FunctionDeclarationName in commit
08630512088, we have seen several issues because ctors/dtors had been treated
differently than functions in aligning, wrapping, and
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67911
Don't remove the outermost parentheses surrounding a return statement
expression when inside a function/lambda that has the decltype(auto) return
type.
Fixed #67892.
>From
Author: Owen Pan
Date: 2023-09-30T02:09:52-07:00
New Revision: 511662b88c36f8d5d02f0b758b15c1b84d4ee6c1
URL:
https://github.com/llvm/llvm-project/commit/511662b88c36f8d5d02f0b758b15c1b84d4ee6c1
DIFF:
https://github.com/llvm/llvm-project/commit/511662b88c36f8d5d02f0b758b15c1b84d4ee6c1.diff
Author: Owen Pan
Date: 2023-09-30T02:03:14-07:00
New Revision: 36c1e568bb4f8e482e3f713c8cb9460c5cf19863
URL:
https://github.com/llvm/llvm-project/commit/36c1e568bb4f8e482e3f713c8cb9460c5cf19863
DIFF:
https://github.com/llvm/llvm-project/commit/36c1e568bb4f8e482e3f713c8cb9460c5cf19863.diff
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67780
>From 40d12f082ac712ea4b967db5a981a9fd08ef7c54 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 29 Sep 2023 02:30:47 -0700
Subject: [PATCH] [clang-format] Fix a bug in mis-annotating arrows
Fixed #66923.
---
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67780
Fixed #66923.
>From 4d65ac64140d39edb70ba64d88971819c2602ea7 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 29 Sep 2023 02:30:47 -0700
Subject: [PATCH] [clang-format] Fix a bug in mis-annotating arrows
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67618
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca resolved
https://github.com/llvm/llvm-project/pull/67518
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -633,9 +637,10 @@ struct FormatToken {
bool canBePointerOrReferenceQualifier() const {
return isOneOf(tok::kw_const, tok::kw_restrict, tok::kw_volatile,
- tok::kw___attribute, tok::kw__Nonnull, tok::kw__Nullable,
+
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67618
Fixed #67604.
>From dfa92b41b74e554157467ea51f5db9dfcec4fcce Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 27 Sep 2023 16:06:48 -0700
Subject: [PATCH] [clang-format] Don't align ctors and dtors with other
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
@HazardyKnusperkeks Np! Really appreciate your prompt reviews of so many
clang-format patches!
https://github.com/llvm/llvm-project/pull/66904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
owenca wrote:
Ping @mydeveloperday @HazardyKnusperkeks @rymiel
https://github.com/llvm/llvm-project/pull/66904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67518
None
>From 44165f4df433a668e4f4c2db730a66ce2acbc64b Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 26 Sep 2023 20:43:55 -0700
Subject: [PATCH] [clang-format] Handle __attribute/__declspec/AttributeMacro
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67396
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67422
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67422
Fixed #67407.
>From 1c74983f9d2a16ab26d64624448df89e5fff87c4 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Tue, 26 Sep 2023 05:17:25 -0700
Subject: [PATCH] [clang-format] Fix a bug in NamespaceEndCommentsFixer
owenca wrote:
> Pinging @owenca.
Waiting for one of @mydeveloperday @HazardyKnusperkeks @rymiel
https://github.com/llvm/llvm-project/pull/66893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67396
>From 3ae647542b80edb47bb2e47e87118be6a1bdbdec Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 25 Sep 2023 23:21:38 -0700
Subject: [PATCH] [clang-format] Split TT_AttributeParen
Replaced TT_AttributeParen
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67396
Replaced TT_AttributeParen with TT_AttributeLParen and TT_AttributeRParen.
>From 32c071771910693e1ba739db32c0de212352e9d8 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 25 Sep 2023 23:21:38 -0700
Subject:
Author: Owen Pan
Date: 2023-09-25T22:20:02-07:00
New Revision: 38dd67c8b3dbce4311e32a68d1100bd9f850c43e
URL:
https://github.com/llvm/llvm-project/commit/38dd67c8b3dbce4311e32a68d1100bd9f850c43e
DIFF:
https://github.com/llvm/llvm-project/commit/38dd67c8b3dbce4311e32a68d1100bd9f850c43e.diff
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67221
>From 8f9df29e1fdfdf49d4a420cc7ec7a28d6bba807f Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 22 Sep 2023 23:47:23 -0700
Subject: [PATCH] [clang-format] Fix a bug in aligning trailing comments
Fixes #67116.
https://github.com/owenca reopened
https://github.com/llvm/llvm-project/pull/67221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2023-09-24T19:25:23-07:00
New Revision: 7db211bda791e4326e380a57a882af20a273
URL:
https://github.com/llvm/llvm-project/commit/7db211bda791e4326e380a57a882af20a273
DIFF:
https://github.com/llvm/llvm-project/commit/7db211bda791e4326e380a57a882af20a273.diff
owenca wrote:
Fixed in ff7e85402280.
https://github.com/llvm/llvm-project/pull/67218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67218
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
LGTM, but please wait for @mydeveloperday.
https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/owenca resolved
https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca resolved
https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca resolved
https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67221
Fixes #67116.
>From 9fa6ed9430896ee9164260227f0791986c750f0f Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 22 Sep 2023 23:47:23 -0700
Subject: [PATCH] [clang-format] Fix a bug in aligning trailing comments
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/67218
None
>From b00e6394bb1fe30be40e040b9201c4f3f1b28cd3 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 22 Sep 2023 21:33:02 -0700
Subject: [PATCH] [clang-format][NFC] Clean up alignTrailingComments()
---
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const
FormatToken ,
if (State.Stack.back().IsInsideObjCArrayLiteral)
return nullptr;
+// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports
+// cannot be split, e.g.
+
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const
FormatToken ,
if (State.Stack.back().IsInsideObjCArrayLiteral)
return nullptr;
+// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports
+// cannot be split, e.g.
+
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2270,7 +2270,18 @@ ContinuationIndenter::createBreakableToken(const
FormatToken ,
if (State.Stack.back().IsInsideObjCArrayLiteral)
return nullptr;
+// The "DPI"/"DPI-C" in SystemVerilog direct programming interface imports
+// cannot be split, e.g.
+
https://github.com/owenca requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
Please wait for @sstwcw. IMO it would be better to disable splitting string
literals after `import`.
https://github.com/llvm/llvm-project/pull/66951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) {
" }\n"
"}",
Style);
- verifyFormat("std::sort(v.begin(), v.end(),\n"
- " [](const auto , const auto ) {\n"
- " return foo.baz <
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/66904
Fixes #66890.
>From 95780df0571c27453b77e893e5020d9b451b0e6d Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 20 Sep 2023 05:56:27 -0700
Subject: [PATCH] [clang-format] Correctly annotate keyword operator
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/66893
Fixes #66857.
>From a03878c28110c26c6119f3c5038640b01df3cfe0 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Wed, 20 Sep 2023 03:54:09 -0700
Subject: [PATCH] [clang-format] Correctly annotate return type of
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -22589,9 +22591,23 @@ TEST_F(FormatTest, FormatsLambdas) {
verifyFormat("Namespace::Foo::Foo(LongClassName bar,\n"
"AnotherLongClassName baz)\n"
": baz{baz}, func{[&] {\n"
- " auto qux = bar;\n"
-
@@ -1955,7 +1955,8 @@ void
ContinuationIndenter::moveStatePastScopeCloser(LineState ) {
void ContinuationIndenter::moveStateToNewBlock(LineState ) {
if (Style.LambdaBodyIndentation == FormatStyle::LBI_OuterScope &&
- State.NextToken->is(TT_LambdaLBrace)) {
+
https://github.com/owenca requested changes to this pull request.
Can you add test cases with `BreakConstructorInitializer` set to `AfterColon`?
https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -22537,10 +22537,12 @@ TEST_F(FormatTest, FormatsLambdas) {
" }\n"
"}",
Style);
- verifyFormat("std::sort(v.begin(), v.end(),\n"
- " [](const auto , const auto ) {\n"
- " return foo.baz <
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66755
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca resolved
https://github.com/llvm/llvm-project/pull/66569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -370,9 +364,9 @@ bool UnwrappedLineParser::parseLevel(const FormatToken
*OpeningBrace,
else if (FormatTok->getType() == TT_MacroBlockEnd)
kind = tok::r_brace;
-auto ParseDefault = [this, OpeningBrace, NextLevelLBracesType, IfKind,
+auto ParseDefault =
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/66569
>From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 15 Sep 2023 21:59:47 -0700
Subject: [PATCH 1/2] [clang-format][NFC] Clean up signatures of some parser
functions
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/65908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest,
UnderstandsRequiresClausesAndConcepts) {
Tokens = annotate("void f() & requires(true) {}");
EXPECT_EQ(Tokens.size(), 12u) << Tokens;
+ EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause);
@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest,
UnderstandsRequiresClausesAndConcepts) {
Tokens = annotate("void f() & requires(true) {}");
EXPECT_EQ(Tokens.size(), 12u) << Tokens;
+ EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause);
@@ -1135,6 +1145,14 @@ TEST_F(TokenAnnotatorTest,
UnderstandsRequiresExpressions) {
EXPECT_TOKEN(Tokens[3], tok::kw_requires, TT_RequiresExpression);
EXPECT_TOKEN(Tokens[4], tok::l_paren, TT_RequiresExpressionLParen);
EXPECT_TOKEN(Tokens[14], tok::l_brace,
https://github.com/owenca commented:
Nits.
https://github.com/llvm/llvm-project/pull/65908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/66569
>From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 15 Sep 2023 21:59:47 -0700
Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser
functions
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/66569
>From 83b81df954391c38c123a116ab5c39acd29a3a87 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 15 Sep 2023 21:59:47 -0700
Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser
functions
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/66569
None
>From d570d3bb4d0bf9a49b51c25857958988329d398f Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 15 Sep 2023 21:59:47 -0700
Subject: [PATCH] [clang-format][NFC] Clean up signatures of some parser
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66354
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca approved this pull request.
https://github.com/llvm/llvm-project/pull/66372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2237,15 +2237,10 @@ ContinuationIndenter::createBreakableToken(const
FormatToken ,
LineState , bool AllowBreak) {
unsigned StartColumn = State.Column - Current.ColumnWidth;
if (Current.isStringLiteral()) {
-// Strings in
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/66372
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2783,17 +2783,17 @@ the configuration (without a prefix: ``Auto``).
const char* x =
"veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongString";
- In C#, Java, and JavaScript:
+ In C# and Java:
.. code-block:: c++
true:
- var x =
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/66354:
>From 73669f7d04070feade2282384478e96b8bc6d727 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 14 Sep 2023 02:59:43 -0700
Subject: [PATCH] [clang-format] Fix a bug in ContinuationIndenter
See
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/66354:
See https://reviews.llvm.org/D136154#3890747 for context.
Fixes part of #58592.
>From 9a15ec3256e2d380d5eb70f0751ea1bb457895dd Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 14 Sep 2023 02:59:43 -0700
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/65933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/65933:
>From 70aafbc4717264205796fa2ea67d78482f9f2a0d Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 11 Sep 2023 01:00:24 -0700
Subject: [PATCH] [clang-format] Fix a bug in annotating `&&` followed by `*`
or `&`
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1101 - 1200 of 1373 matches
Mail list logo
