[flang] [clang] [flang][windows] Add option to link against specific MSVC CRT (PR #70833)

2023-11-01 Thread Reid Kleckner via cfe-commits
rnk wrote: Do we really need to have all 4 variants of the 3 fortran runtime libraries? That's a lot of complexity. Can we pare it down to just static/dynamic? It's also sometimes possible to generate code that works in both the static and dynamic context, depending on what is in those

[clang-tools-extra] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

2023-10-23 Thread Reid Kleckner via cfe-commits
rnk wrote: I think option 1 isn't really a permanent solution. We have lots of clang tools that need to find the resource directory, and it should happen automatically. For option 2, we'd have to reimplement that for every other clang tool that needs to find resources, like LLD as well.

[clang] [Bazel][Clang Tidy] Include builtin headers with clang-tidy (PR #67626)

2023-10-23 Thread Reid Kleckner via cfe-commits
rnk wrote: I think option 1 isn't really a permanent solution. We have lots of clang tools that need to find the resource directory, and it should happen automatically. For option 2, we'd have to reimplement that for every other clang tool that needs to find resources, like LLD as well.

[clang-tools-extra] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-10-19 Thread Reid Kleckner via cfe-commits
@@ -0,0 +1,38 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-10-19 Thread Reid Kleckner via cfe-commits
@@ -0,0 +1,38 @@ +// -*- C++ -*- +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +//

[clang-tools-extra] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-10-19 Thread Reid Kleckner via cfe-commits
@@ -7,6 +7,8 @@ //===--===// #include <__memory/aligned_alloc.h> +#include <__overridable_function> rnk wrote: If this is only needed from files in src/, can the file be moved out of

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-19 Thread Reid Kleckner via cfe-commits
rnk wrote: We can definitely disable delayed template parsing in C++20 mode, I wouldn't argue against that. Whoever actually does the work should decide how much effort they are willing to put in. I'm just saying there are benefits to starting the deprecation clock sooner, since it will

[clang] [Profile] Add binary profile correlation to offload profile metadata at runtime. (PR #69493)

2023-10-19 Thread Reid Kleckner via cfe-commits
rnk wrote: > I think there should be a proper Clang flag to control this, instead of > requiring users to pass internal `-mllvm` flags. (Also the flag should be > well documented.) I believe Zequan did that at one point, but he ran into the problem that Rust and Clang need to agree on the

[clang] [Sema] Add check for bitfield assignments to integral types (PR #69049)

2023-10-19 Thread Reid Kleckner via cfe-commits
@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 -Wconversion -fsyntax-only -verify %s +// RUN: %clang_cc1 -Wbitfield-conversion -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple armebv7-unknown-linux -Wbitfield-conversion \ +// RUN: -fsyntax-only -verify %s +// RUN: %clang_cc1

[clang] [Sema] Add check for bitfield assignments to integral types (PR #69049)

2023-10-19 Thread Reid Kleckner via cfe-commits
@@ -0,0 +1,42 @@ +// RUN: %clang_cc1 -Wconversion -fsyntax-only -verify %s +// RUN: %clang_cc1 -Wbitfield-conversion -fsyntax-only -verify %s +// RUN: %clang_cc1 -triple armebv7-unknown-linux -Wbitfield-conversion \ +// RUN: -fsyntax-only -verify %s +// RUN: %clang_cc1

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-19 Thread Reid Kleckner via cfe-commits
rnk wrote: I still support disabling delayed template parsing by default in all configurations. Ultimately, this feature is a source of bugs, and we should start the clock on its deprecation and removal. This, of course, involves real work, and I haven't allocated any time (mine or others')

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Yep, we are fairly liberal about adding new clang options to the clang-cl mode, especially if they are in the feature `-f` flag namespace, which we believe will not conflict with MSVC flags. https://github.com/llvm/llvm-project/pull/68921

[clang] [Clang][CodeGen] Fix use of CXXThisValue with StrictVTablePointers (PR #68169)

2023-10-04 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. I was going to delegate the review to @aeubanks, who was the last one I'm aware of to touch the strict vptr feature, but I think this is a pretty straightforward fix. https://github.com/llvm/llvm-project/pull/68169

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

2023-10-02 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Yep, looks good to me. https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Default x86-64's medium code model -mlarge-data-threshold to 65535 (PR #67506)

2023-09-28 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/67506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: I wanted to make some minor naming suggestions, and I used the GitHub "edit this file" feature for the first time to commit them as new commits to your branch. I've never done this before, so I don't really know how it works, but clang-format isn't available,

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/7] [clang-cl] Fix for __FUNCTION__ in c++. ---

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/7] [clang-cl] Fix for __FUNCTION__ in c++. ---

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/6] [clang-cl] Fix for __FUNCTION__ in c++. ---

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/6] [clang-cl] Fix for __FUNCTION__ in c++. ---

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/5] [clang-cl] Fix for __FUNCTION__ in c++. ---

[clang-tools-extra] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-21 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/66120 >From 3fcfa303bd211f9a3382657012968cd3f7269db8 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 12 Sep 2023 11:25:19 -0700 Subject: [PATCH 1/5] [clang-cl] Fix for __FUNCTION__ in c++. ---

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

2023-09-20 Thread Reid Kleckner via cfe-commits
rnk wrote: Seems reasonable to me, but I want @efriedma-quic to approve as well, if this is a reasonable implementation of your direction. https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-cl] Fix for __FUNCTION__ in c++. (PR #66120)

2023-09-20 Thread Reid Kleckner via cfe-commits
@@ -2218,6 +2218,9 @@ printTo(raw_ostream , ArrayRef Args, const PrintingPolicy , } else { if (!FirstArg) OS << Comma; + //if (Argument.getKind() == TemplateArgument::Type) + // OS << "class "; + rnk wrote: I would move it into

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

2023-09-20 Thread Reid Kleckner via cfe-commits
rnk wrote: It is true that the MSVC mangler doesn't generally canonicalize types, but I think we can canonicalize in the `mangleTypeName` entry point, because it exists to create unique type names for TBAA and CFI. You can audit the callers, they all relate to either of those two things.

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

2023-09-15 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: This seems fine to me, but it's hard to understand if this is redundant with some other "ParseFunction" scope from the tests. WDYT @MaskRay ? https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing

[clang] [NFC][CodeGen] Change CodeGenOpt::Level/CodeGenFileType into enum classes (PR #66295)

2023-09-14 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-13 Thread Reid Kleckner via cfe-commits
https://github.com/rnk closed https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-13 Thread Reid Kleckner via cfe-commits
https://github.com/rnk resolved https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-13 Thread Reid Kleckner via cfe-commits
@@ -812,11 +815,13 @@ ABIArgInfo X86_32ABIInfo::classifyArgumentType(QualType Ty, CCState , } llvm::IntegerType *PaddingType = NeedsPadding ? Int32 : nullptr; -// Pass over-aligned aggregates on Windows indirectly. This behavior was -// added in MSVC 2015.

[clang-tools-extra] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-13 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-13 Thread Reid Kleckner via cfe-commits
https://github.com/rnk updated https://github.com/llvm/llvm-project/pull/65692: >From 98d560c8057b171c81b43d93c1a0c26f1d27cf5b Mon Sep 17 00:00:00 2001 From: Reid Kleckner Date: Tue, 29 Aug 2023 14:26:10 -0700 Subject: [PATCH 1/2] [MS] Follow up fix to pass aligned args to variadic x86_32

[clang] [clang] Don't inherit dllimport/dllexport to exclude_from_explicit_in… (PR #65961)

2023-09-13 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/65961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][CodeGen] Change CodeGenOpt::{Level, FileType} into enum classes (PR #66295)

2023-09-13 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: Seems reasonable to me. https://github.com/llvm/llvm-project/pull/66295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-12 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk review_requested https://github.com/llvm/llvm-project/pull/65692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MS] Follow up fix to pass aligned args to variadic x86_32 functions (PR #65692)

2023-09-07 Thread Reid Kleckner via cfe-commits
https://github.com/rnk created https://github.com/llvm/llvm-project/pull/65692: MSVC allows users to pass structures with required alignments greater than 4 to variadic functions. It does not pass them indirectly to correctly align them. Instead, it passes them directly with the usual 4 byte

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Reid Kleckner via cfe-commits
@@ -2937,14 +2964,97 @@ void MicrosoftRecordLayoutBuilder::layoutNonVirtualBase( BaseOffset = CharUnits::Zero(); } else { // Otherwise, lay the base out at the end of the MDC. - BaseOffset = Size = Size.alignTo(Info.Alignment); + BaseOffset = DataSize

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Reid Kleckner via cfe-commits
@@ -3055,7 +3195,7 @@ void MicrosoftRecordLayoutBuilder::injectVBPtr(const CXXRecordDecl *RD) { // It is possible that there were no fields or bases located after vbptr, // so the size was not adjusted before. if (Size < FieldStart) - Size = FieldStart; +

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-07 Thread Reid Kleckner via cfe-commits
@@ -4505,6 +4505,14 @@ bool FieldDecl::isZeroSize(const ASTContext ) const { if (!CXXRD->isEmpty()) return false; + // MS ABI: nonzero if class type with class type fields + if (Ctx.getTargetInfo().getCXXABI().isMicrosoft() && + llvm::any_of(CXXRD->fields(),

[clang-tools-extra] ba52a10 - [clang-tidy] Fix test to not depend on D153156, which was reverted

2023-08-22 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2023-08-22T18:39:19-07:00 New Revision: ba52a10fca6fc7b791894c584233db012def68a5 URL: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5 DIFF: https://github.com/llvm/llvm-project/commit/ba52a10fca6fc7b791894c584233db012def68a5.diff

[clang] 0d9919d - Revert "[Clang] CWG1473: do not err on the lack of space after operator"""

2023-08-22 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2023-08-22T18:10:41-07:00 New Revision: 0d9919d362a7a70b2a7970861d897ecc47ec9e4d URL: https://github.com/llvm/llvm-project/commit/0d9919d362a7a70b2a7970861d897ecc47ec9e4d DIFF: https://github.com/llvm/llvm-project/commit/0d9919d362a7a70b2a7970861d897ecc47ec9e4d.diff

[clang] 47d1789 - Add Adrian and David as owners for debug info

2023-07-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2023-07-24T11:11:35-07:00 New Revision: 47d178939e96d388c8d28dff2f937e340f12c31d URL: https://github.com/llvm/llvm-project/commit/47d178939e96d388c8d28dff2f937e340f12c31d DIFF: https://github.com/llvm/llvm-project/commit/47d178939e96d388c8d28dff2f937e340f12c31d.diff

[clang] 651e5ae - [MS] Fix passing aligned records by value in some cases

2023-06-13 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2023-06-13T12:54:23-07:00 New Revision: 651e5ae62d29fdb07eb85f75ab7e686b98479f3a URL: https://github.com/llvm/llvm-project/commit/651e5ae62d29fdb07eb85f75ab7e686b98479f3a DIFF: https://github.com/llvm/llvm-project/commit/651e5ae62d29fdb07eb85f75ab7e686b98479f3a.diff

[clang] 56dc4db - Fix test expectation positioning relative to FIXME comment

2022-06-30 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2022-06-30T14:08:25-07:00 New Revision: 56dc4dbe45e2b1a3e33ab69323ae9d885ab34899 URL: https://github.com/llvm/llvm-project/commit/56dc4dbe45e2b1a3e33ab69323ae9d885ab34899 DIFF: https://github.com/llvm/llvm-project/commit/56dc4dbe45e2b1a3e33ab69323ae9d885ab34899.diff

[clang] 35ab2a1 - Fix a buglet in remove_dots().

2022-06-02 Thread Reid Kleckner via cfe-commits
Author: Paul Pluzhnikov Date: 2022-06-02T11:07:44-07:00 New Revision: 35ab2a11bb55c39ef9fe389aeacc14bb55c5a12d URL: https://github.com/llvm/llvm-project/commit/35ab2a11bb55c39ef9fe389aeacc14bb55c5a12d DIFF:

Re: [clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

2022-02-28 Thread Reid Kleckner via cfe-commits
/put in a std::function or equivalent). Avoids assert/non-assert > unused issues, having to maintain/update the list when the code changes and > makes a capture live/dead/etc. > > On Wed, Feb 23, 2022 at 2:09 PM Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >&g

[clang] 1d1b089 - Fix more unused lambda capture warnings, NFC

2022-02-23 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2022-02-23T14:07:04-08:00 New Revision: 1d1b089c5d503e2fc8697887411730105f66c774 URL: https://github.com/llvm/llvm-project/commit/1d1b089c5d503e2fc8697887411730105f66c774 DIFF: https://github.com/llvm/llvm-project/commit/1d1b089c5d503e2fc8697887411730105f66c774.diff

[clang] cd37594 - Fix unused lambda capture warning, NFC

2022-02-23 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2022-02-23T14:01:01-08:00 New Revision: cd37594c0374f287318d47818cc6d55496d3e9c0 URL: https://github.com/llvm/llvm-project/commit/cd37594c0374f287318d47818cc6d55496d3e9c0 DIFF: https://github.com/llvm/llvm-project/commit/cd37594c0374f287318d47818cc6d55496d3e9c0.diff

[clang] 955dc34 - Fix TargetRegistry shlib build, clang edition

2021-10-08 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-10-08T15:43:56-07:00 New Revision: 955dc3449acd64c0505a3823aa93a6af38b00782 URL: https://github.com/llvm/llvm-project/commit/955dc3449acd64c0505a3823aa93a6af38b00782 DIFF: https://github.com/llvm/llvm-project/commit/955dc3449acd64c0505a3823aa93a6af38b00782.diff

[clang] db3d029 - Effectively revert 33c3d8a916c / D33782

2021-08-25 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-08-25T14:41:26-07:00 New Revision: db3d029fbe09925ea42a3279b1abb244fa547cff URL: https://github.com/llvm/llvm-project/commit/db3d029fbe09925ea42a3279b1abb244fa547cff DIFF: https://github.com/llvm/llvm-project/commit/db3d029fbe09925ea42a3279b1abb244fa547cff.diff

[clang] e42ce42 - [dllexport] Instantiate default ctor default args

2021-08-23 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-08-23T15:56:29-07:00 New Revision: e42ce422a97876e5ecd1c845b12ec65f96f8a293 URL: https://github.com/llvm/llvm-project/commit/e42ce422a97876e5ecd1c845b12ec65f96f8a293 DIFF: https://github.com/llvm/llvm-project/commit/e42ce422a97876e5ecd1c845b12ec65f96f8a293.diff

[clang] 718c632 - Simplify dllexport class member code, NFC

2021-08-11 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-08-11T11:42:20-07:00 New Revision: 718c63258202e8e674c47c9ece16f396065e7c2a URL: https://github.com/llvm/llvm-project/commit/718c63258202e8e674c47c9ece16f396065e7c2a DIFF: https://github.com/llvm/llvm-project/commit/718c63258202e8e674c47c9ece16f396065e7c2a.diff

[clang] f9f5648 - [DebugInfo] Use per-enumerator signedness for DIEnumerator

2021-07-26 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-07-26T16:14:28-07:00 New Revision: f9f56488e02d1c09a9cd4acde61ce1c712e71405 URL: https://github.com/llvm/llvm-project/commit/f9f56488e02d1c09a9cd4acde61ce1c712e71405 DIFF: https://github.com/llvm/llvm-project/commit/f9f56488e02d1c09a9cd4acde61ce1c712e71405.diff

[clang] a9b114c - Disable the new enum i128 test under ASan, it uncovers an existing leak

2021-07-26 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-07-26T15:48:32-07:00 New Revision: a9b114c5dd68685e0e68dd9144454b44509c2f5f URL: https://github.com/llvm/llvm-project/commit/a9b114c5dd68685e0e68dd9144454b44509c2f5f DIFF: https://github.com/llvm/llvm-project/commit/a9b114c5dd68685e0e68dd9144454b44509c2f5f.diff

[clang] 3230493 - Fix clang debug info irgen of i128 enums

2021-07-26 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-07-26T12:25:29-07:00 New Revision: 323049329939becf690adbeeff9f5f7e219075ec URL: https://github.com/llvm/llvm-project/commit/323049329939becf690adbeeff9f5f7e219075ec DIFF: https://github.com/llvm/llvm-project/commit/323049329939becf690adbeeff9f5f7e219075ec.diff

[clang] e32a92c - Remove unnecessary triple from test

2021-06-15 Thread Reid Kleckner via cfe-commits
Author: Yuki Okushi Date: 2021-06-15T09:49:45-07:00 New Revision: e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed URL: https://github.com/llvm/llvm-project/commit/e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed DIFF: https://github.com/llvm/llvm-project/commit/e32a92c6fe8e6dd8ca08b44be12eda6d88c2eaed.diff

[clang] 8f20ac9 - [PGO] Don't reference functions unless value profiling is enabled

2021-05-20 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-05-20T11:09:24-07:00 New Revision: 8f20ac9595c8b279641dace6f212b8a9673b24e4 URL: https://github.com/llvm/llvm-project/commit/8f20ac9595c8b279641dace6f212b8a9673b24e4 DIFF: https://github.com/llvm/llvm-project/commit/8f20ac9595c8b279641dace6f212b8a9673b24e4.diff

[clang] d2f4b7d - Use enum comparison instead of generated switch/case, NFC

2021-05-13 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-05-13T20:26:50-07:00 New Revision: d2f4b7d77828dba831f4b7429a7c970d71eb853b URL: https://github.com/llvm/llvm-project/commit/d2f4b7d77828dba831f4b7429a7c970d71eb853b DIFF: https://github.com/llvm/llvm-project/commit/d2f4b7d77828dba831f4b7429a7c970d71eb853b.diff

[clang] c4adc49 - [SEH] Fix regression with SEH in noexpect functions

2021-05-07 Thread Reid Kleckner via cfe-commits
Author: Olivier Goffart Date: 2021-05-07T13:27:59-07:00 New Revision: c4adc49a1c988e6ea8a340b6245525ef5599812c URL: https://github.com/llvm/llvm-project/commit/c4adc49a1c988e6ea8a340b6245525ef5599812c DIFF:

[clang] 6d78c38 - Move Sema's key function around and add more comments

2021-04-26 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-04-26T18:32:50-07:00 New Revision: 6d78c38986fa0974ea0b37e66f8cb89b256f4e0d URL: https://github.com/llvm/llvm-project/commit/6d78c38986fa0974ea0b37e66f8cb89b256f4e0d DIFF: https://github.com/llvm/llvm-project/commit/6d78c38986fa0974ea0b37e66f8cb89b256f4e0d.diff

[clang] 1c2e7d2 - [MS] Fix crash involving gnu stmt exprs and inalloca

2021-03-04 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-03-04T13:57:46-08:00 New Revision: 1c2e7d200df27e91631ba300965245518bfe252c URL: https://github.com/llvm/llvm-project/commit/1c2e7d200df27e91631ba300965245518bfe252c DIFF: https://github.com/llvm/llvm-project/commit/1c2e7d200df27e91631ba300965245518bfe252c.diff

[clang] e678656 - Add bounds checking assertions to APValue, NFC

2021-01-19 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-01-19T11:15:02-08:00 New Revision: e678656625a3e2b6a5f2849f4a6f7612ceeaed07 URL: https://github.com/llvm/llvm-project/commit/e678656625a3e2b6a5f2849f4a6f7612ceeaed07 DIFF: https://github.com/llvm/llvm-project/commit/e678656625a3e2b6a5f2849f4a6f7612ceeaed07.diff

[clang] 6f69f2e - Consider ASan messages interesting for creduce

2021-01-19 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-01-19T11:15:02-08:00 New Revision: 6f69f2ed61ae805df496fc86ef22e7685573d556 URL: https://github.com/llvm/llvm-project/commit/6f69f2ed61ae805df496fc86ef22e7685573d556 DIFF: https://github.com/llvm/llvm-project/commit/6f69f2ed61ae805df496fc86ef22e7685573d556.diff

[clang] ad55d5c - Simplify vectorcall argument classification of HVAs, NFC

2021-01-07 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2021-01-07T11:14:18-08:00 New Revision: ad55d5c3f32f6598f8ac30b68f4961d82cdb1fed URL: https://github.com/llvm/llvm-project/commit/ad55d5c3f32f6598f8ac30b68f4961d82cdb1fed DIFF: https://github.com/llvm/llvm-project/commit/ad55d5c3f32f6598f8ac30b68f4961d82cdb1fed.diff

[clang] b7905e8 - Fix split-debug.c test on Windows

2020-12-16 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-12-16T13:48:57-08:00 New Revision: b7905e81fc3d7b045a5346442ce92ee87bdb7b21 URL: https://github.com/llvm/llvm-project/commit/b7905e81fc3d7b045a5346442ce92ee87bdb7b21 DIFF: https://github.com/llvm/llvm-project/commit/b7905e81fc3d7b045a5346442ce92ee87bdb7b21.diff

[clang] d2ed9d6 - Revert "ADT: Migrate users of AlignedCharArrayUnion to std::aligned_union_t, NFC"

2020-12-14 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-12-14T17:04:06-08:00 New Revision: d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b URL: https://github.com/llvm/llvm-project/commit/d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b DIFF: https://github.com/llvm/llvm-project/commit/d2ed9d6b7ec6ae837aac0b2d2920c1e34b89d00b.diff

[clang] df28221 - Don't setup inalloca for swiftcc on i686-windows-msvc

2020-12-09 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-12-09T11:08:48-08:00 New Revision: df282215d497e15104ae9e182e083cdfa0bae3c2 URL: https://github.com/llvm/llvm-project/commit/df282215d497e15104ae9e182e083cdfa0bae3c2 DIFF: https://github.com/llvm/llvm-project/commit/df282215d497e15104ae9e182e083cdfa0bae3c2.diff

[clang] d7098ff - De-templatify EmitCallArgs argument type checking, NFCI

2020-12-09 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-12-09T11:08:00-08:00 New Revision: d7098ff29c58dd08ede8314818b7de7fd2fea4cc URL: https://github.com/llvm/llvm-project/commit/d7098ff29c58dd08ede8314818b7de7fd2fea4cc DIFF: https://github.com/llvm/llvm-project/commit/d7098ff29c58dd08ede8314818b7de7fd2fea4cc.diff

[clang] 43b5b48 - Fix GCC 5.3 compile error in ASTImporter code

2020-11-30 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-11-30T16:29:29-08:00 New Revision: 43b5b485a203f190ee4d5d3cab19c44ca865d316 URL: https://github.com/llvm/llvm-project/commit/43b5b485a203f190ee4d5d3cab19c44ca865d316 DIFF: https://github.com/llvm/llvm-project/commit/43b5b485a203f190ee4d5d3cab19c44ca865d316.diff

[clang] 1e843a9 - [MS] Add more 128bit cmpxchg intrinsics for AArch64

2020-11-25 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-11-25T12:07:28-08:00 New Revision: 1e843a987d847da48aaf41801b79cfb364937e8f URL: https://github.com/llvm/llvm-project/commit/1e843a987d847da48aaf41801b79cfb364937e8f DIFF: https://github.com/llvm/llvm-project/commit/1e843a987d847da48aaf41801b79cfb364937e8f.diff

[clang] 3bd0672 - [MS] Fix double evaluation of MSVC builtin arguments

2020-11-25 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-11-25T11:55:01-08:00 New Revision: 3bd06727267184223464f11d4e2470048ac40cb1 URL: https://github.com/llvm/llvm-project/commit/3bd06727267184223464f11d4e2470048ac40cb1 DIFF: https://github.com/llvm/llvm-project/commit/3bd06727267184223464f11d4e2470048ac40cb1.diff

[clang] 09ba206 - Fix compilation issue reported by MSVC user on cfe-dev

2020-11-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-11-24T17:31:25-08:00 New Revision: 09ba2063dc9339957b999c08d3810a3cec2b745b URL: https://github.com/llvm/llvm-project/commit/09ba2063dc9339957b999c08d3810a3cec2b745b DIFF: https://github.com/llvm/llvm-project/commit/09ba2063dc9339957b999c08d3810a3cec2b745b.diff

[clang] 64802d4 - Make check-clang depend on the LLVM split-file utility

2020-11-23 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-11-23T12:21:44-08:00 New Revision: 64802d48d51d651bd2e4567b2f228f8795569542 URL: https://github.com/llvm/llvm-project/commit/64802d48d51d651bd2e4567b2f228f8795569542 DIFF: https://github.com/llvm/llvm-project/commit/64802d48d51d651bd2e4567b2f228f8795569542.diff

[clang] d2e7dca - [CodeGen] Fix Bug 47499: __unaligned extension inconsistent behaviour with C and C++

2020-11-05 Thread Reid Kleckner via cfe-commits
Author: Jan Ole Hüser Date: 2020-11-05T12:57:17-08:00 New Revision: d2e7dca5ca92c655e451d6fcb806df38d7f2d56b URL: https://github.com/llvm/llvm-project/commit/d2e7dca5ca92c655e451d6fcb806df38d7f2d56b DIFF: https://github.com/llvm/llvm-project/commit/d2e7dca5ca92c655e451d6fcb806df38d7f2d56b.diff

[clang] 5fbab40 - [MS] Apply `inreg` to AArch64 sret parms on instance methods

2020-10-15 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-10-15T14:54:42-07:00 New Revision: 5fbab4025eb57b12f2842ab188ff07a110708e1d URL: https://github.com/llvm/llvm-project/commit/5fbab4025eb57b12f2842ab188ff07a110708e1d DIFF: https://github.com/llvm/llvm-project/commit/5fbab4025eb57b12f2842ab188ff07a110708e1d.diff

[clang] 8b6d1c0 - [ADT] Use alignas + sizeof for inline storage, NFC

2020-10-14 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-10-14T16:16:02-07:00 New Revision: 8b6d1c0467b2dfa14cb2d2dec7637bf95c78364b URL: https://github.com/llvm/llvm-project/commit/8b6d1c0467b2dfa14cb2d2dec7637bf95c78364b DIFF: https://github.com/llvm/llvm-project/commit/8b6d1c0467b2dfa14cb2d2dec7637bf95c78364b.diff

[clang] 0ec1cf1 - Revert "DirectoryWatcher: add an implementation for Windows"

2020-10-13 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-10-13T12:35:22-07:00 New Revision: 0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577 URL: https://github.com/llvm/llvm-project/commit/0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577 DIFF: https://github.com/llvm/llvm-project/commit/0ec1cf13f2a4e31aa2c5ccc665c5fbdcd3a94577.diff

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

2020-10-13 Thread Reid Kleckner via cfe-commits
FWIW, I don't see any issues with my two bots that use buildbot annotated commands: http://lab.llvm.org:8011/#/builders/sanitizer-windows http://lab.llvm.org:8011/#/builders/clang-x64-windows-msvc The individual steps don't highlight as green or red, but that's OK for now. On Mon, Oct 12, 2020 at

Re: [Lldb-commits] Upcoming upgrade of LLVM buildbot

2020-10-12 Thread Reid Kleckner via cfe-commits
On Wed, Oct 7, 2020 at 4:32 PM Galina Kistanova via lldb-commits < lldb-comm...@lists.llvm.org> wrote: > They are online now - http://lab.llvm.org:8011/#/waterfall?tags=sanitizer > > AnnotatedCommand has severe design conflict with the new buildbot. > We have changed it to be safe and still do

[clang] efd0472 - BuildVectorType with a dependent (array) type is crashing the compiler - Fix for PR-47542

2020-09-28 Thread Reid Kleckner via cfe-commits
Author: Zahira Ammarguellat Date: 2020-09-28T17:10:32-07:00 New Revision: efd04721c9a2a856dd47e47a08c42d21efd5dd2b URL: https://github.com/llvm/llvm-project/commit/efd04721c9a2a856dd47e47a08c42d21efd5dd2b DIFF:

[clang] 276f68e - Revert "Add a static_assert confirming that DiagnosticBuilder is small"

2020-09-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-09-24T16:39:46-07:00 New Revision: 276f68eace7c27f6805d69a30a4b2f186e42c56c URL: https://github.com/llvm/llvm-project/commit/276f68eace7c27f6805d69a30a4b2f186e42c56c DIFF: https://github.com/llvm/llvm-project/commit/276f68eace7c27f6805d69a30a4b2f186e42c56c.diff

[clang] a32feed - Add a static_assert confirming that DiagnosticBuilder is small

2020-09-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-09-24T16:38:41-07:00 New Revision: a32feed0dbeac7606d042d0d7e041c9eaf12cd51 URL: https://github.com/llvm/llvm-project/commit/a32feed0dbeac7606d042d0d7e041c9eaf12cd51 DIFF: https://github.com/llvm/llvm-project/commit/a32feed0dbeac7606d042d0d7e041c9eaf12cd51.diff

[clang] ecfc9b9 - [MS] For unknown ISAs, pass non-trivially copyable arguments indirectly

2020-09-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-09-24T16:29:48-07:00 New Revision: ecfc9b971269a86b101cddf1fd9f0976be4096d0 URL: https://github.com/llvm/llvm-project/commit/ecfc9b971269a86b101cddf1fd9f0976be4096d0 DIFF: https://github.com/llvm/llvm-project/commit/ecfc9b971269a86b101cddf1fd9f0976be4096d0.diff

[clang] b8a50e9 - [MS] Simplify rules for passing C++ records

2020-09-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-09-24T16:29:47-07:00 New Revision: b8a50e920704436ddcbe0cc9d2020935d7e37095 URL: https://github.com/llvm/llvm-project/commit/b8a50e920704436ddcbe0cc9d2020935d7e37095 DIFF: https://github.com/llvm/llvm-project/commit/b8a50e920704436ddcbe0cc9d2020935d7e37095.diff

[clang] 3453b69 - Revert "Recommit "[CUDA][HIP] Defer overloading resolution diagnostics for host device functions""

2020-09-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-09-24T11:16:54-07:00 New Revision: 3453b6928da332bb67f902add71f5cd80f61c136 URL: https://github.com/llvm/llvm-project/commit/3453b6928da332bb67f902add71f5cd80f61c136 DIFF: https://github.com/llvm/llvm-project/commit/3453b6928da332bb67f902add71f5cd80f61c136.diff

[clang] b62fd43 - Revert "Recommit [NFC] Refactor DiagnosticBuilder and PartialDiagnostic"

2020-09-24 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-09-24T11:16:55-07:00 New Revision: b62fd436a3e613cbfe0654305cbc0e4f142bfcf9 URL: https://github.com/llvm/llvm-project/commit/b62fd436a3e613cbfe0654305cbc0e4f142bfcf9 DIFF: https://github.com/llvm/llvm-project/commit/b62fd436a3e613cbfe0654305cbc0e4f142bfcf9.diff

[clang] 3b3a165 - [MS] On x86_32, pass overaligned, non-copyable arguments indirectly

2020-09-21 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-09-21T11:49:17-07:00 New Revision: 3b3a16548568f5b6c4146ca5129eb6af5000e4ff URL: https://github.com/llvm/llvm-project/commit/3b3a16548568f5b6c4146ca5129eb6af5000e4ff DIFF: https://github.com/llvm/llvm-project/commit/3b3a16548568f5b6c4146ca5129eb6af5000e4ff.diff

[clang] 672ed53 - [codeview] Put !heapallocsite on calls to operator new

2020-06-05 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-06-05T12:52:38-07:00 New Revision: 672ed5386024ba5cee53e19d637b7920a4889837 URL: https://github.com/llvm/llvm-project/commit/672ed5386024ba5cee53e19d637b7920a4889837 DIFF: https://github.com/llvm/llvm-project/commit/672ed5386024ba5cee53e19d637b7920a4889837.diff

[clang] b8000c0 - [Windows] Autolink with basenames and add libdir to libpath

2020-04-28 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-04-28T11:36:21-07:00 New Revision: b8000c0ce84541c5b5535419234fb65ce77d6756 URL: https://github.com/llvm/llvm-project/commit/b8000c0ce84541c5b5535419234fb65ce77d6756 DIFF: https://github.com/llvm/llvm-project/commit/b8000c0ce84541c5b5535419234fb65ce77d6756.diff

[clang] bd6942e - Re-land "[MS] Fix assert handling enum forward decls in hasVisibleDefinition"

2020-04-23 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-04-23T16:22:01-07:00 New Revision: bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581 URL: https://github.com/llvm/llvm-project/commit/bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581 DIFF: https://github.com/llvm/llvm-project/commit/bd6942eb215ec1ddf8dc2335dfe9df06a5ba1581.diff

[clang] 8da5b90 - [MS] Fix packed struct layout for arrays of aligned non-record types

2020-04-14 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-04-14T18:34:52-07:00 New Revision: 8da5b9083691b557f50f72ab099598bb291aec5f URL: https://github.com/llvm/llvm-project/commit/8da5b9083691b557f50f72ab099598bb291aec5f DIFF: https://github.com/llvm/llvm-project/commit/8da5b9083691b557f50f72ab099598bb291aec5f.diff

[clang-tools-extra] eac5672 - Fix target_info.test on Windows with a hack

2020-04-13 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-04-13T13:14:06-07:00 New Revision: eac56724fd955af0f8521557cacc57a83f371649 URL: https://github.com/llvm/llvm-project/commit/eac56724fd955af0f8521557cacc57a83f371649 DIFF: https://github.com/llvm/llvm-project/commit/eac56724fd955af0f8521557cacc57a83f371649.diff

[clang] 55efb68 - [MS] Mark vbase dtors used when marking dtor used

2020-04-09 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2020-04-09T14:19:36-07:00 New Revision: 55efb68c19b4911f780ec4d074f8ff2f8529883f URL: https://github.com/llvm/llvm-project/commit/55efb68c19b4911f780ec4d074f8ff2f8529883f DIFF: https://github.com/llvm/llvm-project/commit/55efb68c19b4911f780ec4d074f8ff2f8529883f.diff

<    1   2   3   4   5   6   7   8   9   10   >