[clang] 631be5c - Remove Support/Options.h, it is unused

2019-11-16 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-11-15T13:32:52-08:00 New Revision: 631be5c0d41161057d02fe08a7aeb4fbde1a91d6 URL: https://github.com/llvm/llvm-project/commit/631be5c0d41161057d02fe08a7aeb4fbde1a91d6 DIFF: https://github.com/llvm/llvm-project/commit/631be5c0d41161057d02fe08a7aeb4fbde1a91d6.diff

[clang-tools-extra] e2369fd - [clang-include-fixer] Skip .rc files when finding symbols

2019-11-14 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-11-14T10:04:35-08:00 New Revision: e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691 URL: https://github.com/llvm/llvm-project/commit/e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691 DIFF: https://github.com/llvm/llvm-project/commit/e2369fd197d9ed9916bf78b2c8f6d7b8e0d66691.diff

[clang] 7177ce9 - [SEH] Defer checking filter expression types until instantiaton

2019-11-07 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-11-07T14:52:04-08:00 New Revision: 7177ce978e8f8e5409cec90bad07df92441656e3 URL: https://github.com/llvm/llvm-project/commit/7177ce978e8f8e5409cec90bad07df92441656e3 DIFF: https://github.com/llvm/llvm-project/commit/7177ce978e8f8e5409cec90bad07df92441656e3.diff

[clang] dd870f6 - Fix warning about unused std::unique result, erase shifted elements

2019-11-07 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-11-07T10:39:29-08:00 New Revision: dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571 URL: https://github.com/llvm/llvm-project/commit/dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571 DIFF: https://github.com/llvm/llvm-project/commit/dd870f6929ee0b1dfb5fd000c7b826a1bd2d2571.diff

[clang] f37b5c8 - [RISCV] Fix up tests on Windows after new usage of sys::path::append

2019-11-07 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-11-07T09:53:56-08:00 New Revision: f37b5c800e150ad915c4e0571edd2c92c0160d89 URL: https://github.com/llvm/llvm-project/commit/f37b5c800e150ad915c4e0571edd2c92c0160d89 DIFF: https://github.com/llvm/llvm-project/commit/f37b5c800e150ad915c4e0571edd2c92c0160d89.diff

Re: [clang] 33a745e - [clang][clang-scan-deps] Add support for extracting full module dependencies.

2019-10-31 Thread Reid Kleckner via cfe-commits
r is convenient. On Wed, Oct 30, 2019 at 4:03 PM Michael Spencer wrote: > On Wed, Oct 30, 2019 at 3:54 PM Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> I XFAILED the test on Windows in 52194350cfe. The [/\\] regexes >> might need to match tw

[clang] 19f1dc7 - Remove unneeded template alias, causes issues with some MSVC version

2019-10-31 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-10-31T14:20:54-07:00 New Revision: 19f1dc7b527eade11dae9425c420cc9f450393b6 URL: https://github.com/llvm/llvm-project/commit/19f1dc7b527eade11dae9425c420cc9f450393b6 DIFF: https://github.com/llvm/llvm-project/commit/19f1dc7b527eade11dae9425c420cc9f450393b6.diff

Re: [clang] 33a745e - [clang][clang-scan-deps] Add support for extracting full module dependencies.

2019-10-30 Thread Reid Kleckner via cfe-commits
I XFAILED the test on Windows in 52194350cfe. The [/\\] regexes might need to match two slashes, and the PREFIX variable ends up having inconsistent slash direction. On Wed, Oct 30, 2019 at 3:27 PM Michael Spencer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Michael Spencer >

[clang] 5219435 - Disable new clang-scan-deps test on Windows due to backslash path matching problems

2019-10-30 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-10-30T15:51:34-07:00 New Revision: 52194350cfe834f27e41771c315fe0656067fdc4 URL: https://github.com/llvm/llvm-project/commit/52194350cfe834f27e41771c315fe0656067fdc4 DIFF: https://github.com/llvm/llvm-project/commit/52194350cfe834f27e41771c315fe0656067fdc4.diff

[clang] 812bdb3 - [MS] Don't reference deleted copy ctors from catchable types

2019-10-30 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-10-30T15:06:26-07:00 New Revision: 812bdb3c13210759341e8a1b08b864a539ce9dc7 URL: https://github.com/llvm/llvm-project/commit/812bdb3c13210759341e8a1b08b864a539ce9dc7 DIFF: https://github.com/llvm/llvm-project/commit/812bdb3c13210759341e8a1b08b864a539ce9dc7.diff

Re: [PATCH] D67723: [DebugInfo] Add option to disable inline line tables.

2019-10-29 Thread Reid Kleckner via cfe-commits
On Mon, Oct 28, 2019 at 4:42 PM David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > If the intended behavior is to show the crash at the call site like >> LangRef in the patch suggest then line 0 will certainly not achieve that. I >> implicitly assumed the wording in LangRef would

[clang] 07ee46d - [MS] Fix constexpr data member pointer conversions

2019-10-29 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-10-29T16:58:00-07:00 New Revision: 07ee46d613d7c1862878d7c7d1208a7b3e37459d URL: https://github.com/llvm/llvm-project/commit/07ee46d613d7c1862878d7c7d1208a7b3e37459d DIFF: https://github.com/llvm/llvm-project/commit/07ee46d613d7c1862878d7c7d1208a7b3e37459d.diff

[clang] 9ecd322 - [NFC] Fix some indentation disturbed in D67368

2019-10-28 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-10-28T17:12:43-07:00 New Revision: 9ecd3225d134541bdfde18a6648edb8b9e048035 URL: https://github.com/llvm/llvm-project/commit/9ecd3225d134541bdfde18a6648edb8b9e048035 DIFF: https://github.com/llvm/llvm-project/commit/9ecd3225d134541bdfde18a6648edb8b9e048035.diff

[clang] 7cd595d - Revert "Use -fdebug-compilation-dir to form absolute paths in coverage mappings"

2019-10-28 Thread Reid Kleckner via cfe-commits
Author: Reid Kleckner Date: 2019-10-28T14:40:17-07:00 New Revision: 7cd595df96d5929488063d8ff5cc3b5d800386da URL: https://github.com/llvm/llvm-project/commit/7cd595df96d5929488063d8ff5cc3b5d800386da DIFF: https://github.com/llvm/llvm-project/commit/7cd595df96d5929488063d8ff5cc3b5d800386da.diff

[clang-tools-extra] r375316 - Move endian constant from Host.h to SwapByteOrder.h, prune include

2019-10-18 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Oct 18 17:48:11 2019 New Revision: 375316 URL: http://llvm.org/viewvc/llvm-project?rev=375316&view=rev Log: Move endian constant from Host.h to SwapByteOrder.h, prune include Works on this dependency chain: ArrayRef.h -> Hashing.h -> --CUT-- Host.h -> StringMap.h / S

r375316 - Move endian constant from Host.h to SwapByteOrder.h, prune include

2019-10-18 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Oct 18 17:48:11 2019 New Revision: 375316 URL: http://llvm.org/viewvc/llvm-project?rev=375316&view=rev Log: Move endian constant from Host.h to SwapByteOrder.h, prune include Works on this dependency chain: ArrayRef.h -> Hashing.h -> --CUT-- Host.h -> StringMap.h / S

r374936 - Fix as-w-option.c on Windows where no assembler exists

2019-10-15 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Oct 15 11:39:41 2019 New Revision: 374936 URL: http://llvm.org/viewvc/llvm-project?rev=374936&view=rev Log: Fix as-w-option.c on Windows where no assembler exists Modified: cfe/trunk/test/Driver/as-w-option.c Modified: cfe/trunk/test/Driver/as-w-option.c URL: http://ll

Re: r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

2019-10-11 Thread Reid Kleckner via cfe-commits
ould have a > separate -fno-gnu-extensions for that part instead? > > On Thu, Oct 10, 2019 at 5:02 PM Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rnk >> Date: Thu Oct 10 14:04:25 2019 >> New Revision: 374449 >> >

r374449 - Add -fgnuc-version= to control __GNUC__ and other GCC macros

2019-10-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Oct 10 14:04:25 2019 New Revision: 374449 URL: http://llvm.org/viewvc/llvm-project?rev=374449&view=rev Log: Add -fgnuc-version= to control __GNUC__ and other GCC macros I noticed that compiling on Windows with -fno-ms-compatibility had the side effect of defining __GNUC__, a

r374418 - Fix one more clang test which didn't have \5C in it

2019-10-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Oct 10 11:42:06 2019 New Revision: 374418 URL: http://llvm.org/viewvc/llvm-project?rev=374418&view=rev Log: Fix one more clang test which didn't have \5C in it Modified: cfe/trunk/test/CoverageMapping/abspath.cpp Modified: cfe/trunk/test/CoverageMapping/abspath.cpp URL:

r374416 - Update clang tests for new LLVM IR backslash printing in r374415

2019-10-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Oct 10 11:36:41 2019 New Revision: 374416 URL: http://llvm.org/viewvc/llvm-project?rev=374416&view=rev Log: Update clang tests for new LLVM IR backslash printing in r374415 Modified: cfe/trunk/test/CodeGen/debug-prefix-map.c cfe/trunk/test/CodeGen/string-literal.c

r374403 - Re-land "Use -fdebug-compilation-dir to form absolute paths in coverage mappings"

2019-10-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Oct 10 11:01:20 2019 New Revision: 374403 URL: http://llvm.org/viewvc/llvm-project?rev=374403&view=rev Log: Re-land "Use -fdebug-compilation-dir to form absolute paths in coverage mappings" This reverts r374324 (git commit 62808631acceaa8b78f8ab9b407eb6b943ff5f77) I change

r374269 - Re-land [mangle] Fix mangling where an extra mangle context is required.

2019-10-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Oct 9 18:14:22 2019 New Revision: 374269 URL: http://llvm.org/viewvc/llvm-project?rev=374269&view=rev Log: Re-land [mangle] Fix mangling where an extra mangle context is required. This reverts r374268 (git commit c34385d07c7d59447bf836b740f032235391d121) I think I reverted

r374268 - Revert [mangle] Fix mangling where an extra mangle context is required.

2019-10-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Oct 9 18:10:01 2019 New Revision: 374268 URL: http://llvm.org/viewvc/llvm-project?rev=374268&view=rev Log: Revert [mangle] Fix mangling where an extra mangle context is required. This reverts r374200 (git commit fd18e94697c987d5f24e25aa4e27ada3cce4) Causes crashes just

r374266 - Use -fdebug-compilation-dir to form absolute paths in coverage mappings

2019-10-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Oct 9 17:54:33 2019 New Revision: 374266 URL: http://llvm.org/viewvc/llvm-project?rev=374266&view=rev Log: Use -fdebug-compilation-dir to form absolute paths in coverage mappings This allows users to explicitly request relative paths with `-fdebug-compilation-dir .`. Fixes

r373771 - Add missing null pointer check in -ftime-trace code

2019-10-04 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Oct 4 11:57:01 2019 New Revision: 373771 URL: http://llvm.org/viewvc/llvm-project?rev=373771&view=rev Log: Add missing null pointer check in -ftime-trace code createOutputFile diagnoses the error for the caller already, so recover by not writing the output. Fixes PR43555

r373004 - Only pass -coverage-notes-file when emitting coverage

2019-09-26 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Sep 26 11:13:19 2019 New Revision: 373004 URL: http://llvm.org/viewvc/llvm-project?rev=373004&view=rev Log: Only pass -coverage-notes-file when emitting coverage The only functional change here is that -coverage-notes-file is not passed to -cc1 in some situations. This code

r372999 - Move normalization of `\` in #includes from -fms-compatibility to -fms-extensions

2019-09-26 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Sep 26 10:19:22 2019 New Revision: 372999 URL: http://llvm.org/viewvc/llvm-project?rev=372999&view=rev Log: Move normalization of `\` in #includes from -fms-compatibility to -fms-extensions Handling backslashes in include paths in the implementation isn't non-conforming. M

r372994 - Un-XFAIL coverage_no_integrated_as.c test on Windows

2019-09-26 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Sep 26 09:56:25 2019 New Revision: 372994 URL: http://llvm.org/viewvc/llvm-project?rev=372994&view=rev Log: Un-XFAIL coverage_no_integrated_as.c test on Windows You can't use -fno-integrated-as for *-msvc triples because no usable standalone assembler exists. Perhaps we coul

r372926 - Simplify -fms-compatibility include lookup logic, NFC

2019-09-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Sep 25 15:50:50 2019 New Revision: 372926 URL: http://llvm.org/viewvc/llvm-project?rev=372926&view=rev Log: Simplify -fms-compatibility include lookup logic, NFC This include search logic has an extra parameter to deal with Windows includes with backslashes, which get normal

r372178 - Ignore exception specifier mismatch when merging redeclarations

2019-09-17 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Sep 17 13:29:10 2019 New Revision: 372178 URL: http://llvm.org/viewvc/llvm-project?rev=372178&view=rev Log: Ignore exception specifier mismatch when merging redeclarations Exception specifiers are now part of the function type in C++17. Normally, it is illegal to redeclare t

r371753 - [MS] Warn when shadowing template parameters under -fms-compatibility

2019-09-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Sep 12 11:26:34 2019 New Revision: 371753 URL: http://llvm.org/viewvc/llvm-project?rev=371753&view=rev Log: [MS] Warn when shadowing template parameters under -fms-compatibility Summary: C++ does not allow shadowing template parameters, but previously we allowed it under -fm

Re: r371663 - Start porting ivfsoverlay tests to Windows

2019-09-12 Thread Reid Kleckner via cfe-commits
Thanks, that seems like the correct fix. The property that makes them fail is the native system path style, not the default target. On Thu, Sep 12, 2019 at 5:03 AM Jeremy Morse wrote: > On Thu, Sep 12, 2019 at 11:24 AM Jeremy Morse > wrote: > > Assuming no-one else is looking at this, I'll comm

r371749 - Don't warn about selectany on implicitly inline variables

2019-09-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Sep 12 10:55:48 2019 New Revision: 371749 URL: http://llvm.org/viewvc/llvm-project?rev=371749&view=rev Log: Don't warn about selectany on implicitly inline variables Summary: This avoids a -Wignored-attribute warning on the code pattern Microsoft recommends for integral cons

r371663 - Start porting ivfsoverlay tests to Windows

2019-09-11 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Sep 11 13:56:25 2019 New Revision: 371663 URL: http://llvm.org/viewvc/llvm-project?rev=371663&view=rev Log: Start porting ivfsoverlay tests to Windows Part of PR43272, the changes are: 1. Use @ as the sed pattern delimiter instead of : so that the drive letter in lit substi

r371642 - [MS] Consder constexpr globals to be inline, as in C++17

2019-09-11 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Sep 11 11:09:10 2019 New Revision: 371642 URL: http://llvm.org/viewvc/llvm-project?rev=371642&view=rev Log: [MS] Consder constexpr globals to be inline, as in C++17 Summary: Microsoft seems to do this regardless of the language mode, so we must also do it in order to be ABI

r371581 - Emit -Wmicrosoft-enum-value warning instead of error in MS ABI

2019-09-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Sep 10 18:01:06 2019 New Revision: 371581 URL: http://llvm.org/viewvc/llvm-project?rev=371581&view=rev Log: Emit -Wmicrosoft-enum-value warning instead of error in MS ABI Summary: The first NFC change is to replace a getCXXABI().isMicrosoft() check with getTriple().isWindows

r371559 - Actually reorder not and env in crash-recovery-modules.m

2019-09-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Sep 10 14:54:16 2019 New Revision: 371559 URL: http://llvm.org/viewvc/llvm-project?rev=371559&view=rev Log: Actually reorder not and env in crash-recovery-modules.m Modified: cfe/trunk/test/Index/crash-recovery-modules.m Modified: cfe/trunk/test/Index/crash-recovery-mod

r371552 - Re-land Remove REQUIRES:shell from tests that pass for me on Windows

2019-09-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Sep 10 13:15:45 2019 New Revision: 371552 URL: http://llvm.org/viewvc/llvm-project?rev=371552&view=rev Log: Re-land Remove REQUIRES:shell from tests that pass for me on Windows This reverts r371497 (git commit 3d7e9ab7b9f8c53aa41420c54970f0fb421004a2) Reorder `not` with `en

r371478 - Remove REQUIRES:shell from tests that pass for me on Windows

2019-09-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Sep 9 17:50:32 2019 New Revision: 371478 URL: http://llvm.org/viewvc/llvm-project?rev=371478&view=rev Log: Remove REQUIRES:shell from tests that pass for me on Windows I see in the history for some of these tests REQUIRES:shell was used as a way to disable tests on Windows

r371277 - Fix thunks.cpp test, don't FileCheck for anon namespace id

2019-09-06 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Sep 6 17:41:08 2019 New Revision: 371277 URL: http://llvm.org/viewvc/llvm-project?rev=371277&view=rev Log: Fix thunks.cpp test, don't FileCheck for anon namespace id The anon namespace id is a hash of the main input path to the compiler, which varies in the test suite becau

r371269 - Use musttail for variadic method thunks when possible

2019-09-06 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Sep 6 15:55:26 2019 New Revision: 371269 URL: http://llvm.org/viewvc/llvm-project?rev=371269&view=rev Log: Use musttail for variadic method thunks when possible This avoids cloning variadic virtual methods when the target supports musttail and the return type is not covaria

r370087 - Move EH spec mismatches under -fms-compatibility

2019-08-27 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Aug 27 10:52:03 2019 New Revision: 370087 URL: http://llvm.org/viewvc/llvm-project?rev=370087&view=rev Log: Move EH spec mismatches under -fms-compatibility -fms-extensions is intended to enable conforming language extensions and -fms-compatibility is intended to language ru

r369474 - Add triple to new test to try to pacify bots

2019-08-20 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Aug 20 16:32:51 2019 New Revision: 369474 URL: http://llvm.org/viewvc/llvm-project?rev=369474&view=rev Log: Add triple to new test to try to pacify bots Modified: cfe/trunk/test/CodeGenCXX/debug-info-atexit-stub.cpp Modified: cfe/trunk/test/CodeGenCXX/debug-info-atexit-

r369043 - [Sema] Implement DR2386 for C++17 structured binding

2019-08-15 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Aug 15 12:45:28 2019 New Revision: 369043 URL: http://llvm.org/viewvc/llvm-project?rev=369043&view=rev Log: [Sema] Implement DR2386 for C++17 structured binding Allow implementations to provide complete definitions of std::tuple_size, but to omit the 'value' member to signal

Re: r368354 - Mark clang-scan-deps test as requiring thread support

2019-08-13 Thread Reid Kleckner via cfe-commits
so the >>> TLS variables are simply global, and the RAII objects assert that things >>> haven't been constructed and destructed in the correct order. >>> >>> So, going forward you will probably need to remember to add REQUIRES: >>> thread_support t

Re: r368348 - Fix up fd limit diagnosis code

2019-08-09 Thread Reid Kleckner via cfe-commits
gt; on it. (And this is code that all other major compilers tolerate, afaik.) > > // Martin > > > On Thu, 8 Aug 2019, Reid Kleckner via cfe-commits wrote: > > > Author: rnk > > Date: Thu Aug 8 14:35:03 2019 > > New Revision: 368348 > > > > URL: ht

r368475 - Don't diagnose errors when a file matches an include component

2019-08-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Aug 9 12:49:14 2019 New Revision: 368475 URL: http://llvm.org/viewvc/llvm-project?rev=368475&view=rev Log: Don't diagnose errors when a file matches an include component This regressed in r368322, and was reported as PR42948 and on the mailing list. The fix is to ignore the

Re: r368348 - Fix up fd limit diagnosis code

2019-08-09 Thread Reid Kleckner via cfe-commits
pilers tolerate, afaik.) > > // Martin > > > On Thu, 8 Aug 2019, Reid Kleckner via cfe-commits wrote: > > > Author: rnk > > Date: Thu Aug 8 14:35:03 2019 > > New Revision: 368348 > > > > URL: http://llvm.org/viewvc/llvm-project?rev=368348&vie

Re: r368354 - Mark clang-scan-deps test as requiring thread support

2019-08-08 Thread Reid Kleckner via cfe-commits
. On Thu, Aug 8, 2019 at 2:45 PM Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Thu Aug 8 14:45:59 2019 > New Revision: 368354 > > URL: http://llvm.org/viewvc/llvm-project?rev=368354&view=rev > Log: > Mark clang-scan-d

r368354 - Mark clang-scan-deps test as requiring thread support

2019-08-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Aug 8 14:45:59 2019 New Revision: 368354 URL: http://llvm.org/viewvc/llvm-project?rev=368354&view=rev Log: Mark clang-scan-deps test as requiring thread support Otherwise the test calls a pure virtual method and crashes. Perhaps this could be improved. Modified: cfe/tr

r368348 - Fix up fd limit diagnosis code

2019-08-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Aug 8 14:35:03 2019 New Revision: 368348 URL: http://llvm.org/viewvc/llvm-project?rev=368348&view=rev Log: Fix up fd limit diagnosis code Apparently Windows returns the "invalid argument" error code when the path contains invalid characters such as '<'. The test/Preprocesso

r367733 - The MinGW linker supports response files

2019-08-02 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Aug 2 15:55:00 2019 New Revision: 367733 URL: http://llvm.org/viewvc/llvm-project?rev=367733&view=rev Log: The MinGW linker supports response files This affects both LLD and ld.bfd. This isn't testable with a normal driver test with -### because those command lines are pri

r367337 - Remove cache for macro arg stringization

2019-07-30 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 30 10:58:22 2019 New Revision: 367337 URL: http://llvm.org/viewvc/llvm-project?rev=367337&view=rev Log: Remove cache for macro arg stringization Summary: The cache recorded the wrong expansion location for all but the first stringization. It seems uncommon to stringize t

r367249 - Fix taint-generic.c on Windows, handle case in OS error

2019-07-29 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Jul 29 11:48:50 2019 New Revision: 367249 URL: http://llvm.org/viewvc/llvm-project?rev=367249&view=rev Log: Fix taint-generic.c on Windows, handle case in OS error Modified: cfe/trunk/test/Analysis/taint-generic.c Modified: cfe/trunk/test/Analysis/taint-generic.c URL:

r366284 - Fix OpenCLCXX test on 32-bit Windows where thiscall is present

2019-07-16 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 16 16:44:33 2019 New Revision: 366284 URL: http://llvm.org/viewvc/llvm-project?rev=366284&view=rev Log: Fix OpenCLCXX test on 32-bit Windows where thiscall is present Modified: cfe/trunk/test/SemaOpenCLCXX/address-space-deduction.cl Modified: cfe/trunk/test/SemaOpen

r366282 - Fix darwin-ld.c if dsymutil.exe exists on PATH

2019-07-16 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 16 16:38:05 2019 New Revision: 366282 URL: http://llvm.org/viewvc/llvm-project?rev=366282&view=rev Log: Fix darwin-ld.c if dsymutil.exe exists on PATH Modified: cfe/trunk/test/Driver/darwin-ld.c Modified: cfe/trunk/test/Driver/darwin-ld.c URL: http://llvm.org/viewv

r365956 - Revert driver: Don't warn about assembler flags being unused when not assembling

2019-07-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jul 12 13:44:57 2019 New Revision: 365956 URL: http://llvm.org/viewvc/llvm-project?rev=365956&view=rev Log: Revert driver: Don't warn about assembler flags being unused when not assembling This reverts r365703 (git commit 101c1afdfd1c88f05da94c6fd317b489bb704f40) and r365714

Re: r365724 - clang-cl: Remove -O0 option

2019-07-11 Thread Reid Kleckner via cfe-commits
This seems to have caused a libfuzzer test to fail here: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/48261 It's not easy to fix because -O0 is passed to clang-cl on Windows and clang elsewhere, so /Od won't do the trick without a substitution. This was kind of why I added -O0 in the

Re: r365499 - [OpenCL][Sema] Fix builtin rewriting

2019-07-10 Thread Reid Kleckner via cfe-commits
NP, I forgot to follow up mentioning that I tweaked the test to fix the failure in https://reviews.llvm.org/rC365557. It would be good to eventually mangle whatever OpenCL thing is being mangled here in the MS ABI, but that can be future work. On Wed, Jul 10, 2019 at 2:45 AM Marco Antognini wrote

r365581 - Revert [clang] DirectoryWatcher

2019-07-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 9 16:22:01 2019 New Revision: 365581 URL: http://llvm.org/viewvc/llvm-project?rev=365581&view=rev Log: Revert [clang] DirectoryWatcher This reverts r365574 (git commit 31babea94a3ed38a140540f2252cf043dacec1f7) Removed: cfe/trunk/include/clang/DirectoryWatcher/

r365579 - [MS] Treat ignored explicit calling conventions as an explicit __cdecl

2019-07-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 9 16:17:43 2019 New Revision: 365579 URL: http://llvm.org/viewvc/llvm-project?rev=365579&view=rev Log: [MS] Treat ignored explicit calling conventions as an explicit __cdecl The CCCR_Ignore action is only used for Microsoft calling conventions, mainly because MSVC does

r365557 - Use the Itanium C++ ABI for the pipe_builtin.cl test

2019-07-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 9 14:02:06 2019 New Revision: 365557 URL: http://llvm.org/viewvc/llvm-project?rev=365557&view=rev Log: Use the Itanium C++ ABI for the pipe_builtin.cl test Certain OpenCL constructs cannot yet be mangled in the MS C++ ABI. Add a FIXME for it if anyone cares to implement

r365556 - De-templatize non-dependent VS macro logic, NFC

2019-07-09 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Jul 9 13:57:28 2019 New Revision: 365556 URL: http://llvm.org/viewvc/llvm-project?rev=365556&view=rev Log: De-templatize non-dependent VS macro logic, NFC These macro definitions don't depend on the template parameter, so they don't need to be part of the template. Move the

Re: r365499 - [OpenCL][Sema] Fix builtin rewriting

2019-07-09 Thread Reid Kleckner via cfe-commits
FYI, your test seems to fail on Windows: FAIL: Clang :: CodeGenOpenCL/pipe_builtin.cl (4679 of 15176) TEST 'Clang :: CodeGenOpenCL/pipe_builtin.cl' FAILED Script: -- : 'RUN: at line 1'; c:\b\slave\clang-x64-windows-msvc\build\build\stage1\bin\clang.exe -cc1

r365393 - Revert [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings

2019-07-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Jul 8 14:59:07 2019 New Revision: 365393 URL: http://llvm.org/viewvc/llvm-project?rev=365393&view=rev Log: Revert [Sema] Resolve placeholder types before type deduction to silence spurious `-Warc-repeated-use-of-weak` warnings This reverts r365382 (git commit 8b1becf2e31d9

r364476 - Revert r363191 "[MS] Pretend constexpr variable template specializations are inline"

2019-06-26 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Jun 26 14:16:51 2019 New Revision: 364476 URL: http://llvm.org/viewvc/llvm-project?rev=364476&view=rev Log: Revert r363191 "[MS] Pretend constexpr variable template specializations are inline" The next Visual Studio update will fix this issue, and it doesn't make sense to i

Re: r364102 - Fix __has_cpp_attribute expansion to produce trailing L and (where

2019-06-21 Thread Reid Kleckner via cfe-commits
I added -P to remove the line markers which were introducing the colons. On Fri, Jun 21, 2019 at 2:58 PM Galina Kistanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hello Richard, > > This commit added broken test to the builder: > > http://lab.llvm.org:8011/builders/llvm-clang-lld-x8

r364108 - Fix has_attribute.cpp test on Windows after r364102

2019-06-21 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jun 21 15:28:52 2019 New Revision: 364108 URL: http://llvm.org/viewvc/llvm-project?rev=364108&view=rev Log: Fix has_attribute.cpp test on Windows after r364102 Modified: cfe/trunk/test/Preprocessor/has_attribute.cpp Modified: cfe/trunk/test/Preprocessor/has_attribute.cp

r364089 - Revert [test][Driver] Fix Clang :: Driver/cl-response-file.c

2019-06-21 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jun 21 11:33:20 2019 New Revision: 364089 URL: http://llvm.org/viewvc/llvm-project?rev=364089&view=rev Log: Revert [test][Driver] Fix Clang :: Driver/cl-response-file.c This reverts r363985 (git commit d5f16d6cfccc4b0b13b6c01d16c673886d53e695) This test can't use printf on

[clang-tools-extra] r364087 - Quote path to Python executable in case it has spaces

2019-06-21 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jun 21 11:17:04 2019 New Revision: 364087 URL: http://llvm.org/viewvc/llvm-project?rev=364087&view=rev Log: Quote path to Python executable in case it has spaces These days Python 3 is typically installed into C:/Program Files, so cope with that. Similar to r364077 in compi

r363973 - Fix passing structs and AVX vectors through sysv_abi

2019-06-20 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Jun 20 13:07:20 2019 New Revision: 363973 URL: http://llvm.org/viewvc/llvm-project?rev=363973&view=rev Log: Fix passing structs and AVX vectors through sysv_abi Do this the same way we did it for ms_abi in r324594. Fixes PR36806. Added: cfe/trunk/test/CodeGen/sysv_abi.

r363450 - Use unsigned for bitfields to avoid sign extension

2019-06-14 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Fri Jun 14 13:19:29 2019 New Revision: 363450 URL: http://llvm.org/viewvc/llvm-project?rev=363450&view=rev Log: Use unsigned for bitfields to avoid sign extension Modified: cfe/trunk/include/clang/Sema/DeclSpec.h cfe/trunk/lib/Sema/DeclSpec.cpp Modified: cfe/trunk/inclu

r363195 - Add comment to r363191 code as requested in code review

2019-06-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Jun 12 12:50:06 2019 New Revision: 363195 URL: http://llvm.org/viewvc/llvm-project?rev=363195&view=rev Log: Add comment to r363191 code as requested in code review Modified: cfe/trunk/lib/AST/ASTContext.cpp Modified: cfe/trunk/lib/AST/ASTContext.cpp URL: http://llvm.or

r363191 - [MS] Pretend constexpr variable template specializations are inline

2019-06-12 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Jun 12 11:53:49 2019 New Revision: 363191 URL: http://llvm.org/viewvc/llvm-project?rev=363191&view=rev Log: [MS] Pretend constexpr variable template specializations are inline Fixes link errors with clang and the latest Visual C++ 14.21.27702 headers, which was reported as P

Re: r363086 - For DR712: store on a DeclRefExpr whether it constitutes an odr-use.

2019-06-11 Thread Reid Kleckner via cfe-commits
The new assert is firing across Chromium, please fix or revert. This is a reduced test case: int a; struct Foo { template void operator()(b, c = a); }; Foo d; bool e; decltype(d(e)) gv; This causes the "missing non-odr-use marking for unevaluated decl ref" assertion on SemaExpr.cpp:16227 to fi

r363007 - Revert r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist"

2019-06-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Jun 10 16:25:43 2019 New Revision: 363007 URL: http://llvm.org/viewvc/llvm-project?rev=363007&view=rev Log: Revert r362994 & co "[analyzer][tests] Add normalize_plist to replace diff_plist" Reverts r362998, r362996, and r362994 because the tests do not pass on Windows due t

r363000 - Require stdcall etc parameters to be complete on ODR use

2019-06-10 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Jun 10 15:53:12 2019 New Revision: 363000 URL: http://llvm.org/viewvc/llvm-project?rev=363000&view=rev Log: Require stdcall etc parameters to be complete on ODR use Functions using stdcall, fastcall, or vectorcall with C linkage mangle in the size of the parameter pack. Calc

r361530 - [Driver] Move the "-o OUT -x TYPE SRC.c" flags to the end of -cc1

2019-05-23 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu May 23 11:35:43 2019 New Revision: 361530 URL: http://llvm.org/viewvc/llvm-project?rev=361530&view=rev Log: [Driver] Move the "-o OUT -x TYPE SRC.c" flags to the end of -cc1 New -cc1 arguments, such as -faddrsig, have started appearing after the input name. I personally find

r361438 - Fix new enum-codegen.cpp test

2019-05-22 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed May 22 14:52:12 2019 New Revision: 361438 URL: http://llvm.org/viewvc/llvm-project?rev=361438&view=rev Log: Fix new enum-codegen.cpp test Modified: cfe/trunk/test/Modules/enum-codegen.cpp Modified: cfe/trunk/test/Modules/enum-codegen.cpp URL: http://llvm.org/viewvc/llv

Re: r360637 - PR41817: Fix regression in r359260 that caused the MS compatibility

2019-05-16 Thread Reid Kleckner via cfe-commits
*From: *Richard Smith *Date: *Wed, May 15, 2019 at 5:43 PM > On Wed, 15 May 2019 at 15:54, Reid Kleckner via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> We could probably re-land Richard's change (although it's quite a lot of >> code...), but...

Re: r360637 - PR41817: Fix regression in r359260 that caused the MS compatibility

2019-05-15 Thread Reid Kleckner via cfe-commits
*From: *Hans Wennborg *Date: *Wed, May 15, 2019 at 1:22 AM > On Tue, May 14, 2019 at 6:35 PM Richard Smith > wrote: > > Yep, I'm not at all surprised. Perhaps we should stop claiming to > support this extension, given that it fundamentally violates assumptions > made by clang (that linkage doesn

r360705 - Fix ASTMerge/namespace/test.cpp after r360701

2019-05-14 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue May 14 13:01:03 2019 New Revision: 360705 URL: http://llvm.org/viewvc/llvm-project?rev=360705&view=rev Log: Fix ASTMerge/namespace/test.cpp after r360701 Modified: cfe/trunk/test/ASTMerge/namespace/test.cpp Modified: cfe/trunk/test/ASTMerge/namespace/test.cpp URL: http

r360701 - Update ASTMerge FileCheck test expectations

2019-05-14 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue May 14 12:02:39 2019 New Revision: 360701 URL: http://llvm.org/viewvc/llvm-project?rev=360701&view=rev Log: Update ASTMerge FileCheck test expectations I belive many of these diagnostics changed from errors to warnings in r357394. I've simply mechanically updated the tests,

r360699 - Restore test files accidentally deleted in r354839

2019-05-14 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue May 14 11:51:07 2019 New Revision: 360699 URL: http://llvm.org/viewvc/llvm-project?rev=360699&view=rev Log: Restore test files accidentally deleted in r354839 I think there must be a bug in git-llvm causing parent directories to be deleted when the diff deletes files in a su

r360297 - Try to restore some clang test headers lost in r360291

2019-05-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed May 8 15:30:46 2019 New Revision: 360297 URL: http://llvm.org/viewvc/llvm-project?rev=360297&view=rev Log: Try to restore some clang test headers lost in r360291 I'm not sure why 'git llvm revert' removed them. Added: cfe/trunk/test/Headers/Inputs/ cfe/trunk/test/H

r360291 - Revert Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility.

2019-05-08 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed May 8 15:01:20 2019 New Revision: 360291 URL: http://llvm.org/viewvc/llvm-project?rev=360291&view=rev Log: Revert Include corecrt.h in stddef.h and vcruntime.h in stdarg.h to improve MS compatibility. This reverts r360271 (git commit a0933bd8ec1515167ea653f7ee788b8bbde27d5

r360207 - [COFF] Use COFF stubs for extern_weak functions

2019-05-07 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue May 7 16:06:21 2019 New Revision: 360207 URL: http://llvm.org/viewvc/llvm-project?rev=360207&view=rev Log: [COFF] Use COFF stubs for extern_weak functions Summary: A COFF stub indirects the reference to a symbol through memory. A .refptr.$sym global variable pointer is crea

r359809 - Use primary template parameter names for variable template debug info

2019-05-02 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu May 2 10:45:54 2019 New Revision: 359809 URL: http://llvm.org/viewvc/llvm-project?rev=359809&view=rev Log: Use primary template parameter names for variable template debug info Summary: Fixes PR41677 Consider: template constexpr bool is_same_v = false; template const

r359722 - Make clang/utils/creduce-clang-crash.py executable

2019-05-01 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed May 1 13:15:39 2019 New Revision: 359722 URL: http://llvm.org/viewvc/llvm-project?rev=359722&view=rev Log: Make clang/utils/creduce-clang-crash.py executable Modified: cfe/trunk/utils/creduce-clang-crash.py (props changed) Propchange: cfe/trunk/utils/creduce-clang-cr

r359623 - Remove two unnecessary wrappers of canPassInRegisters

2019-04-30 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Tue Apr 30 15:23:20 2019 New Revision: 359623 URL: http://llvm.org/viewvc/llvm-project?rev=359623&view=rev Log: Remove two unnecessary wrappers of canPassInRegisters These extra layers aren't necessary. Modified: cfe/trunk/lib/CodeGen/CGCXXABI.cpp cfe/trunk/lib/CodeGen/

r359513 - Re-land r359250, [COFF] Statically link certain runtime library functions

2019-04-29 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Apr 29 16:05:47 2019 New Revision: 359513 URL: http://llvm.org/viewvc/llvm-project?rev=359513&view=rev Log: Re-land r359250, [COFF] Statically link certain runtime library functions Reverts the revert of r359251, this time with fixed tests. Differential Revision: https://re

r359507 - Simplify exclusion of nested classes from extern template instantiation, NFC

2019-04-29 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Apr 29 14:32:05 2019 New Revision: 359507 URL: http://llvm.org/viewvc/llvm-project?rev=359507&view=rev Log: Simplify exclusion of nested classes from extern template instantiation, NFC Summary: This simplifies three checks for MS ABI, Win Itanium, or Win GNU to just "is Wind

r359251 - Revert [COFF] Statically link certain runtime library functions

2019-04-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Apr 25 16:30:41 2019 New Revision: 359251 URL: http://llvm.org/viewvc/llvm-project?rev=359251&view=rev Log: Revert [COFF] Statically link certain runtime library functions This reverts r359250 (git commit 4730604bd3a361c68b92b18bf73a5daa15afe9f4) The newly added test should

r359250 - [COFF] Statically link certain runtime library functions

2019-04-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Apr 25 16:04:20 2019 New Revision: 359250 URL: http://llvm.org/viewvc/llvm-project?rev=359250&view=rev Log: [COFF] Statically link certain runtime library functions Statically link certain runtime library functions for MSVC/GNU Windows environments. This is consistent with M

r359148 - [codeview] Fix symbol names for dynamic initializers and atexit stubs

2019-04-24 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Wed Apr 24 15:45:44 2019 New Revision: 359148 URL: http://llvm.org/viewvc/llvm-project?rev=359148&view=rev Log: [codeview] Fix symbol names for dynamic initializers and atexit stubs Summary: Add a new variant to GlobalDecl for these so that we can detect them more easily during

[clang-tools-extra] r357429 - Fix clangd unittest _WIN32 ifdef

2019-04-01 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Apr 1 14:16:17 2019 New Revision: 357429 URL: http://llvm.org/viewvc/llvm-project?rev=357429&view=rev Log: Fix clangd unittest _WIN32 ifdef WIN32 is not defined, _WIN32 is, use that instead. Modified: clang-tools-extra/trunk/unittests/clangd/JSONTransportTests.cpp Mod

r357220 - [MS] Make __iso_volatile_* available on all targets

2019-03-28 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Mar 28 15:59:09 2019 New Revision: 357220 URL: http://llvm.org/viewvc/llvm-project?rev=357220&view=rev Log: [MS] Make __iso_volatile_* available on all targets Future versions of MSVC make these intrinsics available on x86 & x64, according to: http://lists.llvm.org/pipermail

r356964 - [MS] Add frontend support for __declspec(allocator)

2019-03-25 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Mar 25 16:20:18 2019 New Revision: 356964 URL: http://llvm.org/viewvc/llvm-project?rev=356964&view=rev Log: [MS] Add frontend support for __declspec(allocator) The intention is to add metadata to direct call sites of functions marked with __declspec(allocator), which will ul

r356425 - [MS] Skip vbase construction in abstract class ctors

2019-03-18 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Mon Mar 18 15:41:50 2019 New Revision: 356425 URL: http://llvm.org/viewvc/llvm-project?rev=356425&view=rev Log: [MS] Skip vbase construction in abstract class ctors As background, when constructing a complete object, virtual bases are constructed first. If an exception is thrown

<    1   2   3   4   5   6   7   8   9   10   >