On Wed, Dec 5, 2012 at 7:43 PM, Dan Carpenter wrote:
> line6_send_sysex_message_async() isn't called from anywhere.
>
> Signed-off-by: Dan Carpenter
Reviewed-by: Stefan Hajnoczi
___
devel mailing list
devel@linuxdriverpr
This series addresses the remaining checkpatch.pl warnings that are easy to
fix. This takes the line6 driver another step closer to getting merged as an
ALSA driver.
Stefan Hajnoczi (6):
staging: line6: rename MidiBuffer to avoid CamelCase
staging: line6: wrap comment to 80 chars in driver.c
sound/oss/midibuf.c
already uses it for a different concept. Avoid possible confusion by
using "midi_buffer" instead.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.c | 2 +-
drivers/staging/line6/midi.c| 2 +-
drivers/staging/line6/midi.h| 4 ++--
driver
Fix the following checkpatch.pl warning:
WARNING: line over 80 characters
#1107: FILE: staging/line6/driver.c:523:
+ /* Wait for data length. We'll get a couple of 0xff until length
arrives. */
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.c | 2 +-
1
Fix the following checkpatch.pl warning:
WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...
to printk(KERN_ERR ...
#1861: FILE: staging/line6/driver.h:56:
+ printk(KERN_ERR "line6usb driver bug: missing case in %s:%d\n", \
Signed-off-by: Stefa
:
+ if (memcmp(buf + 1, line6_midi_id, sizeof(line6_midi_id)) ==
0) {
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index e542540..1a11906
definition.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/toneport.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/line6/toneport.c b/drivers/staging/line6/toneport.c
index a529dd3..2f44d56 100644
--- a/drivers/staging/line6/toneport.c
+++ b
Fix the following checkpatch.pl warnings:
WARNING: Avoid CamelCase:
#4512: FILE: staging/line6/pod.c:41:
+ POD_monitor_level = 0x04,
WARNING: Avoid CamelCase:
#4513: FILE: staging/line6/pod.c:42:
+ POD_system_invalid = 0x1
Signed-off-by: Stefan Hajnoczi
g should be fixed regardless of
> the status of moving the Line6 driver out of the staging area.
>
> Reported-by: Stefan Hajnoczi
> Signed-off-by: Markus Grabner
Reviewed-by: Stefan Hajnoczi
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
* tcpdump and wireshark support for powerful analysis
* No driver-specific code is required
This is the last user of line6_write_hexdump() so we drop it too.
Signed-off-by: Stefan Hajnoczi
---
Applies on linux-next/master.
drivers/staging/line6/Kconfig| 10 --
drivers/staging
The line6 driver inspects fewer MIDI messages than in previous versions. The
conditionals to match these MIDI messages were left in place. This series
removes unused conditionals in order to make the MIDI post-processing functions
easier to read.
Applies to linux-next/master.
Stefan Hajnoczi
indentation. Only two MIDI messages are still tracked: the
POD version message on startup and monitor level changes originating
from the device.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 96 +
1 file changed, 19 insertions(+), 77
Previous versions of the line6 driver snooped MIDI traffic in order to
make device state accessible via sysfs attributes. This involved a lot
of logic in line6_variax_process_message() that has since been removed.
Drop unused conditionals in line6_variax_process_message().
Signed-off-by: Stefan
On Mon, Feb 25, 2013 at 2:08 PM, Laurent Navet wrote:
> - WARNING: braces {} are not necessary for single statement blocks
>
> Signed-off-by: Laurent Navet
> ---
> drivers/staging/line6/pod.c |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-b
What is the status of the line6 staging driver? There is no TODO file
so I'm not sure what is blocking it from leaving staging.
Thanks,
Stefan
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/d
On Thu, Oct 27, 2011 at 10:05 AM, Greg KH wrote:
> On Thu, Oct 27, 2011 at 09:28:59AM +0100, Stefan Hajnoczi wrote:
>> What is the status of the line6 staging driver? There is no TODO file
>> so I'm not sure what is blocking it from leaving staging.
>
> That's a
On Thu, Oct 27, 2011 at 9:06 PM, Markus Grabner wrote:
> On Thursday 27 October 2011 11:43:21 you wrote:
>> On Thu, Oct 27, 2011 at 10:05 AM, Greg KH wrote:
>> > On Thu, Oct 27, 2011 at 09:28:59AM +0100, Stefan Hajnoczi wrote:
>> >> What is the status of the line
be possible to unify pod.c and podhd.c. I don't have a Pod xt device to
test against so it's hard for me to make this change without help.
Stefan Hajnoczi (2):
staging: line6: accept all MIDI channels by default
staging: line6: add Pod HD300 support
drivers/staging/line6/Makefi
messages are silently filtered out. If filtering is necessary due to
multiple devices on the bus, users can set the midi_mask_transmit and
midi_mask_receive sysfs attributes.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/midi.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions
has 48 kHz audio and
does not respond to Pod SysEx messages.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/Makefile |3 +-
drivers/staging/line6/driver.c | 24 ++-
drivers/staging/line6/pcm.c |1 +
drivers/staging/line6/podhd.c | 158
On Tue, Nov 22, 2011 at 7:15 PM, Greg KH wrote:
> On Tue, Nov 22, 2011 at 08:15:49AM +, stefa...@gmail.com wrote:
>> From: Stefan Hajnoczi
>>
>> Note: this patch applies against Markus' line6linux driver tree:
>> https://line6linux.svn.sourceforge.net
/freeing out of the stream start/stop callbacks to
prevent this race condition.
With these patches PulseAudio, jack, and native ALSA applications work fine. I
also ran a stress test which prepares/starts/stops streams in a loop. This
test triggered kernel panics before applying Patch 4.
Ste
has 48 kHz audio and
does not respond to Pod SysEx messages.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/Makefile |3 +-
drivers/staging/line6/driver.c | 24 ++-
drivers/staging/line6/pcm.c |1 +
drivers/staging/line6/podhd.c | 158
-by: Stefan Hajnoczi
---
drivers/staging/line6/midi.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/staging/line6/midi.c b/drivers/staging/line6/midi.c
index e554a2d..4183904 100644
--- a/drivers/staging/line6/midi.c
+++ b/drivers/staging/line6/midi.c
@@ -173,6
write packet sizes but the driver
currently uses a single size which I chose not to mess with since other
features like software monitoring may depend on a single packet size for
both endpoints.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pcm.c | 11 ---
1 files changed, 8
allocation/freeing in these callbacks.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/capture.c | 15 +++
drivers/staging/line6/pcm.c | 24
drivers/staging/line6/playback.c | 15 +++
3 files changed, 30 insertions(+), 24
On Tue, Nov 22, 2011 at 8:21 PM, Greg KH wrote:
> On Tue, Nov 22, 2011 at 08:11:07PM +0000, Stefan Hajnoczi wrote:
>> On Tue, Nov 22, 2011 at 7:15 PM, Greg KH wrote:
>> > On Tue, Nov 22, 2011 at 08:15:49AM +, stefa...@gmail.com wrote:
>> >> From: Stefan Hajnoczi
On Thu, Nov 24, 2011 at 11:17 AM, Dan Carpenter
wrote:
> On Wed, Nov 23, 2011 at 08:20:42AM +0000, Stefan Hajnoczi wrote:
>> + line6 = &podhd->line6;
>> + if (line6 == NULL)
>> + return;
>
> The address of a pointer is rarely NULL. In th
oved the initialization.
>
> Signed-off-by: Dan Carpenter
Reviewed-by: Stefan Hajnoczi
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
On Mon, Aug 6, 2012 at 1:08 PM, Johannes Thumshirn
wrote:
> Changed call to simple_strtoul to kstrtoint in pcm_set_impulse_volume(...)
>
> Signed-off-by: Johannes Thumshirn
> ---
> drivers/staging/line6/pcm.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
R
tions(+), 4 deletions(-)
Commit description is wrong:
s/strict_kstrtou8/kstrtou8/
Reviewed-by: Stefan Hajnoczi
___
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
There is no reason to limit the number of line6 devices. Drop the
static array.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.c | 20 +---
drivers/staging/line6/driver.h | 2 --
2 files changed, 1 insertion(+), 21 deletions(-)
diff --git a/drivers/staging
The line6 driver does not support 'index' and 'id' module parameters so
there is no need to keep arrays for these values. Do what other sound
drivers do and use the scalar constants instead of dummy arrays.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/audio.c
On Sat, Nov 10, 2012 at 1:55 PM, Daniel Mack wrote:
> Hi,
>
> On 10.11.2012 07:44, Stefan Hajnoczi wrote:
>> The line6 driver supports devices from the Line6 PODxt, POD HD,
>> TonePort, and Variax product families. This USB sound driver has been
>> in staging since
passes checkpatch.pl completely.
Stefan Hajnoczi (8):
staging: line6: wrap >80 char lines in capture.c
staging: line6: fix quoted string across lines in midibuf.c
staging: line6: shorten comment below 80 chars in pcm.c
staging: line6: drop trailing whitespace in pcm.h
staging: line6: w
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/capture.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/line6/capture.c b/drivers/staging/line6/capture.c
index c85c5b6..389c41f 100644
--- a/drivers/staging/line6/capture.c
+++ b/drivers
Checkpatch warns when quoted strings are split across lines. The
rationale is that quoted strings should be left on a single line so that
grep works. (The 80 character line limit does not apply to quoted
strings.)
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/midibuf.c | 6
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pcm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/line6/pcm.c b/drivers/staging/line6/pcm.c
index 7fe44a6..6c1e313 100644
--- a/drivers/staging/line6/pcm.c
+++ b/drivers/staging/line6/pcm.c
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pcm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/line6/pcm.h b/drivers/staging/line6/pcm.h
index 5210ec8..6aa0d46 100644
--- a/drivers/staging/line6/pcm.h
+++ b/drivers/staging/line6/pcm.h
@@ -167,7
There are a few instances of 80+ character lines in playback.c. Two
instances are just because of a useless comment "this is somewhat
paranoid", so drop the comment. Other instances are straightforward
line wrapping.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/playb
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/usbdefs.h | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/line6/usbdefs.h b/drivers/staging/line6/usbdefs.h
index 353d59d..43eb540 100644
--- a/drivers/staging/line6/usbdefs.h
+++ b/drivers
The LED value is an int, so replace strict_strtol() with kstrtoint().
It's safe to pass in the actual variable instead of a local temporary
because strto*() doesn't write to the result unless the function returns
success.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/tone
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index f97416b..1b85ecc 100644
--- a/drivers/staging/line6/variax.c
+++ b/drivers/staging/line6
.
Stefan Hajnoczi (3):
staging: line6: replace DEBUG_MESSAGES() with dev_dbg()
staging: line6: drop unused DEBUG_MESSAGES() macro
staging: line6: drop unused CONFIG_LINE6_USB_DEBUG
drivers/staging/line6/Kconfig | 8 --
drivers/staging/line6/driver.c | 6 ++---
drivers/staging/line6
The dyndbg feature allows dev_dbg() calls to be enabled/disabled at
runtime and is therefore more convenient than static debug log messages.
Use dev_dbg() instead of the line6-specific DEBUG_MESSAGES() macro.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.c | 6 ++---
drivers
The DEBUG_MESSAGES() macro is no longer needed since dev_dbg() is now
used for debug messages.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/line6/driver.h b/drivers/staging/line6/driver.h
index 35246cf
The CONFIG_LINE6_USB_DEBUG option is no longer relevant since dyndbg
dev_dbg() is now used instead of a compile-time decision whether to
enable debug messages or not.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/Kconfig | 8
1 file changed, 8 deletions(-)
diff --git a
On Sun, Nov 11, 2012 at 1:52 PM, Stefan Hajnoczi wrote:
> Daniel Mack suggested the dyndbg mechanism which allows
> dev_dbg() messages to be enabled/disabled at run-time. This is more powerful
> than the compile-time CONFIG_LINE6_USB_DEBUG option.
>
> This patch series converts
mping code as part of the effort to clean up the driver
and get it out of staging.
Stefan Hajnoczi (6):
staging: line6: drop control URB dumping code
staging: line6: drop CONTROL from CONFIG_LINE6_USB_DUMP_ANY
staging: line6: drop unused CONFIG_LINE6_USB_DUMP_CTRL
staging: line6: drop
-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.c | 36
drivers/staging/line6/midi.c | 3 ---
2 files changed, 39 deletions(-)
diff --git a/drivers/staging/line6/driver.c b/drivers/staging/line6/driver.c
index 571f2ce..fda92d1 100644
--- a/drivers
CONFIG_LINE6_USB_DUMP_CTRL is no longer used by the code and therefore
no longer plays a role in CONFIG_LINE6_USB_DUMP_ANY.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/line6/driver.h b
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/Kconfig | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/line6/Kconfig b/drivers/staging/line6/Kconfig
index a5ded12..2101799 100644
--- a/drivers/staging/line6/Kconfig
+++ b/drivers/staging/line6/Kconfig
ALSA amidi(1) and aseqdump(1) can be used to dump MIDI instead of
manually dumping MIDI messages in the driver. The advantage of using
these existing tools is that can be used at run-time rather than
compile-time.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.c | 3
CONFIG_LINE6_USB_DUMP_MIDI is no longer used by the code and therefore
no longer plays a role in CONFIG_LINE6_USB_DUMP_ANY.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/line6/driver.h b
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/Kconfig | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/line6/Kconfig b/drivers/staging/line6/Kconfig
index 2101799..80a7202 100644
--- a/drivers/staging/line6/Kconfig
+++ b/drivers/staging/line6/Kconfig
s in the kernel because the driver presents an ALSA
volume control.
Stefan Hajnoczi (46):
staging: line6: drop channel sysfs attr
staging: line6: drop clip sysfs attr
staging: line6: drop unused param_dirty bitmap
staging: line6: drop dirty sysfs attr
staging: line6: drop dump sysfs attr
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 51 -
drivers/staging/line6/pod.h | 5 -
2 files changed, 56 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 4a86f7a..e3e2247 100644
--- a
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 23 ---
drivers/staging/line6/pod.h | 5 -
2 files changed, 28 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index e3e2247..4abe2de 100644
--- a/drivers/staging/line6
The param_dirty bitmap tracks which parameters have been modified since
saving a preset. The bitmap is never used though so we can drop this
deadcode.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 16
drivers/staging/line6/pod.h | 5 -
2 files changed
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 21 +
drivers/staging/line6/pod.h | 5 -
2 files changed, 1 insertion(+), 25 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 8fdbe9f..7c76b65 100644
--- a/drivers
Once further sysfs attrs have been removed it will also be possible to
drop prog_data and other pieces which we keep for now.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 60 +++--
1 file changed, 3 insertions(+), 57 deletions(-)
diff
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 40
1 file changed, 40 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 56eab0a..c1eb145 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers
The monitor level can be adjusted using an ALSA volume control.
Therefore the sysfs attribute is unnecessary. Note that we leave the
monitor_level driver variable so that the ALSA volume control still
works.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 12
1
The monitor_level sysfs attr has been dropped and we never need to wait
on the monitor_level value to change. Switch to a plain int and drop
the wait queue.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 10 +-
drivers/staging/line6/pod.h | 2 +-
2 files changed, 6
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 165c7ad..76525c5 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers/staging/line6/pod.c
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index dbf821e..6d6cd5a 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers/staging/line6/pod.c
@@ -628,16
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 48 -
1 file changed, 48 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index bc65fc7..95769c5 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 43 ---
1 file changed, 43 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 76525c5..dbf821e 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 6d6cd5a..bc65fc7 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers/staging/line6/pod.c
@@ -608,16
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 95769c5..deafee9 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers/staging/line6/pod.c
@@ -565,16
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index deafee9..abf7ebe 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers/staging/line6/pod.c
@@ -545,16
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 68 -
1 file changed, 68 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index abf7ebe..949b8f7 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 8
drivers/staging/line6/pod.h | 9 -
2 files changed, 17 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 949b8f7..f84a4ea 100644
--- a/drivers/staging/line6/pod.c
+++ b
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 8
drivers/staging/line6/pod.h | 5 -
2 files changed, 13 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index f84a4ea..3184570 100644
--- a/drivers/staging/line6/pod.c
+++ b
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 7 ---
drivers/staging/line6/pod.h | 5 -
2 files changed, 12 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 3184570..57fbe27 100644
--- a/drivers/staging/line6/pod.c
+++ b
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 34 --
drivers/staging/line6/pod.h | 5 -
2 files changed, 39 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 57fbe27..df2f37a 100644
--- a/drivers
the ALSA volume control should reflect the current
monitor volume level used by the device. Therefore, drop the switch
statement entirely and just check for POD_monitor_level, ignoring
unknown system parameter changes.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 102
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 052db4a..797f6e0 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers/staging/line6/pod.c
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 36
1 file changed, 36 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index 797f6e0..37b20d7 100644
--- a/drivers/staging/line6/pod.c
+++ b/drivers/staging
se of this feature. Therefore we drop it as part of the effort to
clean up the staging driver.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/driver.c | 5 -
drivers/staging/line6/midi.c | 42 --
drivers/staging/line6/midi.h | 5 -
3
of it. Therefore we drop it and rely on applications or
MIDI sequencers to select the channels used for communication.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/midi.c | 56
drivers/staging/line6/midi.h | 5
2 files change
state after a dump
request have been dropped.
Therefore we can safely remove this dead code.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/midi.c | 22 --
drivers/staging/line6/pod.c | 34 --
drivers/staging/line6/pod.h | 7 -
The raw sysfs attr transmits MIDI messages with less filtering. This
was a useful debugging tool while the staging driver still had a lot of
state and filtering. It is not useful anymore since the filtering is
being dropped.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 13
The pod_set_system_param_int() helper function is only used to set the
monitor level. Previously it was also used to control the tuner and has
special checks. These checks can now be dropped, along with the tuner
constants.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 21
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 38 --
drivers/staging/line6/variax.h | 5 -
2 files changed, 43 deletions(-)
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index 8df529f..e76255b 100644
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 42 --
drivers/staging/line6/variax.h | 5 -
2 files changed, 47 deletions(-)
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index e76255b..ef78f5a
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 42 --
drivers/staging/line6/variax.h | 5 -
2 files changed, 47 deletions(-)
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index ef78f5a..31ece34
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 27 ---
1 file changed, 27 deletions(-)
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index 31ece34..94a9f71 100644
--- a/drivers/staging/line6/variax.c
+++ b/drivers
The get_string() function is no longer used so drop it too.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 34 --
drivers/staging/line6/variax.h | 5 -
2 files changed, 39 deletions(-)
diff --git a/drivers/staging/line6/variax.c b
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 20
1 file changed, 20 deletions(-)
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index 8eec139..0f1846e 100644
--- a/drivers/staging/line6/variax.c
+++ b/drivers/staging
The get_string() function has no other callers so remove it too.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 36
1 file changed, 36 deletions(-)
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 22 --
drivers/staging/line6/variax.h | 5 -
2 files changed, 27 deletions(-)
diff --git a/drivers/staging/line6/variax.c b/drivers/staging/line6/variax.c
index 4600d24..4db21a3 100644
--- a/drivers
Note that VARIAX_SYSEX_ACTIVATE was never used so drop it along with the
other VARIAX_SYSEX_* constants which are now unused.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/variax.c | 73 --
1 file changed, 73 deletions(-)
diff --git a/drivers
ypass the filtering ("raw").
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/Kconfig | 11 ---
drivers/staging/line6/driver.c | 14 --
2 files changed, 25 deletions(-)
diff --git a/drivers/staging/line6/Kconfig b/drivers/staging/line6/Kconfig
index a
Since the driver no longer needs to keep state of device parameters it
is no longer necessary to refresh state when messages that affect other
parameters are sent. Drop the code to trigger a dump when amp/effects
are changed.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 9
The driver no longer keeps state of MIDI-accessible device parameters.
Drop the buffers but be careful to keep the device startup procedure
working even though we no longer store the contents of the dump request.
The startup procedure will be simplified in a later patch.
Signed-off-by: Stefan
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c | 11 ---
drivers/staging/line6/pod.h | 5 -
2 files changed, 16 deletions(-)
diff --git a/drivers/staging/line6/pod.c b/drivers/staging/line6/pod.c
index e892b4a..f8257be 100644
--- a/drivers/staging/line6/pod.c
+++ b
The pod startup procedure dumps model data. This is no longer useful
since the sysfs attrs which expose this information to userspace have
been removed. The dump request wasn't been processed anymore.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/pod.c
The sysfs attrs to access the model dump have been removed so it's safe
to drop the model_data field. The next step will be to simplify the
startup process since we no longer need to fetch this data via dump
requests, but that will be done in a later patch.
Signed-off-by: Stefan Haj
The line6 drive no longer requests MIDI dumps from the device so
dumprequest.c is not needed.
Signed-off-by: Stefan Hajnoczi
---
drivers/staging/line6/Makefile | 1 -
drivers/staging/line6/dumprequest.c | 135
drivers/staging/line6/dumprequest.h | 76
101 - 200 of 1001 matches
Mail list logo