Lee Revell wrote:
> Servers are still the most important Linux market,
To whom?
--
Stefan Richter
-=-=-=== --=- -=-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo
on of the dmesg buffer via
configuration ROM would be warranted. Or is it feasible to find the
dmesg buffer by plain memory analysis?
--
Stefan Richter
-=-=-=== --=- -=-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
, is this struct padded on 64bit platforms?
If so, would
struct raw1394_cycle_timer {
__u64 local_time;
__u32 cycle_timer;
};
be padded too?
--
Stefan Richter
-=-=-=== --=- -=-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the
Andi Kleen wrote:
> On Saturday 10 February 2007 14:51, Stefan Richter wrote:
>> Could be handled via linux1394-2.6.git, although a
>> different channel where the actual users of this facility watch would
>> IMO be more appropriate.
>
> It's more related to arch co
ould if there was an interrupt handler...
- "depends on X86_64" is missing in Kconfig.
- Maybe put it into arch/x86_64/drivers/ instead of drivers/ieee1394?
- Plus what I mentioned earlier in the thread.
I could send code to address some of this at next weekend or later.
--
Stefan Richte
1394's .suspend and .resume
didn't test with actual external devices or gave up when they figured
that the problem reaches into upper subsystem layers. (We still haven't
tested interaction with most of the IEEE 1394 high level.)
--
Stefan Richter
-=-=-=== --=- -=-==
http://arcg
o that the ratio of protocol overhead to net
data payload stays minimal.
--
Stefan Richter
-=-=-=== --=- -==--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.k
Rafael J. Wysocki wrote:
>> Why a new flag?
>
> For example, there are drivers that define .suspend() and .resume() which
> do not work correctly and we can use the flag to mark them.
Depending on how serious the problems with these .suspend/.resume()s
are, you could also put a printk in them or
Palmers (1):
ieee1394: cycle timer read extension for raw1394
Stefan Richter (1):
ieee1394: fix another deadlock in nodemgr
--
Stefan Richter
-=-=-=== --=- =---=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of
to 2.6.16.y too. I don't have a machine
to test personally, but it is quite obvious.
The mentioned bigger patch has been merged by Linus between 2.6.20 and
2.6.21-rc1.
--
Stefan Richter
-=-=-=== --=- =-=-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubsc
I wrote:
> I hope you can extract the patch from this MIME attachment.
Probably not unless I attach it for real.
--
Stefan Richter
-=-=-=== --=- =-=-=
http://arcgraph.de/sr/
Subject: [PATCH] Missing critical phys_to_virt in lib/swiotlb.c
From: David Moore <[EMAIL PROTECTED]>
Date
cp took
> relatively long and afterwards I noticed the logged things.
> Do I need to post this in bugzilla?
You could do so, but most importantly you should try to be more specific
in the message subject and in the selection of addressees. :-)
--
Stefan Richter
-=-=-=== -=-- ==-=-
htt
Simon Arlott wrote:
> Fix the "attempting to setting" message in ohci1394.
Committed to linux1394-2.6.git and queued for merge.
--
Stefan Richter
-=-=-=== -=-- ==-==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
t
Adrian Bunk wrote:
> highlevel_host_reset no longer has any modular users.
Thanks, I missed this when I removed the last usage outside the 1394
core. Committed to linux1394-2.6.git.
--
Stefan Richter
-=-=-=== -=-- ==-==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the l
devel or -user mailinglist (but often in combination with
bugzilla),
- bugzilla,
- ...?,
- personal e-mail. (Just don't do it.)
But I do understand why the opener of this thread preferred personal
e-mail; he has explained it multiple times now. He has valid points,
although they don
ot;backported" to 2.6.x.y and to
various distributor kernels.
--
Stefan Richter
-=-=-=== -=-- ==-==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
like it a lot. But perhaps only because I
have to untangle some -mm differences for this.)
--
Stefan Richter
-=-=-=== -=-- ==-==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Jan Engelhardt wrote:
> On Apr 27 2007 22:56, Stefan Richter wrote:
>
>>> -config IEEE1394
>>> +menuconfig IEEE1394
>>> tristate "IEEE 1394 (FireWire) support"
>>> depends on PCI || BROKEN
>>> select NET
>> [...]
>&
Jan Engelhardt wrote:
> On Apr 28 2007 12:41, Stefan Richter wrote:
>> So, shall I put Jan's patch aside until there is only one stack left?
>
> Sort of.
[...]
> when a menu has
> two or three choices (in this case: larger subsystems), it's rand()
> for me wheth
nsibly be DEPRECATED and OBSOLETE at the same
time.
(This also means the correct term is not maturity /levels/, but
maturity attributes or the like.)
--
Stefan Richter
-=-=-=== -=-- ===--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
Robert P. J. Day wrote:
> On Sat, 28 Apr 2007, Stefan Richter wrote:
>> Robert P. J. Day wrote:
>>> http://fsdev.net/wiki/index.php?title=Maturity_levels
...
>> - Your argument should include what the benefits of exposing
>> DEPRECATED and OBSOLETE as machine-pa
es not mean "is subject to currently ongoing
experiments" but rather "is unfinished code which is known to work
incorrectly sometimes".
--
Stefan Richter
-=-=-=== -=-- ===--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
elf, I filed
these complaints of mine under
http://bugzilla.kernel.org/show_bug.cgi?id=8396
http://bugzilla.kernel.org/show_bug.cgi?id=8397
http://bugzilla.kernel.org/show_bug.cgi?id=8394
in hope that they are taken into consideration by those who maintain the
site.
--
Stefan Richter
-=-=-=== -=
Robert P. J. Day wrote:
> On Sat, 28 Apr 2007, Stefan Richter wrote:
>> And that benefit is...? :-)
...
> if you're not convinced, there's nothing else i can think of to say
> that will persuade you.
It didn't come across this way, sorry, but I didn't ask a
b: [...] This term is used to refer
to /obsolete/ structures that should not be used for new applications".
Emphasis is mine.
I can agree with this and the other definitions at this search result.
> p.s. just FYI, even *i'm* getting bored of this. :-)
I thought so. :-)
--
Stefan Ri
o drag this out too much longer.
At least my pestering seems to lead to increasing precision in your
wordings. And believe me, precision in a feature removal process is
valuable for each party involved.
--
Stefan Richter
-=-=-=== -=-- ===-=
http://arcgraph.de/sr/
-
To unsubscribe from this
age without presentational ballast allows for creation of a
multitude of fine-tuned configurator UIs/scripts, which can be extended
by all sorts of features, e.g. better support in dealing with obsolete
configuration options.
--
Stefan Richter
-=-=-=== -=-- ===-=
http://arcgraph.de/sr/
-
To unsu
o properly
define the problem. Bugzilla becomes useful after a report reached a
minimum level of quality (after minimum initial triage) and if the bug
can be clearly associated with a maintained subsystem of the kernel (as
e.g. Linus already pointed out in this thread).
--
Stefan Richter
-
r on mailinglists.
PS: Of course what _does_ work better on mailinglists than on bugzilla
is to recognize duplicates as such in the first place, when the symptoms
seem only loosely related. (I.e. seeing the big picture and recognize
patterns.)
--
Stefan Richter
-=-=-=== -=-- ===-=
http://arc
irrelevant for subsystems where there are less than three or two persons
who steadily hunt bugs anyway. At the field I work on, I wouldn't have
anybody else to bring in in the first place, except that I sometimes
suggest to reporters to subscribe to a bug ticket.
--
Stefan Richter
-=-=-=
who don't know much
about how the Linux guys handle bugs, and has to keep the reporters
involved up until a bug can be closed. IOW it has to be compatible with
integrators, developers, and reporters/testers. Luckily though, not all
of them need all of that system's features. ('syst
post
2.6.21 pull request I'll send out RSN, unless your patch bypasses me
somehow.
--
Stefan Richter
-=-=-=== -=-- ===-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo in
class_Device.)
drivers/ieee1394/eth1394.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
Stefan Richter (1):
ieee1394: fix oops on "modprobe -r ohci1394" after network class_device
conversion
>From 7a9eeb2fa1b3a3a83670b9ba08dd396beedb88f8 Mon Sep 17 00:00:00 2001
From: S
Fix NULL pointer dereference on hot ejection of a FireWire card while
dv1394 was loaded. http://bugzilla.kernel.org/show_bug.cgi?id=7121
I did not test card ejection with open /dev/dv1394 files yet.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Picked from 2.6.21-rc1.
drivers/ie
Fix NULL pointer dereference on hot ejection of a FireWire card while
dv1394 was loaded. http://bugzilla.kernel.org/show_bug.cgi?id=7121
I did not test card ejection with open /dev/dv1394 files yet.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Backport from 2.6.21-rc1.
d
; clause for this
> option includes "m", forcing this (and all other four entries in that
> Kconfig file, by the way) to be built as modules, while the help text
> for all five entries suggests you can select "y".
>
> as jack nicholson would say, something'
+61,6 @@ config PCMCIA_NINJA_SCSI
>
> config PCMCIA_QLOGIC
> tristate "Qlogic PCMCIA support"
> - depends on m
> help
> Say Y here if you intend to attach this type of PCMCIA SCSI host
> adapter to your computer.
> @@ -72,7 +7
fixes http://bugzilla.kernel.org/show_bug.cgi?id=7793 .
Autoloading of eth1394 when an _external_ IP-over-1394 capable device is
discovered is _not_ affected by this patch.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Instead of keeping this until the proposed date of removal (June 2007
he resulting code is
a lot nicer. I prefer this updated patch and I consider it a candidate
for before 2.6.22-rc1.
From: Stefan Richter <[EMAIL PROTECTED]>
Subject: ieee1394: eth1394: don't autoload by hotplug when ohci1394 starts
Until now, ieee1394 put an IP-over-1394 capability entry i
Russ Meyerriecks wrote:
> If anybody has any bug fixes or features maybe they never got
> around to,
http://bugzilla.kernel.org/buglist.cgi?bug_status=NEW&bug_status=ASSIGNED
has 1504 hits right now.
> and would be suitable for this situation,
This may be a problem.
--
S
own thread for
any further bus management purposes, a workqueue looks suitable for hot
plugging and unplugging.
--
Stefan Richter
-=-=-=-= =--- ==---
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAI
Kristian Høgsberg wrote:
> Pull this define out of drivers/ieee1394/ohci1394.c and rename to match
> other PCI class defines.
Committed to linux1394-2.6.git.
--
Stefan Richter
-=-=-==- ==-- =--=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe l
Robert P. J. Day wrote:
> On Sat, 16 Dec 2006, Stefan Richter wrote:
>> Works for me, but I don't see a lot of benefit from it. Actually I see
>> two disadvantages of the patch:
>
> ... snip ...
>
>> - There are two out-of-tree Fi
Gene Heskett wrote:
> On Sunday 17 December 2006 20:05, Stefan Richter wrote:
>>What's missing in our implementation is that the use count of ohci1394
>>goes up too once a "high-level driver" uses resources of a host driven
>>by ohci1394.
>
> This ne
is merely that the
few people who know the driver stack well enough didn't use suspend/
resume support on their own machines yet.
As for Kristian's stack, suspend/resume support can probably be added
quite easily, especially after I got the missing bits working in the
mainline s
ochronous API.
>
> which will allow us to move most user space applications to the new
> stack.
...
--
Stefan Richter
-=-=-==- ==-- =-=--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PR
Kristian Høgsberg wrote:
> Stefan Richter wrote:
>> Actually there are also eth1394 and pcilynx to be pulled over. Eth1394
>> should be quite easy to do for anybody after iso reception is settled in
>> your stack. Pcilynx could follow depending on developer interest. It
t. There should be an option (and it should be the default) to
let eth1394 load its ROM entries == don't automatically modprobe eth1394
as soon as the low level set up a host adapter.
--
Stefan Richter
-=-=-==- ==-- =-=--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line &q
for 1394b
or mixed environments. (Even though the latter would also clearly
benefit from it.)
--
Stefan Richter
-=-=-==- ==-- =-=--
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More major
k vs. new stack vs. both stacks condenses to a radio button
in a single IEEE 1394 config menu, and for a potential brief period
during which both stacks live in mainline together that way. But if
nobody else complains, I'll include it as drivers/firewire.)
--
Stefan Richter
-=-=-==- ==-- =-=
ptimization for 1394a environments and no optimization for 1394b
> or mixed environments. (Even though the latter would also clearly
> benefit from it.)
^^ "it" == "a reduced gap count"
--
Stefan Richter
-=-=-==- ==-- =-=--
http://arcgraph.de/sr/
-
To
f most of the commits to
this tree. From now on I will always do this on commits affecting
mainline's FireWire stack, and prepend "firewire:" to the titles of
commits affecting the JUJU stack. It's redundant but IMO helpful when
reading changelogs.
--
Stefan Richter
-=-
rantees write transactions reach the PCI
>
>already do this.
>
>> +device before the CPU can continue. Writes to MMIO space allow to CPU
^^
>> +continue before the transaction reaches the PCI device. HW weeni
Benjamin Herrenschmidt wrote:
>> Bisecting has identified this commit:
>>
>> commit 9b7d9c096dd4e4baacc21b2588662bbb56f36c4e
>> Author: Stefan Richter <[EMAIL PROTECTED]>
>> Date: Wed Nov 22 21:44:34 2006 +0100
>>
>> ieee1394: sbp2: conver
40 insertions(+), 43 deletions(-)
commit 97d552e35d9404df3254e1157df3340e4e2eaedc
Author: Stefan Richter <[EMAIL PROTECTED]>
Date: Fri Dec 29 23:47:04 2006 +0100
ieee1394: sbp2: fix bogus dma mapping
Need to use a PCI device, not a FireWire host device. Problem found by
mapping
> infrastructure cannot figure out from the generic device (contained in a
> pci_device) compared to the pci_device?
Or are there some restrictions implicit in mappings via pci_dma_ API
which are lifted when using mappings via dma_ API?
--
Stefan Richter
-=-=-=== ---= ---=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
28MiB :) and that is it. Now, I could just put 128, but what if
> somebody changes that, or in some new distro suddenly decides to make it
> different? Even worse, what if it is an old kernel with 64 setting?
[...]
Maybe somebody at LKML has answers?
--
Stefan Richter
-=-=-=== ---= -
loc=536870912 to the
| > line that defines the kernel parameters. (If you use grub there should
| > be a line like this on /boot/grub/menu.lst)
| >
| > kernel /boot/vmlinuz-2.6.15-27-686 root=/dev/sda2
| > vmalloc=536870912 ro quiet splash
| >
| >
| > That killed my
On 14 Jan, Richard Knutsson wrote:
> Stefan Richter wrote:
>> gcc -o test3.o test.c test.c
>>
> That produces just an executable file with a misleading name :)
#-)
[...]
>> 3. When people notice that patches are misdirected too often, they will
>>update MAIN
On 14 Jan, Richard Knutsson wrote:
> (Really liked the idea to have a "Maintainer"-button
> next to "Help" in *config)
Rhetorical question: What will this button be used for?
--
Stefan Richter
-=-=-=== ---= -===-
http://arcgraph.de/sr/
-
To unsubscribe fro
On 15 Jan, Matthias Schniedermeyer wrote:
> Stefan Richter wrote:
>> On 14 Jan, Richard Knutsson wrote:
>>>(Really liked the idea to have a "Maintainer"-button
>>>next to "Help" in *config)
>>
>> Rhetorical question: What will th
f a split transaction, the ack indeed confirms proper reception
of the request. In case of a unified transaction, it is even possible to
encapsulate a write response in the ack, i.e. to complete the
transaction with the ack to the request. Needless to say, unified
transactions require special support
our kind of
application.
Anyway. Do you still want a patch like the following one? Should apply
to 2.6.20-rcX but you should have no difficulties to adapt it to 2.6.19
or older. (The first hunk won't apply before 2.6.20-rc1.)
From: Stefan Richter <[EMAIL PROTECTED]>
Subject: ieee1394: allo
On 15 Jan, Richard Knutsson was...
> thinking of trying to implement it
I'd say go ahead and test your idea.
--
Stefan Richter
-=-=-=== ---= -
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message t
On 15 Jan, Olivier Galibert wrote:
> sd 0:0:0:0: SCSI error: return code = 0x0802
> sda: Current: sense key: Hardware Error
> ASC=0x42 ASCQ=0x0
The Additional Sense Code means "power-on or self-test failure" FWIW.
(SPC-4 annex D)
--
Stefan Richter
-=-=-
Note, sbp2's optional parameter serialize_io=0 does not work correctly
yet with some devices (it never did), therefore use sbp2 with anything
than default parameters if there are problems.
--
Stefan Richter
-=-=-=== ---= =--=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send
the rest of this bullshit?
>
> You talk for everybody, or is it just your (and only your) mind refusing
> to accept new terms?
I'd say it is the refusal to accept new *dumb* terms.
--
Stefan Richter
-=-=-=== ---= =-=-=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send th
>>> Adrian Bunk wrote:
>>>> This patch contains the following cleanups:
>>>> - "extern inline" -> "static inline"
>>>> - fw-topology.c: make struct fw_node_create static
Committed to linux1394-2.6.git.
--
Stefan Richter
-
ate of fixes or feature additions.
It's also not only a question of who writes such release notes, but also
of who the intended audience is. How fine-grained should the release
notes be?
Anyway --- if in doubt, your distributor's current kernel is the best one.
--
Stefan Richter
-=-
atch. What do you say?
This cannot be measured objectively.
--
Stefan Richter
-=-=-=== ---= =-===
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/
lso be Cc'd to linux-kernel or specialized lists like linux-scsi
or linuxppc-dev etc. depending on the issue. I think linux1394-devel can
bear the additional traffic from this new development.
The question is whether you will post what you wrote, or if I will post
what I pulled from
ime.
Kristian just announced
http://gitweb.freedesktop.org/?p=users/krh/linux-2.6.git
git://people.freedesktop.org/~krh/linux-2.6
shortly before you posted.
(And time-lagged/ filtered versions: kernel.org's linux1394-2.6.git, and
non-canonical patchkits for 2.6.{18,19,20} on my homep
one who knows details.
News on linux1394 mailing list indicates that it should
be back soon (or should have been back soon)...
Stefan Richter has tarballs of his svn checkouts here:
http://me.in-berlin.de/~s5r6/linux1394/
BTW, the Linux1394 mailinglists can be accessed from
http
Since there aren't many
mapped ORBs per target, a linked list is a reasonable data structure to
search over. That said --- Kristian, doesn't fw-sbp2 have at most 1 ORB
in sd->orb_list?
--
Stefan Richter
-=-=-=== ---= ==-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: sen
Pete Zaitcev wrote:
> On Fri, 26 Jan 2007 03:35:19 +0100, Stefan Richter <[EMAIL PROTECTED]> wrote:
>> The target wrote an SBP-2 status block into our memory. The status block
>> contains the FireWire bus address of the ORB to which it belongs. [...]
>
> I see. SRP ha
4 has a number of more serious
issues pending at bugzilla.kernel.org, and meanwhile people are eager to
run things like FreeBob or Kino on Juju --- thus it remains to be seen
who of us gets to it first. :-)
--
Stefan Richter
-=-=-=== ---= ==-=-
http://arcgraph.de/sr/
-
To unsubscribe from this li
ocking to a single lock
per host.
- Audit the selfID complete event handling, including what happens
higher up in ieee1394 core, for the possibility to move workload
into tasklets or workqueue jobs.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Robert, does this do any
r migrates to a another
CPU between two interrupt events in quick succession.
Can the latter happen in Linux or/and with -rt kernels?
--
Stefan Richter
-=-=-=== ---= ==-=-
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the bo
Pieter Palmers wrote:
> cc'ing linux1394-devel because it seems to be a problem in the ieee1394
> stack.
Yes, this bug is in stock Linux 2.6 too. Ever has been.
http://bugzilla.kernel.org/show_bug.cgi?id=7121
--
Stefan Richter
-=-=-=== ---= ==-=-
http://arcgraph.de/sr/
-
To unsub
Pieter Palmers wrote:
> Stefan Richter wrote:
>> http://bugzilla.kernel.org/show_bug.cgi?id=7121
> Oops, missed that. Sorry for the noise.
No, it's OK. We have a pile of old open bugs, and those that are rubbed
in our face more often might even get a chance to be fixed some day.
>
> We can't use cmpxchg in generic code.
From: Stefan Richter <[EMAIL PROTECTED]>
Subject: firewire: use atomic type for fw_device.state
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/firewire/fw-card.c |2 +-
drivers/firewire/fw-device.c |6
imple: I don't need dv1394, so I just don't
> build it anymore. It has the annoying tendency to auto-load when raw1394
> is loaded.
This is a correlation but not a causality. dv1394's and raw1394's
_device_id tables for driver matching both match AV/C devices.
--
Ste
evision 168)
> +++ src/main.c(working copy)
> @@ -478,3 +478,15 @@
> return 0;
> }
>
> +int raw1394_read_cycle_timer(raw1394handle_t handle, struct
> raw1394_cycle_timer *ctr)
> +{
> + int err;
> +
> + err = ioctl(handle->fd, RAW1394_IOC_G
Pieter Palmers wrote:
> Stefan Richter wrote:
>> Thus?
>> preempt_disable();
>> local_irq_save(flags);
>>
>> read_cycle_timer;
>> read_time_of_day;
>>
>> local_irq_restore(flags);
>> preempt_enable();
>>
>&
small coding style touch-up and terser coding
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/ieee1394/dv1394.c | 36 +---
1 files changed, 13 insertions(+), 23 deletions(-)
Index: linux-2.6.20-rc6/drivers/ieee1394/dv
Fix NULL pointer dereference on hot ejection of a FireWire card while
dv1394 was loaded. http://bugzilla.kernel.org/show_bug.cgi?id=7121
I did not test card ejection with open /dev/dv1394 files yet.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/ieee1394/dv1394.c
l of the SCSI disk (i.e.
> writing 1 to its "delete" file in sysfs, what scsiadd -r does).
Isn't sd_shutdown called at this occasion?
--
Stefan Richter
-=-=-=== ---= =
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
gt;{pci_device_remove+33}
> {__device_release_driver+120}
>{driver_detach+202}
> {bus_remove_driver+111}
>{driver_unregister+13}
> {pci_unregister_driver+26}
>{sys_delete_module+406}
> {tracesys+209}
>
>
> Any idea ? (if any, please cc [EMAIL P
ove it to other ieee1394_core high-level API functions.
- Rename userspace-exported struct _raw1394_cycle_timer to
raw1394_cycle_timer. Change comments in raw1394.
- Adjust whitespace.
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
Pieter, Dan, is this OK? I only compile-teste
e
> +#include
> +#include
>
> #include
>
Is the correct header for local_irq_save/
local_irq_restore? It seems to be under Linux 2.6.16 but
I'm not sure about later kernels.
--
Stefan Richter
-=-=-=== --=- ---==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send
Pieter Palmers wrote:
> Stefan Richter wrote:
...
>> - Fix integer overflow.
> I had to use 100ULL instead of USEC_PER_SEC to avoid weird behavior.
OK, I'll change that and will wait for...
> I can't test it right now, but I'll report later.
...your and Dan
I wrote:
> - Rename userspace-exported struct _raw1394_cycle_timer to
> raw1394_cycle_timer.
Argh. This makes maintenance of libraw1394's header files more
difficult. I will revert this to _raw1394_cycle_timer, unless somebody
has a better idea how to deal with this issue.
t; #endif /* IEEE1394_RAW1394_H */
Pieter,
one more thing. Do you want to hand out the cycle_timer bitfield to
userspace as-is, or would it make sense to postprocess it in some way?
--
Stefan Richter
-=-=-=== --=- ---==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line &qu
HYS_ADDRESS(sg))
> - sync_single(hwdev, (void *) sg->dma_address,
> + sync_single(hwdev, phys_to_virt(sg->dma_address),
> sg->dma_length, dir, target);
> }
>
--
Stefan Richter
-=-=-=== --=-
butes (CONFIG_IEEE1394_OUI_DB)
> -When:January 2007
> -Files: drivers/ieee1394/: oui.db, oui2c.sh
> -Why: big size, little value
> -Who: Stefan Richter <[EMAIL PROTECTED]>
> -
> --------
> -
This hunk is wrong.
--
Stefan Richter
-=-=-=== ---= -
(0) CYC_CLK_ACC(255)
capabilities: 0x0083c0
vendor_id: 0x000104 DVICO Co., Ltd.
vendor_name_kv: DViCO
1:ffc2 0001041010004beb DVICO Co., Ltd. 'MOMOBAY CX-1'
IRMC(0) CMC(0) ISC(0) BMC(0) PMC(0) GEN(0)
LSPD(2) MAX_REC(2048) MAX_ROM(0) CYC_CLK_ACC(255)
o delete drivers/ieee1394/.gitignore. I'll do so when I
commit your patch, if nobody objects.
--
Stefan Richter
-=-=-=== ---= ---==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More m
|7 --
> drivers/ieee1394/ieee1394_core.c | 22 -
> 3 files changed, 37 deletions(-)
...
Committed to linux1394-2.6.git with the proper section of
feature-removal-schedule.txt pulled out.
--
Stefan Richter
-=-=-=== ---= ---==
http://arcgraph.de/
7145 deletions(-)
delete mode 100644 drivers/ieee1394/.gitignore
delete mode 100644 drivers/ieee1394/oui.db
delete mode 100644 drivers/ieee1394/oui2c.sh
--
Stefan Richter
-=-=-=== ---= ---==
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel&q
#ifdef PCMCIA is only true if compiled inside pcmcia-cs, isn't it?
Signed-off-by: Stefan Richter <[EMAIL PROTECTED]>
---
drivers/ieee1394/ohci1394.c |9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
Index: linux/drivers/ieee1394
1201 - 1300 of 1597 matches
Mail list logo