Author: svenvh
Date: Mon Sep 9 07:39:20 2019
New Revision: 371403
URL: http://llvm.org/viewvc/llvm-project?rev=371403&view=rev
Log:
Merge note_ovl_builtin_candidate diagnostics; NFC
There is no difference between the unary and binary case, so
merge them.
Modified:
cfe/trunk/include/clang/Ba
Author: svenvh
Date: Thu Sep 5 03:01:24 2019
New Revision: 371046
URL: http://llvm.org/viewvc/llvm-project?rev=371046&view=rev
Log:
[OpenCL] Add image type handling for builtins
Image types were previously available, but not working. This patch
adds image type handling.
Rename the image type d
Author: svenvh
Date: Tue Sep 3 04:23:24 2019
New Revision: 370744
URL: http://llvm.org/viewvc/llvm-project?rev=370744&view=rev
Log:
[OpenCL] Drop spurious semicolon in generated file; NFC
Modified:
cfe/trunk/utils/TableGen/ClangOpenCLBuiltinEmitter.cpp
Modified: cfe/trunk/utils/TableGen/Cla
Author: svenvh
Date: Thu Aug 29 03:21:06 2019
New Revision: 370322
URL: http://llvm.org/viewvc/llvm-project?rev=370322&view=rev
Log:
[OpenCL] Fix diagnosing enqueue_kernel call with too few args
The err_typecheck_call_too_few_args diagnostic takes arguments, but
none were provided causing clang t
Author: svenvh
Date: Tue Aug 20 05:21:03 2019
New Revision: 369373
URL: http://llvm.org/viewvc/llvm-project?rev=369373&view=rev
Log:
[OpenCL] Add const, volatile and pointer builtin handling
Const, volatile, and pointer types were previously available, but not
working. This patch adds handling f
Author: svenvh
Date: Mon Aug 19 04:56:03 2019
New Revision: 369253
URL: http://llvm.org/viewvc/llvm-project?rev=369253&view=rev
Log:
[OpenCL] Add generic type handling for builtin functions
Generic types are an abstraction of type sets. It mimics the way
functions are defined in the OpenCL speci
Author: svenvh
Date: Wed Aug 14 03:30:18 2019
New Revision: 368822
URL: http://llvm.org/viewvc/llvm-project?rev=368822&view=rev
Log:
Fix _WIN32 / _WIN64 Wundef warnings
For these macros it is the definedness that matters rather than
the value. Make new uses of these macros consistent with existi
Author: svenvh
Date: Mon Aug 12 05:44:26 2019
New Revision: 368561
URL: http://llvm.org/viewvc/llvm-project?rev=368561&view=rev
Log:
[OpenCL] Ignore parentheses for sampler initialization
The sampler handling logic in SemaInit.cpp would inadvertently treat
parentheses around sampler arguments as
Author: svenvh
Date: Mon Jul 29 07:55:29 2019
New Revision: 367229
URL: http://llvm.org/viewvc/llvm-project?rev=367229&view=rev
Log:
[OpenCL] Rename builtin definition classes
Factor out some of the renames from D63434 and D63442, and generate
half type convert_ builtins.
Patch by Pierre Gondois
Author: svenvh
Date: Fri Jul 19 02:11:48 2019
New Revision: 366546
URL: http://llvm.org/viewvc/llvm-project?rev=366546&view=rev
Log:
[OpenCL] Define CLK_NULL_EVENT without cast
Defining CLK_NULL_EVENT with a `(void*)` cast has the (unintended?)
side-effect that the address space will be fixed (as
Author: svenvh
Date: Wed Jun 26 06:31:24 2019
New Revision: 364423
URL: http://llvm.org/viewvc/llvm-project?rev=364423&view=rev
Log:
[OpenCL] Improve diagnostic for placement new
Without an explicit declaration for placement new, clang would reject
uses of placement new with "'default new' is not
Author: svenvh
Date: Mon Jun 24 03:06:34 2019
New Revision: 364173
URL: http://llvm.org/viewvc/llvm-project?rev=364173&view=rev
Log:
[OpenCL] Remove more duplicates from opencl-c.h
Identified the duplicate declarations using
sort lib/Headers/opencl-c.h | uniq -c | grep ' 2'
Modified:
Author: svenvh
Date: Mon Jun 24 03:06:40 2019
New Revision: 364174
URL: http://llvm.org/viewvc/llvm-project?rev=364174&view=rev
Log:
[OpenCL] Restore ATOMIC_VAR_INIT
We accidentally lost the ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT macros
in r363794.
Also put the `memory_order` typedef back inside a
Author: svenvh
Date: Fri Jun 21 03:26:10 2019
New Revision: 364020
URL: http://llvm.org/viewvc/llvm-project?rev=364020&view=rev
Log:
[OpenCL] Remove duplicate read_image declarations
Patch by Pierre Gondois.
Modified:
cfe/trunk/lib/Headers/opencl-c.h
Modified: cfe/trunk/lib/Headers/opencl-c
Author: svenvh
Date: Fri Jun 21 03:26:20 2019
New Revision: 364021
URL: http://llvm.org/viewvc/llvm-project?rev=364021&view=rev
Log:
[cmake] Add llvm-dwarfdump to clang test dependencies
Commit r363496 ("[Clang] Harmonize Split DWARF options with llc",
2019-06-15) introduced the use of llvm-dwarf
Author: svenvh
Date: Wed Jun 19 05:48:22 2019
New Revision: 363794
URL: http://llvm.org/viewvc/llvm-project?rev=363794&view=rev
Log:
[OpenCL] Split type and macro definitions into opencl-c-base.h
Using the -fdeclare-opencl-builtins option will require a way to
predefine types and macros such as `
Author: svenvh
Date: Mon Jun 17 03:06:34 2019
New Revision: 363541
URL: http://llvm.org/viewvc/llvm-project?rev=363541&view=rev
Log:
Recommit [OpenCL] Move OpenCLBuiltins.td and remove unused include
Reland r363242 after fixing an issue with the tablegen dependence.
Patch by Pierre Gondois and S
Author: svenvh
Date: Fri Jun 14 05:14:58 2019
New Revision: 363376
URL: http://llvm.org/viewvc/llvm-project?rev=363376&view=rev
Log:
Revert "[OpenCL] Move OpenCLBuiltins.td and remove unused include"
This reverts commit r363242 as it broke some builds with
make[2]: *** No rule to make target '
Author: svenvh
Date: Thu Jun 13 02:54:22 2019
New Revision: 363242
URL: http://llvm.org/viewvc/llvm-project?rev=363242&view=rev
Log:
[OpenCL] Move OpenCLBuiltins.td and remove unused include
Patch by Pierre Gondois.
Differential revision: https://reviews.llvm.org/D62849
Added:
cfe/trunk/lib
Author: svenvh
Date: Mon Jun 3 02:39:11 2019
New Revision: 362371
URL: http://llvm.org/viewvc/llvm-project?rev=362371&view=rev
Log:
[OpenCL] Declare builtin functions using TableGen
This patch adds a `-fdeclare-opencl-builtins` command line option to
the clang frontend. This enables clang to ve
Author: svenvh
Date: Thu May 30 05:35:19 2019
New Revision: 362087
URL: http://llvm.org/viewvc/llvm-project?rev=362087&view=rev
Log:
[OpenCL] Support logical vector operators in C++ mode
Support logical operators on vectors in C++ for OpenCL mode, to
preserve backwards compatibility with OpenCL C
Author: svenvh
Date: Thu May 23 02:20:08 2019
New Revision: 361467
URL: http://llvm.org/viewvc/llvm-project?rev=361467&view=rev
Log:
Enable queue_t and clk_event_t comparisons in C++ mode
Support queue_t and clk_event_t comparisons in C++ for OpenCL mode, to
preserve backwards compatibility with
Author: svenvh
Date: Wed May 22 06:12:20 2019
New Revision: 361382
URL: http://llvm.org/viewvc/llvm-project?rev=361382&view=rev
Log:
[OpenCL] Support pipe keyword in C++ mode
Support the OpenCL C pipe feature in C++ for OpenCL mode, to preserve
backwards compatibility with OpenCL C.
Various chan
Author: svenvh
Date: Fri May 17 02:25:38 2019
New Revision: 361004
URL: http://llvm.org/viewvc/llvm-project?rev=361004&view=rev
Log:
[NFC] Fix line endings in OpenCL tests
Modified:
cfe/trunk/test/CodeGenOpenCL/no-signed-zeros.cl
cfe/trunk/test/SemaOpenCL/array-init.cl
Modified: cfe/trun
Author: svenvh
Date: Wed Apr 17 02:08:50 2019
New Revision: 358566
URL: http://llvm.org/viewvc/llvm-project?rev=358566&view=rev
Log:
[libclang] Expose ext_vector_type
Differential Revision: https://reviews.llvm.org/D60775
Modified:
cfe/trunk/bindings/python/clang/cindex.py
cfe/trunk/incl
Author: svenvh
Date: Mon Feb 11 03:00:56 2019
New Revision: 353690
URL: http://llvm.org/viewvc/llvm-project?rev=353690&view=rev
Log:
[libclang] Add attribute support for 'convergent'.
This bumps CINDEX_VERSION_MINOR up (to 51).
Patch by Hsin-Hsiao Lin.
Differential Revision: https://reviews.llv
Author: svenvh
Date: Thu Nov 1 05:43:00 2018
New Revision: 345825
URL: http://llvm.org/viewvc/llvm-project?rev=345825&view=rev
Log:
Allow clk_event_t comparisons
Also rename `invalid-clk-events-cl2.0.cl` to `clk_event_t.cl` and
repurpose it to include both positive and negative clk_event_t tests
Author: svenvh
Date: Tue Oct 2 06:02:24 2018
New Revision: 343582
URL: http://llvm.org/viewvc/llvm-project?rev=343582&view=rev
Log:
Revert r326937 "[OpenCL] Remove block invoke function from emitted block
literal struct"
This reverts r326937 as it broke block argument handling in OpenCL.
See th
Author: svenvh
Date: Tue Oct 2 06:02:27 2018
New Revision: 343583
URL: http://llvm.org/viewvc/llvm-project?rev=343583&view=rev
Log:
[OpenCL] Add block argument CodeGen test
r326937 ("[OpenCL] Remove block invoke function from emitted block
literal struct", 2018-03-07) broke block argument handli
Author: svenvh
Date: Thu Sep 27 06:20:29 2018
New Revision: 343207
URL: http://llvm.org/viewvc/llvm-project?rev=343207&view=rev
Log:
[OpenCL] Improve extension-version.cl and to_addr_builtin.cl tests
Add cl_khr_depth_images to extension-version.cl.
Extend to_addr_builtin.cl to additionally test
Author: svenvh
Date: Tue Sep 25 05:59:34 2018
New Revision: 342968
URL: http://llvm.org/viewvc/llvm-project?rev=342968&view=rev
Log:
[OpenCL] Allow zero assignment and comparisons between queue_t type variables
This change allows for zero assignment and comparison of queue_t
type variables, and e
Author: svenvh
Date: Mon Sep 24 05:12:03 2018
New Revision: 342876
URL: http://llvm.org/viewvc/llvm-project?rev=342876&view=rev
Log:
Fix Wundef NDEBUG warning; NFC
Check for definedness of the NDEBUG macro rather than its value,
to be consistent with other uses.
Modified:
cfe/trunk/lib/Sema/
Author: svenvh
Date: Thu Sep 20 03:07:27 2018
New Revision: 342638
URL: http://llvm.org/viewvc/llvm-project?rev=342638&view=rev
Log:
[OpenCL] Diagnose redundant address space conversion
Add a warning if a parameter with a named address space is passed
to a to_addr builtin.
For example:
int i;
Author: svenvh
Date: Tue Aug 14 06:56:52 2018
New Revision: 339678
URL: http://llvm.org/viewvc/llvm-project?rev=339678&view=rev
Log:
[OpenCL] Add test for constant sampler argument
Modified:
cfe/trunk/test/SemaOpenCL/sampler_t.cl
Modified: cfe/trunk/test/SemaOpenCL/sampler_t.cl
URL:
http://
Author: svenvh
Date: Thu Jun 14 02:51:54 2018
New Revision: 334700
URL: http://llvm.org/viewvc/llvm-project?rev=334700&view=rev
Log:
[OpenCL] Support new/delete in Sema
Reject uses of the default new/delete operators with a diagnostic
instead of a crash in OpenCL C++ mode and accept user-defined
Author: svenvh
Date: Wed May 9 06:16:17 2018
New Revision: 331874
URL: http://llvm.org/viewvc/llvm-project?rev=331874&view=rev
Log:
[OpenCL] Restrict various keywords in OpenCL C++ mode
Restrict the following keywords in the OpenCL C++ language mode,
according to Sections 2.2 & 2.9 of the OpenCL
Author: svenvh
Date: Tue May 8 06:47:43 2018
New Revision: 331766
URL: http://llvm.org/viewvc/llvm-project?rev=331766&view=rev
Log:
[OpenCL] Factor out language version printing
Generate a printable OpenCL language version number in a single place
and select between the OpenCL C or OpenCL C++ ve
Author: svenvh
Date: Fri Apr 27 03:37:04 2018
New Revision: 331026
URL: http://llvm.org/viewvc/llvm-project?rev=331026&view=rev
Log:
[OpenCL] Add separate read_only and write_only pipe IR types
SPIR-V encodes the read_only and write_only access qualifiers of pipes,
so separate LLVM IR types are r
Author: svenvh
Date: Tue Apr 24 07:47:29 2018
New Revision: 330721
URL: http://llvm.org/viewvc/llvm-project?rev=330721&view=rev
Log:
[OpenCL] Fix diagnostic of thread_local
Commit 08c258670c ("[OpenCL] Generic address space has been added in
OpenCL v2.0.", 2014-11-26) did not mark the thread_loca
Author: svenvh
Date: Mon Apr 23 04:23:47 2018
New Revision: 330579
URL: http://llvm.org/viewvc/llvm-project?rev=330579&view=rev
Log:
[OpenCL] Reject virtual functions for OpenCL C++
Differential Revision: https://reviews.llvm.org/D45873
Added:
cfe/trunk/test/Parser/opencl-cxx-virtual.cl
Modi
Author: svenvh
Date: Tue Mar 27 07:57:56 2018
New Revision: 328626
URL: http://llvm.org/viewvc/llvm-project?rev=328626&view=rev
Log:
Drop spurious break; NFC
Modified:
cfe/trunk/lib/Sema/SemaChecking.cpp
Modified: cfe/trunk/lib/Sema/SemaChecking.cpp
URL:
http://llvm.org/viewvc/llvm-project/
Author: svenvh
Date: Thu Jan 11 06:05:38 2018
New Revision: 322278
URL: http://llvm.org/viewvc/llvm-project?rev=322278&view=rev
Log:
[OpenCL] Reorder the CLK_sRGBx/sRGBA defines, NFC
Swap them so that all channel order defines are ordered according to
their values.
Modified:
cfe/trunk/lib/He
Author: svenvh
Date: Wed Dec 6 02:11:28 2017
New Revision: 319883
URL: http://llvm.org/viewvc/llvm-project?rev=319883&view=rev
Log:
[OpenCL] Fix layering violation by getOpenCLTypeAddrSpace
Commit 7ac28eb0a5 / r310911 ("[OpenCL] Allow targets to select address
space per type", 2017-08-15) made B
Author: svenvh
Date: Mon Dec 4 07:01:08 2017
New Revision: 319658
URL: http://llvm.org/viewvc/llvm-project?rev=319658&view=rev
Log:
[OpenCL] Define __IMAGE_SUPPORT__ macro for SPIR
Add #define __IMAGE_SUPPORT__ 1 for SPIR targets to indicate that SPIR
supports images.
Patch by Dmitry Borisenkov
Author: svenvh
Date: Tue Aug 15 02:38:18 2017
New Revision: 310911
URL: http://llvm.org/viewvc/llvm-project?rev=310911&view=rev
Log:
[OpenCL] Allow targets to select address space per type
Generalize getOpenCLImageAddrSpace into getOpenCLTypeAddrSpace, such
that targets can select the address spa
Author: svenvh
Date: Thu Jun 8 09:22:04 2017
New Revision: 304978
URL: http://llvm.org/viewvc/llvm-project?rev=304978&view=rev
Log:
[libclang] Expose typedef and address space functions
Expose the following functions:
- clang_getTypedefName
- clang_getAddressSpace
Patch by Simon Perretta.
Di
Author: svenvh
Date: Tue May 23 05:36:43 2017
New Revision: 303626
URL: http://llvm.org/viewvc/llvm-project?rev=303626&view=rev
Log:
[libclang] [OpenCL] Expose more OpenCL CIndex types
Expose pipe, sampler_t, clk_event_t, queue_t, reserve_id_t, and all
image types.
Update the opencl-types.cl tes
Author: svenvh
Date: Mon May 8 04:29:06 2017
New Revision: 302411
URL: http://llvm.org/viewvc/llvm-project?rev=302411&view=rev
Log:
[OpenCL] Check that global samplers are const
Patch by Simon Perretta.
Differential Revision: https://reviews.llvm.org/D32856
Modified:
cfe/trunk/include/cla
svenvh added a comment.
Thanks, lgtm!
https://reviews.llvm.org/D24235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
svenvh added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:3732
// If this is an implicit conversion from float -> double, remove it.
if (ImplicitCastExpr *Cast = dyn_cast(OrigArg)) {
The comment should mention float -> float now as well.
svenvh accepted this revision.
svenvh added a comment.
LGTM!
https://reviews.llvm.org/D24235
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
svenvh added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:3431
+.getSupportedOpenCLOpts()
+.cl_khr_fp64) ||
getOpenCLOptions().cl_khr_fp64)) {
yaxunl wrote:
> neil.hickey wrote:
> > yaxunl
201 - 252 of 252 matches
Mail list logo
