Hi,
On 30/10/2024 06:51, Saravana Kannan wrote:
On Tue, Oct 29, 2024 at 4:21 AM Tomi Valkeinen
wrote:
Hi,
On 28/10/2024 22:39, Saravana Kannan wrote:
On Mon, Oct 28, 2024 at 1:06 AM Tomi Valkeinen
wrote:
Hi,
On 26/10/2024 07:52, Saravana Kannan wrote:
In attempting to optimize
Hi Sean,
On 28/10/2024 17:04, Tomi Valkeinen wrote:
Hi,
On 25/10/2024 17:58, Sean Anderson wrote:
Hi Tomi,
On 10/3/24 10:53, Sean Anderson wrote:
On 10/2/24 10:50, Tomi Valkeinen wrote:
Hi,
On 01/10/2024 21:31, Sean Anderson wrote:
On 8/9/24 15:35, Sean Anderson wrote:
This series
Hi,
On 28/10/2024 15:42, Steffen Dirkwinkel wrote:
From: Steffen Dirkwinkel
drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init.
zynqmp_dpsub_kms_init creates the connector and without it we don't
enable hotplug detection.
Fixes: eb2d64bfcc17 ("drm: xlnx: zynqmp_dpsub: Rep
Hi,
On 28/10/2024 15:39, Steffen Dirkwinkel wrote:
From: Steffen Dirkwinkel
layer->info can be null if we have an error on the first layer in
zynqmp_disp_create_layers
Fixes: 1836fd5ed98d ("drm: xlnx: zynqmp_dpsub: Minimize usage of global flag")
Signed-off-by: Steffen Dirkwinkel
---
drive
Hi,
On 25/10/2024 17:58, Sean Anderson wrote:
Hi Tomi,
On 10/3/24 10:53, Sean Anderson wrote:
On 10/2/24 10:50, Tomi Valkeinen wrote:
Hi,
On 01/10/2024 21:31, Sean Anderson wrote:
On 8/9/24 15:35, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
Hi,
On 15/10/2024 17:10, Colin Ian King wrote:
Currently when an allocation failure occurs for omap_encoder the exit
path will destroy encoder via omap_encoder_destroy if it is not null.
However, encoder is always null at this point, so the check and destroy
is redundant and can be removed. Cle
Hi,
On 27/10/2024 01:00, li...@treblig.org wrote:
From: "Dr. David Alan Gilbert"
dispc_enable_fifomerge() last use was removed by 2012's
commit 85099f11bd03 ("Revert "OMAPDSS: APPLY: add fifo merge support
funcs"")
dispc_has_writeback(), dispc_wb_get_framedone_irq(), dispc_wb_go(),
dispc_wb_g
tion logic even when
creating SYNC_STATE_ONLY proxy device links from a device that is an
ancestor of a consumer fwnode.
Reported-by: Tomi Valkeinen
Closes:
https://lore.kernel.org/all/1a1ab663-d068-40fb-8c94-f0715403d...@ideasonboard.com/
Fixes: 6442d79d880c ("driver core: fw_devlink: Impro
Add the two DMA channels used for the DisplayPort audio to the
zynqmp_dpsub node.
Acked-by: Michal Simek
Signed-off-by: Tomi Valkeinen
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
b
Hi Michal,
On 08/10/2024 11:22, Michal Simek wrote:
On 9/10/24 13:19, Tomi Valkeinen wrote:
Add the two DMA channels used for the DisplayPort audio to the
zynqmp_dpsub node.
Signed-off-by: Tomi Valkeinen
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +--
1 file changed, 5
the end of the dmas list, and, after the audio support has
been added in "arm64: dts: zynqmp: Add DMA for DP audio", the driver
will treat the audio DMAs as optional to also support the old bindings.
Reviewed-by: Rob Herring (Arm)
Signed-off-by: Tomi Valkeinen
---
.../devicetree/bin
mented out.
Tested-by: Anatoliy Klymenko
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/xlnx/Kconfig| 9 +
drivers/gpu/drm/xlnx/Makefile | 1 +
drivers/gpu/drm/xlnx/zynqmp_disp.c | 48
drivers/gpu/drm/xlnx/zynqmp_disp_regs.h | 7 +-
drivers/gpu/drm/xlnx/z
: Péter Ujfalusi
Cc: Markus Elfring
Signed-off-by: Tomi Valkeinen
Changes in v4:
- Update copyright year
- Use guard(mutex) in the zynqmp_dp_audio.c
- Add Rb and Ab tags
- Link to v3:
https://lore.kernel.org/r/20240910-xilinx-dp-audio-v3-0-75560793f...@ideasonboard.com
Changes in v3:
- Expand the
Hi,
On 21/10/2024 16:51, Steffen Dirkwinkel wrote:
From: Steffen Dirkwinkel
layer->info can be null if we have an error on the first layer in
zynqmp_disp_create_layers
Signed-off-by: Steffen Dirkwinkel
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 3 +++
1 file changed, 3 insertions(+)
diff -
On 21/10/2024 16:41, Steffen Dirkwinkel wrote:
From: Steffen Dirkwinkel
drm_kms_helper_poll_init needs to be called after zynqmp_dpsub_kms_init.
zynqmp_dpsub_kms_init creates the connector and without it we don't
enable hotplug detection.
Signed-off-by: Steffen Dirkwinkel
---
drivers/gpu/dr
Hi,
On 22/10/2024 02:29, Saravana Kannan wrote:
Hi Tomi,
Sorry it took a while to get back.
On Mon, Sep 16, 2024 at 4:52 AM Tomi Valkeinen
wrote:
Hi,
We have an issue where two devices have dependencies to each other,
according to drivers/base/core.c's fw_devlinks, and this prevents
We never use the DSS_IRQ_DEVICE_OCP_ERR flag, and the HW doesn't even
have such a bit... So remove it.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_irq.c | 5 +
drivers/gpu/drm/tidss/tidss_irq.h | 4 +---
2 files changed, 2 insertions(+), 7 deletions(-)
diff --
r for TI Keystone platform Display
SubSystem")
Cc: sta...@vger.kernel.org
Signed-off-by: Devarsh Thakkar
[Tomi: updated the desc]
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_dispc.c | 4
drivers/gpu/drm/tidss/tidss_irq.c | 2 ++
2 files changed, 6 insertions(+)
di
have bits set. However, testing
shows that if any of the irqstatuses is set (i.e. even if
DISPC_IRQSTATUS == 0, but a VID irqstatus has a bit set), we will get an
interrupt.
Signed-off-by: Tomi Valkeinen
Co-developed-by: Bin Liu
Signed-off-by: Bin Liu
Co-developed-by: Devarsh Thakkar
Signed-off-by
The 'wait_lock' name seems to be a copy-paste from omapdrm, and makes no
sense here. Rename it to 'irq_lock'. Also clarify the related comment to
make it clear what it protects, and drop any comments related to
'wait_list' which doesn't exist in tidss.
Signed-o
We check if the platform is K2G in dispc_k3_clear_irqstatus(), and
return early if so. This cannot happen, as the _k3_ functions are never
called on K2G in the first place. So remove the check.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_dispc.c | 2 --
1 file changed, 2
Add printing of underflows the same way as we handle sync losts.
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_irq.c | 14 ++
drivers/gpu/drm/tidss/tidss_plane.c | 8
drivers/gpu/drm/tidss/tidss_plane.h | 2 ++
3 files changed, 24 insertions(+)
diff
79#5424479
Signed-off-by: Devarsh Thakkar
[Tomi: mostly rewrote the patch]
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/tidss/tidss_dispc.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c
b/drivers/gpu/drm/tidss/tidss_dis
sions.
Tomi
Signed-off-by: Tomi Valkeinen
---
Devarsh Thakkar (2):
drm/tidss: Clear the interrupt status for interrupts being disabled
drm/tidss: Fix race condition while handling interrupt registers
Tomi Valkeinen (5):
drm/tidss: Fix issue in irq handling causing irq-flood
Hi,
On 12/10/2024 18:07, Devarsh Thakkar wrote:
It is possible that dispc_{k2g/k3}_set_irqenable can be called for
disabling some interrupt events which were previously enabled. However
instead of clearing any pending events for the interrupt events that are
required to be disabled, it was inste
Hi,
On 23/09/2024 15:25, Dmitry Baryshkov wrote:
As Dmitry asked me during Plumbers to revalidate if our setup still
needs patch 2, I just did that over 6.11.0-next-20240923 (where patch 1
is now included). No surprise, it is still needed for our iot2050 device
series, otherwise the display rem
Hi Dmitry,
On 27/09/2024 11:35, Dmitry Baryshkov wrote:
On Fri, 27 Sept 2024 at 08:41, Tomi Valkeinen
wrote:
On 27/09/2024 02:26, Dmitry Baryshkov wrote:
On Thu, Sep 26, 2024 at 02:52:35PM GMT, Tomi Valkeinen wrote:
Hi,
On 21/09/2024 23:15, Dmitry Baryshkov wrote:
On Mon, Sep 16, 2024 at
Hi,
On 27/09/2024 17:46, Thomas Zimmermann wrote:
Hi
Am 26.09.24 um 15:07 schrieb Tomi Valkeinen:
Hi,
On 24/09/2024 10:13, Thomas Zimmermann wrote:
Store instances of drm_fb_helper and struct omap_fbdev separately.
This will allow omapdrm to use the common fbdev client, which allocates
its
Hi,
On 27/09/2024 17:46, Thomas Zimmermann wrote:
Hi
Am 26.09.24 um 15:07 schrieb Tomi Valkeinen:
Hi,
On 24/09/2024 10:13, Thomas Zimmermann wrote:
Store instances of drm_fb_helper and struct omap_fbdev separately.
This will allow omapdrm to use the common fbdev client, which allocates
its
Hi,
On 27/09/2024 17:46, Thomas Zimmermann wrote:
Hi
Am 26.09.24 um 15:07 schrieb Tomi Valkeinen:
Hi,
On 24/09/2024 10:13, Thomas Zimmermann wrote:
Store instances of drm_fb_helper and struct omap_fbdev separately.
This will allow omapdrm to use the common fbdev client, which allocates
its
Hi,
On 27/09/2024 17:46, Thomas Zimmermann wrote:
Hi
Am 26.09.24 um 15:07 schrieb Tomi Valkeinen:
Hi,
On 24/09/2024 10:13, Thomas Zimmermann wrote:
Store instances of drm_fb_helper and struct omap_fbdev separately.
This will allow omapdrm to use the common fbdev client, which allocates
its
Hi,
On 01/10/2024 21:31, Sean Anderson wrote:
On 8/9/24 15:35, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
testing or to help debug signal-integrity issues.
I think the patche
Here I think we enable all necessary clocks at probe time, so the DP is
always enabled and the above is not an issue.
In any case, even with the current devm:
Reviewed-by: Tomi Valkeinen
Tomi
- add DRM_FBDEV_DMA_DRIVER_OPS macro
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/tilcdc/Kconfig | 1 +
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Tomi Valk
elect DRM_CLIENT_SELECTION
Signed-off-by: Thomas Zimmermann
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/omapdrm/Kconfig | 1 +
drivers/gpu/drm/omapdrm/omap_drv.c | 1 +
drivers/gpu/drm/omapdrm/omap_fbdev.c | 131 ++-
drivers/gpu/drm/om
- use drm_client_setup_with_fourcc()
Signed-off-by: Thomas Zimmermann
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Cc: Michal Simek
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/xlnx/Kconfig | 1 +
drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
Tested on z
can be
referenced directly from the omap and DRM device structures. A later
patchset might rework the common fbdev client to allow for storing
both, drm_fb_helper and omap_fbdev, together in the same place.
Signed-off-by: Thomas Zimmermann
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
On 27/09/2024 02:26, Dmitry Baryshkov wrote:
On Thu, Sep 26, 2024 at 02:52:35PM GMT, Tomi Valkeinen wrote:
Hi,
On 21/09/2024 23:15, Dmitry Baryshkov wrote:
On Mon, Sep 16, 2024 at 02:51:57PM GMT, Tomi Valkeinen wrote:
Hi,
We have an issue where two devices have dependencies to each other
- use drm_client_setup_with_fourcc()
Signed-off-by: Thomas Zimmermann
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Cc: Michal Simek
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/xlnx/Kconfig | 1 +
drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
Tested on z
- add DRM_FBDEV_DMA_DRIVER_OPS macro
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/tilcdc/Kconfig | 1 +
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Tomi Valk
- add DRM_FBDEV_DMA_DRIVER_OPS macro
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/tilcdc/Kconfig | 1 +
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Tomi Valk
- add DRM_FBDEV_DMA_DRIVER_OPS macro
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/tilcdc/Kconfig | 1 +
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 5 -
2 files changed, 5 insertions(+), 1 deletion(-)
Reviewed-by: Tomi Valk
- use drm_client_setup_with_fourcc()
Signed-off-by: Thomas Zimmermann
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Cc: Michal Simek
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/xlnx/Kconfig | 1 +
drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
Tested on z
- use drm_client_setup_with_fourcc()
Signed-off-by: Thomas Zimmermann
Cc: Laurent Pinchart
Cc: Tomi Valkeinen
Cc: Michal Simek
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/xlnx/Kconfig | 1 +
drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
Tested on z
elect DRM_CLIENT_SELECTION
Signed-off-by: Thomas Zimmermann
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/omapdrm/Kconfig | 1 +
drivers/gpu/drm/omapdrm/omap_drv.c | 1 +
drivers/gpu/drm/omapdrm/omap_fbdev.c | 131 ++-
drivers/gpu/drm/om
elect DRM_CLIENT_SELECTION
Signed-off-by: Thomas Zimmermann
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/omapdrm/Kconfig | 1 +
drivers/gpu/drm/omapdrm/omap_drv.c | 1 +
drivers/gpu/drm/omapdrm/omap_fbdev.c | 131 ++-
drivers/gpu/drm/om
elect DRM_CLIENT_SELECTION
Signed-off-by: Thomas Zimmermann
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/omapdrm/Kconfig | 1 +
drivers/gpu/drm/omapdrm/omap_drv.c | 1 +
drivers/gpu/drm/omapdrm/omap_fbdev.c | 131 ++-
drivers/gpu/drm/om
can be
referenced directly from the omap and DRM device structures. A later
patchset might rework the common fbdev client to allow for storing
both, drm_fb_helper and omap_fbdev, together in the same place.
Signed-off-by: Thomas Zimmermann
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
can be
referenced directly from the omap and DRM device structures. A later
patchset might rework the common fbdev client to allow for storing
both, drm_fb_helper and omap_fbdev, together in the same place.
Signed-off-by: Thomas Zimmermann
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
can be
referenced directly from the omap and DRM device structures. A later
patchset might rework the common fbdev client to allow for storing
both, drm_fb_helper and omap_fbdev, together in the same place.
Signed-off-by: Thomas Zimmermann
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
s the default if no format has been given, leave it out entirely.
v5:
- select DRM_CLIENT_SELECTION
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/tidss/Kconfig | 1 +
drivers/gpu/drm/tidss/tidss_drv.c | 4 +++-
2
s the default if no format has been given, leave it out entirely.
v5:
- select DRM_CLIENT_SELECTION
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/tidss/Kconfig | 1 +
drivers/gpu/drm/tidss/tidss_drv.c | 4 +++-
2
s the default if no format has been given, leave it out entirely.
v5:
- select DRM_CLIENT_SELECTION
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/tidss/Kconfig | 1 +
drivers/gpu/drm/tidss/tidss_drv.c | 4 +++-
2
s the default if no format has been given, leave it out entirely.
v5:
- select DRM_CLIENT_SELECTION
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
Acked-by: Javier Martinez Canillas
---
drivers/gpu/drm/tidss/Kconfig | 1 +
drivers/gpu/drm/tidss/tidss_drv.c | 4 +++-
2
Hi,
On 21/09/2024 23:15, Dmitry Baryshkov wrote:
On Mon, Sep 16, 2024 at 02:51:57PM GMT, Tomi Valkeinen wrote:
Hi,
We have an issue where two devices have dependencies to each other,
according to drivers/base/core.c's fw_devlinks, and this prevents them from
probing. I've b
Hi,
We have an issue where two devices have dependencies to each other,
according to drivers/base/core.c's fw_devlinks, and this prevents them
from probing. I've been adding debugging to the core.c, but so far I
don't quite grasp the issue, so I thought to ask. Maybe someone can
instantly say
On 12/09/2024 21:08, Maxime Ripard wrote:
On Thu, Sep 12, 2024 at 06:04:11PM GMT, Maxime Ripard wrote:
On Thu, 12 Sep 2024 22:41:42 +0530, Devarsh Thakkar wrote:
Modify license to include dual licensing as GPL-2.0-only OR MIT license for
tidss display driver. This allows other operating system
Add the two DMA channels used for the DisplayPort audio to the
zynqmp_dpsub node.
Signed-off-by: Tomi Valkeinen
---
arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
b/arch/arm64/boot/dts
mented out.
Tested-by: Anatoliy Klymenko
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/xlnx/Kconfig| 9 +
drivers/gpu/drm/xlnx/Makefile | 1 +
drivers/gpu/drm/xlnx/zynqmp_disp.c | 48
drivers/gpu/drm/xlnx/zynqmp_disp_regs.h | 7 +-
drivers/gpu/drm/xlnx/z
the end of the dmas list, and, after the audio support has
been added in "arm64: dts: zynqmp: Add DMA for DP audio", the driver
will treat the audio DMAs as optional to also support the old bindings.
Signed-off-by: Tomi Valkeinen
---
.../devicetree/bindings/display/xlnx/xlnx,zynqmp-dp
Signed-off-by: Tomi Valkeinen
Changes in v3:
- Expand the description in "dt-bindings: display/xlnx/zynqmp-dpsub: Add
audio DMAs" to be more clear about the DT binding change.
- Rebased on top of current upstream
- Link to v2:
https://lore.kernel.org/r/20240319-xilinx-dp-audio-v2-0
On 09/09/2024 12:31, Aradhya Bhatia wrote:
Hi,
Thank you, Francesco and Max, for testing and reporting this!
On 09/09/24 13:45, Tomi Valkeinen wrote:
Hi,
On 06/09/2024 14:43, Francesco Dolcini wrote:
+Max
Hello Aradhya,
On Tue, Jul 16, 2024 at 02:12:44PM +0530, Aradhya Bhatia wrote:
The
Hi,
On 06/09/2024 14:43, Francesco Dolcini wrote:
+Max
Hello Aradhya,
On Tue, Jul 16, 2024 at 02:12:44PM +0530, Aradhya Bhatia wrote:
The addition of the 2nd OLDI TX (and a 2nd DSS in AM62Px) creates a need
for some major changes for a full feature experience.
1. The OF graph needs to be upd
Hi,
On 03/09/2024 14:56, Maxime Ripard wrote:
On Mon, Sep 02, 2024 at 03:31:28PM GMT, Tomi Valkeinen wrote:
Hi,
On 02/09/2024 13:50, Daniel Vetter wrote:
On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote:
Hi,
On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote:
On 25
On 03/09/2024 10:40, Simona Vetter wrote:
On Mon, Sep 02, 2024 at 03:31:28PM +0300, Tomi Valkeinen wrote:
Hi,
On 02/09/2024 13:50, Daniel Vetter wrote:
On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote:
Hi,
On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote:
On 25/07
Hi,
On 02/09/2024 13:50, Daniel Vetter wrote:
On Mon, Sep 02, 2024 at 11:26:11AM +0200, Maxime Ripard wrote:
Hi,
On Wed, Aug 07, 2024 at 03:19:23PM GMT, Tomi Valkeinen wrote:
On 25/07/2024 14:28, Maxime Ripard wrote:
On Mon, Jul 15, 2024 at 11:32:34AM GMT, Tomi Valkeinen wrote:
On 02/07
Hi Ulf,
On 03/05/2024 16:45, Ulf Hansson wrote:
+ Abel, Saravanna, Stephen
On Mon, 15 Apr 2024 at 19:17, Tomi Valkeinen
wrote:
On 15/04/2024 19:00, Tomi Valkeinen wrote:
Add a new flag, TI_SCI_PD_KEEP_BOOT_STATE, which can be set in the dts
when referring to power domains. When this flag
Hi,
On 25/08/2024 23:31, H. Nikolaus Schaller wrote:
Hi,
CEC features are useful to e.g. control HDMI monitor standby.
But I wonder what happened to this series?
I could find some reviewed-by: and acked-by: in [1] but it wasn't merged
upstream
for unidentifiable reasons.
We apparently had me
, Dmitry Baryshkov wrote:
On Sat, Jun 22, 2024 at 05:16:58PM GMT, Aradhya Bhatia wrote:
On 17-Jun-24 13:41, Dmitry Baryshkov wrote:
On Mon, Jun 17, 2024 at 07:40:32AM GMT, Jan Kiszka wrote:
On 16.02.24 15:57, Marek Vasut wrote:
On 2/16/24 10:10, Tomi Valkeinen wrote:
Ok. Does anyone have a
Hi,
On 23/08/2024 18:00, Laurent Pinchart wrote:
Hi Biju,
On Fri, Aug 23, 2024 at 01:52:14PM +, Biju Das wrote:
On Friday, August 23, 2024 2:15 PM, Laurent Pinchart wrote:
On Thu, Aug 22, 2024 at 05:23:13PM +0100, Biju Das wrote:
This patch series aims to add support for RZ/G2UL DU.
The
Hi,
On 23/08/2024 18:00, Laurent Pinchart wrote:
On Fri, Aug 23, 2024 at 02:33:49PM +0100, Lad, Prabhakar wrote:
On Wed, Jun 26, 2024 at 6:51 AM Laurent Pinchart wrote:
On Tue, Jun 25, 2024 at 01:32:44PM +0100, Prabhakar wrote:
From: Lad Prabhakar
All the RZ/G2L DU specific components are l
ntics.
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/
tilcdc/tilcdc_panel.c
index 68093d6b6b16..5f2d1b6
ntics.
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/
tilcdc/tilcdc_panel.c
index 68093d6b6b16..5f2d1b6
ntics.
Signed-off-by: Thomas Zimmermann
Cc: Jyri Sarha
Cc: Tomi Valkeinen
---
drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/
tilcdc/tilcdc_panel.c
index 68093d6b6b16..5f2d1b6
Hi,
On 09/08/2024 05:10, Kuninori Morimoto wrote:
Hi Tomi
Thank you for your review
+/**
+ * of_graph_get_next_ports() - get next ports node.
+ * @parent: pointer to the parent device node
+ * @ports: current ports node, or NULL to get first
+ *
+ * Return: A 'ports' node pointer with refco
Hi Rob,
On 21/03/2024 07:52, Tomi Valkeinen wrote:
On 20/03/2024 17:37, Rob Herring wrote:
On Tue, Mar 19, 2024 at 10:22:37AM +0200, Tomi Valkeinen wrote:
The DP subsystem for ZynqMP support audio via two channels, and the DP
DMA has dma-engines for those channels. For some reason the DT
Hi Sean,
On 17/06/2024 17:48, Sean Anderson wrote:
On 6/17/24 03:47, Tomi Valkeinen wrote:
Hi Sean,
On 03/05/2024 22:29, Sean Anderson wrote:
This series cleans up the zyqnmp_dp IRQ and locking situation. Once
that's done, it adds debugfs support. The intent is to enable compliance
te
On 08/08/2024 09:13, Ma Ke wrote:
As it may return NULL pointer and cause NULL pointer dereference. Add check
for the return value of alloc_ordered_workqueue.
Cc: sta...@vger.kernel.org
Fixes: 2f95bc6d324a ("drm: omapdrm: Perform initialization/cleanup at probe/remove
time")
Signed-off-by: Ma K
)
has_endpoint = true;
of_node_put(endpoint);
Reviewed-by: Tomi Valkeinen
Tomi
;
goto err_free;
Reviewed-by: Tomi Valkeinen
Tomi
On 06/08/2024 07:58, Kuninori Morimoto wrote:
We already have of_graph_get_next_endpoint(), but it is not
intuitive to use.
(X) node {
(Y) ports {
port@0 { endpoint { remote-endpoint = ...; };};
(A1)port@1 { endpoint { remote-endpoint =
On 06/08/2024 07:58, Kuninori Morimoto wrote:
We have endpoint base functions
- of_graph_get_next_device_endpoint()
- of_graph_get_device_endpoint_count()
- for_each_of_graph_device_endpoint()
Here, for_each_of_graph_device_endpoint() loop finds each endpoints
po
On 06/08/2024 07:58, Kuninori Morimoto wrote:
Current test-component.c is using for_each_endpoint_of_node()
for parsing, but it should use "port" base loop instead of "endpoint",
because properties are "port" base, instead of "endpoint".
The subject of the patch makes this sound like it's just
Hi,
On 25/07/2024 14:28, Maxime Ripard wrote:
On Mon, Jul 15, 2024 at 11:32:34AM GMT, Tomi Valkeinen wrote:
On 02/07/2024 14:43, Maxime Ripard wrote:
Hi Tomi,
On Wed, Jun 26, 2024 at 06:53:40PM GMT, Tomi Valkeinen wrote:
On 26/06/2024 18:07, Maxime Ripard wrote:
On Wed, Jun 26, 2024 at 12
On 30/07/2024 03:34, Kuninori Morimoto wrote:
We already have for_each_endpoint_of_node(), don't use
of_graph_get_next_endpoint() directly. Replace it.
Signed-off-by: Kuninori Morimoto
Acked-by: Dmitry Baryshkov
Reviewed-by: Laurent Pinchart
---
drivers/gpu/drm/omapdrm/dss/base.c | 3 +--
drop taking the lock.
Fixes: 3cbd0c587b12 ("drm/omap: gem: Replace struct_mutex usage with omap_obj
private lock")
Reported-by: Dan Carpenter
Closes:
https://lore.kernel.org/all/511b99d7-aade-4f92-bd3e-63163a13d617@stanley.mountain/
Signed-off-by: Tomi Valkeinen
---
drivers/
nice. Hide the warnings by a (__iomem void
*) typecast.
Signed-off-by: Tomi Valkeinen
Reported-by: kernel test robot
Closes:
https://lore.kernel.org/oe-kbuild-all/202407311737.vsj0sr1w-...@intel.com/
Cc: Ville Syrjälä
---
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 6 +++---
1 file chang
b2f ("drm/omap: Add support for drm_bridge")
Signed-off-by: Tomi Valkeinen
---
drivers/gpu/drm/omapdrm/dss/base.c| 25 ++---
drivers/gpu/drm/omapdrm/dss/omapdss.h | 3 +--
drivers/gpu/drm/omapdrm/omap_drv.c| 4 ++--
3 files changed, 9 insertions(+), 23 deletion
A few minor fixes to omapdrm, mostly to remove sparse or other checker
warnings.
Tomi
Signed-off-by: Tomi Valkeinen
---
Tomi Valkeinen (3):
drm/omap: Fix possible NULL dereference
drm/omap: Hide sparse warnings
drm/omap: Fix locking in omap_gem_new_dmabuf()
drivers/gpu/drm
On 31/07/2024 15:26, Laurent Pinchart wrote:
Hi Dan,
(CC'ing Tomi)
Thank for the report. It indeed seems that something is wrong.
Tomi, could you handle this and send a fix ?
On Tue, Jul 30, 2024 at 05:01:35PM -0500, Dan Carpenter wrote:
Hello Laurent Pinchart,
Commit 3cbd0c587b12 ("drm/
Hi,
On 19/07/2024 12:59, Arnd Bergmann wrote:
From: Arnd Bergmann
Compile-testing with CONFIG_MMU disabled causes a link error in omapdrm:
arm-linux-gnueabi-ld: drivers/gpu/drm/omapdrm/omap_gem.o: in function
`omap_gem_fault_2d':
omap_gem.c:(.text+0x36e): undefined reference to `vmf_insert_m
On 02/07/2024 14:43, Maxime Ripard wrote:
Hi Tomi,
On Wed, Jun 26, 2024 at 06:53:40PM GMT, Tomi Valkeinen wrote:
On 26/06/2024 18:07, Maxime Ripard wrote:
On Wed, Jun 26, 2024 at 12:55:39PM GMT, Tomi Valkeinen wrote:
On 26/06/2024 11:49, Maxime Ripard wrote:
Hi,
On Wed, Jun 19, 2024 at 12
: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Texas Instruments AM625 OLDI Transmitter
+
+maintainers:
+ - Tomi Valkeinen
+ - Aradhya Bhatia
+
+description: |
+ The AM625 TI Keystone OpenLDI transmitter (OLDI TX) supports serialized RGB
+ pixel data transmission between host and flat
IVE>;
+clocks =<&k3_clks 67 1>,
+<&k3_clks 216 1>,
+<&k3_clks 67 2>;
+clock-names = "fck", "vp1", "vp2";
+interrupts = ;
+ports {
+#address-cells = <1>;
+#size-cells = <0>;
+port@0 {
+reg = <0>;
+oldi_out0: endpoint {
+remote-endpoint = <&lcd_in0>;
+};
};
+};
};
Reviewed-by: Tomi Valkeinen
Tomi
On 11/05/2024 22:30, Aradhya Bhatia wrote:
Up till now, the OLDI support in tidss was integrated within the tidss dispc.
This was fine till the OLDI was one-to-mapped with the DSS video-port (VP).
The AM62 and AM62P SoCs have 2 OLDI TXes that can support dual-lvds / lvds-clone
modes.
Add OLDI TX
On 26/06/2024 18:07, Maxime Ripard wrote:
On Wed, Jun 26, 2024 at 12:55:39PM GMT, Tomi Valkeinen wrote:
On 26/06/2024 11:49, Maxime Ripard wrote:
Hi,
On Wed, Jun 19, 2024 at 12:07:48PM GMT, Tomi Valkeinen wrote:
From: Tomi Valkeinen
When a bridge driver uses
akes sense to explain a bit about this in a comment in the
driver code. Otherwise doing all of this in pre_enable and post_disable
looks a bit odd.
Reviewed-by: Tomi Valkeinen
Tomi
Signed-off-by: Aradhya Bhatia
---
.../gpu/drm/bridge/cadence/cdns-dsi-core.c| 32 +++
1
On 22/06/2024 14:09, Aradhya Bhatia wrote:
Move the bridge pre_enable call before crtc enable, and the bridge
post_disable call after the crtc disable.
The sequence of enable after this patch will look like:
bridge[n]_pre_enable
...
bridge[1]_pre_enable
crtc_ena
Signed-off-by: Aradhya Bhatia
Reviewed-by: Tomi Valkeinen
Tomi
---
.../gpu/drm/bridge/cadence/cdns-dsi-core.c| 51 ---
1 file changed, 43 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/bridge/cadence/cdns-dsi-core.c
b/drivers/gpu/drm/bridge/cadence/cdns
(ctx, delay) \
do {\
Reviewed-by: Tomi Valkeinen
Tomi
1 - 100 of 2033 matches
Mail list logo
