Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a

Re: Banning QNetworkAccessManager

2020-02-02 Thread Volker Krause
I agree on the problem of QNAM's default, see also https://conf.kde.org/en/ akademy2019/public/events/135 on that subject. On Saturday, 1 February 2020 23:24:14 CET Ben Cooksley wrote: [...] > Prior to now, i've taken the approach of advertising that > QNetworkAccessManager is broken and needs a

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-20 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > Why's this better? Or how is it different? It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-20 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > apol wrote in Android.cmake:173 > Why's this better? Or how is it different? It's "better" in the way that it actually works with NDK r20, while CMake 3.16 failed to even pass the basic compiler checks. For a toolchain file shipped with a

D26723: KCONFIG_ADD_KCFG_FILES: regenerate also on new version of kconfig_compiler

2020-01-19 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH dependonkconfigcompiler REVISION DETAIL https://phabricator.kde.org/D26723 To: kossebau, #frameworks, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause retitled this revision from "Support NDK r20 and Qt 5.14" to "WIP: Support NDK r20 and Qt 5.14". vkrause edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel,

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause added a task: T12520: Qt 5.14. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, michaelh, ngraham, bruns

D26749: WIP: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause retitled this revision from "Support NDK r20 and Qt 5.14" to "WIP: Support NDK r20 and Qt 5.14". vkrause edited the test plan for this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D26749 To: vkrause Cc: kde-frameworks-devel,

D26749: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This changes from using the toolchain file provided by CMake to using the one provided

D26749: Support NDK r20 and Qt 5.14

2020-01-18 Thread Volker Krause
vkrause created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This changes from using the toolchain file provided by CMake to using the one provided

D26713: Adapt to Qt 5.14 Android changes

2020-01-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R289:41b270f06f6e: Adapt to Qt 5.14 Android changes (authored by vkrause). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26713?vs=73726=73821 REVISION DETAIL

D26713: Adapt to Qt 5.14 Android changes

2020-01-16 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY - Library names now have the ABI as a suffix, dependency files need to follow that. - The Gradle version shipped

D26603: Port away from deprecated IconSize() method

2020-01-12 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R296:3489a1d049fb: Port away from deprecated IconSize() method (authored by vkrause). REPOSITORY R296 KDeclarative CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26603?vs=73332=7 REVISION

D26057: Deprecate the top-level IconSize() function

2020-01-12 Thread Volker Krause
vkrause added a comment. In D26057#592147 , @dfaure wrote: > Please port kdeclarative. > > kdeclarative/private/kiconprovider.cpp:44:56: error: ‘IconSize’ was not declared in this scope > > pixmap =

D26603: Port away from deprecated IconSize() method

2020-01-12 Thread Volker Krause
vkrause created this revision. vkrause added a reviewer: dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D26603

D26532: Don't use KWindowSystem on Android

2020-01-08 Thread Volker Krause
vkrause added a comment. In D26532#590609 , @nicolasfella wrote: > In D26532#590598 , @vkrause wrote: > > > We are already not building a few things here on Android (including public API on other

D26532: Don't use KWindowSystem on Android

2020-01-08 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. We are already not building a few things here on Android (including public API on other platforms), so excluding more is fine IMHO, especially if it's stuff where you can't argue an

D26472: Add GraphQL highlighting definition

2020-01-06 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R216:e94fbd056539: Add GraphQL highlighting definition (authored by vkrause). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26472?vs=72913=72926 REVISION

D26472: Add GraphQL highlighting definition

2020-01-06 Thread Volker Krause
vkrause created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. vkrause requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH master REVISION DETAIL https://phabricator.kde.org/D26472 AFFECTED

Re: Proposal: Allow REUSE compatible License Statements in License Policy

2020-01-06 Thread Volker Krause
+1! More standardization and structure in the license information should simplify maintenance and validation of this information, even better if it's following a global standard :) Thanks for working on this, Volker On Sunday, 5 January 2020 16:40:20 CET Andreas Cord-Landwehr wrote: > Hi, I

Re: List of available sprint venues for 2020 and beyond

2020-01-05 Thread Volker Krause
On Saturday, 4 January 2020 15:01:15 CET Eike Hein wrote: > Dear community, > > Happy new year! > > Recently, we've gotten approached a few times with offers of venues for KDE > events/sprints. One such case was the MBition office, which resulted in the > recent Frameworks 6 sprint held there.

D26313: Add application/vnd.apple.pkpass icon

2019-12-31 Thread Volker Krause
vkrause added a comment. Awesome, thanks! REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26313 To: broulik, #vdg, vkrause, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26273: cmake: don't use taglib-config if we are cross compiling

2019-12-29 Thread Volker Krause
vkrause accepted this revision. vkrause added a comment. This revision is now accepted and ready to land. Longer term we probably either want to convince upstream to install cmake config files, or at least have this in ECM, a quick local grep find a handful of copies of this. REPOSITORY

Re: KDE Itinerary in kdereview

2019-12-29 Thread Volker Krause
2019 13:14:43 CET Volker Krause wrote: > Hi, > > KDE Itinerary has been moved to kdereview: > > Code: https://invent.kde.org/kde/itinerary > Workboard: https://phabricator.kde.org/project/board/280/query/all/ > > KDE Itinerary is a Kirigami-based mobile application for m

[KDE Itinerary] [Bug 415613] KLM Flight booking not imported from pdf ticket

2019-12-28 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=415613 --- Comment #1 from Volker Krause --- Not much we can do without the ticket indeed (or even better the full email it came with, if it came by email, forwarded as attachment). If you are ok with sharing that privately, please forward it to vkra

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

2019-12-27 Thread Volker Krause
On Thursday, 26 December 2019 19:25:09 CET Albert Astals Cid wrote: > El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H. Kossebau va escriure: > > Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker Krause: > > > On Sunday, 22 December 2019 09:46:02 C

Re: Exemptions to try KF "grow" vs. consistent experience (Re: Submitting Grantlee as a KF5 Framework)

2019-12-27 Thread Volker Krause
On Thursday, 26 December 2019 19:25:09 CET Albert Astals Cid wrote: > El dimarts, 24 de desembre de 2019, a les 13:05:23 CET, Friedrich W. H. Kossebau va escriure: > > Am Montag, 23. Dezember 2019, 09:57:57 CET schrieb Volker Krause: > > > On Sunday, 22 December 2019 09:46:02 C

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-23 Thread Volker Krause
On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann wrote: > Hi all, > > in any case, maybe the discussed points should go to the KF6 workboard? > https://phabricator.kde.org/project/view/310/ > > I indeed believe that consistency in the KF5 world is an important feature, > so Friedrich

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-23 Thread Volker Krause
On Sunday, 22 December 2019 09:46:02 CET Dominik Haumann wrote: > Hi all, > > in any case, maybe the discussed points should go to the KF6 workboard? > https://phabricator.kde.org/project/view/310/ > > I indeed believe that consistency in the KF5 world is an important feature, > so Friedrich

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-21 Thread Volker Krause
On Saturday, 21 December 2019 20:12:48 CET Friedrich W. H. Kossebau wrote: > Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly: > > Great, Grantlee is now available at g...@git.kde.org:grantlee.git. > > > > I've pushed a few commits to make it depend on ECM etc. > > > > Once the

Re: CMake config & target challenges on moving to KF5 namespace; dir structure & API dox (Re: Submitting Grantlee as a KF5 Framework)

2019-12-21 Thread Volker Krause
On Saturday, 21 December 2019 20:12:48 CET Friedrich W. H. Kossebau wrote: > Am Samstag, 21. Dezember 2019, 13:03:17 CET schrieb Stephen Kelly: > > Great, Grantlee is now available at g...@git.kde.org:grantlee.git. > > > > I've pushed a few commits to make it depend on ECM etc. > > > > Once the

Re: KDE Itinerary in kdereview

2019-12-20 Thread Volker Krause
On Friday, 20 December 2019 22:50:54 CET Sandro Knauß wrote: > Hi, > > > KDE Itinerary has been moved to kdereview: > > > > Code: https://invent.kde.org/kde/itinerary > > Workboard: https://phabricator.kde.org/project/board/280/query/all/ > > > > KDE Itinerary is a Kirigami-based mobile

D26103: Put Q_REQUIRED_RESULT in front of the functions to fix builds with [[nodiscard]]

2019-12-19 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D26103 To: vonreth, sitter, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

2019-12-18 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R295:3f5a2879e99c: Port from KDE::icon to KIconUtils for getting icon overlays (authored by vkrause). REPOSITORY R295 KCMUtils CHANGES SINCE LAST UPDATE

D26072: Port away from KIconThemes

2019-12-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R128:39ce0e82856e: Port away from KIconThemes (authored by vkrause). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26072?vs=71738=71745 REVISION DETAIL

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

2019-12-17 Thread Volker Krause
vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R295 KCMUtils REVISION DETAIL https://phabricator.kde.org/D26073 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D26073: Port from KDE::icon to KIconUtils for getting icon overlays

2019-12-17 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This also removes the last uses of KIconThemes from here. REPOSITORY R295 KCMUtils BRANCH master REVISION DETAIL

D26072: Port away from KIconThemes

2019-12-17 Thread Volker Krause
vkrause created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY This was only using the deprecated IconSize() method. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL

D26057: Deprecate the top-level IconSize() function

2019-12-17 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R302:3e668c7fba9f: Deprecate the top-level IconSize() function (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26057?vs=71689=71737 REVISION

D26057: Deprecate the top-level IconSize() function

2019-12-16 Thread Volker Krause
vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D26057 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26057: Deprecate the top-level IconSize() function

2019-12-16 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This removes the last of the non-namespaced top-level functions here as well. REPOSITORY R302 KIconThemes BRANCH

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R174:ce6699a141a0: Align ECM and Qt setup with Frameworks conventions (authored by vkrause). REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26011?vs=71575=71576

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
vkrause updated this revision to Diff 71575. vkrause added a comment. Remove duplicate include. REPOSITORY R174 KContacts CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26011?vs=71573=71575 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26011 AFFECTED FILES

D26011: Align ECM and Qt setup with Frameworks conventions

2019-12-15 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This completes the previous commit which provided the hotfix for the ECM version lookup issue breaking the build.

D26009: KCoreAddons: fix compilation with qtbase git dev branch

2019-12-15 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R244 KCoreAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D26009 To: dfaure, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25960: [calendar] Check out of bounds array access in QLocale lookup

2019-12-14 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D25960 To: davidedmundson, #plasma, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

[kio] [Bug 233628] self signed SSL Certificate is not remembered (remember forever function)

2019-12-13 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=233628 --- Comment #81 from Volker Krause --- The change has been added to the 5.65.0 KIO release tarball. -- You are receiving this mail because: You are watching all bug changes.

[kio] [Bug 233628] self signed SSL Certificate is not remembered (remember forever function)

2019-12-13 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=233628 --- Comment #79 from Volker Krause --- Thanks for the feedback. I'll see if we can still get that patch into the 5.65 release due tomorrow. The repeated display of this dialog is of course not addressed by this patch, that's an issue in the code using

Re: KDE Frameworks 5.65.0

2019-12-13 Thread Volker Krause
On Sunday, 8 December 2019 11:45:05 CET David Faure wrote: > Dear packagers, > > KDE Frameworks 5.65.0 has been uploaded to the usual place. > > New frameworks: KQuickCharts. > > Public release next Saturday. > > Thanks for the packaging work! https://bugs.kde.org/show_bug.cgi?id=233628

[kio] [Bug 233628] self signed SSL Certificate is not remembered (remember forever function)

2019-12-13 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=233628 --- Comment #77 from Volker Krause --- With KIO 5.64/5.65 and a stand-alone test case (https://invent.kde.org/vkrause/http-demo) I can reproduce this against https://untrusted-root.badssl.com/ (and only that, https://self-signed.badssl.com/ works

Re: Add kdeconnect-kde to release service

2019-12-12 Thread Volker Krause
On Thursday, 12 December 2019 18:44:30 CET Nicolas Fella wrote: > On Donnerstag, 12. Dezember 2019 18:17:45 CET Volker Krause wrote: > > I think in general it would be very nice to have those includable as well, > > following a standardized branching and versioning model and

Re: Add kdeconnect-kde to release service

2019-12-12 Thread Volker Krause
On Wednesday, 11 December 2019 17:09:11 CET Nicolas Fella wrote: > Hi, > > we would like for KDE Connect to be included in the release service > beginning with the 20.04 release. > > As discussed with Jonathan I've moved the metadata to from extragear/network > to kde/kdeutils. > > I'm unsure

D25924: fix static linking on e.g. macOS

2019-12-12 Thread Volker Krause
vkrause added a comment. This looks wrong though, QtNetwork is not used in the public interface, is it? And the cmake config files are supposed to propagate private link libraries in case of static linking too I think, otherwise LINK_PRIVATE could basically never work, no? REPOSITORY

[kio] [Bug 233628] self signed SSL Certificate is not remembered (remember forever function)

2019-12-12 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=233628 --- Comment #74 from Volker Krause --- Which versions of KIO and KIMAP do you have? -- You are receiving this mail because: You are watching all bug changes.

D25858: Use QStyle for determining icon sizes

2019-12-11 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:34aeee14693b: Use QStyle for determining icon sizes (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25858?vs=71214=71308 REVISION DETAIL

D25858: Use QStyle for determining icon sizes

2019-12-11 Thread Volker Krause
vkrause added a task: T11637: Investigate if KIconThemes is needed as a framework. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25858 To: vkrause, apol Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25865: kfilemetadata EBN transport protocol cleanup

2019-12-11 Thread Volker Krause
vkrause added inline comments. INLINE COMMENTS > xmlextractor.cpp:33 > +inline QString rdfNS(){ return > QStringLiteral("https://www.w3.org/1999/02/22-rdf-syntax-ns#;); } > +inline QString ccNS() { return > QStringLiteral("https://creativecommons.org/ns#;); } > sure about those?

Re: KDE Itinerary in kdereview

2019-12-10 Thread Volker Krause
unity.kde.org/KDE_PIM/KItinerary Thanks, all of the above should be fixed now. Regards, Volker > On Sun, 8 Dec 2019 at 12:16, Volker Krause wrote: > > Hi, > > > > KDE Itinerary has been moved to kdereview: > > > > Code: https://invent.kde.org/kde/itinerary > &

D25858: Use QStyle for determining icon sizes

2019-12-10 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REVISION SUMMARY This should remove the last use of the IconSize() top-level function from Frameworks, in preparation of deprecating

Re: KDE Itinerary in kdereview

2019-12-09 Thread Volker Krause
On Sunday, 8 December 2019 14:07:57 CET Christophe Giboudeaux wrote: > Hey, > > On dimanche 8 décembre 2019 13:14:43 CET Volker Krause wrote: > > Hi, > > > > KDE Itinerary has been moved to kdereview: > > > > Code: https://invent.kde.org/kde/itinerary >

D25371: Remove porting scaffolding, this is entirely on QSslError now

2019-12-09 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:3c9bac61808d: Remove porting scaffolding, this is entirely on QSslError now (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25371?vs=69940=71133

KDE Itinerary in kdereview

2019-12-08 Thread Volker Krause
Hi, KDE Itinerary has been moved to kdereview: Code: https://invent.kde.org/kde/itinerary Workboard: https://phabricator.kde.org/project/board/280/query/all/ KDE Itinerary is a Kirigami-based mobile application for managing your itinerary as a timeline, including access to your travel

[KDE Itinerary] [Bug 413756] Ad calculation and compensation of CO2-emissions

2019-12-08 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=413756 --- Comment #3 from Volker Krause --- Statistics page with CO2 impact estimation and year-by-year trends has been added now. -- You are receiving this mail because: You are watching all bug changes.

Re: Submitting Grantlee as a KF5 Framework

2019-12-08 Thread Volker Krause
Hi, very happy to see Grantlee "coming home" :) Technically I think it's largely in line with Frameworks requirements already, and it has been reliably powering e.g. KMail's message viewer for years. Moving to a faster and, more importantly, predictable release cycle would help us a lot with

Re: Submitting Grantlee as a KF5 Framework

2019-12-08 Thread Volker Krause
Hi, very happy to see Grantlee "coming home" :) Technically I think it's largely in line with Frameworks requirements already, and it has been reliably powering e.g. KMail's message viewer for years. Moving to a faster and, more importantly, predictable release cycle would help us a lot with

Re: Blacklisting of PIM from the CI system

2019-12-04 Thread Volker Krause
On Tuesday, 3 December 2019 22:13:43 CET Allen Winter wrote: > On Tuesday, December 3, 2019 2:52:31 PM EST Volker Krause wrote: > > The complexity of the dependency graph is also a problem for onboarding > > new > > people, and with kdelibs4support gone IMHO the largest te

Re: Blacklisting of PIM from the CI system

2019-12-04 Thread Volker Krause
On Tuesday, 3 December 2019 22:13:43 CET Allen Winter wrote: > On Tuesday, December 3, 2019 2:52:31 PM EST Volker Krause wrote: > > The complexity of the dependency graph is also a problem for onboarding > > new > > people, and with kdelibs4support gone IMHO the largest te

Re: Blacklisting of PIM from the CI system

2019-12-03 Thread Volker Krause
On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: [...] > > > Fixing the current set of failures will not prevent this blacklisting > > >

Re: Blacklisting of PIM from the CI system

2019-12-03 Thread Volker Krause
On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: [...] > > > Fixing the current set of failures will not prevent this blacklisting > > >

D25311: Add KColumnHeadersProxyModel

2019-12-02 Thread Volker Krause
vkrause added a comment. In D25311#570700 , @ahiemstra wrote: > @vkrause Is the updated version more what you expected? Yep, thanks, this addresses my concerns. So +1 from me on this. REPOSITORY R275 KItemModels REVISION DETAIL

D25433: KActionCollection: provide a changed() signal as a replacement for removed()

2019-12-02 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D25433 To: dfaure, kossebau, mart, davidedmundson, vkrause, nicolasfella Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25511: Drop unused broken KGesture support

2019-12-02 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH master REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson, vkrause Cc: apol, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25671: Fix git builds against Qt 5.14

2019-12-02 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R129 Window Decoration Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D25671 To: apol, #frameworks, vkrause Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

Re: Blacklisting of PIM from the CI system

2019-11-30 Thread Volker Krause
On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > sigh... > > > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: > > [...] > > > > > Which is where the problem with PIM

Re: Blacklisting of PIM from the CI system

2019-11-30 Thread Volker Krause
On Sunday, 1 December 2019 04:00:19 CET Ben Cooksley wrote: > On Sun, Dec 1, 2019 at 10:17 AM Volker Krause wrote: > > sigh... > > > > On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: > > [...] > > > > > Which is where the problem with PIM

Re: Blacklisting of PIM from the CI system

2019-11-30 Thread Volker Krause
sigh... On Saturday, 30 November 2019 19:14:38 CET Ben Cooksley wrote: [...] > Which is where the problem with PIM comes in - because it currently > has many repositories failing to build from source on all platforms > those builds are enabled for (including Linux and FreeBSD). looking at this

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

2019-11-30 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R223:6cf2242cd94b: Port away from deprecated Bar|Desktop|SmallIcon methods (authored by vkrause). REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25553?vs=70366=70599

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

2019-11-28 Thread Volker Krause
vkrause added a reviewer: aacid. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25553 To: vkrause, aacid Cc: okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, ngraham, darcyshen, aacid

D25552: Deprecate top-level UserIcon method, no longer used

2019-11-27 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R302:312f27f31199: Deprecate top-level UserIcon method, no longer used (authored by vkrause). REPOSITORY R302 KIconThemes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25552?vs=70364=70450

D25552: Deprecate top-level UserIcon method, no longer used

2019-11-26 Thread Volker Krause
vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R302 KIconThemes REVISION DETAIL https://phabricator.kde.org/D25552 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

2019-11-26 Thread Volker Krause
vkrause added a task: T11654: Deprecate SmallIcon/DesktopIcon/BarIcon/UserIcon/MainBarIcon and KDE::icon in favor of KIconLoader or QIcon API. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D25553 To: vkrause Cc: okular-devel, johnzh, andisa, siddharthmanthan,

D25553: Port away from deprecated Bar|Desktop|SmallIcon methods

2019-11-26 Thread Volker Krause
vkrause created this revision. Herald added a project: Okular. Herald added a subscriber: okular-devel. vkrause requested review of this revision. REPOSITORY R223 Okular BRANCH master REVISION DETAIL https://phabricator.kde.org/D25553 AFFECTED FILES conf/dlgperformance.cpp

D25552: Deprecate top-level UserIcon method, no longer used

2019-11-26 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R302 KIconThemes BRANCH master REVISION DETAIL https://phabricator.kde.org/D25552 AFFECTED FILES src/CMakeLists.txt

D25106: Also allow invoking session restoration logic when apps are manually launched

2019-11-26 Thread Volker Krause
vkrause added a comment. This indeed seems to have negative impact on Kontact, while other people get duplicates it doesn't start at all for me anymore. With this patch reverted it's back to normal. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25106 To:

Re: KF6 Blogs

2019-11-25 Thread Volker Krause
On Saturday, 23 November 2019 16:34:01 CET Dominik Haumann wrote: > Hi everyone, > > could you who currently are at the KF6 sprint blog a bit more? There's 3 posts by Christoph and one by Kévin by now, and one or two more to come I think. Even more importantly IMHO, we discussed monthly

D25491: Remove kdeinit dependency from kded.

2019-11-25 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D25491 To: dfaure, mart, cordlandwehr, vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25511: Drop unused broken KGesture support

2019-11-25 Thread Volker Krause
vkrause added a comment. Right, kdelibs4support seems to include the deleted private headers, and uses these types in public API in KAction. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson Cc: apol, vkrause, kde-frameworks-devel, LeGast00n,

D25511: Drop unused broken KGesture support

2019-11-24 Thread Volker Krause
vkrause added a comment. Seems used in KAction in kdelibs4support. REPOSITORY R263 KXmlGui REVISION DETAIL https://phabricator.kde.org/D25511 To: davidedmundson Cc: vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25401: Fix deprecation syntax in ktcpsocket.h

2019-11-21 Thread Volker Krause
vkrause accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25401 To: dfaure, vkrause, kossebau Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25401: Fix deprecation syntax in ktcpsocket.h

2019-11-19 Thread Volker Krause
vkrause added a comment. In D25401#564683 , @dfaure wrote: > As a data point: this commit changes things for kimap, which has code saying > > src/imapstreamparser.cpp:493:} else if (KTcpSocket *socket = qobject_cast(m_socket))

D25371: Remove porting scaffolding, this is entirely on QSslError now

2019-11-18 Thread Volker Krause
vkrause added a task: T11620: Port from KSslError to QSslError. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D25371 To: vkrause Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25371: Remove porting scaffolding, this is entirely on QSslError now

2019-11-18 Thread Volker Krause
vkrause created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. vkrause requested review of this revision. REPOSITORY R241 KIO BRANCH master REVISION DETAIL https://phabricator.kde.org/D25371 AFFECTED FILES

Re: Disabling akonadi test runner infrastructure across all repositories

2019-11-18 Thread Volker Krause
On Monday, 18 November 2019 02:55:19 CET Ben Cooksley wrote: > On Mon, Nov 18, 2019 at 10:18 AM Volker Krause wrote: > > On Sunday, 17 November 2019 21:20:11 CET Albert Astals Cid wrote: > > > El dissabte, 16 de novembre de 2019, a les 7:02:04 CET, Ben Cooksley va > >

Re: Disabling akonadi test runner infrastructure across all repositories

2019-11-17 Thread Volker Krause
On Sunday, 17 November 2019 21:20:11 CET Albert Astals Cid wrote: > El dissabte, 16 de novembre de 2019, a les 7:02:04 CET, Ben Cooksley va escriure: > > Hi all, > > > > For some time now the Akonadi Test Runner infrastructure has had > > issues on the CI system where it will fail to properly

[Akonadi] [Bug 414178] Deleting all contacts deletes entire /home/user/

2019-11-17 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=414178 --- Comment #1 from Volker Krause --- Git commit e3e0ee0ddc82bf6a34ebe93ed6c5c881f412ddc2 by Volker Krause. Committed on 17/11/2019 at 11:12. Pushed by vkrause into branch 'release/19.12'. Sanity-check collection path before performing recursive

[Akonadi] [Bug 414178] Deleting all contacts deletes entire /home/user/

2019-11-17 Thread Volker Krause
https://bugs.kde.org/show_bug.cgi?id=414178 --- Comment #1 from Volker Krause --- Git commit e3e0ee0ddc82bf6a34ebe93ed6c5c881f412ddc2 by Volker Krause. Committed on 17/11/2019 at 11:12. Pushed by vkrause into branch 'release/19.12'. Sanity-check collection path before performing recursive

D25237: Deprecated KTcpSocket and KSsl* classes

2019-11-16 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:ba8e9c7df86c: Deprecated KTcpSocket and KSsl* classes (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25237?vs=69530=69839 REVISION DETAIL

D25236: Remove the last traces of KSslError from TCPSlaveBase

2019-11-16 Thread Volker Krause
This revision was automatically updated to reflect the committed changes. Closed by commit R241:e0eb9ebaa569: Remove the last traces of KSslError from TCPSlaveBase (authored by vkrause). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25236?vs=69527=69835

Re: Disabling of 'testkioarchive' in kio-extras

2019-11-16 Thread Volker Krause
On Saturday, 16 November 2019 06:39:29 CET Ben Cooksley wrote: > Hi all, > > Currently we have an issue where the test 'testkioarchive' within > kio-extras causes kdeinit5 to be relaunched, as can be seen in the CI > run log below. > >

<    4   5   6   7   8   9   10   11   12   13   >