[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/65687: "descriptive summaries" should only be used for small to medium binaries because of the performance penalty the cause when completing types. I'm defaulting it to false. Besides that, the "raw child" fo

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo review_requested https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo review_requested https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo review_requested https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

@@ -240,6 +240,16 @@ "timeout": { "type": "string", "description": "The time in seconds to wait

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/65687: >From fc0700e761db9761675c42826e8f5bfa5b510840 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 7 Sep 2023 18:35:10 -0400 Subject: [PATCH] [lldb-vscode] Make descriptive summaries and raw chil

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo resolved https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/65687: >From 4d563d5542291c4b386caaad1f6f4c18f4c7bfd1 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 7 Sep 2023 18:35:10 -0400 Subject: [PATCH] [lldb-vscode] Make descriptive summaries and raw chil

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

walter-erquinigo wrote: @clayborg , do you get notifications when I update the PR? :) I'm still getting used to github for llvm. In any case, this is ready for review. https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-

[Lldb-commits] [lldb] c154ba8 - [LLDB][NFC] Add the mojo language to Language::GetPrimaryLanguage

Author: walter erquinigo Date: 2023-09-11T15:25:05-04:00 New Revision: c154ba8abeb6f59f85a9bb6fdf7bd79ad0d8c05c URL: https://github.com/llvm/llvm-project/commit/c154ba8abeb6f59f85a9bb6fdf7bd79ad0d8c05c DIFF: https://github.com/llvm/llvm-project/commit/c154ba8abeb6f59f85a9bb6fdf7bd79ad0d8c05c.di

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/65687: >From 6415738e5c359553212d4a04780694587a536a82 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 7 Sep 2023 18:35:10 -0400 Subject: [PATCH] [lldb-vscode] Make descriptive summaries and raw chil

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/65687: >From 6415738e5c359553212d4a04780694587a536a82 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 7 Sep 2023 18:35:10 -0400 Subject: [PATCH 1/2] [lldb-vscode] Make descriptive summaries and raw

[Lldb-commits] [lldb] [lldb-vscode] Make descriptive summaries and raw child for synthetics configurable (PR #65687)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/65687 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 4a030f5 - [lldb-vscode][NFC] Access a pointee type in a simpler way

Author: walter erquinigo Date: 2023-09-15T12:26:04-04:00 New Revision: 4a030f5b245b63fe09c29686c50d40796c987d96 URL: https://github.com/llvm/llvm-project/commit/4a030f5b245b63fe09c29686c50d40796c987d96 DIFF: https://github.com/llvm/llvm-project/commit/4a030f5b245b63fe09c29686c50d40796c987d96.di

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66527 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

https://github.com/walter-erquinigo commented: Awesome doc! https://github.com/llvm/llvm-project/pull/66527 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Revive internal data formatter documentation (PR #66527)

@@ -0,0 +1,436 @@ +Data Formatters +=== + +This page is an introduction to the design of the LLDB data formatters +subsystem. The intended target audience are people interested in understanding +or modifying the formatters themselves rather than writing a specific data

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/66534 The variables pane on VSCode is very narrow by default, and lldb-vscode has been using the default formatter for addresses, which uses 18 characters for each address. That's a bit too much because it pr

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66534 >From d8060f818b18b3fe64641d9683fa49ffca0b3736 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 12:40:33 -0400 Subject: [PATCH] [lldb-vscode] Show value addresses in a short format

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/66534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

walter-erquinigo wrote: I initially didn't want to mess with global configurations, but after a second thought, I think your solution is better. I'll try that out https://github.com/llvm/llvm-project/pull/66534 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [lldb] [lldb-vscode] Show value addresses in a short format (PR #66534)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/66534 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for print hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/66548 As suggested by Greg in https://github.com/llvm/llvm-project/pull/66534, I'm adding a setting at the Target level that controls whether to show leading zeroes in hex ValueObject values. This has the be

[Lldb-commits] [lldb] [LLDB] Add a setting for print hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for print hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66548 >From 99b2a5e3663263fd1a92e350a3254fafbe9724c5 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:41:23 -0400 Subject: [PATCH] [LLDB] Add a setting for print hex values without lea

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: @jimingham , that's a good catch. Probably I should rename this because I want this setting to affect only SBValueObject::GetValue(), which is want ends up being sent to IDEs as a common interface. Trying to control all places that print as hex value is a bit too much a

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: I like Greg's proposal of naming it `show-hex-variable-values-with-leading-zeroes`. Seems very clear. I also like the idea of making it a global target config, which would simplify the code. https://github.com/llvm/llvm-project/pull/66548 ___

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/66551 enableAutoVariableSummaries is a setting that enhances the summaries of variables in the IDE. A shortcoming of this feature is that it wasn't showing the addresses of pointers, which is valuable informa

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66551 >From 31236a70c8d1736563a253dc3a2582366220cb8f Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:50:35 -0400 Subject: [PATCH] [lldb-vscode] Show addresses next to dereferenced sum

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66548 >From 3bddb5d5f813d5eac165be1a73b9058f5ee0510d Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:41:23 -0400 Subject: [PATCH] [LLDB] Add a setting for print hex variable values wi

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: I've updated the PR following Greg's suggestions. https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: Thanks Jim and Greg! https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9389b05 - [lldb] Fix the TestValueAPI test

Author: walter erquinigo Date: 2023-09-18T13:57:25-04:00 New Revision: 9389b056a604b7da9478bb40125d6a1ad379823a URL: https://github.com/llvm/llvm-project/commit/9389b056a604b7da9478bb40125d6a1ad379823a DIFF: https://github.com/llvm/llvm-project/commit/9389b056a604b7da9478bb40125d6a1ad379823a.di

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

walter-erquinigo wrote: > if it doesn't have a summary and we auto generate one, then we can append the > generated summary string That makes a ton of sense. I'll try that approach. Thanks https://github.com/llvm/llvm-project/pull/66551 ___ lldb-comm

[Lldb-commits] [lldb] 014c41d - [LLDB] Attempt to fix DumpDataExtractorTest

Author: Walter Erquinigo Date: 2023-09-18T21:30:42Z New Revision: 014c41d688f961cdb81cf92e6ba97100a49766a6 URL: https://github.com/llvm/llvm-project/commit/014c41d688f961cdb81cf92e6ba97100a49766a6 DIFF: https://github.com/llvm/llvm-project/commit/014c41d688f961cdb81cf92e6ba97100a49766a6.diff L

[Lldb-commits] [lldb] 266630c - [LLDB] Attempt to fix DumpDataExtractorTest

Author: Walter Erquinigo Date: 2023-09-18T22:02:05Z New Revision: 266630cffceefbe3b00f34ba8efcfba62259335e URL: https://github.com/llvm/llvm-project/commit/266630cffceefbe3b00f34ba8efcfba62259335e DIFF: https://github.com/llvm/llvm-project/commit/266630cffceefbe3b00f34ba8efcfba62259335e.diff L

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: Thanks, man! On Tue, Sep 19, 2023, 4:53 AM David Spickett ***@***.***> wrote: > 9568601 > > > — > Reply to this email directly, view it on GitHub >

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66551 >From 4c9d8d3f5be34d5ffec502a8fa891b603549b2cc Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:50:35 -0400 Subject: [PATCH] [lldb-vscode] Use auto summaries when variables have

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

https://github.com/walter-erquinigo approved this pull request. Good catch! I think I have suffered because of this at some point. https://github.com/llvm/llvm-project/pull/66949 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

walter-erquinigo wrote: @jimingham , IIRC from old experiments regarding the synthetic formatter code, `true` is returned when you want to avoid caching the results of the `Update`, which means that if you want to persist the success or the failure, you just return `false`. I might be wrong bu

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when th

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

walter-erquinigo wrote: Do you think it would be a good idea to provide aliases for the return values of the Update method with better names that match the behavior you just discovered? I'm not a fan of true/false in this case, because it confuses synthetic type developers, but I'm just trying

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when th

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: walter-erquinigo wrote: Btw, I'm building support for the mojo language, and very likely the `main` method will not have the symbol `main`, so building an abstraction around this, for every language, would be very convenient. https://githu

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/67165 This prevents undefined vtable errors when linking these libraries from out-of-tree. I'm facing this issue as I work on my new language plugin. >From 68818ce0376ba717157edaffd5ae2101cf26d4e2 Mon Sep 17

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/67165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67165 >From 0f7b275c5fa608dce8b345c81794514abda017f3 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 22 Sep 2023 12:29:46 -0400 Subject: [PATCH] [lldb][NFC] Move some ctors and tors to cpp files Th

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/67165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: walter-erquinigo wrote: That's file. You can have multiple commits in the same PR, because when it gets approved and merged, github will squash all your commits into a single one. https://github.com/llvm/llvm-project/pull/67019

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

https://github.com/walter-erquinigo approved this pull request. Other than a few nits, this is awesome! https://github.com/llvm/llvm-project/pull/67628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

@@ -0,0 +1,100 @@ +"""A tool for extracting a list of private lldb symbols to export for MSVC. + +When exporting symbols from a dll or exe we either need to mark the symbols in +the source code as __declspec(dllexport) or supply a list of symbols to the +linker. Private symbols in

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

@@ -0,0 +1,100 @@ +"""A tool for extracting a list of private lldb symbols to export for MSVC. + +When exporting symbols from a dll or exe we either need to mark the symbols in +the source code as __declspec(dllexport) or supply a list of symbols to the +linker. Private symbols in

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/67851 None >From 78edde6c7b6294c0e1a78b18cdf81d156c636a38 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 29 Sep 2023 15:44:05 -0400 Subject: [PATCH] [LLDB] Export DWARF Parser symbols for external

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67851 >From 616b08f7c9e30b501d5f0fe2ff8d6fbf3ecb9582 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 29 Sep 2023 15:44:05 -0400 Subject: [PATCH] [LLDB] Export DWARF Parser symbols for external langu

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67851 >From b5cfeaad26ecd29f15aadaad408ff30899a8a16d Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 29 Sep 2023 15:44:05 -0400 Subject: [PATCH] [LLDB] Export DWARF Parser symbols for external langu

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

walter-erquinigo wrote: @clayborg , LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` (see https://github.com/llvm/llvm-project/blob/main/lldb/cmake/modules/AddLLDB.cmake#L177) that is used to export `lldb_private` as well as `lldb` symbols. This shows that there's been a precedent for this ki

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

walter-erquinigo wrote: After chatting with @clayborg , I'm going to try a different approach: - putting all of these dwarf-related files from the plugin in a `lldb_plugins::dwarf` namespace. - adding a new cmake flag that operates along with `LLDB_EXPORT_ALL_SYMBOLS` to specify a custom export

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

walter-erquinigo wrote: > Perhaps instead of lldb_plugin we can name it something like > lldb_private::plugin instead? Well, that would definitely work for me, as these symbols would be automatically exported alongside all the other `lldb_private` symbols. What I'm not completely sure about

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

walter-erquinigo wrote: @jimingham , indeed, I don't want to have a plugin that could be loadable by any build of lldb. The Mojo SDK is distributing already its own build of vanilla lldb along with the mojo plugin that is loaded at runtime and that links correctly with that lldb. I initially t

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/68013 LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` that exports the lldb, lldb_private namespaces, as well as other symbols like python and lua (see `third-party/llvm-project/lldb/source/API/liblldb-priv

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/68013 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 3674a06 - [NFC][LLDB] Remove an unnecessary virtual destructor

Author: walter erquinigo Date: 2023-10-03T15:43:22-04:00 New Revision: 3674a0610a71becc54eab715905c4017d65471c4 URL: https://github.com/llvm/llvm-project/commit/3674a0610a71becc54eab715905c4017d65471c4 DIFF: https://github.com/llvm/llvm-project/commit/3674a0610a71becc54eab715905c4017d65471c4.di

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/68150 As a followup of https://github.com/llvm/llvm-project/pull/67851, I'm defining a new namespace `lldb_plugin::dwarf` for the classes in this Plugins/SymbolFile/DWARF folder. This change is very NFC and h

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68150 >From 98c009c5f33b81d579fd11d11a660026f33836ae Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 16:56:16 -0400 Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin A

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68150 >From 92dc652698d7de826e28ce1563fa804366bab5c0 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 16:56:16 -0400 Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin A

[Lldb-commits] [lldb] [lldb-vscode] Update installation instructions (PR #68234)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/68234 lldb-vscode had installation instructions based on creating a folder inside ~/.vscode/extensions, which no longer works. A different installation mechanism is needed based on a VSCode command. More can

[Lldb-commits] [lldb] [lldb-vscode] Update installation instructions (PR #68234)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/68234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

@@ -18,7 +18,9 @@ #include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h" #include +namespace lldb_plugin::dwarf { walter-erquinigo wrote: This is possible after the switch to c++17, and that's probably why no one else is using it in LLDB. There's no expl

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

walter-erquinigo wrote: I'll add the warning as you guys mention. That'll set clear expectations on what users will be getting. Besides that, @bulbazord , the current symbols getting exported by `third-party/llvm-project/lldb/source/API/liblldb-private.exports` are not all the symbols, but ju

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68013 >From d557ea59b9c24387244280566260c33ac6bb9367 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 13:56:00 -0400 Subject: [PATCH] [LLDB] Allow specifying a custom exports file LLDB ha

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/68013 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68013 >From a472a16e6032ce0cef0acae6957f690f7e6cc4a3 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 13:56:00 -0400 Subject: [PATCH] [LLDB] Allow specifying a custom exports file LLDB ha

[Lldb-commits] [lldb] [lldb][NFCI] Remove use of ConstString from FilterRule in StructuredDataDarwinLog (PR #68347)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/68347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    1   2   3   4   5   6   7   8   9   >