https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 09cd46a63b1fb68e3c5c03273cbc90825b09d027 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
@@ -321,6 +322,7 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
+protected:
walter-erquinigo wrote:
Sure, after you merge this patch, I'll send another one exposing only what's
needed. I'll also remove DWARFASTParserC
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -321,6 +322,7 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
+protected:
walter-erquinigo wrote:
The ivars thing make sense. Could you at least just move the ivars into a
protected or private section for now? If yo
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/69990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/69990
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -321,6 +322,7 @@ class SymbolFileDWARF : public SymbolFileCommon {
m_file_index = file_index;
}
+protected:
walter-erquinigo wrote:
My bad for merging this, but I beg you not to reintroduce it. I originally
intended to have an isolated patch just fo
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@clayborg , friendly ping :)
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69696
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From adcf4b7ad6ec67805293af99300643075a02b75b Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
@@ -52,12 +52,17 @@ llvm::StringRef GetAsString(const llvm::json::Value &value);
/// \param[in] key
/// The key to use when extracting the value
///
+/// \param[in] defaultValue
+/// The default value to return if the key is not present
+///
/// \return
/// A llvm
Author: walter erquinigo
Date: 2023-10-17T18:50:18-04:00
New Revision: 7d1bf1c5cf284ce1a18fe0ce4a4cf91f3e514866
URL:
https://github.com/llvm/llvm-project/commit/7d1bf1c5cf284ce1a18fe0ce4a4cf91f3e514866
DIFF:
https://github.com/llvm/llvm-project/commit/7d1bf1c5cf284ce1a18fe0ce4a4cf91f3e514866.di
Author: walter erquinigo
Date: 2023-10-17T18:15:29-04:00
New Revision: 59908504cd7a72cd2a614e5c6db5410101209365
URL:
https://github.com/llvm/llvm-project/commit/59908504cd7a72cd2a614e5c6db5410101209365
DIFF:
https://github.com/llvm/llvm-project/commit/59908504cd7a72cd2a614e5c6db5410101209365.di
walter-erquinigo wrote:
@clayborg , friendly ping
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
fantastic!
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@JDevlieghere , PTAL
https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/16?u=wallace
https://github.com/llvm/llvm-project/pull/69264
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 19295d5fe84c1f06f3e5d712d5af39f8ef48286c Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
walter-erquinigo wrote:
Sure, Greg, I'll update my patch with the empty prefix.
I'll probably write the very basic Typescript wrapper in two weeks. I would
like to see it a point of contribution between different companies
https://github.com/llvm/llvm-project/pull/69238
___
walter-erquinigo wrote:
@clayborg , I've updated this patch using launch and attach settings, which
might be fine following what've been doing so far. Even though I agree that
it'd be nice to read the GUI global configs, I think that all settings should
be also configurable via launch and atta
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 4595d0940738b42f19d4127f3743afbaa53f0691 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
walter-erquinigo wrote:
> Can you check real quick if any native plug-ins can have and or access global
> settings from the VS Code GUI? That would be the best way for all of these.
> Maybe there is a combination mode where we have some typescript in our
> extension, but still have a native DA
walter-erquinigo wrote:
@clayborg , good point, I'll move it to launch and attach settings.
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
walter-erquinigo wrote:
> (Not related to this PR but I put up an
> [RFC](https://discourse.llvm.org/t/rfc-rename-lldb-vscode-to-lldb-dap/74075/)
> on Friday to rename it to `lldb-dap`. Putting it up here for extra
> visibility.)
Nice! I'll approve your PR if you make that change!
https://gi
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/69238
>From 3d14b2938e0fd6073cdafcea4a54071f23158b42 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 16 Oct 2023 15:08:20 -0400
Subject: [PATCH] [lldb-vscode] Allow specifying a custom escape charac
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/69238
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/69238
We've been using the backtick as our escape character, however that leads to a
weird experience on VS Code, because on most hosts, as soon as you type the
backtick on VS Code, the IDE will introduce ano
Author: walter erquinigo
Date: 2023-10-13T17:22:49-04:00
New Revision: a669a237c45a515bea0d258cbbecdbbb3170d57a
URL:
https://github.com/llvm/llvm-project/commit/a669a237c45a515bea0d258cbbecdbbb3170d57a
DIFF:
https://github.com/llvm/llvm-project/commit/a669a237c45a515bea0d258cbbecdbbb3170d57a.di
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Thanks for unblocking me!!
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
I've just updated this PR to use
```
namespace lldb_private::plugin {
namespace swift {
```
PTAL, @JDevlieghere , @clayborg
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/68924
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@bulbazord , thanks!! I'll try to improve the type system and other parts of
the LLDB as I add support for my language.
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
walter-erquinigo wrote:
@bulbazord , ReadCStringFromMemory returns the length of the string, which in
the case of empty strings is 0!
So, this code was wrong since the beginning. The only thing to check is
error.Success() and not the size.
https://github.com/llvm/llvm-project/pull/68924
_
walter-erquinigo wrote:
@clayborg PTAL
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
> I think I'm missing something. The API's you are calling the lldb_plugin
> API's aren't really stand-alone, are they? The lldb_plugin::dwarf API's seem
> to have a bunch of methods that take lldb_private types. So you already have
> to have some kind of closure of
walter-erquinigo wrote:
> That expectations, combined with the fact that LLDB has plugins, makes it
> really sound like lldb_plugin is the interface we expose for writing
> (dynamically loadable) plugins.
I don't think people would have the expectation that you need to use
`lldb_plugin` for
walter-erquinigo wrote:
A problem that I'm seeing now is that if we move all the plugins to
`lldb_private::plugin`, the `liblldb-private.exports` file will by default emit
all the lldb symbols (the ones in plugins + the regular lldb_private symbols).
This can potentially be too many symbols, a
walter-erquinigo wrote:
Thanks, @JDevlieghere !
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated
with the program
}
```
+### Connect to a Debug Server on the Current Machine
+
+This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on
+the current machine, that is debugging the prog
walter-erquinigo wrote:
@jimingham , thanks! I reverted the changes to that method and left a tiny
comment mentioning that it's used by swift.
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From fa598fac03c2be067cf3adc7c2b161b403ebf4de Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From fd9b54296757e86b3798e6782513a11356c56622 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68927
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From de55d41ed7c3bed798953b69e401cfeb403304e0 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface,
dump(lldb::opaque_compiler_type_t type) const = 0;
#endif
- virtual void DumpValue(lldb::opaque_compiler_type_t type,
- ExecutionContext *exe_ctx, Stream &s,
- l
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From bf47938af6e80a02402a492ca7c61cf47391bd3c Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From c6ca8497de2cfabf22d29b8210021f36263302c9 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface,
dump(lldb::opaque_compiler_type_t type) const = 0;
#endif
- virtual void DumpValue(lldb::opaque_compiler_type_t type,
- ExecutionContext *exe_ctx, Stream &s,
- l
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From 8671fd2bb1808322e24688feba75e7b6df1a302e Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68927
>From ddea9112d479eddeaf95a30d5f3dd314cae6860b Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 16:58:08 -0400
Subject: [PATCH] [LLDB][NFC] Remove dead code
I found this type/types
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/68927
I found this type/typesystem code that is dead and seems to have been replaced
by the ValueObjectPrinter.
>From 2e589d7e13959947bf7c81b089f164ccd8d22906 Mon Sep 17 00:00:00 2001
From: walter erquinigo
@@ -19,6 +19,21 @@ def getFormatted(self, format, expr):
self.assertTrue(result.Succeeded(), result.GetError())
return result.GetOutput()
+@no_debug_info_test
+@skipIfWindows
+def testAllPlatforms(self):
+self.build()
+lldbutil.run_t
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68924
>From eaf314f813202fd71b884f3cd2e87db6cfd97e96 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 15:58:19 -0400
Subject: [PATCH 1/3] [LLDB] Fix type formatting empty c-strings
The t
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68924
>From eaf314f813202fd71b884f3cd2e87db6cfd97e96 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Thu, 12 Oct 2023 15:58:19 -0400
Subject: [PATCH 1/2] [LLDB] Fix type formatting empty c-strings
The t
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/68924
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/68924
The type formatter code is effectively considering empty strings as read
errors, which is wrong. The fix is very simple. We should rely on the error
object and stop checking the size. I also added a tes
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -212,6 +212,21 @@ This loads the coredump file `/cores/123.core` associated
with the program
}
```
+### Connect to a Remote Debug Server
+
+This connects to a debug server (e.g. `lldb-server`, `gdbserver`) that is
+debugging the program `/tmp/a.out` and listening locally o
walter-erquinigo wrote:
@JDevlieghere PTAL :)
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68150
>From 52f91bcf453790f89626b9d597671c17d0102dcb Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 16:56:16 -0400
Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin
A
walter-erquinigo wrote:
@clayborg has a very valid point. This will allow for better tuning of what
gets exported. I'll do that instead.
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/68234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
ping @clayborg
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@JDevlieghere PTAL
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68150
>From 96c00272c96f546b57902f0f98b0af383dae24c5 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 16:56:16 -0400
Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin
A
walter-erquinigo wrote:
sounds good! I'll do the change now
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@JDevlieghere , now that I think of it twice, I like the approach you mention
better. I'll use `lldb_private::plugin::dwarf` for the namespace then. Do you
still want these nested namespaces to be defined in three lines instead of one?
I could keep consistency as you me
@@ -18,7 +18,9 @@
#include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h"
#include
+namespace lldb_plugin::dwarf {
walter-erquinigo wrote:
Sure, I'll change that!!
https://github.com/llvm/llvm-project/pull/68150
___
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/68347
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68013
>From a472a16e6032ce0cef0acae6957f690f7e6cc4a3 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 13:56:00 -0400
Subject: [PATCH] [LLDB] Allow specifying a custom exports file
LLDB ha
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68013
>From d557ea59b9c24387244280566260c33ac6bb9367 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 13:56:00 -0400
Subject: [PATCH] [LLDB] Allow specifying a custom exports file
LLDB ha
walter-erquinigo wrote:
I'll add the warning as you guys mention. That'll set clear expectations on
what users will be getting.
Besides that, @bulbazord , the current symbols getting exported by
`third-party/llvm-project/lldb/source/API/liblldb-private.exports` are not all
the symbols, but ju
@@ -18,7 +18,9 @@
#include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h"
#include
+namespace lldb_plugin::dwarf {
walter-erquinigo wrote:
This is possible after the switch to c++17, and that's probably why no one else
is using it in LLDB. There's no expl
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/68234
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/68234
lldb-vscode had installation instructions based on creating a folder inside
~/.vscode/extensions, which no longer works. A different installation mechanism
is needed based on a VSCode command. More can
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68150
>From 92dc652698d7de826e28ce1563fa804366bab5c0 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 16:56:16 -0400
Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin
A
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/68150
>From 98c009c5f33b81d579fd11d11a660026f33836ae Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Mon, 2 Oct 2023 16:56:16 -0400
Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin
A
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/68150
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/68150
As a followup of https://github.com/llvm/llvm-project/pull/67851, I'm defining
a new namespace `lldb_plugin::dwarf` for the classes in this
Plugins/SymbolFile/DWARF folder. This change is very NFC and h
Author: walter erquinigo
Date: 2023-10-03T15:43:22-04:00
New Revision: 3674a0610a71becc54eab715905c4017d65471c4
URL:
https://github.com/llvm/llvm-project/commit/3674a0610a71becc54eab715905c4017d65471c4
DIFF:
https://github.com/llvm/llvm-project/commit/3674a0610a71becc54eab715905c4017d65471c4.di
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/68013
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo created
https://github.com/llvm/llvm-project/pull/68013
LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` that exports the lldb,
lldb_private namespaces, as well as other symbols like python and lua (see
`third-party/llvm-project/lldb/source/API/liblldb-priv
https://github.com/walter-erquinigo closed
https://github.com/llvm/llvm-project/pull/67851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
walter-erquinigo wrote:
@jimingham , indeed, I don't want to have a plugin that could be loadable by
any build of lldb. The Mojo SDK is distributing already its own build of
vanilla lldb along with the mojo plugin that is loaded at runtime and that
links correctly with that lldb.
I initially t
walter-erquinigo wrote:
> Perhaps instead of lldb_plugin we can name it something like
> lldb_private::plugin instead?
Well, that would definitely work for me, as these symbols would be
automatically exported alongside all the other `lldb_private` symbols. What I'm
not completely sure about
walter-erquinigo wrote:
After chatting with @clayborg , I'm going to try a different approach:
- putting all of these dwarf-related files from the plugin in a
`lldb_plugins::dwarf` namespace.
- adding a new cmake flag that operates along with `LLDB_EXPORT_ALL_SYMBOLS` to
specify a custom export
walter-erquinigo wrote:
@clayborg , LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` (see
https://github.com/llvm/llvm-project/blob/main/lldb/cmake/modules/AddLLDB.cmake#L177)
that is used to export `lldb_private` as well as `lldb` symbols. This shows
that there's been a precedent for this ki
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/67851
>From b5cfeaad26ecd29f15aadaad408ff30899a8a16d Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 29 Sep 2023 15:44:05 -0400
Subject: [PATCH] [LLDB] Export DWARF Parser symbols for external langu
https://github.com/walter-erquinigo ready_for_review
https://github.com/llvm/llvm-project/pull/67851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo edited
https://github.com/llvm/llvm-project/pull/67851
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo updated
https://github.com/llvm/llvm-project/pull/67851
>From 616b08f7c9e30b501d5f0fe2ff8d6fbf3ecb9582 Mon Sep 17 00:00:00 2001
From: walter erquinigo
Date: Fri, 29 Sep 2023 15:44:05 -0400
Subject: [PATCH] [LLDB] Export DWARF Parser symbols for external langu
401 - 500 of 874 matches
Mail list logo
