[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/68924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

walter-erquinigo wrote: @bulbazord , thanks!! I'll try to improve the type system and other parts of the LLDB as I add support for my language. https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

walter-erquinigo wrote: @bulbazord , ReadCStringFromMemory returns the length of the string, which in the case of empty strings is 0! So, this code was wrong since the beginning. The only thing to check is error.Success() and not the size. https://github.com/llvm/llvm-project/pull/68924

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

walter-erquinigo wrote: @clayborg PTAL https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

walter-erquinigo wrote: > I think I'm missing something. The API's you are calling the lldb_plugin > API's aren't really stand-alone, are they? The lldb_plugin::dwarf API's seem > to have a bunch of methods that take lldb_private types. So you already have > to have some kind of closure of

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

walter-erquinigo wrote: > That expectations, combined with the fact that LLDB has plugins, makes it > really sound like lldb_plugin is the interface we expose for writing > (dynamically loadable) plugins. I don't think people would have the expectation that you need to use `lldb_plugin` for

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

walter-erquinigo wrote: A problem that I'm seeing now is that if we move all the plugins to `lldb_private::plugin`, the `liblldb-private.exports` file will by default emit all the lldb symbols (the ones in plugins + the regular lldb_private symbols). This can potentially be too many symbols,

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

walter-erquinigo wrote: Thanks, @JDevlieghere ! https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

@@ -212,6 +212,38 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Debug Server on the Current Machine + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) on +the current machine, that is debugging the

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

walter-erquinigo wrote: @jimingham , thanks! I reverted the changes to that method and left a tiny comment mentioning that it's used by swift. https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68927 >From fa598fac03c2be067cf3adc7c2b161b403ebf4de Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 12 Oct 2023 16:58:08 -0400 Subject: [PATCH] [LLDB][NFC] Remove dead code I found this

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68927 >From fd9b54296757e86b3798e6782513a11356c56622 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 12 Oct 2023 16:58:08 -0400 Subject: [PATCH] [LLDB][NFC] Remove dead code I found this

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/68927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68927 >From de55d41ed7c3bed798953b69e401cfeb403304e0 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 12 Oct 2023 16:58:08 -0400 Subject: [PATCH] [LLDB][NFC] Remove dead code I found this

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface, dump(lldb::opaque_compiler_type_t type) const = 0; #endif - virtual void DumpValue(lldb::opaque_compiler_type_t type, - ExecutionContext *exe_ctx, Stream , -

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68927 >From bf47938af6e80a02402a492ca7c61cf47391bd3c Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 12 Oct 2023 16:58:08 -0400 Subject: [PATCH] [LLDB][NFC] Remove dead code I found this

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68927 >From c6ca8497de2cfabf22d29b8210021f36263302c9 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 12 Oct 2023 16:58:08 -0400 Subject: [PATCH] [LLDB][NFC] Remove dead code I found this

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

@@ -384,13 +384,15 @@ class TypeSystem : public PluginInterface, dump(lldb::opaque_compiler_type_t type) const = 0; #endif - virtual void DumpValue(lldb::opaque_compiler_type_t type, - ExecutionContext *exe_ctx, Stream , -

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68927 >From 8671fd2bb1808322e24688feba75e7b6df1a302e Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 12 Oct 2023 16:58:08 -0400 Subject: [PATCH] [LLDB][NFC] Remove dead code I found this

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68927 >From ddea9112d479eddeaf95a30d5f3dd314cae6860b Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 12 Oct 2023 16:58:08 -0400 Subject: [PATCH] [LLDB][NFC] Remove dead code I found this

[Lldb-commits] [lldb] [LLDB][NFC] Remove dead code (PR #68927)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/68927 I found this type/typesystem code that is dead and seems to have been replaced by the ValueObjectPrinter. >From 2e589d7e13959947bf7c81b089f164ccd8d22906 Mon Sep 17 00:00:00 2001 From: walter erquinigo

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

@@ -19,6 +19,21 @@ def getFormatted(self, format, expr): self.assertTrue(result.Succeeded(), result.GetError()) return result.GetOutput() +@no_debug_info_test +@skipIfWindows +def testAllPlatforms(self): +self.build() +

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68924 >From eaf314f813202fd71b884f3cd2e87db6cfd97e96 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 12 Oct 2023 15:58:19 -0400 Subject: [PATCH 1/3] [LLDB] Fix type formatting empty c-strings The

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68924 >From eaf314f813202fd71b884f3cd2e87db6cfd97e96 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Thu, 12 Oct 2023 15:58:19 -0400 Subject: [PATCH 1/2] [LLDB] Fix type formatting empty c-strings The

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/68924 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Fix type formatting empty c-strings (PR #68924)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/68924 The type formatter code is effectively considering empty strings as read errors, which is wrong. The fix is very simple. We should rely on the error object and stop checking the size. I also added a

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/68866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-vscode] Add example configuration for connecting to a remote gdbserver (PR #68866)

@@ -212,6 +212,21 @@ This loads the coredump file `/cores/123.core` associated with the program } ``` +### Connect to a Remote Debug Server + +This connects to a debug server (e.g. `lldb-server`, `gdbserver`) that is +debugging the program `/tmp/a.out` and listening locally

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

walter-erquinigo wrote: @JDevlieghere PTAL :) https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68150 >From 52f91bcf453790f89626b9d597671c17d0102dcb Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 16:56:16 -0400 Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

walter-erquinigo wrote: @clayborg has a very valid point. This will allow for better tuning of what gets exported. I'll do that instead. https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-vscode] Update installation instructions (PR #68234)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/68234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

walter-erquinigo wrote: ping @clayborg https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

walter-erquinigo wrote: @JDevlieghere PTAL https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68150 >From 96c00272c96f546b57902f0f98b0af383dae24c5 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 16:56:16 -0400 Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

walter-erquinigo wrote: sounds good! I'll do the change now https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

walter-erquinigo wrote: @JDevlieghere , now that I think of it twice, I like the approach you mention better. I'll use `lldb_private::plugin::dwarf` for the namespace then. Do you still want these nested namespaces to be defined in three lines instead of one? I could keep consistency as you

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

@@ -18,7 +18,9 @@ #include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h" #include +namespace lldb_plugin::dwarf { walter-erquinigo wrote: Sure, I'll change that!! https://github.com/llvm/llvm-project/pull/68150

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/68013 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

walter-erquinigo wrote: Thanks! https://github.com/llvm/llvm-project/pull/68013 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFCI] Remove use of ConstString from FilterRule in StructuredDataDarwinLog (PR #68347)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/68347 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68013 >From a472a16e6032ce0cef0acae6957f690f7e6cc4a3 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 13:56:00 -0400 Subject: [PATCH] [LLDB] Allow specifying a custom exports file LLDB

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/68013 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68013 >From d557ea59b9c24387244280566260c33ac6bb9367 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 13:56:00 -0400 Subject: [PATCH] [LLDB] Allow specifying a custom exports file LLDB

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

walter-erquinigo wrote: I'll add the warning as you guys mention. That'll set clear expectations on what users will be getting. Besides that, @bulbazord , the current symbols getting exported by `third-party/llvm-project/lldb/source/API/liblldb-private.exports` are not all the symbols, but

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

@@ -18,7 +18,9 @@ #include "llvm/DebugInfo/DWARF/DWARFLocationExpression.h" #include +namespace lldb_plugin::dwarf { walter-erquinigo wrote: This is possible after the switch to c++17, and that's probably why no one else is using it in LLDB. There's no

[Lldb-commits] [lldb] [lldb-vscode] Update installation instructions (PR #68234)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/68234 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Update installation instructions (PR #68234)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/68234 lldb-vscode had installation instructions based on creating a folder inside ~/.vscode/extensions, which no longer works. A different installation mechanism is needed based on a VSCode command. More can

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68150 >From 92dc652698d7de826e28ce1563fa804366bab5c0 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 16:56:16 -0400 Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/68150 >From 98c009c5f33b81d579fd11d11a660026f33836ae Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Mon, 2 Oct 2023 16:56:16 -0400 Subject: [PATCH] [LLDB][NFC] Create a namespace for the DWARF plugin

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/68150 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Create a namespace for the DWARF plugin (PR #68150)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/68150 As a followup of https://github.com/llvm/llvm-project/pull/67851, I'm defining a new namespace `lldb_plugin::dwarf` for the classes in this Plugins/SymbolFile/DWARF folder. This change is very NFC and

[Lldb-commits] [lldb] 3674a06 - [NFC][LLDB] Remove an unnecessary virtual destructor

Author: walter erquinigo Date: 2023-10-03T15:43:22-04:00 New Revision: 3674a0610a71becc54eab715905c4017d65471c4 URL: https://github.com/llvm/llvm-project/commit/3674a0610a71becc54eab715905c4017d65471c4 DIFF:

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/68013 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Allow specifying a custom exports file (PR #68013)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/68013 LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` that exports the lldb, lldb_private namespaces, as well as other symbols like python and lua (see

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

walter-erquinigo wrote: @jimingham , indeed, I don't want to have a plugin that could be loadable by any build of lldb. The Mojo SDK is distributing already its own build of vanilla lldb along with the mojo plugin that is loaded at runtime and that links correctly with that lldb. I initially

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

walter-erquinigo wrote: > Perhaps instead of lldb_plugin we can name it something like > lldb_private::plugin instead? Well, that would definitely work for me, as these symbols would be automatically exported alongside all the other `lldb_private` symbols. What I'm not completely sure about

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

walter-erquinigo wrote: After chatting with @clayborg , I'm going to try a different approach: - putting all of these dwarf-related files from the plugin in a `lldb_plugins::dwarf` namespace. - adding a new cmake flag that operates along with `LLDB_EXPORT_ALL_SYMBOLS` to specify a custom

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

walter-erquinigo wrote: @clayborg , LLDB has the cmake flag `LLDB_EXPORT_ALL_SYMBOLS` (see https://github.com/llvm/llvm-project/blob/main/lldb/cmake/modules/AddLLDB.cmake#L177) that is used to export `lldb_private` as well as `lldb` symbols. This shows that there's been a precedent for this

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67851 >From b5cfeaad26ecd29f15aadaad408ff30899a8a16d Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 29 Sep 2023 15:44:05 -0400 Subject: [PATCH] [LLDB] Export DWARF Parser symbols for external

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67851 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67851 >From 616b08f7c9e30b501d5f0fe2ff8d6fbf3ecb9582 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 29 Sep 2023 15:44:05 -0400 Subject: [PATCH] [LLDB] Export DWARF Parser symbols for external

[Lldb-commits] [lldb] [LLDB] Export DWARF Parser symbols for external language plugins (PR #67851)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/67851 None >From 78edde6c7b6294c0e1a78b18cdf81d156c636a38 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 29 Sep 2023 15:44:05 -0400 Subject: [PATCH] [LLDB] Export DWARF Parser symbols for

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

@@ -0,0 +1,100 @@ +"""A tool for extracting a list of private lldb symbols to export for MSVC. + +When exporting symbols from a dll or exe we either need to mark the symbols in +the source code as __declspec(dllexport) or supply a list of symbols to the +linker. Private symbols

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

@@ -0,0 +1,100 @@ +"""A tool for extracting a list of private lldb symbols to export for MSVC. + +When exporting symbols from a dll or exe we either need to mark the symbols in +the source code as __declspec(dllexport) or supply a list of symbols to the +linker. Private symbols

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

https://github.com/walter-erquinigo approved this pull request. Other than a few nits, this is awesome! https://github.com/llvm/llvm-project/pull/67628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Add windows support for LLDB_EXPORT_ALL_SYMBOLS (PR #67628)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: walter-erquinigo wrote: That's file. You can have multiple commits in the same PR, because when it gets approved and merged, github will squash all your commits into a single one. https://github.com/llvm/llvm-project/pull/67019

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/67165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/67165 >From 0f7b275c5fa608dce8b345c81794514abda017f3 Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 22 Sep 2023 12:29:46 -0400 Subject: [PATCH] [lldb][NFC] Move some ctors and tors to cpp files

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo ready_for_review https://github.com/llvm/llvm-project/pull/67165 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Move some ctors and tors to cpp files (PR #67165)

https://github.com/walter-erquinigo created https://github.com/llvm/llvm-project/pull/67165 This prevents undefined vtable errors when linking these libraries from out-of-tree. I'm facing this issue as I work on my new language plugin. >From 68818ce0376ba717157edaffd5ae2101cf26d4e2 Mon Sep

[Lldb-commits] [lldb] [lldb] add command start (PR #67019)

=?utf-8?q?José?= L. Junior Message-ID: In-Reply-To: walter-erquinigo wrote: Btw, I'm building support for the mojo language, and very likely the `main` method will not have the symbol `main`, so building an abstraction around this, for every language, would be very convenient.

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

walter-erquinigo wrote: Do you think it would be a good idea to provide aliases for the return values of the Update method with better names that match the behavior you just discovered? I'm not a fan of true/false in this case, because it confuses synthetic type developers, but I'm just

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

https://github.com/walter-erquinigo approved this pull request. https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

@@ -659,3 +659,16 @@ def test_fs_gs_base(self): pthread_self_val.GetValueAsUnsigned(0), "fs_base does not equal to pthread_self() value.", ) + +def test_process_must_be_stopped(self): +"""Check that all register commands error when

[Lldb-commits] [lldb] [lldb] Require paused process and frame for "register info" command (PR #67124)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/67124 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Lazy deference underlying object for shared/weak/unique_ptr synthetic… (PR #67069)

walter-erquinigo wrote: @jimingham , IIRC from old experiments regarding the synthetic formatter code, `true` is returned when you want to avoid caching the results of the `Update`, which means that if you want to persist the success or the failure, you just return `false`. I might be wrong

[Lldb-commits] [lldb] [lldb] Fix stdcpp type summary mistakenly marked as regex (NFC) (PR #66949)

https://github.com/walter-erquinigo approved this pull request. Good catch! I think I have suffered because of this at some point. https://github.com/llvm/llvm-project/pull/66949 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Use auto summaries whenever variables don't have a summary (PR #66551)

https://github.com/walter-erquinigo edited https://github.com/llvm/llvm-project/pull/66551 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66551 >From 4c9d8d3f5be34d5ffec502a8fa891b603549b2cc Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:50:35 -0400 Subject: [PATCH] [lldb-vscode] Use auto summaries when variables have

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: Thanks, man! On Tue, Sep 19, 2023, 4:53 AM David Spickett ***@***.***> wrote: > 9568601 > > > — > Reply to this email directly, view it on GitHub >

[Lldb-commits] [lldb] 266630c - [LLDB] Attempt to fix DumpDataExtractorTest

Author: Walter Erquinigo Date: 2023-09-18T22:02:05Z New Revision: 266630cffceefbe3b00f34ba8efcfba62259335e URL: https://github.com/llvm/llvm-project/commit/266630cffceefbe3b00f34ba8efcfba62259335e DIFF: https://github.com/llvm/llvm-project/commit/266630cffceefbe3b00f34ba8efcfba62259335e.diff

[Lldb-commits] [lldb] 014c41d - [LLDB] Attempt to fix DumpDataExtractorTest

Author: Walter Erquinigo Date: 2023-09-18T21:30:42Z New Revision: 014c41d688f961cdb81cf92e6ba97100a49766a6 URL: https://github.com/llvm/llvm-project/commit/014c41d688f961cdb81cf92e6ba97100a49766a6 DIFF: https://github.com/llvm/llvm-project/commit/014c41d688f961cdb81cf92e6ba97100a49766a6.diff

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

walter-erquinigo wrote: > if it doesn't have a summary and we auto generate one, then we can append the > generated summary string That makes a ton of sense. I'll try that approach. Thanks https://github.com/llvm/llvm-project/pull/66551 ___

[Lldb-commits] [lldb] 9389b05 - [lldb] Fix the TestValueAPI test

Author: walter erquinigo Date: 2023-09-18T13:57:25-04:00 New Revision: 9389b056a604b7da9478bb40125d6a1ad379823a URL: https://github.com/llvm/llvm-project/commit/9389b056a604b7da9478bb40125d6a1ad379823a DIFF:

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo closed https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: Thanks Jim and Greg! https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

walter-erquinigo wrote: I've updated the PR following Greg's suggestions. https://github.com/llvm/llvm-project/pull/66548 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add a setting for printing ValueObject hex values without leading zeroes (PR #66548)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66548 >From 3bddb5d5f813d5eac165be1a73b9058f5ee0510d Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:41:23 -0400 Subject: [PATCH] [LLDB] Add a setting for print hex variable values

[Lldb-commits] [lldb] [lldb-vscode] Show addresses next to dereferenced summaries when using enableAutoVariableSummaries (PR #66551)

https://github.com/walter-erquinigo updated https://github.com/llvm/llvm-project/pull/66551 >From 31236a70c8d1736563a253dc3a2582366220cb8f Mon Sep 17 00:00:00 2001 From: walter erquinigo Date: Fri, 15 Sep 2023 16:50:35 -0400 Subject: [PATCH] [lldb-vscode] Show addresses next to dereferenced

<    1   2   3   4   5   6   7   8   >