Re: [PATCH] i2c: nvidia-gpu: Use PTR_ERR_OR_ZERO() to simplify code

2020-05-22 Thread Wolfram Sang
On Tue, May 05, 2020 at 08:22:30PM +0530, Aishwarya Ramakrishnan wrote: > PTR_ERR_OR_ZERO contains if(IS_ERR(...)) + PTR_ERR. > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Signed-off-by: Aishwarya Ramakrishnan Waiting for the Rev-by from Ajay (driver maintainer). > --- >

Re: [PATCH v2] i2c: cadence: Add an error handling for platform_get_irq()

2020-05-22 Thread Wolfram Sang
> The change is valid but the question is if make sense to do it in this > way. Some drivers are using devm_request_irq to do do job. > > For example: > id->irq = platform_get_irq(pdev, 0); > ret = devm_request_irq(>dev, id->irq, cdns_i2c_isr, 0, >

Re: [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe()

2020-05-22 Thread Wolfram Sang
On Fri, May 22, 2020 at 05:04:18PM +0200, Wolfram Sang wrote: > On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote: > > In the function efm32_i2c_probe(),when get irq failed,the function > > platform_get_irq() logs an error message,so remove redundant message > > here

Re: [PATCH] i2c: drivers: Avoid unnecessary check in efm32_i2c_probe()

2020-05-22 Thread Wolfram Sang
On Wed, Apr 15, 2020 at 10:06:40PM +0800, Tang Bin wrote: > The function efm32_i2c_probe() is only called with an > openfirmware platform device.Therefore there is no need > to check that it has an openfirmware node. > > Signed-off-by: Tang Bin > Signed-off-by: Shengju Zhang Applied to

Re: [PATCH] i2c: drivers: Omit superfluous error message in efm32_i2c_probe()

2020-05-22 Thread Wolfram Sang
On Wed, Apr 15, 2020 at 09:57:34PM +0800, Tang Bin wrote: > In the function efm32_i2c_probe(),when get irq failed,the function > platform_get_irq() logs an error message,so remove redundant message > here. > > Signed-off-by: Tang Bin > Signed-off-by: Shengju Zhang Applied to for-next, thanks!

Re: [PATCH v12 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-22 Thread Wolfram Sang
On Thu, May 21, 2020 at 02:09:09PM +0300, Tali Perry wrote: > Add Nuvoton NPCM BMC I2C controller driver. > > Signed-off-by: Tali Perry This is a very complex driver, so I can really comment only about high level things. Thank you very much for keeping at it! My code checkers say: CHECKPATCH:

Re: [PATCH] i2c: core: fix NULL pointer dereference in suspend/resume callbacks

2020-05-22 Thread Wolfram Sang
On Fri, May 22, 2020 at 01:15:12PM +0200, Marek Szyprowski wrote: > Hi All, > > On 22.05.2020 12:13, Marek Szyprowski wrote: > > Commit 6fe12cdbcfe3 ("i2c: core: support bus regulator controlling in > > adapter") added generic suspend and resume functions for i2c devices. > > Those functions

Re: [PATCH v12 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-21 Thread Wolfram Sang
> From a glimpse, this looks good to go. I will have a close look later > today. Phew, this driver is huge. I won't finish my review today, but I am working on it and am maybe 2/3 through. signature.asc Description: PGP signature

Re: [PATCH v12 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-21 Thread Wolfram Sang
> > > I wondered also about DEBUG_FS entries. I can see their value when > > > developing the driver. But since this is done now, do they really help a > > > user to debug a difficult case? I am not sure, and then I wonder if we > > > should have that code in upstream. I am open for discussion,

Re: [PATCH v12 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-21 Thread Wolfram Sang
Hi Tali, Andy! On Thu, May 21, 2020 at 05:23:40PM +0300, Andy Shevchenko wrote: > On Thu, May 21, 2020 at 02:09:09PM +0300, Tali Perry wrote: > > Add Nuvoton NPCM BMC I2C controller driver. > > Thanks. My comments below. > After addressing them, FWIW, > Reviewed-by: Andy Shevchenko Thanks,

Re: Re: [RFC PATCH] i2c: at91: Fix pinmux after devm_gpiod_get() for bus recovery

2020-05-20 Thread Wolfram Sang
> > This will do for 5.7. For 5.8 or 5.9, I can imagine to take the two > > pinctrl_state pointers into bus_recovery_info and handle all this in the > > core. I will try this later this week if noone is super-eager to try it > > out before. > > > > By 'all this' you mean to move the entire

Re: [next] i2c: mediatek: Use div_u64 for 64-bit division to fix 32-bit kernels

2020-05-20 Thread Wolfram Sang
On Wed, May 20, 2020 at 06:31:53PM +0800, qii.w...@mediatek.com wrote: > From: Qii Wang > > Use div_u64 for 64-bit division, and change sample_ns type to > unsigned int. Otherwise, the module will reference __udivdi3 > under 32-bit kernels, which is not allowed in kernel space. > >

Re: linux-next: Tree for May 19 (i2c/busses/i2c-mt65xx.o)

2020-05-20 Thread Wolfram Sang
On Tue, May 19, 2020 at 05:24:30PM -0700, Randy Dunlap wrote: > On 5/19/20 11:03 AM, Stephen Rothwell wrote: > > Hi all, > > > > News: there will be no linux-next release tomorrow. > > > > Changes since 20200518: > > > > on i386: > > ERROR: modpost: "__udivdi3"

Re: [PULL REQUEST] i2c for v5.8

2020-05-19 Thread Wolfram Sang
On Tue, May 19, 2020 at 08:36:13AM +0200, Wolfram Sang wrote: > Linus, > > here is the pull request which I missed last week. It contains a set of > driver and core fixes as well as MAINTAINER updates. Sorry, kernel version in $subject should have been v5.7! > > Please

[PULL REQUEST] i2c for v5.8

2020-05-19 Thread Wolfram Sang
Wolfram Sang (2): i2c: use my kernel.org address from now on i2c: algo-pca: update contact email .mailmap | 2 ++ MAINTAINERS | 9 - drivers/i2c/algos/i2c-algo-pca.c | 2 +- drivers/i2c/busses/i2c-altera.c | 10

Re: [PATCH][next] i2c: mediatek: fix integer overflow on an integer multiplication

2020-05-18 Thread Wolfram Sang
On Mon, May 18, 2020 at 05:55:29PM +0100, Colin King wrote: > From: Colin Ian King > > Currently the calculation of sample_ns is using a 32 bit integer > multiplication and can potentially overflow. Fix this by making the > constant a long long to use a 64 bit multiply and hence > avoid an

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Wolfram Sang
Hi Prabhakar, > > Leaves us with a seperate compatible entry for it? > > > Sounds okay to me, how about "renesas,iic-no-dvfs" ? So that this > could be used on all the SoC's which don't support DVFS. Well, the feature missing is used for DVFS, but its name is "automatic transmission". So, I'd

Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

2020-05-18 Thread Wolfram Sang
> Its similar to as seen on Rcar-H2 where just the A15 cores are up and > A7 cores fail to boot. Attached is the boot log where reboot works as > expected with all A15 core up. Although I have tested the internal > release based on 3.10 where all the cores are up which used bootarg >

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-18 Thread Wolfram Sang
> > However, both versions (with and without automatic transmission) are > > described with the same "renesas,iic-r8a7742" compatible. Is it possible > > to detect the reduced variant at runtime somehow? > > > I couldn't find anything the manual that would be useful to detect at runtime. > > >

Re: [PATCH 17/17] ARM: dts: r8a7742: Add RWDT node

2020-05-17 Thread Wolfram Sang
it against similar SoCs (like the previous patched). So, for that: Reviewed-by: Wolfram Sang However, just to make sure, have you checked the WDT (especially reboot) with SMP and multiple CPU cores enabled? Some early Gen2 SoCs had issues there. signature.asc Description: PGP signature

Re: [PATCH 16/17] dt-bindings: watchdog: renesas,wdt: Document r8a7742 support

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:56PM +0100, Lad Prabhakar wrote: > RZ/G1H (R8A7742) watchdog implementation is compatible with R-Car Gen2, > therefore add relevant documentation. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewe

Re: [PATCH 15/17] ARM: dts: r8a7742: Add APMU nodes

2020-05-17 Thread Wolfram Sang
ristian Rotariu > Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 14/17] dt-bindings: power: renesas,apmu: Document r8a7742 support

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:54PM +0100, Lad Prabhakar wrote: > Document APMU and SMP enable method for RZ/G1H (also known as r8a7742) > SoC. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 12/17] ARM: dts: r8a7742: Add Ethernet AVB support

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:52PM +0100, Lad Prabhakar wrote: > Add Ethernet AVB support for R8A7742 SoC. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 13/17] ARM: dts: r8a7742: Add Ether support

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:53PM +0100, Lad Prabhakar wrote: > Define the generic R8A7742 part of the Ether device node. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 11/17] dt-bindings: net: renesas,ether: Document R8A7742 SoC

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:51PM +0100, Lad Prabhakar wrote: > Document RZ/G1H (R8A7742) SoC bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 10/17] dt-bindings: net: renesas,ravb: Add support for r8a7742 SoC

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:50PM +0100, Lad Prabhakar wrote: > Document RZ/G1H (R8A7742) SoC bindings. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 09/17] ARM: dts: r8a7742: Add sata nodes

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:49PM +0100, Lad Prabhakar wrote: > Add the sata devices nodes to the R8A7742 device tree. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 08/17] dt-bindings: ata: renesas,rcar-sata: Add r8a7742 support

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:48PM +0100, Lad Prabhakar wrote: > Document SATA support for the RZ/G1H, which is compatible with > R-Car Gen2 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang signature.as

Re: [PATCH 07/17] ARM: dts: r8a7742: Add MMC0 node

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:47PM +0100, Lad Prabhakar wrote: > Describe MMC0 device node in the R8A7742 device tree. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 06/17] ARM: dts: r8a7742: Add SDHI nodes

2020-05-17 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:46PM +0100, Lad Prabhakar wrote: > Add the SDHI devices nodes to the R8A7742 device tree. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 05/17] mmc: renesas_sdhi_sys_dmac: Add support for r8a7742 SoC

2020-05-15 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:45PM +0100, Lad Prabhakar wrote: > Add support for r8a7742 SoC. Renesas RZ/G1H (R8A7742) SDHI is identical to > the R-Car Gen2 family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > I think we can skip this because of the generic

Re: [PATCH 04/17] dt-bindings: mmc: renesas,sdhi: Document r8a7742 support

2020-05-15 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:44PM +0100, Lad Prabhakar wrote: > Document SDHI controller for RZ/G1H (R8A7742) SoC, which is compatible > with R-Car Gen2 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang

Re: [PATCH 02/17] dt-bindings: i2c: renesas,iic: Document r8a7742 support

2020-05-15 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:42PM +0100, Lad Prabhakar wrote: > Document IIC controller for RZ/G1H (R8A7742) SoC, which is compatible > with R-Car Gen2 SoC family. > > Signed-off-by: Lad Prabhakar > Reviewed-by: Marian-Cristian Rotariu > Reviewed-by: Wolfram Sang

Re: [PATCH 01/17] dt-bindings: i2c: renesas,i2c: Document r8a7742 support

2020-05-15 Thread Wolfram Sang
fine-grained (e.g. group all simple additions like this in one patch) but still: Reviewed-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH 03/17] ARM: dts: r8a7742: Add I2C and IIC support

2020-05-15 Thread Wolfram Sang
On Fri, May 15, 2020 at 04:08:43PM +0100, Lad Prabhakar wrote: > Add the I2C[0-3] and IIC[0-3] devices nodes to the R8A7742 device tree. > > Automatic transmission for PMIC control is not available on IIC3 hence > compatible string "renesas,rcar-gen2-iic" and "renesas,rmobile-iic" is > not added

Re: [PATCH 1/4] dt-bindings: i2c: Document I2C controller binding for MT6797 SoC

2020-05-15 Thread Wolfram Sang
> > > > Do you want to take this thorough your tree or are you OK if I take it > thorough > mine? The I2C list is neither in the CC field, nor is the patch in patchwork. I suggest you take it. Acked-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH v2 2/2] i2c: mediatek: Add i2c ac-timing adjust support

2020-05-15 Thread Wolfram Sang
On Thu, May 14, 2020 at 09:09:05PM +0800, Qii Wang wrote: > This patch adds a algorithm to calculate some ac-timing parameters > which can fully meet I2C Spec. > > Signed-off-by: Qii Wang Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH v2 1/2] MAINTAINERS: add maintainer for mediatek i2c controller driver

2020-05-15 Thread Wolfram Sang
On Thu, May 14, 2020 at 09:09:04PM +0800, Qii Wang wrote: > Add Qii Wang as maintainer for mediatek i2c controller driver. > > Signed-off-by: Qii Wang Applied to for-current, thanks for stepping up! signature.asc Description: PGP signature

Re: [PATCH] i2c: at91: Restore pinctrl state if can't get scl/sda gpios

2020-05-15 Thread Wolfram Sang
On Wed, May 13, 2020 at 02:13:22PM +0300, Codrin Ciubotariu wrote: > If there is a strict pinmux or if simply the scl/sda gpios are missing, > the pins will remain in gpio mode, compromizing the I2C bus. > Change to the default state of the pins before returning the error. > > Fixes: a53acc7ebf27

[PATCH] drm/vblank: remove outdated and noisy output

2020-05-15 Thread Wolfram Sang
, the vblank init message is displayed again when the DU driver is retried. Because the message doesn't really carry a useful information, I suggest to simply drop it. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/drm_vblank.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] i2c: mediatek: Add i2c ac-timing adjust support

2020-05-14 Thread Wolfram Sang
> > Last question: You seem to be the one doing major updates to this > > driver. Thanks for that! Are you maybe interested in becoming the > > maintainer for this driver? I think there won't be much patches to > > review and reports to handle but it will speed up processing for me. > > Yes, It

[PATCH] drm/vblank: remove outdated and noisy output

2020-05-13 Thread Wolfram Sang
, the vblank init message is displayed again when the DU driver is retried. Because the message doesn't really carry a useful information, I suggest to simply drop it. Signed-off-by: Wolfram Sang --- drivers/gpu/drm/drm_vblank.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm

Re: [PATCH] i2c: mux: Replace zero-length array with flexible-array

2020-05-13 Thread Wolfram Sang
> If that's not much work for you, then it'd be great if you include > it for 5.7. :) No problem, done now! signature.asc Description: PGP signature

Re: [PATCH 0/2] drm: encoder_slave: some updates

2020-05-13 Thread Wolfram Sang
On Mon, Mar 16, 2020 at 05:39:05PM +0100, Wolfram Sang wrote: > While converting I2C users to new APIs, I found a refcounting problem in > the encoder_slave implementation. This series fixes it and converts to > the new API. > > Based on linux-next and only build tested. >

Re: [PATCH 1/1] video: backlight: tosa_lcd: convert to use i2c_new_client_device()

2020-05-13 Thread Wolfram Sang
On Fri, Apr 17, 2020 at 11:14:46AM +0100, Lee Jones wrote: > On Thu, 26 Mar 2020, Wolfram Sang wrote: > > > Move away from the deprecated API and return the shiny new ERRPTR where > > useful. > > > > Signed-off-by: Wolfram Sang > > --- > > drivers/

Re: [PATCH] char: ipmi: convert to use i2c_new_client_device()

2020-05-13 Thread Wolfram Sang
On Tue, May 12, 2020 at 04:45:32PM -0500, miny...@acm.org wrote: > From: Wolfram Sang > > Move away from the deprecated API. > > Based on a patch by Wolfram Sang . > > Signed-off-by: Corey Minyard > --- > I think this works. Yes, we can do it like this (despit

Re: [PATCH 1/1] mfd: htc-i2cpld: convert to use i2c_new_client_device()

2020-05-13 Thread Wolfram Sang
> Haven't pushed for a while. Should be there when -next is rebuilt. Thanks, Lee! signature.asc Description: PGP signature

Re: [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device()

2020-05-13 Thread Wolfram Sang
> > - addr_info->added_client = i2c_new_device(to_i2c_adapter(adev), > > -_info->binfo); > > + addr_info->added_client = i2c_new_client_device(to_i2c_adapter(adev), > > + _info->binfo); > >

Re: [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device()

2020-05-12 Thread Wolfram Sang
On Tue, May 12, 2020 at 01:25:17PM -0500, Corey Minyard wrote: > On Thu, Mar 26, 2020 at 10:09:58PM +0100, Wolfram Sang wrote: > > Move away from the deprecated API. > > > > Signed-off-by: Wolfram Sang > > Ok by me. > > Acked-by: Corey Minyard > > Do yo

Re: [PATCH 1/1] x86/platform/intel-mid: convert to use i2c_new_client_device()

2020-05-12 Thread Wolfram Sang
On Thu, Mar 26, 2020 at 10:10:15PM +0100, Wolfram Sang wrote: > Move away from the deprecated API and return the shiny new ERRPTR where > useful. > > Signed-off-by: Wolfram Sang > --- Can we have this now so I can remove the old API in the next merge window? Andy already revi

Re: [PATCH 1/1] char: ipmi: convert to use i2c_new_client_device()

2020-05-12 Thread Wolfram Sang
On Thu, Mar 26, 2020 at 10:09:58PM +0100, Wolfram Sang wrote: > Move away from the deprecated API. > > Signed-off-by: Wolfram Sang Can we have this now so I can remove the old API in the next merge window? > --- > drivers/char/ipmi/ipmi_ssif.c | 4 ++-- > 1 file changed,

Re: [PATCH 0/2] drm: encoder_slave: some updates

2020-05-12 Thread Wolfram Sang
On Mon, Mar 16, 2020 at 05:39:05PM +0100, Wolfram Sang wrote: > While converting I2C users to new APIs, I found a refcounting problem in > the encoder_slave implementation. This series fixes it and converts to > the new API. > > Based on linux-next and only build tested. >

Re: [PATCH 1/1] power: supply: bq24190_charger: convert to use i2c_new_client_device()

2020-05-12 Thread Wolfram Sang
On Thu, Mar 26, 2020 at 10:09:54PM +0100, Wolfram Sang wrote: > Move away from the deprecated API in this comment. > > Signed-off-by: Wolfram Sang Can we have this now so I can remove the old API in the next merge window? > --- > drivers/power/supply/bq24190_charger.c | 2 +- &g

Re: [PATCH 1/1] video: backlight: tosa_lcd: convert to use i2c_new_client_device()

2020-05-12 Thread Wolfram Sang
On Fri, Apr 17, 2020 at 11:14:46AM +0100, Lee Jones wrote: > On Thu, 26 Mar 2020, Wolfram Sang wrote: > > > Move away from the deprecated API and return the shiny new ERRPTR where > > useful. > > > > Signed-off-by: Wolfram Sang > > --- > > drivers/

Re: [PATCH 1/1] mfd: htc-i2cpld: convert to use i2c_new_client_device()

2020-05-12 Thread Wolfram Sang
On Wed, Apr 15, 2020 at 12:04:42PM +0100, Lee Jones wrote: > On Thu, 26 Mar 2020, Wolfram Sang wrote: > > > Move away from the deprecated API and return the shiny new ERRPTR where > > useful. > > > > Signed-off-by: Wolfram Sang > > --- > > drive

Re: [PATCH] i2c: mediatek: Add i2c ac-timing adjust support

2020-05-12 Thread Wolfram Sang
Hi Qii Wang, On Thu, Mar 26, 2020 at 07:54:36PM +0800, qii.w...@mediatek.com wrote: > From: Qii Wang > > This patch adds a algorithm to calculate some ac-timing parameters > which can fully meet I2C Spec. > > Signed-off-by: Qii Wang Could you rebase this on top of i2c/for-next or v5.7-rcX?

Re: [PATCH] i2c: mux: demux-pinctrl: Fix an error handling path in 'i2c_demux_pinctrl_probe()'

2020-05-12 Thread Wolfram Sang
On Wed, May 06, 2020 at 09:21:00PM +0200, Christophe JAILLET wrote: > A call to 'i2c_demux_deactivate_master()' is missing in the error handling > path, as already done in the remove function. > > Fixes: 50a5ba876908 ("i2c: mux: demux-pinctrl: add driver") > Signed-off-by: Christophe JAILLET

Re: [PATCH] i2c: mux: Replace zero-length array with flexible-array

2020-05-12 Thread Wolfram Sang
On Thu, May 07, 2020 at 01:53:29PM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced

Re: [PATCH] i2c: algo-pca: update contact email

2020-05-11 Thread Wolfram Sang
On Sat, May 02, 2020 at 04:26:49PM +0200, Wolfram Sang wrote: > The 'pengutronix' address is defunct for years. Use the proper contact > address. > > Signed-off-by: Wolfram Sang Applied to for-current, thanks! signature.asc Description: PGP signature

Bug#892261: fixed upstream

2020-05-05 Thread Wolfram Sang
Fixed upstream with commit aef913e ("mmc-utils: use MMC_IOC_MULTI_CMD for RPMB access") since December 2018. signature.asc Description: PGP signature

Bug#791707: Fixed upstream

2020-05-05 Thread Wolfram Sang
The issue has been fixed upstream since April 2016 with commit 2e31d1c3a ("chrt: validate priority before trying to use it") which also mentions this bugreport. signature.asc Description: PGP signature

Re: [PATCH] powerpc/5200: update contact email

2020-05-05 Thread Wolfram Sang
> > My 'pengutronix' address is defunct for years. Merge the entries and use > > the proper contact address. > > Is there any point adding the new address? It's just likely to bit-rot > one day too. At least, this one is a group address, not an individual one, so less likey. > I figure the git

Re: [PATCH] powerpc/5200: update contact email

2020-05-05 Thread Wolfram Sang
> > My 'pengutronix' address is defunct for years. Merge the entries and use > > the proper contact address. > > Is there any point adding the new address? It's just likely to bit-rot > one day too. At least, this one is a group address, not an individual one, so less likey. > I figure the git

Re: [PATCH v3] i2c: at91: support atomic write xfer

2020-05-05 Thread Wolfram Sang
Hi, > I don't expect this to be used for much more than a simple write to PMIC > to kill the power. So this patch is tailor made for exactly this purpose. Frankly, I don't like it much. The atomic callbacks are supposed to be drop-in replacements of the non-atomic contexts. There may be a need

Re: [RFC PATCH] i2c: at91: Fix pinmux after devm_gpiod_get() for bus recovery

2020-05-05 Thread Wolfram Sang
On Wed, Apr 15, 2020 at 10:06:43AM +0300, Codrin Ciubotariu wrote: > devm_gpiod_get() usually calls gpio_request_enable() for non-strict pinmux > drivers. These puts the pins in GPIO mode, whithout notifying the pinctrl > driver. At this point, the I2C bus no longer owns the pins. To mux the >

Re: [PATCH v4 1/4] i2c: at91: Send bus clear command if SDA is down

2020-05-05 Thread Wolfram Sang
On Tue, Feb 25, 2020 at 05:50:09PM +0200, Codrin Ciubotariu wrote: > After a transfer timeout, some faulty I2C slave devices might hold down > the SDA pin. We can generate a bus clear command, hoping that the slave > might release the pins. > If the CLEAR command is not supported, we will use gpio

Re: [PATCH] i2c: use my kernel.org address from now on

2020-05-05 Thread Wolfram Sang
On Sat, May 02, 2020 at 02:18:35PM +0200, Wolfram Sang wrote: > The old email is still active, but for easier handling, I am going to > use my kernel.org address from now on. Also, add a mailmap for the now > defunct Pengutronix address. > > Signed-off-by: Wolfram Sang Applied

Re: [PATCH] i2c: fix missing pm_runtime_put_sync in i2c_device_probe

2020-05-05 Thread Wolfram Sang
On Thu, Apr 30, 2020 at 05:43:21PM +0200, Alain Volmat wrote: > In case of the I2C client exposes the flag I2C_CLIENT_HOST_NOTIFY, > pm_runtime_get_sync is called in order to always keep active the > adapter. However later on, pm_runtime_put_sync is never called > within the function in case of an

Re: [PATCH] i2c: drivers: Remove superfluous error message

2020-05-05 Thread Wolfram Sang
On Mon, May 04, 2020 at 05:14:06PM +0530, Aishwarya Ramakrishnan wrote: > The function platform_get_irq can log an error by itself. > This omit a redundant message for exception handling in the > calling function. > > Suggested by Coccinelle. > > Signed-off-by: Aishwarya Ramakrishnan Sorry, I

[sigrok-devel] [PATCH libsigrok v2] openbench-logic-sniffer: improve error messages when scanning ID

2020-05-04 Thread Wolfram Sang
From: Wolfram Sang - always say 'ID' when the ID command failed - print hexdump of a faulty ID because on a stalled device we may get 0x00 bytes which would terminate the string early. Introduce a new 'num_read' variable to avoid that in a future change 'ret' might get reused and destroy

[sigrok-devel] [PATCH libsigrok v2] serial: flush() after open() in the serial core.

2020-05-03 Thread Wolfram Sang
(serial, ...) ... when != serial - serial_flush(serial); and then the results and the unmatched findings of serial_flush() were audited. Signed-off-by: Wolfram Sang --- Changes since V1: - do the generic flush *after* setting parameters src/hardware/agilent-dmm/api.c

Re: [sigrok-devel] [RFC PATCH] Flush buffers when opening port

2020-05-03 Thread Wolfram Sang
On Sat, Apr 11, 2020 at 10:07:39PM +0200, Wolfram Sang wrote: > Make sure that all buffers are empty after opening (on all supported > systems). > > Signed-off-by: Wolfram Sang > --- > > This came up while debugging bug #1025. It doesn't fix the bug but I > think

[sigrok-devel] [PATCH libsigrok] openbench-logic-sniffer: improve error messages when scanning ID

2020-05-03 Thread Wolfram Sang
From: Wolfram Sang - always say 'ID' when the ID command failed - print hexdump of a faulty ID because on a stalled device we may get 4 0x00 bytes which would terminate the string early. Made debugging OLS startup issues a lot easier. Signed-off-by: Wolfram Sang --- src/hardware/openbench

Re: [sigrok-devel] [PATCH RFC libsigrok] serial: flush() after open() in the serial core.

2020-05-03 Thread Wolfram Sang
> @@ -122,6 +122,10 @@ SR_PRIV int serial_open(struct sr_serial_dev_inst > *serial, int flags) > if (ret != SR_OK) > return ret; > > + ret = serial_flush(serial); > + if (ret != SR_OK) > + return ret; > + > if (serial->serialcomm) >

Re: [PATCH] i2c: uniphier: Remove superfluous error message in uniphier_i2c_probe()

2020-05-03 Thread Wolfram Sang
On Sun, May 03, 2020 at 05:38:47PM +0530, Aishwarya Ramakrishnan wrote: > The function platform_get_irq can log an error by itself. > This omit a redundant message for exception handling in the > calling function. > > Suggested by Coccinelle. > > Signed-off-by: Aishwarya Ramakrishnan Please

[PATCH] powerpc/5200: update contact email

2020-05-02 Thread Wolfram Sang
My 'pengutronix' address is defunct for years. Merge the entries and use the proper contact address. Signed-off-by: Wolfram Sang --- arch/powerpc/boot/dts/pcm032.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/pcm032.dts b/arch/powerpc/boot/dts

Re: [PATCH] mmc: sdhci-esdhc: update contact email

2020-05-02 Thread Wolfram Sang
On Sat, May 02, 2020 at 08:39:16AM -0700, Joe Perches wrote: > On Sat, 2020-05-02 at 16:28 +0200, Wolfram Sang wrote: > > The 'pengutronix' address is defunct for years. Use the proper contact > > address. > > Maybe add a .mailmap entry? Yes, it is in another patch: http:/

Re: [PATCH v2 1/2] i2c: tegra: Better handle case where CPU0 is busy for a long time

2020-05-02 Thread Wolfram Sang
> I'll try not to forget about these patches to resubmit them later on, > once the problem will be resolved :) Don't worry, I'll keep an eye on these issues, too :) signature.asc Description: PGP signature

[PATCH] watchdog: update email address in conversion doc

2020-05-02 Thread Wolfram Sang
The old one is defunct. However, I think it makes sense that I am still the primary contact person for updates here. Signed-off-by: Wolfram Sang --- ... if there will be any. Let me know if you agree. Documentation/watchdog/convert_drivers_to_kernel_api.rst | 2 +- 1 file changed, 1 insertion

[PATCH] mmc: sdhci-esdhc: update contact email

2020-05-02 Thread Wolfram Sang
The 'pengutronix' address is defunct for years. Use the proper contact address. Signed-off-by: Wolfram Sang --- drivers/mmc/host/sdhci-esdhc.h | 2 +- include/linux/platform_data/mmc-esdhc-imx.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host

[PATCH] rtc: stmp3xxx: update contact email

2020-05-02 Thread Wolfram Sang
The 'pengutronix' address is defunct for years. Use the proper contact address. Signed-off-by: Wolfram Sang --- drivers/rtc/rtc-stmp3xxx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-stmp3xxx.c b/drivers/rtc/rtc-stmp3xxx.c index ff6488be385f..c9bc3d4a1e66

[PATCH] can: mscan: mpc5xxx_can: update contact email

2020-05-02 Thread Wolfram Sang
The 'pengutronix' address is defunct for years. Use the proper contact address. Signed-off-by: Wolfram Sang --- drivers/net/can/mscan/mpc5xxx_can.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/can/mscan/mpc5xxx_can.c b/drivers/net/can/mscan/mpc5xxx_can.c

[PATCH] hwmon: adt7411: update contact email

2020-05-02 Thread Wolfram Sang
My 'pengutronix' address is defunct for years. Merge the entries and use the proper contact address. Signed-off-by: Wolfram Sang --- drivers/hwmon/adt7411.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/hwmon/adt7411.c b/drivers/hwmon/adt7411.c index c7010b91bc13

[PATCH] watchdog: imx2_wdt: update contact email

2020-05-02 Thread Wolfram Sang
The 'pengutronix' address is defunct for years. Use the proper contact address. Signed-off-by: Wolfram Sang --- drivers/watchdog/imx2_wdt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c index 1fe472f56cb3

[PATCH] i2c: algo-pca: update contact email

2020-05-02 Thread Wolfram Sang
The 'pengutronix' address is defunct for years. Use the proper contact address. Signed-off-by: Wolfram Sang --- drivers/i2c/algos/i2c-algo-pca.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/algos/i2c-algo-pca.c b/drivers/i2c/algos/i2c-algo-pca.c index

[PATCH] powerpc/5200: update contact email

2020-05-02 Thread Wolfram Sang
My 'pengutronix' address is defunct for years. Merge the entries and use the proper contact address. Signed-off-by: Wolfram Sang --- arch/powerpc/boot/dts/pcm032.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/powerpc/boot/dts/pcm032.dts b/arch/powerpc/boot/dts

[PATCH] input: lm8333: update contact email

2020-05-02 Thread Wolfram Sang
The 'pengutronix' address is defunct for years. Use the proper contact address. Signed-off-by: Wolfram Sang --- include/linux/input/lm8333.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/input/lm8333.h b/include/linux/input/lm8333.h index 79f918c6e8c5

[PATCH] ASoC: codecs: max9768: update contact email

2020-05-02 Thread Wolfram Sang
The 'pengutronix' address is defunct for years. Use the proper contact address. Signed-off-by: Wolfram Sang --- sound/soc/codecs/max9768.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/max9768.c b/sound/soc/codecs/max9768.c index d0737db5868a..39dda1b03b3d

[PATCH] i2c: use my kernel.org address from now on

2020-05-02 Thread Wolfram Sang
The old email is still active, but for easier handling, I am going to use my kernel.org address from now on. Also, add a mailmap for the now defunct Pengutronix address. Signed-off-by: Wolfram Sang --- .mailmap| 2 ++ MAINTAINERS | 2 +- drivers/i2c/i2c-core

[PATCH] staging: ks7010: remove me from CC list

2020-05-02 Thread Wolfram Sang
I lost interest in this driver years ago because I could't keep up with testing the incoming janitorial patches. So, drop me from CC. Signed-off-by: Wolfram Sang --- drivers/staging/ks7010/TODO | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ks7010/TODO b/drivers/staging

[PULL REQUEST] i2c for v5.7

2020-05-01 Thread Wolfram Sang
-30 16:12:33 +0200) Dan Carpenter (1): i2c: amd-mp2-pci: Fix Oops in amd_mp2_pci_init() error handling Rayagonda Kokatanur (1): i2c: iproc: generate stop event for slave writes Wolfram Sang (2): Revert "i2c:

Re: [PATCH] i2c: fix missing pm_runtime_put_sync in i2c_device_probe

2020-04-30 Thread Wolfram Sang
On Thu, Apr 30, 2020 at 05:43:21PM +0200, Alain Volmat wrote: > In case of the I2C client exposes the flag I2C_CLIENT_HOST_NOTIFY, > pm_runtime_get_sync is called in order to always keep active the > adapter. However later on, pm_runtime_put_sync is never called > within the function in case of an

Re: [PATCH] i2c: powermac: use true,false for bool variable

2020-04-30 Thread Wolfram Sang
On Sun, Apr 26, 2020 at 05:42:28PM +0800, Jason Yan wrote: > In i2c_powermac_register_devices(), variable 'found_onyx' is bool and > assigned '0' and 'true' in different places. Use 'false' instead of '0'. > This fixes the following coccicheck warning: > >

Re: [PATCH] i2c: powermac: use true,false for bool variable

2020-04-30 Thread Wolfram Sang
On Sun, Apr 26, 2020 at 05:42:28PM +0800, Jason Yan wrote: > In i2c_powermac_register_devices(), variable 'found_onyx' is bool and > assigned '0' and 'true' in different places. Use 'false' instead of '0'. > This fixes the following coccicheck warning: > >

Re: [PATCH v0 linux master] i2c/busses: Avoid i2c interrupt status clear race condition.

2020-04-30 Thread Wolfram Sang
On Wed, Apr 29, 2020 at 11:37:37AM +0800, ryan_chen wrote: > In AST2600 there have a slow peripheral bus between CPU > and i2c controller. > Therefore GIC i2c interrupt status clear have delay timing, > when CPU issue write clear i2c controller interrupt status. > To avoid this issue, the driver

Bug#947942: upstream has a patch for the gawk issue now

2020-04-29 Thread Wolfram Sang
Hi, I also hit the 'gawk' problem after upgrading to bullseye and my simple proposal: https://www.spinics.net/lists/util-linux-ng/msg16081.html was commited upstream: https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/commit/?id=76f969fe6ff149c7748894dcf881218f84873d67 Kind

Re: [PATCH v0 linux master] i2c/busses: Avoid i2c interrupt status clear race condition.

2020-04-29 Thread Wolfram Sang
> And is there maybe a Fixes: tag for it? > [Ryan Chen] Yes it is a fix patch. I meant this (from submitting-patches.rst): === If your patch fixes a bug in a specific commit, e.g. you found an issue using ``git bisect``, please use the 'Fixes:' tag with the first 12 characters of the SHA-1 ID,

Re: [PATCH v0 linux master] i2c/busses: Avoid i2c interrupt status clear race condition.

2020-04-29 Thread Wolfram Sang
On Wed, Apr 29, 2020 at 11:37:37AM +0800, ryan_chen wrote: > In AST2600 there have a slow peripheral bus between CPU > and i2c controller. > Therefore GIC i2c interrupt status clear have delay timing, > when CPU issue write clear i2c controller interrupt status. > To avoid this issue, the driver

Re: [PATCH RFT] i2c: brcmstb: properly check NACK condition

2020-04-28 Thread Wolfram Sang
On Sun, Apr 26, 2020 at 10:12:10AM +0200, Wolfram Sang wrote: > From: Wolfram Sang > > cppcheck rightfully complains about: > > drivers/i2c/busses/i2c-brcmstb.c:319:7: warning: Condition 'CMD_RD' is always > true [knownConditionTrueFalse] > drivers/i2c/busses/i2c-brcm

<    5   6   7   8   9   10   11   12   13   14   >