https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/93461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/93461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/90898
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/91172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/75170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/91320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/91316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/91316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -209,6 +221,9 @@ class DataflowAnalysisContext {
using DenseMapInfo::isEqual;
};
+ DataflowAnalysisContext(Solver &S, std::unique_ptr OwnedSolver,
ymand wrote:
Please add comments either here or on the fields relating S and OwnedSolver.
https://git
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/91316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/91455
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand commented:
I think we can do this without resorting to a pointer union and templating of
the initialization functions, but it will take a little refactoring.
First, notice that `stmt` doesn't make sense for the CallStack. The call stack
serves two purposes -- to avoid
ymand wrote:
> I agree with the usefulness of storing the initial target separately,
> reducing checks and branching based on whether the current target is a `Stmt`
> or `Function`. Since I was touching everywhere `CallStack` was used anyway, I
> went ahead with not pushing the starting `Funct
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/91616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -718,29 +730,46 @@ class Environment {
void pushCallInternal(const FunctionDecl *FuncDecl,
ArrayRef Args);
+ // FIXME: Add support for resetting globals after function calls to enable
+ // the implementation of sound analyses.
+
/// Assigns st
https://github.com/ymand approved this pull request.
Nice!
https://github.com/llvm/llvm-project/pull/91616
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -476,7 +476,7 @@ runTypeErasedDataflowAnalysis(
PrettyStackTraceAnalysis CrashInfo(ACFG, "runTypeErasedDataflowAnalysis");
std::optional MaybeStartingEnv;
- if (InitEnv.callStackSize() == 1) {
+ if (InitEnv.callStackSize() == 0) {
ymand wrote:
aside:
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/94217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/94332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/94963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/96731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/95901
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Yitzhak Mandelbaum
Date: 2022-09-09T17:13:52Z
New Revision: abc16c7a5b0a63d14172262153608b3d24de957f
URL:
https://github.com/llvm/llvm-project/commit/abc16c7a5b0a63d14172262153608b3d24de957f
DIFF:
https://github.com/llvm/llvm-project/commit/abc16c7a5b0a63d14172262153608b3d24de957f.diff
Author: Yitzhak Mandelbaum
Date: 2022-09-22T19:16:31Z
New Revision: 0b12efc7a42c187400f7df18d5fd629d92d2747e
URL:
https://github.com/llvm/llvm-project/commit/0b12efc7a42c187400f7df18d5fd629d92d2747e
DIFF:
https://github.com/llvm/llvm-project/commit/0b12efc7a42c187400f7df18d5fd629d92d2747e.diff
Author: Yitzhak Mandelbaum
Date: 2022-08-03T15:17:49Z
New Revision: 692e03039d1ee57c06c0cfae68b91bc5bfd99f6e
URL:
https://github.com/llvm/llvm-project/commit/692e03039d1ee57c06c0cfae68b91bc5bfd99f6e
DIFF:
https://github.com/llvm/llvm-project/commit/692e03039d1ee57c06c0cfae68b91bc5bfd99f6e.diff
Author: Yitzhak Mandelbaum
Date: 2022-10-14T17:41:53Z
New Revision: 39b9d4f188ca1f99515658334d57c2961db33289
URL:
https://github.com/llvm/llvm-project/commit/39b9d4f188ca1f99515658334d57c2961db33289
DIFF:
https://github.com/llvm/llvm-project/commit/39b9d4f188ca1f99515658334d57c2961db33289.diff
Author: Yitzhak Mandelbaum
Date: 2022-10-14T17:51:57Z
New Revision: 13cd184ef7fa9d76deaffb1924521fa914edba5e
URL:
https://github.com/llvm/llvm-project/commit/13cd184ef7fa9d76deaffb1924521fa914edba5e
DIFF:
https://github.com/llvm/llvm-project/commit/13cd184ef7fa9d76deaffb1924521fa914edba5e.diff
Author: Yitzhak Mandelbaum
Date: 2022-10-14T19:35:11Z
New Revision: 7da087974f9491855eea0087c657851a84c67b75
URL:
https://github.com/llvm/llvm-project/commit/7da087974f9491855eea0087c657851a84c67b75
DIFF:
https://github.com/llvm/llvm-project/commit/7da087974f9491855eea0087c657851a84c67b75.diff
Author: Yitzhak Mandelbaum
Date: 2022-10-19T12:23:09Z
New Revision: 8cadac41e9f63b2494805042573792cc2cc2a8ea
URL:
https://github.com/llvm/llvm-project/commit/8cadac41e9f63b2494805042573792cc2cc2a8ea
DIFF:
https://github.com/llvm/llvm-project/commit/8cadac41e9f63b2494805042573792cc2cc2a8ea.diff
Author: Yitzhak Mandelbaum
Date: 2022-11-03T23:31:20Z
New Revision: c0725865b188f71f904ecd4dac56ef37268b30d2
URL:
https://github.com/llvm/llvm-project/commit/c0725865b188f71f904ecd4dac56ef37268b30d2
DIFF:
https://github.com/llvm/llvm-project/commit/c0725865b188f71f904ecd4dac56ef37268b30d2.diff
Author: Thomas Etter
Date: 2022-11-15T14:24:05Z
New Revision: f3afd16b65ebda19e417120acf3c3793c171cf5e
URL:
https://github.com/llvm/llvm-project/commit/f3afd16b65ebda19e417120acf3c3793c171cf5e
DIFF:
https://github.com/llvm/llvm-project/commit/f3afd16b65ebda19e417120acf3c3793c171cf5e.diff
LOG:
Author: Thomas Etter
Date: 2022-11-15T14:28:03Z
New Revision: a49fcca9e3ec9e310312416599405d26c189a81b
URL:
https://github.com/llvm/llvm-project/commit/a49fcca9e3ec9e310312416599405d26c189a81b
DIFF:
https://github.com/llvm/llvm-project/commit/a49fcca9e3ec9e310312416599405d26c189a81b.diff
LOG:
Author: Yitzhak Mandelbaum
Date: 2022-09-30T14:27:02Z
New Revision: 9a4e52ebeb6dd8527bc1ee944a9466d68a95b6f1
URL:
https://github.com/llvm/llvm-project/commit/9a4e52ebeb6dd8527bc1ee944a9466d68a95b6f1
DIFF:
https://github.com/llvm/llvm-project/commit/9a4e52ebeb6dd8527bc1ee944a9466d68a95b6f1.diff
Author: Yitzhak Mandelbaum
Date: 2022-09-30T14:53:18Z
New Revision: 40f5c634bc991510427e274ba49d4c56f29ef593
URL:
https://github.com/llvm/llvm-project/commit/40f5c634bc991510427e274ba49d4c56f29ef593
DIFF:
https://github.com/llvm/llvm-project/commit/40f5c634bc991510427e274ba49d4c56f29ef593.diff
Author: Yitzhak Mandelbaum
Date: 2022-12-19T15:28:30Z
New Revision: a18cf8d14f5552c13bd1cef112ba5b88a7fc75ff
URL:
https://github.com/llvm/llvm-project/commit/a18cf8d14f5552c13bd1cef112ba5b88a7fc75ff
DIFF:
https://github.com/llvm/llvm-project/commit/a18cf8d14f5552c13bd1cef112ba5b88a7fc75ff.diff
Author: Yitzhak Mandelbaum
Date: 2022-12-19T21:01:27Z
New Revision: d2e4aaf6ac3bc7c72a81f050512afa17a9ceb54b
URL:
https://github.com/llvm/llvm-project/commit/d2e4aaf6ac3bc7c72a81f050512afa17a9ceb54b
DIFF:
https://github.com/llvm/llvm-project/commit/d2e4aaf6ac3bc7c72a81f050512afa17a9ceb54b.diff
Author: Yitzhak Mandelbaum
Date: 2022-12-22T14:19:49Z
New Revision: 0e8d4a6df9598cf0d654c24bbd3901bfb77d91bb
URL:
https://github.com/llvm/llvm-project/commit/0e8d4a6df9598cf0d654c24bbd3901bfb77d91bb
DIFF:
https://github.com/llvm/llvm-project/commit/0e8d4a6df9598cf0d654c24bbd3901bfb77d91bb.diff
Author: Yitzhak Mandelbaum
Date: 2022-12-22T14:20:50Z
New Revision: f3700bdb7f00d4f2652a7bdc6a99130e8a1b3c59
URL:
https://github.com/llvm/llvm-project/commit/f3700bdb7f00d4f2652a7bdc6a99130e8a1b3c59
DIFF:
https://github.com/llvm/llvm-project/commit/f3700bdb7f00d4f2652a7bdc6a99130e8a1b3c59.diff
Author: Yitzhak Mandelbaum
Date: 2022-12-22T14:42:17Z
New Revision: 38404df9d879483784a7024b2b4a366388d6d476
URL:
https://github.com/llvm/llvm-project/commit/38404df9d879483784a7024b2b4a366388d6d476
DIFF:
https://github.com/llvm/llvm-project/commit/38404df9d879483784a7024b2b4a366388d6d476.diff
Author: Yitzhak Mandelbaum
Date: 2023-01-03T21:57:39Z
New Revision: 0086a3555ac6cd76bb637252a0ba17c06c9b869b
URL:
https://github.com/llvm/llvm-project/commit/0086a3555ac6cd76bb637252a0ba17c06c9b869b
DIFF:
https://github.com/llvm/llvm-project/commit/0086a3555ac6cd76bb637252a0ba17c06c9b869b.diff
Author: Yitzhak Mandelbaum
Date: 2023-01-05T21:46:39Z
New Revision: 5e8f597c2fedc740b71f07dfdb1ef3c2d348b193
URL:
https://github.com/llvm/llvm-project/commit/5e8f597c2fedc740b71f07dfdb1ef3c2d348b193
DIFF:
https://github.com/llvm/llvm-project/commit/5e8f597c2fedc740b71f07dfdb1ef3c2d348b193.diff
Author: Yitzhak Mandelbaum
Date: 2023-01-06T01:07:28Z
New Revision: 2b1a517a92bfdfa3b692a660e19a2bb22513a567
URL:
https://github.com/llvm/llvm-project/commit/2b1a517a92bfdfa3b692a660e19a2bb22513a567
DIFF:
https://github.com/llvm/llvm-project/commit/2b1a517a92bfdfa3b692a660e19a2bb22513a567.diff
Author: Yitzhak Mandelbaum
Date: 2023-01-09T19:32:10Z
New Revision: 01ccf7b3cee58dbe02fd97696cae1781746b6137
URL:
https://github.com/llvm/llvm-project/commit/01ccf7b3cee58dbe02fd97696cae1781746b6137
DIFF:
https://github.com/llvm/llvm-project/commit/01ccf7b3cee58dbe02fd97696cae1781746b6137.diff
Author: Yitzhak Mandelbaum
Date: 2023-01-10T14:17:25Z
New Revision: 264976d98e785fa061ce6ac06db4a9bda2590506
URL:
https://github.com/llvm/llvm-project/commit/264976d98e785fa061ce6ac06db4a9bda2590506
DIFF:
https://github.com/llvm/llvm-project/commit/264976d98e785fa061ce6ac06db4a9bda2590506.diff
Author: Yitzhak Mandelbaum
Date: 2023-01-10T14:28:45Z
New Revision: 089a54469f63c2f3c4b9d79fb9694f21bef0d071
URL:
https://github.com/llvm/llvm-project/commit/089a54469f63c2f3c4b9d79fb9694f21bef0d071
DIFF:
https://github.com/llvm/llvm-project/commit/089a54469f63c2f3c4b9d79fb9694f21bef0d071.diff
Author: Yitzhak Mandelbaum
Date: 2023-01-10T15:48:00Z
New Revision: 3ce03c42dbb46531968c527d80c0243c2db7bc0e
URL:
https://github.com/llvm/llvm-project/commit/3ce03c42dbb46531968c527d80c0243c2db7bc0e
DIFF:
https://github.com/llvm/llvm-project/commit/3ce03c42dbb46531968c527d80c0243c2db7bc0e.diff
Author: Yitzhak Mandelbaum
Date: 2022-12-07T16:24:49Z
New Revision: 390029be8946cac807e8fc978b9cf3790e7456cc
URL:
https://github.com/llvm/llvm-project/commit/390029be8946cac807e8fc978b9cf3790e7456cc
DIFF:
https://github.com/llvm/llvm-project/commit/390029be8946cac807e8fc978b9cf3790e7456cc.diff
Author: Yitzhak Mandelbaum
Date: 2022-12-09T18:58:00Z
New Revision: ef4635452f3a23ee29f7586148e19e8c84471a59
URL:
https://github.com/llvm/llvm-project/commit/ef4635452f3a23ee29f7586148e19e8c84471a59
DIFF:
https://github.com/llvm/llvm-project/commit/ef4635452f3a23ee29f7586148e19e8c84471a59.diff
Author: Yitzhak Mandelbaum
Date: 2022-12-15T15:39:52Z
New Revision: 5d22d1f54836263ead1971ef8128f5128290dfa7
URL:
https://github.com/llvm/llvm-project/commit/5d22d1f54836263ead1971ef8128f5128290dfa7
DIFF:
https://github.com/llvm/llvm-project/commit/5d22d1f54836263ead1971ef8128f5128290dfa7.diff
Author: Yitzhak Mandelbaum
Date: 2022-12-15T15:43:21Z
New Revision: 98550df7b7bbce0e38a1ec558287d759163c64ba
URL:
https://github.com/llvm/llvm-project/commit/98550df7b7bbce0e38a1ec558287d759163c64ba
DIFF:
https://github.com/llvm/llvm-project/commit/98550df7b7bbce0e38a1ec558287d759163c64ba.diff
Author: v1nh1shungry
Date: 2022-11-17T22:47:15Z
New Revision: 8003c1d61e69142cb6e87df719c17f3c4ad86c98
URL:
https://github.com/llvm/llvm-project/commit/8003c1d61e69142cb6e87df719c17f3c4ad86c98
DIFF:
https://github.com/llvm/llvm-project/commit/8003c1d61e69142cb6e87df719c17f3c4ad86c98.diff
LOG:
Author: Yitzhak Mandelbaum
Date: 2022-11-22T16:09:28Z
New Revision: 84dd12b29064095cdef3949e8fd5c91b93f36004
URL:
https://github.com/llvm/llvm-project/commit/84dd12b29064095cdef3949e8fd5c91b93f36004
DIFF:
https://github.com/llvm/llvm-project/commit/84dd12b29064095cdef3949e8fd5c91b93f36004.diff
https://github.com/ymand review_requested
https://github.com/llvm/llvm-project/pull/65949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/65949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/65949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const
Formula &Val1,
}
void DataflowAnalysisContext::addTransitiveFlowConditionConstraints(
-Atom Token, llvm::SetVector &Constraints,
-llvm::DenseSet &VisitedTokens) {
- auto Res = VisitedTokens.
@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const
Formula &Val1,
}
void DataflowAnalysisContext::addTransitiveFlowConditionConstraints(
-Atom Token, llvm::SetVector &Constraints,
-llvm::DenseSet &VisitedTokens) {
- auto Res = VisitedTokens.
https://github.com/ymand created
https://github.com/llvm/llvm-project/pull/66014:
The template is agnostic as to the type used by the list, as long as it is
compatible with `llvm::move` and `std::back_inserter`. In practice, we've
encountered analyses which use different types (`llvm::SmallVect
https://github.com/ymand review_requested
https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand review_requested
https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand review_requested
https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand review_requested
https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand review_requested
https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand review_requested
https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand review_requested
https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -245,10 +245,10 @@ runDataflowAnalysis(
/// iterations.
/// - This limit is still low enough to keep runtimes acceptable (on typical
/// machines) in cases where we hit the limit.
-template
-llvm::Expected> diagnoseFunction(
+template
+llvm::Expected diagnoseFunction(
ymand wrote:
> I think `llvm::SmallVector` makes sense for both callsites that currently
> exist (and ones that we might add in the future). This patch currently lets
> `UncheckedOptionalAccessCheck::check()` continue to use `std::vector`, but I
> think `llvm::SmallVector` makes sense there as
https://github.com/ymand updated
https://github.com/llvm/llvm-project/pull/66014:
>From 6eda5a1fc6200027d6ae99dc5eff69aa88962c81 Mon Sep 17 00:00:00 2001
From: Yitzhak Mandelbaum
Date: Mon, 11 Sep 2023 21:34:00 +
Subject: [PATCH 1/2] [clang][dataflow] Change `diagnoseFunction` to take type
ymand wrote:
Updated to enforce `llvm::SmallVector`, per Martin's recommendation. PTAL.
https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -245,10 +245,10 @@ runDataflowAnalysis(
/// iterations.
/// - This limit is still low enough to keep runtimes acceptable (on typical
/// machines) in cases where we hit the limit.
-template
-llvm::Expected> diagnoseFunction(
+template
+llvm::Expected diagnoseFunction(
https://github.com/ymand resolved
https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/66014
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -108,6 +108,16 @@ class DataflowAnalysisContext {
/// A null `PointeeType` can be used for the pointee of `std::nullptr_t`.
PointerValue &getOrCreateNullPointerValue(QualType PointeeType);
+ /// Adds `Constraint` to current and future flow conditions in this context.
+
https://github.com/ymand resolved
https://github.com/llvm/llvm-project/pull/65949
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -172,27 +179,33 @@ bool DataflowAnalysisContext::equivalentFormulas(const
Formula &Val1,
}
void DataflowAnalysisContext::addTransitiveFlowConditionConstraints(
-Atom Token, llvm::SetVector &Constraints,
-llvm::DenseSet &VisitedTokens) {
- auto Res = VisitedTokens.
https://github.com/ymand updated
https://github.com/llvm/llvm-project/pull/66014:
>From 335f12e897d8d776dc476b468bc0dc1e7b8019df Mon Sep 17 00:00:00 2001
From: Yitzhak Mandelbaum
Date: Mon, 11 Sep 2023 21:34:00 +
Subject: [PATCH 1/2] [clang][dataflow] Change `diagnoseFunction` to take type
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/66480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -91,6 +91,10 @@ StringRef getExtendedText(const T &Node, tok::TokenKind Next,
llvm::Error validateEditRange(const CharSourceRange &Range,
const SourceManager &SM);
+/// Determines whether \p Range is one that can be read from.
+llvm::Error vali
@@ -230,7 +230,7 @@ class SelectorStencil : public StencilInterface {
// message. If it's valid, then something else is the cause and we just
// return the generic failure message.
if (auto Err =
- tooling::validateEditRange(*RawRange, *Match.Sour
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -87,6 +87,9 @@ class alignas(const Formula *) Formula {
ArrayRef Operands,
unsigned Value = 0);
+ // Parse Formulas using Arena rather than caling this function directly.
ymand wrote:
nit: Maybe prefix wit
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/66424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/66480
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand approved this pull request.
https://github.com/llvm/llvm-project/pull/66764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Yitzhak Mandelbaum
Date: 2023-07-18T21:43:55Z
New Revision: 1defa781243f9d0bc66719465e4de33e9fb7a243
URL:
https://github.com/llvm/llvm-project/commit/1defa781243f9d0bc66719465e4de33e9fb7a243
DIFF:
https://github.com/llvm/llvm-project/commit/1defa781243f9d0bc66719465e4de33e9fb7a243.diff
Author: Yitzhak Mandelbaum
Date: 2023-07-26T17:12:29Z
New Revision: 1429240ed63b05991e175e623b3fa5b72e59dc5b
URL:
https://github.com/llvm/llvm-project/commit/1429240ed63b05991e175e623b3fa5b72e59dc5b
DIFF:
https://github.com/llvm/llvm-project/commit/1429240ed63b05991e175e623b3fa5b72e59dc5b.diff
Author: Yitzhak Mandelbaum
Date: 2023-07-26T17:12:29Z
New Revision: e9570d1e59ba381ea55327b5cbed0b5bc05677fe
URL:
https://github.com/llvm/llvm-project/commit/e9570d1e59ba381ea55327b5cbed0b5bc05677fe
DIFF:
https://github.com/llvm/llvm-project/commit/e9570d1e59ba381ea55327b5cbed0b5bc05677fe.diff
This broke one of the builds.
https://lab.llvm.org/buildbot/#/builders/121/builds/32939/steps/4/logs/stdio.
Working on a fix now.
On Wed, Jul 26, 2023 at 1:12 PM Yitzhak Mandelbaum via Phabricator <
revi...@reviews.llvm.org> wrote:
> This revision was landed with ongoing or failed builds.
> This
Author: Yitzhak Mandelbaum
Date: 2023-07-26T17:37:05Z
New Revision: 75abfa2474da663f22e33e63d34bb843ef01d12b
URL:
https://github.com/llvm/llvm-project/commit/75abfa2474da663f22e33e63d34bb843ef01d12b
DIFF:
https://github.com/llvm/llvm-project/commit/75abfa2474da663f22e33e63d34bb843ef01d12b.diff
Author: Yitzhak Mandelbaum
Date: 2023-07-27T18:40:59Z
New Revision: 26db5e651bb65287b57a9ca84388d61d8b3305c9
URL:
https://github.com/llvm/llvm-project/commit/26db5e651bb65287b57a9ca84388d61d8b3305c9
DIFF:
https://github.com/llvm/llvm-project/commit/26db5e651bb65287b57a9ca84388d61d8b3305c9.diff
Author: Yitzhak Mandelbaum
Date: 2023-06-27T17:07:54Z
New Revision: f4cf51c99c74f46a490e0ae265da8fba298d800b
URL:
https://github.com/llvm/llvm-project/commit/f4cf51c99c74f46a490e0ae265da8fba298d800b
DIFF:
https://github.com/llvm/llvm-project/commit/f4cf51c99c74f46a490e0ae265da8fba298d800b.diff
@@ -5987,4 +6018,204 @@ TEST(TransferTest, EvaluateBlockWithUnreachablePreds) {
ASTContext &ASTCtx) {});
}
+TEST(TransferTest, LambdaCaptureByCopy) {
+ std::string Code = R"(
+void target(int Foo, int Bar) {
+ [Foo]() {
+(void)0;
+// [[p]]
+
https://github.com/ymand requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/68558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/68558
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3214,6 +3220,117 @@ TEST_P(UncheckedOptionalAccessTest, Bitfield) {
}
)");
}
+
+TEST_P(UncheckedOptionalAccessTest, Lambda) {
ymand wrote:
Please split these into individual tests.
https://github.com/llvm/llvm-project/pull/68558
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/68510
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -180,3 +180,44 @@ void std_forward_rvalue_ref_safe(absl::optional&&
opt) {
std::forward>(opt).value();
}
+
+namespace std {
+
+template
+class optional {
+public:
+ template
+ optional& operator=(const U &u){
+ data = u;
+ }
+private:
+ T dat
@@ -180,3 +180,44 @@ void std_forward_rvalue_ref_safe(absl::optional&&
opt) {
std::forward>(opt).value();
}
+
+namespace std {
+
+template
+class optional {
+public:
+ template
+ optional& operator=(const U &u){
+ data = u;
+ }
+private:
+ T dat
@@ -180,3 +180,44 @@ void std_forward_rvalue_ref_safe(absl::optional&&
opt) {
std::forward>(opt).value();
}
+
+namespace std {
+
+template
+class optional {
+public:
+ template
+ optional& operator=(const U &u){
ymand wrote:
The issue isn't specifi
401 - 500 of 604 matches
Mail list logo
