[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

@@ -173,21 +173,21 @@ TryCreateAutoSummaryForContainer(lldb::SBValue ) { lldb::SBValue child = v.GetChildAtIndex(i); if (llvm::StringRef name = child.GetName(); !name.empty()) { - llvm::StringRef value; + llvm::StringRef desc; if (llvm::StringRef

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

@@ -405,6 +405,9 @@ struct VariableDescription { /// Create a JSON object that represents these extensions to the DAP variable /// response. llvm::json::Object GetVariableExtensionsJSON(); + + /// Returns a description of the value appropraite for the specified context.

Logging in Kafka

If Kafka 4.0 is Java 11+, why would you use SLF4J instead of the Java 9+ logging facade System.Logger?

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #77671)

clayborg wrote: > > Looks good, need to add tests for: > > > > * split dwarf with .dwo files > > * split dwarf with .dwp file > > @clayborg, do you have suggestion regarding how to test `GetDebugInfoSize()` > for dwo/dwp? yes, for either we just add up the size of any debug info sections for

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -35,25 +42,29 @@ Progress::~Progress() { ReportProgress(); } -void Progress::Increment(uint64_t amount, std::string update) { +void Progress::Increment(uint64_t amount, + std::optional updated_detail) { if (amount > 0) { std::lock_guard

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -35,25 +42,29 @@ Progress::~Progress() { ReportProgress(); } -void Progress::Increment(uint64_t amount, std::string update) { +void Progress::Increment(uint64_t amount, + std::optional updated_detail) { if (amount > 0) { std::lock_guard

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -96,13 +97,14 @@ class Progress { static std::atomic g_id; /// The title of the progress activity. std::string m_title; + std::string m_details; std::mutex m_mutex; /// A unique integer identifier for progress reporting. const uint64_t m_id; /// How much

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -11,15 +11,19 @@ #include "lldb/Core/Debugger.h" #include "lldb/Utility/StreamString.h" +#include + using namespace lldb; using namespace lldb_private; std::atomic Progress::g_id(0); -Progress::Progress(std::string title, uint64_t total,

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -30,18 +34,19 @@ Progress::~Progress() { // Make sure to always report progress completed when this object is // destructed so it indicates the progress dialog/activity should go away. std::lock_guard guard(m_mutex); - if (!m_completed) -m_completed = m_total; +

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -51,9 +56,10 @@ void Progress::Increment(uint64_t amount, std::string update) { void Progress::ReportProgress(std::string update) { if (!m_complete) { // Make sure we only send one notification that indicates the progress is -// complete. -m_complete =

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -30,18 +34,19 @@ Progress::~Progress() { // Make sure to always report progress completed when this object is // destructed so it indicates the progress dialog/activity should go away. std::lock_guard guard(m_mutex); - if (!m_completed) -m_completed = m_total; +

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -30,18 +34,19 @@ Progress::~Progress() { // Make sure to always report progress completed when this object is // destructed so it indicates the progress dialog/activity should go away. std::lock_guard guard(m_mutex); - if (!m_completed) -m_completed = m_total; +

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -51,9 +56,10 @@ void Progress::Increment(uint64_t amount, std::string update) { void Progress::ReportProgress(std::string update) { clayborg wrote: remove `std::string update` as we have it in `m_details` https://github.com/llvm/llvm-project/pull/77547

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

https://github.com/clayborg commented: A bit more cleanup, see inline comment https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

clayborg wrote: > > Is there a way we can tell that the request is from the console and only > > enable this feature if we are going to dump it to the debug console? > > Yea, the DAP has a context we can use to limit this >

[Lldb-commits] [lldb] Fix debug info size statistics for split dwarf (PR #77671)

https://github.com/clayborg commented: Looks good, need to add tests for: - split dwarf with .dwo files - split dwarf with .dwp file https://github.com/llvm/llvm-project/pull/77671 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

clayborg wrote: Is there a way we can tell that the request is from the console and only enable this feature if we are going to dump it to the debug console? https://github.com/llvm/llvm-project/pull/77026 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

clayborg wrote: > > Looks fine to me. Can we add a test? > > Updated the existing tests to check the adjusted format. > > One issue I did notice with tests is that the response to an expression will > include a response are automatically persisted by > `SBValue::GetDescription()`, so you

[Lldb-commits] [lldb] Add settings and code that limits the number of progress events. (PR #75769)

@@ -1430,6 +1445,279 @@ void Debugger::SetDestroyCallback( m_destroy_callback_baton = baton; } + + /// Notify the progress thread that there is new progress data. +void Debugger::NotifyProgress(std::unique_ptr _up) { + // Start the progress thread if it isn't already

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -69,7 +69,8 @@ class Progress { /// /// @param [in] debugger An optional debugger pointer to specify that this /// progress is to be reported only to specific debuggers. - Progress(std::string title, uint64_t total = UINT64_MAX, + Progress(std::string title,

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -519,8 +519,7 @@ void SymbolFileDWARF::InitializeObject() { if (apple_names.GetByteSize() > 0 || apple_namespaces.GetByteSize() > 0 || apple_types.GetByteSize() > 0 || apple_objc.GetByteSize() > 0) { - Progress progress(llvm::formatv("Loading Apple DWARF

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

@@ -532,8 +531,7 @@ void SymbolFileDWARF::InitializeObject() { DWARFDataExtractor debug_names; LoadSectionData(eSectionTypeDWARFDebugNames, debug_names); if (debug_names.GetByteSize() > 0) { - Progress progress( - llvm::formatv("Loading DWARF5 index

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

https://github.com/clayborg approved this pull request. The roots of this look really good. A few nits we can choose to fix or do in another patch. https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb][Progress] Separate title and details (PR #77547)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/77547 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

@@ -68,6 +68,11 @@ class DWARFDeclContext { const char *GetQualifiedName() const; + /// Returns a vector of string, one string per entry in the fully qualified + /// name. For example, for the DeclContext `A::B::C`, this methods returns + /// `{"C", "B", "A"}` +

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

@@ -68,6 +68,11 @@ class DWARFDeclContext { const char *GetQualifiedName() const; + /// Returns a vector of string, one string per entry in the fully qualified + /// name. For example, for the DeclContext `A::B::C`, this methods returns + /// `{"C", "B", "A"}` +

[Lldb-commits] [lldb] [lldb][[DWARFDeclContext] Add function to extract qualified names as vector (PR #77349)

@@ -68,6 +68,11 @@ class DWARFDeclContext { const char *GetQualifiedName() const; + /// Returns a vector of string, one string per entry in the fully qualified + /// name. For example, for the DeclContext `A::B::C`, this methods returns + /// `{"C", "B", "A"}` +

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

clayborg wrote: > Thanks for the fix! I did test this patch with both our regression issue, and > also allowing us to remove the double-lookup working around #53904 and can > confirm it addressed both issues. Thanks again! Glad it worked! It will also be a huge improvement in the expression

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/77029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARFIndex][nfc] Factor out fully qualified name query (PR #76977)

@@ -102,6 +110,12 @@ class DWARFIndex { } void ReportInvalidDIERef(DIERef ref, llvm::StringRef name) const; + + /// Implementation of `GetFullyQualifiedType` to check a single entry, + /// shareable with derived classes. clayborg wrote: > I'm glad you

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

https://github.com/clayborg updated https://github.com/llvm/llvm-project/pull/77029 >From ceb740dcce0ac870b1ef145d41670385a1d24f1c Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Thu, 4 Jan 2024 16:17:44 -0800 Subject: [PATCH 1/3] Fix expressions that involve nested structs/classes/uni

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

@@ -3106,10 +3115,39 @@ void DWARFASTParserClang::ParseSingleMember( std::make_pair(field_decl, field_bit_offset)); } +static bool IsTypeTag(dw_tag_t tag) { + switch (tag) { +case DW_TAG_typedef: +case DW_TAG_base_type: +case DW_TAG_pointer_type: +case

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

@@ -2260,7 +2269,7 @@ bool DWARFASTParserClang::CompleteTypeFromDWARF(const DWARFDIE , // Disable external storage for this type so we don't get anymore // clang::ExternalASTSource queries for this type. - m_ast.SetHasExternalStorage(clang_type.GetOpaqueQualType(),

[Lldb-commits] [lldb] [lldb-dap] Updating VariableDescription to use GetDescription() as a fallback. (PR #77026)

https://github.com/clayborg commented: Looks fine to me. Can we add a test? https://github.com/llvm/llvm-project/pull/77026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/77029 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

clayborg wrote: This patch was in response to this issue: https://github.com/llvm/llvm-project/pull/74786#issuecomment-1874921872 And is related to https://github.com/llvm/llvm-project/pull/66879, but does things a bit differently. https://github.com/llvm/llvm-project/pull/77029

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

clayborg wrote: https://github.com/llvm/llvm-project/pull/77029 is a slightly modified version of this patch where it parses the types after the struct/union/class is created. https://github.com/llvm/llvm-project/pull/66879 ___ lldb-commits mailing

[Lldb-commits] [lldb] Fix expressions that involve nested structs/classes/unions. (PR #77029)

parsed a type into the containing decl context and the expression might succeed if it is run again. >From ceb740dcce0ac870b1ef145d41670385a1d24f1c Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Thu, 4 Jan 2024 16:17:44 -0800 Subject: [PATCH] Fix expressions that involve nested stru

[Lldb-commits] [lldb] [lldb][DWARFIndex][nfc] Factor out fully qualified name query (PR #76977)

clayborg wrote: LGTM https://github.com/llvm/llvm-project/pull/76977 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [LU] Fwd: VPN

Just to make everyone feel really old, ISDN is being phased out... Mind you, Openreach think they'll have an IP network by the end of 2025, so I wouldn't be so sure. Andy C On Thu, 4 Jan 2024 at 15:43, John Boocock wrote: > We got 500whatsits of Fibre

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

clayborg wrote: > ``` > == > ERROR: test_resolver_serialization > (TestBreakpointSerialization.BreakpointSerialization) >Test that breakpoint resolvers contain the expected information >

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

clayborg wrote: So while you were able to work around issues with the expression parser with #68705, I do believe a modified version of this patch is needed. https://github.com/llvm/llvm-project/pull/66879 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Resolve nested types when parsing structures (PR #66879)

clayborg wrote: I recently ran into this issue when looking at new failures in: https://github.com/llvm/llvm-project/pull/74786#issuecomment-1874921872 And this was referred to in bug report: https://github.com/llvm/llvm-project/issues/53904 After looking at the code, I believe we do need to

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

https://github.com/clayborg approved this pull request. Looks good! https://github.com/llvm/llvm-project/pull/76766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

@@ -49,6 +49,37 @@ def test_scripted_extra_args(self): self.setup_targets_and_cleanup() self.do_check_extra_args() +def test_resolver_serialization(self): +"""Test that breakpoint resolvers contain the expected information""" +self.build()

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

@@ -49,6 +49,37 @@ def test_scripted_extra_args(self): self.setup_targets_and_cleanup() self.do_check_extra_args() +def test_resolver_serialization(self): +"""Test that breakpoint resolvers contain the expected information""" +self.build()

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

@@ -49,6 +49,37 @@ def test_scripted_extra_args(self): self.setup_targets_and_cleanup() self.do_check_extra_args() +def test_resolver_serialization(self): +"""Test that breakpoint resolvers contain the expected information""" +self.build()

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

@@ -49,6 +49,37 @@ def test_scripted_extra_args(self): self.setup_targets_and_cleanup() self.do_check_extra_args() +def test_resolver_serialization(self): +"""Test that breakpoint resolvers contain the expected information""" +self.build()

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

@@ -49,6 +49,37 @@ def test_scripted_extra_args(self): self.setup_targets_and_cleanup() self.do_check_extra_args() +def test_resolver_serialization(self): +"""Test that breakpoint resolvers contain the expected information""" +self.build()

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

https://github.com/clayborg approved this pull request. One quick fix suggested, but looks good. https://github.com/llvm/llvm-project/pull/76766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

@@ -49,6 +49,37 @@ def test_scripted_extra_args(self): self.setup_targets_and_cleanup() self.do_check_extra_args() +def test_resolver_serialization(self): +"""Test that breakpoint resolvers contain the expected information""" +self.build()

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/76766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[exim-dev] no member named 'dane_verified' in 'tls_support'

This fix (to allow compilation from source under FreeBSD for systems without DANE) has not made it into Exim 4.97.1 <https://git.exim.org/exim.git/commitdiff/37b849dca4dfd855212a763662825e 967a4d77b1> :-( -- richard Richard Clayton Tho

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

clayborg wrote: So I traced down why things used to work and why they don't work now. The issue is we are being too accurate with our type lookups now. For my reduced example I had this code: ``` struct A { struct B { static int f; }; }; ``` What would happen when you type "p A::B::f"

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

clayborg wrote: > > Can this be tested? > > I took a look at existing tests, but I'm not sure how to best test this. I > think we would need to create a breakpoint in a module by address and make > sure the resolver correctly serializes the name (in `statistics dump` or > otherwise). Does

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

clayborg wrote: I am also not saying this patch hasn't made this issue happen more often, so I will check out my APIs to see how they are being called from the expression parser. https://github.com/llvm/llvm-project/pull/74786 ___ lldb-commits

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

clayborg wrote: > absl::cord_internal::RefcountAndFlags::Flags::kNumFlags I have a small repro case from the code pointer you gave. I will look into this and report back what I find. Are you guys using the expression parser in your pretty printer? As Michael pointed out, you can get the

[Lldb-commits] [lldb] [lldb] Fix breakpoint resolver serialization bug (PR #76766)

https://github.com/clayborg commented: Can this be tested? https://github.com/llvm/llvm-project/pull/76766 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [mailop] DKIM validity period (anti-forgery vs. anti-spying)

have a lot more experience than I do. I'm just old :) https://letmegooglethat.com/?q=richard+clayton+phd+thesis+traceability -- richard Richard Clayton Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Lib

Re: [mailop] DKIM validity period (anti-forgery vs. anti-spying)

o remember that there is account takeover, people in your household who know your passwords better than you do and that's before you get into all the BGP, NTP etc exotica (if that interests you then I once wrote a PhD thesis on all the assumptions we make about "traceability" and the cir

[Lldb-commits] [lldb] [lldb] In-progress — All ValueObjectSP instances are now valid (non-null) but have an error state (PR #74912)

clayborg wrote: > > ### Goal > > Every `ValueObjectSP` will have an actual value and will never be equal to > > `nullptr`. > > I would like to learn more about the goal. It seems like the existing code > will result in widespread use of `optional>`. Is the > plan to reduce these cases to a

[Lldb-commits] [lldb] [lldb][Type] Add TypeQuery::SetLanguages API (PR #75926)

https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/75926 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Search for symbols in all external modules (PR #75927)

@@ -175,7 +175,7 @@ TypeSP DWARFASTParserClang::ParseTypeFromClangModule(const SymbolContext , *sc.comp_unit, results.GetSearchedSymbolFiles(), [&](Module ) { module.FindTypes(query, results); pcm_type_sp = results.GetTypeMap().FirstType(); -

[Lldb-commits] [lldb] [lldb][DWARF] Search for symbols in all external modules (PR #75927)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/75927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF] Search for symbols in all external modules (PR #75927)

https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/75927 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [DRAFT] Add support for inline DWARF source files. (PR #75880)

@@ -235,6 +236,51 @@ ParseSupportFilesFromPrologue(const lldb::ModuleSP , for (size_t idx = first_file_idx; idx <= last_file_idx; ++idx) { std::string remapped_file; if (auto file_path = GetFileByIndex(prologue, idx, compile_dir, style)) { + auto entry =

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/75865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/75865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

@@ -2727,39 +2730,48 @@ ValueObjectSP ValueObject::AddressOf(Status ) { const bool scalar_is_load_address = false; addr_t addr = GetAddressOf(scalar_is_load_address, _type); error.Clear(); - if (addr != LLDB_INVALID_ADDRESS && address_type != eAddressTypeHost) { -

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

@@ -1623,62 +1623,68 @@ bool ValueObject::IsUninitializedReference() { ValueObjectSP ValueObject::GetSyntheticArrayMember(size_t index, bool can_create) { - ValueObjectSP synthetic_child_sp; - if (IsPointerType() ||

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

https://github.com/clayborg requested changes to this pull request. simple formatting changes and this is good to go https://github.com/llvm/llvm-project/pull/75865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

@@ -1623,62 +1623,68 @@ bool ValueObject::IsUninitializedReference() { ValueObjectSP ValueObject::GetSyntheticArrayMember(size_t index, bool can_create) { - ValueObjectSP synthetic_child_sp; - if (IsPointerType() ||

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

@@ -1992,71 +1999,67 @@ void ValueObject::GetExpressionPath(Stream , } ValueObjectSP ValueObject::GetValueForExpressionPath( -llvm::StringRef expression, ExpressionPathScanEndReason *reason_to_stop, -ExpressionPathEndResultType *final_value_type, +llvm::StringRef

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

@@ -1623,62 +1623,68 @@ bool ValueObject::IsUninitializedReference() { ValueObjectSP ValueObject::GetSyntheticArrayMember(size_t index, bool can_create) { - ValueObjectSP synthetic_child_sp; - if (IsPointerType() ||

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/75865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve maintainability and readability for ValueObject methods (PR #75865)

@@ -1623,62 +1623,68 @@ bool ValueObject::IsUninitializedReference() { ValueObjectSP ValueObject::GetSyntheticArrayMember(size_t index, bool can_create) { - ValueObjectSP synthetic_child_sp; - if (IsPointerType() ||

[Lldb-commits] [lldb] Remove unused FileSPec::IsResolved() functionality. (PR #75840)

https://github.com/clayborg approved this pull request. https://github.com/llvm/llvm-project/pull/75840 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][PDB] Update max matches test for type queries (PR #75813)

https://github.com/clayborg approved this pull request. Thanks for fixing properly! https://github.com/llvm/llvm-project/pull/75813 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add settings and code that limits the number of progress events. (PR #75769)

17 00:00:00 2001 From: Greg Clayton Date: Sun, 17 Dec 2023 22:52:45 -0800 Subject: [PATCH] Add settings and code that limits the number of progress events. Currently in LLDB if clients listen for Debugger::eBroadcastBitProgress events, this can cause too many progress events to get sent to clie

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

clayborg wrote: @DavidSpickett I created a new PR to fix the buildbots: https://github.com/llvm/llvm-project/pull/75566 This disables the TestUniqueTypes4.py on windows, and fixes the test in `lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp` to test what it was testing before.

[Lldb-commits] [lldb] Trying to fix windows buildbots after #74786 (PR #75566)

debug or fix why it isn't working. >From 2ff3c15494590e527305e2b8cabf747c0b1eb599 Mon Sep 17 00:00:00 2001 From: Greg Clayton Date: Thu, 14 Dec 2023 23:12:04 -0800 Subject: [PATCH] Trying to fix windows buildbots after https://github.com/llvm/llvm-project/pull/74786 This patch fi

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

clayborg wrote: So regarding: ``` lldb-unit :: SymbolFile/PDB/./SymbolFilePDBTests.exe/SymbolFilePDBTests/TestMaxMatches ``` This test was testing the wrong thing. From the looks of `SymbolFilePDBTests::TestMaxMatches(...)` I thought it was finding multiple matches when we didn't ask for a

[Lldb-commits] [lldb] [lldb-dap] Emit more structured info along with variables (PR #75244)

@@ -165,7 +173,14 @@ def do_test_scopes_variables_setVariable_evaluate( "hasVariablesReference": True, }, "pt": { -"equals": {"type": "PointType"}, +"equals": { +"type": "PointType", +

[Lldb-commits] [lldb] Make only one function that needs to be implemented when searching for types (PR #74786)

clayborg wrote: > > If we need to expected fail the python test on window until we can look > > into it, I would vote to do this. > > As it happens, I'm using the buildbot machine to reproduce this. So it's not > doing any more builds for now. I'll put in workarounds if I don't find the >

[Lldb-commits] [lldb] Add option to pass thread ID to thread select command (PR #73596)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/73596 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

https://github.com/clayborg commented: My suggestions would be: - don't move any C++ files, just leave them where they are - make a directory that can be copied into `~/.vscode/extensions` as is so that creating the extension doesn't involve grabbing files from many locations - `git move` any

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

@@ -27,58 +31,43 @@ get a full featured debugger with a well defined protocol. # Installation for Visual Studio Code -Installing the plug-in involves creating a directory in any location outside of -`~/.vscode/extensions`. For example, `~/vscode-lldb` is a valid one. You'll

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

@@ -0,0 +1,21 @@ +import * as vscode from 'vscode'; clayborg wrote: Wanted to mention again that maybe we make a directory that contains the needed typescript sources that will be in the exact format needed for installing an extension? So if we have

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/75515 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Create a typescript extension for lldb-dap (PR #75515)

@@ -0,0 +1,5 @@ +out +node_modules +.vscode-test +*.vsix +!.vscode clayborg wrote: Can we just create a `vscode` folder (no leading `.`) and remove this file? Why do we need `out` and `node_modlues` to be added to this? Does `npm` create temp files here for

[Lldb-commits] [lldb] [lldb-dap] Emit more structured info along with variables (PR #75244)

@@ -153,10 +153,18 @@ def do_test_scopes_variables_setVariable_evaluate( buffer_children = make_buffer_verify_dict(0, 32) verify_locals = { "argc": { -"equals": {"type": "int", "value": "1"}, -"declaration": { -

[Lldb-commits] [lldb] [lldb-dap] Emit more structured info along with variables (PR #75244)

@@ -1133,63 +1175,64 @@ llvm::json::Value CreateVariable(lldb::SBValue v, int64_t variablesReference, int64_t varID, bool format_hex, bool is_name_duplicated, std::optional

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

@@ -11,40 +11,81 @@ namespace lldb_dap { -void RunLLDBCommands(llvm::StringRef prefix, +bool RunLLDBCommands(llvm::StringRef prefix, const llvm::ArrayRef , - llvm::raw_ostream ) { + llvm::raw_ostream , bool

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

@@ -434,20 +434,54 @@ ExpressionContext DAP::DetectExpressionContext(lldb::SBFrame , return ExpressionContext::Variable; } -void DAP::RunLLDBCommands(llvm::StringRef prefix, - const std::vector ) { - SendOutput(OutputType::Console, -

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

https://github.com/clayborg approved this pull request. Just fix an init as suggested and this is good to go. https://github.com/llvm/llvm-project/pull/74808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [lldb] [lldb-dap] Implement command directives (PR #74808)

https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/74808 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix a crash from character type confusion interaction with libedit (PR #75388)

https://github.com/clayborg closed https://github.com/llvm/llvm-project/pull/75388 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

<    3   4   5   6   7   8   9   10   11   12   >