[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-07 Thread Aaron Ballman via cfe-commits
__ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Report erroneous floating point results in _Complex math (PR #90588)

2024-06-07 Thread Joshua Cranmer via cfe-commits
https://github.com/jcranmer-intel approved this pull request. https://github.com/llvm/llvm-project/pull/90588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add WarnOnSizeOfPointer mode to bugprone-sizeof-expression (PR #94356)

2024-06-07 Thread Donát Nagy via cfe-commits
.../clang-tidy/bugprone/SizeofExpressionCheck.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp index 1cb721d89fc9b..c25ee42d0899a 100644 --- a/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/SizeofExpressionCheck.cpp @@ -177,8 +177,7 @@ void SizeofExpressionCheck::registerMatchers(MatchFinder *Finder) { const auto ZeroLiteral = ignoringParenImpCasts(integerLiteral(equals(0))); const auto SubscriptExprWithZeroIndex = -arraySubscriptExpr( -hasIndex(ZeroLiteral)); +arraySubscriptExpr(hasIndex(ZeroLiteral)); const auto DerefExpr = ignoringParenImpCasts(unaryOperator(hasOperatorName("*"))); ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
, strTy, intTy, intTy, boxTy, refTy, i1Ty}, clementval wrote: Let me double check that. I have probably messade up smth here https://github.com/llvm/llvm-project/pull/94771 ___ llvm-branch-commits mailing list llvm-branch-commits

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

2024-06-07 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/94679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-07 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: FYI in the libc++ CI we've been running the LLDB tests for a few months now and I haven't seen a single unrelated failure. https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-07 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: >From my side as an author of the PR, I want to see Clang and LLDB code owners >agree on the way forward, then I'll implement it if I can. https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-c

[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

2024-06-07 Thread Shivam Gupta via lldb-commits
ur suggested. https://github.com/llvm/llvm-project/pull/94775 _______ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in Platform/Android/PlatformAndroid.cpp (PR #94785)

2024-06-07 Thread via lldb-commits
tAdbClient(error)); `` https://github.com/llvm/llvm-project/pull/94785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[clang] [llvm] [Clang] Introduce [[clang::structured_concurrency]] (PR #94693)

2024-06-07 Thread via cfe-commits
roIdElider CIE(CII, FEI, AA, DT, PDT, ORE); Changed |= CIE.attemptElide(); } diff --git a/llvm/lib/Transforms/Coroutines/Coroutines.cpp b/llvm/lib/Transforms/Coroutines/Coroutines.cpp index 1a92bc1636257..48c02e5406b75 100644 --- a/llvm/lib/Transforms/Coroutines/Coroutines.cpp +++ b/llvm/lib/Transforms/Coroutines/Coroutines.cpp @@ -86,6 +86,7 @@ static const char *const CoroIntrinsics[] = { "llvm.coro.prepare.retcon", "llvm.coro.promise", "llvm.coro.resume", +"llvm.coro.safe.elide", "llvm.coro.save", "llvm.coro.size", "llvm.coro.subfn.addr", `` https://github.com/llvm/llvm-project/pull/94693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in Platform/Android/PlatformAndroid.cpp (PR #94785)

2024-06-07 Thread Shivam Gupta via lldb-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/94785 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in Platform/Android/PlatformAndroid.cpp (PR #94785)

2024-06-07 Thread Shivam Gupta via lldb-commits
____ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[jenkinsci/anka-build-plugin]

2024-06-07 Thread 'Artur Melanchyk' via Jenkins Commits
are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-07 Thread Paul Kirth via cfe-commits
/pull/94717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[jenkinsci/anka-build-plugin]

2024-06-07 Thread 'Artur Melanchyk' via Jenkins Commits
are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/

[jenkinsci/jenkins] a8aaab: Bump org.jenkins-ci:jenkins from 1.115 to 1.116

2024-06-07 Thread 'dependabot[bot]' via Jenkins Commits
(https://github.com/jenkinsci/pom/releases) - [Changelog](https://github.com/jenkinsci/pom/blob/master/CHANGELOG-old.md) - [Commits](https://github.com/jenkinsci/pom/compare/jenkins-1.115...jenkins-1.116) --- updated-dependencies: - dependency-name: org.jenkins-ci:jenkins dependenc

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-06-07 Thread David Blaikie via cfe-commits
parate patch, but probably one worth doing) - again, if/where possible, it'd be nice if these things aligned/involved fewer special cases and inconsistencies. https://github.com/llvm/llvm-project/pull/75912 ___ cfe-commits mailing list cfe-c

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-07 Thread Aaron Ballman via cfe-commits
. That said, if others aren't as concerned about test flakiness, I won't block progress on this PR. https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in lldb/source/Host/linux/Host.cpp (PR #94783)

2024-06-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. Similar concern as https://github.com/llvm/llvm-project/pull/94775#issuecomment-2155285000 https://github.com/llvm/llvm-project/pull/94783 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in Python/Interfaces/ScriptedPythonInterface.h (PR #94779)

2024-06-07 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere requested changes to this pull request. Similar comment as https://github.com/llvm/llvm-project/pull/94775#issuecomment-2155285000 https://github.com/llvm/llvm-project/pull/94779 ___ lldb-commits mailing list lldb

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-07 Thread Paul Kirth via cfe-commits
t;, ``` or ```suggestion "directory": ".", ``` https://github.com/llvm/llvm-project/pull/93928 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-07 Thread Paul Kirth via cfe-commits
ng++ -o Calculator.o -I../include ../src/Calculator.cpp", ``` This can be relative too. Same in other lines. https://github.com/llvm/llvm-project/pull/93928 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-07 Thread Paul Kirth via cfe-commits
ests, whenever possible. https://github.com/llvm/llvm-project/pull/93928 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-07 Thread Paul Kirth via cfe-commits
ter. https://github.com/llvm/llvm-project/pull/93928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-07 Thread Paul Kirth via cfe-commits
l to use a `.test` extension in files that are only used to hold the `RUN`/`CHECK` lines. `lld/test/ELF` has a lot of examples like that. I'm sure there are others too. https://github.com/llvm/llvm-project/pull/93928 ___ cfe-commits mailing list cfe

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-07 Thread Paul Kirth via cfe-commits
___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-06-07 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/93928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in lldb/source/Host/linux/Host.cpp (PR #94783)

2024-06-07 Thread via lldb-commits
grp, _fields.session, _fields.tty_nr, _fields.tpgid, _fields.flags, `` https://github.com/llvm/llvm-project/pull/94783 _______ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Slava Zakharin via llvm-branch-commits
, strTy, intTy, intTy, boxTy, refTy, i1Ty}, vzakhari wrote: The first argument is a box reference here but not in the non-dim case. https://github.com/llvm/llvm-project/pull/94771 ___ llvm-branch-commits mailing list llvm-branch-commits

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in lldb/source/Host/linux/Host.cpp (PR #94783)

2024-06-07 Thread Shivam Gupta via lldb-commits
d %d %d %u %lu %lu %lu %lu %lu %lu %ld %ld", _fields.pid, stat_fields.comm, _fields.state, _fields.ppid, _fields.pgrp, _fields.session, _fields.tty_nr, _fields.tpgid, _fields.flags, _______ lldb-commits ma

[clang] [clang] Add fixit for using declaration with a (qualified) namespace (PR #94762)

2024-06-07 Thread Nico Weber via cfe-commits
https://github.com/nico closed https://github.com/llvm/llvm-project/pull/94762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2c047e6 - [clang] Add fixit for using declaration with a (qualified) namespace (#94762)

2024-06-07 Thread via cfe-commits
name}} using cwg460::X; // expected-error@-1 {{using declaration cannot refer to a namespace}} +// expected-note@-2 {{did you mean 'using namespace'?}} using X::Q; // expected-error@-1 {{using declaration cannot refer to a namespace}} +// expected-note@-2 {{did you me

[clang] Fix spurious non-strict availability warning (PR #94377)

2024-06-07 Thread Helena Kotas via cfe-commits
https://github.com/hekota commented: LGTM! https://github.com/llvm/llvm-project/pull/94377 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Slava Zakharin via llvm-branch-commits
lvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_omp_wait_deps); +Builder.CreateCall( +TaskWaitFn, +{Ident, ThreadID, Builder.getInt32(Dependencies.size()), DepArray, Meinersbur wrote: Can you document the members like above? `/*loc_ref=*/Ident, /*gtid=*/...` https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
, +LLVM::ModuleTranslation , +SmallVector ) { Meinersbur wrote: ```suggestion SmallVectorImpl ) { ``` https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
alue *TaskSize = Builder.getInt64( +divideCeil(M.getDataLayout().getTypeSizeInBits(Task), 8)); Meinersbur wrote: ```suggestion Value *TaskSize = Builder.getInt64( M.getDataLayout().getTypeStoreSize(Task)); ``` There usually isn't a reason to manually divide by 8. https://

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
B, TargetTaskAllocaBB->begin()); InsertPointTy TargetTaskBodyIP(TargetTaskBodyBB, TargetTaskBodyBB->begin()); ``` I don't really have an opinion on which is better, but others may prefer this form since it is shorter. https://github.com/llvm/llvm-project/pull/93977 _____

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
e > element has to allocate its full internal array (e.g. 8 times the object size > on 64-bit libstdc++; 16 times the object size or 4096 bytes, whichever is > larger, on 64-bit libc++). https://github.com/llvm/llvm-project/pull/93977 ___________

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
OpenMPIRBuilder::GenMapInfoCallbackTy GenMapInfoCB) { +StaleCI->eraseFromParent(); +while (!ToBeDeleted.empty()) { + ToBeDeleted.top()->eraseFromParent(); + ToBeDeleted.pop(); +} Meinersbur wrote: ```suggestion llvm::for_each(ToBeDeleted, [](Instruction *I) { I->ereaseFromParent(); } ); ``` https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
s) { +AllocaInst *ArgStructAlloca = +dyn_cast(StaleCI->getArgOperand(1)); Meinersbur wrote: ```suggestion auto *ArgStructAlloca = dyn_cast(StaleCI->getArgOperand(1)); ``` https://github.com/llvm/llvm-project/pull/93977 ______

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
@.omp_target_task_proxy_func(i32 %thread.id, ptr %task) /// This function is called from emitTargetTask once the /// code to launch the target kernel has been outlined already. ``` https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
/load doesn't have the align set explicitly, `memcpy` should apply pointer alignment itself. https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
uot;? https://github.com/llvm/llvm-project/pull/93977 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur commented: Conceptually, looks quite good. Just some style comments. https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
ion. + // + // kernel_launch_function is generated by emitKernelLaunch and has the + // always_inline attribute. void kernel_launch_function(thread_id, Meinersbur wrote: [nit] line break https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing l

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

2024-06-07 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @clayborg that's a cool idea. We might be able to use that to implement `GetOpcodeDataSize`. That would definitely be a separate PR though. https://github.com/llvm/llvm-project/pull/94679 ___ lldb-commits mailing list lldb

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
-project/pull/94771 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[jenkinsci/github-plugin]

2024-06-07 Thread 'Kanstantsin Shautsou' via Jenkins Commits
Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/github-plugin

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Slava Zakharin via llvm-branch-commits
refTy = fir::ReferenceType::get(ty); + auto refBoxTy = fir::ReferenceType::get(boxTy); vzakhari wrote: Then, I guess, this should not be needed as well :) https://github.com/llvm/llvm-project/pull/94771 ___ llvm-branch-commits

[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

2024-06-07 Thread Jonas Devlieghere via lldb-commits
s < max_bit_pos` in the block surrounding it" or something like that. Definitely mention the PR but don't just repeat the warning without enough context to make sense of it. https://github.com/llvm/llvm-project/pull/94775 _______ lldb-commits ma

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in Python/Interfaces/ScriptedPythonInterface.h (PR #94779)

2024-06-07 Thread via lldb-commits
(!has_class_name) return create_error("Missing script class name."); else if (!has_interpreter_dict) `` https://github.com/llvm/llvm-project/pull/94779 _______ lldb-commits mailing list lldb-commits@lists.llvm.org http

[Lldb-commits] [lldb] [LLDB][NFC] Fix a cppcheck warning in Python/Interfaces/ScriptedPythonInterface.h (PR #94779)

2024-06-07 Thread Shivam Gupta via lldb-commits
lse if (!has_interpreter_dict) ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[clang] [OpenMP][NFC] Fix argument order of SourceLocations for allocate clause (PR #94777)

2024-06-07 Thread via cfe-commits
___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][NFC] Fix argument order of SourceLocations for allocate clause (PR #94777)

2024-06-07 Thread Mike Rice via cfe-commits
ion EndLoc) { +SourceLocation LParenLoc, SourceLocation ColonLoc, SourceLocation EndLoc) { if (Allocator) { // OpenMP [2.11.4 allocate Clause, Description] // allocator is an expression of omp_allocator_handle_t type. ___ cfe-commits mail

[clang] [clang-format] Fix bad comment indentation before ifdef after braceless if (PR #94776)

2024-06-07 Thread via cfe-commits
uot;)); +} + TEST_F(FormatTestComments, KeepsLevelOfCommentBeforePPDirective) { // Keep the current level if the comment was originally not aligned with // the preprocessor directive. `` https://github.com/llvm/llvm-project/pull/94776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Thorsten Schütt via cfe-commits
== fltNonfiniteBehavior::NanOnly || +S.nonFiniteBehavior == fltNonfiniteBehavior::NoNanInf) { tschuett wrote: Same here. https://github.com/llvm/llvm-project/pull/94735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Thorsten Schütt via cfe-commits
"Unknown category!"); +if (S.nonFiniteBehavior == fltNonfiniteBehavior::NoNanInf) { tschuett wrote: No redundant braces. https://github.com/llvm/llvm-project/pull/94735 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [clang-format] Fix bad comment indentation before ifdef after braceless if (PR #94776)

2024-06-07 Thread via cfe-commits
). You can also ask questions in a comment on this PR, on the [LLVM Discord](https://discord.com/invite/xS7Z362) or on the [forums](https://discourse.llvm.org/). https://github.com/llvm/llvm-project/pull/94776 _______ cfe-commits mailing list cfe-commits@lists.l

[clang] [clang-format] Fix bad comment indentation before ifdef after braceless if (PR #94776)

2024-06-07 Thread Erich Reitz via cfe-commits
\n" + "/* comment */\n" + "#ifdef A\n" + " int j;\n" + "}")); +} + TEST_F(FormatTestComments, KeepsLevelOfCommentBeforePPDirective) { // Keep the current level if the comment was originally not aligned with // the preprocessor directive. ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm-branch-commits] [clang] [clang] Implement pointer authentication for C++ virtual functions, v-tables, and VTTs (PR #94056)

2024-06-07 Thread Anton Korobeynikov via llvm-branch-commits
er, thanks! https://github.com/llvm/llvm-project/pull/94056 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

2024-06-07 Thread via lldb-commits
gn_bit = llvm::APInt::getSignMask(sign_bit_pos + 1); llvm::APInt bitwize_and = m_integer & sign_bit; if (bitwize_and.getBoolValue()) { `` https://github.com/llvm/llvm-project/pull/94775 ___ lldb-commits mailing list ll

[llvm-branch-commits] [clang] [clang] Implement pointer authentication for C++ virtual functions, v-tables, and VTTs (PR #94056)

2024-06-07 Thread Oliver Hunt via llvm-branch-commits
the "other" discriminator used for the pointer auth schema used for vtable pointers in instances of the requested type` sound? it's more explicit about what is being produced https://github.com/llvm/llvm-project/pull/94056 ___ llvm-branch-commi

[llvm-branch-commits] [clang] [clang] Implement pointer authentication for C++ virtual functions, v-tables, and VTTs (PR #94056)

2024-06-07 Thread Oliver Hunt via llvm-branch-commits
github.com/llvm/llvm-project/pull/94056 ___ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[Lldb-commits] [lldb] [LLDB] [NFC] Fix a cppcheck warning in lldb/source/Utility/Scalar.cpp (PR #94775)

2024-06-07 Thread Shivam Gupta via lldb-commits
.getBoolValue()) { ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[clang] Fix #pragma (packed, n) not emitting the alignment in debug info (PR #94673)

2024-06-07 Thread Augusto Noronha via cfe-commits
https://github.com/augusto2112 closed https://github.com/llvm/llvm-project/pull/94673 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 66df614 - Fix #pragma (packed, n) not emitting the alignment in debug info (#94673)

2024-06-07 Thread via cfe-commits
ignof(MyType2) == 1, "alignof MyType2 is wrong"); + +#pragma pack(1) +struct MyType3 { + int m; +}; +MyType3 mt3; + +static_assert(alignof(MyType3) == 1, "alignof MyType3 is wrong"); _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Dan Liew via cfe-commits
. You could do that as a separate AST test or use the `LateParsing` struct in a way that will make the thread safety analysis emit warnings. https://github.com/llvm/llvm-project/pull/94216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Dan Liew via cfe-commits
https://github.com/delcypher requested changes to this pull request. https://github.com/llvm/llvm-project/pull/94216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Dan Liew via cfe-commits
://github.com/llvm/llvm-project/pull/94216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Dan Liew via cfe-commits
https://github.com/delcypher edited https://github.com/llvm/llvm-project/pull/94216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[jenkinsci/anka-build-plugin]

2024-06-07 Thread 'Artur Melanchyk' via Jenkins Commits
are subscribed to the Google Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/

[jenkinsci/github-plugin]

2024-06-07 Thread 'Kanstantsin Shautsou' via Jenkins Commits
Groups "Jenkins Commits" group. To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-commits+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-commits/jenkinsci/github-plugin

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-07 Thread Matt Arsenault via cfe-commits
he number. +Otherwise returns the greater of the two arguments. -0.0 is considered to +be less than +0.0 for this intrinsic. + +Note that these are the semantics of minimumNumber specified in IEEE 754-2019. -------- arsenm wrote: Copy paste error minimumNumber. Also like above, this is not the signaling nan behavior (where the behavior inverts from quiet nan) https://github.com/llvm/llvm-project/pull/93841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-07 Thread Matt Arsenault via cfe-commits
e number. +Otherwise returns the greater of the two arguments. -0.0 is considered to +be less than +0.0 for this intrinsic. + +Note that these are the semantics of minimumNumber specified in IEEE 754-2019. arsenm wrote: Should also state the explicit difference here, on the intrinsic, the comparison to minnum https://github.com/llvm/llvm-project/pull/93841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-07 Thread Matt Arsenault via cfe-commits
hout https://github.com/llvm/llvm-project/pull/93841 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-07 Thread Matt Arsenault via cfe-commits
n + - qNaN, no excpetion + - NUM, no excpetion + arsenm wrote: cover nan vs. nan case https://github.com/llvm/llvm-project/pull/93841 _______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Intrinsic: introduce minimumnum and maximumnum (PR #93841)

2024-06-07 Thread Matt Arsenault via cfe-commits
n the number. +Otherwise returns the lesser of the two arguments. -0.0 is considered to +be less than +0.0 for this intrinsic. + +Note that these are the semantics of minimumNumber specified in IEEE 754-2019. arsenm wrote: This is not the IEEE semantics for signaling nan. For a signali

[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #94664)

2024-06-07 Thread Andrew Ng via cfe-commits
eGen/CodeGenModule.h index dc24971a3c186..9b63f47ef42cb 100644 --- a/clang/lib/CodeGen/CodeGenModule.h +++ b/clang/lib/CodeGen/CodeGenModule.h @@ -1594,6 +1594,8 @@ class CodeGenModule : public CodeGenTypeCache { } private: + bool shouldDropDLLAttribute(const Decl *D, const llvm::GlobalValue *GV) const; + l

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
___________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
(RTNAME(CppReduceComplex16)); + ExpandAndQuoteKey(RTNAME(CppReduceComplex16Dim)); clementval wrote: No bad change! Thanks for catching it! https://github.com/llvm/llvm-project/pull/94771 ___ llvm-branch-commits mailing list llvm

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Slava Zakharin via llvm-branch-commits
(RTNAME(CppReduceComplex16)); + ExpandAndQuoteKey(RTNAME(CppReduceComplex16Dim)); vzakhari wrote: Is this change intended? https://github.com/llvm/llvm-project/pull/94771 ___ llvm-branch-commits mailing list llvm-branch-commits

[Lldb-commits] [lldb] adcf33f - Revert "Reapply PR/87550 (#94625)"

2024-06-07 Thread Felipe de Azevedo Piovezan via lldb-commits
_setExceptionBreakpoints(const llvm::json::Object ) { // Keep a list of any exception breakpoint filter names that weren't set // so we can clear any exception breakpoints if needed. std::set unset_filters; - for (const auto : *g_dap.exception_breakpoints) + for (const auto : g_dap.exception_breakpoints) unset_filters.insert(bp.filter); for (const auto : *filters) { ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Reapply PR/87550 (PR #94625)

2024-06-07 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: @oontvoo I'm going to revert this for now as the incremental bots are our first line of defense against failures https://github.com/llvm/llvm-project/pull/94625 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https

[clang] [llvm] [CUDA][HIP] warn incompatible redeclare (PR #77359)

2024-06-07 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu edited https://github.com/llvm/llvm-project/pull/77359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

2024-06-07 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/94679 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Encode operands and arity in Dwarf.def and use them in LLDB. (PR #94679)

2024-06-07 Thread Greg Clayton via lldb-commits
___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CUDA][HIP] warn incompatible redeclare (PR #77359)

2024-06-07 Thread Yaxun Liu via cfe-commits
diff --git a/llvm/docs/CompileCudaWithLLVM.rst b/llvm/docs/CompileCudaWithLLVM.rst index 8c468d796660a..0371d7a3bdfcb 100644 --- a/llvm/docs/CompileCudaWithLLVM.rst +++ b/llvm/docs/CompileCudaWithLLVM.rst @@ -427,7 +427,7 @@ To enable these warnings, use the following compiler flag: .. code-block:: console --Woffload-incompatible-redeclare +-Wnvcc-compat Using a Different Class on Host/Device -- ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CUDA][HIP] warn incompatible redeclare (PR #77359)

2024-06-07 Thread Yaxun Liu via cfe-commits
stic nor your > comment make this really clear to me. (Also I'd drop the `It will cause > warning with nvcc` and make the flag something like `-Wnvcc-compat`) sorry. I missed your comments. will rename the flag https://github.com/llvm/llvm-project/pull/77359 ____

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-06-07 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur edited https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread via llvm-branch-commits
1 ___________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[clang] [clang] Report erroneous floating point results in _Complex math (PR #90588)

2024-06-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/90588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Report erroneous floating point results in _Complex math (PR #90588)

2024-06-07 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Changes LGTM unless @jcranmer-intel still has concerns. https://github.com/llvm/llvm-project/pull/90588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[llvm-branch-commits] [flang] [flang] Lower REDUCE intrinsic with DIM argument (PR #94771)

2024-06-07 Thread Valentin Clement バレンタイン クレメン via llvm-branch-commits
ECK: fir.call @_FortranAReduceCharacter4Dim + end module ___________ llvm-branch-commits mailing list llvm-branch-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-branch-commits

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-07 Thread John McCall via cfe-commits
_______ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CUDA][HIP] warn incompatible redeclare (PR #77359)

2024-06-07 Thread Yaxun Liu via cfe-commits
Function Declarations + + +Clang can emit warnings when it detects that host (H) and device (D) functions are declared or defined with the same signature. These warnings are not enabled by default. + +To enable these warnings, use the following compiler flag: + +.. code-block:: console + +-Woffload-incompatible-redeclare + Using a Different Class on Host/Device -- ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    2   3   4   5   6   7   8   9   10   11   >