Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/693#issuecomment-185508713
@ravicodder could you please rebase?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-185509350
Error:
```
09:55:34,147 ERROR org.apache.zeppelin.integration.ZeppelinIT:257 -
Exception in ZeppelinIT while
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/668#issuecomment-185520105
merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/722#issuecomment-185994458
Agreed on the overlap.
Let's merge this for now if there is no more comments.
---
If your project is set up for it, you can reply to this emai
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/697#issuecomment-185996538
it looks like this might have broken the build?
```
[ERROR] COMPILATION ERROR :
[INFO
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/726#issuecomment-186005517
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/719#issuecomment-186020261
FYI - https://s3.amazonaws.com/archive.travis-ci.org/jobs/110282609/log.txt
```
02:08:26,726 INFO org.apache.zeppelin.WebDriverManager:172
GitHub user felixcheung opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/727
[WIP] Get travis to retry download of Spark release
### What is this PR for?
Refactor download and use travis' builtin mechanism to retry on failure -
hopefully it will the
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/727#issuecomment-186383703
https://s3.amazonaws.com/archive.travis-ci.org/jobs/110306654/log.txt
it retried 3 times - 2x timeout after 5 min, 1x partial/corrupted download
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/727#issuecomment-186431206
It passed. I'm going trigger CI a few more times.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user felixcheung closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user felixcheung reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/727
[WIP] Get travis to retry download of Spark release
### What is this PR for?
Refactor download and use travis' builtin mechanism to retry on failure -
hopefully it will
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/727#issuecomment-186503335
Everything still passing, download time has been super fast (like 4 sec) I
will hold and retry on Monday during the day.
---
If your project is set up
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/722#issuecomment-186914966
@jeffsteinmetz you are welcome to look into how the script should be merged
- we would likely keep both of them functional for a release but one script
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/705#issuecomment-186915557
Let's rebase and merge this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/276#issuecomment-186915981
Ping. Would anyone else like to pick this up if we don't hear back from
@raj-bains ?
---
If your project is set up for it, you can reply to this
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/703#issuecomment-186919160
Is this only applicable to Spark interpreter group?
Instead of "per note session" should we say "separate interpreter for each
noteb
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/730#issuecomment-187440281
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-187440655
I guess from the usability point of view, would it be confusing - because
restarting interpreter at a particular paragraph, but all local variables would
GitHub user felixcheung reopened a pull request:
https://github.com/apache/incubator-zeppelin/pull/727
Get travis to retry download of Spark release
### What is this PR for?
Refactor download and use travis' builtin mechanism to retry on failure -
hopefully it will then
Github user felixcheung closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/727
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/739#issuecomment-187505828
Is it feasible to have a copy button? or is it to crowded?
http://fortawesome.github.io/Font-Awesome/icon/clipboard/
---
If your project is set up
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/719#issuecomment-187507463
LGTM. merging if no more comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/719#issuecomment-187507531
if you see `No output has been received in the last 10 minutes` please let
me know
---
If your project is set up for it, you can reply to this email
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/738#issuecomment-187509898
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/727#issuecomment-187510015
more download errors:
https://s3.amazonaws.com/archive.travis-ci.org/jobs/110955308/log.txt
I suspect we should travis_retry build as well
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/727#issuecomment-187510088
Merging this then since it seems to help..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/743#issuecomment-187992008
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/719#issuecomment-188080562
In the post commit build, it looks like Selenium tests are failing because
of "Connection refused" from screen shots. Any idea?
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/703#issuecomment-188101021
big change - only a few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user felixcheung opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/748
Add PR template for github
### What is this PR for?
PR template can be added automatically by GitHub when a PR is opened.
Proposing some changes to PR template wordings
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188663996
yea ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/748#issuecomment-188932693
I think it's useful to have that in contributing.md so newcomers would have
an idea what to expect before actually opening a new PR. We might wa
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/746#issuecomment-189009246
that we would need a job run status API...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/727#issuecomment-189016612
Maybe pre-caching is the only way to make this more stable.. I have seen
more than a few times download fails even after 3 tries either from timing out
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/753#issuecomment-189785676
looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-189785823
@doanduyhai is cassandra supported on windows?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/713#issuecomment-189785882
looks good - great contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-189786658
@prabhjyotsingh probably - we could say 'restart this interpreter X - note
that all interpreter states and local variables will be reset'
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189787467
thx - let's add logger to capture the full stack before returning with
InterpreterResult?
```
logger.error("Invocation target exc
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189801164
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-189802314
btw, it looks like this might be a legitimate test failure, could you take
a look?
https://s3.amazonaws.com/archive.travis-ci.org/jobs/112358128
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-189935535
The last CI failure is because of spark release download timeout.
I think we are good to go - how about we track the Windows Cassandra test
failure
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/749#issuecomment-190965016
what if someone has set JAVA_OPTS in the env? shouldn't we be additive?
---
If your project is set up for it, you can reply to this email and have
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/756#issuecomment-191011315
Shouldn't we say `Ctrl - Shift - + ` instead?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/756#issuecomment-191012508
CI fails with a strange error:
```
Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate
element: {"method":"pa
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-191077565
@Leemoonsoo @corneadoug any more thought on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/756#issuecomment-191075335
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/480#issuecomment-191637577
agreed, and "except" would be rather common.
perhaps @corneadoug would have an suggestion on where to put a button or a
dialog or something
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/749#issuecomment-191638729
That sounds like a reasonable approach, we could say something like
"if you are setting JAVA_OPT, set ZEPPELIN_JAVA_OPTS instead for Zeppelin,
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/692#issuecomment-192082260
@ravicodder could you rebase please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/690#issuecomment-192082267
@ravicodder could you rebase please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/560#issuecomment-192082411
where are we on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/543#issuecomment-192082492
@dcardon @jeffsteinmetz where are we on this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/418#issuecomment-192082652
Where are we on this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/389#issuecomment-192082716
@babokim haven't heard from you - would you be able to continue this work?
---
If your project is set up for it, you can reply to this email and
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/734#issuecomment-192086401
Hmm, interesting. Let's keep this here for now then.
---
If your project is set up for it, you can reply to this email and have your
reply appe
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/754#issuecomment-192706297
LGTM. @echarles what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/749#issuecomment-192706478
looks good. I think we might want to deprecate JAVA_INTP_OPTS and replace
with something more Zeppelin specific for clarify, and allow for admin to
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/827#issuecomment-221025863
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user felixcheung opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/914
[WIP] test - please ignore
### What is this PR for?
Testing another PR in Travis
### What type of PR is it?
### Todos
### What is the Jira issue
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/903#issuecomment-221467057
@mfelgamal thank you for your contributions. As you can see we started a PR
on Livy interpreter about a month and a half ago, and it has recently been
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221467292
thanks, looks like Selenium tests have been busted by a merged code change.
thanks for opening ZEPPELIN-876.
---
If your project is set up for it, you
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/908#issuecomment-221467549
cool - should we have some sort of access control for this later? loading a
jar by POST request on a server seems rather open ;)
---
If your project is
Github user felixcheung closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/914
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/868#issuecomment-221470332
ok, with the same code changes everything passes except selenium, which is
a known test issue.
https://travis-ci.org/apache/incubator-zeppelin/builds
Github user felixcheung commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/918#issuecomment-221789778
cool - should we have the info in documentation?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/944
@mfelgamal could you please close the PR #903?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/747
it looks like error with NPM?
```
[ERROR] npm ERR! Linux 3.13.0-40-generic
[ERROR] npm ERR! argv
"/home/travis/build/apache/incubator-zeppelin/zeppelin-web/node
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
what's our guideline on what is experimental?
should that be added to
https://zeppelin.incubator.apache.org/docs/0.6.0-incubating-SNAPSHOT/rest-api/rest-interpreter.html?
-
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/924
It's not too bad since it is mostly whitespace changes. @doanduyhai could
you review the cassandra changes?
---
If your project is set up for it, you can reply to this emai
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/942
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/941
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/946
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/928
IMHO extending the scala interpreter is preferred instead of creating
another interpreter (%spark.mahout suggestion) since it is very similar..
---
If your project is set up for it
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
sounds good, but how does a contributor/developer decides whether something
new should be annotated as "Experimental" or "ZeppelinApi"?
---
If your project is se
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/868
Can you check the log file?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
Agreed. I think the model used in Spark is that if an API is:
- new
- expecting (significant) discussions/changes in this or the next minor
release
Then it should be
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/940
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/957
WIP?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/958
thanks! we should probably look into download/network errors too.
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/928
Then perhaps it should be a separate one (eg. %mahout)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/917
Hmm... I'm not sure sure we should move to jdk8 completely by default -
there are some interpreters that only runs with jdk7 last time we checked.
Similarly for Scala 2.1, but t
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/928
how would we support different languages in this case? for instance, Apache
Spark can be in Java/Scala/Python/R, Apache Flink can be in Java/Scala/Python,
H2O can be in Java/Python/R
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/921
in the screenshots, what does "interpreter is not set" mean?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/966
LGTM
btw, this is getting fragile - would be great if interpreter can have an
extension mechanism to control what it is mapping to on the js side.
---
If your project is set up
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/970
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
but latest is generally older than the unreleased snapshot build?
for instance, https://zeppelin.incubator.apache.org/docs/latest/ now points
to 0.5.6 release doc, not 0.6.0
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/947
minor question, looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/746
finished my pass on this.
+1 on other's comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user felixcheung commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/953
Right. This is good. I was not sure about the redirect comment above but I
didn't really have a better sol
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/980
From what I see, we should still be able to use most of the existing code.
Could you elaborate more on how bad it would be to support Spark 1.x and 2.x in
the same interpreter code?
---
If
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/966
right, I think that can be added to interpreterSettings and checked on the
frontend similar to this:
https://github.com/apache/zeppelin/blob/09bc8a36a437a2a37736449e330a7594c89f495d
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/988
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/965
should this check for both `/` and `\` then for windows?
https://github.com/apache/zeppelin/pull/965/files#diff-bcbdda87aa29314ed459e8212067e313R528
---
If your project is set up for it
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/868
Are folks still having problems with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/980
+1 on all of that. I think we could work together on a proposal to see what
is the best way to go forward.
I think we are way overdue on separating "programming languages" (and
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/868
That was MapR though, you probably want something like this for CDH:
```
mvn clean package -DskipTests -Pspark-1.6 -Phadoop-2.6
-Dspark.version=1.6.0-cdh5.7.0 -Dhadoop.version=2.6.0
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1011
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1012
Nice! Can this be generalized to not just jdbc?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
1001 - 1100 of 1173 matches
Mail list logo
