Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153083018
--- Diff: resource-managers/kubernetes/core/pom.xml ---
@@ -0,0 +1,94 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://w
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19468#discussion_r153082500
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Constants.scala
---
@@ -0,0 +1,50 @@
+/*
+ * Licensed
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19793#discussion_r153080692
--- Diff:
core/src/test/scala/org/apache/spark/deploy/rest/SubmitRestProtocolSuite.scala
---
@@ -86,6 +86,8 @@ class SubmitRestProtocolSuite extends
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19793
Jenkins, test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19805#discussion_r153080509
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -524,22 +524,41 @@ class Dataset[T] private[sql
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19805#discussion_r153080488
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -524,22 +524,41 @@ class Dataset[T] private[sql
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19805#discussion_r153080504
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -524,22 +524,41 @@ class Dataset[T] private[sql
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19805
could you update the title to add [PYTHON]
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19805
Jenkins, test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19816
yes!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19754#discussion_r153052719
--- Diff: dev/create-release/release-build.sh ---
@@ -392,6 +375,7 @@ if [[ "$1" == "publish-release" ]]; then
find . -t
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2685
thanks, that's useful.
could you look into if we could add a test in
https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/tabledata/tabledata.test.js
?
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19816
I think likely this is a general problem with default shuffle size being
too big on limited resources when in tests (particularly on Windows/AppVeyor).
The additional test failures are expected
Author: felixcheung
Date: Sat Nov 25 03:01:04 2017
New Revision: 23279
Log:
Apache Spark spark-2.2.1-rc2 docs
[This commit notification would consist of 1388 parts,
which exceeds the limit of 50 ones, so it was shortened to the summary
Author: felixcheung
Date: Sat Nov 25 02:44:26 2017
New Revision: 23278
Log:
Apache Spark spark-2.2.1-rc2
Added:
dev/spark/spark-2.2.1-rc2-bin/
dev/spark/spark-2.2.1-rc2-bin/SparkR_2.2.1.tar.gz (with props)
dev/spark/spark-2.2.1-rc2-bin/SparkR_2.2.1.tar.gz.asc
dev/spark/spark
Repository: spark
Updated Branches:
refs/heads/branch-2.2 c3b5df22a -> 455cea622
Preparing Spark release v2.2.1-rc2
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/e30e2698
Tree:
Preparing development version 2.2.2-SNAPSHOT
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/455cea62
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/455cea62
Diff:
Repository: spark
Updated Tags: refs/tags/v2.2.1-rc2 [created] e30e2698a
-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11994#discussion_r153024408
--- Diff: project/MimaExcludes.scala ---
@@ -76,7 +76,10 @@ object MimaExcludes {
// [SPARK-14280] Support Scala 2.12
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/11994#discussion_r153024461
--- Diff:
external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala
---
@@ -59,22 +61,22 @@ class GangliaSink(val
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/11994
what's the next step on this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19775
I agree this is useful to have, @jerryshao is probably right though, it is
likely better to add extensibility into the Metrics system.
@jerryshao I'll review your PR
@matyix could
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19802
I think there are some values in having a better experience with mismatch
client/server versions. We discussed it might be even more common when the
client was a R package (or Python perhaps
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19807
I fixed it during merge and merged this to 2.2.
@jsnowacki thanks and please close this PR.
---
-
To unsubscribe, e-mail
fix typo
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/c3b5df22
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/c3b5df22
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/c3b5df22
Branch:
Repository: spark
Updated Branches:
refs/heads/branch-2.2 ad57141f9 -> c3b5df22a
[SPARK-22495] Fix setup of SPARK_HOME variable on Windows
## What changes were proposed in this pull request?
This is a cherry pick of the original PR 19370 onto branch-2.2 as suggested in
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19807#discussion_r153021890
--- Diff: bin/find-spark-home.cmd ---
@@ -0,0 +1,60 @@
+@echo off
+
+rem
+rem Licensed to the Apache Software Foundation (ASF) under one
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19816#discussion_r153021587
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3021,41 +3021,54 @@ test_that("dapplyCollect() on DataFrame with a
binary c
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19816#discussion_r153021622
--- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
@@ -3078,101 +3091,117 @@ test_that("coalesce, repartition, numParti
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19468
Hi! I think we have quorum at this point.
Not sure if folks are around to review during the holiday, but I plan to do
another final round within a day or so, and merge unless anyone has any
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2668
Is there a way to restart the interpreter process?
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19370
I think the concern is we are adding python dependency for even non python
use cases.
We could track handling missing python better separately. My concerns is
python is not a standard
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19370#discussion_r151880938
--- Diff: bin/find-spark-home.cmd ---
@@ -0,0 +1,49 @@
+@echo off
+
+rem
+rem Licensed to the Apache Software Foundation (ASF) under one
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2374
where are we on this?
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2676
hmm, this is interesting, and likely important.
but given the set of issues related to cron perhaps it makes sense to
rethink the entire auth/role-base access control around here? it feels
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2671
we still want a check in the backend right, since this is a
security/authentication issue.
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2679
this looks reasonable but it is going to work the same in all other
browsers?
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2670
that's odd, anyone knows what's wrong with the build profile?
```
All tests passed.
[WARNING] The requested profile "web-ci" could not be activated because it
does
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2675
well, IMHO `-` and `_` are very common in programming languages too (eg.
python)
I think it's reasonable to accept these two in names.
Not sure about other characters though
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19767
should this go to 2.2?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19257
how is this coming? it will be good to fix this in 2.2?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2653
ah thanks, that seems useful... @1ambda would you like to take a look?
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2650
@Leemoonsoo @1ambda what do you think?
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2663
looks good!
merging if no more comment
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19754
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Repository: zeppelin
Updated Branches:
refs/heads/master 951544a74 -> 717a8c1e7
[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role
### What is this PR for?
For administrator, make new admin role that assigned user can see all notebooks.
### What type of PR is it?
Improvement
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/19754
[BUILD] update release scripts
## What changes were proposed in this pull request?
Change to dist.apache.org instead of home directory
sha512 should have .sha512 extension. From
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/18853#discussion_r151037844
--- Diff: docs/sql-programming-guide.md ---
@@ -1490,6 +1490,13 @@ that these options will be deprecated in future
release as more optimizations ar
Github user felixcheung commented on the pull request:
https://github.com/apache/zeppelin/commit/deadcc77475c15b73470a87c9c07b4dd68b9236b#commitcomment-25617388
In
zeppelin-jupyter/src/main/java/org/apache/zeppelin/jupyter/JupyterUtil.java:
In
zeppelin-jupyter/src/main/java/org
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2663
is there something wrong? Jenkins not kicking off?
---
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2663
merging if no more comment
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19739
as RM, I'd say big -100 :)
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Author: felixcheung
Date: Tue Nov 14 04:30:04 2017
New Revision: 23090
Log:
Apache Spark spark-2.2.1-rc1
[This commit notification would consist of 1388 parts,
which exceeds the limit of 50 ones, so it was shortened to the summary
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19695
Sorry I didnât see it before tagging
Please go ahead
---
-
To unsubscribe, e-mail: reviews-unsubscr
Preparing development version 2.2.2-SNAPSHOT
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/af0b1855
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/af0b1855
Diff:
Repository: spark
Updated Branches:
refs/heads/branch-2.2 c68b4c54f -> af0b1855f
Preparing Spark release v2.2.1-rc1
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/41116ab7
Tree:
Repository: spark
Updated Tags: refs/tags/v2.2.1-rc1 [created] 41116ab7f
-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
Repository: spark
Updated Tags: refs/tags/v2.2.1-rc1 [deleted] 124b9a106
-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
Repository: spark
Updated Branches:
refs/heads/branch-2.2 b1f8c84ef -> c68b4c54f (forced update)
-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
Repository: spark
Updated Tags: refs/tags/v2.2.1-rc1 [created] 124b9a106
-
To unsubscribe, e-mail: commits-unsubscr...@spark.apache.org
For additional commands, e-mail: commits-h...@spark.apache.org
Preparing development version 2.2.2-SNAPSHOT
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/b1f8c84e
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/b1f8c84e
Diff:
Repository: spark
Updated Branches:
refs/heads/branch-2.2 c68b4c54f -> b1f8c84ef
Preparing Spark release v2.2.1-rc1
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/124b9a10
Tree:
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19734
@viirya could you take a look
https://amplab.cs.berkeley.edu/jenkins/job/spark-branch-2.2-compile-sbt-scala-2.10/724
Repository: spark
Updated Branches:
refs/heads/branch-2.2 8acd02f42 -> f73637798
[SPARK-22442][SQL][BRANCH-2.2] ScalaReflection should produce correct field
names for special characters
## What changes were proposed in this pull request?
For a class with field name of special characters,
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19734
merged to 2.2
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19734
ok thanks, I'm above to tag 2.2.1. technically this isn't a regression but
I could wait for a few hours (need to wait for jenkins build from the branch)
if we could merge this ASAP
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19722
merged to master/cherry pick to 2.2
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Repository: spark
Updated Branches:
refs/heads/master 9bf696dbe -> 3d90b2cb3
[SPARK-21693][R][ML] Reduce max iterations in Linear SVM test in R to speed up
AppVeyor build
## What changes were proposed in this pull request?
This PR proposes to reduce max iteration in Linear SVM test in
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19723
thanks, @gatorsmile you can close this PR
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19732
merged to 2.2
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/19732
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
xcheun...@hotmail.com>
Closes #19732 from felixcheung/fixmesosdriverconstraint.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/2a04cfaa
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/2a04cfaa
Diff: http:
GitHub user felixcheung opened a pull request:
https://github.com/apache/spark/pull/19732
[2.2] fix mesos break
## What changes were proposed in this pull request?
Fix break from cherry pick
## How was this patch tested?
Jenkins
You can merge this pull
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19543
thanks @susanxhuynh
merged this to master.
the cherry pick to 2.2 was non-trivial, but merged, please keep an eye for
this and please help test 2.2.1
Repository: spark
Updated Branches:
refs/heads/branch-2.2 4ef0bef9e -> f6ee3d90d
[SPARK-19606][MESOS] Support constraints in spark-dispatcher
A discussed in SPARK-19606, the addition of a new config property named
"spark.mesos.constraints.driver" for constraining drivers running on a Mesos
Repository: spark
Updated Branches:
refs/heads/master 21a7bfd5c -> b3f9dbf48
[SPARK-19606][MESOS] Support constraints in spark-dispatcher
## What changes were proposed in this pull request?
A discussed in SPARK-19606, the addition of a new config property named
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19543
@susanxhuynh, @ttashi-rms, @ArtRand please take a look
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19713
Sounds like we should have for 2.2.1
Iâm looking at cutting 2.2.1 ASAP, could someone backport this and tag me
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19722
LGTM cool stuff, if we get the same result in less iterations
Letâs get this into 2.2 as well
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2585
merging if no more comment
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19543
add to white list
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2585
ok thanks
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19543
Jenkins, retest this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user felixcheung commented on a diff in the pull request:
https://github.com/apache/spark/pull/19543#discussion_r150376571
--- Diff:
resource-managers/mesos/src/main/scala/org/apache/spark/deploy/mesos/config.scala
---
@@ -122,4 +122,11 @@ package object config
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19657
thanks! merged to master, 2.2.
2.1 attempt had conflict, so leaving that out for now.
---
-
To unsubscribe, e-mail
tested?
manually by building package
Jenkins, AppVeyor
Author: Felix Cheung <felixcheun...@hotmail.com>
Closes #19657 from felixcheung/rinstalldir.
(cherry picked from commit b70aa9e08b4476746e912c2c2a8b7bdd102305e8)
Signed-off-by: Felix Cheung <felixche...@apache.org>
Project: http://gi
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19701
thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2585
could you check if it's related?
https://travis-ci.org/yu74n/zeppelin/builds/299517426
---
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19515
@pmackles perhaps you could email this to d...@spark.apache.org to get some
visibility to this and hopefully someone else on the mesos side can review
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19515
@susanxhuynh or anyone from the mesos side would you please review?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19543
@susanxhuynh or anyone from the mesos side would you please review?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19515
Jenkins, test this please
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
GitHub user felixcheung reopened a pull request:
https://github.com/apache/spark/pull/19657
[SPARK-22344][SPARKR] clean up install dir if running test as source package
## What changes were proposed in this pull request?
remove spark if spark downloaded & insta
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/19657
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19657
ouch
```
Error in packageVersion("knitr") : package 'knitr' not found
[00:03:37] Execut
Github user felixcheung closed the pull request at:
https://github.com/apache/spark/pull/19657
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19657
ok thanks, in that case, would you mind cherry pick these changes into your
account to run under appveyor - fixing test run is lower priority than getting
this merged to kick off 2.2.1
GitHub user felixcheung reopened a pull request:
https://github.com/apache/spark/pull/19657
[SPARK-22344][SPARKR] clean up install dir if running test as source package
## What changes were proposed in this pull request?
remove spark if spark downloaded & insta
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19468
ping @jiangxb1987
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user felixcheung commented on the issue:
https://github.com/apache/spark/pull/19657
@HyukjinKwon hey I think the appveyor test pass is just timing out after 1
hr 30 min - is there a way to up the timeout
1301 - 1400 of 6371 matches
Mail list logo
