Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19735
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19711#discussion_r150712289
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ui/SQLListener.scala ---
@@ -113,7 +116,7 @@ class SQLListener(conf: SparkConf) extends
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19633#discussion_r150746876
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -424,11 +424,19 @@ case class FileSourceScanExec
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r150752055
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -216,7 +216,9 @@ private[spark] object
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r150751761
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -92,6 +92,11 @@ object SparkSubmit extends CommandLineUtils with Logging
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r150751268
--- Diff: core/src/main/scala/org/apache/spark/SecurityManager.scala ---
@@ -551,13 +553,10 @@ private[spark] class SecurityManager(
private
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r151015745
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -412,8 +412,6 @@ class SparkContext(config: SparkConf) extends Logging
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r151017494
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -216,7 +216,9 @@ private[spark] object
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r151018454
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -745,15 +739,20 @@ private[spark] class Client
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19741
From my understanding, the above exception seems no harm to the Spark
application, just running into some threading corner case during stop, am I
right
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19741#discussion_r151305271
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
---
@@ -268,8 +268,13 @@ private[spark
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19643#discussion_r151307924
--- Diff: core/src/main/scala/org/apache/spark/SparkContext.scala ---
@@ -1838,12 +1852,21 @@ class SparkContext(config: SparkConf) extends
Logging
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19633#discussion_r151308496
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
---
@@ -424,11 +424,19 @@ case class FileSourceScanExec
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19631#discussion_r151320052
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -216,7 +216,9 @@ private[spark] object
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19631
Did another round of review, LGTM overall. @tgravescs do you any comment?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19788
@yucai would you mind adding more explanations to your PR description?
---
-
To unsubscribe, e-mail: reviews-unsubscr
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19788
Sure, I will do it tomorrow.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19788
ok to test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152891172
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -196,12 +196,14 @@ private[spark] class
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152891438
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -196,12 +196,14 @@ private[spark] class
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152891792
--- Diff: core/src/main/scala/org/apache/spark/MapOutputTracker.scala ---
@@ -812,10 +812,13 @@ private[spark] object MapOutputTracker extends
Logging
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r152891920
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -196,12 +196,14 @@ private[spark] class
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19802
Can you please explain more, and how to reproduce this issue? Spark's RPC
is not designed for version compatible.
---
---
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19775
Do we have to put this in Spark, is it a necessary part of k8s? I think if
we pull in that PR(https://github.com/apache/spark/pull/11994), then this can
be stayed out of Spark as a package. Even
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19788#discussion_r153089584
--- Diff:
core/src/main/scala/org/apache/spark/shuffle/IndexShuffleBlockResolver.scala ---
@@ -196,12 +196,14 @@ private[spark] class
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
@felixcheung thanks for your reviewing. I think there's no next step,
current changes should be enough for user to externalize customized metrics
source and
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/11994#discussion_r153110760
--- Diff: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
---
@@ -195,18 +196,26 @@ private[spark] class MetricsSystem private
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19788
@yucai I'm thinking of the necessity to add this new configuration
`spark.shuffle.continuousFetch` like you mentioned above. This PR you proposed
is actually a superset of previous way,
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/11994
@rxin , thanks for your comment. The key motivation of this PR is to expose
the metrics Sink/Source interface for third-party plugins, so that we don't
need to maintain every different
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19717
I think we'd better to honor newly added
`org.apache.spark.deploy.SparkApplication` to implement k8s client, like #
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153407820
--- Diff: core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala ---
@@ -702,6 +715,19 @@ object SparkSubmit extends CommandLineUtils with
Logging
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153408859
--- Diff:
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
@@ -590,6 +600,11 @@ private[deploy] class SparkSubmitArguments(args
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153408574
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153410482
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/steps/BaseDriverConfigurationStep.scala
---
@@ -0,0 +1,162
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153407637
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19812
Hi @liutang123 would you mind explaining us the issue you met and how to
reproduce it? Currently we don't know what actual issue it is and how to
evaluate your ch
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r153678912
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
---
@@ -0,0 +1,160 @@
+/*
+ * Licensed to
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19834
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19812
Does this failure ". For some reason, all of the 3 executors failed. "
happened during task running or before task submission? Besides, if you're
running on yarn, yarn will bring n
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19631
LGTM.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19856
I guess the original purpose of such log is to reflect the behavior of
consumer connection. It is not super necessary to do such trivial change. Also
`ReliableKafkaReceiver` is not recommended
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19856
Actually there's no issue here, IMHO I think your understanding of this log
is slightly different from the original pu
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19856
>I think the log can't reflect the behavior of consumer connection,because
consumer.create doesn't do any connect,it only construct a
ZookeeperConsumerConnector instance
Th
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19840
I think in YARN we have several different ways to set `PYSPARK_PYTHON`, I
guess your issue is that which one should take priority?
Can you please:
1. Define a consistent ordering
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19840
Oh, I see. You're running in client mode. So this one `--conf
spark.yarn.appMasterEnv.PYSPARK_PYTHON=py3.zip/py3/bin/python` is useless.
So I guess the behavior is expected. Be
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19840
I'm a little concerned about such changes, this may be misconfigured to
introduce the discrepancy between driver python and executor python, at least
we should honor this configur
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19885
@merlintang would you please add the problem to your PR description,
currently it is a WASB problem in which userInfo is honored to differentiate
filesystems. Please add the scenario to the
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19885#discussion_r154822603
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -1428,6 +1428,12 @@ private object Client extends
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19885
@vanzin please help to review, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19885
Is this assumption based on the implementation of Hadoop `FileSystem`? I
was thinking that wasb is an exception, for other we still keep the original
code.
@steveloughran would you
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19885
ok to test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154871648
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2744,6 +2744,25 @@ private[spark] object Utils extends Logging
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154872371
--- Diff: docs/running-on-yarn.md ---
@@ -234,18 +234,11 @@ To use a custom metrics.properties for the
application master and executors, upd
The
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154870951
--- Diff: core/src/main/scala/org/apache/spark/util/Utils.scala ---
@@ -2744,6 +2744,25 @@ private[spark] object Utils extends Logging
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154874378
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/Client.scala
---
@@ -0,0 +1,234
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r154875878
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/DriverConfigurationStepsOrchestrator.scala
---
@@ -0,0
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19885
I still have a question about it, URIs for HDFS like
`hdfs://us...@nn1.com:8020` and `hdfs://us...@nn1.com:8020` , do we honor
userInfo for HDFS filesystems, are they two HDFS clusters, or just
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/19717#discussion_r155125699
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/Client.scala
---
@@ -0,0 +1,234
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19885
>User info isn't picked up from the URL, it's taken off your Kerberos
credentials. If you are running HDFS unkerberized, then UGI takes it from the
environment variable HAD
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/19885
I see. Thanks for the explanation @steveloughran . My concern is that
current changes will affect all the filesystems, but we only saw this issue in
wasb. So limiting authority comparison to only
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/22434
[SPARK-24685][BUILD][FOLLOWUP] Fix the nonexist profile name in release
script
## What changes were proposed in this pull request?
`without-hadoop` profile doesn't exist in
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/22434
@cloud-fan @vanzin , please help to review, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/22441
Is it possible to test this on Jenkins?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21138
Hi @mridulm , thanks a lot for your comments.
UGI.loginUserFromKeytab is not existed any more in Spark 2.3+
(https://github.com/apache/spark/commit
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21088
ok to test.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21138
@mridulm I would treat the current fix as a workaround for SASL issue,
since it is a regression in 2.3.
For UGI refreshing issue (mainly cause STS long running failure, also lead
to SASL
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21138
Thanks for the review @mridulm @vanzin . Let me test again. I will merge
the code when test is passed.
---
-
To unsubscribe
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21138
Jenkins, retest this please.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21138
Merging to master and branch 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21152#discussion_r184315510
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala
---
@@ -66,157 +66,115 @@ class ContinuousSuite
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21152#discussion_r184316769
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/continuous/ContinuousSuite.scala
---
@@ -66,157 +66,115 @@ class ContinuousSuite
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21166
Can you please check again with latest master code, I doubt the issue is
not valid any more in the latest code.
---
-
To
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21168
The change is fail to build, please fix it.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/21178
[SPARK-24110][Thrift-Server] Avoid UGI.loginUserFromKeytab in STS
## What changes were proposed in this pull request?
Spark ThriftServer will call UGI.loginUserFromKeytab twice in
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21178
Ping @mridulm , please help to review, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r184672313
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java
---
@@ -362,4 +371,34 @@ public static void
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r184833381
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java
---
@@ -18,14 +18,11 @@
package
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r184833443
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
---
@@ -52,8 +52,22 @@ private[hive
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r184833705
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java
---
@@ -362,4 +371,34 @@ public static void
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21166
1. We improve the DAGScheduler to always send TaskEnd message. So the issue
I found before may not be valid.
2. We refactored the LiveListenerQueue to make it more robust for internal
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21152
LGTM. Merging to master.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21152
@HeartSaVioR what is your JIRA id?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands
GitHub user jerryshao opened a pull request:
https://github.com/apache/spark/pull/21188
[SPARK-24046][SS] Fix rate source rowsPerSecond <= rampUpTime corner case
## What changes were proposed in this pull request?
Current Rate source has some issues when calculat
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r184844613
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java
---
@@ -362,4 +371,34 @@ public static void
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21188
Isn't this a flat ramp-up smoothly increasing the rows per second? Your
proposal is another solution, but just two op
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21178
@mridulm , can you review again? Thanks a lot.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r185407534
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java
---
@@ -92,7 +95,26 @@ public String getAuthName
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r185427751
--- Diff:
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java
---
@@ -92,7 +95,26 @@ public String getAuthName
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21178#discussion_r185432085
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
---
@@ -52,8 +52,22 @@ private[hive
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21178
Thanks @mridulm for your review, really appreciated!
Merging to master branch.
---
-
To unsubscribe, e-mail: reviews
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21216
I'm not so familiar with federated HDFS, but is it transparent to the
downside applications like Spark, or Spark should know all the configured NNs?
If it is transparent, then I think the
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20761
Hi @szyszy are you still going to work on this PR?
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/20761
Cool, thanks!
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21207
LGTM. Merging to master branch.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21216#discussion_r186015828
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala
---
@@ -196,11 +196,17 @@ object
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21216#discussion_r186059087
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/YarnSparkHadoopUtil.scala
---
@@ -196,11 +196,17 @@ object
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21245
LGTM, merging to master and branch 2.3.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional
Github user jerryshao commented on the issue:
https://github.com/apache/spark/pull/21243
What kind of exceptions will client AM meet usually? I think the logic is
quite simple for client AM, just wondering what kind of issue will it meet
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21243#discussion_r186633839
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/ApplicationMaster.scala
---
@@ -389,37 +389,40 @@ private[spark] class
Github user jerryshao commented on a diff in the pull request:
https://github.com/apache/spark/pull/21243#discussion_r186634159
--- Diff:
resource-managers/yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
---
@@ -1073,14 +1074,14 @@ private[spark] class Client
901 - 1000 of 1081 matches
Mail list logo
